Re: [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper

2024-01-23 Thread Cédric Le Goater
_name); +aspeed_machine_class_init_cpus_defaults(mc); } static void fby35_reset(MachineState *state, ShutdownCause reason) @@ -1515,6 +1502,7 @@ static void aspeed_machine_fby35_class_init(ObjectClass *oc, void *data) amc->i2c_init = fby35_i2c_init; /* FIXME: Replace this macro with somethin

Re: [PATCH v2 2/5] hw/arm/aspeed: Set default CPU count using aspeed_soc_num_cpus()

2024-01-23 Thread Cédric Le Goater
oc: Add AST1030 support") and supermicrox11-bmc (commit 40a38df55e "hw/arm/aspeed: Add board model for Supermicro X11 BMC") machines. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 5 - 1 file changed, 4 insertions(+),

Re: [PATCH v2 1/5] hw/arm/aspeed: Remove dead code

2024-01-23 Thread Cédric Le Goater
On 1/23/24 23:48, Philippe Mathieu-Daudé wrote: Remove copy/paste typo from commit 6c323aba40 ("hw/arm/aspeed: Adding new machine Tiogapass in QEMU"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 1 - 1 file

Re: [PATCH] target/ppc: Fix crash on machine check caused by ifetch

2024-01-23 Thread Cédric Le Goater
On 1/7/24 18:05, Nicholas Piggin wrote: is_prefix_insn_excp() loads the first word of the instruction address which caused an exception, to determine whether or not it was prefixed so the prefix bit can be set in [H]SRR1. In case it was the instruction fetch itself that caused the exception,

Re: [PATCH rfcv1 4/6] vfio: initialize IOMMUFDDevice and pass to vIOMMU

2024-01-23 Thread Cédric Le Goater
On 1/23/24 10:46, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Subject: Re: [PATCH rfcv1 4/6] vfio: initialize IOMMUFDDevice and pass to vIOMMU On 1/15/24 11:13, Zhenzhong Duan wrote: Initialize IOMMUFDDevice in vfio and pass to vIOMMU, so that vIOMMU could get

Re: [PATCH] hw/pci-host/raven.c: Mark raven_io_ops as implementing unaligned accesses

2024-01-23 Thread Cédric Le Goater
e raven MR to correctly mark it as handling unaligned accesses itself. Tested with 'make check' and 'make check-avocado' only. It doesn't affect the prep machine boot with OpenBIOS and a "Debian GNU/Linux 3.0 6015" image. Tested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Thanks,

Re: [PATCH] target/ppc: Fix crash on machine check caused by ifetch

2024-01-23 Thread Cédric Le Goater
55a7fa34f89 ("target/ppc: Machine check on invalid real address access on POWER9/10") Fixes: 5a5d3b23cb2 ("target/ppc: Add SRR1 prefix indication to interrupt handlers") Signed-off-by: Nicholas Piggin Ack-by: Cédric Le Goater Thanks, C. --- target/ppc/excp_helper.c |

Re: [PATCH 1/3] virtio_iommu: Clear IOMMUPciBus pointer cache when system reset

2024-01-23 Thread Cédric Le Goater
On 1/22/24 07:40, Zhenzhong Duan wrote: IOMMUPciBus pointer cache is indexed by bus number, bus number may not always be a fixed value, i.e., guest reboot to different kernel which set bus number with different algorithm. This could lead to endpoint binding to wrong iommu MR in

Re: [PATCH 6/8] hw/arm/aspeed/2600: Check for CPU types in machine_run_board_init()

2024-01-23 Thread Cédric Le Goater
On 1/23/24 10:27, Cédric Le Goater wrote: On 1/23/24 07:38, Philippe Mathieu-Daudé wrote: Restrict MachineClass::valid_cpu_types[] to the single valid CPU type. Signed-off-by: Philippe Mathieu-Daudé ---   hw/arm/aspeed.c | 12   1 file changed, 12 insertions(+) diff --git a/hw

Re: [PATCH 6/8] hw/arm/aspeed/2600: Check for CPU types in machine_run_board_init()

2024-01-23 Thread Cédric Le Goater
On 1/23/24 07:38, Philippe Mathieu-Daudé wrote: Restrict MachineClass::valid_cpu_types[] to the single valid CPU type. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index

Re: [PATCH 4/8] hw/arm/aspeed/2400: Check for CPU types in machine_run_board_init()

2024-01-23 Thread Cédric Le Goater
On 1/23/24 07:38, Philippe Mathieu-Daudé wrote: Restrict MachineClass::valid_cpu_types[] to the single valid CPU type. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 8 1 file changed, 8 insertions(+) diff --git a/hw

Re: [PATCH 5/8] hw/arm/aspeed/2500: Check for CPU types in machine_run_board_init()

2024-01-23 Thread Cédric Le Goater
On 1/23/24 07:38, Philippe Mathieu-Daudé wrote: Restrict MachineClass::valid_cpu_types[] to the single valid CPU type. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 14 ++ 1 file changed, 14 insertions(+) diff

Re: [PATCH rfcv1 6/6] intel_iommu: add a framework to check and sync host IOMMU cap/ecap

2024-01-23 Thread Cédric Le Goater
On 1/15/24 11:13, Zhenzhong Duan wrote: From: Yi Liu Add a framework to check and synchronize host IOMMU cap/ecap with vIOMMU cap/ecap. Currently only stage-2 translation is supported which is backed by shadow page table on host side. So we don't need exact matching of each bit of cap/ecap

Re: [PATCH rfcv1 2/6] hw/pci: introduce pci_device_set/unset_iommu_device()

2024-01-22 Thread Cédric Le Goater
On 1/23/24 07:37, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Subject: Re: [PATCH rfcv1 2/6] hw/pci: introduce pci_device_set/unset_iommu_device() On 1/15/24 11:13, Zhenzhong Duan wrote: From: Yi Liu This adds pci_device_set/unset_iommu_device() to set/unset

Re: [PATCH] target/ppc: Re-name registers to match ISA

2024-01-22 Thread Cédric Le Goater
(e.g., DEC, TB, CFAR), so risk of breaking users should be low. QEMU should follow the ISA for register name convention (where there is no established GDB name). Signed-off-by: Nicholas Piggin Acked-by: Cédric Le Goater Thanks, C. --- There is never a great time to change user interface

Re: [PATCH v6 9/9] ppc/pnv: Test pnv i2c master and connected devices

2024-01-22 Thread Cédric Le Goater
-by: Cédric Le Goater No change from previous version tests/qtest/meson.build | 1 + tests/qtest/pnv-host-i2c-test.c | 650 2 files changed, 651 insertions(+) create mode 100644 tests/qtest/pnv-host-i2c-test.c diff --git a/tests/qtest/meson.build b

Re: [PATCH v3 8/8] target/ppc: Add SMT support to time facilities

2024-01-22 Thread Cédric Le Goater
not right, but it is enough for skiboot and certain other proprietary firmware. Signed-off-by: Nicholas Piggin Acked-by: Cédric Le Goater Thanks, C. --- target/ppc/timebase_helper.c | 105 --- target/ppc/translate.c | 42 +- 2 files

Re: [PATCH v3 5/8] ppc/pnv: Wire ChipTOD model to powernv9 and powernv10 machines

2024-01-22 Thread Cédric Le Goater
On 12/1/23 13:16, Nicholas Piggin wrote: Wire the ChipTOD model to powernv9 and powernv10 machines. Suggested-by-by: Cédric Le Goater Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/ppc/pnv_chip.h | 3 +++ hw/ppc/pnv.c | 30

Re: [PATCH rfcv1 4/6] vfio: initialize IOMMUFDDevice and pass to vIOMMU

2024-01-22 Thread Cédric Le Goater
On 1/15/24 11:13, Zhenzhong Duan wrote: Initialize IOMMUFDDevice in vfio and pass to vIOMMU, so that vIOMMU could get hw IOMMU information. In VFIO legacy backend mode, we still pass a NULL IOMMUFDDevice to vIOMMU, in case vIOMMU needs some processing for VFIO legacy backend mode.

Re: [PATCH rfcv1 3/6] intel_iommu: add set/unset_iommu_device callback

2024-01-22 Thread Cédric Le Goater
On 1/15/24 11:13, Zhenzhong Duan wrote: From: Yi Liu This adds set/unset_iommu_device() implementation in Intel vIOMMU. In set call, IOMMUFDDevice is recorded in hash table indexed by PCI BDF. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan ---

Re: [PATCH rfcv1 2/6] hw/pci: introduce pci_device_set/unset_iommu_device()

2024-01-22 Thread Cédric Le Goater
On 1/15/24 11:13, Zhenzhong Duan wrote: From: Yi Liu This adds pci_device_set/unset_iommu_device() to set/unset IOMMUFDDevice for a given PCIe device. Caller of set should fail if set operation fails. Extract out pci_device_get_iommu_bus_devfn() to facilitate implementation of

Re: [PATCH rfcv1 1/6] backends/iommufd_device: introduce IOMMUFDDevice

2024-01-22 Thread Cédric Le Goater
On 1/19/24 08:31, Duan, Zhenzhong wrote: -Original Message- From: Eric Auger Subject: Re: [PATCH rfcv1 1/6] backends/iommufd_device: introduce IOMMUFDDevice On 1/15/24 11:13, Zhenzhong Duan wrote: IOMMUFDDevice represents a device in iommufd and can be used as a communication

Re: [PATCH 0/5] buses: switch to 3-phase-reset

2024-01-22 Thread Cédric Le Goater
Hello, On 1/22/24 03:06, Peter Xu wrote: Hi, Peter, On Fri, Jan 19, 2024 at 04:35:07PM +, Peter Maydell wrote: I wrote this ages ago and recently picked it back up because of a recent PCI related reset ordering problem noted by Peter Xu. I'm not sure if this patchset is necessary as a

Re: [PATCH 2/2] ppc/pnv: Change powernv default to powernv10

2024-01-19 Thread Cédric Le Goater
Signed-off-by: Nicholas Piggin May be we could drop support for power10_v1.0 and power9_v1.0 ? These were bringup CPUs. Anyhow, Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/pnv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index

Re: [PATCH 8/8] ppc/pnv: Update skiboot to v7.1

2024-01-19 Thread Cédric Le Goater
Reviewed-by: Cédric Le Goater Thanks, C. ---> [blob omitted, patch is just for comments] pc-bios/skiboot.lid | Bin 2527240 -> 2527328 bytes roms/skiboot| 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/skiboot b/roms/skiboot index 24a7

Re: [PATCH 00/26] target/ppc: TCG improvements and fixes

2024-01-19 Thread Cédric Le Goater
Hello Nick, On 1/18/24 16:06, Nicholas Piggin wrote: This is mostly TCG core emulation improvements and fixes. I got the chiptod model in there because it's intertwined with TFMR SPR. Other non-TCG patches are spapr MSR entry point change which goes together with the other machine check /

Re: [PATCH v2 0/3] s390x/pci: fix ISM reset

2024-01-18 Thread Cédric Le Goater
that went unnoticed because the kernel previously did not detect and issue a warning for this scenario. Changes for v2: - Fold a typo fix from patch 2 into patch 1 where it belongs - Add block comment re: timing of ISM reset - Add review tags Reviewed-by: Cédric Le Goater Thanks, C.

Re: [PATCH 0/4] ppc: add machine check injection HMP command

2024-01-18 Thread Cédric Le Goater
Hello Nick, On 1/18/24 15:34, Nicholas Piggin wrote: I'd like to resurrect this and get it merged, because it's quite useful for testing (has caught several Linux bugs in the past). IIRC the main concern David had last time it came up was that it should have QMP commands too. Which is valid.

Re: [PATCH] vfio: use matching sizeof type

2024-01-17 Thread Cédric Le Goater
On 1/18/24 06:09, Peter Xu wrote: On Wed, Jan 17, 2024 at 05:03:44PM +0100, Paolo Bonzini wrote: Do not use uint64_t for the type of the declaration and __u64 when computing the number of elements in the array. Signed-off-by: Paolo Bonzini --- hw/vfio/common.c | 2 +- 1 file changed, 1

Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-17 Thread Cédric Le Goater
On 1/17/24 22:11, Matthew Rosato wrote: On 1/17/24 10:19 AM, Matthew Rosato wrote: On 1/17/24 6:01 AM, Cédric Le Goater wrote: Adding Alex, On 1/16/24 23:31, Matthew Rosato wrote: ISM devices are sensitive to manipulation of the IOMMU, so the ISM device needs to be reset before the vfio-pci

Re: [PATCH v2 2/2] docs/about: Deprecate the old "power5+" and "power7+" CPU names

2024-01-17 Thread Cédric Le Goater
On 1/17/24 15:10, Thomas Huth wrote: For consistency we should drop the names with a "+" in it in the long run. Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater Thanks, C. --- docs/about/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/

Re: [PATCH v2 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-17 Thread Cédric Le Goater
a hack in type_name_is_valid() to still allow them for compatibility reasons. However, there is a much nicer solution for this: Simply use aliases! This way we can still support the old names without the need for the ugly hack in type_name_is_valid(). Signed-off-by: Thomas Huth Reviewed-by: Cédric

Re: [PATCH 2/4] reset: Allow multiple stages of system resets

2024-01-17 Thread Cédric Le Goater
On 1/17/24 11:28, Eric Auger wrote: Hi Peter, On 1/17/24 10:15, pet...@redhat.com wrote: From: Peter Xu QEMU resets do not have a way to order reset hooks. Add one coarse grained reset stage so that some devices can be reset later than some others. I would precise that the lowest stage has

Re: [PATCH 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-17 Thread Cédric Le Goater
eboot") Fixes: 03451953c7 ("s390x/pci: reset ISM passthrough devices on shutdown and system reset") Reported-by: Cédric Le Goater Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 26 +- hw/s390x/s390-virtio-ccw.c | 2 ++ inclu

Re: [PATCH 1/3] s390x/pci: avoid double enable/disable of aif

2024-01-17 Thread Cédric Le Goater
? Doesn't KVM handle multiple calls to KVM_S390_ZPCIOP_DEREG_AEN cleanly ? Just asking, I am no expert there. Thanks, C. Fixes: d0bc7091c2 ("s390x/pci: enable adapter event notification for interpreted devices") Reported-by: Cédric Le Goater Signed-off-by: Matthew Rosato --- hw/

Re: [PATCH 2/3] s390x/pci: refresh fh before disabling aif

2024-01-17 Thread Cédric Le Goater
aif. Fixes: 03451953c7 ("s390x/pci: reset ISM passthrough devices on shutdown and system reset") Reported-by: Cédric Le Goater Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-kvm.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-

Re: [PATCH 2/3] s390x/pci: refresh fh before disabling aif

2024-01-17 Thread Cédric Le Goater
before disabling aif. Fixes: 03451953c7 ("s390x/pci: reset ISM passthrough devices on shutdown and system reset") Reported-by: Cédric Le Goater Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-kvm.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/

Re: [PATCH v3 22/46] hw/arm/aspeed: use qemu_configure_nic_device()

2024-01-16 Thread Cédric Le Goater
VICE(>soc->ftgmac100[i]), + true, NULL)) { + break; /* No configs left; stop asking */ } } Acked-by: Cédric Le Goater Thanks, C.

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-15 Thread Cédric Le Goater
On 1/12/24 20:54, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/10/24 14:19, Fabiano Rosas wrote: Markus Armbruster writes: Peter Xu writes: On Tue, Jan 09, 2024 at 10:22:31PM +0100, Philippe Mathieu-Daudé wrote: Hi Fabiano, On 9/1/24 21:21, Fabiano Rosas wrote: Cédric Le

Re: Possible race condition in aspeed ast2600 smp boot on TCG QEMU

2024-01-12 Thread Cédric Le Goater
Adding Aspeed Engineers. This reminds me of a discussion a while ago. On 1/11/24 18:38, Stephen Longfield wrote: We’ve noticed inconsistent behavior when running a large number of aspeed ast2600 executions, that seems to be tied to a race condition in the smp boot when executing on TCG-QEMU,

Re: [PATCH v10 9/9] hw/fsi: Update MAINTAINER list

2024-01-12 Thread Cédric Le Goater
On 1/11/24 00:15, Ninad Palsule wrote: Added maintainer for IBM FSI model Signed-off-by: Cédric Le Goater Please remove my S-o-b. Signed-off-by: Ninad Palsule --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 00ec1f7eca

Re: [PATCH v10 8/9] hw/fsi: Added FSI documentation

2024-01-12 Thread Cédric Le Goater
On 1/11/24 00:15, Ninad Palsule wrote: Documentation for IBM FSI model. Signed-off-by: Cédric Le Goater Please remove mu S-o-b. Thanks, C. Signed-off-by: Ninad Palsule --- docs/specs/fsi.rst | 138 +++ docs/specs/index.rst | 1 + 2 files

Re: [PATCH v10 7/9] hw/fsi: Added qtest

2024-01-12 Thread Cédric Le Goater
On 1/11/24 00:15, Ninad Palsule wrote: Added basic qtests for FSI model. Acked-by: Thomas Huth Signed-off-by: Cédric Le Goater Please remove mu S-o-b. Thanks, C. Signed-off-by: Ninad Palsule --- tests/qtest/aspeed-fsi-test.c | 205 ++ tests/qtest

Re: [PATCH v10 5/9] hw/fsi: Aspeed APB2OPB interface, Onchip perif bus

2024-01-12 Thread Cédric Le Goater
fsi_aspeed_apb2opb_realize() - removed FSIMasterState object and fsi_opb_realize() - simplified OPBus ] Signed-off-by: Andrew Jeffery Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule Reviewed-by: Joel Stanley Nah. Joel you should re-review next respin :) --- v9: - Removed unused

Re: [PATCH v10 4/9] hw/fsi: Introduce IBM's FSI master

2024-01-12 Thread Cédric Le Goater
() - dropped FSIBus definition ] Move the list down before my S-o-b. Signed-off-by: Andrew Jeffery Reviewed-by: Joel Stanley I think you can drop Joel's reviews, the code has changed a lot. Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule --- v9: - Initialized

Re: [PATCH v10 2/9] hw/fsi: Introduce IBM's FSI Bus and FSI slave

2024-01-12 Thread Cédric Le Goater
- dropped hw/fsi/trace-events changes ] Move the list down before my S-o-b. Signed-off-by: Andrew Jeffery Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule --- include/hw/fsi/fsi.h | 38 +++ hw/fsi/fsi.c | 111

Re: [PATCH v10 3/9] hw/fsi: Introduce IBM's cfam

2024-01-12 Thread Cédric Le Goater
- reworked fsi_cfam_realize() ] Move the list down before my S-o-b. Signed-off-by: Andrew Jeffery Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule --- v9: - Added more registers to scratchpad - Removed unnecessary address space - Removed unnecessary header file - Defi

Re: [PATCH v10 1/9] hw/fsi: Introduce IBM's Local bus and scratchpad

2024-01-12 Thread Cédric Le Goater
ifications should be before my S-o-b. Signed-off-by: Andrew Jeffery Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule --- v9: - Changed LBUS memory region to 1MB. --- meson.build | 1 + hw/fsi/trace.h| 1 + include/hw/fsi/lbus.h | 52 +

Re: [PATCH v10 0/9] Introduce model for IBM's FSI

2024-01-12 Thread Cédric Le Goater
Hello Ninad, This is looking much better. I have a couple more comments. Please wait a little before sending a respin ! :) and please run make check and script/checkpatch.pl. On 1/11/24 00:15, Ninad Palsule wrote: Hello, Please review the patch-set version 10. I have incorporated review

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Cédric Le Goater
On 1/12/24 11:55, Thomas Huth wrote: On 12/01/2024 06.21, Harsh Prateek Bora wrote: On 1/12/24 10:42, Thomas Huth wrote: On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 -

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-12 Thread Cédric Le Goater
On 1/10/24 14:19, Fabiano Rosas wrote: Markus Armbruster writes: Peter Xu writes: On Tue, Jan 09, 2024 at 10:22:31PM +0100, Philippe Mathieu-Daudé wrote: Hi Fabiano, On 9/1/24 21:21, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/9/24 18:40, Fabiano Rosas wrote: Cédric Le Goater

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-12 Thread Cédric Le Goater
On 1/10/24 07:26, Peter Xu wrote: On Wed, Jan 10, 2024 at 07:03:06AM +0100, Markus Armbruster wrote: Peter Xu writes: On Tue, Jan 09, 2024 at 10:22:31PM +0100, Philippe Mathieu-Daudé wrote: Hi Fabiano, On 9/1/24 21:21, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/9/24 18:40

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-12 Thread Cédric Le Goater
On 1/10/24 07:03, Markus Armbruster wrote: Peter Xu writes: On Tue, Jan 09, 2024 at 10:22:31PM +0100, Philippe Mathieu-Daudé wrote: Hi Fabiano, On 9/1/24 21:21, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/9/24 18:40, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/3/24 20

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-12 Thread Cédric Le Goater
On 1/9/24 22:09, Philippe Mathieu-Daudé wrote: On 9/1/24 22:07, Philippe Mathieu-Daudé wrote: Hi Cédric, On 9/1/24 19:06, Cédric Le Goater wrote: On 1/9/24 18:40, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/3/24 20:53, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: +Peter

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-11 Thread Cédric Le Goater
Regarding pseries, migration compat broke because of 5bc8d26de20c ("spapr: allocate the ICPState object from under sPAPRCPUCore") which is similar to the changes proposed by this series, it impacts the QOM hierarchy. Here is the workaround/fix from Greg : 46f7afa37096 ("spapr: fix migration of

Re: [PATCH 2/2] docs/about: Deprecate the old "power5+" and "power7+" CPU names

2024-01-11 Thread Cédric Le Goater
ported via +an alias, but for consistency these will get removed in a future +release, too. Use ``power5plus_v2.1`` and ``power7plus_v2.1`` instead. + System emulator machines ---- Reviewed-by: Cédric Le Goater Thanks, C.

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Cédric Le Goater
a hack in type_name_is_valid() to still allow them for compatibility reasons. However, there is a much nicer solution for this: Simply use aliases! This way we can still support the old names without the need for the ugly hack in type_name_is_valid(). Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater Thanks, C.

Re: [PATCH v2] target/s390x/kvm/pv: Provide some more useful information if decryption fails

2024-01-11 Thread Cédric Le Goater
have gone wrong. Buglink: https://issues.redhat.com/browse/RHEL-18212 Signed-off-by: Thomas Huth --- v2: Print the error in s390_machine_protect() instead of doing it in s390_pv_set_sec_parms(), report the text via Error **errp Reviewed-by: Cédric Le Goater s390_pv_

Re: [PULL 2/7] s390x: do a subsystem reset before the unprotect on reboot

2024-01-11 Thread Cédric Le Goater
On 1/10/24 21:28, Matthew Rosato wrote: On 1/10/24 1:30 PM, Cédric Le Goater wrote: On 9/12/23 13:41, Thomas Huth wrote: From: Janosch Frank Bound APQNs have to be reset before tearing down the secure config via s390_machine_unprotect(). Otherwise the Ultravisor will return a error code. So

Re: [PULL 2/7] s390x: do a subsystem reset before the unprotect on reboot

2024-01-10 Thread Cédric Le Goater
On 9/12/23 13:41, Thomas Huth wrote: From: Janosch Frank Bound APQNs have to be reset before tearing down the secure config via s390_machine_unprotect(). Otherwise the Ultravisor will return a error code. So let's do a subsystem_reset() which includes a AP reset before the unprotect call.

Re: [PATCH 00/10] docs/migration: Reorganize migration documentations

2024-01-10 Thread Cédric Le Goater
On 1/10/24 03:37, Peter Xu wrote: On Tue, Jan 09, 2024 at 02:21:26PM +0100, Cédric Le Goater wrote: A few things I'd like to mention alongside, because it's documentation relevant too, and I'd like to collect if there's any comment. I just mostly rewrote two wiki pages completely: https

Re: [PATCH v8 00/10] Introduce model for IBM's FSI

2024-01-09 Thread Cédric Le Goater
Hello Ninad, Here are comments on the file organization and configs. On 11/29/23 00:56, Ninad Palsule wrote: Hello, Please review the patch-set version 8. I have incorporated review comments from Cedric. - Fixed checkpatch failures. - Fixed commit messages. - Fixed LBUS memory map

Re: [PATCH v3 3/4] ci: Add a migration compatibility test job

2024-01-09 Thread Cédric Le Goater
On 1/5/24 19:04, Fabiano Rosas wrote: The migration tests have support for being passed two QEMU binaries to test migration compatibility. Add a CI job that builds the lastest release of QEMU and another job that uses that version plus an already present build of the current version and run the

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-09 Thread Cédric Le Goater
On 1/9/24 18:40, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/3/24 20:53, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: +Peter/Fabiano On 2/1/24 17:41, Cédric Le Goater wrote: On 1/2/24 17:15, Philippe Mathieu-Daudé wrote: Hi Cédric, On 2/1/24 15:55, Cédric Le Goater wrote

[PATCH] tests/avocado/machine_aspeed.py: Update buildroot images to 2023.11

2024-01-09 Thread Cédric Le Goater
/torvalds/linux.git/commit/?id=9deb10cf160e Signed-off-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py index 6fa5459a07bf..cec018142453

Re: [PATCH] target/s390x/kvm/pv: Provide some more useful information if decryption fails

2024-01-09 Thread Cédric Le Goater
On 1/9/24 15:30, Thomas Huth wrote: It's a common scenario to copy guest images from one host to another to run the guest on the other machine. This (of course) does not work with "secure exection" guests since they are encrypted with one certain host key. However, if you still (accidentally)

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

2024-01-09 Thread Cédric Le Goater
On 1/3/24 20:53, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: +Peter/Fabiano On 2/1/24 17:41, Cédric Le Goater wrote: On 1/2/24 17:15, Philippe Mathieu-Daudé wrote: Hi Cédric, On 2/1/24 15:55, Cédric Le Goater wrote: On 12/12/23 17:29, Philippe Mathieu-Daudé wrote: Hi, When

Re: [PATCH 00/10] docs/migration: Reorganize migration documentations

2024-01-09 Thread Cédric Le Goater
A few things I'd like to mention alongside, because it's documentation relevant too, and I'd like to collect if there's any comment. I just mostly rewrote two wiki pages completely: https://wiki.qemu.org/ToDo/LiveMigration https://wiki.qemu.org/Features/Migration> I merged all the TODO

Re: [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface

2024-01-08 Thread Cédric Le Goater
Hello Ninad, +static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp) +{ +    SysBusDevice *sbd = SYS_BUS_DEVICE(dev); +    AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev); +    int i; + +    sysbus_init_irq(sbd, >irq); + +    memory_region_init_io(>iomem, OBJECT(s), _apb2opb_ops, s,

Re: [PATCH 10/10] docs/migration: Further move virtio to be feature of migration

2024-01-08 Thread Cédric Le Goater
On 1/9/24 07:46, pet...@redhat.com wrote: From: Peter Xu Move it one layer down, so taking Virtio-migration as a feature for migration. Cc: Michael S. Tsirkin Cc: Jason Wang Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel/migration/features.rst

Re: [PATCH 09/10] docs/migration: Further move vfio to be feature of migration

2024-01-08 Thread Cédric Le Goater
On 1/9/24 07:46, pet...@redhat.com wrote: From: Peter Xu Move it one layer down, so taking VFIO-migration as a feature for migration. Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel/migration/features.rst

Re: [PATCH 08/10] docs/migration: Organize "Postcopy" page

2024-01-08 Thread Cédric Le Goater
+ Postcopy +.. contents:: + 'Postcopy' migration is a way to deal with migrations that refuse to converge The quote character is used in a few places to emphasize words which should be reworked. The rest looks good, so Reviewed-by: Cédric Le Goater Thanks, C. (or take too l

Re: [PATCH 07/10] docs/migration: Split "dirty limit"

2024-01-08 Thread Cédric Le Goater
On 1/9/24 07:46, pet...@redhat.com wrote: From: Peter Xu Split that into a separate file, put under "features". Cc: Yong Huang Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel/migration/dirty-limit.rst | 71

Re: [PATCH 06/10] docs/migration: Split "Postcopy"

2024-01-08 Thread Cédric Le Goater
On 1/9/24 07:46, pet...@redhat.com wrote: From: Peter Xu Split postcopy into a separate file. Introduce a head page "features.rst" to keep all the features on top of migration framework. Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel

Re: [PATCH 05/10] docs/migration: Split "Debugging" and "Firmware"

2024-01-08 Thread Cédric Le Goater
On 1/9/24 07:46, pet...@redhat.com wrote: From: Peter Xu Move the two sections into a separate file called "best-practises.rst". Add the entry into index. Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel/migration/best-practise

Re: [PATCH 04/10] docs/migration: Split "Backwards compatibility" separately

2024-01-08 Thread Cédric Le Goater
On 1/9/24 07:46, pet...@redhat.com wrote: From: Peter Xu Split the section from main.rst into a separate file. Reference it in the index.rst. Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C.

Re: [PATCH 03/10] docs/migration: Convert virtio.txt into rST

2024-01-08 Thread Cédric Le Goater
On 1/9/24 07:46, pet...@redhat.com wrote: From: Peter Xu Convert the plain old .txt into .rst, add it into migration/index.rst. Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel/migration/index.rst | 1 + docs/devel/migration/virtio.rst | 115

Re: [PATCH 02/10] docs/migration: Create index page

2024-01-08 Thread Cédric Le Goater
"migration framework". Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel/index-internals.rst | 3 +-- docs/devel/migration/index.rst | 11 +++ docs/devel/migration/main.rst | 6 +++--- docs/deve

Re: [PATCH 01/10] docs/migration: Create migration/ directory

2024-01-08 Thread Cédric Le Goater
is still not yet converted to rST. That is a job for later. Cc: Michael S. Tsirkin Cc: Jason Wang Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Peter Xu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/devel/index-internals.rst| 2 +- docs/devel

Re: [PATCH 2/2] hw/block: Deprecate the TC58128 block device

2024-01-08 Thread Cédric Le Goater
-by: Samuel Tardieu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/about/deprecated.rst | 2 +- hw/block/tc58128.c| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index e6a12c9077..15e39f8bbb 100644

Re: [PATCH 1/2] target/sh4: Deprecate the shix machine

2024-01-08 Thread Cédric Le Goater
to deprecate it. Signed-off-by: Samuel Tardieu Reviewed-by: Cédric Le Goater Thanks, C. --- docs/about/deprecated.rst | 5 + hw/sh4/shix.c | 1 + 2 files changed, 6 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 2e15040246

Re: [PATCH 8/9] tests/avocado: ppc add hypervisor tests

2024-01-08 Thread Cédric Le Goater
/rtas* F: tests/qtest/libqos/rtas* F: tests/avocado/ppc_pseries.py +F: tests/avocado/ppc_hv_tests.py PowerNV (Non-Virtualized) M: Cédric Le Goater diff --git a/tests/avocado/ppc_hv_tests.py b/tests/avocado/ppc_hv_tests.py new file mode 100644 index 00..2162d6bd68 --- /dev/null

Re: [PATCH] target/ppc: Fix crash on machine check caused by ifetch

2024-01-08 Thread Cédric Le Goater
On 1/7/24 18:05, Nicholas Piggin wrote: is_prefix_insn_excp() loads the first word of the instruction address which caused an exception, to determine whether or not it was prefixed so the prefix bit can be set in [H]SRR1. In case it was the instruction fetch itself that caused the exception,

Re: [PATCH 9/9] tests/avocado: Add FreeBSD distro boot tests for ppc

2024-01-08 Thread Cédric Le Goater
On 1/7/24 18:01, Nicholas Piggin wrote: FreeBSD project provides qcow2 images that work well for testing QEMU. Add pseries tests for HPT and Radix, KVM and TCG. This uses a short term VM image, because FreeBSD has not set up long term builds for ppc64 at present. Other architectures could be

Re: [PATCH 7/9] tests/avocado: Add pseries KVM boot_linux test

2024-01-08 Thread Cédric Le Goater
On 1/7/24 18:01, Nicholas Piggin wrote: ppc has no avocado tests for the KVM backend. Add a KVM boot_linux.py test for pseries. Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- tests/avocado/boot_linux.py | 8 1 file changed, 8 insertions

Re: [PATCH 5/9] tests/avocado: ppc add powernv10 boot_linux_console test

2024-01-08 Thread Cédric Le Goater
On 1/7/24 18:01, Nicholas Piggin wrote: Add test for POWER10. Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- tests/avocado/boot_linux_console.py | 8 1 file changed, 8 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests

Re: [PATCH 2/9] tests/avocado: mark boot_linux.py long runtime instead of flaky

2024-01-08 Thread Cédric Le Goater
n though they run in less than 50s. Anyhow, Reviewed-by: Cédric Le Goater Thanks, C. + AVOCADO_ALLOW_UNTRUSTED_CODE There are tests which will boot a kernel image or firmware that can be diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.p

Re: [PATCH 1/9] gitlab: fix s390x tag for avocado-system-centos

2024-01-08 Thread Cédric Le Goater
On 1/7/24 18:01, Nicholas Piggin wrote: The 390x tag should be s390x. Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d

[PULL 13/17] vfio/iommufd: Remove the use of stat() to check file existence

2024-01-07 Thread Cédric Le Goater
opendir to avoid the race. Fixes: CID 1531551 Signed-off-by: Cédric Le Goater Reviewed-by: Zhenzhong Duan --- hw/vfio/iommufd.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c index d4c586e842def8f04d3a914843f5eece2c75ea30

[PULL 08/17] vfio/iommufd: Introduce a VFIOIOMMU iommufd QOM interface

2024-01-07 Thread Cédric Le Goater
As previously done for the sPAPR and legacy IOMMU backends, convert the VFIOIOMMUOps struct to a QOM interface. The set of of operations for this backend can be referenced with a literal typename instead of a C struct. Reviewed-by: Zhenzhong Duan Tested-by: Eric Farman Signed-off-by: Cédric Le

[PULL 01/17] vfio/spapr: Extend VFIOIOMMUOps with a release handler

2024-01-07 Thread Cédric Le Goater
This allows to abstract a bit more the sPAPR IOMMU support in the legacy IOMMU backend. Reviewed-by: Zhenzhong Duan Tested-by: Eric Farman Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-container-base.h | 1 + hw/vfio/container.c | 10 +++- hw/vfio/spapr.c

[PULL 04/17] vfio/container: Introduce a VFIOIOMMU QOM interface

2024-01-07 Thread Cédric Le Goater
referencing the various implementations. Simply transform the VFIOIOMMUOps struct in an InterfaceClass and do some initial name replacements. Next changes will start converting VFIOIOMMUOps. Reviewed-by: Zhenzhong Duan Tested-by: Eric Farman Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio

[PULL 11/17] vfio/container: Replace basename with g_path_get_basename

2024-01-07 Thread Cédric Le Goater
-by: Eric Auger Reviewed-by: Zhao Liu Reviewed-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater --- hw/vfio/container.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/vfio/container.c b/hw/vfio/container.c index 688cf23bab88f85246378bc5a7da3c51ea6b79d9

[PULL 06/17] vfio/container: Intoduce a new VFIOIOMMUClass::setup handler

2024-01-07 Thread Cédric Le Goater
This will help in converting the sPAPR IOMMU backend to a QOM interface. Reviewed-by: Zhenzhong Duan Tested-by: Eric Farman Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-container-base.h | 1 + hw/vfio/container.c | 1 + 2 files changed, 2 insertions(+) diff

[PULL 15/17] vfio/migration: Add helper function to set state or reset device

2024-01-07 Thread Cédric Le Goater
and remove duplicate comments. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé --- hw/vfio/migration.c | 41 + 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c

[PULL 16/17] backends/iommufd: Remove check on number of backend users

2024-01-07 Thread Cédric Le Goater
QOM already has a ref count on objects and it will assert much earlier, when INT_MAX is reached. Reviewed-by: Eric Auger Reviewed-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater --- backends/iommufd.c | 5 - 1 file changed, 5 deletions(-) diff --git a/backends/iommufd.c b/backends

[PULL 17/17] backends/iommufd: Remove mutex

2024-01-07 Thread Cédric Le Goater
BQL lock and it should be safe to drop the IOMMUFD backend mutex. Simply remove it. Fixes: CID 1531550 Fixes: CID 1531549 Reviewed-by: Eric Auger Reviewed-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater --- include/sysemu/iommufd.h | 2 -- backends/iommufd.c | 7 --- 2 files chan

[PULL 05/17] vfio/container: Introduce a VFIOIOMMU legacy QOM interface

2024-01-07 Thread Cédric Le Goater
-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 1 - include/hw/vfio/vfio-container-base.h | 1 + hw/vfio/common.c | 6 ++- hw/vfio/container.c | 58 ++- 4 files changed, 55 insertions(+), 11 deletions(-) diff --git

[PULL 09/17] vfio/spapr: Only compile sPAPR IOMMU support when needed

2024-01-07 Thread Cédric Le Goater
sPAPR IOMMU support is only needed for pseries machines. Compile out support when CONFIG_PSERIES is not set. This saves ~7K of text. Reviewed-by: Zhenzhong Duan Tested-by: Eric Farman Signed-off-by: Cédric Le Goater --- hw/vfio/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PULL 12/17] hw/vfio: fix iteration over global VFIODevice list

2024-01-07 Thread Cédric Le Goater
afe ("vfio/common: Introduce a global VFIODevice list") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2061 Signed-off-by: Volker Rümelin Reviewed-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Reviewed-by: Eric Auger --- hw/vfio/common.c | 8 1 file changed, 4 insert

<    1   2   3   4   5   6   7   8   9   10   >