Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

On 12/26/2011 08:00 PM, Dor Laor wrote: On 12/26/2011 05:12 PM, Anthony Liguori wrote: Hi Dor, Merry Christmas Anthony, On 12/25/2011 09:19 AM, Dor Laor wrote: On 12/19/2011 07:13 PM, Anthony Liguori wrote: Well, I'm still not convinced that a new standalone package should handle these

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

On 12/27/2011 11:37 PM, Anthony Liguori wrote: On 12/27/2011 04:35 PM, Cleber Rosa wrote: On 12/26/2011 08:00 PM, Dor Laor wrote: On 12/26/2011 05:12 PM, Anthony Liguori wrote: Hi Dor, Merry Christmas Anthony, On 12/25/2011 09:19 AM, Dor Laor wrote: On 12/19/2011 07:13 PM, Anthony

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

On 12/27/2011 11:37 PM, Anthony Liguori wrote: On 12/27/2011 04:35 PM, Cleber Rosa wrote: On 12/26/2011 08:00 PM, Dor Laor wrote: On 12/26/2011 05:12 PM, Anthony Liguori wrote: Hi Dor, Merry Christmas Anthony, On 12/25/2011 09:19 AM, Dor Laor wrote: On 12/19/2011 07:13 PM, Anthony

Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU

, but still it demands effort that has to be justified. anthony@titi:~/git/autotest/client/tests$ git log --format=%an %ae kvm | sort -u Amos Kong ak...@redhat.com Chris Evich cev...@redhat.com Cleber Rosa cr...@redhat.com Jerry Tang jt...@suse.com lmr lmr@592f7852-d20e-0410-864c-8624ca9c26a4 Lucas

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

On 10/26/2011 12:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author:

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

On 10/26/2011 12:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: Hi folks: We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by: commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 Author:

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

On 10/28/2011 08:33 AM, Kevin Wolf wrote: Am 27.10.2011 16:32, schrieb Kevin Wolf: Am 27.10.2011 16:15, schrieb Kevin Wolf: Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: Am 19.09.2011 16:37, schrieb Frediano Ziglio: Now that

Re: [Qemu-devel] [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 Upstream qemu-kvm.git sanity 11-01-2011 00:04:02 | Status: 1 Completed | Success Rate: 94.74 %

On 11/07/2011 07:21 AM, Marcelo Tosatti wrote: On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: On 11/01/2011 12:17 PM, kvm-autotest wrote: Job ID: 2011 Job name: Upstream qemu-kvm.git sanity 11-01-2011 00:04:02 Summary: Host: Status: Completed Status: 1 Completed

Re: [Qemu-devel] [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 Upstream qemu-kvm.git sanity 11-01-2011 00:04:02 | Status: 1 Completed | Success Rate: 94.74 %

On 11/07/2011 02:22 PM, Marcelo Tosatti wrote: On Mon, Nov 07, 2011 at 09:00:26AM -0300, Cleber Rosa wrote: On 11/07/2011 07:21 AM, Marcelo Tosatti wrote: On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: On 11/01/2011 12:17 PM, kvm-autotest wrote: Job ID: 2011 Job

Re: [Qemu-devel] Autotest | Job ID: 2072 [unittest emulator + kernel git] Upstream qemu-kvm.git sanity 11-07-2011 13:16:33 | Status: 1 Completed | Success Rate: 94.74 %

On 11/07/2011 04:56 PM, kvm-autot...@redhat.com wrote: Job ID: 2072 Job name: [unittest emulator + kernel git] Upstream qemu-kvm.git sanity 11-07-2011 13:16:33 Summary: Host: virtlab201.virt.bos.redhat.com Status: Completed Status: 1 Completed Results interface URL:

Re: [Qemu-devel] live snapshot wiki updated

On 07/19/2011 12:14 PM, Anthony Liguori wrote: On 07/19/2011 09:30 AM, Jes Sorensen wrote: On 07/19/11 16:24, Eric Blake wrote: [adding the libvir-list] On 07/19/2011 08:09 AM, Jes Sorensen wrote: Urgh, libvirt parsing image files is really unfortunate, it really doesn't give me warm fuzzy

Re: [Qemu-devel] live snapshot wiki updated

On 07/20/2011 10:34 AM, Anthony Liguori wrote: On 07/20/2011 08:50 AM, Cleber Rosa wrote: Just as a reminder: with DAC, if a guest is compromised and somehow escalates to QEMU, it could disable its isolation (ie, by setting their own image files world readable). I guess we shouldn't try to fix

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

On 08/08/2011 07:47 AM, Dor Laor wrote: On 08/08/2011 01:59 PM, Nadav Har'El wrote: * What's is postcopy livemigration It is is yet another live migration mechanism for Qemu/KVM, which implements the migration technique known as postcopy or lazy migration. Just after the migrate command is

Re: [Qemu-devel] Re: spice in kvm-autotest [was: Re: KVM call minutes for Apr 5]

On 04/05/2011 03:25 PM, Lucas Meneghel Rodrigues wrote: On Tue, 2011-04-05 at 13:08 -0500, Anthony Liguori wrote: On 04/05/2011 12:08 PM, Alon Levy wrote: The thing about WHQL is that it has its own test suite coordination program (DTM), that has to run on a separate machine/VM. So they have

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

On 03/08/2012 08:54 AM, Stefan Hajnoczi wrote: On Thu, Mar 8, 2012 at 11:44 AM, Stefan Hajnoczistefa...@gmail.com wrote: On Thu, Mar 8, 2012 at 4:00 AM, Lucas Meneghel Rodriguesl...@redhat.com wrote: One of our main goals is to provide useful tools for the qemu community, since we have a

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

On 03/08/2012 08:21 PM, Anthony Liguori wrote: On 03/08/2012 04:24 PM, Ademar Reis wrote: On Thu, Mar 08, 2012 at 03:24:15PM -0600, Anthony Liguori wrote: On 03/08/2012 03:02 PM, Ademar Reis wrote: On Thu, Mar 08, 2012 at 01:16:58PM -0600, Anthony Liguori wrote: On 03/08/2012 11:59 AM,

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

On 03/09/2012 09:04 AM, Anthony Liguori wrote: On 03/09/2012 05:20 AM, Cleber Rosa wrote: You're comparing developer-level tests with the existent QA-level tests (much more complex). Let's be specific then. Look at device-add.sh in qemu-test. It's 71LOC. pci_hotplug.py in autotest is 204LOC

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

On 03/09/2012 09:42 AM, Anthony Liguori wrote: On 03/09/2012 06:40 AM, Cleber Rosa wrote: On 03/09/2012 09:04 AM, Anthony Liguori wrote: On 03/09/2012 05:20 AM, Cleber Rosa wrote: You're comparing developer-level tests with the existent QA-level tests (much more complex). Let's be specific

Re: [Qemu-devel] [RFC] Future goals for autotest and virtualization tests

On 03/09/2012 12:48 PM, Anthony Liguori wrote: On 03/09/2012 09:34 AM, Paolo Bonzini wrote: Il 09/03/2012 16:24, Anthony Liguori ha scritto: At the very least dump the inquiry pages, mode pages, etc. and see that they make sense and correspond to the device properties. Is this not something

Re: [Qemu-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

- Original Message - > From: "Thomas Huth" > To: "Jason Wang" , "Jan Kiszka" > , qemu-devel@nongnu.org > Cc: "Paolo Bonzini" , avocado-de...@redhat.com, "Markus > Armbruster" >

Re: [Qemu-devel] [PATCH v6 1/3] loader: Allow ELF loader to auto-detect the ELF arch

ine)) { +goto fail; +} +elf_machine = e_machine; +} + -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ]

Re: [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header

On 07/27/2017 08:24 AM, Eric Blake wrote: > On 07/27/2017 07:15 AM, Peter Maydell wrote: >> On 27 July 2017 at 13:02, Cleber Rosa <cr...@redhat.com> wrote: >>> The generation of the informational header on config.log contains two >>> pairs of single quotes, whi

Re: [Qemu-devel] [PATCH 1/6] tests/tcg/test_path.c: include utils/bufferiszero.c

On 08/02/2017 05:36 PM, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > On 08/02/2017 05:15 PM, Cleber Rosa wrote: >> Which contains one specific function used by iov.c. >> >> Without this, "make -C tests/tcg test_path" (and consequently >> "make

[Qemu-devel] [PATCH 6/6] tests/tcg/test-i386-fprem.c: compilation fix for -Werror=unused-const-variable=

A clean up of unused code to make the compiler happy. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/tcg/test-i386-fprem.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/tests/tcg/test-i386-fprem.c b/tests/tcg/test-i386-fprem.c index f70363d..1dceda0

[Qemu-devel] [PATCH 1/6] tests/tcg/test_path.c: include utils/bufferiszero.c

Which contains one specific function used by iov.c. Without this, "make -C tests/tcg test_path" (and consequently "make -C tests/tcg" or simply "make test") fails quite early. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/tcg/test_path.c | 1 +

[Qemu-devel] [PATCH 3/6] tests/tcg/linux-test.c: include definitions for getrusage()

A include for is missing, and prevents tests/tcg/linux-test from compiling. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/tcg/linux-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/linux-test.c b/tests/tcg/linux-test.c index 1c6c013..15c9d7f 100644 --- a/tes

[Qemu-devel] [PATCH 2/6] tests/tcg/linux-test.c: remove unused include of "qemu/cutils.h"

Building tests/tcg/linux-test is not currently possible because $(QEMU_INCLUDES) is not being passed to $(CC_I386). But, since it's not really used, instead of adding the $(QEMU_INCLUDES), let's remove the "qemu/ctuils.h" include instead. Signed-off-by: Cleber Rosa <cr...@redhat.co

[Qemu-devel] [PATCH 0/6] Enable building and running tcg tests on i386

ave strong opinions about it, be that they need to be nourished and cared for, that they should be eliminated completely, or anything in between, I'd love to hear about it. Cleber Rosa(6): tests/tcg/test_path.c: include utils/bufferiszero.c tests/tcg/linux-test.c: remove unused include of &quo

[Qemu-devel] [PATCH 5/6] tests/tcg/test-i386-fprem.c: compilation fix for -Werror=strict-prototype

A trivial fix to make the compiler happy. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/tcg/test-i386-fprem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/test-i386-fprem.c b/tests/tcg/test-i386-fprem.c index 1a71623..f70363d 100644 --- a/tests/tc

[Qemu-devel] [PATCH 4/6] tests/tcg/test-i386-fprem: build with $(QEMU_CFLAGS)

So that glib.h can be found. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/tcg/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile index 89e3342..c946fde 100644 --- a/tests/tcg/Makefile +++ b/tests/tcg/Makefile @@

[Qemu-devel] [PATCH 0/1] qemu-iotests/109: Fix lock race condition

A race condition is currently present between the clean up attempt of the QEMU process and the execution of qemu-img. Cleber Rosa(1): qemu-iotests/109: Fix lock/race condition tests/qemu-iotests/109 | 3 ++- tests/qemu-iotests/109.out | 56

[Qemu-devel] [PATCH 1/1] qemu-iotests/109: Fix lock race condition

and waits for the QEMU process to exit. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/109 | 3 ++- tests/qemu-iotests/109.out | 56 ++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/

Re: [Qemu-devel] Question for iotests 188, 189 and 087

upported_os Linux ... It's trivial to also have access to other compile time settings. I did a quick experiment that would add a "_required_feature" function to "common.rc". For 087 (or 190?) it would look like: ... _supported_fmt qcow2 _supported_proto file _supported_os Linux _required_feature CONFIG_LINUX_AIO ... Does it make sense? Would a patch series along those lines would be welcomed by reviews? Thanks! -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ] signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] Question for iotests 188, 189 and 087

On 07/20/2017 04:37 AM, Jing Liu wrote: > Hi Cleber Rosa, > > > On 2017/7/19 上午5:22, Cleber Rosa wrote: >> >> On 07/18/2017 02:07 PM, John Snow wrote: >>> >>> On 07/17/2017 11:01 PM, Jing Liu wrote: >>> > [...] >> I see issues

Re: [Qemu-devel] Question for iotests 188, 189 and 087

On 07/18/2017 05:47 PM, John Snow wrote: > > > On 07/18/2017 05:22 PM, Cleber Rosa wrote: >> >> >> On 07/18/2017 02:07 PM, John Snow wrote: >>> >>> >>> On 07/17/2017 11:01 PM, Jing Liu wrote: >>>> Hi all, >>>>

[Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

configurations. On top of that, it adds a function to to be used on qemu-iotests. Finally, as an example, it sets a test to be skipped if the required feature is not enable on the host build configuration. Cleber Rosa (3): scripts: introduce buildconf.py qemu-iotests: add _require_feature

[Qemu-devel] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087

One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO. As a PoC/RFC, this goes the easy route and skips the test as a whole when that feature is missing. Other approaches include splitting the test and adding extra filtering. Signed-off-by: Cleber Rosa <cr...@redhat.com>

[Qemu-devel] [PATCH 2/3] qemu-iotests: add _require_feature() function

from the _supported_* family of functions, was chosen to match the style of _require_command(), which seems pretty similar. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/check | 2 ++ tests/qemu-iotests/common.rc | 7 +++ 2 files changed, 9 insertions(+) diff

[Qemu-devel] [PATCH 1/3] scripts: introduce buildconf.py

Signed-off-by: Cleber Rosa <cr...@redhat.com> --- scripts/buildconf.py | 278 +++ 1 file changed, 278 insertions(+) create mode 100755 scripts/buildconf.py diff --git a/scripts/buildconf.py b/scripts/buildconf.py new file mode 100755 index 000..

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On 07/21/2017 08:33 AM, Stefan Hajnoczi wrote: > On Thu, Jul 20, 2017 at 11:47:27PM -0400, Cleber Rosa wrote: >> This is a follow up to a previous discussion about reported failures when >> running some qemu-iotests. Turns out the failures were due to missing >> lib

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On 07/21/2017 10:01 AM, Daniel P. Berrange wrote: > On Fri, Jul 21, 2017 at 01:33:25PM +0100, Stefan Hajnoczi wrote: >> On Thu, Jul 20, 2017 at 11:47:27PM -0400, Cleber Rosa wrote: >>> This is a follow up to a previous discussion about reported failures when >>> runnin

Re: [Qemu-devel] [PATCH 1/3] scripts: introduce buildconf.py

On 07/21/2017 10:00 AM, Eric Blake wrote: > On 07/20/2017 10:47 PM, Cleber Rosa wrote: >> scripts/buildconf.py is a command line utility (but also can be used >> as a Python module) that introspects the build configuration. >> >> It uses the generated host leve

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

ts is not None: self._args.append(opts) FIY, I have a bad feeling about it, but it's quite comparable to add_device(), and it keeps "args" private. -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ] signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

un tests that are expected to PASS within the given feature list. The test runner (run-test-suite.sh) would select only tests that match the features given. No SKIPs would be expected as the outcome of *any test*. The other approach is to let the feature match to the test, and SKIPs would then be

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote: > On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote: >> On 07/21/2017 10:01 AM, Daniel P. Berrange wrote: >>> On Fri, Jul 21, 2017 at 01:33:25PM +0100, Stefan Hajnoczi wrote: >>>> On Thu, Jul 20, 2017 at 11:47

Re: [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code

tderr.write('qemu received signal %i: %s\n' % > (-exitcode, ' '.join(self.args))) > +sys.stderr.write('qemu received signal %i\n' % -exitcode) > + > self._load_io_log() > self._post_shutdown() > > -- Cleber Rosa [ Sr Software Engineer - V

Re: [Qemu-devel] [PATCH v5 4/6] qemu.py: cleanup launch()

if exitcode < 0: > sys.stderr.write('qemu received signal %i\n' % -exitcode) > > -self._load_io_log() > -self._post_shutdown() > +self._load_io_log() > +self._post_shutdown() > > underscore_to_dash

[Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header

comprehend the entire command line: # QEMU configure log Mon Jul 26 08:17:35 EDT 2017 # Configured with: './configure --target-list=x86_64-softmmu' Signed-off-by: Cleber Rosa <cr...@redhat.com> --- configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/con

[Qemu-devel] [PATCH 5/5] docs: fix broken paths to docs/interop dir

With the move of some docs to docs/interop on d59157e, a couple of references where not updated. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- docs/devel/writing-qmp-commands.txt | 2 +- qapi-schema.json| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 3/5] qemu-iotests: remove commented out variables

-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/check | 4 1 file changed, 4 deletions(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 7a2e0d0..437ef65 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -229,8 +229,6 @@

[Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement

The check script contains a commented out root user requirement, probably because of its xfstests heritage. This requirement doesn't apply to qemu-iotests, so it better be gone. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/check | 6 -- 1 file changed, 6 del

[Qemu-devel] [PATCH 2/5] qemu-iotests: get rid of _full_imgproto_details()

Although this function is used, its implementation does nothing besides echoing a variable name. There's no need to wrap this functionality in a function, and based on the one usage it has, it's not even required to adhere to a convention or code style. Signed-off-by: Cleber Rosa <

[Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups

This is a collection of trivial fixes and cleanups. The only expected behavior change is in the output on config.log, as per the first patch. Cleber Rosa(5): configure: remove duplicate single quotes on config.log qemu-iotests: get rid of _full_imgproto_details() qemu-iotests: remove

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

e32: -kernel: requires an argument I also see what I believe is proper handling with invalid kernels (or empty options): $ ./unicore32-softmmu/qemu-system-unicore32 -kernel '' qemu-system-unicore32: Load kernel error: '' Regards, - Cleber. > /* only zImage format supported */ >

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

On 07/26/2017 11:28 AM, Cleber Rosa wrote: > > > On 07/26/2017 11:04 AM, Eduardo Otubo wrote: >> Starting qemu-system-unicore32 without the -kernel parameter results in >> an assert() returns false and aborts qemu. This patch replaces it with a >> proper error

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On 07/26/2017 01:58 PM, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote: >> On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote: >>> On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote: >>>> On 07/21/2017 10:01 AM, Daniel P

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

On 07/26/2017 01:35 PM, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: >> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: >>> On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: >>>> Signed-off-by: Amador Pahim <

Re: [Qemu-devel] Improving QMP test coverage

ause it is IMO a complementary topic, and I believe I understand its use cases. Regards, - Cleber. [1] - http://avocado-framework.readthedocs.io/en/52.0/api/utils/avocado.utils.html#avocado.utils.process.run [2] - http://avocado-framework.readthedocs.io/en/52.0/WritingTests.html#advanced-logging-capa

Re: [Qemu-devel] [PATCH 1/1] QAPI schema: turn example commands/returns into proper JSON

On 08/08/2017 05:13 PM, Eric Blake wrote: > On 08/08/2017 03:53 PM, Cleber Rosa wrote: >> Most QMP commands and returns in the QAPI schema documentation >> are valid "JSON-based wire format". A few examples are either >> malformed, or contain comments. >> &

[Qemu-devel] [PATCH 0/1] QAPI schema: turn example commands/returns into proper JSON

a. Besides allowing humans to copy and paste the examples without surprises, this also paves the way towards automatic execution of examples as tests. Cleber Rosa(1): QAPI schema: turn example commands/returns into proper JSON qapi-schema.json | 9 - qapi/block-core

[Qemu-devel] [PATCH 1/1] QAPI schema: turn example commands/returns into proper JSON

MP monitor. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- qapi-schema.json | 9 - qapi/block-core.json | 32 qapi/rocker.json | 5 + 3 files changed, 21 insertions(+), 25 deletions(-) diff --git a/qapi-schema.json b/qapi-s

Re: [Qemu-devel] Improving QMP test coverage

gt; [2] - >> http://avocado-framework.readthedocs.io/en/52.0/WritingTests.html#advanced-logging-capabilities >> [3] - https://www.youtube.com/watch?v=htUbOsh8MZI > > [*] Very many nutty things are more obviously nuts in shell. It's an > advantage of sorts ;) > We all know a number of amazing software that gets written using the most improbable tools and languages. It makes the world a much more interesting place! [1] - https://docs.python.org/2/library/doctest.html -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ] signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 1/6] tests/tcg/test_path.c: include utils/bufferiszero.c

On 08/02/2017 06:24 PM, Cleber Rosa wrote: > > > On 08/02/2017 05:36 PM, Philippe Mathieu-Daudé wrote: >> Hi Cleber, >> >> On 08/02/2017 05:15 PM, Cleber Rosa wrote: >>> Which contains one specific function used by iov.c. >>> >>> Without

Re: [Qemu-devel] [PATCH] qemu.py: Call logging.basicConfig() automatically

.DEBUG if debug else logging.WARN)) > + > def __enter__(self): > return self > > Your description is accurate, and backed by: https://docs.python.org/3/library/logging.html#logging.basicConfig Quoting the relevant section: "This function does nothing if the root logger already has handlers configured for it." Reviewed-by: Cleber Rosa <cr...@redhat.com>

Re: [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error

On 08/18/2017 01:05 PM, Amador Pahim wrote: > When launching a VM, if an exception happens and the VM is not > initiated, it might be useful to see the qemu command line and > the qemu command output. > > This patch creates that message. Notice that self._iolog needs to be > cleaned up in the

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

har **argv) >> qtest_add_func("/netfilter/remove_netdev_multi", >> remove_netdev_with_multi_netfilter); >> >> -qtest_start("-netdev user,id=qtest-bn0 -device e1000,netdev=qtest-bn0"); >> +args = g_strdup_printf("-netdev user,id=qtest-bn0 " >> + "-device %s,netdev=qtest-bn0", devstr); >> +qtest_start(args); >> ret = g_test_run(); >> >> qtest_end(); >> +g_free(args); >> >> return ret; >> } > > Even though I think we should deal with the questions above, having > more tests for s390x is certainly a good idea. Thus, > > Reviewed-by: Cornelia Huck <coh...@redhat.com> > Seconded: the network device selection is a different problem. Reviewed-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 1/6] tests: Run filter-redirector and -mirror test only on POSIX systems

./configure --cross-prefix=i686-w64-mingw32- $ make $ make tests/test-filter-mirror.exe ... CC tests/test-filter-redirector.o tests/test-filter-redirector.c: In function 'test_redirector_tx': tests/test-filter-redirector.c:72:11: error: implicit declaration of function 'socketpair'; did you mean 'socket_init'? [-Werror=implicit-function-declaration] ... Which is supposed to fail. Tested-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

es also test coverage if we do not >> use the same PCI NIC in all the tests...? > > It just looks like a bit of unneeded churn to me. > > Re coverage: Do we have a very simple test that we can run for all kind > of NICs? This would give some reliable testing for various devices

Re: [Qemu-devel] [PATCH v2 2/2] tests: Make vmgenid test compile

t32_t acpi_find_vgia(void) > AcpiRsdpDescriptor rsdp_table; > uint32_t rsdt; > AcpiRsdtDescriptorRev1 rsdt_table; > -int tables_nr; > +size_t tables_nr; > uint32_t *tables; > AcpiTableHeader ssdt_table; > VgidTable vgid_table; > Tested-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 1/2] tests: Use real size for iov tests

sz; ++j) { > k = i; > - iov_memset(iov, niov, 0, 0xff, -1); > + iov_memset(iov, niov, 0, 0xff, sz); > do { > s = g_test_rand_int_range(0, j - k + 1); > r = iov_recv(sv[0], iov, niov, k, s); > Tested-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 3/6] tests: Enable the drive_del test also on s390x

t;) || > -!strcmp(arch, "ppc") || !strcmp(arch, "ppc64")) { > +!strcmp(arch, "ppc") || !strcmp(arch, "ppc64") || > +!strcmp(arch, "s390x")) { > qtest_add_func("/drive_del/after_failed_device_add", > test_after_failed_device_add); > qtest_add_func("/blockdev/drive_del_device_del", > I honestly can't comment on the device to be used on this test (as others have commented). Putting that aside, and given the fact that I went through the lengths of testing it on the s390x target: Tested-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 04/10] tests: Add ubuntu.i386 image

f.wait_ssh() > +self.ssh_root_check("touch /etc/cloud/cloud-init.disabled") > +self.ssh_root_check("apt-get update") > +self.ssh_root_check("apt-get install -y cloud-initramfs-growroot") > +# Don't check the status in case the guest hang up too qu

Re: [Qemu-devel] [PATCH v3 05/10] tests: Add FreeBSD image

turn > +cimg = > self._download_with_cache("http://download.patchew.org/freebsd.img.xz;, > + > sha256sum='adcb771549b37bc63826c501f05121a206ed3d9f55f49145908f7e1432d65891') > +img_tmp_xz = img + ".tmp.xz" > +img_tmp = img + &q

Re: [Qemu-devel] [PATCH v3 07/10] tests: Add OpenBSD image

= img + ".tmp.xz" > + img_tmp = img + ".tmp" > +subprocess.check_call(["cp", "-f", cimg, img_tmp_xz]) > +subprocess.check_call(["xz", "-df", img_tmp_xz]) > +os.rename(img_tmp, img) > + > +if __name__ == "__main__": > +sys.exit(basevm.main(OpenBSDVM)) > -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ] signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

tch the "build environment setup" automation to use a more generic tool such as ansible? Having an in-tree playbook that could be executed against a VM seems like slightly better than syncing the WIKI pages. I'm no expert in ansible, but I can give it that a try if you fancy the idea. -

Re: [Qemu-devel] [PATCH v3 06/10] tests: Add NetBSD image

".tmp.xz" > + img_tmp = img + ".tmp" > +subprocess.check_call(["cp", "-f", cimg, img_tmp_xz]) > +subprocess.check_call(["xz", "-df", img_tmp_xz]) > +os.rename(img_tmp, img) > + > +if __name__ == "__main__": > +sys.exit(basevm.main(NetBSDVM)) > -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ] signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] make check speed

eason and yes, it's most certainly timeout issue. The problem with > Travis is it gives quite decent power, but sometimes it's slowed for couple > of seconds, or even minutes. This affects many of our (Avocado) selftests so > we usually have timeouts between 10-60s for operations that

Re: [Qemu-devel] [PATCH v6 01/10] qemu.py: Pylint/style fixes

be a recursive subset of the 'event'; skips > +branch processing on match's value None > + {"foo": {"bar": 1}} matches {"foo": None} > + {"foo": {"bar": 1}} does not matches {"foo": {"baz": None}} > +''' > def event_match(event, match=None): > if match is None: > return True > @@ -226,4 +259,8 @@ class QEMUMachine(object): > return None > > def get_log(self): > +''' > +After self.shutdown or failed qemu execution, this returns the output > +of the qemu process. > +''' > return self._iolog > Reviewed-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v6 03/10] qemu.py: Use iteritems rather than keys()

t; +qmp_args[key] = value > > return self._qmp.cmd(cmd, args=qmp_args) > > Yep, I could tell this was coming while reading patch 01. Reviewed-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v6 02/10] qemu|qtest: Avoid dangerous arguments

class QEMUQtestProtocol(object): > class QEMUQtestMachine(qemu.QEMUMachine): > '''A QEMU VM''' > > -def __init__(self, binary, args=[], name=None, test_dir="/var/tmp", > +def __init__(self, binary, args=None, name=None, test_dir="/var/tmp", > socket_scm_helper=None): > if name is None: > name = "qemu-%d" % os.getpid() > Reviewed-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v6 04/10] qemu.py: Simplify QMP key-conversion

-qmp_args[key.translate(self.underscore_to_dash)] = value > +qmp_args[key.replace('_', '-')] = value > else: > qmp_args[key] = value > > Right, this would only make sense if multiple (different) substitutions were necessary. Reviewed-by: Cleber Rosa <cr...@redhat.com> signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] Make test

Error 1 > make: *** [test] Error 2 > > I went through the same experience, and reported it (in the form of patches) here: http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg00378.html Although it looks like you're clang, so it'd be nice to check if these fixes work for

Re: [Qemu-devel] Make test

> I think the removing the `make test` target is a good thing, if its tests are either absorbed by an existing `make check*` one. Now that depends on what people think the tcg tests (and others) deserve... TLC? Total annihilation? -- Cleber Rosa [ Sr Software Engineer - Virtualization

Re: [Qemu-devel] Make test

08799/xsh/unistd.h.html > Then again this page states you should be able to do a "#include " > on your posix compatible platform. > > Thank you. > I'll take a look and attempt a more portable fix on a v2. Regards! -- Cleber Rosa [ Sr Software Engineer - Virtualization Team

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

On 11/17/2017 02:19 AM, Paolo Bonzini wrote: > On 16/11/2017 18:38, Cleber Rosa wrote: >> This variables has no real use. To avoid pretending it does, while >> still keeping the information, let's turn it into a comment. >> >> The format chosen is the one already bein

Re: [Qemu-devel] [Qemu-block] [PATCH 01/10] qemu-iotests: make execution of tests agnostic to test type

On 11/17/2017 02:25 AM, Paolo Bonzini wrote: > On 16/11/2017 18:38, Cleber Rosa wrote: >> check makes a distinction on how it runs Python based tests. The >> current approach is inconsistent because: >> >> 1) a large number of Python tests are already set as execut

Re: [Qemu-devel] [PATCH v3 2/2] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

he test file 181 authored > by Kevin Wolf. > > CC: Kevin Wolf <kw...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > CC: Cleber Rosa <cr...@redhat.com> > Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> > > --- > I CCed Cleb

[Qemu-devel] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

This variables has no real use. To avoid pretending it does, while still keeping the information, let's turn it into a comment. The format chosen is the one already being used on tests 149 and 194. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/001 | 5 ++--- test

[Qemu-devel] [PATCH 05/10] qemu-iotests: define functions used in _cleanup() before its use

some tabs versus spaces indentation in _cleanup() in a few tests. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/001 | 6 +++--- tests/qemu-iotests/002 | 6 +++--- tests/qemu-iotests/003 | 6 +++--- tests/qemu-iotests/004 | 6 +++--- tests/qemu-iotests/00

[Qemu-devel] [PATCH 01/10] qemu-iotests: make execution of tests agnostic to test type

it with "$SHELL $test_file", but it'd be pointless IMO, there's no value in the distinction that check makes. Dropping this distinction makes the interface simpler: check requires an executable file. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/096 | 0 tests/

[Qemu-devel] [PATCH 10/10] qemu-iotests: add section on how to write a new I/O test

, general workflow proposed for writing a new test, etc. After feedback is received, I can go over and sync both sides (wiki and README). Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/README | 44 ++-- tests/qemu-iotests/sample_test_tem

[Qemu-devel] [PATCH 00/10] I/O tests cleanups

ges to how tests are executed and verified. Thanks! --- Cleber Rosa (10): qemu-iotests: add section on how to write a new I/O test qemu-iotests: remove unused "here" variable qemu-iotests: clean up double comment characters qemu-iotests: remove the concept of $seq.full (a

[Qemu-devel] [PATCH 02/10] qemu-iotests: fix filename containing checks

Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/common.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test

[Qemu-devel] [PATCH 08/10] qemu-iotests: clean up double comment characters

This is a syntactic only change, just to make it consistent with the style used on all other tests. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/048 | 37 ++--- tests/qemu-iotests/074 | 40 2

[Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable

Another legacy variable that did not convince me it has any purpose whatsoever. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/001 | 1 - tests/qemu-iotests/002 | 1 - tests/qemu-iotests/003 | 1 - tests/qemu-iotests/004 | 1 - tests/qemu-iotests/005 | 1 - test

[Qemu-devel] [PATCH 03/10] qemu-iotests: be strict with expected output

ot similar) to the recorded expected output. Let's drop this exception and make things more predictable. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/026.out | 92 +++--- tests/qemu-iotests/049.out | 4 +- tests/qemu-iote

[Qemu-devel] [PATCH 07/10] qemu-iotests: remove the concept of $seq.full (and boiler plate code)

this function. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/001 | 1 - tests/qemu-iotests/002 | 1 - tests/qemu-iotests/003 | 1 - tests/qemu-iotests/004 | 1 - tests/qemu-iotests/005 | 1 - tests/qemu-iotests/007 | 1 - tests/qemu-iotests/008 | 1 - tests/qemu-iotes

[Qemu-devel] [PATCH 04/10] qemu-iotests: include (source) filters from common.rc

the amount of boiler plate code (while still making the comment found on almost every test "get standard environment, filters and checks" accurate. Signed-off-by: Cleber Rosa <cr...@redhat.com> --- tests/qemu-iotests/001 | 1 - tests/qemu-iotests/002 | 1 - tests/qemu-iotes

Re: [Qemu-devel] [RFC 01/24] qemu.py: Introduce _create_console() method

On 04/20/2018 03:56 PM, Eduardo Habkost wrote: > On Fri, Apr 20, 2018 at 03:19:28PM -0300, Eduardo Habkost wrote: >> From: Amador Pahim >> >> This patch adds the QEMUMachine._create_console() method, which >> returns a list with the chardev console device arguments to be >>

Re: [Qemu-devel] Publishing binary images for testing (was Re: [RFC PATCH 0/6] generic way to deprecate machines)

rsions of guest images. For Avocado-VT, there are the JeOS images[1], which we keep on a test "assets" directory. We have a lot of storage/bandwidth availability, so it can be used for other assets proven to be necessary for tests. As long as distribution rights and licensing are not issu

  1   2   3   4   5   6   7   8   9   10   >