[PATCH 11/16] tests/acceptance/boot_xen.py: fetch kernel during test setUp()

2021-09-24 Thread Cleber Rosa
The kernel is a common blob used in all tests. By moving it to the setUp() method, the "fetch asset" plugin will recognize the kernel and attempt to fetch it and cache it before the tests are started. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_xen.py | 13 ++-

[PATCH 10/16] tests/acceptance/boot_xen.py: unify tags

2021-09-24 Thread Cleber Rosa
Because all tests share the same tags, it's possible to have all of them at the class level. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_xen.py | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/tests/acceptance/boot_xen.py b/

[PATCH 07/16] Acceptance Tests: workaround expired mipsdistros.mips.com HTTPS cert

2021-09-24 Thread Cleber Rosa
ff-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 6 +++--- tests/acceptance/replay_kernel.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 80e3a2f7a6..bc0caa1099 1

[PATCH 09/16] tests/acceptance/boot_xen.py: merge base classes

2021-09-24 Thread Cleber Rosa
While it's a good practice to have reusable base classes, in this specific case there's no other user of the BootXenBase class. By unifying the class used in this test, we can improve readability and have the opportunity to add some future improvements in a clearer fashion. Signed-off-

[PATCH 03/16] Acceptance Tests: add mechanism for listing tests

2021-09-24 Thread Cleber Rosa
It is helpful to know the tests that would be executed with a "make check-acceptance" without executing them. Let's introduce a "make list-acceptance" rule for that purpose. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 8 1 file changed, 8 insertio

[PATCH 06/16] Acceptance Tests: use extract from package from avocado.utils

2021-09-24 Thread Cleber Rosa
om_package Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 84 ++ tests/acceptance/boot_xen.py | 6 +- tests/acceptance/replay_kernel.py | 12 ++-- tests/acceptance/tcg_plugins.py| 2 +- 4 files changed, 41 insertions(+), 63

[PATCH 01/16] Acceptance Tests: bump Avocado requirement to 91.0

2021-09-24 Thread Cleber Rosa
implementation to be used by those that choose to do so. More information can be found at the release notes at: https://avocado-framework.readthedocs.io/en/latest/releases/91_0.html Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 12 tests/Makefile.include | 2 ++ tests/requi

[PATCH 08/16] acceptance/tests/vnc.py: use explicit syntax for enabling passwords

2021-09-24 Thread Cleber Rosa
This matches the command line on 82a17d1d67, where the "on" or "off" should be explicitly given. Signed-off-by: Cleber Rosa --- tests/acceptance/vnc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acceptance/vnc.py b/tests/acceptance/vnc

[PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements

2021-09-24 Thread Cleber Rosa
proposal is a convention to tag tests that either have known issues, or that touch on QEMU features that have known issues. By tagging those tests accordingly, they will be automatically excluded from the regular execution with "make check-acceptance". Finally, some updates to as

[PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown()

2021-09-24 Thread Cleber Rosa
Maydell Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 2c4fef3e14..1e807e2e55 100644 --- a/tests/acceptance/avocado_qemu/__init__

[PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

2021-08-03 Thread Cleber Rosa
lable unintentionally by a third party. Signed-off-by: Cleber Rosa --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 37b1a8e442..d35b948e8d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile F:

[PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry

2021-08-03 Thread Cleber Rosa
This is a reply to an issue[1] reported by Peter, and while at it, an update of the MAINTAINERS entry so other people now the status and where to go for help with regards to the acceptance tests' infrastructure. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html Cleber

[PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

2021-08-03 Thread Cleber Rosa
Maydell Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 2c4fef3e14..1e807e2e55 100644 --- a/tests/acceptance/avocado_qemu/__init__

Re: 'make check-acceptance' eats lots of disk space and never cleans it up

2021-08-03 Thread Cleber Rosa
On Tue, Aug 3, 2021 at 9:47 AM Peter Maydell wrote: > > On Tue, 3 Aug 2021 at 13:58, Cleber Rosa wrote: > > > > On Tue, Aug 3, 2021 at 8:43 AM Peter Maydell > > wrote: > > > > > > It looks like 'make check-acceptance' creates directories i

Re: 'make check-acceptance' eats lots of disk space and never cleans it up

2021-08-03 Thread Cleber Rosa
On Tue, Aug 3, 2021 at 8:43 AM Peter Maydell wrote: > > It looks like 'make check-acceptance' creates directories in > build/clang/tests/results which are huge and which it never > cleans up. For example one of my build directories (configured > just for arm targets) has over 350 'job-[timestamp]'

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Cleber Rosa
On Sat, Jul 31, 2021 at 4:33 PM Peter Maydell wrote: > > On Sat, 31 Jul 2021 at 19:43, Alex Bennée wrote: > > > > > > Peter Maydell writes: > > > > > "make check-acceptance" takes way way too long. I just did a run > > > on an arm-and-aarch64-targets-only debug build and it took over > > > half

Re: "make check-acceptance" takes way too long

2021-07-31 Thread Cleber Rosa
On Sat, Jul 31, 2021 at 2:40 AM Thomas Huth wrote: > > On 31/07/2021 00.04, Cleber Rosa wrote: > > On Fri, Jul 30, 2021 at 11:43 AM Peter Maydell > > wrote: > >> > >> On Fri, 30 Jul 2021 at 16:12, Peter Maydell > >> wrote: > >>> > &g

Re: "make check-acceptance" takes way too long

2021-07-30 Thread Cleber Rosa
On Fri, Jul 30, 2021 at 11:43 AM Peter Maydell wrote: > > On Fri, 30 Jul 2021 at 16:12, Peter Maydell wrote: > > > > "make check-acceptance" takes way way too long. I just did a run > > on an arm-and-aarch64-targets-only debug build and it took over > > half an hour, and this despite it skipping

Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-27 Thread Cleber Rosa
On Tue, Jul 27, 2021 at 9:48 AM Peter Maydell wrote: > > On Tue, 27 Jul 2021 at 14:24, Cleber Rosa wrote: > > Yes, I've spent quite some time with some flaky behavior while running > > the replay tests as well. But in the end, the test remained unchanged > > becau

Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-27 Thread Cleber Rosa
On Tue, Jul 27, 2021 at 5:17 AM Peter Maydell wrote: > > On Tue, 27 Jul 2021 at 01:39, Cleber Rosa wrote: > > tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt > > is currently failing consistently (first found that in [1]). > > FWIW I find that on my

Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-27 Thread Cleber Rosa
On Tue, Jul 27, 2021 at 3:37 AM Peter Maydell wrote: > > On Tue, 27 Jul 2021 at 01:39, Cleber Rosa wrote: > > > > > > Hi everyone, > > > > tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt > > is currently failing consistently (first

Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-26 Thread Cleber Rosa
tps://gitlab.com/qemu-project/qemu/-/jobs/1445513133#L268 -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Cleber Rosa
wangyanan (Y) writes: > Hi Cleber, > > On 2021/7/23 6:25, Cleber Rosa wrote: >> Yanan Wang writes: >> >>> In the SMP configuration, we should either specify a topology >>> parameter with a reasonable value (equal to or greater than 1) >>> or j

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Cleber Rosa
Yanan Wang writes: > In the SMP configuration, we should either specify a topology > parameter with a reasonable value (equal to or greater than 1) > or just leave it omitted and QEMU will calculate its value. > Configurations which explicitly specify the topology parameters > as zero like "sock

Re: [PATCH-for-6.1 v2] gitlab-ci: Extract OpenSBI job rules and fix 'when' condition

2021-07-22 Thread Cleber Rosa
an Rampazzo > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: when 'always' -> 'on_success' & reworded (danpb) > > Supersedes: <20210720164829.3949558-1-phi...@redhat.com> > --- > .gitlab-ci.d/opensbi.yml | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) > Reviewed-by: Cleber Rosa

Re: [PATCH for-6.1 2/2] docs: Move licence/copyright from HTML output to rST comments

2021-07-22 Thread Cleber Rosa
system/generic-loader.rst | 4 ++-- > 3 files changed, 13 insertions(+), 10 deletions(-) Reviewed-by: Cleber Rosa

Re: [PATCH for-6.1 1/2] docs: Remove stale TODO comments about license and version

2021-07-22 Thread Cleber Rosa
ell > --- > docs/interop/qemu-ga-ref.rst | 9 - > docs/interop/qemu-qmp-ref.rst| 9 - > docs/interop/qemu-storage-daemon-qmp-ref.rst | 9 - > 3 files changed, 27 deletions(-) > Reviewed-by: Cleber Rosa

[PULL 3/7] tests/acceptance/virtio-gpu.py: combine CPU tags

2021-07-20 Thread Cleber Rosa
Like previously done with the arch tags, all tests use the same CPU value so it's possible to combine them at the class level. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-4-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/accept

[PULL 1/7] tests/acceptance/virtio-gpu.py: use require_accelerator()

2021-07-20 Thread Cleber Rosa
Since efe30d501 there's a shorthand for requiring specific accelerators, and canceling the test if it's not available. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-2-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptan

[PULL 2/7] tests/acceptance/virtio-gpu.py: combine x86_64 arch tags

2021-07-20 Thread Cleber Rosa
The test class in question is x86_64 specific, so it's possible to set the tags at the class level. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-3-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 3

[PULL 4/7] tests/acceptance/virtio-gpu.py: combine kernel command line

2021-07-20 Thread Cleber Rosa
Both tests use the same kernel command line arguments, so there's no need to have a common and then an additional set of arguments. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-5-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests

[PULL 5/7] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-20 Thread Cleber Rosa
Since 49afbca3b, the use of an optional virgl renderer is not available anymore, and since b36eb8860f, the way to choose a GL based rendered is to use the "virtio-vga-gl" device. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-6-cr...@redhat.com> Reviewed-by:

[PULL 7/7] remote/memory: Replace share parameter with ram_flags

2021-07-20 Thread Cleber Rosa
588-1-yang.zh...@intel.com> Signed-off-by: Cleber Rosa --- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/remote/memory.c b/hw/remote/memory.c index 472ed2a272..6e21ab1a45 100644 --- a/hw/remote/memory.c +++ b/hw/remote/memory.c @@ -46,7 +46,7 @@ void remote

[PULL 6/7] tests/acceptance/virtio-gpu.py: provide kernel and initrd hashes

2021-07-20 Thread Cleber Rosa
By providing kernel and initrd hashes, the test guarantees the integrity of the images used and avoids the warnings set by fetch_asset() when hashes are lacking. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-7-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by:

[PULL for 6.1 0/7] Python and Acceptance Tests

2021-07-20 Thread Cleber Rosa
he mailing list. -------- Cleber Rosa (6): tests/acceptance/virtio-gpu.py: use require_accelerator() tests/acceptance/virtio-gpu.py: combine x86_64 arch tags tests/acceptance/virtio-gpu.py: combine CPU tags tests/acceptance/virtio-gpu.py: combine kernel command line tests/acceptance/vir

Re: tests/acceptance/multiprocess.py test failure

2021-07-20 Thread Cleber Rosa
Jag Raman writes: > > Hi Cleber, > > We presently don’t have permissions to send a PR to > upstream (Peter Maydell). > > Presently, we are requesting someone else who has > permissions to do PRs on our behalf. We will work > on getting permissions to send PRs going forward. > > Thank you! Hi Ja

Re: tests/acceptance/multiprocess.py test failure

2021-07-15 Thread Cleber Rosa
Sorry for missing that patch on the ml. Maintainers (Elena, Jagannathan, John), Are you planning a PR with this patch? Thanks, -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

tests/acceptance/multiprocess.py test failure

2021-07-14 Thread Cleber Rosa
Hi everyone, The tests/acceptance/multiprocess.py:Multiprocess.test_multiprocess_x86_64 is currently failing (as of a9649a719a44894b81f38dc1c5c1888ee684acef). Unfortunately CI was unable to catch this issue earlier, because tests that require KVM are not yet running (but this should change soon).

Re: [PATCH-for-6.1] gitlab-ci: Extract EDK2 job rules to reusable section

2021-07-14 Thread Cleber Rosa
AGE =~ /edk2/i' # or last commit description contains > 'EDK2' > - when: always > artifacts: > paths: # 'artifacts.zip' will contains the following files: > - pc-bios/edk2*bz2 Hi Phil, This looks good, but have you triggered a pipeline with these changes? It'd be helpful for an extra level of assurance for the intended results. Thanks! -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

[PATCH 4/6] tests/acceptance/virtio-gpu.py: combine kernel command line

2021-07-14 Thread Cleber Rosa
Both tests use the same kernel command line arguments, so there's no need to have a common and then an additional set of arguments. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/tests/accep

[PATCH 6/6] tests/acceptance/virtio-gpu.py: provide kernel and initrd hashes

2021-07-14 Thread Cleber Rosa
By providing kernel and initrd hashes, the test guarantees the integrity of the images used and avoids the warnings set by fetch_asset() when hashes are lacking. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH 5/6] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-14 Thread Cleber Rosa
Since 49afbca3b, the use of an optional virgl renderer is not available anymore, and since b36eb8860f, the way to choose a GL based rendered is to use the "virtio-vga-gl" device. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 3/6] tests/acceptance/virtio-gpu.py: combine CPU tags

2021-07-14 Thread Cleber Rosa
Like previously done with the arch tags, all tests use the same CPU value so it's possible to combine them at the class level. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/acceptance/virtio-gpu

[PATCH 2/6] tests/acceptance/virtio-gpu.py: combine x86_64 arch tags

2021-07-14 Thread Cleber Rosa
The test class in question is x86_64 specific, so it's possible to set the tags at the class level. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-g

[PATCH for 6.1 0/6] virtio-gpu acceptance test: use current device name

2021-07-14 Thread Cleber Rosa
oft freeze, I can re-send patch 5 by itself. Cleber Rosa (6): tests/acceptance/virtio-gpu.py: use require_accelerator() tests/acceptance/virtio-gpu.py: combine x86_64 arch tags tests/acceptance/virtio-gpu.py: combine CPU tags tests/acceptance/virtio-gpu.py: combine kernel command line tes

[PATCH 1/6] tests/acceptance/virtio-gpu.py: use require_accelerator()

2021-07-14 Thread Cleber Rosa
Since efe30d501 there's a shorthand for requiring specific accelerators, and canceling the test if it's not available. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/acceptance/virti

[PULL 15/23] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta The tests that are already tagged with "cpu:VALUE" don't need to add "-cpu VALUE" to the list of arguments of the vm object because the avocado_qemu framework is able to handle it automatically. Reviewed-by: Cleber Rosa Tested-by:

[PULL 23/23] tests/acceptance/cpu_queries.py: use the proper logging channels

2021-07-13 Thread Cleber Rosa
The test contains methods for the proper log of test related information. Let's use that and remove the print and the unused logging import. Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log Signed-off-by: Cleber Rosa Messa

[PULL 22/23] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-07-13 Thread Cleber Rosa
These tests' setUp do not do anything beyong what their base class do. And while they do decorate the setUp() we can decorate the classes instead, so no functionality is lost here. This is possible because since Avocado 76.0 we can decorate setUp() directly. Signed-off-by: Cleber Rosa Me

[PULL 18/23] tests/acceptance: Add set_vm_arg() to the Test class

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta The set_vm_arg method is added to avocado_qemu.Test class on this change. Use that method to set (or replace) an argument to the list of arguments given to the QEMU binary. Suggested-by: Cleber Rosa Signed-off-by: Wainer dos Santos Moschetta Reviewed-by

[PULL 12/23] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

2021-07-13 Thread Cleber Rosa
os:netbsd tests/acceptance/ Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210623180021.898286-4-f4...@amsat.org> Reviewed-by: Niek Linnenbank Reviewed-by: Willian Rampazzo Reviewed-by: Cleber Rosa [PMD: ammend the commit message with example command] Signed-off-by: Cleber Rosa ---

[PULL 19/23] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests

2021-07-13 Thread Cleber Rosa
() to overwrite the -cpu value. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Message-Id: <20210430133414.39905-8-waine...@redhat.com> Signed-off-by: Cleber Rosa --- tests/acceptance/x86_cpu_model_versions.py | 40 +- 1 file changed, 32 inse

[PULL 21/23] Acceptance tests: do not try to reuse packages from the system

2021-07-13 Thread Cleber Rosa
from tests run on different machines; With regards to downloads, pip already caches the downloaded wheels and tarballs under ~/.cache/pip, so there should not be more than one download even if the venv is destroyed and recreated. Signed-off-by: Cleber Rosa Message-Id: <20210415215141.1865

[PULL 16/23] tests/acceptance: Tagging tests with "cpu:VALUE"

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta The existing tests which are passing "-cpu VALUE" argument to the vm object are now properly "cpu:VALUE" tagged, so letting the avocado_qemu framework to handle that automatically. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo S

[PULL 20/23] python: Configure tox to skip missing interpreters

2021-07-13 Thread Cleber Rosa
Santos Moschetta Message-Id: <20210630184546.456582-1-waine...@redhat.com> Reviewed-by: Willian Rampazzo Reviewed-by: John Snow Signed-off-by: Cleber Rosa --- .gitlab-ci.d/static_checks.yml | 1 + python/Makefile| 5 - python/setup.cfg | 1 + 3 files chan

[PULL 17/23] python/qemu: Add args property to the QEMUMachine class

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta This added the args property to QEMUMachine so that users of the class can access and handle the list of arguments to be given to the QEMU binary. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta Message-Id

[PULL 08/23] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-07-13 Thread Cleber Rosa
ssage-Id: <20210706131729.30749-2-eric.au...@redhat.com> [CR: moved aarch64 definition from patch 2 to 1] [CR: protect get() when arch is not defined] [CR: split long lines] Acked-by: Wainer dos Santos Moschetta Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__ini

[PULL 14/23] tests/acceptance: Fix mismatch on cpu tagged tests

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta There are test cases on machine_mips_malta.py and tcg_plugins.py files where the cpu tag does not correspond to the value actually given to the QEMU binary. This fixed those tests tags. Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian

[PULL 04/23] Acceptance Tests: rename attribute holding the distro image checksum

2021-07-13 Thread Cleber Rosa
make the naming of those more uniform. Signed-off-by: Cleber Rosa Message-Id: <20210414221457.1653745-2-cr...@redhat.com> Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Eric Auger Reviewed-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé [CR: split long lines] Signed-off

[PULL 13/23] tests/acceptance: Automatic set -cpu to the test vm

2021-07-13 Thread Cleber Rosa
display none -vga none \ -chardev socket,id=mon,path=/var/tmp/avo_qemu_sock_pdgzbgd_/qemu-1135557-monitor.sock \ -mon chardev=mon,mode=control -cpu host Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta Message-Id: &

[PULL 07/23] tests/acceptance: Ignore binary data sent on serial console

2021-07-13 Thread Cleber Rosa
text string anyway). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210515134555.307404-2-f4...@amsat.org> Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 7 +-- 1 file chang

[PULL 10/23] avocado_qemu: Add SMMUv3 tests

2021-07-13 Thread Cleber Rosa
: <20210706131729.30749-4-eric.au...@redhat.com> [CR: split long lines] [CR: added MAINTAINERS entry] Signed-off-by: Cleber Rosa --- MAINTAINERS | 1 + tests/acceptance/smmu.py | 137 +++ 2 files changed, 138 insertions(+) create mode 100644 tests/acceptance/s

[PULL 02/23] Acceptance Tests: log information when creating QEMUMachine

2021-07-13 Thread Cleber Rosa
Including its base temporary directory, given that information useful for debugging can be put there. Signed-off-by: Cleber Rosa Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20210211220146.2525771-5-cr...@redhat.com> Signed-off-by: Cleber Rosa --- tests/acceptance/avocad

[PULL 11/23] avocado_qemu: Add Intel iommu tests

2021-07-13 Thread Cleber Rosa
: <20210706131729.30749-5-eric.au...@redhat.com> [CR: split long lines] Signed-off-by: Cleber Rosa --- tests/acceptance/intel_iommu.py | 119 1 file changed, 119 insertions(+) create mode 100644 tests/acceptance/intel_iommu.py diff --git a/tests/acceptance/intel_iommu.py b

[PULL 06/23] Acceptance Tests: support choosing specific distro and version

2021-07-13 Thread Cleber Rosa
e pre-caching of the Fedora 31 images done during the early stages of `make check-acceptance` (before the tests are actually executed) are not expanded here to cover every new image added. But, the tests will download other needed images (and cache them) during the first execution. Signed-off-by: Cleber

[PULL 01/23] Acceptance Tests: use the job work directory for created VMs

2021-07-13 Thread Cleber Rosa
ce: https://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.workdir Reference: https://avocado-framework.readthedocs.io/en/85.0/config/index.html#run-keep-tmp Signed-off-by: Cleber Rosa Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: John Snow Message-Id: <20210211220146.252

[PULL 09/23] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection

2021-07-13 Thread Cleber Rosa
Rampazzo Message-Id: <20210706131729.30749-3-eric.au...@redhat.com> [CR: split long lines] Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 58 +-- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/avocado_qemu/__init__

[PULL 05/23] Acceptance Tests: move definition of distro checksums to the framework

2021-07-13 Thread Cleber Rosa
tests can still define a distro_checksum value if for some reason they want to override the known distribution information. Signed-off-by: Cleber Rosa Message-Id: <20210414221457.1653745-3-cr...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Acked-by: Eric Auger [CR: split long lines] Si

[PULL 03/23] Acceptance Tests: distinguish between temp and logs dir

2021-07-13 Thread Cleber Rosa
. Signed-off-by: Cleber Rosa Message-Id: <20210211220146.2525771-6-cr...@redhat.com> Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Cleber Rosa --- python/qemu/machine/machine.py| 17 ++--- tests/acceptance/avocado_qemu/__init__.py | 3 ++- 2 files chang

[PULL 00/23] Python and Acceptance Tests

2021-07-13 Thread Cleber Rosa
and Intel IOMMU tests - Respect "cpu" tags and reduce boiler plate code - Improved logging of qemu execution output - Other misc improvements -------- Cleber Rosa (9): Acceptance Tests: use the job work directory for created VM

Re: [PATCH v1 1/2] tests/acceptance: move pkg extraction to avocado_qemu/

2021-07-13 Thread Cleber Rosa
Claudio Fontana writes: > currently these utility functions are present only in boot_linux_console.py, > but they are useful in general, not just for linux. > > In order to reuse them for a firmware test with OVMF, make these functions > general utility functions inside avocado_qemu/ , from wher

Re: [PATCH 4/9] tests/acceptance: Extract image_expand() helper

2021-07-13 Thread Cleber Rosa
Philippe Mathieu-Daudé writes: > To be able to expand an image to a non-power-of-2 value, > extract image_expand() from image_pow2ceil_expand(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 14 +- > 1 file changed, 9 insertions(+), 5 de

Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

2021-07-13 Thread Cleber Rosa
é > --- > tests/acceptance/boot_linux_console.py | 1 + > tests/acceptance/ppc_prep_40p.py | 2 ++ > 2 files changed, 3 insertions(+) Reviewed-by: Cleber Rosa Phil, I can ammend the commit message and queue this one if you think it's a good idea. Cheers, - Cleber.

[PATCH] tests/acceptance: Add tests for the Pegasos2 machine

2021-07-12 Thread Cleber Rosa
NCEL 0 JOB TIME : 34.42 s Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Cleber Rosa --- tests/acceptance/machine_ppc_pegasos.py | 103 1 file changed, 103 insertions(+) create mode 100644 tests/acceptance/machine_ppc_pegasos.py diff --git a/tests/acceptance/ma

Re: [PATCH 2/2] tests/acceptance: Add tests for the Pegasos2 machine

2021-07-12 Thread Cleber Rosa
Wainer dos Santos Moschetta writes: > Hi, > > On 5/15/21 10:45 AM, Philippe Mathieu-Daudé wrote: >> Add a pair of tests for the Pegasos2 machine following the steps from: >> https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html >> >>$ PEGASOS2_ROM_PATH=/tmp/pegasos2.rom AVOC

Re: [PATCH v5 1/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-07-12 Thread Cleber Rosa
On 7/8/21 3:32 PM, Eric Auger wrote: Hi Cleber, On 7/8/21 7:34 PM, Cleber Rosa wrote: On 7/8/21 4:56 AM, Eric Auger wrote: I am not sufficiently expert on the test infra and python to be really efficient fixing that. Can anyone help quickly to target the soft freeze? Otherwise, today I will

Re: [PATCH v5 1/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-07-08 Thread Cleber Rosa
On 7/8/21 4:56 AM, Eric Auger wrote: I am not sufficiently expert on the test infra and python to be really efficient fixing that. Can anyone help quickly to target the soft freeze? Otherwise, today I will drop that patch and restore the code I had in v4, just based on Cleber series. I think t

Re: [PATCH 0/3] Acceptance Tests: support choosing specific distro and version

2021-07-08 Thread Cleber Rosa
On 6/9/21 8:11 AM, Eric Auger wrote: Hi CLeber, On 4/15/21 12:14 AM, Cleber Rosa wrote: Because Fedora 31 will not suit all tests that depend on a Linux guest, this allows for the configuration of the guest distribution. It came out of a suggestion from Eric Auger, and it was actually a

Re: [PATCH 2/3] Acceptance Tests: move definition of distro checksums to the framework

2021-07-08 Thread Cleber Rosa
On 4/22/21 3:56 AM, Auger Eric wrote: Hi Cleber, On 4/15/21 12:14 AM, Cleber Rosa wrote: Instead of having, by default, the checksum in the tests, and the definition of tests in the framework, let's keep them together. A central definition for distributions is available, and it should

Re: [PATCH v5 2/4] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection

2021-07-07 Thread Cleber Rosa
On 7/6/21 9:17 AM, Eric Auger wrote: From: Willian Rampazzo When running LinuxTests we may need to run the guest with custom params. It is practical to store the pxeboot URL and the default kernel params so that the tests just need to fetch those and augment the kernel params. Signed-off-by:

Re: [PATCH v5 1/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-07-07 Thread Cleber Rosa
On 7/6/21 9:17 AM, Eric Auger wrote: From: Willian Rampazzo As the KNOWN_DISTROS grows, more loosely methods will be created in the avocado_qemu/__init__.py file. Let's refactor the code so that KNOWN_DISTROS and related methods are packaged in a class Signed-off-by: Wainer dos Santos Mosch

[PATCH v7 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-06-29 Thread Cleber Rosa
stage in which other community members can add their own machine configuration documentation/scripts, and accompanying job definitions. As a general rule, those newly added contributed jobs should run as "non-gating", until their reliability is verified (AKA "allow_failure: true&

[PATCH v7 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
OS/machines that the QEMU project has available to act as runners, namely: * Ubuntu 20.04 on aarch64 * Ubuntu 18.04 on s390x But, it should work on all other Linux distributions. Earlier versions were tested on FreeBSD too, so chances of success are high. Signed-off-by: Cleber Rosa Reviewed

[PATCH v7 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
have already had this playbook applied to them. Signed-off-by: Cleber Rosa --- docs/devel/ci.rst | 40 + scripts/ci/setup/.gitignore| 2 + scripts/ci/setup/build-environment.yml | 116 + scripts/ci/setup/inventory.template| 1

[PATCH v7 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
The QEMU project has two machines (aarch64 and s390x) that can be used for jobs that do build and run tests. This introduces those jobs, which are a mapping of custom scripts used for the same purpose. Signed-off-by: Cleber Rosa Reviewed-by: Willian Rampazzo --- .gitlab-ci.d/custom

[PATCH v7 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI)

2021-06-29 Thread Cleber Rosa
ion requirement (there's no static version of those libs in distro supplied packages) to one - Dropped ubuntu-18.04.3-x86_64-notools job definition, because it doesn't fall into the general scope of gating job described by PMM (and it did not run any test) - Added w32 and w64 cross bui

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Fri, Jun 11, 2021 at 7:04 AM Alex Bennée wrote: > > > Cleber Rosa Junior writes: > > > On Tue, Jun 8, 2021 at 2:30 AM Philippe Mathieu-Daudé > > wrote: > > > > Hi Alex, Stefan, > > > > On 6/8/21 5:14 AM, Cleber Rosa wrote: > > > T

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Thu, Jun 10, 2021 at 2:18 AM Thomas Huth wrote: > > On 08/06/2021 05.14, Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390x) that can be used > > for jobs that do build and run tests. This introduces those jobs, > > which are a mapping of cus

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Wed, Jun 9, 2021 at 11:09 AM Stefan Hajnoczi wrote: > > On Tue, Jun 08, 2021 at 04:07:57PM -0300, Wainer dos Santos Moschetta wrote: > > > And I understand that are a lot of them (from everyone, including > > > myself). The dilemma here is: should we activate the machines already > > > availab

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Wed, Jun 9, 2021 at 10:55 AM Stefan Hajnoczi wrote: > > On Tue, Jun 08, 2021 at 09:36:37AM -0400, Cleber Rosa Junior wrote: > > On Tue, Jun 8, 2021 at 2:30 AM Philippe Mathieu-Daudé > > wrote: > > Here are my thoughts. It's just my opinion based on experience ru

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-06-29 Thread Cleber Rosa
On Tue, Jun 8, 2021 at 2:27 PM Wainer dos Santos Moschetta wrote: > > Hi, > > On 6/8/21 12:14 AM, Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390x) that can be used > > for jobs that do build and run tests. This introduces those jobs, > >

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
On Thu, Jun 10, 2021 at 2:24 AM Thomas Huth wrote: > > On 08/06/2021 05.14, Cleber Rosa wrote: > > To have the jobs dispatched to custom runners, gitlab-runner must > > be installed, active as a service and properly configured. The > > variables file and playbook introduc

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
On Wed, Jun 9, 2021 at 1:46 PM Willian Rampazzo wrote: > > On Tue, Jun 8, 2021 at 12:14 AM Cleber Rosa wrote: > > > > To have the jobs dispatched to custom runners, gitlab-runner must > > be installed, active as a service and properly configured. The > > variable

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-06-29 Thread Cleber Rosa
On Tue, Jun 8, 2021 at 3:04 PM Wainer dos Santos Moschetta wrote: > > Hi, > > On 6/8/21 12:14 AM, Cleber Rosa wrote: > > To have the jobs dispatched to custom runners, gitlab-runner must > > be installed, active as a service and properly configured. The > > variable

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
On 6/10/21 4:13 AM, Erik Skultety wrote: ... On a freshly installed Ubuntu 20.04, the script failed for me with dependency messages on the apt side. After I updated the packages on the system, the playbook worked without problems. So, my suggestion is to add the "update = yes" here, or add a

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
On 6/9/21 1:16 PM, Willian Rampazzo wrote: On Tue, Jun 8, 2021 at 12:14 AM Cleber Rosa wrote: To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right packages installed. The playbook introduced here covers the QEMU&#

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
On 6/9/21 12:13 PM, Willian Rampazzo wrote: On Tue, Jun 8, 2021 at 3:48 PM Wainer dos Santos Moschetta wrote: Hi, On 6/8/21 12:14 AM, Cleber Rosa wrote: To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-29 Thread Cleber Rosa
On Tue, Jun 8, 2021 at 2:48 PM Wainer dos Santos Moschetta wrote: > > Hi, > > On 6/8/21 12:14 AM, Cleber Rosa wrote: > > To run basic jobs on custom runners, the environment needs to be > > properly set up. The most common requirement is having the right > > p

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

2021-06-28 Thread Cleber Rosa
On 6/11/21 6:40 AM, Alex Bennée wrote: Cleber Rosa Junior writes: On Wed, Jun 9, 2021 at 11:26 AM Alex Bennée wrote: Cleber Rosa Junior writes: > On Wed, Jun 9, 2021 at 9:36 AM Alex Bennée wrote: > > Cleber Rosa writes: > > > To run basic jobs on c

Re: QEMU hosting

2021-06-28 Thread Cleber Rosa
On 6/20/21 12:14 PM, Thomas Markey wrote: Dear all Would it be possible, may I ask, for the QEMU website to be updated to show that Fosshost is supporting the project? The fosshost logo with a link back to https://fosshost.org will be more than sufficient, or just a l

<    1   2   3   4   5   6   7   8   9   10   >