- Original Message -
> From: "Eric Blake"
> To: "Cleber Rosa" , qemu-devel@nongnu.org
> Cc: "Peter Maydell" , "Eduardo Habkost"
> , "Philippe Mathieu-Daudé"
> , "Wainer dos Santos Moschetta" ,
> "Lau
On Wed, Nov 06, 2019 at 04:26:41PM -0300, Eduardo Habkost wrote:
> On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote:
> > On 06.11.19 10:24, Stefan Hajnoczi wrote:
> > > On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote:
> > >> It tests proper queue size settings for all
that adds the build dir to
the PATH during the test execution.
This is based on the same work for qemu-iotests, and suggested by its
author:
- https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00951.html
CC: Philippe Mathieu-Daudé
Signed-off-by: Cleber Rosa
Reviewed-by: Philippe Mathieu
create the cloudinit ISO image that will be used to configure the
guest, the pycdlib library is also required and has been added as
requirement to the virtual environment created by "check-venv".
The console output is read by a separate thread, by means of the
Avocado datadrainer uti
libraries such as
avocado.utils.vmimage.get() may use the matching binaries, but it may
also apply to any other binary that test code may eventually attempt
to execute.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 6 ++
1 file changed, 6 insertions(+)
diff --git
same test names
across executions from different people or from different directories.
[1] -
https://avocado-framework.readthedocs.io/en/69.0/ReferenceGuide.html#test-id
Signed-off-by: Cleber Rosa
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
llowed). This works for either a dedicated build
directory or also a combined source and build tree.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/a
into a utility method.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index 9a57c020d8..e676d9c4e7 100644
The same way the arch tag is being used as a fallback for the arch
parameter, let's do the same for QEMU's machine and avoid some boiler
plate code.
Signed-off-by: Cleber Rosa
---
docs/devel/testing.rst | 18
tests/acceptance/avocado_qemu/__init__.py | 5 ++
tests
The default vm provided by the test, available as self.vm, serves the
same purpose of the one obtained by self.get_vm(), but saves a line
and matches the style of other tests.
Signed-off-by: Cleber Rosa
---
tests/acceptance/x86_cpu_model_versions.py | 100 ++---
1 file changed
ependency of tests, system wide, it actually goes against the
goal of testing all QEMU things from the source/build tree. This
became aparent with tests running on environments such as Travis CI,
which don't necessarily have qemu-img available elsewhere.
Cleber Rosa (8):
Acceptance test x
On Tue, Oct 29, 2019 at 05:58:13PM -0400, Cleber Rosa wrote:
> On Tue, Oct 29, 2019 at 05:51:28PM -0400, Cleber Rosa wrote:
> > On Tue, Oct 29, 2019 at 09:13:45PM +, Peter Maydell wrote:
> > > On Mon, 28 Oct 2019 at 23:50, Cleber Rosa wrote:
> > > >
> > &g
The boot_linux_console.py:BootLinuxConsole.test_m68k_q800 was very
recently merged, but between its last review and now, the Kernel
package used went missing.
This updates the Kernel package, and protects the test from failing
if it gets updated again.
Cleber Rosa (2):
Acceptance test: cancel
There's an updated version of the Debian package containing the m68k
Kernel.
Now, if the package gets updated again, the test won't fail, but will
be canceled. A more permanent solution is certainly needed.
Signed-off-by: Cleber Rosa
---
tests/acceptance/boot_linux_console.py | 6 +++---
1
f fetching the
package fails.
Signed-off-by: Cleber Rosa
---
tests/acceptance/boot_linux_console.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/acceptance/boot_linux_console.py
b/tests/acceptance/boot_linux_console.py
index df27813c78..c439fd90fc 100644
--- a/tests/
On Tue, Oct 29, 2019 at 05:51:28PM -0400, Cleber Rosa wrote:
> On Tue, Oct 29, 2019 at 09:13:45PM +, Peter Maydell wrote:
> > On Mon, 28 Oct 2019 at 23:50, Cleber Rosa wrote:
> > >
> > > The following changes since commit
> > > aaffb853359829a37daaf883c
On Tue, Oct 29, 2019 at 09:13:45PM +, Peter Maydell wrote:
> On Mon, 28 Oct 2019 at 23:50, Cleber Rosa wrote:
> >
> > The following changes since commit aaffb853359829a37daaf883c773e8320b55c723:
> >
> > Merge remote-tracking branch
> > 'remotes/ma
console: / # reboot: Restarting system
PASS (7.04 s)
JOB TIME : 7.20 s
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-27-phi...@redhat.com>
Reviewed-by: Aleksandar Markovic
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Signed-off-by: Cleber R
Commit 8f8fd9ed introduced the python directory structure, but forgot
to update the path pattern on the MAINTAINERS file.
Signed-off-by: Cleber Rosa
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 42e702f346..a0dd1041b2 100644
erence: https://bugs.launchpad.net/qemu/+bug/1829779
From: Eduardo Habkost
Signed-off-by: Cleber Rosa
Message-Id: <20190911023558.4880-2-cr...@redhat.com>
---
python/qemu/machine.py | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/python/qemu/machine.py b
From: Philippe Mathieu-Daudé
Because of a possible deadlock (QEMU waiting for the socket to
become writable) let's close the console socket as soon as we
stop to use it.
Suggested-by: Cleber Rosa
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-4-phi...@redhat.
From: Philippe Mathieu-Daudé
Some firmwares don't parse the control character and
expect a .
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-5-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Signed-off-by: Cleber Rosa
---
tests/acce
From: Philippe Mathieu-Daudé
Release notes:
http://www.helenos.org/wiki/Download#HelenOS0.6.0
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-11-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
[Cleber: added/removed needed/unneeded imports]
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-13-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Signed-off-by: Cleber Rosa
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
-request
for you to fetch changes up to efdb45bfd72745038909dfd1e970a827cb8d5d7e:
tests/boot_linux_console: Run BusyBox on 5KEc 64-bit cpu (2019-10-28 19:04:04
-0400)
Cleber Rosa (4):
MAINTAINERS: update location of Python
From: Philippe Mathieu-Daudé
User case from:
https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html
Acked-by: David Gibson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-16-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
[Cleber:
lt;20191028073441.6448-25-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
[Cleber: removed conditional to skip test]
Signed-off-by: Cleber Rosa
---
tests/acceptance/boot_linux_console.py | 41 ++
1 file changed, 41 insertions(+)
diff --git a/tests/
From: Philippe Mathieu-Daudé
Refactor the exec_command_and_wait_for_pattern() utility method
so we can reuse it in other files.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-6-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Signed-off-by:
is a condition expected for many
acceptance tests, and it's already used by the migration tests.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests
ptance
$ avocado run -t machine:raspi2 tests/acceptance
Reviewed-by: Alex Bennée
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-21-phi...@redhat.com>
Signed-off-by: Cleber Rosa
---
tests/acceptance/
The same utility method is already present in two different test
files, so let's consolidate it into a single utility function.
Signed-off-by: Cleber Rosa
Message-Id: <20190916164011.7653-1-cr...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
[PMD: failure_message is optional]
Re
-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-14-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
[Cleber: fixed file name and imports]
Signed-off-by: Cleber Rosa
---
MAINTAINERS | 1 +
tests/acceptance/ppc_prep_40p.p
From: Philippe Mathieu-Daudé
Acked-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-18-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Signed-off-by: Cleber Rosa
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 de
-by: Cleber Rosa
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20191028073441.6448-20-phi...@redhat.com>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Signed-off-by: Cleber Rosa
---
tests/acceptance/boot_linux_console.py | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
On Thu, Oct 24, 2019 at 06:12:25PM -0300, Wainer dos Santos Moschetta wrote:
> Hi Cleber,
>
> On 9/24/19 4:45 PM, Cleber Rosa wrote:
> > Currently a test can describe the target architecture binary that it
> > should primarily be run with, be setting a single tag value.
>
the serial console. Few commands are executed
> > before halting the machine (via reboot).
> >
> >
>
> A very nice test.
>
> Reviewed-by: Aleksandar Markovic
>
Thanks for the review Aleksandar.
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
On Mon, Oct 28, 2019 at 02:41:51PM -0400, Cleber Rosa wrote:
> On Mon, Oct 28, 2019 at 08:34:30AM +0100, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daudé
> >
> > User case from:
> > https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html
>
On Mon, Oct 28, 2019 at 08:34:40AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> This test boots a Linux kernel on a smdkc210 board and verify
> the serial output is working.
>
> The cpio image used comes from the linux-build-test project:
>
oot_linux_console.py | 42 ++
> 1 file changed, 42 insertions(+)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index 44a046bd64..cbb8cddf47 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -432,6 +432,48 @@ class BootLinuxConsole(MachineTest):
> exec_command_and_wait_for_pattern(self, 'reboot',
> 'reboot: Restarting system')
>
> +@skipUnless(os.getenv('IGNORE_AVOCADO_CONSOLE_BUG'), 'Console buggy')
Given that the problems seem related to console input, I think it's
safe to remove this conditional. I've tested this extensively
(hundreds of executions with as many as 15 running simultaneously)
and had no issues.
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
ng the
> kernel command line.
>
> Add few lines to expand our previous test and cover the AUX
> UART.
>
> Reviewed-by: Alex Bennée
> Reviewed-by: Cleber Rosa
> Tested-by: Cleber Rosa
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/acceptance/boot_linux_c
b.com/sakaki-/bcmrpi3-kernel#description
>
> The cpio image used comes from the linux-build-test project:
> https://github.com/groeck/linux-build-test
>
> Reviewed-by: Cleber Rosa
> Tested-by: Cleber Rosa
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> v2: Use
GTERM to all processes
> console: Sent SIGKILL to all processes
> console: Requesting system reboot
> console: kvm: exiting hardware virtualization
> console: reboot: Restarting system
> PASS (11.08 s)
>
> Reviewed-by: Cleber Rosa
> Tested-by: Cleber Rosa
> Sign
GTERM to all processes
> console: Sent SIGKILL to all processes
> console: Requesting system reboot
> console: kvm: exiting hardware virtualization
> console: reboot: Restarting system
> PASS (11.08 s)
>
> Reviewed-by: Cleber Rosa
> Tested-by: Cleber Rosa
> Sign
clude this test by the use of the "arch:arm" tags.
>
> Alternatively, this test can be run using:
>
> $ avocado run -t arch:arm tests/acceptance
> $ avocado run -t machine:raspi2 tests/acceptance
>
> Reviewed-by: Alex Bennée
> Reviewed-by: Cleber Rosa
> Teste
mework.readthedocs.io/en/67.0/api/utils/avocado.utils.html#avocado.utils.archive.gzip_uncompress
>
> Suggested-by: Cleber Rosa
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
On Mon, Oct 28, 2019 at 08:34:32AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> Acked-by: Alex Bennée
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
On Mon, Oct 28, 2019 at 08:34:33AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> Add a test which boots a HP-UX firmware upgrade CD-ROM.
> It exercise the PCI LSI53C895A SCSI controller.
>
> The ISO image comes from:
>
On Mon, Oct 28, 2019 at 08:34:31AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> User case from:
> https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html
>
> Sandalfoot info:
> http://www.juneau-lug.org/sandalfoot.php
>
> Acked-by: David Gibson
>
On Mon, Oct 28, 2019 at 01:48:01PM -0400, Cleber Rosa wrote:
> On Mon, Oct 28, 2019 at 08:34:29AM +0100, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daudé
> >
> > User case from:
> > https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html
>
> ---
> v3:
> - use avocado_qemu.wait_for_console_pattern (Cleber)
> - use MD5 hash
> ---
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
ne('40p')
> +self.vm.set_console()
> +self.vm.add_args('-bios', bios_path,
> + '-fda', drive_path)
> + self.vm.launch()
> +os_banner = 'NetBSD 4.0 (GENERIC) #0: Sun Dec 16 00:49:40 PST 2007'
> +wait_for_console_pattern(self, os_banner)
> +wait_for_console_pattern(self, 'Model: IBM PPS Model 6015')
> --
> 2.21.0
>
With the import and name changes above:
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
On Mon, Oct 28, 2019 at 08:34:29AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> User case from:
> https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html
>
> Acked-by: David Gibson
> Acked-by: Artyom Tarasenko
> Tested-by: Cleber Ros
On Mon, Oct 28, 2019 at 08:34:26AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> Gaisler provides convenient images:
> https://www.gaisler.com/index.php/downloads/linux
>
> HOWTO build:
> https://www.gaisler.com/index.php/products/operating-systems/linux
>
>
On Mon, Oct 28, 2019 at 08:34:27AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
the kernel ...')
But this needs an import:
from avocado_qemu import wait_for_console_pattern
> --
> 2.21.0
>
The core of the test is good, and I've tested it with the changes
listed above, and it runs reliably.
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
ional, added doc
> v3: reword because after rebasing only 1 file has to be modified
> ---
> tests/acceptance/avocado_qemu/__init__.py | 19 +++
> tests/acceptance/boot_linux_console.py| 18 +++---
> 2 files changed, 26 insertions(+), 11 deletions(-)
Reviewe
as we
> > stop to use it.
> >
> > Suggested-by: Cleber Rosa
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > tests/acceptance/avocado_qemu/__init__.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >
> Fixe -> Fix
>
> You missed my r-b ag
ess_message):
> -command += '\n'
> +command += '\r'
> self.vm.console_socket.sendall(command.encode())
> wait_for_console_pattern(self, success_message)
>
> --
> 2.21.0
>
Given the discussion on
, this LGTM.
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
Queuing on my python-next branch (and sending shortly in a PR).
Thanks,
- Cleber.
On Mon, Oct 28, 2019 at 08:34:18AM +0100, Philippe Mathieu-Daudé wrote:
> Because of a possible deadlock (QEMU waiting for the socket to
> become writable) let's close the console socket as soon as we
> stop to use it.
>
> Suggested-by: Cleber Rosa
> Signed-off-by: Phil
On Mon, Oct 28, 2019 at 08:58:01AM +0100, Aleksandar Markovic wrote:
> On Monday, October 28, 2019, Philippe Mathieu-Daudé
> wrote:
>
> > From: Cleber Rosa
> >
> > The same utility method is already present in two different test
> > files, so let's consolidate
On Mon, Oct 28, 2019 at 08:34:17AM +0100, Philippe Mathieu-Daudé wrote:
> From: Cleber Rosa
>
> The same utility method is already present in two different test
> files, so let's consolidate it into a single utility function.
>
> Signed-off-by: Cleber Rosa
> Message-Id: &
On Mon, Oct 28, 2019 at 08:34:16AM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> Currently the QEMU Python module limits the QEMUMachine class to
> use the first serial console.
>
> Some machines/guest might use another console than the first one as
> the 'boot
On Fri, Oct 11, 2019 at 02:27:25PM +0300, Nir Soffer wrote:
> On Fri, Oct 11, 2019, 12:36 Kevin Wolf wrote:
>
> > Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben:
> > > Due to not being able to find a reason to have shebangs on files that
> > > are not executable
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/044 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044
index aa2a00ceed..bae99e25cf 100755
--- a/tests/qemu-iotests/044
+++ b/tests/qemu-iotests/044
Reviewed-by: Eric Blake
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/044 | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044
index 8b2afa2a11..aa2a00ceed 100755
--- a/tests/qemu-iotests/044
+++ b/tests/qemu-iotests/044
@@ -102,17 +102,14
- Original Message -
> From: "Eric Blake"
> To: "Cleber Rosa" , qemu-devel@nongnu.org
> Cc: qemu-bl...@nongnu.org, "Max Reitz" , "Kevin Wolf"
> , qemu-triv...@nongnu.org,
> "Michael Tokarev" , "Laurent Vivier"
Due to not being able to find a reason to have shebangs on files that
are not executable.
While at it, add a mode hint to emacs, which would be clueless or
plain wrong about these containing shell code.
Suggested-by: Eric Blake
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/common.config
Should not be necessary on files that are not executed standalone.
Reviewed-by: Eric Blake
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/common.config | 3 ---
tests/qemu-iotests/common.filter | 3 ---
tests/qemu-iotests/common.rc | 3 ---
3 files changed, 9 deletions(-)
diff --git
The most trivial set of cleanups to iotests common libraries and the
044 test.
Changes from v1:
* Added emacs mode hints on tests/qemu-iotests/common.* files (Eric
Blake)
Cleber Rosa (4):
qemu-iotests: remove bash shebang from library files
qemu-iotests: remove forceful execution success
On Wed, Oct 09, 2019 at 02:38:02PM +0100, Peter Maydell wrote:
> On Tue, 8 Oct 2019 at 22:49, Cleber Rosa wrote:
> >
> > I find it hard to judge precisely how much of a third-party some of
> > these are. I remember Philippe mentioning that one of them, I gues
On Wed, Oct 09, 2019 at 12:26:27PM -0400, Cleber Rosa wrote:
> On Fri, Sep 27, 2019 at 11:37:52AM -0500, Eric Blake wrote:
> > On 9/27/19 9:17 AM, Cleber Rosa wrote:
> > > Due to not being able to find a reason to have shebangs on files that
> > > are not executab
('cat /proc/cpuinfo',
> + 'BogoMIPS')
> + self.exec_command_and_wait_for_pattern('uname -a',
> + 'Debian')
> +self.exec_command_and_wait_for_pattern('reboot',
> + 'reboot: Restarting system')
> +
> def test_s390x_s390_ccw_virtio(self):
> """
> :avocado: tags=arch:s390x
> --
> 2.20.1
>
Reviewed-by: Cleber Rosa
And even though you mentioned some trouble with the console, I've run
this 100 times and had no issues that disturbed the test, so:
Tested-by: Cleber Rosa
On Mon, Oct 07, 2019 at 03:09:25PM +0200, Max Reitz wrote:
> On 27.09.19 16:17, Cleber Rosa wrote:
> > The most trivial set of cleanups to iotests common libraries and the
> > 044 test.
> >
> > Cleber Rosa (4):
> > qemu-iotests: remove bash shebang from library
On Fri, Sep 27, 2019 at 11:37:52AM -0500, Eric Blake wrote:
> On 9/27/19 9:17 AM, Cleber Rosa wrote:
> > Due to not being able to find a reason to have shebangs on files that
> > are not executable.
> >
> > Signed-off-by: Cleber Rosa
> > ---
> >
self.do_test_arm_raspi2(0)
>
> +def test_arm_raspi2_uart1(self):
> +"""
> +:avocado: tags=arch:arm
> +:avocado: tags=machine:raspi2
> +:avocado: tags=device:bcm2835_aux
> + """
> + self.do_test_arm_raspi2(1)
> +
> def test_s390x_s390_ccw_virtio(self):
> """
> :avocado: tags=arch:s390x
> --
> 2.20.1
>
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
78')
Nitpick: you could avoid the strings concatenation operation with:
self.exec_command_and_wait_for_pattern(('cat /sys/devices/virtual/'
'thermal/thermal_zone0/temp'),
'25178')
> +self.exec_command_and_wait_for_pattern('reboot',
> + 'reboot: Restarting system')
> +
> def test_s390x_s390_ccw_virtio(self):
> """
> :avocado: tags=arch:s390x
> --
> 2.20.1
>
Either way,
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
+
> +def test_arm_raspi2_uart0(self):
> +"""
> +:avocado: tags=arch:arm
> + :avocado: tags=machine:raspi2
> +:avocado: tags=device:pl011
> +"""
> +self.do_test_arm_raspi2(0)
> +
> def test_s390x_s390_ccw_virtio(self):
> """
> :avocado: tags=arch:s390x
> --
> 2.20.1
>
Reviewed-by: Cleber Rosa
On Thu, Sep 26, 2019 at 07:34:23PM +0200, Philippe Mathieu-Daudé wrote:
> We are going to use the same pattern. Instead of keeping
> copy/pasting this code, extract as a local function.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/acceptance/boot_linux_console.py | 10 ++
> 1
On Wed, Oct 09, 2019 at 11:43:15AM -0400, Cleber Rosa wrote:
> On Thu, Sep 26, 2019 at 07:34:24PM +0200, Philippe Mathieu-Daudé wrote:
> > Similar to the x86_64/pc test, it boots a Linux kernel on a raspi2
> > board and verify the serial is working.
> >
> > The kerne
On Thu, Sep 26, 2019 at 07:34:22PM +0200, Philippe Mathieu-Daudé wrote:
> Currently we are limited to use the first serial console available.
> Some machines/guest might use another console than the first one as
> the 'boot console'.
>
> To be able to use the N console as default, we simply need
+407,7 @@ static void bcm2835_property_realize(DeviceState *dev,
> Error **errp)
> }
>
> s->dma_mr = MEMORY_REGION(obj);
> -address_space_init(>dma_as, s->dma_mr, NULL);
> +address_space_init(>dma_as, s->dma_mr, TYPE_BCM2835_PROPERTY
> "-memory");
>
> /* TODO: connect to MAC address of USB NIC device, once we emulate it */
> qemu_macaddr_default_if_unset(>macaddr);
> --
> 2.20.1
>
The names you're giving are much more detailed than most other
examples I found for address_space_init(), and I like that approach a
lot.
Reviewed-by: Cleber Rosa
ay:
>
Unless the value given to the formatting string is zero, then the "0x"
prefix is not applied to the resulting string.
> Reviewed-by: Alex Bennée
Reviewed-by: Cleber Rosa
,7 @@ static void raspi3_machine_init(MachineClass *mc)
> mc->max_cpus = BCM283X_NCPUS;
> mc->min_cpus = BCM283X_NCPUS;
> mc->default_cpus = BCM283X_NCPUS;
> -mc->default_ram_size = 1024 * 1024 * 1024;
> +mc->default_ram_size = 1 * GiB;
> }
> DEFINE_MACHINE("raspi3", raspi3_machine_init)
> #endif
> --
> 2.20.1
>
Reviewed-by: Cleber Rosa
On Sat, Oct 05, 2019 at 05:47:48PM +0200, Philippe Mathieu-Daudé wrote:
> This test boots a Linux kernel on a smdkc210 board and verify
> the serial output is working.
>
> The cpio image used comes from the linux-build-test project:
> https://github.com/groeck/linux-build-test
>
> Since this
gionOps usdhc_mmio_ops = {
> .read = usdhc_read,
> .write = usdhc_write,
> --
> 2.20.1
>
>
Reviewed-by: Cleber Rosa
On Mon, Oct 07, 2019 at 05:28:49PM +0100, Peter Maydell wrote:
> On Sat, 5 Oct 2019 at 16:47, Philippe Mathieu-Daudé wrote:
> >
> > This test boots a Linux kernel on a smdkc210 board and verify
> > the serial output is working.
> >
> > The cpio image used comes from the linux-build-test project:
On Sat, Oct 05, 2019 at 05:47:44PM +0200, Philippe Mathieu-Daudé wrote:
> This test boots a Linux kernel on a smdkc210 board and verify
> the serial output is working.
>
> The cpio image used comes from the linux-build-test project:
> https://github.com/groeck/linux-build-test
>
> If ARM is a
Should not be necessary on files that are not executed standalone.
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/common.config | 3 ---
tests/qemu-iotests/common.filter | 3 ---
tests/qemu-iotests/common.rc | 3 ---
3 files changed, 9 deletions(-)
diff --git a/tests/qemu-iotests
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/044 | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044
index 05ea1f49c5..eb42df0fe1 100755
--- a/tests/qemu-iotests/044
+++ b/tests/qemu-iotests/044
@@ -105,17 +105,14 @@ class
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/044 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044
index eb42df0fe1..0ca4bcfc6d 100755
--- a/tests/qemu-iotests/044
+++ b/tests/qemu-iotests/044
@@ -34,7 +34,6 @@ if sys.version_info.major == 2
Due to not being able to find a reason to have shebangs on files that
are not executable.
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/common.config | 2 --
tests/qemu-iotests/common.filter | 2 --
tests/qemu-iotests/common.nbd | 1 -
tests/qemu-iotests/common.pattern | 2 --
tests
The most trivial set of cleanups to iotests common libraries and the
044 test.
Cleber Rosa (4):
qemu-iotests: remove bash shebang from library files
qemu-iotests: remove forceful execution success from library files
qemu-iotests: 044: pass is actually a noop, so remove it
qemu-iotests
is tagged
with "machine", its value will be set on the QEMUMachine instances
created/managed by the test. Hopefully this will eliminate boiler
plate code, and make writing tests more straightforward.
Cleber Rosa (3):
Acceptance test x86_cpu_model_versions: use default vm
Acceptance test
into a utility method.
Signed-off-by: Cleber Rosa
---
tests/acceptance/avocado_qemu/__init__.py | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index bd41e0443c..02775bafcf 100644
The same way the arch tag is being used as a fallback for the arch
parameter, let's do the same for QEMU's machine and avoid some boiler
plate code.
This requires a bump in the Avocado version, as starting with 72.0,
the characters supported in tags are less strict.
Signed-off-by: Cleber Rosa
The default vm provided by the test, available as self.vm, serves the
same purpose of the one obtained by self.get_vm(), but saves a line
and matches the style of other tests.
Signed-off-by: Cleber Rosa
---
tests/acceptance/x86_cpu_model_versions.py | 100 ++---
1 file changed
On Thu, Sep 19, 2019 at 06:10:03PM +0100, Alex Bennée wrote:
> There is a race here in the clean-up code so lets just accept that
> sometimes the active task we just looked up might have finished before
> we got to inspect it.
>
> Signed-off-by: Alex Bennée
> ---
> tests/docker/docker.py | 32
On Thu, Sep 19, 2019 at 06:10:02PM +0100, Alex Bennée wrote:
> From: John Snow
>
> When it was based on docker8 which uses python-minimal, it needed this.
Assuming this docker8 was a typo? I mean, s/docker8/debian8/ ?
- Cleber
> It no longer does.
>
> Goodbye, python2.7.
>
> Signed-off-by:
rged fix from Message-Id: <20190917185537.25417-1-js...@redhat.com>]
> Signed-off-by: Alex Bennée
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Cleber Rosa
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> di
On Thu, Sep 19, 2019 at 06:10:04PM +0100, Alex Bennée wrote:
> From: John Snow
>
> Oops; there's no argv here.
>
> Signed-off-by: John Snow
> Message-Id: <20190913193821.17756-1-js...@redhat.com>
> Signed-off-by: Alex Bennée
Reviewed-by: Cleber Rosa
Tested-by: C
801 - 900 of 1612 matches
Mail list logo
