[Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-09 Thread Cleber Rosa
device type. Also, even when there's a default machine type, for some purposes, testing included, it's better if outside code is explicit about the machine type, instead of relying on whatever is set internally. Signed-off-by: Cleber Rosa --- scripts/qemu.py | 22 +- 1 file

Re: [Qemu-devel] [RFC PATCH 0/3] acceptance tests: Test firmware checking debug console output

2018-10-02 Thread Cleber Rosa
On 9/28/18 6:51 AM, Laszlo Ersek wrote: > Hi Phil, > > (+Daniel, +Kashyap) > > On 09/28/18 02:30, Philippe Mathieu-Daudé wrote: >> Hi, >> >> This RFC series add simple acceptance tests which boot SeaBIOS and >> EDK2 on Q35 and virt/aarch64. >> >> It is more of a proof of concept (to motivate

[Qemu-devel] [RFC PATCH 1/3] acceptance tests: Add SeaBIOS boot and debug console checking test

2018-10-02 Thread Cleber Rosa
On 9/27/18 8:30 PM, Philippe Mathieu-Daudé wrote: > This test boots SeaBIOS and check the debug console (I/O port on the ISA bus) > reports enough information on the initialized devices. > > Example: > > $ avocado --show=debugcon run tests/acceptance/boot_firmware.py > > Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 2/3] acceptance tests: Add EDK2 OVMF boot and debug console checking test

2018-10-02 Thread Cleber Rosa
On 9/27/18 8:30 PM, Philippe Mathieu-Daudé wrote: > This test boots OVMF and check the debug console (I/O port on the ISA bus) > report enough information on the initialized devices. > > Example: > > $ avocado --show=QMP,serial run tests/acceptance/boot_firmware.py > > Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 3/3] acceptance tests: Add EDK2 AAVMF boot and console checking test

2018-10-02 Thread Cleber Rosa
On 9/27/18 8:30 PM, Philippe Mathieu-Daudé wrote: > This test boots EDK2 AAVMF and check the debug console (PL011) reports enough > information on the initialized devices. > > Example: > > $ avocado --show=console run tests/acceptance/boot_firmware.py > --cit-parameter-file aarch64.cit >

Re: [Qemu-devel] [PATCH v2 6/7] Acceptance Tests: add variants definition for architectures

2018-10-10 Thread Cleber Rosa
On 10/10/18 6:59 AM, Philippe Mathieu-Daudé wrote: > On 10/10/2018 01:26, Cleber Rosa wrote: >> One of the Avocado features relevant to virtualization testing is the >> ability to reuse tests in different scenarios, known as variants. >> This adds a JSON based variants f

Re: [Qemu-devel] [PATCH 2/7] Acceptance Tests: introduce arch parameter and attribute

2018-10-10 Thread Cleber Rosa
On 10/4/18 7:56 PM, Murilo Opsfelder Araujo wrote: > Hi, Cleber. > > On Thu, Oct 04, 2018 at 11:14:24AM -0400, Cleber Rosa wrote: >> On a number of different scenarios, such as when choosing a QEMU >> binary to be used on tests (or a image to use to boot a test VM), it'

Re: [Qemu-devel] [PATCH v2 6/7] Acceptance Tests: add variants definition for architectures

2018-10-10 Thread Cleber Rosa
On 10/10/18 6:51 AM, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > On 10/10/2018 01:26, Cleber Rosa wrote: >> One of the Avocado features relevant to virtualization testing is the >> ability to reuse tests in different scenarios, known as variants. >> This adds

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 9:46 AM, Eduardo Habkost wrote: > On Wed, Oct 10, 2018 at 08:35:38AM -0400, Cleber Rosa wrote: >> >> >> On 10/10/18 7:00 AM, Philippe Mathieu-Daudé wrote: >>> On 10/10/2018 01:26, Cleber Rosa wrote: >>>> Some targets require a mac

Re: [Qemu-devel] [PATCH v2 7/7] Acceptance Tests: change the handling of tests for specific archs

2018-10-10 Thread Cleber Rosa
On 10/10/18 6:50 AM, Philippe Mathieu-Daudé wrote: > On 10/10/2018 01:26, Cleber Rosa wrote: >> With the introduction of a variants file that can run the same >> tests on various architectures, it makes sense to make most tests >> to be reusable on those environments.

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 7:00 AM, Philippe Mathieu-Daudé wrote: > On 10/10/2018 01:26, Cleber Rosa wrote: >> Some targets require a machine type to be set, as there's no default >> (aarch64 is one example). To give a consistent interface to users of >> this API, this cha

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 9:59 AM, Cleber Rosa wrote: > > > On 10/10/18 9:46 AM, Eduardo Habkost wrote: >> On Wed, Oct 10, 2018 at 08:35:38AM -0400, Cleber Rosa wrote: >>> >>> >>> On 10/10/18 7:00 AM, Philippe Mathieu-Daudé wrote: >>>> On 10/10/201

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 11:26 AM, Philippe Mathieu-Daudé wrote: > On 10/10/2018 16:28, Eduardo Habkost wrote: >> On Wed, Oct 10, 2018 at 10:15:15AM -0400, Cleber Rosa wrote: >>> >>> >>> On 10/10/18 9:59 AM, Cleber Rosa wrote: >>>> >>>> >>&

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 10:28 AM, Eduardo Habkost wrote: > On Wed, Oct 10, 2018 at 10:15:15AM -0400, Cleber Rosa wrote: >> >> >> On 10/10/18 9:59 AM, Cleber Rosa wrote: >>> >>> >>> On 10/10/18 9:46 AM, Eduardo Habkost wrote: >>>>

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 12:08 PM, Philippe Mathieu-Daudé wrote: > On 10/10/2018 17:58, Cleber Rosa wrote: >> >> >> On 10/10/18 11:26 AM, Philippe Mathieu-Daudé wrote: >>> On 10/10/2018 16:28, Eduardo Habkost wrote: >>>> On Wed, Oct 10, 2018 at 10:15:15AM -0400, Cle

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 11:31 AM, Daniel P. Berrangé wrote: > On Wed, Oct 10, 2018 at 11:28:40AM -0300, Eduardo Habkost wrote: >> On Wed, Oct 10, 2018 at 10:15:15AM -0400, Cleber Rosa wrote: >>> >>> >>> On 10/10/18 9:59 AM, Cleber Rosa wrote: >>>> >

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 12:23 PM, Peter Maydell wrote: > On 10 October 2018 at 16:47, Cleber Rosa wrote: >> To make sure we're on the same page, we're still going to have default >> machine types, based on the arch, for those targets that don't provide >> one (aarch64 is one exampl

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 2:07 PM, Peter Maydell wrote: > On 10 October 2018 at 18:52, Cleber Rosa wrote: >> >> >> On 10/10/18 12:23 PM, Peter Maydell wrote: >>> On 10 October 2018 at 16:47, Cleber Rosa wrote: >>>> To make sure we're on the same page, we're stil

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 11:47 AM, Cleber Rosa wrote: > > > On 10/10/18 10:28 AM, Eduardo Habkost wrote: >> On Wed, Oct 10, 2018 at 10:15:15AM -0400, Cleber Rosa wrote: >>> >>> >>> On 10/10/18 9:59 AM, Cleber Rosa wrote: >>>> >>>> >>&

Re: [Qemu-devel] [PATCH v2 4/7] scripts/qemu.py: set predefined machine type based on arch

2018-10-10 Thread Cleber Rosa
On 10/10/18 11:42 PM, Eduardo Habkost wrote: > On Wed, Oct 10, 2018 at 08:17:26PM -0400, Cleber Rosa wrote: >> >> >> On 10/10/18 11:47 AM, Cleber Rosa wrote: >>> >>> >>> On 10/10/18 10:28 AM, Eduardo Habkost wrote: >>>>

Re: [Qemu-devel] [RFC PATCH v2 0/3] acceptance tests: Test firmware checking debug console output

2018-10-04 Thread Cleber Rosa
On 10/4/18 8:58 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> Hi, >> >> This RFC series add simple acceptance tests which boot SeaBIOS and EDK2 on >> the pc and virt/aarch64 default machines >> >> Still PoC but can be useful for the Avocado team to test the >> multi-arch

Re: [Qemu-devel] [RFC PATCH v2 0/3] acceptance tests: Test firmware checking debug console output

2018-10-04 Thread Cleber Rosa
On 10/4/18 9:09 AM, Peter Maydell wrote: > On 4 October 2018 at 14:04, Alex Bennée wrote: >> >> Alex Bennée writes: >> >>> Philippe Mathieu-Daudé writes: >>> Hi, This RFC series add simple acceptance tests which boot SeaBIOS and EDK2 on the pc and virt/aarch64 default

[Qemu-devel] [PATCH v3 2/3] Acceptance tests: add make rule for running them

2018-10-09 Thread Cleber Rosa
lso, while the Avocado test runner will take care of creating a location to save test results to, it was understood that it's better if the results are kept within the build tree. Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 35 ++- tests/Makefi

[Qemu-devel] [PATCH v3 3/3] Travis support for the acceptance tests

2018-10-09 Thread Cleber Rosa
-venv package. Signed-off-by: Cleber Rosa --- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 95be6ec59f..f55f799c52 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,6 +36,8 @@ addons: - liburcu-dev - libusb-1.0-0-dev - libvte

[Qemu-devel] [PATCH v3 1/3] Bootstrap Python venv for tests

2018-10-09 Thread Cleber Rosa
-requirements.txt is supposed to contain the Python requirements that should be added to the venv created by check-venv. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 20 tests/venv-requirements.txt | 3 +++ 2 files changed, 23 insertions(+) create mode 100644 tests

[Qemu-devel] [PATCH v3 0/3] Bootstrap Python venv and acceptance/functional tests

2018-10-09 Thread Cleber Rosa
Travis. Ideas discussed, but not implemented: * Install external packages such as python3-pip on Debian based systems, deemed too invasive on developer's systems. * Allow the use of Python 2, and consequently the "virtualenv" module. Cleber Rosa (3): Bootstrap

Re: [Qemu-devel] [PATCH 2/2] Acceptance tests: add make rule for running them

2018-09-20 Thread Cleber Rosa
On 9/20/18 4:14 PM, Eduardo Habkost wrote: > On Thu, Sep 20, 2018 at 04:00:27PM -0400, Cleber Rosa wrote: >> >> >> On 9/20/18 2:58 PM, Eduardo Habkost wrote: >>> On Thu, Sep 20, 2018 at 11:19:56AM -0400, Cleber Rosa wrote: >>>> The acceptance

Re: [Qemu-devel] [PATCH 2/2] Acceptance tests: add make rule for running them

2018-09-20 Thread Cleber Rosa
On 9/20/18 2:58 PM, Eduardo Habkost wrote: > On Thu, Sep 20, 2018 at 11:19:56AM -0400, Cleber Rosa wrote: >> The acceptance (aka functional, aka Avocado-based) tests are >> Python files located in "tests/acceptance" that need to be run >> with the Avocado li

Re: [Qemu-devel] [PATCH 2/2] Acceptance tests: add make rule for running them

2018-09-21 Thread Cleber Rosa
On 9/20/18 5:18 PM, Philippe Mathieu-Daudé wrote: > On 9/20/18 10:14 PM, Eduardo Habkost wrote: >> On Thu, Sep 20, 2018 at 04:00:27PM -0400, Cleber Rosa wrote: >>> On 9/20/18 2:58 PM, Eduardo Habkost wrote: >>>> On Thu, Sep 20, 2018 at 11:19:56AM -0400, Cleber Ro

Re: [Qemu-devel] [PATCH 2/2] Acceptance tests: add make rule for running them

2018-09-21 Thread Cleber Rosa
On 9/20/18 7:07 PM, Philippe Mathieu-Daudé wrote: > On 9/21/18 12:06 AM, Eduardo Habkost wrote: >> On Thu, Sep 20, 2018 at 11:18:46PM +0200, Philippe Mathieu-Daudé wrote: >>> On 9/20/18 10:14 PM, Eduardo Habkost wrote: >>>> On Thu, Sep 20, 2018 at 04:00:27PM -0400,

Re: [Qemu-devel] [PATCH 1/2] Bootstrap Python venv for tests

2018-09-21 Thread Cleber Rosa
On 9/20/18 7:29 PM, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > On 9/20/18 5:19 PM, Cleber Rosa wrote: >> A number of QEMU tests are written in Python, and may benefit >> from an untainted Python venv. >> >> By using make rules, tests that depend on specific

Re: [Qemu-devel] [PATCH 2/2] Acceptance tests: add make rule for running them

2018-09-21 Thread Cleber Rosa
gt;> >>>>> On Thu, Sep 20, 2018 at 11:19:56AM -0400, Cleber Rosa wrote: > [...] >>>>>> +$(TESTS_RESULTS_DIR): >>>>>> +$(call quiet-command, mkdir -p $@, \ >>>>>> +MKDIR, $@) >>>>>> + >

Re: [Qemu-devel] [PATCH] Add "boot_linux" acceptance test

2018-09-26 Thread Cleber Rosa
On 9/26/18 2:27 PM, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > On Thu, Sep 20, 2018 at 6:18 PM Cleber Rosa wrote: >> >> This acceptance test, validates that a full blown Linux guest can >> successfully boot in QEMU. In this specific case, the guest >

[Qemu-devel] [PATCH] Bootstrap Python venv and acceptance/functional tests

2018-09-20 Thread Cleber Rosa
Python 3, as it's based on the venv module. This was based on some discussions and perception about standardizing on Python 3, but can easily be made to accommodate Python 2 as well. Commit summary == Cleber Rosa (2): Bootstrap Python venv for tests Acceptance tests: add make rule

[Qemu-devel] [PATCH 2/2] Acceptance tests: add make rule for running them

2018-09-20 Thread Cleber Rosa
lso, while the Avocado test runner will take care of creating a location to save test results to, it was understood that it's better if the results are kept within the build tree. Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 28 +++- tests/Makefile.include

[Qemu-devel] [PATCH 1/2] Bootstrap Python venv for tests

2018-09-20 Thread Cleber Rosa
-requirements.txt is supposed to contain the Python requirements that should be added to the venv created by check-venv. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 19 +++ tests/venv-requirements.txt | 3 +++ 2 files changed, 22 insertions(+) create mode 100644 tests

[Qemu-devel] [PATCH] Add "boot_linux" acceptance test

2018-09-20 Thread Cleber Rosa
t;tests/venv-requirements.txt" file introduced in another patch series. Reference: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg02503.html Reference: https://github.com/avocado-framework/avocado/commit/02c47b1eade667d18fb0adef3293d86a6b5fd2e9 Signed-off-by: Cleber Rosa

[Qemu-devel] [PATCH 10/18] Boot Linux Console Test: refactor the console watcher into utility method

2019-01-17 Thread Cleber Rosa
This introduces a utility method that monitors the console device and looks for either a message that signals the test success or failure. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 30 ++ 1 file changed, 21 insertions(+), 9 deletions

[Qemu-devel] [PATCH 09/18] Boot Linux Console Test: update the x86_64 kernel

2019-01-17 Thread Cleber Rosa
To the stock Fedora 29 kernel, from the Fedora 28. New tests will be added using the 29 kernel, so for consistency, let's also update it here. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests

[Qemu-devel] [PATCH 12/18] Boot Linux Console Test: add a test for mips + malta

2019-01-17 Thread Cleber Rosa
this test by the use of the "arch:mips" tags. Alternatively, this test can be run using: $ avocado run -t arch:mips tests/acceptance $ avocado run -t machine:malta tests/acceptance $ avocado run -t endian:big tests/acceptance Signed-off-by: Philippe Mathieu-Daudé Signed

[Qemu-devel] [PATCH 02/18] Acceptance tests: show avocado test execution by default

2019-01-17 Thread Cleber Rosa
d to adapt the list of tests to match the user's build environment (among other choices). Because of that, let's present the default Avocado UI by default. Users can always choose a different output by setting the AVOCADO_SHOW variable. Signed-off-by: Cleber Rosa --- .travis.yml| 2

[Qemu-devel] [PATCH 06/18] Acceptance tests: use "arch:" tag to filter target specific tests

2019-01-17 Thread Cleber Rosa
version of the "boot_linux_console.py" test, which downloads and attempts to run a x86_64 kernel, is now tagged as: :avocado: tags=arch:x86_64 This means that it can be filtered (out) when no x86_64 target is available. At the same time, tests that don't have a "arch:" tag, wi

[Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pick_default_qemu_bin()

2019-01-17 Thread Cleber Rosa
Making it clear what is returned by this utility function. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance

[Qemu-devel] [PATCH 08/18] Boot Linux Console Test: rename the x86_64 after the arch and machine

2019-01-17 Thread Cleber Rosa
Given that the test is specific to x86_64 and pc, and new tests are going to be added to the same class, let's rename it accordingly. Also, let's make the class documentation not architecture specific. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 11 +++ 1

[Qemu-devel] [PATCH 04/18] Acceptance tests: fix doc reference to avocado_qemu directory

2019-01-17 Thread Cleber Rosa
The "this directory" reference is misleading and confusing, it's a leftover from when this text was proposed in a README file inside the "tests/acceptance/avocado_qemu" directory. When that text was moved to the top level docs directory, the reference was not updated. Signed

[Qemu-devel] [PATCH 05/18] Acceptance tests: introduce arch parameter and attribute

2019-01-17 Thread Cleber Rosa
parameter and a test instance attribute, that will contain such a value. Now, when the "arch" test parameter is given, it will influence the selection of the default QEMU binary, if one is not given explicitly by means of the "qemu_img" parameter. Signed-off-by: Cleber R

[Qemu-devel] [PATCH 16/18] Boot Linux Console Test: add a test for arm + virt

2019-01-17 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on an arm target using the virt machine. Signed-off-by: Cleber Rosa --- .travis.yml| 2 +- tests/acceptance/boot_linux_console.py | 19 +++ 2 files changed, 20 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 14/18] Boot Linux Console Test: add a test for ppc64 + pseries

2019-01-17 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on a ppc64 target using the pseries machine. Signed-off-by: Cleber Rosa --- .travis.yml| 2 +- scripts/qemu.py| 1 - tests/acceptance/boot_linux_console.py | 19 +++ 3 files

[Qemu-devel] [PATCH 07/18] Acceptance tests: look for target architecture in test tags first

2019-01-17 Thread Cleber Rosa
rch parameter given (manually) does not match the test "arch" tag, but it may be a useful default behavior to be added in the future. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests

[Qemu-devel] [PATCH 11/18] scripts/qemu.py: support adding a console with the default serial device

2019-01-17 Thread Cleber Rosa
device type is given, and there's no definition on CONSOLE_DEV_TYPES, the "-serial" is going to be added to the QEMU command line, instead of raising exceptions. Signed-off-by: Cleber Rosa --- scripts/qemu.py | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH 18/18] Boot Linux Console Test: add a test for alpha + clipper

2019-01-17 Thread Cleber Rosa
tance" will automatically include this test by the use of the "arch:alpha" tags. Alternatively, this test can be run using: $ avocado run -t arch:alpha tests/acceptance $ avocado run -t machine:clipper tests/acceptance Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Cleber Ro

Re: [Qemu-devel] [PATCH] scripts/replay-dump.py: fix utf-8 mangling

2019-01-17 Thread Cleber Rosa
distribute it and/or > # modify it under the terms of the GNU Lesser General Public > Reviewed-by: Cleber Rosa

[Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt

2019-01-17 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on a aarch64 target using the virt machine. One special option added is the CPU type, given that the kernel selected fails to boot on the virt machine's default CPU (cortex-a15). Signed-off-by: Cleber Rosa --- .travis.yml

[Qemu-devel] [PATCH 00/18] Acceptance Tests: target architecture support

2019-01-17 Thread Cleber Rosa
rchitecture. [3] - On a previous proposed version, the test class would look at the "arch" parameter given, and would cancel the test if there wasn't a match. --- Git Info: - URI: https://github.com/clebergnu/qemu/tree/sent/target_arch - Remote: https://github.com/clebergn

[Qemu-devel] [PATCH 13/18] Boot Linux Console Test: add a test for mips64el + malta

2019-01-17 Thread Cleber Rosa
est can be run using: $ avocado run -t arch:mips64el tests/acceptance $ avocado run -t machine:malta tests/acceptance Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Cleber Rosa --- .travis.yml| 2 +- tests/acceptance/boot_linux_console.py | 39 +++

[Qemu-devel] [PATCH 17/18] Boot Linux Console Test: add a test for s390x + s390-ccw-virtio

2019-01-17 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on a s390x target using the s390-ccw-virtio machine. Because it's not possible to have multiple VT220 consoles, '-nodefaults' is used, so that the one set with set_console() works correctly. Signed-off-by: Cleber Rosa --- .travis.yml

[Qemu-devel] [PATCH 01/18] scripts/qemu.py: log QEMU launch command line

2019-01-17 Thread Cleber Rosa
Even when the launch of QEMU succeeds, it's useful to have the command line recorded. Signed-off-by: Cleber Rosa --- scripts/qemu.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 6e3b0e6771..ec3567d4e2 100644 --- a/scripts/qemu.py +++ b/scripts

Re: [Qemu-devel] [PATCH 17/18] Boot Linux Console Test: add a test for s390x + s390-ccw-virtio

2019-01-18 Thread Cleber Rosa
On 1/18/19 3:58 AM, Cornelia Huck wrote: > > Cool, I had been looking at adding some of the tests I'm running here > to this framework as well, and this gives me a good base to work with :) > > I'll try to find some time to give it a whirl. > I can't assist you in finding some time, but for

Re: [Qemu-devel] [PATCH] tests.acceptance: adds multi vm capability for acceptance tests

2019-01-23 Thread Cleber Rosa
On 1/14/19 10:55 AM, Caio Carrara wrote: > This change adds the possibility to write acceptance tests with multi > virtual machine support. It's done keeping the virtual machines objects > stored in a test attribute (dictionary). This dictionary shouldn't be > accessed directly but through the

[Qemu-devel] [PATCH v2 2/2] Add "boot_linux" acceptance test

2018-11-21 Thread Cleber Rosa
he virtual environment created by "check-venv". Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux.py | 46 ++ tests/requirements.txt | 1 + 2 files changed, 47 insertions(+) create mode 100644 tests/acceptance/boot_linux.py diff --git

[Qemu-devel] [PATCH v2 0/2] Add "boot_linux" acceptance test

2018-11-21 Thread Cleber Rosa
u-img to create snapshot files. Even though we could require qemu-img to be installed as a dependency of tests, system wide, it actually goes against the goal of testing all QEMU things from the source/build tree. This became aparent with tests running on environments such as Travis

[Qemu-devel] [PATCH v2 1/2] RFC: Acceptance tests: add the build directory to the system PATH

2018-11-21 Thread Cleber Rosa
-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 1e54fd5932..3d5190cbab 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b

[Qemu-devel] [PATCH 0/1] Acceptance tests: add test for set-numa-node error handler fix

2018-11-21 Thread Cleber Rosa
: - Build: https://travis-ci.org/clebergnu/qemu/builds/457721153 - Execution results for tests updated on this series: * https://travis-ci.org/clebergnu/qemu/jobs/457721176#L2051 * https://travis-ci.org/clebergnu/qemu/jobs/457721176#L2052 Cleber Rosa (1): Acceptance tests: add test

[Qemu-devel] [PATCH 1/1] Acceptance tests: add test for set-numa-node error handler fix

2018-11-21 Thread Cleber Rosa
ific check for that was added a separate test. Tests: a22528b918c7d29795129b5a64c4cb44bb57a44d Reference: f3be67812c226162f86ce92634bd913714445420 CC: Igor Mammedov CC: Markus Armbruster Signed-off-by: Cleber Rosa --- tests/acceptance/set_numa_node.py | 41 +++ 1 file c

Re: [Qemu-devel] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Cleber Rosa
On 11/27/18 2:49 PM, Eduardo Habkost wrote: > On Tue, Nov 27, 2018 at 05:00:07PM -0200, Caio Carrara wrote: >> Hi, Cleber. >> >> On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: >>> This is a simple move of Python code that wraps common QEMU &

Re: [Qemu-devel] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Cleber Rosa
On 11/27/18 2:00 PM, Caio Carrara wrote: > Hi, Cleber. > > On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: >> This is a simple move of Python code that wraps common QEMU >> functionality, and are used by a number of different tests >> and scripts.

Re: [Qemu-devel] [PATCH 1/1] Acceptance tests: add test for set-numa-node error handler fix

2018-11-22 Thread Cleber Rosa
On 11/22/18 7:19 AM, Wainer dos Santos Moschetta wrote: > > On 11/21/2018 11:41 AM, Cleber Rosa wrote: >> Commit a22528b918 fixed an issue that is exposed by means of the >> "set-numa-node" QMP command (introduced in f3be67812).  This adds a >> test that pre

Re: [Qemu-devel] [PATCH 1/1] Acceptance tests: add test for set-numa-node error handler fix

2018-11-21 Thread Cleber Rosa
On 11/21/18 10:50 AM, Markus Armbruster wrote: > Cleber Rosa writes: > >> Commit a22528b918 fixed an issue that is exposed by means of the >> "set-numa-node" QMP command (introduced in f3be67812). This adds a >> test that pretty much maps the steps documen

[Qemu-devel] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Cleber Rosa
* generate documentation Signed-off-by: Cleber Rosa --- configure | 1 + scripts/qemu.py => python/qemu/__init__.py | 11 ++- {scripts/qmp => python/qemu}/qmp.py| 0 {scripts => python/qemu}/qtest.py | 5 +++-- scripts/dev

Re: [Qemu-devel] [PATCH] qmp-shell: Fix example with objects as values

2019-01-11 Thread Cleber Rosa
obj\":[1,True,\"three\"]}" I just find the "free style" confusing... IMO how to be more creative about escaping is optional, and adds noise to the most common use case. Thanks, - Cleber. > # > # Both JSON and Python formatting should work, including both styles of > # string literal quotes. Both paradigms of literal values should work, > -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver

2018-11-30 Thread Cleber Rosa
On 11/30/18 4:58 AM, Paolo Bonzini wrote: > On 30/11/18 08:21, Thomas Huth wrote: >> On 2018-11-29 21:43, Eric Blake wrote: >>> On 11/29/18 11:45 AM, Paolo Bonzini wrote: gtester is deprecated by upstream glib and it does not support tests that call g_test_skip in some glib stable

Re: [Qemu-devel] [libvirt] Libvirt upstream CI efforts

2019-02-21 Thread Cleber Rosa
; > Note is a bit more complicated than this for QEMU as there's acutally > many test systems in QEMU > > - Unit tests emitting TAP format with GLib's TAP harnes > - QTests functional tests emitting TAP format with GLib's TAP harness > - Block I/O functional/integration te

Re: [Qemu-devel] Libvirt upstream CI efforts

2019-02-21 Thread Cleber Rosa
something like 'make >integration' that would prepare the selected guests and execute the > test > suite in them (only on demand) > Yes, this is the type of experience that should ultimately be delivered. > Regards, > Erik > > [1] https://github.com/autotest/tp-libvirt > [2] https://libvirt.org/testtck.html > [3] > https://wiki.centos.org/QaWiki/CI/GettingStarted#head-a46ee49e8818ef9b50225c4e9d429f7a079758d2 > [4] https://github.com/libvirt/libvirt-jenkins-ci > [1] https://github.com/avocado-framework/avocado/tree/master/selftests/deployment -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

Re: [Qemu-devel] [PATCH v3 02/12] docs: Convert memory.txt to rst format

2019-03-06 Thread Cleber Rosa
85-3-peter.mayd...@linaro.org Reviewed-by: Cleber Rosa

Re: [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

2019-03-06 Thread Cleber Rosa
) Unexpected section title. } { Exiting due to level-4 (SEVERE) system message. But I'm assuming the extended sphinx roles/directives will be used, so the only way to check against future breakage would be to build the docs. Do we have strong position in favor or against putting that into the "common" `make check` flow? Anyway, these are all possibilities for future enhancements, so: Reviewed-by: Cleber Rosa

Re: [Qemu-devel] [PATCH v3 08/12] docs: Provide separate conf.py for each manual we want

2019-03-06 Thread Cleber Rosa
On Tue, Mar 05, 2019 at 05:21:35PM +, Peter Maydell wrote: > By default Sphinx wants to build a single manual at once. > For QEMU, this doesn't suit us, because we want to have > separate manuals for "Developer's Guide", "User Manual", > and so on, and we don't want to ship the Developer's

Re: [Qemu-devel] [PULL 0/7] Python queue, 2019-02-22

2019-03-06 Thread Cleber Rosa
On Fri, Mar 01, 2019 at 02:38:45PM +, Peter Maydell wrote: > On Fri, 22 Feb 2019 at 19:41, Cleber Rosa wrote: > > > > The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116: > > > > Merge remote-tracking branch > > 'remotes/awil

Re: [Qemu-devel] [PATCH v2 1/2] Acceptance tests: use linux-3.6 and set vm memory to 4GiB

2019-02-22 Thread Cleber Rosa
ading more than 2GiB initrd > > CC: Wainer dos Santos Moschetta > CC: Caio Carrara > CC: Cleber Rosa > CC: Eduardo Habkost > CC: Philippe Mathieu-Daudé > Signed-off-by: Li Zhijian > Reviewed-by: Cleber Rosa

Re: [Qemu-devel] [PATCH v2 2/2] Acceptance tests: expect boot to extract 2GiB+ initrd with linux-v4.16

2019-02-22 Thread Cleber Rosa
CC: Wainer dos Santos Moschetta > CC: Caio Carrara > CC: Cleber Rosa > CC: Eduardo Habkost > CC: Philippe Mathieu-Daudé > Signed-off-by: Li Zhijian > Reviewed-by: Cleber Rosa

Re: [Qemu-devel] [PATCH v2] iotests: handle TypeError for Python3 in test 242

2019-02-22 Thread Cleber Rosa
ys.version_info.major == 2: ... Because this is already present on other tests, and IIRC Max mentioned using this as an easy to find flag the moment Python 2 support is to be dropped. But, looking for "sys.version_info.major" is just as effective, so: Reviewed-by: Cleber Rosa > > qemu_img_create('-f', iotests.imgfmt, disk, '1M') >

[Qemu-devel] [PULL 1/7] Acceptance tests: drop usage of ":avocado: enable"

2019-02-22 Thread Cleber Rosa
oiler plate statements can now be removed. Reference: https://avocado-framework.readthedocs.io/en/68.0/release_notes/68_0.html#users-test-writers Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wainer dos Santos Moschetta Message-Id: <201902

[Qemu-devel] [PULL 4/7] tests.acceptance: adds multi vm capability for acceptance tests

2019-02-22 Thread Cleber Rosa
usage of vm in tests will not be broken by this change since it keeps a property called vm in the base test class. This property only calls the new method `get_vm` with default parameters (no args and 'default' as machine name). Signed-off-by: Caio Carrara Reviewed-by: Cleber Rosa Reviewed

[Qemu-devel] [PULL 0/7] Python queue, 2019-02-22

2019-02-22 Thread Cleber Rosa
avocado: enable" Caio Carrara (2): tests.acceptance: adds multi vm capability for acceptance tests tests.acceptance: adds simple migration test Cleber Rosa (3): Acceptance tests: drop usage of ":avocado: enable" Introduce a Python module structure scripts/qemu.py: log QEMU l

[Qemu-devel] [PULL 6/7] Acceptance tests: use linux-3.6 and set vm memory to 4GiB

2019-02-22 Thread Cleber Rosa
Santos Moschetta CC: Caio Carrara CC: Cleber Rosa CC: Eduardo Habkost CC: Philippe Mathieu-Daudé Signed-off-by: Li Zhijian Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Cleber Rosa Message-Id: <1548638112-31101-1-git-send-email-lizhij...@cn.fujitsu.com> Signed-off-by: Clebe

[Qemu-devel] [PULL 2/7] Introduce a Python module structure

2019-02-22 Thread Cleber Rosa
style * generate documentation Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara Reviewed-by: Stefan Hajnoczi Message-Id: <20190206162901.19082-2-cr...@redhat.com> Signed-off-by: Cleber Rosa --- configure | 1 + scripts/qemu.py => python/qemu/__init_

[Qemu-devel] [PULL 3/7] scripts/qemu.py: log QEMU launch command line

2019-02-22 Thread Cleber Rosa
Even when the launch of QEMU succeeds, it's useful to have the command line recorded. Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Cleber Rosa Message-Id: <20190202005610.24048-2-cr...@redhat.com> Signed-off-by: Cleber Rosa ---

[Qemu-devel] [PULL 5/7] tests.acceptance: adds simple migration test

2019-02-22 Thread Cleber Rosa
From: Caio Carrara This change adds the simplest possible migration test. Beyond the test purpose itself it's also useful to exercise the multi virtual machines capabilities from base avocado qemu test class. Signed-off-by: Cleber Rosa Signed-off-by: Caio Carrara Reviewed-by: Cleber Rosa

[Qemu-devel] [PULL 7/7] Acceptance tests: expect boot to extract 2GiB+ initrd with linux-v4.16

2019-02-22 Thread Cleber Rosa
: Cleber Rosa CC: Eduardo Habkost CC: Philippe Mathieu-Daudé Signed-off-by: Li Zhijian Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Cleber Rosa Message-Id: <1548638112-31101-2-git-send-email-lizhij...@cn.fujitsu.com> Signed-off-by: Cleber Rosa --- tests/acceptance/linux_initrd.p

Re: [Qemu-devel] [PATCH] iotests: handle TypeError for Python3 in test 242

2019-02-21 Thread Cleber Rosa
On 2/18/19 4:25 PM, Philippe Mathieu-Daudé wrote: > On 2/18/19 9:05 PM, Eric Blake wrote: >> [adding Eduardo for some python 2-vs-3 advice] > > And Cleber. > >> >> On 2/18/19 1:59 PM, Andrey Shinkevich wrote: >>> To write one byte to disk, Python2 may use 'chr' type. >>> In Python3,

[Qemu-devel] [PATCH v3 01/20] scripts/qemu.py: log QEMU launch command line

2019-02-20 Thread Cleber Rosa
Even when the launch of QEMU succeeds, it's useful to have the command line recorded. Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- scripts/qemu.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qemu.py b

[Qemu-devel] [PATCH v3 02/20] Acceptance tests: show avocado test execution by default

2019-02-20 Thread Cleber Rosa
d to adapt the list of tests to match the user's build environment (among other choices). Because of that, let's present the default Avocado UI by default. Users can always choose a different output by setting the AVOCADO_SHOW variable. Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara Reviewed-by

[Qemu-devel] [PATCH v3 00/20] Acceptance Tests: target architecture support

2019-02-20 Thread Cleber Rosa
kernel command line options (Philippe) * On "Boot Linux Console Test: add a test for s390x + s390-ccw-virtio": - Switched to using common kernel command line options (Philippe) * On "Boot Linux Console Test: add a test for alpha + clipper": - Switched to using

[Qemu-devel] [PATCH v3 15/20] Boot Linux Console Test: add a test for mips64el + malta

2019-02-20 Thread Cleber Rosa
est can be run using: $ avocado run -t arch:mips64el tests/acceptance $ avocado run -t machine:malta tests/acceptance Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Cleber Rosa --- .travis.yml| 2 +- tests/acceptance/boot_linux_console.py | 34 +++

[Qemu-devel] [PATCH v3 04/20] Acceptance tests: fix doc reference to avocado_qemu directory

2019-02-20 Thread Cleber Rosa
The "this directory" reference is misleading and confusing, it's a leftover from when this text was proposed in a README file inside the "tests/acceptance/avocado_qemu" directory. When that text was moved to the top level docs directory, the reference was not updated. Signed

[Qemu-devel] [PATCH v3 05/20] Acceptance tests: introduce arch parameter and attribute

2019-02-20 Thread Cleber Rosa
parameter and a test instance attribute, that will contain such a value. Now, when the "arch" test parameter is given, it will influence the selection of the default QEMU binary, if one is not given explicitly by means of the "qemu_img" parameter. Signed-off-by: Cleber Rosa R

[Qemu-devel] [PATCH v3 03/20] Acceptance tests: improve docstring on pick_default_qemu_bin()

2019-02-20 Thread Cleber Rosa
Making it clear what is returned by this utility function. Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py

[Qemu-devel] [PATCH v3 14/20] Boot Linux Console Test: add a test for mips + malta

2019-02-20 Thread Cleber Rosa
this test by the use of the "arch:mips" tags. Alternatively, this test can be run using: $ avocado run -t arch:mips tests/acceptance $ avocado run -t machine:malta tests/acceptance $ avocado run -t endian:big tests/acceptance Signed-off-by: Philippe Mathieu-Daudé Signed

[Qemu-devel] [PATCH v3 07/20] Acceptance tests: look for target architecture in test tags first

2019-02-20 Thread Cleber Rosa
rch parameter given (manually) does not match the test "arch" tag, but it may be a useful default behavior to be added in the future. Signed-off-by: Cleber Rosa --- docs/devel/testing.rst| 4 +++- tests/acceptance/avocado_qemu/__init__.py | 7 ++- 2 files changed, 9 ins

[Qemu-devel] [PATCH v3 06/20] Acceptance tests: use "arch:" tag to filter target specific tests

2019-02-20 Thread Cleber Rosa
version of the "boot_linux_console.py" test, which downloads and attempts to run a x86_64 kernel, is now tagged as: :avocado: tags=arch:x86_64 This means that it can be filtered (out) when no x86_64 target is available. At the same time, tests that don't have a "arch:" tag, wi

[Qemu-devel] [PATCH v3 08/20] Boot Linux Console Test: rename the x86_64 after the arch and machine

2019-02-20 Thread Cleber Rosa
Given that the test is specific to x86_64 and pc, and new tests are going to be added to the same class, let's rename it accordingly. Also, let's make the class documentation not architecture specific. Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé

<    1   2   3   4   5   6   7   8   9   10   >