Re: [Qemu-devel] [libvirt] [PATCH v1] qemu: command: rework cpu feature argument support

2016-11-16 Thread Collin L. Walling
at 08:42:12AM +0100, Jiri Denemark wrote: On Mon, Nov 14, 2016 at 18:02:29 -0200, Eduardo Habkost wrote: On Mon, Nov 14, 2016 at 02:26:03PM -0500, Collin L. Walling wrote: cpu features are passed to the qemu command with feature=on/off instead of +/-feature. Signed-off-by: Collin L. Walling <w

[Qemu-devel] [PATCH v1 4/4] s390-ccw: interactive boot menu for scsi

2017-11-27 Thread Collin L. Walling
Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> -

[Qemu-devel] [PATCH v1 3/4] s390-ccw: interactive boot menu for eckd dasd

2017-11-27 Thread Collin L. Walling
will cancel the timeout and prompt the user until correct input is given. Any value set for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu prompt will continuously wait until correct user input is given. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.

[Qemu-devel] [PATCH v1 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-11-27 Thread Collin L. Walling
will cancel the timeout and prompt the user until correct input is given. Any value set for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu prompt will continuously wait until correct user input is given. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.

Re: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread Collin L. Walling
On 11/27/2017 01:58 PM, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x Message-id:

[Qemu-devel] [PATCH v1 1/5] s390-ccw: update libc.h

2017-11-27 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function: itostr Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Chr

[Qemu-devel] [PATCH v1 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-27 Thread Collin L. Walling
k geometry. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 24 ++-- pc-bios/s390-ccw/bootmap.h | 55 +- 2 files changed

[Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread Collin L. Walling
the following libvirt domain xml: or ... Where X is some positive integer representing time in milliseconds. Loadparm will override all boot options. Collin L. Walling (4): s390-ccw: ipl structs for eckd cdl/ldl s390-ccw: parse and set boot menu

[Qemu-devel] [PATCH v1 5/5] s390-ccw: interactive boot menu for scsi

2017-11-27 Thread Collin L. Walling
Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> -

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-28 Thread Collin L. Walling
On 11/28/2017 06:45 AM, Thomas Huth wrote: On 27.11.2017 21:55, Collin L. Walling wrote: [...] +static void s390_ipl_set_boot_menu(uint8_t *boot_menu_enabled, + uint16_t *boot_menu_timeout) +{ +QemuOptsList *plist = qemu_find_opts("boot

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 0/5] (FIXED) Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-28 Thread Collin L. Walling
On 11/28/2017 05:35 AM, Cornelia Huck wrote: On Mon, 27 Nov 2017 15:55:31 -0500 "Collin L. Walling" <wall...@linux.vnet.ibm.com> wrote: These patches implement a boot menu for ECKD DASD and SCSI guests on s390x. The menu will only appear if the disk has been configured for I

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-11-28 Thread Collin L. Walling
On 11/28/2017 07:36 AM, Thomas Huth wrote: On 27.11.2017 21:55, Collin L. Walling wrote: [...] +static void read_stage2(block_number_t s1b_block_nr, void **stage2_data) +{ +block_number_t s2_block_nr; +BootEckdStage1b *s1b = (void *)sec; +int i; + +/* Get Stage1b data

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/5] s390-ccw: update libc.h

2017-11-28 Thread Collin L. Walling
On 11/28/2017 05:45 AM, Cornelia Huck wrote: On Mon, 27 Nov 2017 15:55:32 -0500 "Collin L. Walling" <wall...@linux.vnet.ibm.com> wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C st

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-28 Thread Collin L. Walling
On 11/28/2017 05:48 AM, Cornelia Huck wrote: On Mon, 27 Nov 2017 15:55:33 -0500 "Collin L. Walling" <wall...@linux.vnet.ibm.com> wrote: ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend &

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-28 Thread Collin L. Walling
On 11/28/2017 06:04 AM, Cornelia Huck wrote: On Mon, 27 Nov 2017 15:55:34 -0500 "Collin L. Walling" <wall...@linux.vnet.ibm.com> wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot men

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-29 Thread Collin L. Walling
On 11/29/2017 05:28 PM, David Hildenbrand wrote: On 27.11.2017 21:55, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml

[Qemu-devel] [PATCH v1 1/4] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-27 Thread Collin L. Walling
k geometry. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 24 ++-- pc-bios/s390-ccw/bootmap.h | 55 +- 2 files changed

[Qemu-devel] [PATCH v1 2/4] s390-ccw: parse and set boot menu options

2017-11-27 Thread Collin L. Walling
-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- hw/s390x/ipl.c | 20 hw/s390x/ipl.h | 8 ++-- pc-bios/s390-ccw/iplb.h | 8 ++-- 3 files changed, 32 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-27 Thread Collin L. Walling
-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- hw/s390x/ipl.c | 23 +++ hw/s390x/ipl.h | 8 ++-- pc-bios/s390-ccw/iplb.h | 8 ++-- 3 files changed, 35 insertions(+), 4 deleti

[Qemu-devel] [PATCH v1 0/5] (FIXED) Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread Collin L. Walling
the following libvirt domain xml: or ... Where X is some positive integer representing time in milliseconds. Loadparm will override all boot options. Collin L. Walling (5): s390-ccw: update libc.h s390-ccw: ipl structs for eckd cdl/ldl s390-ccw

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-12-12 Thread Collin L. Walling
On 12/12/2017 11:30 AM, Farhan Ali wrote: On 12/11/2017 05:19 PM, Collin L. Walling wrote: When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 3/5] s390-ccw: parse and set boot menu options

2017-12-12 Thread Collin L. Walling
On 12/12/2017 12:00 PM, David Hildenbrand wrote: On 11.12.2017 23:19, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-12-14 Thread Collin L. Walling
On 12/14/2017 12:41 PM, Cornelia Huck wrote: On Mon, 11 Dec 2017 17:19:17 -0500 "Collin L. Walling" <wall...@linux.vnet.ibm.com> wrote: ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend &

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc

2017-12-18 Thread Collin L. Walling
On 12/18/2017 08:06 AM, Thomas Huth wrote: On 11.12.2017 23:19, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-12-18 Thread Collin L. Walling
On 12/14/2017 12:41 PM, Cornelia Huck wrote: On Mon, 11 Dec 2017 17:19:17 -0500 "Collin L. Walling" <wall...@linux.vnet.ibm.com> wrote: ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend &

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc

2017-12-19 Thread Collin L. Walling
On 12/19/2017 02:31 AM, Thomas Huth wrote: On 18.12.2017 17:16, Collin L. Walling wrote: On 12/18/2017 08:06 AM, Thomas Huth wrote: On 11.12.2017 23:19, Collin L. Walling wrote: Moved:    memcmp from bootmap.h to libc.h (renamed from _memcmp)    strlen from sclp.c to libc.h (renamed from

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/5] s390-ccw: update libc

2017-12-19 Thread Collin L. Walling
On 12/19/2017 11:29 AM, Collin L. Walling wrote: On 12/19/2017 02:31 AM, Thomas Huth wrote: On 18.12.2017 17:16, Collin L. Walling wrote: On 12/18/2017 08:06 AM, Thomas Huth wrote: On 11.12.2017 23:19, Collin L. Walling wrote: Moved:     memcmp from bootmap.h to libc.h (renamed from _memcmp

[Qemu-devel] Interactive Boot Menu: New Fields in IPLB

2017-12-07 Thread Collin L. Walling
0];     uint16_t devno;     uint8_t  reserved2[88];     uint8_t  reserved_ext[4096 - 200];     } QEMU_PACKED; } QEMU_PACKED; typedef union IplParameterBlock IplParameterBlock; - Thanks for your time, - Collin L Walling

[Qemu-devel] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-12-11 Thread Collin L. Walling
y. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 24 ++-- pc-bios/s390-ccw/bootmap.h | 55 +- 2 files changed, 53 inser

[Qemu-devel] [PATCH v2 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-12-11 Thread Collin L. Walling
line will attempt to use the zipl loader values. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/bootmap.c | 71 +- pc-bios/s390-ccw/bootmap.h | 2 + pc-bios/s390-ccw/main.c | 3 + pc-bios/s390-ccw/

[Qemu-devel] [PATCH v2 5/5] s390-ccw: interactive boot menu for scsi

2017-12-11 Thread Collin L. Walling
Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> -

[Qemu-devel] [PATCH v2 1/5] s390-ccw: update libc

2017-12-11 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function: itostr Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Chr

[Qemu-devel] [PATCH v2 3/5] s390-ccw: parse and set boot menu options

2017-12-11 Thread Collin L. Walling
other than 'prompt' will disable the menu and just boot the specified entry. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- hw/s390x/ipl.c | 55 + hw

[Qemu-devel] [PATCH v2 0/5] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-12-11 Thread Collin L. Walling
representing time in milliseconds. A loadparm other than 'prompt' will disable the menu and just boot the specified entry. If no boot options are specified, we will attempt to use the values provided by zipl (ECKD DASD only). Collin L. Walling (5): s390-ccw: update libc s390-ccw: ipl structs

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-25 Thread Collin L. Walling
On 10/20/2017 07:37 AM, Halil Pasic wrote: On 10/20/2017 12:25 PM, Christian Borntraeger wrote: From: "Collin L. Walling" <wall...@linux.vnet.ibm.com> The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n

[Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Collin L. Walling
st started Connected to domain test Escape character is ^] Network boot starting... Using MAC address: 02:01:02:03:04:05 Requesting information via DHCP: 010 Signed-off-by: Collin L. Walling <wall...@linux

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Collin L. Walling
On 10/26/2017 04:25 PM, Alexander Graf wrote: On 26.10.17 20:52, Collin L. Walling wrote: The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n') as just a new line instead of as a Unix line feed. Because of this, output

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Collin L. Walling
On 10/26/2017 04:48 PM, Alexander Graf wrote: On 26.10.17 22:37, Collin L. Walling wrote: On 10/26/2017 04:25 PM, Alexander Graf wrote: On 26.10.17 20:52, Collin L. Walling wrote: The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat

[Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lines

2017-10-27 Thread Collin L. Walling
st started Connected to domain test Escape character is ^] Network boot starting... Using MAC address: 02:01:02:03:04:05 Requesting information via DHCP: 010 Signed-off-by: Collin L. Walling <wall...@linux

Re: [Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lines

2017-10-27 Thread Collin L. Walling
On 10/27/2017 11:39 AM, Halil Pasic wrote: On 10/27/2017 04:30 PM, Collin L. Walling wrote: The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n') as just a new line instead of as a Unix line feed. Because of this, output

[Qemu-devel] [PATCH v4] s390-ccw: print carriage return with new lines

2017-10-27 Thread Collin L. Walling
st started Connected to domain test Escape character is ^] Network boot starting... Using MAC address: 02:01:02:03:04:05 Requesting information via DHCP: 010 Signed-off-by: Collin L. Walling <wall...@linux

[Qemu-devel] [PATCH v3 4/8] s390-ccw: interactive boot menu for eckd dasd (menu setup)

2018-01-15 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/iplb.h | 3 +++ pc-bios/s390-ccw/main.c | 21 +++

[Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc

2018-01-15 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function: itostr Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Chr

[Qemu-devel] [PATCH v3 6/8] s390-ccw: interactive boot menu for eckd dasd (print menu)

2018-01-15 Thread Collin L. Walling
Prints the menu data starting from the zIPL menu banner. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 3 +-- pc-bios/s390-ccw/menu.c| 42 ++ pc-bios/s390-ccw/menu.h| 1 + 3 files chang

[Qemu-devel] [PATCH v3 8/8] s390-ccw: interactive boot menu for scsi

2018-01-15 Thread Collin L. Walling
Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> -

[Qemu-devel] [PATCH v3 3/8] s390-ccw: parse and set boot menu options

2018-01-15 Thread Collin L. Walling
other than 'prompt' will disable the menu and just boot the specified entry. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- hw/s390x/ipl.c | 54 + hw

[Qemu-devel] [PATCH v3 2/8] s390-ccw: ipl structs for eckd cdl/ldl

2018-01-15 Thread Collin L. Walling
y. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Janosch Frank <fran...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 29 +--- pc-bios/s390-ccw/bootmap.h | 55 +- 2 files changed, 56 inser

[Qemu-devel] [PATCH v3 0/8] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-01-15 Thread Collin L. Walling
presenting time in milliseconds. A loadparm other than 'prompt' will disable the menu and just boot the specified entry. If no boot options are specified, we will attempt to use the values provided by zipl (ECKD DASD only). Collin L. Walling (8): s390-ccw: update libc s390-ccw: ipl structs fo

[Qemu-devel] [PATCH v3 7/8] s390-ccw: interactive boot menu for eckd dasd (read input)

2018-01-15 Thread Collin L. Walling
appropriately. A correct value will boot the respective boot menu entry. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/menu.c | 160 +++- pc-bios/s390-ccw/s390-ccw.h | 2 + pc-bios/s390-ccw/sclp.c | 20

[Qemu-devel] [PATCH v3 5/8] s390-ccw: interactive boot menu for eckd dasd (read stage2 data)

2018-01-15 Thread Collin L. Walling
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 112 +++-- pc-bios/s390-ccw/bootmap.h | 1 + pc-bios/s390-ccw/menu.h| 10 3 files changed, 118 insertions(+), 5 deletions(-) diff --git a/pc-bios/s390-cc

Re: [Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc

2018-01-15 Thread Collin L. Walling
On 01/15/2018 12:05 PM, Eric Blake wrote: On 01/15/2018 10:44 AM, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/8] s390-ccw: update libc

2018-01-16 Thread Collin L. Walling
On 01/16/2018 05:00 AM, Thomas Huth wrote: On 15.01.2018 18:23, Collin L. Walling wrote: On 01/15/2018 12:05 PM, Eric Blake wrote: On 01/15/2018 10:44 AM, Collin L. Walling wrote: [...] +/** + * atoi: + * @str: the string to be converted. + * + * Given a string @str, convert it to an integer

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/8] s390-ccw: update libc

2018-01-16 Thread Collin L. Walling
On 01/16/2018 06:07 AM, Christian Borntraeger wrote: On 01/15/2018 06:23 PM, Collin L. Walling wrote: On 01/15/2018 12:05 PM, Eric Blake wrote: On 01/15/2018 10:44 AM, Collin L. Walling wrote: Moved:    memcmp from bootmap.h to libc.h (renamed from _memcmp)    strlen from sclp.c to libc.h

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/8] s390-ccw: ipl structs for eckd cdl/ldl

2018-01-16 Thread Collin L. Walling
On 01/16/2018 07:32 AM, Thomas Huth wrote: On 15.01.2018 17:44, Collin L. Walling wrote: ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 3/8] s390-ccw: parse and set boot menu options

2018-01-16 Thread Collin L. Walling
On 01/16/2018 07:44 AM, Thomas Huth wrote: On 15.01.2018 17:44, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 7/8] s390-ccw: interactive boot menu for eckd dasd (read input)

2018-01-17 Thread Collin L. Walling
On 01/17/2018 05:10 AM, Thomas Huth wrote: On 15.01.2018 17:44, Collin L. Walling wrote: When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 04/10] s390-ccw: update libc

2018-01-25 Thread Collin L. Walling
ve to have standardized semantics. Sound good.  I'll prepend the underscore and document the differences. Thanks for your suggestions. -- - Collin L Walling

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 03/10] s390-ccw: refactor IPL structs

2018-01-25 Thread Collin L. Walling
On 01/25/2018 06:39 AM, Thomas Huth wrote: On 23.01.2018 19:26, Collin L. Walling wrote: ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 07/10] s390-ccw: read stage2 boot loader data to find menu

2018-01-25 Thread Collin L. Walling
On 01/25/2018 10:25 AM, Thomas Huth wrote: On 23.01.2018 19:26, Collin L. Walling wrote: Read the stage2 boot loader data block-by-block. We scan the current block for the string "zIPL" to detect the start of the boot menu banner. We then load the adjacent blocks (previous block and

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 01/10] s390-ccw: refactor boot map table code

2018-01-25 Thread Collin L. Walling
On 01/25/2018 05:07 AM, Thomas Huth wrote: On 23.01.2018 19:26, Collin L. Walling wrote: - replace ScsiMbr in ECKD code with BootMapTable - fix read_block messages to reflect BMT - reduce ipl_scsi code with BMT struct Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- p

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 02/10] s390-ccw: refactor eckd_block_num to use CHS

2018-01-25 Thread Collin L. Walling
On 01/25/2018 06:17 AM, Cornelia Huck wrote: On Thu, 25 Jan 2018 12:06:50 +0100 Thomas Huth <th...@redhat.com> wrote: On 23.01.2018 19:26, Collin L. Walling wrote: Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used ec

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console

2018-01-29 Thread Collin L. Walling
On 01/29/2018 05:07 AM, David Hildenbrand wrote: On 23.01.2018 19:26, Collin L. Walling wrote: Implements an sclp_read function to capture input from the console and a wrapper function that handles parsing certain characters and adding input to a buffer. The input is checked for any erroneous

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 08/10] s390-ccw: print zipl boot menu

2018-01-29 Thread Collin L. Walling
On 01/29/2018 05:15 AM, David Hildenbrand wrote: On 23.01.2018 19:26, Collin L. Walling wrote: When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console

2018-01-29 Thread Collin L. Walling
On 01/29/2018 08:08 AM, David Hildenbrand wrote: On 23.01.2018 19:26, Collin L. Walling wrote: Implements an sclp_read function to capture input from the console and a wrapper function that handles parsing certain characters and adding input to a buffer. The input is checked for any erroneous

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 04/12] s390-ccw: update libc

2018-02-06 Thread Collin L. Walling
On 02/06/2018 01:14 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: itostr

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-06 Thread Collin L. Walling
On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: On 06.02.2018 10:23, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: [...] diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 0d06fc1..3e3c3b8 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -399,6 +399,20 @@ void

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 01/12] s390-ccw: refactor boot map table code

2018-02-06 Thread Collin L. Walling
On 02/06/2018 12:52 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: - replace ScsiMbr in ECKD code with BootMapTable - fix read_block messages to reflect BMT - reduce ipl_scsi code with BMT struct Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-06 Thread Collin L. Walling
On 02/06/2018 05:07 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq disabling. Those interrupts could propagate to the guest

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-14 Thread Collin L. Walling
On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: On 06.02.2018 10:23, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: [...] diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index e857ce4..825a1a3 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-14 Thread Collin L. Walling
On 02/14/2018 05:57 AM, David Hildenbrand wrote: On 05.02.2018 21:57, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq disabling. Those interrupts could propagate

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-14 Thread Collin L. Walling
ng in qemu-options.hx that s390 treats "splash-time" as the menu-timeout. Thoughts? On 02/05/2018 03:57 PM, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,sp

[Qemu-devel] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-05 Thread Collin L. Walling
The s390-ccw firmware needs some information in support of the boot process which is not available on the native machine. Examples are the netboot firmware load address and now the boot menu parameters. While storing that data in unused fields of the IPL parameter block works, that approach could

[Qemu-devel] [PATCH v5 03/12] s390-ccw: refactor IPL structs

2018-02-05 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling <wall...@linux.vnet.i

[Qemu-devel] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-05 Thread Collin L. Walling
to prevent further service interrupts from ASCII events and then consume all pending irqs for a miniscule duration. Once finished, we reset the write event mask and resume business as usual. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/menu.

[Qemu-devel] [PATCH v5 08/12] s390-ccw: read stage2 boot loader data to find menu

2018-02-05 Thread Collin L. Walling
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Thomas Huth <th...@redhat.com> --- pc-bios/s390-ccw/bootmap.c | 94 +++--- pc-bios/s390-ccw/bootmap.h | 23 +++- pc-bios/s390-ccw/menu.c| 5 +++ pc-bios/s390-ccw/men

[Qemu-devel] [PATCH v5 10/12] s390-ccw: read user input for boot index via the SCLP console

2018-02-05 Thread Collin L. Walling
entries, then the selection will be booted. Any erroneous input will cancel the timeout and re-prompt the user. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Thomas Huth <th...@redhat.com> --- pc-bios/s390-ccw/menu

[Qemu-devel] [PATCH v5 00/12]Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-05 Thread Collin L. Walling
ll attempt to use the values provided by zipl (ECKD DASD only). Collin L. Walling (12): s390-ccw: refactor boot map table code s390-ccw: refactor eckd_block_num to use CHS s390-ccw: refactor IPL structs s390-ccw: update libc s390-ccw: move auxiliary IPL data to separate location s390-

[Qemu-devel] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-05 Thread Collin L. Walling
for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu will be enabled without a timeout. The absence of any boot options on the command line will flag to later use the zipl boot loader values. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Re

[Qemu-devel] [PATCH v5 02/12] s390-ccw: refactor eckd_block_num to use CHS

2018-02-05 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.

[Qemu-devel] [PATCH v5 09/12] s390-ccw: print zipl boot menu

2018-02-05 Thread Collin L. Walling
(linux-4.13.0) 1. linux-4.13.0 2. performance 3. kvm Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Thomas Huth <th...@redhat.com> --- pc-bios/s390-ccw/menu.c | 49 - 1 file changed, 48 insertions(+), 1 delet

[Qemu-devel] [PATCH v5 04/12] s390-ccw: update libc

2018-02-05 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: itostr atoui Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Acked-by: Chr

[Qemu-devel] [PATCH v5 07/12] s390-ccw: set up interactive boot menu parameters

2018-02-05 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Thomas Huth <th...@redhat.com> --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/m

[Qemu-devel] [PATCH v5 01/12] s390-ccw: refactor boot map table code

2018-02-05 Thread Collin L. Walling
- replace ScsiMbr in ECKD code with BootMapTable - fix read_block messages to reflect BMT - reduce ipl_scsi code with BMT struct Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> --- pc-bios/s390-ccw/bootmap.c | 53 ++ pc-bios/s3

[Qemu-devel] [PATCH v5 12/12] s390-ccw: interactive boot menu for scsi

2018-02-05 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com> Reviewed-by: Thoma

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/12]Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-05 Thread Collin L. Walling
: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] IPL_assert(num >= 0, "itostr: cannot convert negative values"); ^~ -- - Collin L Walling

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-15 Thread Collin L. Walling
On 02/15/2018 02:04 AM, Thomas Huth wrote: On 14.02.2018 16:33, Collin L. Walling wrote: On 02/14/2018 05:57 AM, David Hildenbrand wrote: [...] 1. CKC interrupts can be cleared by resetting the CKC 2. SCLP interrupts can be cleared only via delivery (apart from CPU reset) So if you have CKC

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/19/2018 11:00 AM, Thomas Huth wrote: On 19.02.2018 16:40, Collin L. Walling wrote: On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be converted. + * @str: a pointer to a string to store

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be converted. + * @str: a pointer to a string to store the conversion. + * @len: the length of the passed string. + * + * Given an integer @num

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/19/2018 11:19 AM, Collin L. Walling wrote: On 02/19/2018 11:00 AM, Thomas Huth wrote: On 19.02.2018 16:40, Collin L. Walling wrote: On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Collin L. Walling
On 02/19/2018 09:15 AM, Christian Borntraeger wrote: On 02/16/2018 11:07 PM, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq-type disabling. Those interrupts could

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Collin L. Walling
On 02/19/2018 09:17 AM, Christian Borntraeger wrote: On 02/19/2018 03:15 PM, Christian Borntraeger wrote: On 02/16/2018 11:07 PM, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
putting it all together. Shall I whip something up and post what I have as a reply to this email chain? -- - Collin L Walling

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote: On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: On 22.02.2018 12:51, Christian Borntraeger wrote: Series Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Thanks!!! menu o

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
On 02/22/2018 11:45 AM, Collin L. Walling wrote: On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote: On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: On 22.02.2018 12:51, Christian Borntraeger wrote: Series Acked-by: Christian Borntraeger

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 06/12] s390-ccw: parse and set boot menu options

2018-02-16 Thread Collin L. Walling
uint8_t reserved2[16]; +uint8_t reserved2[14]; } QEMU_PACKED; typedef struct QemuIplParameters QemuIplParameters; Thomas -- - Collin L Walling

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 06/12] s390-ccw: parse and set boot menu options

2018-02-16 Thread Collin L. Walling
On 02/16/2018 11:20 AM, Thomas Huth wrote: On 15.02.2018 23:54, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 04/12] s390-ccw: update libc

2018-02-16 Thread Collin L. Walling
On 02/16/2018 11:05 AM, Thomas Huth wrote: On 15.02.2018 23:54, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) What happened to the renames of _strlen to strlen and _memcmp to memcmp? The hunks

Re: [Qemu-devel] [PATCH v6 10/12] s390-ccw: read user input for boot index via the SCLP console

2018-02-16 Thread Collin L. Walling
On 02/16/2018 10:03 AM, David Hildenbrand wrote: On 15.02.2018 23:54, Collin L. Walling wrote: [...] + static int get_boot_index(int entries) { -return 0; /* Implemented next patch */ +int boot_index; +bool retry = false; +char tmp[5]; + +do { +boot_menu_prompt

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 01/12] s390-ccw: refactor boot map table code

2018-02-16 Thread Collin L. Walling
On 02/16/2018 07:19 AM, Viktor Mihajlovski wrote: On 16.02.2018 11:42, Thomas Huth wrote: On 15.02.2018 23:54, Collin L. Walling wrote: Some ECKD bootmap code was using structs designed for SCSI. Even though this works, it confuses readability. Add a new BootMapTable struct to assist

[Qemu-devel] [PATCH v6 03/12] s390-ccw: refactor IPL structs

2018-02-15 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling <wall...@linux.vnet.i

  1   2   >