answers. Even as non native speaker
I was aware that this part still did not sound like correct English,
but I restricted my modifications to those parts where I was sure.
Let's ask the original author Corentin Chary...
Regards
Stefan W.
--
Corentin Chary
http://xf.iksaif.net
encoding for lossless
updates,
like zlib or tight.
- Bitmap module: create bitmap.h and bitops.h, and remove duplicate code
from vnc.c
It was my last series from GSoC 2010 context, if necessary I can send different
series for adaptive vnc, zrle and bitmap stuff.
Thanks,
Corentin Chary (15
These two helpers are needed for zrle and zywrle.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 33 +
ui/vnc-palette.h |3 +++
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
If an adaptive encoding has choosen to send a lossy update
based on the result of vnc_update_freq(), then it should advertise
it with vnc_sent_lossy_rect(). This will allow to automatically refresh
this rect once it's static again.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc
Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 91 ++---
ui/vnc.h |7 +++--
2 files changed, 25 insertions(+), 73 deletions(-)
diff
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 18 ++
ui/vnc-palette.h |3 ++-
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git
rect was not updated in the last 2 second, then the frequency
became 0, and all the stored timestamp are reseted.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 101 ++
ui/vnc.h | 19 +++
2 files changed, 120
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 600ea75..9189014 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
This allow to use palette on the stack instead of always
allocating them.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c |8 +++-
ui/vnc-palette.h |1 +
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index
This option allow to disable adaptive behaviors in some encodings.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-options.hx|9 +
ui/vnc-enc-tight.c |2 +-
ui/vnc.c | 13 +
ui/vnc.h |1 +
4 files changed, 20 insertions(+), 5
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c |4 ++--
ui/vnc-enc-zrle.c |3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ad9a9a8..81024d5 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc
.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
Makefile.objs |1 +
bitmap.c | 255 +
bitmap.h | 222 ++
bitops.c | 142 ++
bitops.h
__ffs(1): 0
ffs(1): 1
This behavior is needed for all the other function to work (and makes
more sense that the normal ffs).
But .. maybe I should just use ffs() - 1
--
Corentin Chary
http://xf.iksaif.net
?), but
the destroy call does.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-jobs-async.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-jobs-async.c b/ui/vnc-jobs-async.c
index 6e9cf08..0b5d750 100644
--- a/ui/vnc-jobs-async.c
+++ b/ui/vnc-jobs-async.c
Hi Anthony,
If you want to enable vnc threaded server by default, you should
really merge these two lost patchs :).
Thanks,
Corentin Chary (1):
vnc: qemu can die if the client is disconnected while updating screen
Yoshiaki Tamura (1):
vl.c: set NULL upon deleting handlers
From: Corentin Chary corenti...@iksaif.net
agraf reported that qemu_mutex_destroy(vs-output_mutex) was failing
in vnc_disconnect_finish() when the vnc client was disconnected while
updating the screen.
It's because vnc_worker_thread_loop() tries to unlock the mutex while
not locked.
Signed-off
handler still exists, it'll be
called, and then crashes because of lack of resources. This patch
fixes it.
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
Reviewed-by: Corentin Chary corenti...@iksaif.net
---
vl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff
On Tue, Jan 25, 2011 at 10:03 AM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Tue, Jan 25, 2011 at 8:33 AM, Corentin Chary
corentin.ch...@gmail.com wrote:
From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
Currently qemu_set_fd_handler2() is only setting ioh-deleted upon
deleting
vnc: qemu can die if the client is disconnected while updating screen
http://patchwork.ozlabs.org/patch/80334/
(what about a stable alias instead of [PING x.x] ? Like sta...@kernel.org)
Thanks,
--
Corentin Chary
http://xf.iksaif.net
agraf reported that qemu_mutex_destroy(vs-output_mutex) while failing
in vnc_disconnect_finish().
It's because vnc_worker_thread_loop() tries to unlock the mutex while
not locked. The unlocking call doesn't fail (pthread bug ?), but
the destroy call does.
Signed-off-by: Corentin Chary corenti
From: Corentin Chary corentin.ch...@gmail.com
Hi,
Since v2:
- Fixed some styles issues
- Rebased to current master
- Fixed a Makefile issue (using .c instead of .o)
I rebased the series against current master, it contains:
- Adaptive Tight Encoding: send lossy or lossless updates depending
These two helpers are needed for zrle and zywrle.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 32
ui/vnc-palette.h |3 +++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
If an adaptive encoding has choosen to send a lossy update
based on the result of vnc_update_freq(), then it should advertise
it with vnc_sent_lossy_rect(). This will allow to automatically refresh
this rect once it's static again.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc
This should not change the current behavior, but if any new
encoding try to use the tight quality, it will always be set
to -1 when lossy encodings are disabled.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff
rect was not updated in the last 2 second, then the frequency
became 0, and all the stored timestamp are reseted.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 101 ++
ui/vnc.h | 19 +++
2 files changed, 120
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 18 ++
ui/vnc-palette.h |3 ++-
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git
Use the new update frequency infrastructure to use jpeg for regions with
high update frequency.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 75 +++-
1 files changed, 62 insertions(+), 13 deletions(-)
diff --git
This allow to use palette on the stack instead of always
allocating them.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c |8 +++-
ui/vnc-palette.h |1 +
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index
.
bitops_ffsl() and bitops_flsl() are here because bitops/bitmap works
on unsigned long, not int, and we can't use current code because:
* ffs only works on int
* qemu_fls only works on int
* ffsl is a GNU extension
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
Makefile.objs |1
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c |4 ++--
ui/vnc-enc-zrle.c |3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ad9a9a8..81024d5 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc
The for loop in send_lossy_rect was totally wrong, and we can't
call vnc_set_bits() because it does not really do what it should.
Use vnc_set_bit() directly instead.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 12
1 files changed, 8 insertions(+), 4
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 6c57b0e..86c23207 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
This option allow to disable adaptive behaviors in some encodings.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-options.hx|9 +
ui/vnc-enc-tight.c |2 +-
ui/vnc.c | 13 +
ui/vnc.h |1 +
4 files changed, 20 insertions(+), 5
Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 91 ++---
ui/vnc.h |7 +++--
2 files changed, 25 insertions(+), 73 deletions(-)
diff
The force_jpeg threshold was too low.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 81024d5..82c1e96 100644
--- a/ui/vnc-enc
from userspace, there is no way to
implement that into QEMU.
Simply install it on your guests if you want to use it.
--
Corentin Chary
http://xf.iksaif.net
This should not change the current behavior, but if any new
encoding try to use the tight quality, it will always be set
to -1 when lossy encodings are disabled.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff
rect was not updated in the last 2 second, then the frequency
became 0, and all the stored timestamp are reseted.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 101 ++
ui/vnc.h | 19 +++
2 files changed, 120
,
like zlib or tight.
- Bitmap module: create bitmap.h and bitops.h, and remove duplicate code
from vnc.c
This is probably my last series in the GSoC 2010 context, but I'll probably
continue to work on the VNC server for some time :).
Thanks,
Corentin Chary (15):
vnc: don't set the quality
Use the new update frequency infrastructure to use jpeg for regions with
high update frequency.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 75 +++-
1 files changed, 62 insertions(+), 13 deletions(-)
diff --git
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 18 ++
ui/vnc-palette.h |3 ++-
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git
This allow to use palette on the stack instead of always
allocating them.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c |8 +++-
ui/vnc-palette.h |1 +
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index
These two helpers are needed for zrle and zywrle.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 33 +
ui/vnc-palette.h |3 +++
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
Makefile.objs |1 +
bitmap.c | 255 +
bitmap.h | 222 ++
bitops.c | 142 ++
bitops.h
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c |6 +++---
ui/vnc-enc-zrle.c |3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 5ca4342..9f83235 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc
The force_jpeg threshold was too low.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-thread.c |1 +
ui/vnc-enc-tight.c | 20 ++--
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/qemu-thread.c b/qemu-thread.c
index fbc78fe..4094c51 100644
The for loop in send_lossy_rect was totally wrong, and we can't
call vnc_set_bits() because it does not really do what it should.
Use vnc_set_bit() directly instead.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 12
1 files changed, 8 insertions(+), 4
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 0adab4a..dffb4aa 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
This option allow to disable adaptive behaviors in some encodings.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-options.hx|9 +
ui/vnc-enc-tight.c |2 +-
ui/vnc.c | 13 +
ui/vnc.h |1 +
4 files changed, 20 insertions(+), 5
Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 91 ++---
ui/vnc.h |7 +++--
2 files changed, 25 insertions(+), 73 deletions(-)
diff
On Wed, Aug 11, 2010 at 3:06 PM, Chris Krumme
chris.kru...@windriver.com wrote:
Hello Corentin,
On 08/11/2010 12:49 AM, Corentin Chary wrote:
The force_jpeg threshold was too low.
Signed-off-by: Corentin Charycorenti...@iksaif.net
---
qemu-thread.c | 1 +
ui/vnc-enc-tight.c
The force_jpeg threshold was too low.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 9f83235..b0181ff 100644
--- a/ui/vnc-enc
{
+ } else if (vs-csock != -1) {
qemu_set_fd_handler2(vs-csock, NULL, vnc_client_read, NULL, vs);
}
vnc_unlock_output(vs);
--
1.7.1.1
Acked-By: Corentin Chary corenti...@iksaif.net
--
Corentin Chary
http://xf.iksaif.net
-fd_write = NULL;
break;
}
}
--
1.7.1.1
Good catch, thanks,
Reviewed-by: Corentin Chary corenti...@iksaif.net
--
Corentin Chary
http://xf.iksaif.net
stuff is multiplatform, and serious
commercial work needs something faster than tcg.
*-user is useful to GCC developers (and used by those who work on the ARM
backend to run the GCC testsuite).
Paolo
Isn't that also used by scratchbox ?
--
Corentin Chary
http://xf.iksaif.net
=ac71103dc6b408775ae72067790ab367912f75ec
--
Corentin Chary
http://xf.iksaif.net
From RFB specs: The order of the encoding types given in this
message is a hint bby the client as to its preference (the first
encoding specified being most preferred)
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions
-sasl.o] Error 1
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-auth-sasl.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/vnc-auth-sasl.c b/vnc-auth-sasl.c
index acaac0c..a51ddc8 100644
--- a/vnc-auth-sasl.c
+++ b/vnc-auth-sasl.c
@@ -47,7 +47,8 @@ long
This will allow to implement new encodings (tight, zrle, ..)
in a cleaner way. This may hurt performances, because some
functions like vnc_convert_pixel are not static anymore, but
should not be a problem with gcc 4.5 and the new -flto.
Signed-off-by: Corentin Chary corenti...@iksaif.net
From RFB specs: The order of the encoding types given in this
message is a hint by the client as to its preference (the first
encoding specified being most preferred)
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c | 14 ++
1 files changed, 10 insertions(+), 4
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.c b/vnc.c
index a91c3a3..d0c0d00 100644
--- a/vnc.c
+++ b/vnc.c
@@ -655,7 +655,7 @@ static void send_framebuffer_update(VncState *vs, int x,
int y, int w
According to http://tigervnc.org/cgi-bin/rfbproto#zlib-encoding
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c | 12 +---
vnc.h |2 +-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/vnc-encoding-zlib.c b/vnc-encoding-zlib.c
On Tue, May 4, 2010 at 2:01 PM, Corentin Chary corenti...@iksaif.net wrote:
From RFB specs: The order of the encoding types given in this
message is a hint by the client as to its preference (the first
encoding specified being most preferred)
Signed-off-by: Corentin Chary corenti
From RFB specs: The order of the encoding types given in this
message is a hint by the client as to its preference (the first
encoding specified being most preferred)
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c | 15 +++
1 files changed, 11 insertions(+), 4
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c |9 -
vnc.h |1 +
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/vnc-encoding-zlib.c b/vnc-encoding-zlib.c
index 6a16a79..29dd1b7 100644
--- a/vnc-encoding-zlib.c
+++ b/vnc
This patch only add support for basic compression
without any filter.
This should not be merged right now, because it's currently
worse than zlib, but clients would prefer it. This only for preliminary
review and comments.
Thanks,
---
Makefile |2 +
Makefile.objs |
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
index b836569..0c661a9 100644
--- a/vnc-encoding-tight.c
+++ b/vnc-encoding-tight.c
@@ -1,9 +1,14
According to http://tigervnc.org/cgi-bin/rfbproto#zlib-encoding
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c | 12 +---
vnc.h |2 +-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/vnc-encoding-zlib.c b/vnc-encoding-zlib.c
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.c b/vnc.c
index a91c3a3..d0c0d00 100644
--- a/vnc.c
+++ b/vnc.c
@@ -655,7 +655,7 @@ static void send_framebuffer_update(VncState *vs, int x,
int y, int w
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c | 245 +-
1 files changed, 244 insertions(+), 1 deletions(-)
diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
index 0d328c2..5ea90c0 100644
--- a/vnc-encoding
Also introduce a new helper to free buffers: buffer_free()
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c | 11 +++
vnc-encoding-zlib.c |8
vnc.c| 23 ++-
vnc.h|4 +++-
4 files changed
This patch only add support for basic compression
without any filter.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
Makefile |2 +
Makefile.objs |1 +
vnc-encoding-hextile.c |5 +-
vnc-encoding-tight.c | 287
.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c |7 ---
vnc-encoding-zlib.c |5 -
vnc.c|2 --
vnc.h|2 --
4 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c |9 -
vnc.h |1 +
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/vnc-encoding-zlib.c b/vnc-encoding-zlib.c
index 6a16a79..29dd1b7 100644
--- a/vnc-encoding-zlib.c
+++ b/vnc
On Tue, May 18, 2010 at 11:18 AM, Alexander Graf ag...@suse.de wrote:
On 18.05.2010, at 09:31, Corentin Chary wrote:
This is missing a patch description. When people later on either cherry-pick
your commits or simply git show them, it's almost impossible to know what's
going on.
So please
On Tue, May 18, 2010 at 11:19 AM, Alexander Graf ag...@suse.de wrote:
On 18.05.2010, at 09:31, Corentin Chary wrote:
Signed-off-by: Corentin Chary corenti...@iksaif.net
I'm also missing a cover letter explaining what your patch set does. As a
general rule of thumb, whenever your patch set
(libvncserver and ultravnc seems to support that encoding) and
get some numbers (you can choose the prefered encoding with most of
the vnc clients).
--
Corentin Chary
http://xf.iksaif.net
; ./SDL_viewer 127.0.0.1
On another term I launch tcpdump -i lo0 -nvv port 5900 | python
tcpstat.py dump.csv (but you can use wireshark, etc ...)
[1]
http://xf.iksaif.net/blog/index.php?post/2010/05/18/QEMU%3A-some-charts-on-tight-zlib-and-hextile
--
Corentin Chary
http://xf.iksaif.net
According to http://tigervnc.org/cgi-bin/rfbproto#zlib-encoding
zlib encoding only uses a single stream. Current implementation defines
4 streams but only uses the first one. Remove them and only use a single
stream.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c
Add palette tight encoding. Palette encoding will try to count the number
of colors for a given rectangle, and if this number is low enough
( 256) it will send the palette + the rectangle with indexed colors.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c | 430
send_framebuffer_update() was calling hextile instead of zlib
since commit 70a4568fe0c5a64adaa3da5030b7109e5199e692.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.c b/vnc.c
index a91c3a3..d0c0d00 100644
Free buffers used by tight and zlib encodings, lso introduce
a new helper to free buffers: buffer_free()
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c | 11 +++
vnc-encoding-zlib.c |8
vnc.c| 23
Fill encoding detects rectangle using only one color and send only
one pixel value.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c | 245 +-
1 files changed, 244 insertions(+), 1 deletions(-)
diff --git a/vnc
.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c |7 ---
vnc-encoding-zlib.c |5 -
vnc.c|2 --
vnc.h|2 --
4 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
in qemu_mallocz instead of malloc + memset ?
$ man calloc
calloc() allocates memory for an array of nmemb elements of size
bytes each and returns a pointer to the allocated memory. __The
memory is set to zero.__
--
Corentin Chary
http://xf.iksaif.net
Forget this series, I'm sending a rebased one.
--
Corentin Chary
http://xf.iksaif.net
On Tue, May 18, 2010 at 2:54 PM, Alexander Graf ag...@suse.de wrote:
Corentin Chary wrote:
Create a new set_encoding() function to remove
duplicated code in set_encodings().
Signed-off-by: Corentin Chary corenti...@iksaif.net
Acked-by: Alexander Graf ag...@suse.de
Keep in mind
the first encoding (which is in fact the last, because we
start from the end of the array).
I believe that the right thing to do is to revert
14eb8b6829ad9dee7035de729e083844a425f274 and add some comments to
explain why we loop in reverse order.
--
Corentin Chary
http://xf.iksaif.net
On Tue, May 18, 2010 at 9:02 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Tue, May 18, 2010 at 5:37 PM, Corentin Chary
corentin.ch...@gmail.com wrote:
Did you try to profile using calloc in qemu_mallocz instead of malloc +
memset ?
No, I didn't try it. I don't see how it could perform
This patch was wrong, because the loop was already reversed,
so the first encoding was correctly set at the end of the loopp.
This reverts commit 14eb8b6829ad9dee7035de729e083844a425f274.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c | 14 --
1 files changed, 4
-First-%28dumb%29-tight-benchmarks
[2]
http://xf.iksaif.net/blog/index.php?post/2010/05/18/QEMU%3A-some-charts-on-tight-zlib-and-hextile
Corentin Chary (12):
Revert vnc: set the right prefered encoding
vnc: explain why set_encodings loop is reversed
vnc: really call zlib if we want zlib
vnc
According to http://tigervnc.org/cgi-bin/rfbproto#zlib-encoding
zlib encoding only uses a single stream. Current implementation defines
4 streams but only uses the first one. Remove them and only use a single
stream.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c
send_framebuffer_update() was calling hextile instead of zlib
since commit 70a4568fe0c5a64adaa3da5030b7109e5199e692.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.c b/vnc.c
index d0402b9..e81a2a5 100644
Adjust zlib compression level if needed by calling deflateParams.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c |9 -
vnc.h |1 +
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/vnc-encoding-zlib.c b/vnc-encoding-zlib.c
Add a small comment to explain why we need to start from
the end of the array to set the right prefered encoding.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/vnc.c b/vnc.c
index b1a3fdb..d0402b9 100644
Add palette tight encoding. Palette encoding will try to count the number
of colors for a given rectangle, and if this number is low enough
( 256) it will send the palette + the rectangle with indexed colors.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c | 437
Makes sure we free all ressources used in zlib encoding (zlib stream
and buffer).
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-zlib.c |8
vnc.c |2 ++
vnc.h |1 +
3 files changed, 11 insertions(+), 0 deletions(-)
diff
Some encodings like tight supports tiling (spliting in
multiple sub-rectangles). So we needed a way to tell
vnc_update_client() how much rectangles are in the buffer.
zlib, raw and hextile always send a full rectangle.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding
Fill encoding detects rectangles using only one color and send only
one pixel value.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc-encoding-tight.c | 257 +-
1 files changed, 255 insertions(+), 2 deletions(-)
diff --git a/vnc
Add a buffer_free() helper to free vnc buffers and
remove some duplicated code in vnc_disconnect_finish().
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
vnc.c | 18 ++
vnc.h |1 +
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/vnc.c b/vnc.c
index
1 - 100 of 229 matches
Mail list logo
