[Qemu-devel] [PATCH] block.curl: adding 'curltimeout' option

2014-08-12 Thread Daniel Henrique Barboza
. The previous default timeout of 5 seconds will be used if this option is not present. Signed-off-by: Daniel Henrique Barboza danie...@linux.vnet.ibm.com --- block/curl.c| 13 - qemu-options.hx | 10 -- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/block

[Qemu-devel] [PATCH v2] block.curl: adding 'curltimeout' option

2014-08-12 Thread Daniel Henrique Barboza
. The previous default timeout of 5 seconds will be used if this option is not present. Signed-off-by: Daniel Henrique Barboza danie...@linux.vnet.ibm.com --- block/curl.c| 13 - qemu-options.hx | 10 -- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/block

[Qemu-devel] [PATCH v3] block.curl: adding 'timeout' option

2014-08-13 Thread Daniel Henrique Barboza
. The previous default timeout of 5 seconds will be used if this option is not present. Reviewed-by: Fam Zheng f...@redhat.com Signed-off-by: Daniel Henrique Barboza danie...@linux.vnet.ibm.com --- block/curl.c| 13 - qemu-options.hx | 10 -- 2 files changed, 20 insertions(+), 3

[Qemu-devel] [PATCH v3] block.curl: timeout option

2014-08-13 Thread Daniel Henrique Barboza
Changes in v3: - changed option name from 'curltimeout' to 'timeout' Changes in v2: - remove double quote from the int value in qemu-options.hx Daniel Henrique Barboza (1): block.curl: adding 'timeout' option block/curl.c| 13 - qemu-options.hx | 10 -- 2 files

[Qemu-devel] [PATCH v3] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-22 Thread Daniel Henrique Barboza
er 'downtime_limit' expects an integer in the range of 0 to 200 milliseconds To allow for a proper error message when using QMP, a validation of the user input was added in 'qmp_migrate_set_downtime'. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- migration/mig

[Qemu-devel] [PATCH v2] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-20 Thread Daniel Henrique Barboza
that allows the use of the MAX_MIGRATE_SET_DOWNTIME as a parameter, instead of hardcoding the value in the error message. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- migration/migration.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --g

Re: [Qemu-devel] [PATCH] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-17 Thread Daniel Henrique Barboza
On 02/17/2017 03:37 PM, Paolo Bonzini wrote: On 17/02/2017 18:26, Daniel Henrique Barboza wrote: The previous error message was displaying the values in miliseconds, being misleading with the command that accepts the value in seconds: { "execute": "migrate_set_downti

Re: [Qemu-devel] [PATCH v2] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-21 Thread Daniel Henrique Barboza
On 02/21/2017 12:47 PM, Markus Armbruster wrote: "Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: * Markus Armbruster (arm...@redhat.com) wrote: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> writes: On 02/21/2017 06:02 AM, Markus Armbruster wrote: D

Re: [Qemu-devel] [PATCH v2] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-21 Thread Daniel Henrique Barboza
On 02/21/2017 06:02 AM, Markus Armbruster wrote: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> writes: The previous error message was displaying the values in miliseconds, being misleading with the command that accepts the value in seconds: { "execute": "

[Qemu-devel] [PATCH] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-17 Thread Daniel Henrique Barboza
ricError", "desc": "Parameter 'downtime_limit' expects an integer in the range of 0 to 200 milliseconds"}} This patch changes it to '2000 seconds' to keep consistency with the expected parameter. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com>

[Qemu-devel] [PATCH 4/4] migration: spapr: migrate pending_events of spapr state

2017-04-24 Thread Daniel Henrique Barboza
o make sure migration across different versions is not broken. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 33 + hw/ppc/sp

[Qemu-devel] [PATCH 3/4] migration: spapr: migrate ccs_list in spapr state

2017-04-24 Thread Daniel Henrique Barboza
broken. * see http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg01763.html for more information on this discussion. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 +

[Qemu-devel] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-15 Thread Daniel Henrique Barboza
ists.gnu.org/archive/html/qemu-devel/2017-05/msg05226.html [2] https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg01989.html Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 26 ++ hw/ppc/spapr_ovec.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround

2017-08-10 Thread Daniel Henrique Barboza
On 08/09/2017 09:52 PM, David Gibson wrote: On Wed, Aug 09, 2017 at 05:43:46PM -0300, Daniel Henrique Barboza wrote: Commit d5fc133eed ("ppc: Rework CPU compatibility testing across migration") changed the way cpu_post_load behaves with the PVR setting, causing an unexpected bug

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/8] spapr: DRC cleanups (part VI)

2017-07-14 Thread Daniel Henrique Barboza
On 07/14/2017 03:53 AM, David Gibson wrote: On Thu, Jul 13, 2017 at 07:13:23AM -0300, Daniel Henrique Barboza wrote: On 07/12/2017 09:57 PM, David Gibson wrote: On Wed, Jul 12, 2017 at 10:48:38AM -0300, Daniel Henrique Barboza wrote: The dreaded Libvirt hotplug-migrate-hotunplug scenario

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] spapr: DRC cleanups (part VI)

2017-07-07 Thread Daniel Henrique Barboza
Anyway, this was more of an experiment than a serious fix proposal. I believe the general idea is solid but it'll get a couple of spins to get a good patch for pushing. I'll send the POC as a RFC to get things started and we'll see what happens. I've sent the POC as RFC here: "[RFC drcVI

[Qemu-devel] [RFC drcVI PATCH] spapr: reset DRCs on migration pre_load

2017-07-07 Thread Daniel Henrique Barboza
ot unplugs to work as expected. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 7 +++ hw/ppc/spapr_drc.c | 17 + include/hw/ppc/spapr_drc.h | 1 + 3 files changed, 25 insertions(+) diff --git a/hw/ppc/

Re: [Qemu-devel] [Qemu-ppc] [RFC drcVI PATCH] spapr: reset DRCs on migration pre_load

2017-07-11 Thread Daniel Henrique Barboza
On 07/11/2017 10:00 AM, David Gibson wrote: Ah! So it's broken for the prelaunch case as well, though in a slightly different way. Actually for me the breakage is less obvious - if I plug the cpu at prelaunch, I*do* get 2 cpus appearing in the running system. But tracing through, that's

Re: [Qemu-devel] [Qemu-ppc] [RFC drcVI PATCH] spapr: reset DRCs on migration pre_load

2017-07-11 Thread Daniel Henrique Barboza
On 07/11/2017 10:41 AM, David Gibson wrote: On Tue, Jul 11, 2017 at 11:00:47PM +1000, David Gibson wrote: On Mon, Jul 10, 2017 at 05:37:31PM -0300, Daniel Henrique Barboza wrote: On 07/10/2017 03:39 AM, David Gibson wrote: On Fri, Jul 07, 2017 at 06:20:37PM -0300, Daniel Henrique Barboza

[Qemu-devel] [PATCH v15] migration: spapr: migrate pending_events of spapr state

2017-07-11 Thread Daniel Henrique Barboza
/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Daniel Henrique Barboza (1): migration: spapr: migrate pending_events of spapr state hw/ppc/spapr.c | 32 +++ hw/ppc/spapr_events.c | 103

[Qemu-devel] [PATCH v15] migration: spapr: migrate pending_events of spapr state

2017-07-11 Thread Daniel Henrique Barboza
in the callers of these functions and we don't need to waste resources calling qdev() again. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 +++ hw/ppc/spapr_events.c | 103 +++-- i

Re: [Qemu-devel] [Qemu-ppc] [RFC drcVI PATCH] spapr: reset DRCs on migration pre_load

2017-07-10 Thread Daniel Henrique Barboza
On 07/10/2017 03:39 AM, David Gibson wrote: On Fri, Jul 07, 2017 at 06:20:37PM -0300, Daniel Henrique Barboza wrote: "spapr: Remove 'awaiting_allocation' DRC flag" removed the flag that was originally was being used to prevent a race condition between hot unplug and hotplug. The DRC

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/8] spapr: DRC cleanups (part VI)

2017-07-12 Thread Daniel Henrique Barboza
The dreaded Libvirt hotplug-migrate-hotunplug scenario is working nicely. device_add when the machine is in RUN_STATE_PRELAUNCH (-S) still doesn't work but it is expected - as discussed in "[RFC drcVI PATCH] spapr: reset DRCs on migration pre_load​", this scenario can't be fixed solely by this

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 6/8] spapr: Consolidate DRC state variables

2017-07-12 Thread Daniel Henrique Barboza
On 07/12/2017 02:53 AM, David Gibson wrote: Each DRC has three fields describing its state: isolation_state, allocation_state and configured. At first this seems like a reasonable representation, since its based directly on the PAPR defined isolation-state and allocation-state indicators.

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 8/8] spapr: Implement DR-indicator for physical DRCs only

2017-07-12 Thread Daniel Henrique Barboza
On 07/12/2017 02:53 AM, David Gibson wrote: According to PAPR, the DR-indicator should only be valid for physical DRCs, not logical DRCs. At the moment we implement it for all DRCs, so restrict it to physical ones only. We move the state to the physical DRC subclass, which means adding some

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 7/8] spapr: Remove sPAPRConfigureConnectorState sub-structure

2017-07-12 Thread Daniel Henrique Barboza
On 07/12/2017 02:53 AM, David Gibson wrote: Most of the time, the state of a DRC object is contained in the single 'state' variable. However, during the transition from UNISOLATE to CONFIGURED state requires multiple calls to the ibm,configure-connector RTAS call to retrieve the device tree

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/8] spapr: DRC cleanups (part VI)

2017-07-13 Thread Daniel Henrique Barboza
On 07/12/2017 09:57 PM, David Gibson wrote: On Wed, Jul 12, 2017 at 10:48:38AM -0300, Daniel Henrique Barboza wrote: The dreaded Libvirt hotplug-migrate-hotunplug scenario is working nicely. Good to hear. device_add when the machine is in RUN_STATE_PRELAUNCH (-S) still doesn't work

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] spapr: DRC cleanups (part VI)

2017-07-07 Thread Daniel Henrique Barboza
On 07/07/2017 04:14 AM, David Gibson wrote: On Thu, Jul 06, 2017 at 11:31:35AM -0300, Daniel Henrique Barboza wrote: On 07/05/2017 06:53 PM, Daniel Henrique Barboza wrote: Worth a try. I'll see if I can make a POC of this DRC reset at incoming migration time. Just played a little

Re: [Qemu-devel] [Qemu-ppc] [FIX PATCH v1] spapr: Fix QEMU abort during memory unplug

2017-07-20 Thread Daniel Henrique Barboza
onding entry already exists (Daniel Henrique Barboza) Daniel had shown another alternative, we can switch over to that if preferred. Reviewed-by: Daniel Barboza <danie...@linux.vnet.ibm.com> hw/ppc/spapr.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --

Re: [Qemu-devel] [Qemu-ppc] [FIX PATCH] spapr: Fix QEMU abort during memory unplug

2017-07-19 Thread Daniel Henrique Barboza
On 07/19/2017 05:54 AM, Bharata B Rao wrote: Commit 0cffce56 (hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState) introduced a new way to track pending LMBs of DIMM device that is marked for removal. Since this commit we can hit the assert in spapr_pending_dimm_unplugs_add() in

Re: [Qemu-devel] [Qemu-ppc] [FIX PATCH v2] spapr: Fix QEMU abort during memory unplug

2017-07-21 Thread Daniel Henrique Barboza
On 07/21/2017 03:57 AM, David Gibson wrote: On Fri, Jul 21, 2017 at 10:21:06AM +0530, Bharata B Rao wrote: Commit 0cffce56 (hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState) introduced a new way to track pending LMBs of DIMM device that is marked for removal. Since this commit

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 00/26] spapr: add support for PHB hotplug

2017-07-26 Thread Daniel Henrique Barboza
I've tested the patch set using Greg's Github branch. It worked fine in my tests using a Fedora 26 and an Ubuntu 17.04 guests. I have two observations though: 1 - This is not related to this patch set per se because it is reproducible on master, but I think it is interfering with this new

[Qemu-devel] [PATCH] hw/ppc/spapr.c: do not adjust rma_size with KVM RADIX in ppc_spapr_init

2017-06-28 Thread Daniel Henrique Barboza
earer that a common code applies to both HPT and RADIX. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 7d9af75..117ea9d 100644 --- a/hw/ppc/spap

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: fix memory hotplug error path

2017-07-04 Thread Daniel Henrique Barboza
On 07/04/2017 04:42 AM, Greg Kurz wrote: On Mon, 3 Jul 2017 14:03:07 -0300 Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> wrote: On 07/03/2017 11:54 AM, Greg Kurz wrote: QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. Let's propagate the error inst

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] spapr: DRC cleanups (part VI)

2017-07-04 Thread Daniel Henrique Barboza
I just tested this patch set on top of current ppc-for-2.10 branch (which contains the patches from part V). It applied cleanly but required a couple of trivial fixes to build probably because it was made on top of an older code base. The trivial migration test worked fine. The libvirt

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Daniel Henrique Barboza
On 07/03/2017 09:21 AM, Greg Kurz wrote: QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. Let's propagate the error instead, like it is done everywhere else where spapr_drc_attach() is called. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c | 10 --

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: fix memory hotplug error path

2017-07-03 Thread Daniel Henrique Barboza
On 07/03/2017 11:54 AM, Greg Kurz wrote: QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. Let's propagate the error instead, like it is done everywhere else where spapr_drc_attach() is called. Signed-off-by: Greg Kurz --- Changes in v2: - added rollback

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] spapr: DRC cleanups (part VI)

2017-07-06 Thread Daniel Henrique Barboza
On 07/05/2017 06:53 PM, Daniel Henrique Barboza wrote: Worth a try. I'll see if I can make a POC of this DRC reset at incoming migration time. Just played a little with the idea of manual reset during migration. I've created a POC that resets the CPU DRCs in a pre_load hook. Then I've

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] spapr: DRC cleanups (part VI)

2017-07-05 Thread Daniel Henrique Barboza
On 07/05/2017 08:04 AM, David Gibson wrote: On Tue, Jul 04, 2017 at 06:13:31PM -0300, Daniel Henrique Barboza wrote: I just tested this patch set on top of current ppc-for-2.10 branch (which contains the patches from part V). It applied cleanly but required a couple of trivial fixes to build

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

2017-04-26 Thread Daniel Henrique Barboza
On 04/26/2017 02:55 AM, David Gibson wrote: On Tue, Apr 25, 2017 at 05:45:11PM -0500, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-04-24 17:08:26) In pseries, a firmware abstraction called Dynamic Reconfiguration Connector (DRC) is used to assign a particular dynamic resource

Re: [Qemu-devel] [PATCH 4/4] migration: spapr: migrate pending_events of spapr state

2017-04-26 Thread Daniel Henrique Barboza
On 04/25/2017 07:53 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-04-24 17:08:28) From: Jianjun Duan <du...@linux.vnet.ibm.com> In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source gues

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] migration: alternative way to set instance_id in SaveStateEntry

2017-04-26 Thread Daniel Henrique Barboza
On 04/25/2017 07:26 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-04-24 17:08:25) From: Jianjun Duan <du...@linux.vnet.ibm.com> In QOM (QEMU Object Model) migrated objects are identified with instance_id which is calculated automatically using their path in t

[Qemu-devel] [PATCH 3/4] migration: spapr: migrate ccs_list in spapr state

2017-04-26 Thread Daniel Henrique Barboza
broken. * see http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg01763.html for more information on this discussion. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 +

[Qemu-devel] [PATCH 1/4] hw/ppc: setting spapr_drc_detach_cb in spapr_dr_connector_new

2017-04-26 Thread Daniel Henrique Barboza
ase' to 'spapr_dr_connector_new' instead of 'drck-detach()' * moved the callback functions up in the code so they can be referenced by 'spapr_create_lmb_dr_connectors' and 'spapr_init_cpus' Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c

[Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

2017-04-26 Thread Daniel Henrique Barboza
in 'spapr_tce_table_realize'. This approach works because DRCs are bus-less and do not sit on a BusClass that implements bc->get_dev_path, so as a fallback the VMSD gets identified via "spapr_drc"/get_index(drc). Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/p

[Qemu-devel] [PATCH 4/4] migration: spapr: migrate pending_events of spapr state

2017-04-26 Thread Daniel Henrique Barboza
o make sure migration across different versions is not broken. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 33 + hw/ppc/sp

[Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

2017-04-26 Thread Daniel Henrique Barboza
in 'spapr_tce_table_realize'. This approach works because DRCs are bus-less and do not sit on a BusClass that implements bc->get_dev_path, so as a fallback the VMSD gets identified via "spapr_drc"/get_index(drc). Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/p

[Qemu-devel] [PATCH 1/4] hw/ppc: setting spapr_drc_detach_cb in spapr_dr_connector_new

2017-04-26 Thread Daniel Henrique Barboza
ase' to 'spapr_dr_connector_new' instead of 'drck-detach()' * moved the callback functions up in the code so they can be referenced by 'spapr_create_lmb_dr_connectors' and 'spapr_init_cpus' Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c

[Qemu-devel] [PATCH 0/4 v7] migration/ppc: migrating DRC, ccs_list and pending_events

2017-04-26 Thread Daniel Henrique Barboza
of it. Daniel Henrique Barboza (2): hw/ppc: setting spapr_drc_detach_cb in spapr_dr_connector_new hw/ppc: migrating the DRC state of hotplugged devices Jianjun Duan (2): migration: spapr: migrate ccs_list in spapr state migration: spapr: migrate pending_events of spapr state hw/ppc

[Qemu-devel] [PATCH 3/4] migration: spapr: migrate ccs_list in spapr state

2017-04-26 Thread Daniel Henrique Barboza
broken. * see http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg01763.html for more information on this discussion. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 +

[Qemu-devel] [PATCH 0/4 v7] migration/ppc: migrating DRC, ccs_list and pending_events

2017-04-26 Thread Daniel Henrique Barboza
of it. Daniel Henrique Barboza (2): hw/ppc: setting spapr_drc_detach_cb in spapr_dr_connector_new hw/ppc: migrating the DRC state of hotplugged devices Jianjun Duan (2): migration: spapr: migrate ccs_list in spapr state migration: spapr: migrate pending_events of spapr state hw/ppc

[Qemu-devel] [PATCH 4/4] migration: spapr: migrate pending_events of spapr state

2017-04-26 Thread Daniel Henrique Barboza
o make sure migration across different versions is not broken. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 33 + hw/ppc/sp

[Qemu-devel] [PATCH 1/4] migration: alternative way to set instance_id in SaveStateEntry

2017-04-24 Thread Daniel Henrique Barboza
ration and supports flexible management of DRC objects in migration. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- include/hw/qdev-core.h | 6 ++ migration/savevm.c | 6 ++ 2 files changed, 12 i

[Qemu-devel] [PATCH 0/4 v6] migration/ppc: migrating DRC, ccs_list and pending_events

2017-04-24 Thread Daniel Henrique Barboza
and pending_events of spapr state need be transmitted in migration. This patch set also takes care of it. Daniel Henrique Barboza (1): hw/ppc: migrating the DRC state of hotplugged devices Jianjun Duan (3): migration: alternative way to set instance_id in SaveStateEntry migration: spapr

[Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

2017-04-24 Thread Daniel Henrique Barboza
can properly finish. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr_drc.c | 67 ++ hw/ppc/spapr_pci.c | 22 ++ 2 files changed, 89 insertions(+) diff --git a/hw/ppc/spapr_drc.c b/

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] hw/ppc: setting spapr_drc_detach_cb in spapr_dr_connector_new

2017-04-28 Thread Daniel Henrique Barboza
On 04/26/2017 07:09 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-04-26 16:31:21) The idea of moving the detach callback functions to the constructor of the dr_connector is to set them statically at init time, avoiding any post-load hooks to restore it (after a migration

[Qemu-devel] [PATCH] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround

2017-08-09 Thread Daniel Henrique Barboza
msg00503.html Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- target/ppc/kvm.c | 34 ++ target/ppc/kvm_ppc.h | 1 + target/ppc/machine.c | 22 ++ 3 files changed, 57 insertions(+) diff --git a/target/ppc/kvm.c b/tar

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-17 Thread Daniel Henrique Barboza
On 08/17/2017 04:52 AM, David Gibson wrote: On Tue, Aug 15, 2017 at 05:28:46PM -0300, Daniel Henrique Barboza wrote: This patch is a follow up on the discussions that started with Laurent's patch series "spapr: disable hotplugging without OS" [1] and discussions made at patch &qu

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-22 Thread Daniel Henrique Barboza
On 08/18/2017 01:14 AM, David Gibson wrote: On Thu, Aug 17, 2017 at 06:31:28PM -0300, Daniel Henrique Barboza wrote: On 08/17/2017 04:52 AM, David Gibson wrote: On Tue, Aug 15, 2017 at 05:28:46PM -0300, Daniel Henrique Barboza wrote: This patch is a follow up on the discussions

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-23 Thread Daniel Henrique Barboza
On 08/22/2017 09:24 PM, David Gibson wrote: On Tue, Aug 22, 2017 at 08:50:44PM -0300, Daniel Henrique Barboza wrote: On 08/18/2017 01:14 AM, David Gibson wrote: On Thu, Aug 17, 2017 at 06:31:28PM -0300, Daniel Henrique Barboza wrote: On 08/17/2017 04:52 AM, David Gibson wrote: On Tue, Aug

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] hw/ppc: removing spapr_drc_detach_cb opaques

2017-05-03 Thread Daniel Henrique Barboza
On 05/03/2017 12:26 AM, Bharata B Rao wrote: On Tue, May 2, 2017 at 1:13 PM, Daniel Henrique Barboza <danie...@linux.vnet.ibm.com <mailto:danie...@linux.vnet.ibm.com>> wrote: On 05/02/2017 12:40 AM, Bharata B Rao wrote: On Sun, Apr 30, 2017 at 10:55 PM, Daniel Henr

Re: [Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

2017-05-03 Thread Daniel Henrique Barboza
On 05/03/2017 01:09 PM, Dr. David Alan Gilbert wrote: * Daniel Henrique Barboza (danie...@linux.vnet.ibm.com) wrote: static void realize(DeviceState *d, Error **errp) { sPAPRDRConnector *drc = SPAPR_DR_CONNECTOR(d); @@ -540,6 +598,8 @@ static void realize(DeviceState *d, Error

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] hw/ppc: removing spapr_drc_detach_cb opaques

2017-05-03 Thread Daniel Henrique Barboza
the spapr_lmb_release callback - looks like the best option we have. Thanks, Daniel On 05/03/2017 10:56 AM, Daniel Henrique Barboza wrote: On 05/03/2017 12:26 AM, Bharata B Rao wrote: On Tue, May 2, 2017 at 1:13 PM, Daniel Henrique Barboza <danie...@linux.vnet.ibm.com <mailto

[Qemu-devel] [PATCH v10] pseries: migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
This patch was detached from the patchset: "[PATCH v9 0/6] migration/ppc: migrating DRC, ccs_list and pending_events" Because it is independent and has use outside of the scope of the pseries DRC migration patchset. Change log: v10: detached from DRC patch set v9: no changes v8: no changes

[Qemu-devel] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
o make sure migration across different versions is not broken. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 33 + hw/ppc/sp

[Qemu-devel] [PATCH v9] migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
This patch was detached from the patchset: "[PATCH v9 0/6] migration/ppc: migrating DRC, ccs_list and pending_events" Because it is independent and has use outside of the scope of the pseries DRC migration patchset. Change log: v9: no changes v8: no changes v7: no changes v6: - Rebased

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9] migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
Please ignore this patch. I've resent it again as "v10" to help differentiate from the v9 version that is still included in the DRC patch set. Daniel On 05/15/2017 10:06 AM, Daniel Henrique Barboza wrote: This patch was detached from the patchset: "[PATCH v9 0/6] migration

[Qemu-devel] [PATCH v9] migration: spapr: migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
o make sure migration across different versions is not broken. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 33 + hw/ppc/sp

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-17 Thread Daniel Henrique Barboza
On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: On 05/16/2017 01:25 AM, David Gibson wrote: On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan <du...@linux.vnet.ibm.com> In racing situations between hotplug events and migration ope

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 3/6] hw/ppc: migrating the DRC state of hotplugged devices

2017-05-16 Thread Daniel Henrique Barboza
On 05/12/2017 03:11 AM, David Gibson wrote: On Fri, May 05, 2017 at 05:47:43PM -0300, Daniel Henrique Barboza wrote: In pseries, a firmware abstraction called Dynamic Reconfiguration Connector (DRC) is used to assign a particular dynamic resource to the guest and provide an interface

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-16 Thread Daniel Henrique Barboza
On 05/16/2017 01:25 AM, David Gibson wrote: On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan <du...@linux.vnet.ibm.com> In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be del

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 0/6] migration/ppc: migrating DRC, ccs_list and pending_events

2017-05-11 Thread Daniel Henrique Barboza
: Hi Daniel, I'd like to test your patch series: is there a way to generate easily the problem your series wants to fix? Thanks, Laurent On 05/05/2017 22:47, Daniel Henrique Barboza wrote: v9: - patch 1 (*new*): added a qtail in sPAPRMachineState called pending_dimm_unplugs that stores the DIMM

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 4/6] hw/ppc/spapr.c: migrate pending_dimm_unplugs of spapr state

2017-05-12 Thread Daniel Henrique Barboza
On 05/12/2017 03:12 AM, David Gibson wrote: On Fri, May 05, 2017 at 05:47:44PM -0300, Daniel Henrique Barboza wrote: To allow for a DIMM unplug event to resume its work if a migration occurs in the middle of it, this patch migrates the non-empty pending_dimm_unplugs QTAILQ that stores

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 6/6] migration: spapr: migrate pending_events of spapr state

2017-05-12 Thread Daniel Henrique Barboza
On 05/12/2017 03:28 AM, David Gibson wrote: On Fri, May 05, 2017 at 05:47:46PM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan <du...@linux.vnet.ibm.com> In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be del

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: manage hotplugged devices while the VM is not started

2017-06-19 Thread Daniel Henrique Barboza
On 06/19/2017 09:40 AM, Marcel Apfelbaum wrote: On 16/06/2017 16:53, Igor Mammedov wrote: On Wed, 14 Jun 2017 19:27:12 -0500 Michael Roth wrote: Quoting Igor Mammedov (2017-06-14 04:00:01) On Tue, 13 Jun 2017 16:42:45 -0500 Michael Roth

[Qemu-devel] [PATCH v14] migration: spapr: migrate pending_events of spapr state

2017-06-20 Thread Daniel Henrique Barboza
Henrique Barboza (1): migration: spapr: migrate pending_events of spapr state hw/ppc/spapr.c | 32 + hw/ppc/spapr_events.c | 98 +++--- include/hw/ppc/spapr.h | 9 +++-- 3 files changed, 101 insertions(+), 38 deletions(-) -- 2.9.4

[Qemu-devel] [PATCH v14] migration: spapr: migrate pending_events of spapr state

2017-06-20 Thread Daniel Henrique Barboza
in the callers of these functions and we don't need to waste resources calling qdev() again. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 + hw/ppc/spapr_events.c

Re: [Qemu-devel] [Qemu-ppc] [RESEND PATCH v10 1/5] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

2017-05-19 Thread Daniel Henrique Barboza
On 05/19/2017 01:26 AM, David Gibson wrote: On Thu, May 18, 2017 at 06:54:12PM -0300, Daniel Henrique Barboza wrote: The LMB DRC release callback, spapr_lmb_release(), uses an opaque parameter, a sPAPRDIMMState struct that stores the current LMBs that are allocated to a DIMM (nr_lmbs). After

[Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

2017-05-22 Thread Daniel Henrique Barboza
e VMSD to make sure migration across different versions is not broken. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 hw/ppc/sp

[Qemu-devel] [PATCH v11 3/5] hw/ppc: migrating the DRC state of hotplugged devices

2017-05-22 Thread Daniel Henrique Barboza
/ppc/spapr_iommu.c does in 'spapr_tce_table_realize'. This approach works because DRCs are bus-less and do not sit on a BusClass that implements bc->get_dev_path, so as a fallback the VMSD gets identified via "spapr_drc"/get_index(drc). Signed-off-by: Daniel Henrique B

[Qemu-devel] [PATCH v11 5/5] migration: spapr: migrate ccs_list in spapr state

2017-05-22 Thread Daniel Henrique Barboza
broken. * see http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg01763.html for more information on this discussion. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 +

[Qemu-devel] [PATCH v11 1/5] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

2017-05-22 Thread Daniel Henrique Barboza
an now be safely removed from the code. As an additional cleanup made by this patch, the spapr_del_lmbs function was merged with spapr_memory_unplug_request. The former was being called only by the latter and both were small enough to fit one single function. Signed-off-by: Daniel Henrique Barboza

[Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

2017-05-22 Thread Daniel Henrique Barboza
v13: - rebased with dgibson/ppc-for-2.10 - patch 1 removed from the series (already applied at ppc-for-2.10) - data_size is now being calculated by using the extended_length field inside rtas_event_log_queue v12: - patch 2: added a switch statement to get the proper data_size based on the

[Qemu-devel] [PATCH v11 0/5] migration/ppc: migrating DRC and ccs_list

2017-05-22 Thread Daniel Henrique Barboza
patch defines the VMStateDescription struct for spapr drc state to enable it. To fix the potential racing between hotplug events on guest and guest migration and ccs_list of spapr state need be transmitted in migration. This patch set also takes care of it. Daniel Henrique Barboza (4):

[Qemu-devel] [PATCH v11 2/5] hw/ppc: removing drc->detach_cb and drc->detach_cb_opaque

2017-05-22 Thread Daniel Henrique Barboza
() now uses a switch(drc->type) to execute the apropriate callback. To achieve this, spapr_core_release, spapr_lmb_release and spapr_phb_remove_pci_device_cb callbacks were made public to be visible inside detach(). Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> ---

[Qemu-devel] [PATCH v11 4/5] hw/ppc/spapr.c: recover pending LMB unplug info in spapr_lmb_release

2017-05-22 Thread Daniel Henrique Barboza
new recover function spapr_recover_pending_dimm_state that is used inside spapr_lmb_release to recover this DRC LMB release status that is lost during the migration. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spa

Re: [Qemu-devel] [Qemu-ppc] [PATCH v13] migration: spapr: migrate pending_events of spapr state

2017-05-23 Thread Daniel Henrique Barboza
On 05/23/2017 01:07 AM, David Gibson wrote: On Mon, May 22, 2017 at 03:40:39PM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan <du...@linux.vnet.ibm.com> In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be del

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] spapr: disable hotplugging without OS

2017-05-23 Thread Daniel Henrique Barboza
Hi Laurent, This is an interesting patch series. I've been working in the last weeks in the DRC migration, mainly to solve the problem in which a hot CPU unplug will not succeed after a migration if the CPU was hotplugged in the source. The problem happened when migrating with virsh because

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] spapr: disable hotplugging without OS

2017-05-23 Thread Daniel Henrique Barboza
On 05/23/2017 03:07 PM, Daniel Henrique Barboza wrote: On 05/23/2017 02:52 PM, Daniel Henrique Barboza wrote: Hi Laurent, This is an interesting patch series. I've been working in the last weeks in the DRC migration, mainly to solve the problem in which a hot CPU unplug will not succeed

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] spapr: disable hotplugging without OS

2017-05-23 Thread Daniel Henrique Barboza
On 05/23/2017 02:52 PM, Daniel Henrique Barboza wrote: Hi Laurent, This is an interesting patch series. I've been working in the last weeks in the DRC migration, mainly to solve the problem in which a hot CPU unplug will not succeed after a migration if the CPU was hotplugged in the source

[Qemu-devel] [PATCH v12 2/2] migration: spapr: migrate pending_events of spapr state

2017-05-19 Thread Daniel Henrique Barboza
e VMSD to make sure migration across different versions is not broken. Signed-off-by: Jianjun Duan <du...@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 32 hw/ppc/sp

[Qemu-devel] [PATCH v12 0/2] pseries: migrate pending_events of spapr state

2017-05-19 Thread Daniel Henrique Barboza
g DRC, ccs_list and pending_events" Because it is independent and has use outside of the scope of the pseries DRC migration patchset. Daniel Henrique Barboza (1): hw/ppc/spapr_events.c: removing 'exception' from sPAPREventLogEntry Jianjun Duan (1): migration: spapr: migrate pending_events of s

[Qemu-devel] [PATCH v12 1/2] hw/ppc/spapr_events.c: removing 'exception' from sPAPREventLogEntry

2017-05-19 Thread Daniel Henrique Barboza
events that should be reported with the event_scan interface, we can refer to the changes made in this patch to add the event_scan logic back. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr_events.c | 52 +++--- i

Re: [Qemu-devel] [Qemu-ppc] [PATCH v11 2/2] migration: spapr: migrate pending_events of spapr state

2017-05-19 Thread Daniel Henrique Barboza
On 05/18/2017 11:32 PM, David Gibson wrote: On Thu, May 18, 2017 at 05:24:02PM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan <du...@linux.vnet.ibm.com> In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be del

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-18 Thread Daniel Henrique Barboza
On 05/18/2017 01:46 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-05-17 15:31:44) On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: On 05/16/2017 01:25 AM, David Gibson wrote: On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan

[Qemu-devel] [PATCH v11 1/2] hw/ppc/spapr_events.c: removing 'exception' from sPAPREventLogEntry

2017-05-18 Thread Daniel Henrique Barboza
events that should be reported with the event_scan interface, we can refer to the changes made in this patch to add the event_scan logic back. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr_events.c | 52 +++--- i

[Qemu-devel] [PATCH v11 0/2] pseries: migrate pending_events of spapr state

2017-05-18 Thread Daniel Henrique Barboza
n/ppc: migrating DRC, ccs_list and pending_events" Because it is independent and has use outside of the scope of the pseries DRC migration patchset. Daniel Henrique Barboza (1): hw/ppc/spapr_events.c: removing 'exception' from sPAPREventLogEntry Jianjun Duan (1): migration: spap

[Qemu-devel] [PATCH v10 4/5] hw/ppc/spapr.c: recover pending LMB unplug info in spapr_lmb_release

2017-05-18 Thread Daniel Henrique Barboza
new recover function spapr_recover_pending_dimm_state that is used inside spapr_lmb_release to recover this DRC LMB release status that is lost during the migration. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 39 ++

[Qemu-devel] [PATCH v10 2/5] hw/ppc: removing drc->detach_cb and drc->detach_cb_opaque

2017-05-18 Thread Daniel Henrique Barboza
() now uses a switch(drc->type) to execute the apropriate callback. To achieve this, spapr_core_release, spapr_lmb_release and spapr_phb_remove_pci_device_cb callbacks were made public to be visible inside detach(). Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> ---

[Qemu-devel] [RESEND PATCH v10 1/5] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

2017-05-18 Thread Daniel Henrique Barboza
an now be safely removed from the code. Signed-off-by: Daniel Henrique Barboza <danie...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 57 +- include/hw/ppc/spapr.h | 4 2 files changed, 56 insertions(+), 5 deletions(-) diff --git a/hw

  1   2   3   4   5   6   7   8   9   10   >