Re: [PATCH v3 22/49] i386/sev: Introduce 'sev-snp-guest' object

On Wed, Mar 20, 2024 at 03:39:18AM -0500, Michael Roth wrote: > From: Brijesh Singh > > SEV-SNP support relies on a different set of properties/state than the > existing 'sev-guest' object. This patch introduces the 'sev-snp-guest' > object, which can be used to configure an SEV-SNP guest. For

Re: [PATCH v3 21/49] i386/sev: Introduce "sev-common" type to encapsulate common SEV state

On Wed, Mar 20, 2024 at 03:39:17AM -0500, Michael Roth wrote: > Currently all SEV/SEV-ES functionality is managed through a single > 'sev-guest' QOM type. With upcoming support for SEV-SNP, taking this > same approach won't work well since some of the properties/state > managed by 'sev-guest' is

Re: [PATCH v3 21/49] i386/sev: Introduce "sev-common" type to encapsulate common SEV state

On Wed, Mar 20, 2024 at 03:39:17AM -0500, Michael Roth wrote: > Currently all SEV/SEV-ES functionality is managed through a single > 'sev-guest' QOM type. With upcoming support for SEV-SNP, taking this > same approach won't work well since some of the properties/state > managed by 'sev-guest' is

Re: [PATCH] Implement SSH commands in QEMU GA for Windows

On Tue, Mar 19, 2024 at 06:17:24PM +, aidan_le...@selinc.com wrote: > From: aidaleuc > > Signed-off-by: aidaleuc > --- > qga/commands-posix-ssh.c | 47 +-- > qga/commands-ssh-core.c| 52 +++ > qga/commands-ssh-core.h| 20 ++ > qga/commands-windows-ssh.c | 686

Re: [PATCH v5 7/7] tests/migration-test: add qpl compression test

On Wed, Mar 20, 2024 at 12:45:27AM +0800, Yuan Liu wrote: > add qpl to compression method test for multifd migration > > the migration with qpl compression needs to access IAA hardware > resource, please run "check-qtest" with sudo or root permission, > otherwise migration test will fail That's

Re: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

On Wed, Mar 20, 2024 at 12:45:25AM +0800, Yuan Liu wrote: > the qpl initialization includes memory allocation for compressed > data and the qpl job initialization. > > the qpl initialization will check whether the In-Memory Analytics > Accelerator(IAA) hardware is available, if the platform does

Re: [PATCH v5 3/7] configure: add --enable-qpl build option

On Wed, Mar 20, 2024 at 12:45:23AM +0800, Yuan Liu wrote: > add --enable-qpl and --disable-qpl options to enable and disable > the QPL compression method for multifd migration. > > the Query Processing Library (QPL) is an open-source library > that supports data compression and decompression

[PULL 6/8] crypto: query gcrypt for cipher availability

are available at runtime. qcrypto_cipher_supports must therefore query gcrypt directly to check for cipher availability. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- crypto/cipher-gcrypt.c.inc | 5 + 1 file changed, 5 insertions(+) diff --git

[PULL 8/8] crypto: report which ciphers are being skipped during tests

Since the ciphers can be dynamically disabled at runtime, when running unit tests it is helpful to report which ciphers we can skipped for testing. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-cipher.c | 4 1

[PULL 2/8] chardev: lower priority of the HUP GSource in socket chardev

nter-intuitively, lowering the priority of a GSource is done by raising its priority number. Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 16 1 file changed, 16 insertions(+) diff --git a/chardev/char-sock

[PULL 4/8] Revert "chardev: use a child source for qio input source"

child GSource to notify if we still have more data available to be read. Signed-off-by: Antoine Damhet Signed-off-by: Charles Frey Signed-off-by: Daniel P. Berrangé With this, it is now quite common for the 'prepare' function on a QIOChannelTLS GSource to indicate immediate

[PULL 7/8] crypto: use error_abort for unexpected failures

-by: Daniel P. Berrangé --- tests/unit/test-crypto-cipher.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/unit/test-crypto-cipher.c b/tests/unit/test-crypto-cipher.c index 11ab1a54fc..d0ea7b4d8e 100644 --- a/tests/unit/test-crypto-cipher.c +++ b/tests/unit/test-crypto

[PULL 1/8] seccomp: report EPERM instead of killing process for spawn set

/qemu-project/qemu/-/issues/2116 Signed-off-by: Daniel P. Berrangé --- system/qemu-seccomp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/system/qemu-seccomp.c b/system/qemu-seccomp.c index 4d7439e7f7..98ffce075c 100644 --- a/system/qemu-seccomp.c +++ b/system

[PULL 3/8] Revert "chardev/char-socket: Fix TLS io channels sending too much data to the backend"

solution is to avoid tcp_chr_read being called at all unless the frontend is able to accept more data. This will be done in a followup commit. This reverts commit 462945cd22d2bcd233401ed3aa167d83a8e35b05 Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 6

[PULL 0/8] Misc fixes patches

Daniel P. Berrangé (8): seccomp: report EPERM instead of killing process for spawn set chardev: lower priority of the HUP GSource in socket chardev Revert "chardev/char-socket: Fix TLS io channels sending too much data to the ba

[PULL 5/8] crypto: factor out conversion of QAPI to gcrypt constants

The conversion of cipher mode will shortly be required in more than one place. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- crypto/cipher-gcrypt.c.inc | 116 +++-- 1 file changed, 60 insertions(+), 56

Re: [PATCH] coroutine: cap per-thread local pool size

On Tue, Mar 19, 2024 at 06:41:28PM +0100, Kevin Wolf wrote: > Am 19.03.2024 um 18:10 hat Daniel P. Berrangé geschrieben: > > On Tue, Mar 19, 2024 at 05:54:38PM +0100, Kevin Wolf wrote: > > > Am 19.03.2024 um 14:43 hat Daniel P. Berrangé geschrieben: > > > > On Mon, Ma

Re: [PATCH] coroutine: cap per-thread local pool size

On Tue, Mar 19, 2024 at 01:55:10PM -0400, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2024 at 01:43:32PM +0000, Daniel P. Berrangé wrote: > > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > > diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c >

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

On Tue, Mar 19, 2024 at 03:25:18PM -0400, Peter Xu wrote: > On Tue, Mar 19, 2024 at 04:25:32PM +0000, Daniel P. Berrangé wrote: > > On Fri, Mar 15, 2024 at 04:54:27PM -0400, Peter Xu wrote: > > > On Fri, Mar 15, 2024 at 03:01:09PM -0300, Fabiano Rosas wrote: > &

Re: [PATCH v7] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

On Tue, Mar 19, 2024 at 06:58:33PM +0100, Eric Auger wrote: > Hi Daniel, > > On 3/19/24 16:22, Daniel P. Berrangé wrote: > > On Wed, Feb 21, 2024 at 01:34:31AM -0500, Shaoqin Huang wrote: > >> The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM deci

Re: [PATCH v3 6/7] qga/commands-posix: don't do fork()/exec() when suspending via sysfs

t really need to do that in > a separate process as we only need to perform one write to /sys/power/state. > > Let's just use g_file_set_contents() to simplify things here. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Andrey Drobyshev > --- > qga/commands-posix.c | 41 +---

Re: [PATCH v3 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper

t; --- > qga/commands-posix.c | 96 ++-- > 1 file changed, 13 insertions(+), 83 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [PATCH v3 5/7] qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper

> 1 file changed, 3 insertions(+), 32 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://ent

Re: [PATCH v3 3/7] qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper

t; 1 file changed, 6 insertions(+), 33 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

Re: [PATCH v3 4/7] qga/commands-posix: qmp_guest_set_time: use ga_run_command helper

-- > 1 file changed, 3 insertions(+), 40 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: h

Re: [PATCH v3 2/7] qga: introduce ga_run_command() helper for guest cmd execution

; Signed-off-by: Andrey Drobyshev > --- > qga/commands-posix.c | 150 +++ > 1 file changed, 150 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dber

Re: [PATCH v3 1/7] qga: guest-get-fsinfo: add optional 'total-bytes-root' field

On Fri, Mar 15, 2024 at 02:29:40PM +0200, Andrey Drobyshev wrote: > Since the commit 25b5ff1a86 ("qga: add mountpoint usage info to > GuestFilesystemInfo") we have 2 values reported in guest-get-fsinfo: > used = (f_blocks - f_bfree), total = (f_blocks - f_bfree + f_bavail) as > returned by

Re: [PATCH] coroutine: cap per-thread local pool size

On Tue, Mar 19, 2024 at 05:54:38PM +0100, Kevin Wolf wrote: > Am 19.03.2024 um 14:43 hat Daniel P. Berrangé geschrieben: > > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > > The coroutine pool implementation can hit the Linux vm.max_map_count > &g

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

On Fri, Mar 15, 2024 at 09:13:52AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Mar 15, 2024 at 12:20:40AM -0300, Fabiano Rosas wrote: > >> The fd: URI has supported migration to a file or socket since before > >> QEMU 8.2. In 8.2 we adde

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

> > On Fri, Mar 15, 2024 at 08:55:42AM +, Daniel P. Berrangé wrote: > > >> The 'file:' protocol eventually calls into qemu_open, and this > > >> transparently allows for FD passing using /dev/fdset/NNN syntax > > >> to pass in FDs.

Re: [PATCH 00/29] include: move include/qapi/qmp/ to include/qobject/

Ping I don't want to spend time rebasing without opinions on whether this is a desirable kind of cleanup to make. (obviously this is /not/ for 9.0) On Mon, Jan 08, 2024 at 06:23:36PM +, Daniel P. Berrangé wrote: > To repeat the 1st patch commit message... > > The general ex

[PATCH for-9.0] qapi: drop unused QCryptoBlockCreateOptionsLUKS.detached-header

The 'detached-header' field in QCryptoBlockCreateOptionsLUKS was left over from earlier patch iterations. Signed-off-by: Daniel P. Berrangé --- qapi/crypto.json | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/qapi/crypto.json b/qapi/crypto.json index 931c88e688

Re: [PATCH v7] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

On Wed, Feb 21, 2024 at 01:34:31AM -0500, Shaoqin Huang wrote: > diff --git a/docs/system/arm/cpu-features.rst > b/docs/system/arm/cpu-features.rst > index a5fb929243..7c8f6a60ef 100644 > --- a/docs/system/arm/cpu-features.rst > +++ b/docs/system/arm/cpu-features.rst > @@ -204,6 +204,29 @@ the

Re: [PATCH v7] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

On Tue, Mar 19, 2024 at 03:00:40PM +, Peter Maydell wrote: > On Tue, 19 Mar 2024 at 14:57, Eric Auger wrote: > > > > Hi Peter, > > > > On 2/29/24 12:00, Peter Maydell wrote: > > > > > > It doesn't appear because the list of properties that we advertise > > > via query-cpu-model-expansion is

Re: [PATCH v7] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

On Wed, Feb 21, 2024 at 01:34:31AM -0500, Shaoqin Huang wrote: > The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide > which PMU events are provided to the guest. Add a new option > `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering. > Without the filter, all

Re: [PULL 1/1] coroutine: cap per-thread local pool size

Sending this PULL feels little rushed, as I still have un-answered questions on the inital patch posting just a few hours ago On Tue, Mar 19, 2024 at 11:09:38AM -0400, Stefan Hajnoczi wrote: > The coroutine pool implementation can hit the Linux vm.max_map_count > limit, causing QEMU to abort

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 03:29:14PM +0100, Paolo Bonzini wrote: > On Tue, Mar 19, 2024 at 3:27 PM Daniel P. Berrangé > wrote: > > > > On Tue, Mar 19, 2024 at 03:25:53PM +0100, Paolo Bonzini wrote: > > > On Tue, Mar 19, 2024 at 3:15 PM Daniel P. Berrangé

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 03:25:53PM +0100, Paolo Bonzini wrote: > On Tue, Mar 19, 2024 at 3:15 PM Daniel P. Berrangé > wrote: > > > +int kvm_get_vm_type(MachineState *ms, const char *vm_type) > > > > The 'vm_type' parameter is never used here. What value is it expec

Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

On Tue, Mar 19, 2024 at 02:59:59PM +0100, Paolo Bonzini wrote: > From: Xiaoyao Li > > KVM is introducing a new API to create confidential guests, which > will be used by TDX and SEV-SNP but is also available for SEV and > SEV-ES. The API uses the VM type argument to KVM_CREATE_VM to > identify

Re: [PATCH 2/7] runstate: skip initial CPU reset if reset is not actually possible

On Tue, Mar 19, 2024 at 02:59:55PM +0100, Paolo Bonzini wrote: > Right now, the system reset is concluded by a call to > cpu_synchronize_all_post_reset() in order to sync any changes > that the machine reset callback applied to the CPU state. > > However, for VMs with encrypted state such as

Re: [PATCH] coroutine: cap per-thread local pool size

On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > The coroutine pool implementation can hit the Linux vm.max_map_count > limit, causing QEMU to abort with "failed to allocate memory for stack" > or "failed to set up stack guard page" during coroutine creation. > > This happens

Re: [PATCH 2/3 for 9.0] Revert "chardev/char-socket: Fix TLS io channels sending too much data to the backend"

On Mon, Mar 18, 2024 at 11:09:23PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Mar 18, 2024 at 10:23 PM Daniel P. Berrangé > wrote: > > > > This commit results in unexpected termination of the TLS connection. > > When 'fd_can_read' returns 0, the code

Re: [PATCH] build: Re-introduce an 'info' target to build a Texinfo manual.

On Tue, Mar 19, 2024 at 11:47:59AM +, Peter Maydell wrote: > On Mon, 18 Mar 2024 at 03:05, Maxim Cournoyer > wrote: > > > > This reinstates > > , > > which was committed at some point but reverted many years later in > >

Re: [PATCH 3/3 for 9.0] Revert "chardev: use a child source for qio input source"

On Tue, Mar 19, 2024 at 12:20:18AM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Mar 18, 2024 at 10:25 PM Daniel P. Berrangé > wrote: > > > > This reverts commit a7077b8e354d90fec26c2921aa2dea85b90dff90, > > and add comments to explain why child sources cannot b

[PATCH 3/3 for 9.0] Revert "chardev: use a child source for qio input source"

child GSource to notify if we still have more data available to be read. Signed-off-by: Antoine Damhet Signed-off-by: Charles Frey Signed-off-by: Daniel P. Berrangé With this, it is now quite common for the 'prepare' function on a QIOChannelTLS GSource to indicate immediate

[PATCH 1/3 for 9.0] chardev: lower priority of the HUP GSource in socket chardev

nter-intuitively, lowering the priority of a GSource is done by raising its priority number. Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 16 1 file changed, 16 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 8a0406cc1e..2c4dff

[PATCH 0/3 for 9.0] Fix TLS support for chardevs and incoming data loss on EOF

discarded when POLLHUP is reported at the same time. This required patch 1 to be applied before doing the revert in patch 3, otherwise test-char would now very frequently fail. So we get 2 bug fixes for the price of one :-) Daniel P. Berrangé (3): chardev: lower priority of the HUP GSource

[PATCH 2/3 for 9.0] Revert "chardev/char-socket: Fix TLS io channels sending too much data to the backend"

solution is to avoid tcp_chr_read being called at all unless the frontend is able to accept more data. This will be done in a followup commit. This reverts commit 1907f4d149c3589ade641423c6a33fd7598fa4d3. Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 6 +++--- 1 file changed, 3

Re: [PATCH 9/9] docs/system: Add documentation on support for IGVM

On Mon, Mar 18, 2024 at 03:59:31PM +, Roy Hopkins wrote: > On Fri, 2024-03-01 at 17:10 +0000, Daniel P. Berrangé wrote: > > On Tue, Feb 27, 2024 at 02:50:15PM +, Roy Hopkins wrote: > > > IGVM support has been implemented for Confidential Guests that support > >

Re: [PATCH v3] block: Use LVM tools for LV block device truncation

ze it executing lvresize. > > Signed-off-by: Alexander Ivanov > --- > block/file-posix.c | 61 ++ > 1 file changed, 61 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/block/file-posix.c b/block/file-posix.c &

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

On Fri, Mar 15, 2024 at 12:20:40AM -0300, Fabiano Rosas wrote: > The fd: URI has supported migration to a file or socket since before > QEMU 8.2. In 8.2 we added the file: URI that supported migration to a > file. So now we have two ways (three if you count exec:>cat) to > migrate to a file. Fine.

Re: [PATCH v2] block: Use LVM tools for LV block device truncation

On Thu, Mar 14, 2024 at 06:25:00PM +0100, Alexander Ivanov wrote: > > > On 3/14/24 13:44, Daniel P. Berrangé wrote: > > On Wed, Mar 13, 2024 at 11:43:27AM +0100, Alexander Ivanov wrote: > > > If a block device is an LVM logical volume we can resize it using

Re: [PATCH v2] block: Use LVM tools for LV block device truncation

On Wed, Mar 13, 2024 at 11:43:27AM +0100, Alexander Ivanov wrote: > If a block device is an LVM logical volume we can resize it using > standard LVM tools. > > Add a helper to detect if a device is a DM device. In raw_co_truncate() > check if the block device is DM and resize it executing

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

On Thu, Mar 14, 2024 at 09:26:53AM +0100, Anthony Harivel wrote: > > Hi Daniel, > > > > You don't need to access it via the /node/ hierarchy > > > > The canonical path for CPUs would be > > > > /sys/devices/system/cpu/cpuNNN/topology > > > > The core_cpus_list file is giving you hyper-thread

Re: [PATCH v5 49/65] i386/tdx: handle TDG.VP.VMCALL

On Tue, Mar 12, 2024 at 03:44:32PM +0800, Xiaoyao Li wrote: > On 3/11/2024 5:27 PM, Daniel P. Berrangé wrote: > > On Thu, Feb 29, 2024 at 01:37:10AM -0500, Xiaoyao Li wrote: > > > From: Isaku Yamahata > > > > > > Add property "quote-generation-

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

On Wed, Mar 13, 2024 at 11:48:19AM +0100, Anthony Harivel wrote: > Hi Daniel, > > Daniel P. Berrangé, Mar 12, 2024 at 16:49: > > > The point still stands though. NUMA node ID numbers are not > > guaranteed to be the same as socket ID numbers. Very often > > then

Re: [PATCH] block: Use LVM tools for LV block device truncation

On Tue, Mar 12, 2024 at 06:04:26PM +0100, Alexander Ivanov wrote: > Thank you for the review. > > On 3/11/24 19:24, Daniel P. Berrangé wrote: > > On Mon, Mar 11, 2024 at 06:40:44PM +0100, Alexander Ivanov wrote: > > > If a block device is an LVM logical volum

Re: [PATCH 7/9] i386/sev: Refactor setting of reset vector and initial CPU state

On Tue, Mar 12, 2024 at 03:45:20PM +, Roy Hopkins wrote: > On Fri, 2024-03-01 at 17:01 +0000, Daniel P. Berrangé wrote: > > On Tue, Feb 27, 2024 at 02:50:13PM +, Roy Hopkins wrote: > > > +    /* > > > + * Ideally we would provide the

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

On Tue, Mar 12, 2024 at 12:21:14PM +0100, Anthony Harivel wrote: > Daniel P. Berrangé, Jan 30, 2024 at 10:39: > > > +rcu_register_thread(); > > > + > > > +/* Get QEMU PID*/ > > > +pid = getpid(); > > > + > > > +/* Nb of CPU

Re: [PATCH 2/2] migration: Fix error handling after dup in file migration

On Tue, Mar 12, 2024 at 08:22:18AM -0400, Peter Xu wrote: > On Tue, Mar 12, 2024 at 09:57:58AM +0000, Daniel P. Berrangé wrote: > > On Mon, Mar 11, 2024 at 08:33:35PM -0300, Fabiano Rosas wrote: > > > The file migration code was allowing a possible -1 from a failed call > >

Re: [PATCH 0/2] trace: fix ability to use systemtap with qemu tools

Ping again for these patches to get into this release. On Fri, Feb 16, 2024 at 01:09:33PM +, Daniel P. Berrangé wrote: > Ping: Stefan, are you OK with picking up these trace patches > for merge ? > > On Mon, Jan 08, 2024 at 05:13:54PM +0000, Daniel P. Berrangé wrote: > > Cu

Re: [PATCH] tests: Raise timeouts for bufferiszero and crypto-tlscredsx509

of them create a huge number of certs for testing many scenarios. Either way, Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH 2/2] migration: Fix error handling after dup in file migration

; > > -fioc = qio_channel_file_new_fd(dup(fioc->fd)); > +fioc = qio_channel_file_new_dupfd(fioc->fd, errp); > > - if (!fioc || fioc->fd == -1) { > -error_setg(errp, "Error creating migration incoming channel"); > +if (!

Re: [PATCH 1/2] io: Introduce qio_channel_file_new_dupfd

On Mon, Mar 11, 2024 at 08:33:34PM -0300, Fabiano Rosas wrote: > Add a new helper function for creating a QIOChannelFile channel with a > duplicated file descriptor. This saves the calling code from having to > do error checking on the dup() call. > > Suggested-by: Daniel P. Ber

Re: [PATCH v2] spapr: Tag pseries-2.1 - 2.11 machines as deprecated

On Mon, Mar 11, 2024 at 06:46:53PM +0100, Philippe Mathieu-Daudé wrote: > Hi, > > On 14/12/23 19:17, Cédric Le Goater wrote: > > pseries machines before version 2.11 have undergone many changes to > > correct issues, mostly regarding migration compatibility. This is > > obfuscating the code

Re: [PATCH] block: Use LVM tools for LV block device truncation

On Mon, Mar 11, 2024 at 06:40:44PM +0100, Alexander Ivanov wrote: > If a block device is an LVM logical volume we can resize it using > standard LVM tools. > > In raw_co_truncate() check if the block device is a LV using lvdisplay > and resize it executing lvresize. > > Signed-off-by: Alexander

Re: [PATCH] meson.build: Always require an objc compiler on macos hosts

to simply require ObjC on macos. Yeah, I think simplicity wins here, unless someone can provide a compelling reason why they absolutely must be able to build without objc being present, even if it were unused. > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by

[PATCH 4/4] crypto: report which ciphers are being skipped during tests

Since the ciphers can be dynamically disabled at runtime, when running unit tests it is helpful to report which ciphers we can skipped for testing. Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-cipher.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/unit/test

[PATCH 2/4] crypto: query gcrypt for cipher availability

are available at runtime. qcrypto_cipher_supports must therefore query gcrypt directly to check for cipher availability. Signed-off-by: Daniel P. Berrangé --- crypto/cipher-gcrypt.c.inc | 5 + 1 file changed, 5 insertions(+) diff --git a/crypto/cipher-gcrypt.c.inc b/crypto/cipher-gcrypt.c.inc index

[PATCH 0/4] crypto: handle gcrypt ciphers being disabled

This fixes testing on RHEL with libgcrypt cipher backends Daniel P. Berrangé (4): crypto: factor out conversion of QAPI to gcrypt constants crypto: query gcrypt for cipher availability crypto: use error_abort for unexpected failures crypto: report which ciphers are being skipped during

[PATCH 1/4] crypto: factor out conversion of QAPI to gcrypt constants

The conversion of cipher mode will shortly be required in more than one place. Signed-off-by: Daniel P. Berrangé --- crypto/cipher-gcrypt.c.inc | 116 +++-- 1 file changed, 60 insertions(+), 56 deletions(-) diff --git a/crypto/cipher-gcrypt.c.inc b/crypto/cipher

[PATCH 3/4] crypto: use error_abort for unexpected failures

) Aborted (core dumped) to Unexpected error in qcrypto_cipher_ctx_new() at ../crypto/cipher-gcrypt.c.inc:262: ./build//tests/unit/test-crypto-cipher: Cannot initialize cipher: Invalid cipher algorithm Aborted (core dumped) Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-cipher.c | 3

Re: [PULL 25/27] migration/multifd: Add mapped-ram support to fd: URI

On Mon, Mar 04, 2024 at 09:26:32AM +0800, pet...@redhat.com wrote: > From: Fabiano Rosas > > If we receive a file descriptor that points to a regular file, there's > nothing stopping us from doing multifd migration with mapped-ram to > that file. > > Enable the fd: URI to work with multifd +

Re: [PATCH v3 0/5] Generate x86 cpu features

On Mon, Mar 11, 2024 at 12:32:03PM +0100, Tim Wiederhake wrote: > On Tue, 2024-03-05 at 14:17 +0000, Daniel P. Berrangé wrote: > > > Looking at this fresh, I'm left wondering why I didn't suggested > > > using 'QMP' to expose this information when reviewing the earlier >

Re: [PATCH v6] crypto: Introduce SM4 symmetric cipher algorithm

On Mon, Mar 11, 2024 at 09:32:32AM +, Daniel P. Berrangé wrote: > On Fri, Mar 08, 2024 at 09:30:52PM +0100, Thomas Huth wrote: > > On 07/12/2023 16.47, Hyman Huang wrote: > > > Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). > > > > > > SM4

Re: [PATCH v6] crypto: Introduce SM4 symmetric cipher algorithm

On Fri, Mar 08, 2024 at 09:30:52PM +0100, Thomas Huth wrote: > On 07/12/2023 16.47, Hyman Huang wrote: > > Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). > > > > SM4 (GBT.32907-2016) is a cryptographic standard issued by the > > Organization of State Commercial Administration of

Re: [PATCH v5 49/65] i386/tdx: handle TDG.VP.VMCALL

On Thu, Feb 29, 2024 at 01:37:10AM -0500, Xiaoyao Li wrote: > From: Isaku Yamahata > > Add property "quote-generation-socket" to tdx-guest, which is a property > of type SocketAddress to specify Quote Generation Service(QGS). > > On request of GetQuote, it connects to the QGS socket, read

Re: [PATCH 3/4] docs/interop/firmware.json: Use full include paths

On Fri, Mar 08, 2024 at 04:19:42PM +0100, Markus Armbruster wrote: > The coupling with the main QAPI schema is unfortunate. > > The purpose of docs/interop/firmware.json is to serve as schema for > firmware descriptions: a firmware description is a JSON object that > conforms to this schema's

Re: [PATCH v2 2/2] gitlab-ci: add manual job to run Coverity

> .gitlab-ci.d/opensbi.yml | 4 > 3 files changed, 45 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

On Thu, Mar 07, 2024 at 07:38:27PM -0800, Justinien Bouron wrote: > > This last two lines doesn't make sense to me. Isn't the grab > > toggling entirely in control of the QEMU process, regardless > > of what state the guest is at ? > > Actually, you're right, they do not make sense. This issue of

Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

On Thu, Mar 07, 2024 at 05:53:24PM +, Kim, Dongwon wrote: > Hi Daniel, > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Thursday, March 7, 2024 1:46 AM > > To: Kim, Dongwon > > Cc: Marc-André Lureau ; qemu- > > de...@nong

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

On Wed, Mar 06, 2024 at 10:28:22PM -0800, Justinien Bouron wrote: > Depending on your use-case, it might be inconvenient to have qemu grab > the input device immediately upon starting the guest, especially if the > guest takes a while to start in which case it may take a few seconds > before being

Re: [PATCH 0/3] ui/gtk: introducing vc->visible

On Tue, Mar 05, 2024 at 04:18:18PM +0400, Marc-André Lureau wrote: > Hi Kim > > I am uncomfortable with the series in general. > > Not only we don't have the means to draw dmabuf/scanout "when > required", so resuming drawing won't work until the guest draws (this > is already a problem but you

Re: [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible

On Wed, Jan 31, 2024 at 11:12:57AM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Jan 31, 2024 at 3:50 AM wrote: > > > > From: Dongwon Kim > > > > UI size is set to 0 when the VC is invisible, which will prevent > > the further scanout update by notifying the guest that the display > > is not

Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

On Thu, Feb 01, 2024 at 06:48:58PM +, Kim, Dongwon wrote: > Hi Marc-André, > > Thanks for your feedback. Yes, you are right, rendering doesn't stop on > Ubuntu system > as it has preview even after the window is minimized. But this is not always > the case. > Some simple windows managers

Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

On Tue, Jan 30, 2024 at 03:48:38PM -0800, dongwon@intel.com wrote: > From: Dongwon Kim > > A new flag "visible" is added to show visibility status of the gfx console. > The flag is set to 'true' when the VC is visible but set to 'false' when > it is hidden or closed. When the VC is

Re: Does "-object" support structured options now?

On Wed, Mar 06, 2024 at 02:36:08PM +, Daniel P. Berrangé wrote: > On Wed, Mar 06, 2024 at 02:33:05PM +, Chun Feng Wu wrote: > > Thanks Daniel for your response! > > > > I tried it with the following cmd > > > > qemu-system-x86_64 [other options...]

Re: Does "-object" support structured options now?

On Wed, Mar 06, 2024 at 02:33:05PM +, Chun Feng Wu wrote: > Thanks Daniel for your response! > > I tried it with the following cmd > > qemu-system-x86_64 [other options...] \ > -object > '{"qom-type":"throttle-group","id":"limits0","limits":{"iops-total":200}}' > > And I got error: >

Re: [PATCH] migration/multifd: Don't fsync when closing QIOChannelFile

On Wed, Mar 06, 2024 at 08:52:41AM +0800, Peter Xu wrote: > On Tue, Mar 05, 2024 at 05:49:33PM +0000, Daniel P. Berrangé wrote: > > I don't think you should be removing this. Calling qio_channel_close() > > remains recommended best practice, even with fdatasync() removed, as

Re: [PATCH v2 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper

On Fri, Mar 01, 2024 at 07:28:58PM +0200, Andrey Drobyshev wrote: > There's no need to check for the existence of the "chpasswd", "pw" > executables, as the exec() call will do that for us. > > Signed-off-by: Andrey Drobyshev > --- > qga/commands-posix.c | 96

Re: [PATCH v2 6/7] qga/commands-posix: use ga_run_command helper when suspending via sysfs

On Fri, Mar 01, 2024 at 07:28:57PM +0200, Andrey Drobyshev wrote: > We replace the direct call to open() with a "sh -c 'echo ...'" call, so > that it becomes an executable command. Introduced an indirection via the shell is a significant step backwards IMHO. > > Signed-off-by: Andrey Drobyshev

Re: [PATCH v2 2/7] qga: introduce ga_run_command() helper for guest cmd execution

On Fri, Mar 01, 2024 at 07:28:53PM +0200, Andrey Drobyshev wrote: > When executing guest commands in *nix environment, we repeat the same > fork/exec pattern multiple times. Let's just separate it into a single > helper which would also be able to feed input data into the launched > process'

Re: [PATCH] migration/multifd: Don't fsync when closing QIOChannelFile

evice"); > -return -1; > -} > if (qemu_close(fioc->fd) < 0) { > error_setg_errno(errp, errno, > "Unable to close file"); Upto here: Reviewed-by: Daniel P. Berrangé > diff --git a/migration/multifd.c

Re: [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents

On Tue, Mar 05, 2024 at 09:09:05AM -0800, fan wrote: > On Tue, Mar 05, 2024 at 04:15:30PM +0000, Daniel P. Berrangé wrote: > > On Tue, Mar 05, 2024 at 04:09:08PM +, Jonathan Cameron via wrote: > > > On Mon, 4 Mar 2024 11:34:08 -0800 > > > nifan@gmail.com wrote:

Re: [PATCH v5 13/13] qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC extents

On Tue, Mar 05, 2024 at 04:09:08PM +, Jonathan Cameron via wrote: > On Mon, 4 Mar 2024 11:34:08 -0800 > nifan@gmail.com wrote: > > > From: Fan Ni > > > > With the change, we add the following two QMP interfaces to print out > > extents information in the device, > > 1.

Re: [PATCH v3 0/5] Generate x86 cpu features

On Tue, Feb 06, 2024 at 02:47:34PM +0100, Tim Wiederhake wrote: > Synchronizing the list of cpu features and models with qemu is a recurring > task in libvirt. For x86, this is done by reading qom-list-properties for > max-x86_64-cpu and manually filtering out everthing that does not look like > a

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

On Tue, Mar 05, 2024 at 02:25:09PM +0100, Anthony Harivel wrote: > Daniel P. Berrangé, Mar 04, 2024 at 15:48: > > On Mon, Mar 04, 2024 at 03:41:02PM +0100, Anthony Harivel wrote: > > > > > > Hi Daniel, > > > > > > > > +if (s->m

Re: [RFC PATCH v2 1/9] Add Rust SEV library as subproject

On Wed, Oct 04, 2023 at 04:34:10PM -0400, Tyler Fanelli wrote: > The Rust sev library provides a C API for the AMD SEV launch ioctls, as > well as the ability to build with meson. Add the Rust sev library as a > QEMU subproject with the goal of outsourcing all SEV launch ioctls to C > APIs

Re: [PATCH] hw/rtc/sun4v-rtc: Relicense to GPLv2-or-later

> Philippe Mathieu-Daudé NB mailmap translations - the commit was phi...@redhat.com originally > Markus Armbruster > Eduardo Habkost On behalf of Red Hat, I can confirm that any contributions to this file where Red Hat would hold copyright are acceptable to relicense to GPL-v2-or-later.

Re: [RFC PATCH 2/2] gitlab-ci: add manual job to run Coverity

"schedule" && $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH' > + when: on_success > +- if: '$CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM' > + when: never > +# Forks don't get any pipeline unless QEMU_CI=1 or QEMU_CI=2 is set > +- if: '$QEMU_CI != &qu

<    1   2   3   4   5   6   7   8   9   10   >