Re: [PATCH 09/14] hw: temporarily disable deletion of versioned machine types

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 01:05:20PM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > The new deprecation and deletion policy for versioned machine types is > > being introduced in QEMU 9.1.0. > > > > Under the new policy a number of old

Re: [PATCH v4 01/22] hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines

2024-05-02 Thread Daniel P . Berrangé
On Tue, Apr 16, 2024 at 08:59:17PM +0200, Philippe Mathieu-Daudé wrote: > Similarly to the commit c7437f0ddb "docs/about: Mark the > old pc-i440fx-2.0 - 2.3 machine types as deprecated", > deprecate the 2.4 to 2.12 machines. > > Suggested-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH v4 20/22] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

2024-05-02 Thread Daniel P . Berrangé
On Tue, Apr 16, 2024 at 08:59:36PM +0200, Philippe Mathieu-Daudé wrote: > The pc-i440fx-2.3 machine was deprecated for the 8.2 > release (see commit c7437f0ddb "docs/about: Mark the > old pc-i440fx-2.0 - 2.3 machine types as deprecated"), > time to remove it. > > Signed-off-by: Philippe Mathieu-Da

Re: [PATCH 13/14] hw/i386: remove obsolete manual deprecation reason string of i440fx machines

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 02:08:58PM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > The automatic deprecation mechanism introduced in the preceeding patches > > will mark every i440fx machine upto and including 2.12 as deprecated. As > > s

Re: [PATCH] bitmap: Use g_try_new0/g_renew

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 04:23:16PM +0200, Paolo Bonzini wrote: > Avoids an explicit use of sizeof(). The GLib allocation macros > ensure that the multiplication by the size of the element > uses the right type and does not overflow. > > Cc: qemu-triv...@nongnu.org > Cc: Roman Kiryanov > Cc: Dani

Re: [PATCH] ui/cocoa.m: Drop old macOS-10.12-and-earlier compat ifdefs

2024-05-02 Thread Daniel P . Berrangé
feAreaInsets, which is 12.0-or-newer. > > Remove the ifdefs that were providing backwards compatibility for > building on 10.12 and earlier versions. > > Signed-off-by: Peter Maydell > --- > ui/cocoa.m | 13 - > 1 file changed, 13 deletions(-) Reviewed-by: Daniel

Re: [PATCH v2] bitmap: Use g_try_new0/g_renew

2024-05-02 Thread Daniel P . Berrangé
ange > Signed-off-by: Paolo Bonzini > --- > include/qemu/bitmap.h | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

Re: [PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-03 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 11:54:15PM +0300, Michael Tokarev wrote: > 02.05.2024 23:41, Richard Henderson wrote: > > On 5/2/24 13:08, Michael Tokarev wrote: > > > This thing works now with sid/unstable, this is what this patch is about. > > > > It worked when first introduced, then failed, then worke

Re: [PATCH v2] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2024 at 10:16:34AM +0300, Michael Tokarev wrote: > Revert "gitlab-ci: Disable the riscv64-debian-cross-container by default" > This reverts commit f51f90c65ed7706c3c4f7a889ce3d6b7ab75ef6a. > > riscv64 in debian has been non-functioning for almost a year, after the > architecture ha

Re: [PATCH v2] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2024 at 10:51:57AM +0200, Philippe Mathieu-Daudé wrote: > On 3/5/24 10:07, Daniel P. Berrangé wrote: > > On Fri, May 03, 2024 at 10:16:34AM +0300, Michael Tokarev wrote: > > > Revert "gitlab-ci: Disable the riscv64-debian-cross-container by default&quo

Re: [PATCH v2] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

2024-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2024 at 09:07:34AM +0100, Daniel P. Berrangé wrote: > On Fri, May 03, 2024 at 10:16:34AM +0300, Michael Tokarev wrote: > > Revert "gitlab-ci: Disable the riscv64-debian-cross-container by default" > > This reverts commit f51f90c65ed7706c3c4f7a889ce3d6b7ab75

Re: [PATCH] gitlab-ci: adjust msys2-64bit to be able to run qtest

2024-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2024 at 02:15:09PM +0200, Paolo Bonzini wrote: > sparc-softmmu is able to run a subset of qtests when compiled > --without-default-devices, > so use it instead of x86_64-softmmu for the msys2 run. > > Signed-off-by: Paolo Bonzini > --- > .gitlab-ci.d/windows.yml | 5 + > 1 f

Re: [PATCH 00/14] hw: define and enforce a standard lifecycle for versioned machines

2024-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2024 at 01:14:27PM +0100, Peter Maydell wrote: > On Wed, 1 May 2024 at 19:28, Daniel P. Berrangé wrote: > > I wonder, however, whether we would benefit from changing how we > > update the VERSION file. > > > > eg instead of re-using the micro di

Re: [PATCH V1 01/26] oslib: qemu_clear_cloexec

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 08:27:15PM -0300, Fabiano Rosas wrote: > Steve Sistare writes: > > +cc dgilbert, marcandre > > > Define qemu_clear_cloexec, analogous to qemu_set_cloexec. > > > > Signed-off-by: Steve Sistare > > Reviewed-by: Dr. David Alan Gilbert > > Reviewed-by: Marc-André Lureau >

Re: [PATCH 1/9] monitor: Honor QMP request for fd removal immediately

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:34AM -0300, Fabiano Rosas wrote: > We're enabling using the fdset interface to pass file descriptors for > use in the migration code. Since migrations can happen more than once > during the VMs lifetime, we need a way to remove an fd from the fdset > at the end of migr

Re: [PATCH 2/9] migration: Fix file migration with fdset

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:35AM -0300, Fabiano Rosas wrote: > When the migration using the "file:" URI was implemented, I don't > think any of us noticed that if you pass in a file name with the > format "/dev/fdset/N", this allows a file descriptor to be passed in > to QEMU and that behaves jus

Re: [PATCH 2/9] migration: Fix file migration with fdset

2024-05-08 Thread Daniel P . Berrangé
On Fri, May 03, 2024 at 12:23:51PM -0400, Peter Xu wrote: > On Fri, Apr 26, 2024 at 11:20:35AM -0300, Fabiano Rosas wrote: > > When the migration using the "file:" URI was implemented, I don't > > think any of us noticed that if you pass in a file name with the > > format "/dev/fdset/N", this allow

Re: [PATCH 3/9] tests/qtest/migration: Fix file migration offset check

2024-05-08 Thread Daniel P . Berrangé
On Fri, May 03, 2024 at 05:36:59PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Fri, Apr 26, 2024 at 11:20:36AM -0300, Fabiano Rosas wrote: > >> When doing file migration, QEMU accepts an offset that should be > >> skipped when writing the migration stream to the file. The purpose of >

Re: [PATCH 4/9] migration: Add direct-io parameter

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:37AM -0300, Fabiano Rosas wrote: > Add the direct-io migration parameter that tells the migration code to > use O_DIRECT when opening the migration stream file whenever possible. > > This is currently only used with the mapped-ram migration that has a > clear window g

Re: [PATCH 5/9] migration/multifd: Add direct-io support

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:38AM -0300, Fabiano Rosas wrote: > When multifd is used along with mapped-ram, we can take benefit of a > filesystem that supports the O_DIRECT flag and perform direct I/O in > the multifd threads. This brings a significant performance improvement > because direct-io w

Re: [PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:39AM -0300, Fabiano Rosas wrote: > The tests are only allowed to run in systems that know about the > O_DIRECT flag and in filesystems which support it. > > Signed-off-by: Fabiano Rosas > --- > tests/qtest/migration-helpers.c | 42 + >

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: > Allow multifd to use an fdset when migrating to a file. This is useful > for the scenario where the management layer wants to have control over > the migration file. > > By receiving the file descriptors directly, QEMU can delegate s

Re: [PATCH 9/9] tests/qtest/migration: Add a test for mapped-ram with passing of fds

2024-05-08 Thread Daniel P . Berrangé
On Fri, Apr 26, 2024 at 11:20:42AM -0300, Fabiano Rosas wrote: > Add a multifd test for mapped-ram with passing of fds into QEMU. This > is how libvirt will consume the feature. > > There are a couple of details to the fdset mechanism: > > - multifd needs two distinct file descriptors (not duplic

Re: [PATCH v4 01/12] libvhost-user: set msg.msg_control to NULL when it is empty

2024-05-08 Thread Daniel P . Berrangé
On Wed, May 08, 2024 at 09:44:45AM +0200, Stefano Garzarella wrote: > On some OS (e.g. macOS) sendmsg() returns -1 (errno EINVAL) if > the `struct msghdr` has the field `msg_controllen` set to 0, but > `msg_control` is not NULL. > > Reviewed-by: Eric Blake > Reviewed-by: David Hildenbrand > Revi

Re: [PATCH v4 02/12] libvhost-user: fail vu_message_write() if sendmsg() is failing

2024-05-08 Thread Daniel P . Berrangé
subprojects/libvhost-user/libvhost-user.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berran

Re: [PATCH v4 04/12] vhost-user-server: do not set memory fd non-blocking

2024-05-08 Thread Daniel P . Berrangé
now carry memory fd (e.g. VHOST_USER_ADD_MEM_REG, > VHOST_USER_SET_MEM_TABLE). > > Signed-off-by: Stefano Garzarella > --- > v3: > - avoiding setting fd non-blocking for messages where we have memory fd > (Eric) > --- > util/vhost-user-server.c | 12 ++++ > 1 f

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-08 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 06:52:50AM +0200, Jinpu Wang wrote: > Hi Peter, hi Daniel, > On Mon, May 6, 2024 at 5:29 PM Peter Xu wrote: > > > > On Mon, May 06, 2024 at 12:08:43PM +0200, Jinpu Wang wrote: > > > Hi Peter, hi Daniel, > > > > Hi, Jinpu, > > > > Thanks for sharing this test results. Sound

Re: Hermetic virtio-vsock in QEMU

2024-05-08 Thread Daniel P . Berrangé
On Wed, May 08, 2024 at 02:37:52PM +0200, Paolo Bonzini wrote: > On 5/8/24 11:38, Stefano Garzarella wrote: > > On Wed, May 08, 2024 at 01:13:09PM GMT, Marc-André Lureau wrote: > > > Hi > > > > > > On Wed, May 8, 2024 at 11:50 AM Stefano Garzarella > > > wrote: > > > > > > > > Hi Roman, > > > >

Re: Hermetic virtio-vsock in QEMU

2024-05-08 Thread Daniel P . Berrangé
On Wed, May 08, 2024 at 03:00:30PM +0200, Paolo Bonzini wrote: > On Wed, May 8, 2024 at 2:51 PM Daniel P. Berrangé wrote: > > Designwise, a native VSOCK backend in QEMU really should implement the > > same approach defined by firecracker, so that we have interoperability &

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-09 Thread Daniel P . Berrangé
On Wed, May 08, 2024 at 05:39:53PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, May 08, 2024 at 09:53:48AM +0100, Daniel P. Berrangé wrote: > >> On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: > >> > Allow multifd to use an fdset

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-05-09 Thread Daniel P . Berrangé
ARM and x86, I'd like to discuss my API > thinking with you. ;-) > > On Mon, Apr 15, 2024 at 06:29:25PM +0100, Daniel P. Berrangé wrote: > > Date: Mon, 15 Apr 2024 18:29:25 +0100 > > From: "Daniel P. Berrangé" > > Subject: Re: [PATCH v9] arm/kvm: Enable

Re: [PATCH v3] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2024 at 04:54:16PM +0300, Michael Tokarev wrote: > 03.05.2024 20:46, Babu Moger wrote: > > Observed the following failure while booting the SEV-SNP guest and the > > guest fails to boot with the smp parameters: > > "-smp 192,sockets=1,dies=12,cores=8,threads=2". > > > > qemu-system

Re: [PATCH 01/14] include/hw: add helpers for defining versioned machine types

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 12:34:49PM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > The various targets which define versioned machine types have > > a bunch of obfuscated macro code for defining unique function > > and variable names using

Re: [PATCH 01/14] include/hw: add helpers for defining versioned machine types

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 09:57:21AM -0500, Eric Blake wrote: > On Wed, May 01, 2024 at 07:27:46PM +0100, Daniel P. Berrangé wrote: > > The various targets which define versioned machine types have > > a bunch of obfuscated macro code for defining unique function > > and variab

Re: [PATCH 08/14] include/hw: add macros for deprecation & removal of versioned machines

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 12:59:05PM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > Versioned machines live for a long time to provide back compat for > > incoming migration and restore of saved images. To guide users away from > > usage of old

Re: [PATCH V1 24/26] seccomp: cpr-exec blocker

2024-05-10 Thread Daniel P . Berrangé
On Mon, Apr 29, 2024 at 08:55:33AM -0700, Steve Sistare wrote: > cpr-exec mode needs permission to exec. Block it if permission is denied. > > Signed-off-by: Steve Sistare > --- > include/sysemu/seccomp.h | 1 + > system/qemu-seccomp.c| 10 -- > system/vl.c | 6 ++

Re: [PATCH v3] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2024-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2024 at 11:05:44AM +0300, Michael Tokarev wrote: > 09.05.2024 17:11, Daniel P. Berrangé wrote: > > On Thu, May 09, 2024 at 04:54:16PM +0300, Michael Tokarev wrote: > > > 03.05.2024 20:46, Babu Moger wrote: > > > > > diff --git a/hw/i386/pc.c b/hw/i

Re: [Qemu-devel] [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning

2019-05-01 Thread Daniel P . Berrangé
On Tue, Apr 30, 2019 at 11:28:41PM +, Alistair Francis wrote: > Fix this warning with GCC 9 on Fedora 30: > hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct > ’ may result in an unaligned pointer value > [-Werror=address-of-packed-member] > 1715 |

Re: [Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-05-01 Thread Daniel P . Berrangé
, dev); > > for (i = 0; i < usbports; i++) { > +g_assert(i < MAX(MAXPORTS_2, MAXPORTS_3)); > speedmask = 0; > if (i < xhci->numports_2) { > if (xhci_get_flag(xhci, XHCI_FLAG_SS_FIRST)) { I proposed a slightly different fix

Re: [Qemu-devel] [PATCH v2 1/5] util/qemu-sockets: Fix GCC 9 build warnings

2019-05-01 Thread Daniel P . Berrangé
On Tue, Apr 30, 2019 at 11:28:22PM +, Alistair Francis wrote: > Fix this warning when building with GCC9 on Fedora 30: > In function ‘strncpy’, > inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: > /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’

Re: [Qemu-devel] [PATCH v2 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-05-01 Thread Daniel P . Berrangé
On Wed, May 01, 2019 at 11:40:13AM +0200, Laurent Vivier wrote: > On 01/05/2019 01:28, Alistair Francis wrote: > > Fix this warning when building with GCC9 on Fedora 30: > > In function ‘strncpy’, > > inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: > > /usr/include/bits

[Qemu-devel] [PATCH v2] linux-user: avoid string truncation warnings in uname field copying

2019-05-01 Thread Daniel P . Berrangé
n the original uname field was. It suffices to copy the entire original field and simply force a NUL terminator at the end of the new field. Signed-off-by: Daniel P. Berrangé --- Changed in v2: - Always use sizeof() in preference to __NEW_UTS_LEN linux-user/uname.c | 5 ++--- 1 file chang

[Qemu-devel] [PATCH v2] sockets: avoid string truncation warnings when copying UNIX path

2019-05-01 Thread Daniel P . Berrangé
)); | ^~ We are already validating the UNIX socket path length earlier in the functions. If we save this string length when we first check it, then we can simply use memcpy instead of strcpy later, avoiding the gcc truncation warnings. Signed-off-by: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH v2 3/5] sockets: avoid string truncation warnings when copying UNIX path

2019-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2019 at 05:45:30PM +0200, Laurent Vivier wrote: > Dan, > > do you want I take this through the trivial branch queue or do you add > it into the Sockets branch queue? I'm fine with you sending it via trivial queue since there's nothing else pending for the sockets code. Regards,

Re: [Qemu-devel] [PATCH v3] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-05-03 Thread Daniel P . Berrangé
~ >68 |__bos (__s), __fmt, __va_arg_pack ()); > |~~~~~~~~~ > > Signed-off-by: Alistair Francis > Reviewed-by: Laurent Vivier > Reviewed-by: Daniel P. Berrangé > Revie

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Daniel P . Berrangé
On Thu, Apr 25, 2019 at 02:35:03PM +0100, Stefan Hajnoczi wrote: > At KVM Forum 2018 I gave a presentation on security in QEMU: > https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) > https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) > > This patch adds a security guide to the deve

Re: [Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 11:28:53AM +0100, Peter Maydell wrote: > On Fri, 3 May 2019 at 11:19, Daniel P. Berrangé wrote: > > Everything above here is useful to QEMU devs, app devs & end users and > > should be made part of the main QEMU doc - convert it to texi and @inclu

Re: [Qemu-devel] Request for comment - dynamic VNC keyboard mapping

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 01:47:15PM +0200, Mario wrote: > Hi all, > > I have a question related to the VNC server keyboard settings. Currently > the user of qemu has to decide before VM startup which language is used > for VNC keyboard mapping. If no keyboard is configured, the en-us keyboard > wil

Re: [Qemu-devel] [PATCH v2 5/6] util: simplify unix_listen()

2019-05-03 Thread Daniel P . Berrangé
> util/qemu-sockets.c | 18 ++ > 1 file changed, 2 insertions(+), 16 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |

Re: [Qemu-devel] [PATCH] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-03 Thread Daniel P . Berrangé
ev/urandom" > > Signed-off-by: Kashyap Chamarthy > --- > backends/rng-random.c | 2 +- > qemu-options.hx | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://ww

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > On 03/05/2019 02.41, Eduardo Habkost wrote: > > From: Daniel P. Berrangé > > > > Unless overridden via an env var or configure arg, QEMU will only look > > for the 'python' binary in $PATH. This

Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 05:54:35PM +0100, Daniel P. Berrangé wrote: > On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote: > > On 03/05/2019 02.41, Eduardo Habkost wrote: > > > From: Daniel P. Berrangé > > > > > > Unless overridden via an env var o

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > The Golang JSON parser decodes JSON numbers to float64 by default so > > will have this precision limitation too, though at least they provide > > a backdoor for custom parsing from the original serialized representation. > > >

Re: [Qemu-devel] [PATCH] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-07 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 10:47:57PM +0200, Kashyap Chamarthy wrote: > On Fri, May 03, 2019 at 04:49:05PM +0100, Daniel P. Berrangé wrote: > > On Fri, May 03, 2019 at 05:46:13PM +0200, Kashyap Chamarthy wrote: > > > When QEMU exposes a VirtIO-RNG device to the guest, that device ne

Re: [Qemu-devel] [PATCH] Deprecate Python 2 support

2019-05-07 Thread Daniel P . Berrangé
s changed, 16 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH] Deprecate Python 2 support

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 12:38:14PM +0200, Kevin Wolf wrote: > Am 03.05.2019 um 21:37 hat Eduardo Habkost geschrieben: > > Python 2 will reach end of life in January 1 2020. Declare it as > > deprecated. > > > > Signed-off-by: Eduardo Habkost > > --- > > configure| 8 > > qe

Re: [Qemu-devel] [PATCH v3 1/5] 9p: mitigates most QID path collisions

2019-05-07 Thread Daniel P . Berrangé
On Tue, Apr 23, 2019 at 01:30:03PM +0200, Christian Schoenebeck via Qemu-devel wrote: > This first patch here is an updated version of Antonios Motakis' > original 4-patch set (using fixed length 16 bit prefixes), merged to one > patch: > > https://lists.gnu.org/archive/html/qemu-devel/2018-02/ms

Re: [Qemu-devel] [PATCH v3 2/5] 9P: trivial cleanup of QID path collision mitigation

2019-05-07 Thread Daniel P . Berrangé
On Tue, Apr 23, 2019 at 01:35:23PM +0200, Christian Schoenebeck via Qemu-devel wrote: > Addresses trivial changes regarding the previous patch as requested > on the mailing list a while ago. These changes should just be made to the original 4 patches individually rather than in a new patch. > >

Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii'

2019-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2019 at 07:58:28PM +0200, Christian Schoenebeck via Qemu-devel wrote: > This is the counter part patch against latest libvirt git master head to > support the 'vii' feature of patch 5, which introduces the XML config > XML tag "important" on libvirt side. > > To stick with the pre

Re: [Qemu-devel] [PATCH v2] i386: Add some MSR based features on Cascadelake-Server CPU model

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 08:48:53PM +0800, Tao Xu wrote: > As noted in > http://lists.gnu.org/archive/html/qemu-devel/2018-09/msg02212.html Rather than pointing to the mailing list post, please just refer to the git commit hash that patch was merged under, which IIUC is c7a88b52f62b30c04158eeb07f73

Re: [Qemu-devel] [PATCH v3 1/5] 9p: mitigates most QID path collisions

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 03:11:26PM +0200, Christian Schoenebeck wrote: > On Dienstag, 7. Mai 2019 13:42:47 CEST Daniel P. Berrangé wrote: > > > This first patch here is an updated version of Antonios Motakis' > > > original 4-patch set (using fixed length 16 bi

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: > test-qapi.py doesn't force a specific encoding for stderr or > stdout, but the reference files used by check-qapi-schema are in > UTF-8. This breaks check-qapi-schema under certain circumstances > (e.g. if using the C locale and Py

Re: [Qemu-devel] [PULL 0/2] slirp: move slirp as git submodule project

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 09:11:09AM -0500, Eric Blake wrote: > On 5/2/19 5:30 PM, Samuel Thibault wrote: > > The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: > > > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > > into staging (2019-05-02 1

Re: [Qemu-devel] [RFC] Virtio RNG: Consider changing the default entropy source to /dev/urandom?

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 11:59:05AM +0200, Nikos Mavrogiannopoulos wrote: > In terms of RHEL what is preferred is (1) use a crypto lib, and (2) if > that's not possible use getrandom(). That is summarized in this > article: > > https://www.redhat.com/en/blog/understanding-red-hat-enterprise-linux-r

Re: [Qemu-devel] [RFC] Virtio RNG: Consider changing the default entropy source to /dev/urandom?

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 10:14:25AM -0700, Richard Henderson wrote: > On 5/7/19 8:22 AM, Daniel P. Berrangé wrote: > > On Tue, May 07, 2019 at 11:59:05AM +0200, Nikos Mavrogiannopoulos wrote: > >> In terms of RHEL what is preferred is (1) use a crypto lib, and (2) if > >&

Re: [Qemu-devel] [PATCH 1/5] qemu-nbd: Add --pid-file option

2019-05-08 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 08:36:06PM +0200, Max Reitz wrote: > --fork is a bit boring if there is no way to get the child's PID. This > option helps. > > Signed-off-by: Max Reitz > --- > qemu-nbd.c| 29 + > qemu-nbd.texi | 2 ++ > 2 files changed, 31 insertions(+)

Re: [Qemu-devel] [PATCH 1/5] qemu-nbd: Add --pid-file option

2019-05-08 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 09:39:01PM +0200, Max Reitz wrote: > On 07.05.19 21:30, Eric Blake wrote: > > On 5/7/19 1:36 PM, Max Reitz wrote: > >> --fork is a bit boring if there is no way to get the child's PID. This > >> option helps. > >> > >> Signed-off-by: Max Reitz > >> --- > >> qemu-nbd.c

Re: [Qemu-devel] Question in QEMU : The result of printf does not appear in the qemu VM's log.

2019-05-08 Thread Daniel P . Berrangé
On Wed, May 08, 2019 at 10:51:00AM +0900, S KH wrote: > Hello. > > I'am student studying QEMU hypervisor and SPICE. > > In order to find out the calling order of functions in QEMU source, I input > and compiled 'printf ("% s \ n", __ func__) "into source. If using printf() output is buffered so

Re: [Qemu-devel] [PATCH v3] i386: Add some MSR based features on Cascadelake-Server CPU model

2019-05-08 Thread Daniel P . Berrangé
CAPABILITIES MSR based features (RDCL_NO, > IBRS_ALL and SKIP_L1DFL_VMENTRY). > > And "014018e19b i386: Make arch_capabilities migratable" has been > in QEMU upstream, the CPUID_7_0_EDX_ARCH_CAPABILITIES can be > safely added into CPU Model. > > Signed-off-by: Tao Xu

Re: [Qemu-devel] Question in QEMU : The result of printf does not appear in the qemu VM's log.

2019-05-08 Thread Daniel P . Berrangé
Re-adding qemu-devel - please don't take mailing list threads private. On Wed, May 08, 2019 at 07:07:01PM +0900, S KH wrote: > Hello. > > Thanks to help, I can see the results of the output in the log file. Thank > you very much for your help. I am currently working with the QEMU source as > well

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 10:31:46AM +0200, Markus Armbruster wrote: > We've wandered into the QAPI vs. QOM swamp. Cc: Paolo. > > Eduardo Habkost writes: > > > On Wed, May 08, 2019 at 11:16:50AM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Tue, May 07, 2019 at 07:

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 11:36:04AM +0200, Kevin Wolf wrote: > Am 09.05.2019 um 11:24 hat Kevin Wolf geschrieben: > > Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > > > Eduardo Habkost writes: > > > > diff --git a/.travis.yml b/.travis.yml > > > > index 66448d99d6..0f6986b3f1 100644 >

Re: [Qemu-devel] [PATCH v3 2/2] docs: add Security chapter to the documentation

2019-05-09 Thread Daniel P . Berrangé
++ > qemu-doc.texi | 3 ++ > 3 files changed, 135 insertions(+), 1 deletion(-) > create mode 100644 docs/security.texi Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [Qemu-devel] [PATCH v3 1/2] docs: add Secure Coding Practices to developer docs

2019-05-09 Thread Daniel P . Berrangé
> 2 files changed, 107 insertions(+) > create mode 100644 docs/devel/secure-coding-practices.rst Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https

Re: [Qemu-devel] [PATCH 12/13] tests/vm: fedora autoinstall, using serial console

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 03:10:03PM +0200, Gerd Hoffmann wrote: > Hi, > > > > +# shutdown > > > +self.ssh_root("poweroff") > > > +self.console_wait("sleep state S5") > > > +self.wait() > > > + > > > +if os.path.exists(img): > > > +os.remove(img)

Re: [Qemu-devel] [RFC] rng-random: allow to use getrandom()

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 03:22:34PM +0200, Laurent Vivier wrote: > Add a parameter to select the rng-random backend mode, > from a file or from qemu_guest_getrandom(): > > -object rng-random,id=rng0,mode=file or > -object rng-random,id=rng0,mode=getrandom > > by default mode is file I don't r

Re: [Qemu-devel] Question on QEMU : How to record debug log in VM of QEMU

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 02:45:25PM +0100, Stefan Hajnoczi wrote: > On Tue, May 07, 2019 at 11:29:03AM +0900, S KH wrote: > > This is a question I have encountered while using QEMU. > > > > I want to compile the source directly rather than through apt or yum and > > install QEMU and input the outpu

Re: [Qemu-devel] [RFC] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 04:23:42PM +0200, Laurent Vivier wrote: > Add a new RNG backend using QEMU builtin getrandom function. > > It can be created with "-object rng-builtin". > > This patch applies on top of > "[PATCH v4 00/24] Add qemu_getrandom and ARMv8.5-RNG etc" > Based-on: <20190506173353

Re: [Qemu-devel] [PATCH] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 02:53:20PM +0100, Stefan Hajnoczi wrote: > On Fri, May 03, 2019 at 05:46:12PM +0200, Kashyap Chamarthy wrote: > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > > source of entropy, and that source needs to be "non-blocking", like > > `/dev/urandom

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 12:52:47PM -0300, Eduardo Habkost wrote: > On Thu, May 09, 2019 at 10:14:52AM +0100, Daniel P. Berrangé wrote: > > On Thu, May 09, 2019 at 10:31:46AM +0200, Markus Armbruster wrote: > > > We've wandered into the QAPI vs. QOM swamp. Cc: Paolo. >

Re: [Qemu-devel] [PATCH v5 01/24] configure: Link test before auto-enabling crypto libraries

2019-05-10 Thread Daniel P . Berrangé
> --- > configure | 72 +-- > 1 file changed, 44 insertions(+), 28 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [Qemu-devel] [PATCH v5 02/24] crypto: Merge crypto-obj-y into libqemuutil.a

2019-05-10 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 06:24:36PM -0700, Richard Henderson wrote: > We will shortly need this in the user-only binaries, so drop the split > into system and tools binaries. This also means that crypto-aes-obj-y > can be merged back into crypto-obj-y. > > Cc: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH v2] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-10 Thread Daniel P . Berrangé
/msg02724.html > -- "[RFC] Virtio RNG: Consider changing the default entropy source to >/dev/urandom" > > Signed-off-by: Kashyap Chamarthy > --- > v2: > - Update commit message to mention justification for preferring >`/dev/urandom` over `/dev/r

Re: [Qemu-devel] [PATCH v2] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-05-10 Thread Daniel P . Berrangé
g-builtin.c | 56 ++ > qemu-options.hx| 10 +++- > 3 files changed, 66 insertions(+), 2 deletions(-) > create mode 100644 backends/rng-builtin.c Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [Qemu-devel] [PATCH v2] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2019 at 02:03:33PM +0200, Markus Armbruster wrote: > Kashyap Chamarthy writes: > > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > > source of entropy, and that source needs to be "non-blocking", like > > `/dev/urandom`. However, currently QEMU default

Re: [Qemu-devel] [PATCH v2] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2019 at 02:37:41PM +0200, Laurent Vivier wrote: > On 10/05/2019 14:27, Markus Armbruster wrote: > > Laurent Vivier writes: > > The new rng-builtin is considerably simpler than both rng-random and > > rng-egd. Moreover, it just works, whereas rng-random is limited to > > CONFIG_POS

Re: [Qemu-devel] [PATCH] crypto: Fix LGPL information in the file headers

2019-05-10 Thread Daniel P . Berrangé
| 2 +- > include/crypto/tlscredsanon.h | 2 +- > include/crypto/tlscredspsk.h | 2 +- > include/crypto/tlscredsx509.h | 2 +- > include/crypto/tlssession.h | 2 +- > include/crypto/xts.h | 2 +- > 52 files changed, 52 insertions(+), 52 deletions(-) Reviewed-by: Dan

Re: [Qemu-devel] [PATCH v3 1/3] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2019 at 12:12:41PM -0400, Michael S. Tsirkin wrote: > On Fri, May 10, 2019 at 03:42:01PM +0200, Laurent Vivier wrote: > > From: Kashyap Chamarthy > > > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > > source of entropy, and that source needs to be "non

Re: [Qemu-devel] [PATCH v3 1/3] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2019 at 12:21:19PM -0400, Michael S. Tsirkin wrote: > On Fri, May 10, 2019 at 05:16:44PM +0100, Daniel P. Berrangé wrote: > > On Fri, May 10, 2019 at 12:12:41PM -0400, Michael S. Tsirkin wrote: > > > On Fri, May 10, 2019 at 03:42:01PM +0200, Laurent Vivier w

Re: [Qemu-devel] [PATCH v3 1/3] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2019 at 12:55:18PM -0400, Michael S. Tsirkin wrote: > On Fri, May 10, 2019 at 05:25:54PM +0100, Daniel P. Berrangé wrote: > > On Fri, May 10, 2019 at 12:21:19PM -0400, Michael S. Tsirkin wrote: > > > On Fri, May 10, 2019 at 05:16:44PM +0100, Daniel P. Berrangé wro

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2019 at 02:17:11PM -0300, Eduardo Habkost wrote: > On Fri, May 10, 2019 at 11:29:53AM +0200, Markus Armbruster wrote: > [...] > > I'm afraid our command line is awkward both for machines and for humans, > > albeit for different reasons. > > > > For humans doing simple things, the c

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Daniel P . Berrangé
On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > Maybe try to clean the folder first: > > rm -r capstone > mkdir capstone > make git-submodule-update > > If that does not help, maybe try a completely fresh git checkout? Rather than deleting stuff like that, it is best to use git

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2019 at 10:48:58AM +0100, Peter Maydell wrote: > On Mon, 13 May 2019 at 10:08, Daniel P. Berrangé wrote: > > > > On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > > > Maybe try to clean the folder first: > > > > > > rm -r

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-13 Thread Daniel P . Berrangé
On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote: > > > >> >> > I can think of some options: > >> >> > > >> >

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2019 at 01:29:34PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > > > Daniel P. Berrangé writes: > > > > > > > On Tue, M

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2019 at 03:53:19PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote: > [...] > >> Double-checking: do you propose to encode *all* numbers as strings, or > >> j

Re: [Qemu-devel] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 03:06:08PM -0300, Eduardo Habkost wrote: > On Wed, Jun 05, 2019 at 06:33:11PM +0100, Daniel P. Berrangé wrote: > [...] > > I wonder if there's a way to close the testing gap somehow ? Random idea > > would be a non-versioned "pc-no-deprecated

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 03:42:39PM -0500, Eric Blake wrote: > On 6/5/19 3:13 PM, Eduardo Habkost wrote: > > >> IOW, I don't think RHEL-7 support as a build platform blocks us from > >> dropping py2. We merely need to tweak our build platforms doc to clarify > >> our intent wrt add-on yum repos. >

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 03:13:08PM -0300, Eduardo Habkost wrote: > On Wed, Jun 05, 2019 at 04:44:03PM +0100, Daniel P. Berrangé wrote: > [...] > > Thus to answer your python 2 question, we should ask which of our build > > targets cannot support python 3 ? > > > > O

Re: [Qemu-devel] Qemu baseline requirements/portability?

2019-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2019 at 07:30:08AM +0200, Markus Armbruster wrote: > "H. Peter Anvin" writes: > > > On 6/5/19 12:55 PM, H. Peter Anvin wrote: > >> Hi, > >> > >> I am writing some code I'm hoping will be able to make it into Qemu, but I > >> can't seem to find what the baseline portability requir

<    3   4   5   6   7   8   9   10   11   12   >