[Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.

From: Rob Landley r...@landley.net Date: Sun, 21 Feb 2010 10:25:09 -0600 085219f79cad89291699bd2bfb21c9fdabafe65f is first bad commit commit 085219f79cad89291699bd2bfb21c9fdabafe65f Author: Sam Ravnborg s...@ravnborg.org Date: Fri Jan 2 18:47:34 2009 -0800 sparc32: use proper types

[Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.

Here's the fix I'll use, thanks for the report Rob: sparc32: Fix struct stat uid/gid types. Commit 085219f79cad89291699bd2bfb21c9fdabafe65f (sparc32: use proper types in struct stat) Accidently changed the struct stat uid/gid members to uid_t and gid_t, but those get set to __kernel_uid32_t

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

From: Herbert Xu herb...@gondor.apana.org.au Date: Wed, 14 Apr 2010 08:58:22 +0800 On Tue, Apr 13, 2010 at 08:31:03PM +0200, Eric Dumazet wrote: Herbert Acked your patch, so I guess its OK, but I think it can be dangerous. The tun socket accounting was never designed to stop it from

Re: [Qemu-devel] [V6 PATCH] virtio-net: send gratuitous packets when needed

From: Jason Wang jasow...@redhat.com Date: Wed, 28 Mar 2012 13:44:28 +0800 As hypervior does not have the knowledge of guest network configuration, it's better to ask guest to send gratuitous packets when needed. Guest tests VIRTIO_NET_S_ANNOUNCE bit during config change interrupt and when

Re: [Qemu-devel] Macvtap bug: contractor wanted

Solicitation of paid services or employment is absolutely not appropriate on the vger.kernel.org mailing lists. Please do not do this ever again.

Re: [Qemu-devel] [PATCH v4 2/3] net: split eth_mac_addr for better error handling

From: ak...@redhat.com Date: Sun, 20 Jan 2013 10:43:08 +0800 From: Stefan Hajnoczi stefa...@gmail.com When we set mac address, software mac address in system and hardware mac address all need to be updated. Current eth_mac_addr() doesn't allow callers to implement error handling nicely.

Re: [Qemu-devel] [PATCH v5 0/3] make mac programming for virtio net more robust

From: Amos Kong ak...@redhat.com Date: Mon, 21 Jan 2013 19:17:20 +0800 Currenly mac is programmed byte by byte. This means that we have an intermediate step where mac is wrong. Third patch introduced a new vq control command to set mac address, it's atomic. V2: check return of sending

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

From: David Woodhouse dw...@infradead.org Date: Mon, 02 Feb 2015 07:27:10 + I'm guessing you don't want to push the *whole* management of the TLS control connection *and* the UDP transport, and probing the latter with keepalives, into the kernel? I certainly don't :) Whilst Herbert Xu and

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

From: David Woodhouse dw...@infradead.org Date: Sun, 01 Feb 2015 13:33:50 + Of course, now I'm looking closely at the path these packets take to leave the box, it starts to offend me that they're being passed up to userspace just to encrypt them (as DTLS or ESP) and then send them back

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

From: David Woodhouse dw...@infradead.org Date: Sun, 01 Feb 2015 21:29:43 + I really was looking for some way to push down something like an XFRM state into the tun device and just say shove them out here until I tell you otherwise. People decided to use TUN and push VPN stuff back into

Re: [Qemu-devel] TCP performance problems - GSO/TSO, MSS, 8139cp related

From: Russell King - ARM Linux Date: Fri, 11 Nov 2016 22:33:08 + > "The new buffer management algorithm provides capabilities of Microsoft > Large-Send offload" and as yet I haven't found anything that describes > what this is or how it works. For once I will give

Re: [Qemu-devel] [PATCH net-next v4 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

From: Jason Baron Date: Fri, 5 Jan 2018 17:44:54 -0500 > The ability to set speed and duplex for virtio_net is useful in various > scenarios as described here: > > 16032be virtio_net: add ethtool support for set and get of settings > > However, it would be nice to be able

Re: [Qemu-devel] [PATCH net-next v2 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

From: Jason Baron Date: Fri, 22 Dec 2017 16:54:01 -0500 > The ability to set speed and duplex for virtio_net in useful in various > scenarios as described here: > > 16032be virtio_net: add ethtool support for set and get of settings > > However, it would be nice to be able

Re: [RFC net-next 08/18] tun: run offloaded XDP program in Tx path

From: David Ahern Date: Sun, 1 Dec 2019 09:39:54 -0700 > Below you just drop the packet which is going to be a bad user > experience. A better user experience is to detect XDP return codes a > program uses, catch those that are not supported for this use case and > fail the install of the

Re: [RFC net-next 08/18] tun: run offloaded XDP program in Tx path

From: "Michael S. Tsirkin" Date: Sun, 1 Dec 2019 16:40:22 -0500 > Right. But it is helpful to expose the supported functionality > to guest in some way, if nothing else then so that > guests can be moved between different hosts. > > Also, we need a way to report this kind of event to guest > so

[Bug 1858488] Re: qemu git && 4.2: timed audio issues with sb16, gus not working?

It seems this might be related to buffer/sample size, spice works and uses timed audio with a larger buffer. GUS I have not gotten to work. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858488

[Bug 1858488] Re: qemu git && 4.2: timed audio issues with sb16, gus not working?

./qemu is a symlink to qemu/build/i386-softmmu/qemu-system-i386 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858488 Title: qemu git && 4.2: timed audio issues with sb16, gus not working?

[Bug 1858488] [NEW] qemu git && 4.2: timed audio issues with sb16, gus not working?

Public bug reported: I have built [both] current git, and 4.2.0, there are issues with audio/soundhw for both. Specifics: Linux nullrig 5.3.0-24-generic #26-Ubuntu SMP Thu Nov 14 01:33:18 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Out of source build, successful for both: ../configure

Re: [PATCH v3 00/11] s390x/tcg: Implement Vector-Enhancements Facility 2

I've reviewed all changes, looks good. Ran all of my own tests including vstrs, all passed. Thank you for all reviews and changes here. - David Miller On Mon, Mar 7, 2022 at 8:54 PM Richard Henderson < richard.hender...@linaro.org> wrote: > Hi David, > > I've split up the patc

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

the tests failed. I'm submitting the split patches with whitespace fixes. I hope it's not a dealbreaker, seeing as it matches the rest of the file this way anyhow. If it is, I will spend some more time looking into it tomorrow. Thanks, - David Miller On Thu, Mar 3, 2022 at 1:04 PM David Hildenbra

[PATCH v2 0/7] s390x/tcg: Implement Vector-Enhancements Facility 2

(VCFPL) VECTOR FP CONVERT TO FIXED (VCSFP) VECTOR FP CONVERT TO LOGICAL(VCLFP) VECTOR SHIFT LEFT (VSL) VECTOR SHIFT RIGHT ARITHMETIC (VSRA) VECTOR SHIFT RIGHT LOGICAL (VSRL) David

[PATCH v2 2/7] target/s390x: vxeh2: vector string search

Signed-off-by: David Miller --- target/s390x/helper.h| 1 + target/s390x/tcg/insn-data.def | 2 + target/s390x/tcg/translate.c | 3 +- target/s390x/tcg/translate_vx.c.inc | 17 target/s390x/tcg/vec_string_helper.c | 65 5

[PATCH v2 1/7] target/s390x: vxeh2: vector convert short/32b

Signed-off-by: David Miller --- target/s390x/helper.h | 4 +++ target/s390x/tcg/translate_vx.c.inc | 44 ++--- target/s390x/tcg/vec_fpu_helper.c | 31 3 files changed, 75 insertions(+), 4 deletions(-) diff --git a/target/s390x

[PATCH v2 3/7] target/s390x: vxeh2: vector shift {double by bit, left, right {logical, arithmetic}}

Signed-off-by: David Miller --- include/qemu/bitops.h | 25 +++ target/s390x/helper.h | 3 + target/s390x/tcg/insn-data.def | 6 +- target/s390x/tcg/translate_vx.c.inc | 108 ++-- target/s390x/tcg/vec_int_helper.c | 58

[PATCH v2 4/7] target/s390x: vxeh2: vector {load, store} elements reversed

Signed-off-by: David Miller --- target/s390x/helper.h | 4 ++- target/s390x/tcg/insn-data.def | 4 +++ target/s390x/tcg/translate_vx.c.inc | 39 + target/s390x/tcg/vec.h | 24 ++ target/s390x/tcg/vec_helper.c

[PATCH v2 6/7] target/s390x: add S390_FEAT_VECTOR_ENH2 to cpu max

Signed-off-by: David Miller --- target/s390x/gen-features.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 22846121c4..499a3b10a8 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x/gen-features.c @@ -740,7 +740,9

[PATCH v2 5/7] target/s390x: vxeh2: vector {load, store} reversed elements [and {zero, replicate}]

Signed-off-by: David Miller --- target/s390x/tcg/insn-data.def | 16 +++ target/s390x/tcg/translate_vx.c.inc | 161 2 files changed, 177 insertions(+) diff --git a/target/s390x/tcg/insn-data.def b/target/s390x/tcg/insn-data.def index 3a7f15a0b5..dc6daa6c10

[PATCH v2 7/7] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

* tests/tcg/s390x/vxeh2_vcvt.c : vector convert * tests/tcg/s390x/vxeh2_vs.c: vector shift * tests/tcg/s390x/vxeh2_vlstr.c : vector load/store reversed Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 8 ++ tests/tcg/s390x/vxeh2_vcvt.c| 97

Re: [PATCH v5 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

Will submit patch later today, thanks

[PATCH v4 2/3] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1

TCG implements everything we need to run basic z15 OS+software Signed-off-by: David Miller --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 6 +++--- target/s390x/gen-features.c | 7 +-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/s390x/s390

[PATCH v5 0/3] s390x: Add partial z15 support and tests

et v2 -> v3: * Moved tests to separate patch. * Combined patches into series. David Miller (3): s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1 tests/tcg/s390x: Tests for Miscellane

[PATCH v5 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

HIGH (SELFHR) MOVE RIGHT TO LEFT(MVCRL) POPULATION COUNT (POPCNT) Signed-off-by: David Miller --- target/s390x/gen-features.c| 1 + target/s390x/helper.h | 1 + target/s390x/tcg/insn-data.def | 30 +-- target/s390x/tcg/mem_helper.c | 20

[PATCH v4 3/3] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

tests/tcg/s390x/mie3-compl.c: [N]*K instructions tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction tests/tcg/s390x/mie3-sel.c: SELECT instruction Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/tcg

[PATCH v5 3/3] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

tests/tcg/s390x/mie3-compl.c: [N]*K instructions tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction tests/tcg/s390x/mie3-sel.c: SELECT instruction Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 5 ++- tests/tcg/s390x/mie3-compl.c| 55

[PATCH v4 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

HIGH (SELFHR) MOVE RIGHT TO LEFT(MVCRL) POPULATION COUNT (POPCNT) Signed-off-by: David Miller --- target/s390x/gen-features.c| 1 + target/s390x/helper.h | 1 + target/s390x/tcg/insn-data.def | 30 +-- target/s390x/tcg/mem_helper.c | 20

[PATCH v4 0/3] s390x: Add partial z15 support and tests

into series. David Miller (3): s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1 tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3 hw/s390x/s390-virtio-ccw

[PATCH v5 2/3] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1

TCG implements everything we need to run basic z15 OS+software Signed-off-by: David Miller --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 6 +++--- target/s390x/gen-features.c | 7 +-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/s390x/s390

Re: [PATCH v4 3/3] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

/tests/tcg/s390x/Makefile.target new file: ../tests/tcg/s390x/mie3-compl.c new file: ../tests/tcg/s390x/mie3-mvcrl.c new file: ../tests/tcg/s390x/mie3-sel.c On Wed, Feb 16, 2022 at 3:13 PM David Hildenbrand wrote: > > On 16.02.22 21:03, David Miller wrote: >

Re: [PATCH v7 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

Had it on my TODO list for this morning, thank you. On Mon, Feb 28, 2022 at 12:59 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 2/28/22 00:14, Thomas Huth wrote: > > Full patch can be seen here: > > > > https://gitlab.com/thuth/qemu/-/commit/38af118ea2fef0c473 > > > > static

[PATCH v6 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

tests/tcg/s390x/mie3-compl.c: [N]*K instructions tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction tests/tcg/s390x/mie3-sel.c: SELECT instruction Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 5 ++- tests/tcg/s390x/mie3-compl.c| 55

[PATCH v6 4/4] tests/tcg/s390x: changed to using .insn for tests requiring z15

Signed-off-by: David Miller --- tests/tcg/s390x/mie3-compl.c | 21 +++-- tests/tcg/s390x/mie3-mvcrl.c | 2 +- tests/tcg/s390x/mie3-sel.c | 6 +++--- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/tests/tcg/s390x/mie3-compl.c b/tests/tcg/s390x/mie3-compl.c

[PATCH v6 1/4] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

HIGH (SELFHR) MOVE RIGHT TO LEFT(MVCRL) POPULATION COUNT (POPCNT) Signed-off-by: David Miller --- target/s390x/gen-features.c| 1 + target/s390x/helper.h | 1 + target/s390x/tcg/insn-data.def | 30 +-- target/s390x/tcg/mem_helper.c | 20

[PATCH v6 2/4] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1

TCG implements everything we need to run basic z15 OS+software Signed-off-by: David Miller --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 6 +++--- target/s390x/gen-features.c | 7 +-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/s390x/s390

[PATCH v6 0/4] s390x: Add partial z15 support and tests

dundant code op_sel -> op_loc * Cleanup for checkpatch.pl * Readded mie3-* to Makefile.target v2 -> v3: * Moved tests to separate patch. * Combined patches into series. David Miller (4): s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x s390x/cpum

[PATCH v3 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

HIGH (SELFHR) MOVE RIGHT TO LEFT(MVCRL) POPULATION COUNT (POPCNT) Signed-off-by: David Miller --- target/s390x/gen-features.c| 1 + target/s390x/helper.h | 1 + target/s390x/tcg/insn-data.def | 30 -- target/s390x/tcg/mem_helper.c | 20

[PATCH v3 2/3] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1

TCG implements everything we need to run basic z15 OS+software. Signed-off-by: David Miller --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 6 +++--- target/s390x/gen-features.c | 7 +-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/s390x/s390

[PATCH v3 0/3] s390x: Add partial z15 support and tests

Add partial support for s390x z15 ga1 and specific tests for minste3 v2 -> v3: * Moved tests to separate patch. * Combined patches into series. David Miller (3): s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x s390x/cpumodel: Bump up QEMU mo

[PATCH v3 3/3] s390x/tcg/tests: Tests for Miscellaneous-Instruction-Extensions Facility 3

tests/tcg/s390x/mie3-compl.c: [N]*K instructions tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction tests/tcg/s390x/mie3-sel.c: SELECT instruction Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 2 +- tests/tcg/s390x/mie3-compl.c| 56

Re: [PATCH v6 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

ed, both gcc and clang assemble multiple 'asm' statements into a single block as long as there are no C statements between. I'm happy to change it. On Wed, Feb 23, 2022 at 2:45 PM Richard Henderson wrote: > > On 2/17/22 13:17, David Miller wrote: > > +#define F_PROasm ( \ &

Re: [PATCH v6 1/4] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

> Bit 0 controls this, and recall that IBM uses big-bit numbering, so "8". > This stores the low part of r[23] in the high part of r1. > You need to select the high part of r[23]. good catch, these are both fixed will update patch shortly. Thanks for the review - David Mil

Re: [PATCH] tests/tcg/s390x: Cleanup of mie3 tests.

Please disregard, v2 sent. On Tue, Mar 1, 2022 at 2:15 PM David Miller wrote: > Adds clobbers and merges remaining separate asm statements. > > Signed-off-by: David Miller > --- > tests/tcg/s390x/mie3-compl.c | 42 +++- > tests/tcg/s390x

[PATCH v2] tests/tcg/s390x: Cleanup of mie3 tests.

Adds clobbers and merges remaining separate asm statements. v1 -> v2: * Corrected side in rebase conflict, removing older code. Signed-off-by: David Miller --- tests/tcg/s390x/mie3-compl.c | 18 +++- tests/tcg/s390x/mie3-mvcrl.c | 12 +++ tests/tcg/s390x/mie3-sel.c |

Re: [PATCH v2] tests/tcg/s390x: Cleanup of mie3 tests.

I used #define Fi3(S, ASM) uint64_t S(uint64_t a, uint64_t b, uint64_t c) \ { \ uint64_t res = 0; \ asm volatile ( \ "ltgr %[c], %[c]\n" \ ASM \ "stg %[c], %[res] " \ : [res] "=" (res) \ : [a] "r" (a), \ [b] "r"

[PATCH] tests/tcg/s390x: Cleanup of mie3 tests.

Adds clobbers and merges remaining separate asm statements. Signed-off-by: David Miller --- tests/tcg/s390x/mie3-compl.c | 42 +++- tests/tcg/s390x/mie3-mvcrl.c | 12 +++ tests/tcg/s390x/mie3-sel.c | 40 ++ 3 files

Re: [PATCH v2] tests/tcg/s390x: Cleanup of mie3 tests.

However the constraint must be wrong there. Sorry about split message. On Tue, Mar 1, 2022 at 3:21 PM David Miller wrote: > I used > > > #define Fi3(S, ASM) uint64_t S(uint64_t a, uint64_t b, uint64_t c) \ > { \ > uint64_t res = 0;

[PATCH v3] tests/tcg/s390x: Cleanup of mie3 tests.

Adds clobbers and merges remaining separate asm statements. v2 -> v3: * Removed all direct memory references in mie3-sel.c v1 -> v2: * Corrected side in rebase conflict, removing older code. Signed-off-by: David Miller --- tests/tcg/s390x/mie3-compl.c | 18 - tests/tcg

Re: [PATCH v7 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

>On 28/02/2022 19.31, David Miller wrote: > > Had it on my TODO list for this morning, thank you. > Thanks! Please send it as additional patch on top of my s390x-next, since I > already sent a pull request for the other patches yesterday: > > https://gitlab.com/thuth/qemu

[PATCH v1 0/2] s390x: Add support for Vector Enhancements Facility 2

Extend s390x z15 to support and test Vector Enhancements Facility 2 (vxeh2) David Miller (2): s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x tests/tcg/s390x: Tests for Vector Enhancements Facility 2 include/qemu/bitops.h| 26 ++ target/s390x/gen-features.c

[PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

(VCLFP) VECTOR SHIFT LEFT (VSL) VECTOR SHIFT RIGHT ARITHMETIC (VSRA) VECTOR SHIFT RIGHT LOGICAL (VSRL) Signed-off-by: David Miller --- include/qemu/bitops.h| 26 ++ target/s390x/gen-features.c | 2 +- target/s390x

[PATCH v1 2/2] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

tests/tcg/s390x/vxeh2_vcvt.c tests/tcg/s390x/vxeh2_vs.c tests/tcg/s390x/vxeh2_vlstr.c Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 8 ++ tests/tcg/s390x/vxeh2_vcvt.c| 97 + tests/tcg/s390x/vxeh2_vlstr.c | 146

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

sting code flow. Thanks - David Miller On Thu, Mar 3, 2022 at 3:58 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 3/2/22 17:22, David Miller wrote: > > resolves: https://gitlab.com/qemu-project/qemu/-/issues/738 > > > > implements: > > VECTOR LO

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

Makes sense, thanks for the quick reply. Last question, the patches can depend on others in the same set right? IE: all of the additions to insn-data.def in one, implementations in separate patches. Thanks - David Miller On Thu, Mar 3, 2022 at 12:42 PM Richard Henderson < richard.hen

Re: [PATCH v6 1/4] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

Yes I'm adding to this patch, I haven't quite figured out where to put them, they are inline to various things in the patch themselves so I'm putting in the cover letter under the patch they go to. I hope that's correct. Thanks - David Miller On Wed, Feb 23, 2022 at 8:40 AM Christian

[PATCH v7 0/4] s390x: Add partial z15 support and tests

d patches into series. David Miller (4): s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x * Reviewed-by: David Hildenbrand s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1 * Reviewed-by: David Hildenbrand tests/tcg/s390x: Te

[PATCH v7 2/4] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1

TCG implements everything we need to run basic z15 OS+software Signed-off-by: David Miller --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 6 +++--- target/s390x/gen-features.c | 7 +-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/s390x/s390

[PATCH v7 4/4] tests/tcg/s390x: changed to using .insn for tests requiring z15

Signed-off-by: David Miller --- tests/tcg/s390x/mie3-compl.c | 21 +++-- tests/tcg/s390x/mie3-mvcrl.c | 2 +- tests/tcg/s390x/mie3-sel.c | 6 +++--- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/tests/tcg/s390x/mie3-compl.c b/tests/tcg/s390x/mie3-compl.c

[PATCH v7 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

tests/tcg/s390x/mie3-compl.c: [N]*K instructions tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction tests/tcg/s390x/mie3-sel.c: SELECT instruction Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 5 ++- tests/tcg/s390x/mie3-compl.c| 55

[PATCH v7 1/4] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

HIGH (SELFHR) MOVE RIGHT TO LEFT(MVCRL) POPULATION COUNT (POPCNT) Signed-off-by: David Miller --- target/s390x/gen-features.c| 1 + target/s390x/helper.h | 1 + target/s390x/tcg/insn-data.def | 30 +++-- target/s390x/tcg/mem_helper.c | 20

[PATCH v4 00/11] s390x/tcg: Implement Vector-Enhancements Facility 2

(VCFPL) VECTOR FP CONVERT TO FIXED (VCSFP) VECTOR FP CONVERT TO LOGICAL(VCLFP) VECTOR SHIFT LEFT (VSL) VECTOR SHIFT RIGHT ARITHMETIC (VSRA) VECTOR SHIFT RIGHT LOGICAL (VSRL) David

[PATCH v4 05/11] target/s390x: vxeh2: vector shift double by bit

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- target/s390x/tcg/insn-data.def | 6 +++- target/s390x/tcg/translate_vx.c.inc | 55 + 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/target/s390x/tcg/insn-data.def b/target/s390x

[PATCH v4 01/11] tcg: Implement tcg_gen_{h,w}swap_{i32,i64}

From: Richard Henderson Swap half-words (16-bit) and words (32-bit) within a larger value. Mirrors functions of the same names within include/qemu/bitops.h. Signed-off-by: Richard Henderson Reviewed-by: David Miller Reviewed-by: David Hildenbrand --- include/tcg/tcg-op.h | 6 ++ tcg

[PATCH v4 03/11] target/s390x: vxeh2: vector string search

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- target/s390x/helper.h| 6 ++ target/s390x/tcg/insn-data.def | 2 + target/s390x/tcg/translate.c | 3 +- target/s390x/tcg/translate_vx.c.inc | 25 +++ target/s390x/tcg/vec_string_helper.c | 99

[PATCH v4 08/11] target/s390x: vxeh2: vector {load, store} byte reversed element

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/tcg/insn-data.def | 12 target/s390x/tcg/translate_vx.c.inc | 85 + 2 files changed, 97 insertions(+) diff --git a/target/s390x/tcg/insn-data.def

[PATCH v4 09/11] target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- target/s390x/gen-features.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 22846121c4..499a3b10a8 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x

[PATCH v4 07/11] target/s390x: vxeh2: vector {load, store} byte reversed elements

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- target/s390x/tcg/insn-data.def | 4 + target/s390x/tcg/translate_vx.c.inc | 115 2 files changed, 119 insertions(+) diff --git a/target/s390x/tcg/insn-data.def b/target/s390x/tcg/insn-data.def

[PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- tests/tcg/s390x/Makefile.target | 8 ++ tests/tcg/s390x/vxeh2_vcvt.c| 97 + tests/tcg/s390x/vxeh2_vlstr.c | 146 tests/tcg/s390x/vxeh2_vs.c | 91

[PATCH v4 04/11] target/s390x: vxeh2: Update for changes to vector shifts

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- target/s390x/helper.h | 3 ++ target/s390x/tcg/insn-data.def | 12 ++--- target/s390x/tcg/translate_vx.c.inc | 75 - target/s390x/tcg/vec_int_helper.c | 55 + 4

[PATCH v4 06/11] target/s390x: vxeh2: vector {load, store} elements reversed

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/tcg/insn-data.def | 4 ++ target/s390x/tcg/translate_vx.c.inc | 84 + 2 files changed, 88 insertions(+) diff --git a/target/s390x/tcg/insn-data.def b

[PATCH v4 02/11] target/s390x: vxeh2: vector convert short/32b

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/helper.h | 4 +++ target/s390x/tcg/translate_vx.c.inc | 44 ++--- target/s390x/tcg/vec_fpu_helper.c | 31 3 files changed

[PATCH v4 11/11] target/s390x: Fix writeback to v1 in helper_vstl

From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: David Miller Reviewed-by: David Hildenbrand --- target/s390x/tcg/vec_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c index ededf13cf0..48d86722b2

Re: [PATCH v3 00/11] s390x/tcg: Implement Vector-Enhancements Facility 2

Is this waiting on me for anything? I wanted to ensure this is wrapped up before starting a new project. Thanks, - David Miller On Mon, Mar 7, 2022 at 11:09 PM David Miller wrote: > > > I've reviewed all changes, looks good. > Ran all of my own tests including vstrs, all passed. &

[PATCH v5 08/11] target/s390x: vxeh2: vector {load, store} byte reversed element

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/tcg/insn-data.def | 12 target/s390x/tcg/translate_vx.c.inc | 85 + 2 files changed, 97 insertions(+) diff --git a/target/s390x/tcg/insn-data.def

[PATCH v5 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- tests/tcg/s390x/Makefile.target | 8 ++ tests/tcg/s390x/vx.h| 19 + tests/tcg/s390x/vxeh2_vcvt.c| 88 tests/tcg/s390x/vxeh2_vlstr.c | 139 tests/tcg

[PATCH v5 09/11] target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- target/s390x/gen-features.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 22846121c4..499a3b10a8 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x

[PATCH v5 04/11] target/s390x: vxeh2: Update for changes to vector shifts

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/helper.h | 3 ++ target/s390x/tcg/insn-data.def | 12 ++--- target/s390x/tcg/translate_vx.c.inc | 75 - target/s390x/tcg/vec_int_helper.c

[PATCH v5 06/11] target/s390x: vxeh2: vector {load, store} elements reversed

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/tcg/insn-data.def | 4 ++ target/s390x/tcg/translate_vx.c.inc | 84 + 2 files changed, 88 insertions(+) diff --git a/target/s390x/tcg/insn-data.def b

[PATCH v5 11/11] target/s390x: Fix writeback to v1 in helper_vstl

From: Richard Henderson Fixes: 0e0a5b49ad58 ("s390x/tcg: Implement VECTOR STORE WITH LENGTH") Signed-off-by: Richard Henderson Reviewed-by: David Miller Reviewed-by: David Hildenbrand --- target/s390x/tcg/vec_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target

[PATCH v5 05/11] target/s390x: vxeh2: vector shift double by bit

Signed-off-by: David Miller Signed-off-by: Richard Henderson --- target/s390x/tcg/insn-data.def | 6 +++- target/s390x/tcg/translate_vx.c.inc | 55 + 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/target/s390x/tcg/insn-data.def b/target/s390x

[PATCH v5 03/11] target/s390x: vxeh2: vector string search

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/helper.h| 6 ++ target/s390x/tcg/insn-data.def | 2 + target/s390x/tcg/translate.c | 3 +- target/s390x/tcg/translate_vx.c.inc | 25 +++ target

[PATCH v5 02/11] target/s390x: vxeh2: vector convert short/32b

Signed-off-by: David Miller Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/helper.h | 4 +++ target/s390x/tcg/translate_vx.c.inc | 44 ++--- target/s390x/tcg/vec_fpu_helper.c | 31 3 files changed

[PATCH v5 01/11] tcg: Implement tcg_gen_{h,w}swap_{i32,i64}

From: Richard Henderson Swap half-words (16-bit) and words (32-bit) within a larger value. Mirrors functions of the same names within include/qemu/bitops.h. Signed-off-by: Richard Henderson Reviewed-by: David Miller Reviewed-by: David Hildenbrand --- include/tcg/tcg-op.h | 6 ++ tcg

[PATCH v5 00/11] s390x/tcg: Implement Vector-Enhancements Facility 2

(VCFPL) VECTOR FP CONVERT TO FIXED (VCSFP) VECTOR FP CONVERT TO LOGICAL(VCLFP) VECTOR SHIFT LEFT (VSL) VECTOR SHIFT RIGHT ARITHMETIC (VSRA) VECTOR SHIFT RIGHT LOGICAL (VSRL) David

[PATCH v5 07/11] target/s390x: vxeh2: vector {load, store} byte reversed elements

Signed-off-by: David Miller Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand --- target/s390x/tcg/insn-data.def | 4 + target/s390x/tcg/translate_vx.c.inc | 113 2 files changed, 117 insertions(+) diff --git a/target/s390x/tcg/insn-data.def b

Re: [PATCH v5 09/11] target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model

I am sending v5 now as I'm away from my desk until Sunday. As I'm unsure whether or not this just needs a V7_0 and the patch shown as an example isn't a direct correlation : I've left it out for now. I will dig into it further Monday March 28th. Thanks - David Miller On Wed, Mar 23, 2022 at 9:57

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

Sorry, Didn't notice this, as it was on v4 patch emails. I assume since there is no other follow up after a week, CI jobs are not being updated and I should change samples to use .insn. I will try to get this out tomorrow. Thanks, - David Miller On Wed, Mar 23, 2022 at 1:13 PM Thomas Huth

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

On Thu, Mar 31, 2022 at 10:15 PM David Miller wrote: > > Hi, > > There is some issue with instruction sub/alt encodings not matching, > but I worked around it easily. > > I'm dropping the updated patch for the tests in here. > I know I should resend the entire patch se

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

%[v1], %[v2], %[v3], 0, %[I], 0\n" : [v1] "=v" (v1->v) : [v2] "v" (v2->v) , [v3] "v" (v3->v) , [I] "i" (I & 7)); Patch is attached Thanks - David Miller On Thu, Mar 31, 202

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

wrote: > > > > Am 01.04.22 um 04:15 schrieb David Miller: > > Hi, > > > > There is some issue with instruction sub/alt encodings not matching, > > but I worked around it easily. > > > > I'm dropping the updated patch for the tests in here. > > I kn

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

Hildenbrand wrote: > > On 01.04.22 17:25, Christian Borntraeger wrote: > > Am 01.04.22 um 17:02 schrieb David Miller: > >> vrr is almost a perfect match (it is for this, larger than imm4 would > >> need to be split). > >> > >> .long : this would b

Re: [PATCH v3 03/11] target/s390x: vxeh2: vector string search

I came to much the same conclusion On Tue, Mar 22, 2022 at 10:42 AM Richard Henderson wrote: > > On 3/21/22 03:31, David Hildenbrand wrote: > >> +for (i = 0; i < nelem; i++) { > >> +if (s390_vec_read_element(v3, i, es) == 0) { > >> +break; > >> +}

  1   2   >