feature compression type
backing_file_offset += 56 (8 + 48 -> header_change + feature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 144, 182, 242, 255
Signed-off-by: Denis Plotnikov
Reviewed
ir]
* remove unnecessry casting [Eric]
* remove rudundant checks [Eric]
* fix compressed cluster layout in qcow2 spec [Vladimir]
* fix wording [Eric, Vladimir]
* fix compression type filtering in iotests [Eric]
v1:
the initial series
Denis Plotnikov (4):
qcow2: introduce
Thanks for the comments.
I'll make the fixes accordingly and re-sent the series shortly.
Denis
On 14.03.2020 00:40, Eric Blake wrote:
On 3/12/20 4:22 AM, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different
size in both cases: 1.4G
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
QAPI part:
Acked-by: Markus Armbruster
---
docs/interop/qcow2.txt | 20 +++
configure | 2 +-
qapi/block-core.json | 3 +-
block/qcow2-threads.c
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/287 | 128 +
tests/qemu-iotests/287.out
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/qcow2-threads.c | 71
size in both cases: 1.4G
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
QAPI part:
Acked-by: Markus Armbruster
---
docs/interop/qcow2.txt | 20 +++
configure | 2 +-
qapi/block-core.json | 3 +-
block/qcow2-threads.c
: incompatible feture compression type
backing_file_offset += 56 (8 + 48 -> header_change + fature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 144, 182, 242, 255
Signed-off-by: Denis Plotnikov
Reviewed
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/qcow2-threads.c | 71
layout in qcow2 spec [Vladimir]
* fix wording [Eric, Vladimir]
* fix compression type filtering in iotests [Eric]
v1:
the initial series
Denis Plotnikov (4):
qcow2: introduce compression type feature
qcow2: rework the cluster compression routine
qcow2: add zstd cluster compression
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/287 | 128 +
tests/qemu-iotests/287.out
:35, Denis Plotnikov wrote:
v5:
* replace -ENOTSUP with abort in qcow2_co_decompress [Vladimir]
* set cluster size for all test cases in the beginning of the 287 test
v4:
* the series is rebased on top of 01 "block/qcow2-threads: fix
qcow2_decompress"
* 01 is just a
: incompatible feture compression type
backing_file_offset += 56 (8 + 48 -> header_change + fature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 144, 182, 242, 255
Signed-off-by: Denis Plotnikov
Reviewed
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/287 | 128 +
tests/qemu-iotests/287.out
size in both cases: 1.4G
Signed-off-by: Denis Plotnikov
QAPI part:
Acked-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/interop/qcow2.txt | 20 +++
configure | 2 +-
qapi/block-core.json | 3 +-
block/qcow2-threads.c | 123
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-threads.c | 71
ic]
v1:
the initial series
Denis Plotnikov (4):
qcow2: introduce compression type feature
qcow2: rework the cluster compression routine
qcow2: add zstd cluster compression
iotests: 287: add qcow2 compression type test
Vladimir Sementsov-Ogievskiy (1):
block/qcow2-threads: fix qcow2_decom
From: Vladimir Sementsov-Ogievskiy
On success path we return what inflate() returns instead of 0. And it
most probably works for Z_STREAM_END as it is positive, but is
definitely broken for Z_BUF_ERROR.
While being here, switch to errno return code, to be closer to
qcow2_compress API (and usual
On 04.03.2020 14:27, Vladimir Sementsov-Ogievskiy wrote:
03.03.2020 16:34, Denis Plotnikov wrote:
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/287 | 127
On 04.03.2020 10:49, Vladimir Sementsov-Ogievskiy wrote:
03.03.2020 16:34, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment
size in both cases: 1.4G
Signed-off-by: Denis Plotnikov
---
docs/interop/qcow2.txt | 20 +++
configure | 2 +-
qapi/block-core.json | 3 +-
block/qcow2-threads.c | 123 +
block/qcow2.c | 7 +++
5 files changed, 153
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/287 | 127 +
tests/qemu-iotests/287.out | 43 +
tests/qemu-iotests
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
---
block/qcow2-threads.c | 71 ---
1 file changed, 60 insertions(+), 11
From: Vladimir Sementsov-Ogievskiy
On success path we return what inflate() returns instead of 0. And it
most probably works for Z_STREAM_END as it is positive, but is
definitely broken for Z_BUF_ERROR.
While being here, switch to errno return code, to be closer to
qcow2_compress API (and usual
: incompatible feture compression type
backing_file_offset += 56 (8 + 48 -> header_change + fature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 144, 182, 242, 255
Signed-off-by: Denis Plotnikov
--
lable for clusters compression.
The implementation is done with respect to the recently added compression
type additional header to the qcow2 specification.
Denis Plotnikov (4):
qcow2: introduce compression type feature
qcow2: rework the cluster compression routine
qcow2: add zstd cluster compres
Package manager --exist flag is used instead of --exists.
Fix it.
Signed-off-by: Denis Plotnikov
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 7b373bc0bb..caa65f5883 100755
--- a/configure
+++ b/configure
@@ -2464,7 +2464,7 @@ fi
: incompatible feture compression type
backing_file_offset += 56 (8 + 48 -> header_change + fature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 144, 182, 242, 255
Signed-off-by: Denis Plotnikov
--
ethod is faster than the only available zlib.
The series adds zstd to the methods available for clusters compression.
The implementation is done with respect to the recently added compression
type additional header to the qcow2 specification.
Denis Plotnikov (4):
qcow2: introduce compression
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/287 | 127 +
tests/qemu-iotests/287.out | 43 +
tests/qemu-iotests
size in both cases: 1.4G
Signed-off-by: Denis Plotnikov
---
docs/interop/qcow2.txt | 20 +++
configure | 2 +-
qapi/block-core.json | 3 +-
block/qcow2-threads.c | 123 +
block/qcow2.c | 7 +++
5 files changed, 153
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
---
block/qcow2-threads.c | 77 +++
1 file changed, 63 insertions(+), 14
On 02.03.2020 16:38, Kevin Wolf wrote:
Am 10.11.2019 um 20:03 hat Denis Plotnikov geschrieben:
This allows to replace the file on a block device and is useful
to workaround the cases (migration) when the VM image is placed on
some shared storage with exclusive file opening model
On 02.03.2020 14:24, Vladimir Sementsov-Ogievskiy wrote:
02.03.2020 11:21, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied
On 02.03.2020 11:51, Vladimir Sementsov-Ogievskiy wrote:
Doesn't apply to master, as zstd already exists in ./configure :) (for
migration)
M, will rebase it. Any other comments?
02.03.2020 11:21, Denis Plotnikov wrote:
v2:
* rework compression type setting [Vladimir]
* squash
: incompatible feture compression type
backing_file_offset += 56 (8 + 48 -> header_change + fature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 144, 182, 242, 255
Signed-off-by: Denis Plotnikov
--
.
The implementation is done with respect to the recently added compression
type additional header to the qcow2 specification.
Denis Plotnikov (4):
qcow2: introduce compression type feature
qcow2: rework the cluster compression routine
qcow2: add zstd cluster compression
iotests: 287: add qcow2 compression
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
---
block/qcow2-threads.c | 77 +++
1 file changed, 63 insertions(+), 14
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/287 | 127 +
tests/qemu-iotests/287.out | 43 +
tests/qemu-iotests
size in both cases: 1.4G
Signed-off-by: Denis Plotnikov
---
docs/interop/qcow2.txt | 20 +++
configure | 29 ++
qapi/block-core.json | 3 +-
block/qcow2-threads.c | 120 +
block/qcow2.c | 7 +++
5 files changed, 178
On 27.02.2020 17:18, Vladimir Sementsov-Ogievskiy wrote:
27.02.2020 17:11, Denis Plotnikov wrote:
On 27.02.2020 12:55, Vladimir Sementsov-Ogievskiy wrote:
27.02.2020 10:29, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression
On 27.02.2020 17:03, Eric Blake wrote:
On 2/27/20 1:29 AM, Denis Plotnikov wrote:
After adding compression type feature to qcow2 format, qemu framework
commands reporting the image settingd, e.g. "qemu-img create", started
settings
reporting the compression type for the i
On 27.02.2020 17:01, Eric Blake wrote:
On 2/27/20 1:29 AM, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment, is the only
On 27.02.2020 16:48, Eric Blake wrote:
On 2/27/20 1:29 AM, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to Qcow2 that indicates which allow to use different compression
to qcow2, allowing the use of different
methods for image
On 27.02.2020 13:29, Vladimir Sementsov-Ogievskiy wrote:
27.02.2020 10:29, Denis Plotnikov wrote:
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/287 | 123
On 27.02.2020 13:09, Vladimir Sementsov-Ogievskiy wrote:
27.02.2020 13:04, Vladimir Sementsov-Ogievskiy wrote:
27.02.2020 10:29, Denis Plotnikov wrote:
Affected tests: 049, 060, 061, 065, 144, 182, 242, 255
After adding the compression type feature for qcow2, the compression
type
On 27.02.2020 12:55, Vladimir Sementsov-Ogievskiy wrote:
27.02.2020 10:29, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment
Affected tests: 049, 060, 061, 065, 144, 182, 242, 255
After adding the compression type feature for qcow2, the compression type
is reported on image quering.
Add the corresponding values of the "compression type" for the tests' output
matching.
Signed-off-by: Denis Plotnikov
---
+ 48 -> header_change + fature_table_change)
Change the values for the test output comparison accordingly.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/031.out | 14 +++---
tests/qemu-iotests/036.out | 4 ++--
tests/qemu-iotests/061.out | 28 ++--
3 fi
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
---
block/qcow2-threads.c | 77 +++
1 file changed, 63 insertions(+), 14
ered image parameters.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/common.filter | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index 3f8ee3e5f7..c6962d199c 100644
--- a/tests/qemu-iotests/common.fi
zstd comression method is faster than the only available zlib.
The series adds zstd to the methods available for clusters compression.
The implementation is done with respect to the recently added compression
type additional header to the qcow2 specification.
Denis Plotnikov (8):
qcow2
size in both cases: 1.4G
Signed-off-by: Denis Plotnikov
---
block/qcow2-threads.c | 122 +
block/qcow2.c | 7 +++
configure | 29 ++
docs/interop/qcow2.txt | 18 ++
qapi/block-core.json | 3 +-
5 files changed, 178
compression is ZLIB. Images created with ZLIB compression type
are backward compatible with older qemu versions.
Signed-off-by: Denis Plotnikov
---
block/qcow2.c | 105 ++
block/qcow2.h | 31 ---
include/block/block_int.h | 1 +
qapi
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/080 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/080 b/tests/qemu-iotests/080
index a3d13c414e..7588c63b6c 100755
--- a/tests/qemu-iotests/080
+++ b/tests/qemu-iotests/080
@@ -45,7 +45,7
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
---
tests/qemu-iotests/287 | 123 +
tests/qemu-iotests/287.out | 41 +
tests/qemu-iotests
On 18.02.2020 16:59, Denis Plotnikov wrote:
On 18.02.2020 16:53, Stefan Hajnoczi wrote:
On Thu, Feb 13, 2020 at 05:59:27PM +0300, Denis Plotnikov wrote:
v1:
* seg_max default value changing removed
---
The goal is to reduce the amount of requests issued by a guest on
1M reads/writes
On 18.02.2020 16:53, Stefan Hajnoczi wrote:
On Thu, Feb 13, 2020 at 05:59:27PM +0300, Denis Plotnikov wrote:
v1:
* seg_max default value changing removed
---
The goal is to reduce the amount of requests issued by a guest on
1M reads/writes. This rises the performance up to 4
://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html
Suggested-by: Denis V. Lunev
Signed-off-by: Denis Plotnikov
---
v3:
* typos fixed
v2:
* seg_max default value changing removed
---
hw/block/virtio-blk.c | 2 +-
hw/core/machine.c | 2 ++
hw/scsi/virtio-scsi.c | 2 +-
3 files changed, 4
in the original problem statment:
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html
Suggested-by: Denis V. Lunev
Signed-off-by: Denis Plotnikov
---
hw/block/virtio-blk.c | 2 +-
hw/core/machine.c | 2 ++
hw/scsi/virtio-scsi.c | 2 +-
3 files changed, 4 insertions(+), 2
On 13.02.2020 14:45, Stefan Hajnoczi wrote:
On Thu, Feb 13, 2020 at 12:28:25PM +0300, Denis Plotnikov wrote:
On 13.02.2020 12:08, Stefan Hajnoczi wrote:
On Thu, Feb 13, 2020 at 11:08:35AM +0300, Denis Plotnikov wrote:
On 12.02.2020 18:43, Stefan Hajnoczi wrote:
On Tue, Feb 11, 2020 at 05
On 13.02.2020 12:08, Stefan Hajnoczi wrote:
On Thu, Feb 13, 2020 at 11:08:35AM +0300, Denis Plotnikov wrote:
On 12.02.2020 18:43, Stefan Hajnoczi wrote:
On Tue, Feb 11, 2020 at 05:14:14PM +0300, Denis Plotnikov wrote:
The goal is to reduce the amount of requests issued by a guest on
1M
On 12.02.2020 18:43, Stefan Hajnoczi wrote:
On Tue, Feb 11, 2020 at 05:14:14PM +0300, Denis Plotnikov wrote:
The goal is to reduce the amount of requests issued by a guest on
1M reads/writes. This rises the performance up to 4% on that kind of
disk access pattern.
The maximum chunk size
On 11.02.2020 17:37, Philippe Mathieu-Daudé wrote:
Hi Denis,
On 2/11/20 3:25 PM, Denis Plotnikov wrote:
* fixed failing on non-existed machine type removal
* the test refactored to add more parameters to check
Gereral questions left:
How to restric test for using:
1. on a set
* fixed failing on non-existed machine type removal
* the test refactored to add more parameters to check
Gereral questions left:
How to restric test for using:
1. on a set of target OS-es
2. on a set target architectures
Denis Plotnikov (2):
tests/acceptance/virtio_check_params
Signed-off-by: Denis Plotnikov
---
tests/acceptance/virtio_check_params.py | 38 ++---
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/tests/acceptance/virtio_check_params.py
b/tests/acceptance/virtio_check_params.py
index deec89bf86..e578952a97 100644
Before, the test failed if an excluded machine type was absent in the machine
types lists.
Signed-off-by: Denis Plotnikov
---
tests/acceptance/virtio_check_params.py | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tests/acceptance/virtio_check_params.py
b
://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html
Suggested-by: Denis V. Lunev
Signed-off-by: Denis Plotnikov
---
hw/block/virtio-blk.c | 4 ++--
hw/core/machine.c | 2 ++
hw/scsi/virtio-scsi.c | 4 ++--
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw
vhost-blk-device isn't a part of qemu.git
Signed-off-by: Denis Plotnikov
---
hw/core/machine.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index d8e30e4895..2501b540ec 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -31,7 +31,6
On 09.02.2020 10:49, Michael S. Tsirkin wrote:
On Fri, Feb 07, 2020 at 11:48:05AM +0300, Denis Plotnikov wrote:
On 05.02.2020 14:19, Stefan Hajnoczi wrote:
On Tue, Feb 04, 2020 at 12:59:04PM +0300, Denis Plotnikov wrote:
On 30.01.2020 17:58, Stefan Hajnoczi wrote:
On Wed, Jan 29, 2020
On 05.02.2020 14:19, Stefan Hajnoczi wrote:
On Tue, Feb 04, 2020 at 12:59:04PM +0300, Denis Plotnikov wrote:
On 30.01.2020 17:58, Stefan Hajnoczi wrote:
On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote:
The goal is to reduce the amount of requests issued by a guest on
1M
On 30.01.2020 17:58, Stefan Hajnoczi wrote:
On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote:
The goal is to reduce the amount of requests issued by a guest on
1M reads/writes. This rises the performance up to 4% on that kind of
disk access pattern.
The maximum chunk size
On 03.02.2020 15:51, Michael S. Tsirkin wrote:
On Mon, Feb 03, 2020 at 03:17:07PM +0300, Denis Plotnikov wrote:
On 30.01.2020 16:38, Michael S. Tsirkin wrote:
On Wed, Jan 29, 2020 at 05:06:59PM +0300, Denis Plotnikov wrote:
Signed-off-by: Denis Plotnikov
I'm not sure what the point
On 30.01.2020 16:42, Michael S. Tsirkin wrote:
On Wed, Jan 29, 2020 at 05:07:01PM +0300, Denis Plotnikov wrote:
This is due to the change in the default virtqueue_size in the
latest machine type to improve guest disks performance.
Sorry what is due to the change?
Signed-off-by: Denis
On 30.01.2020 16:40, Michael S. Tsirkin wrote:
On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote:
The goal is to reduce the amount of requests issued by a guest on
1M reads/writes. This rises the performance up to 4% on that kind of
disk access pattern.
The maximum chunk size
On 30.01.2020 16:38, Michael S. Tsirkin wrote:
On Wed, Jan 29, 2020 at 05:06:59PM +0300, Denis Plotnikov wrote:
Signed-off-by: Denis Plotnikov
I'm not sure what the point is. It's more or less an accident that
these two devices share the queue size, this constance
makes no sense to me
On 30.01.2020 17:56, Stefan Hajnoczi wrote:
On Wed, Jan 29, 2020 at 06:55:18PM +0100, Cornelia Huck wrote:
On Wed, 29 Jan 2020 17:06:59 +0300
Denis Plotnikov wrote:
Signed-off-by: Denis Plotnikov
---
hw/block/virtio-blk.c | 6 --
hw/scsi/virtio-scsi.c | 5 +++--
include
/archive/html/qemu-devel/2017-12/msg03721.html
Suggested-by: Denis V. Lunev
Signed-off-by: Denis Plotnikov
---
hw/core/machine.c | 3 +++
include/hw/virtio/virtio.h | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index
The goal is to increase the performance of the block layer on
1M reads/writes up to 4% by reducing the amount of requests issued by a guest
using virtio-scsi or virtio-blk devices.
Original problem description:
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html
Denis Plotnikov
This is due to the change in the default virtqueue_size in the
latest machine type to improve guest disks performance.
Signed-off-by: Denis Plotnikov
---
tests/acceptance/virtio_seg_max_adjust.py | 33 ++-
1 file changed, 21 insertions(+), 12 deletions(-)
diff --git a/tests
Signed-off-by: Denis Plotnikov
---
hw/block/virtio-blk.c | 6 --
hw/scsi/virtio-scsi.c | 5 +++--
include/hw/virtio/virtio.h | 1 +
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 09f46ed85f..72f935033f 100644
Since, virtio_seg_max_adjust checks not only seg_max, but also
virtqueue_size parameter, let's make the test more general and
add new parameters to be checked there in the future.
Signed-off-by: Denis Plotnikov
---
.../{virtio_seg_max_adjust.py => virtio_check_params.py} | 0
1 f
Hi, Juan
I'll read the series soon. Thanks for sending that to me!
Denis
On 24.01.2020 15:43, Juan Quintela wrote:
> Denis Plotnikov wrote:
>> zstd date compression algorithm shows better performance on data compression.
>> It might be useful to employ the algorithm in VM migr
Some guests read back queue size after writing it.
Always update the on size write otherwise they might be confused.
Signed-off-by: Denis Plotnikov
---
hw/virtio/virtio-mmio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
On 23.12.2019 17:31, Michael S. Tsirkin wrote:
> On Mon, Dec 23, 2019 at 02:37:58PM +0300, Denis Plotnikov wrote:
>> Currenly, the virtqueue size is saved to the proxy on pci writing and
>> is read from the device pci reading.
>> The virtqueue size is propagated la
1. virtqueue_size is a power of 2
2. virtqueue_size > 2, since seg_max is virtqueue_size - 2
Signed-off-by: Denis Plotnikov
---
hw/virtio/virtio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 04716b5f6c..e3ab69061e 100
evice right
away, so the written value could be read on the next step, if the value was
ok for the device.
Suggested-by: Roman Kagan
Suggested-by: Michael S. Tsirkin
Signed-off-by: Denis Plotnikov
---
hw/virtio/virtio-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio
5.0 machine type uses 4.2 compats. This seems to be incorrect, since
the latests machine type by now is 5.0 and it should use its own
compat or shouldn't use any relying on the defaults.
Seems, like this appeared because of some problems on merge/rebase.
Signed-off-by: Denis Plotnikov
---
hw
PLEASE, IGNORE THIS PATCH SET
On 20.12.2019 17:04, Denis Plotnikov wrote:
> v5:
>* rebased on the recent master [MST]
>* NOTE: the test doesn't pass because 5.0 machine type use 4.2 compat
>instead of it's own or no compat at all. The test will pass
>
old (seg_max = 126 always) and new (seg_max = queue_size - 2) behaviors.
Not to change the behavior of the older VMs, prevent setting the default
seg_max_adjust value for older machine types.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Denis Plotnikov
---
hw/block/virtio-blk.c | 9 ++
type [MST]
* add min queue size check [Stefan]
* add avocado based test [Max, Stefan, Eduardo, Cleber]
v2:
* the standalone patch to make seg_max virtqueue size dependent
* other patches are postponed
v1:
the initial series
Denis Plotnikov (2):
virtio: make seg_max virtqueue size
It tests proper seg_max_adjust settings for all machine types except
'none', 'isapc', 'microvm'
Signed-off-by: Denis Plotnikov
---
tests/acceptance/virtio_seg_max_adjust.py | 134 ++
1 file changed, 134 insertions(+)
create mode 100755 tests/acceptance
type [MST]
* add min queue size check [Stefan]
* add avocado based test [Max, Stefan, Eduardo, Cleber]
v2:
* the standalone patch to make seg_max virtqueue size dependent
* other patches are postponed
v1:
the initial series
Denis Plotnikov (2):
virtio: make seg_max virtqueue size
old (seg_max = 126 always) and new (seg_max = queue_size - 2) behaviors.
Not to change the behavior of the older VMs, prevent setting the default
seg_max_adjust value for older machine types.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Denis Plotnikov
---
hw/block/virtio-blk.c | 9 ++
It tests proper seg_max_adjust settings for all machine types except
'none', 'isapc', 'microvm'
Signed-off-by: Denis Plotnikov
---
tests/acceptance/virtio_seg_max_adjust.py | 134 ++
1 file changed, 134 insertions(+)
create mode 100755 tests/acceptance
On 16.12.2019 18:38, Kevin Wolf wrote:
> Am 16.12.2019 um 15:51 hat Denis Plotnikov geschrieben:
>> On 13.12.2019 13:32, Kevin Wolf wrote:
>>> Am 18.11.2019 um 11:50 hat Denis Plotnikov geschrieben:
>>>> Another problem here, is that the "size" of the dev
On 13.12.2019 13:32, Kevin Wolf wrote:
> Am 18.11.2019 um 11:50 hat Denis Plotnikov geschrieben:
>>
>> On 10.11.2019 22:08, Denis Plotnikov wrote:
>>> On 10.11.2019 22:03, Denis Plotnikov wrote:
>>>> This allows to change (replace) the file on a block dev
old (seg_max = 126 always) and new (seg_max = queue_size - 2) behaviors.
Not to change the behavior of the older VMs, prevent setting the default
seg_max_adjust value for older machine types.
Signed-off-by: Denis Plotnikov
---
hw/block/virtio-blk.c | 9 -
hw/core/machine.c
It tests proper seg_max_adjust settings for all machine types except
'none', 'isapc', 'microvm'
Signed-off-by: Denis Plotnikov
---
tests/acceptance/virtio_seg_max_adjust.py | 135 ++
1 file changed, 135 insertions(+)
create mode 100755 tests/acceptance
series
Denis Plotnikov (2):
virtio: make seg_max virtqueue size dependent
tests: add virtio-scsi and virtio-blk seg_max_adjust test
hw/block/virtio-blk.c | 9 +-
hw/core/machine.c | 3 +
hw/scsi/vhost-scsi.c | 2 +
hw/scsi
201 - 300 of 505 matches
Mail list logo
