[PING] [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-12-13 Thread Denis Plotnikov
On 05.12.2019 10:59, Denis Plotnikov wrote: > Ping! > > On 25.11.2019 12:16, Denis Plotnikov wrote: >> >> >> On 06.11.2019 15:03, Michael S. Tsirkin wrote: >>> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >>>> On 10/24/19 12:28 AM

[PING]Re: [PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-12-12 Thread Denis Plotnikov
On 18.11.2019 13:50, Denis Plotnikov wrote: > > > On 10.11.2019 22:08, Denis Plotnikov wrote: >> >> On 10.11.2019 22:03, Denis Plotnikov wrote: >>> This allows to change (replace) the file on a block device and is >>> useful >>> to wo

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-12-05 Thread Denis Plotnikov
Ping! On 25.11.2019 12:16, Denis Plotnikov wrote: > > > On 06.11.2019 15:03, Michael S. Tsirkin wrote: >> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >>> On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: >>>> On Fri, Oct 18, 2019 at 02:

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-25 Thread Denis Plotnikov
On 25.11.2019 18:30, Eduardo Habkost wrote: > On Fri, Nov 22, 2019 at 11:36:30AM +0000, Denis Plotnikov wrote: >> >> On 18.11.2019 21:54, Eduardo Habkost wrote: >>> On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: >>>> Some device's property c

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-25 Thread Denis Plotnikov
On 06.11.2019 15:03, Michael S. Tsirkin wrote: > On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >> On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: >>> On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: >>>> From: "Denis V. Lunev

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-22 Thread Denis Plotnikov
On 18.11.2019 21:54, Eduardo Habkost wrote: > On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: >> Some device's property can be changed if the device has been already >> realized. For example, it could be "drive" property of a scsi disk device. >&g

Re: [PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-11-18 Thread Denis Plotnikov
On 10.11.2019 22:08, Denis Plotnikov wrote: > > On 10.11.2019 22:03, Denis Plotnikov wrote: >> This allows to change (replace) the file on a block device and is useful >> to workaround exclusive file access restrictions, e.g. to implement VM >> migration with a shared dis

Re: [PATCH v0 0/2] allow to set 'drive' property on a realized block device

2019-11-18 Thread Denis Plotnikov
Ping! On 10.11.2019 22:03, Denis Plotnikov wrote: > This allows to replace the file on a block device and is useful > to workaround the cases (migration) when the VM image is placed on > some shared storage with exclusive file opening model but the image > should be open form more

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-14 Thread Denis Plotnikov
On 13.11.2019 16:18, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 12:38:48PM +0000, Denis Plotnikov wrote: >> >> On 06.11.2019 15:03, Michael S. Tsirkin wrote: >>> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >>>> On 10/24/1

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-13 Thread Denis Plotnikov
On 06.11.2019 15:03, Michael S. Tsirkin wrote: > On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >> On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: >>> On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: >>>> From: "Denis V. Lunev

[PATCH v3 2/2] tests: add virtio-scsi and virtio-blk seg_max_adjust test

2019-11-12 Thread Denis Plotnikov
It tests proper seg_max_adjust settings for all machine types except 'none', 'isapc', 'microvm' Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_seg_max_adjust.py | 135 ++ 1 file changed, 135 insertions(+) create mode 100755 tests/acceptance

[PATCH v3 0/2] virtio: make seg_max virtqueue size dependent

2019-11-12 Thread Denis Plotnikov
v3: * add property to set in machine type [MST] * add min queue size check [Stefan] * add avocado based test [Max, Stefan, Eduardo, Cleber] v2: * the standalone patch to make seg_max virtqueue size dependent * other patches are postponed v1: the initial series Denis Plotnikov (2

[PATCH v3 1/2] virtio: make seg_max virtqueue size dependent

2019-11-12 Thread Denis Plotnikov
old (seg_max = 126 always) and new (seg_max = queue_size - 2) behaviors. Not to change the behavior of the older VMs, prevent setting the default seg_max_adjust value for older machine types. Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 9 - hw/core/machine.c

Re: [PATCH v2 1/1] virtio: make seg_max virtqueue size dependent

2019-11-11 Thread Denis Plotnikov
On 11.11.2019 14:19, Stefan Hajnoczi wrote: > On Fri, Nov 08, 2019 at 04:42:49PM +0300, Denis Plotnikov wrote: >> +virtio_stl_p(vdev, _max, s->conf.queue_size - 2); > [...] >> +virtio_stl_p(vdev, >seg_max, s->conf.virtqueue_size - 2); > Please extend t

Re: [PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-11-10 Thread Denis Plotnikov
On 10.11.2019 22:03, Denis Plotnikov wrote: > This allows to change (replace) the file on a block device and is useful > to workaround exclusive file access restrictions, e.g. to implement VM > migration with a shared disk stored on some storage with the exclusive > file o

[PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-10 Thread Denis Plotnikov
Some device's property can be changed if the device has been already realized. For example, it could be "drive" property of a scsi disk device. So far, set_pointer could operate only on a relized device. The patch extends its interface for operation on an unrealized device. Signed-off

[PATCH v0 2/2] block: allow to set 'drive' property on a realized block device

2019-11-10 Thread Denis Plotnikov
with a fake image drive, and later, on the last migration phase, the fake image file is replaced with the real one. Signed-off-by: Denis Plotnikov --- hw/core/qdev-properties-system.c | 89 +++- 1 file changed, 77 insertions(+), 12 deletions(-) diff --git a/hw/core/qdev

[PATCH v0 0/2] allow to set 'drive' property on a realized block device

2019-11-10 Thread Denis Plotnikov
. More details here: http://patchwork.ozlabs.org/patch/1179329/ The current series suggests another approach: 1. blockdev-add 2. qom-set disk.drive = the blockdev added (this is what the series adds) Denis Plotnikov (2): qdev-properties-system: extend set_pionter for unrealized devices block:

[PATCH v2 1/1] virtio: make seg_max virtqueue size dependent

2019-11-08 Thread Denis Plotnikov
seg_max has a restriction to be less or equal to virtqueue size according to Virtio 1.0 specification Although seg_max can't be set directly, it's worth to express this dependancy directly in the code for sanity purpose. Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 2 +- hw/scsi

[PATCH v2 0/1] virtio: fix IO request length in virtio SCSI/block

2019-11-08 Thread Denis Plotnikov
v2: * the standalone patch to make seg_max virtqueue size dependent * other patches are postponed v1: the initial series Denis Plotnikov (1): virtio: make seg_max virtqueue size dependent hw/block/virtio-blk.c | 2 +- hw/scsi/virtio-scsi.c | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-07 Thread Denis Plotnikov
Wed, Nov 06, 2019 at 10:07:02AM +, Denis Lunev wrote: >> On 11/5/19 9:51 PM, Michael S. Tsirkin wrote: >>> On Tue, Nov 05, 2019 at 07:11:03PM +0300, Denis Plotnikov wrote: >>>> seg_max has a restriction to be less or equal to virtqueue size >>>

Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-07 Thread Denis Plotnikov
On 07.11.2019 19:30, Cleber Rosa wrote: > On Wed, Nov 06, 2019 at 04:26:41PM -0300, Eduardo Habkost wrote: >> On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote: >>> On 06.11.19 10:24, Stefan Hajnoczi wrote: >>>> On Tue, Nov 05, 2019 at 07:11:05P

Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting

2019-11-05 Thread Denis Plotnikov
On 05.11.2019 23:56, Michael S. Tsirkin wrote: > On Tue, Nov 05, 2019 at 07:11:02PM +0300, Denis Plotnikov wrote: >> The patch protects from creating illegal virtio device configuration >> via direct virtqueue size property setting. >> >> Signed-off-by: Denis Plotn

[PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-05 Thread Denis Plotnikov
It tests proper queue size settings for all available machine types. Signed-off-by: Denis Plotnikov --- tests/qemu-iotests/267 | 154 + tests/qemu-iotests/267.out | 1 + tests/qemu-iotests/group | 1 + 3 files changed, 156 insertions(+) create mode

[PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-05 Thread Denis Plotnikov
seg_max has a restriction to be less or equal to virtqueue size according to Virtio 1.0 specification Although seg_max can't be set directly, it's worth to express this dependancy directly in the code for sanity purpose. Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 2 +- hw/scsi

[PATCH v1 3/4] virtio: increase virtuqueue sizes in new machine types

2019-11-05 Thread Denis Plotnikov
-by: Denis Plotnikov --- hw/core/machine.c | 14 ++ hw/i386/pc_piix.c | 16 +--- hw/i386/pc_q35.c| 14 -- include/hw/boards.h | 6 ++ 4 files changed, 45 insertions(+), 5 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index 55b08f1466

[PATCH v1 0/4] virtio: fix IO request length in virtio SCSI/block

2019-11-05 Thread Denis Plotnikov
ernels we can increase virtqueue_size to 256 and max_segments to 254. The pitfall here is that seabios allows the virtqueue_size-s < 128, however, the seabios patch extending that value to 256 is pending. Denis Plotnikov (4): virtio: protect non-modern devices from too big virtqueue size settin

[PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting

2019-11-05 Thread Denis Plotnikov
The patch protects from creating illegal virtio device configuration via direct virtqueue size property setting. Signed-off-by: Denis Plotnikov --- hw/virtio/virtio-blk-pci.c | 9 + hw/virtio/virtio-scsi-pci.c | 10 ++ 2 files changed, 19 insertions(+) diff --git a/hw/virtio

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-10-23 Thread Denis Plotnikov
On 21.10.2019 16:24, Stefan Hajnoczi wrote: > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: >> From: "Denis V. Lunev" >> >> Linux guests submit IO requests no longer than PAGE_SIZE * max_seg >> field reported by SCSI controler. Thus typi

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Denis Plotnikov
On 22.10.2019 16:18, Max Reitz wrote: > On 22.10.19 14:53, Denis Plotnikov wrote: >> On 22.10.2019 14:05, Max Reitz wrote: >>> On 21.10.19 08:50, Denis Plotnikov wrote: >>>> On 18.10.2019 18:02, Max Reitz wrote: >>>>> On 18.10.19 14:09, Denis Plotn

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-22 Thread Denis Plotnikov
On 22.10.2019 14:05, Max Reitz wrote: > On 21.10.19 08:50, Denis Plotnikov wrote: >> On 18.10.2019 18:02, Max Reitz wrote: >>> On 18.10.19 14:09, Denis Plotnikov wrote: >>>> The modification is useful to workaround exclusive file access >>>> restric

Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-21 Thread Denis Plotnikov
On 18.10.2019 18:02, Max Reitz wrote: > On 18.10.19 14:09, Denis Plotnikov wrote: >> The modification is useful to workaround exclusive file access restrictions, >> e.g. to implement VM migration with shared disk stored on a storage with >> the exclusive file opening mo

[PATCH] blockdev: modify blockdev-change-medium to change non-removable device

2019-10-18 Thread Denis Plotnikov
migration phase, the fake image file is replaced with the real one. Signed-off-by: Denis Plotnikov --- blockdev.c | 69 +++- hmp.c| 2 ++ qapi/block-core.json | 7 +++-- qmp.c| 3 +- 4 files changed, 57 insertions

[PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-10-18 Thread Denis Plotnikov
Stefan Hajnoczi CC: Kevin Wolf CC: Max Reitz CC: Gerd Hoffmann Signed-off-by: Denis V. Lunev Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 3 ++- hw/scsi/vhost-scsi.c| 2 ++ hw/scsi/virtio-scsi.c | 4 +++- include/hw/virtio/virtio-blk.h | 1 + inclu

Re: [Qemu-block] [Ping] [PATCH v6 0/3] qcow2: add zstd cluster compression

2019-09-22 Thread Denis Plotnikov
On 20.09.2019 20:55, John Snow wrote: > > On 9/18/19 12:29 PM, Denis Plotnikov wrote: >> On 12.09.2019 11:46, Denis Plotnikov wrote: >>> ping! >>> > https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00943.html > > I was under the impression you

[Qemu-devel] [Ping] [PATCH v6 0/3] qcow2: add zstd cluster compression

2019-09-18 Thread Denis Plotnikov
On 12.09.2019 11:46, Denis Plotnikov wrote: > ping! > > On 05.09.2019 12:31, Denis Plotnikov wrote: >> v6: >> * fixed zstd compressed length storing/loading [Eric] >> * fixed wording, spec section placement [Eric] >> >> v5: >> * type changed

Re: [Qemu-devel] [PATCH v6 0/3] qcow2: add zstd cluster compression

2019-09-12 Thread Denis Plotnikov
ping! On 05.09.2019 12:31, Denis Plotnikov wrote: > v6: > * fixed zstd compressed length storing/loading [Eric] > * fixed wording, spec section placement [Eric] > > v5: > * type changed for compression_type at BDRVQcow2State [Kevin] > * fixed typos, grammar [Kevin] > * f

Re: [Qemu-devel] [Qemu-block] [PULL v2 01/16] qemu-io: add pattern file for write command

2019-09-10 Thread Denis Plotnikov
On 10.09.2019 10:23, Kevin Wolf wrote: > Am 10.09.2019 um 09:19 hat Max Reitz geschrieben: >> On 09.09.19 19:26, Peter Maydell wrote: >>> On Tue, 3 Sep 2019 at 14:35, Max Reitz wrote: >>>> From: Denis Plotnikov >>>> >>>> The patch a

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
On 05.09.2019 17:31, Eric Blake wrote: > On 9/5/19 2:44 AM, Denis Plotnikov wrote: > > >>>> + >>>> +s_size = be32_to_cpu(*(const uint32_t *) src); >>> As written, this looks like you may be dereferencing an unaligned >>> pointer. It so ha

[Qemu-devel] [PATCH v6 1/3] qcow2: introduce compression type feature

2019-09-05 Thread Denis Plotnikov
providing a comparable compression ratio and therefore provides a performance advantage in backup scenarios. The default compression is ZLIB. Images created with ZLIB compression type are backward compatible with older qemu versions. Signed-off-by: Denis Plotnikov Reviewed-by: Eric Blake --- block

[Qemu-devel] [PATCH v6 2/3] qcow2: rework the cluster compression routine

2019-09-05 Thread Denis Plotnikov
The patch allows processing the image compression type defined in the image header and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Eric Blake --- block/qcow2-threads.c | 77 +++ 1 file

[Qemu-devel] [PATCH v6 0/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
real 65.5 16.3 (-75 %) 1.9 1.6 (-16 %) user 65.0 15.8 5.3 2.5 sys 3.3 0.2 2.0 2.0 Both ZLIB and ZSTD gave the same compression ratio: ~1.5 compressed image size in both cases: ~1.4G Denis Plotnikov (3): qcow2: introduce compression type

[Qemu-devel] [PATCH v6 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
size in both cases: 1.4G Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 122 + block/qcow2.c | 7 +++ configure | 29 ++ docs/interop/qcow2.txt | 21 ++- qapi/block-core.json | 3 +- 5 files changed

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
On 04.09.2019 19:07, Eric Blake wrote: > On 9/4/19 10:29 AM, Denis Plotnikov wrote: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining >> the same level of compression ratio in comparison with >> zlib, whi

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
On 04.09.2019 19:07, Eric Blake wrote: > On 9/4/19 10:29 AM, Denis Plotnikov wrote: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining >> the same level of compression ratio in comparison with >> zlib, whi

[Qemu-devel] [PATCH v5 0/3] qcow2: add zstd cluster compression

2019-09-04 Thread Denis Plotnikov
5.3 2.5 sys 3.3 0.2 2.0 2.0 Both ZLIB and ZSTD gave the same compression ratio: ~1.5 compressed image size in both cases: ~1.4G Denis Plotnikov (3): qcow2: introduce compression type feature qcow2: rework the cluster compression routine qcow2: add zstd cluster compression block/qcow2

[Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-04 Thread Denis Plotnikov
size in both cases: 1.4G Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 107 + block/qcow2.c | 7 +++ configure | 29 +++ docs/interop/qcow2.txt | 20 qapi/block-core.json | 3 +- 5 files changed

[Qemu-devel] [PATCH v5 1/3] qcow2: introduce compression type feature

2019-09-04 Thread Denis Plotnikov
providing a comparable compression ratio and therefore provides a performance advantage in backup scenarios. The default compression is ZLIB. Images created with ZLIB compression type are backward compatible with older qemu versions. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 91

[Qemu-devel] [PATCH v5 2/3] qcow2: rework the cluster compression routine

2019-09-04 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 77 +++ 1 file changed, 63 insertions(+), 14

Re: [Qemu-devel] [PATCH v4 3/3] qcow2: add zstd cluster compression

2019-09-04 Thread Denis Plotnikov
Kevin, thanks for commenting. I'll resend the series shortly. Denis On 03.09.2019 17:12, Kevin Wolf wrote: > Am 28.08.2019 um 14:56 hat Denis Plotnikov geschrieben: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining &g

[Qemu-devel] [PATCH v4 1/3] qcow2: introduce compression type feature

2019-08-28 Thread Denis Plotnikov
providing a comparable compression ratio and therefore provides a performance advantage in backup scenarios. The default compression is ZLIB. Images created with ZLIB compression type are backward compatible with older qemu versions. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 91

[Qemu-devel] [PATCH v4 2/3] qcow2: rework the cluster compression routine

2019-08-28 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 78 +++ 1 file changed, 64 insertions(+), 14

[Qemu-devel] [PATCH v4 0/3] qcow2: add zstd cluster compression

2019-08-28 Thread Denis Plotnikov
: compression decompression zlib zstd zlib zstd real 65.5 16.3 (-75 %) 1.9 1.6 (-16 %) user 65.0 15.8 5.3 2.5 sys 3.3 0.2 2.0 2.0 Both ZLIB and ZSTD gave the same compression ratio: ~1.5 compressed image size in both cases: ~1.4G Denis

[Qemu-devel] [PATCH v4 3/3] qcow2: add zstd cluster compression

2019-08-28 Thread Denis Plotnikov
size in both cases: 1.4G Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 107 + block/qcow2.c | 7 +++ configure | 34 + docs/interop/qcow2.txt | 20 qapi/block-core.json | 3 +- 5 files changed

Re: [Qemu-devel] [PATCH v3 1/3] qcow2: introduce compression type feature

2019-08-27 Thread Denis Plotnikov
On 27.08.2019 14:49, Vladimir Sementsov-Ogievskiy wrote: > 19.08.2019 18:00, Denis Plotnikov wrote: >> The patch adds some preparation parts for incompatible compression type >> feature to QCOW2 header that indicates that *all* compressed clusters >> must be (de)compr

Re: [Qemu-devel] [PATCH v3 0/3] qcow2: add zstd cluster compression

2019-08-26 Thread Denis Plotnikov
Ping! On 19.08.2019 18:00, Denis Plotnikov wrote: > v3: > * relax the compression type setting requirement when >the compression type is not zlib [Eric, Kevin] > * add compression type values to the spec [Eric] > * fix wording in the spec and descriptions [Eric] > * fix func

[Qemu-devel] [PATCH v10] qemu-io: add pattern file for write command

2019-08-20 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v10: * fix overflow [Max] * remove casting to bool [Max, Eric] * fix wording [Max] v9: * replace flag cast to int with bool [Eric] * fix the error

Re: [Qemu-devel] [PATCH v9] qemu-io: add pattern file for write command

2019-08-20 Thread Denis Plotnikov
On Aug 20 2019, at 4:35 pm, Max Reitz wrote: On 19.08.19 18:18, Denis Plotnikov wrote: The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v9: * replace flag cast to int with bool [Eric] * fix the error message

[Qemu-devel] [PATCH v9] qemu-io: add pattern file for write command

2019-08-19 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v9: * replace flag cast to int with bool [Eric] * fix the error message [Eric] * use qemu_io_free instead of qemu_vfree [Eric] * add function description

[Qemu-devel] [PATCH v3 2/3] qcow2: rework the cluster compression routine

2019-08-19 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 78 +++ 1 file changed, 64 insertions(+), 14

[Qemu-devel] [PATCH v3 3/3] qcow2: add zstd cluster compression

2019-08-19 Thread Denis Plotnikov
size in both cases: 1.4G Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 94 ++ block/qcow2.c | 6 +++ configure | 34 +++ docs/interop/qcow2.txt | 20 + qapi/block-core.json | 3 +- 5 files changed

[Qemu-devel] [PATCH v3 0/3] qcow2: add zstd cluster compression

2019-08-19 Thread Denis Plotnikov
2.5 sys 3.3 0.2 2.0 2.0 Both ZLIB and ZSTD gave the same compression ratio: ~1.5 compressed image size in both cases: ~1.4G Denis Plotnikov (3): qcow2: introduce compression type feature qcow2: rework the cluster compression routine qcow2: add zstd cluster compression block/qcow2

[Qemu-devel] [PATCH v3 1/3] qcow2: introduce compression type feature

2019-08-19 Thread Denis Plotnikov
providing a comparable compression ratio and therefore provides a performance advantage in backup scenarios. The default compression is ZLIB. Images created with ZLIB compression type are backward compatible with older qemu versions. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 94

Re: [Qemu-devel] [PATCH v2 0/3] add zstd cluster compression

2019-08-07 Thread Denis Plotnikov
Ping! On Jul 30 2019, at 5:45 pm, Denis Plotnikov wrote: Hi all! Is there any other comments besides Markus's one about adding zlib/zstd links to compressed cluster layout description? On Jul 4 2019, at 4:09 pm, Denis Plotnikov wrote: change log: v2: * relax the compression type setting

[Qemu-devel] [PATCH v8] qemu-io: add pattern file for write command

2019-08-07 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v8: fix according to Max's comments * get rid of unnecessary buffer for the pattern * buffer allocation just in bytes * take into account the missalign

Re: [Qemu-devel] [PATCH v2 0/3] add zstd cluster compression

2019-07-30 Thread Denis Plotnikov
Hi all! Is there any other comments besides Markus's one about adding zlib/zstd links to compressed cluster layout description? On Jul 4 2019, at 4:09 pm, Denis Plotnikov wrote: change log: v2: * relax the compression type setting restriction in the spec * fix qcow2 header size checking * fix

Re: [Qemu-devel] [PATCH v2 3/3] qcow2: add zstd cluster compression

2019-07-30 Thread Denis Plotnikov
On Jul 9 2019, at 9:18 am, Markus Armbruster wrote: Denis Plotnikov writes: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, by the moment, has been the only

Re: [Qemu-devel] [PATCH v7] qemu-io: add pattern file for write command

2019-07-30 Thread Denis Plotnikov
Ping! On Jul 5 2019, at 1:21 pm, Denis Plotnikov wrote: The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v7: * fix variable naming * make code more readable * extend help for write command v6: * the pattern

[Qemu-devel] [PATCH v7] qemu-io: add pattern file for write command

2019-07-05 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v7: * fix variable naming * make code more readable * extend help for write command v6: * the pattern file is read once to reduce io v5: * file name

[Qemu-devel] [PATCH v2 1/3] qcow2: introduce compression type feature

2019-07-04 Thread Denis Plotnikov
providing a comparable compression ratio and therefore provide a performance advantage in backup scenarios. The default compression is ZLIB. Images created with ZLIB compression type are backward compatible with older qemu versions. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 95

[Qemu-devel] [PATCH v2 0/3] add zstd cluster compression

2019-07-04 Thread Denis Plotnikov
ratio: ~1.5 compressed image size in both cases: ~1.4G Denis Plotnikov (3): qcow2: introduce compression type feature qcow2: rework the cluster compression routine qcow2: add zstd cluster compression block/qcow2.c | 287 +++--- block/qcow2.h

[Qemu-devel] [PATCH v2 2/3] qcow2: rework the cluster compression routine

2019-07-04 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 93 --- 1 file changed, 73 insertions(+), 20

[Qemu-devel] [PATCH v2 3/3] qcow2: add zstd cluster compression

2019-07-04 Thread Denis Plotnikov
size in both cases: 1.4G Signed-off-by: Denis Plotnikov --- block/qcow2.c | 99 ++ configure | 32 ++ docs/interop/qcow2.txt | 19 qapi/block-core.json | 3 +- 4 files changed, 152 insertions(+), 1 deletion

Re: [Qemu-devel] [PATCH v1 1/3] qcow2: introduce compression type feature

2019-07-03 Thread Denis Plotnikov
On 03.07.2019 18:46, Kevin Wolf wrote: > Am 03.07.2019 um 17:01 hat Denis Plotnikov geschrieben: >> On 03.07.2019 17:14, Eric Blake wrote: >>> On 7/3/19 6:00 AM, Denis Plotnikov wrote: >>>> diff --git a/block/qcow2.c b/block/qcow2.c >>>> index 3ace3b2209

Re: [Qemu-devel] [PATCH v1 1/3] qcow2: introduce compression type feature

2019-07-03 Thread Denis Plotnikov
On 03.07.2019 18:13, Eric Blake wrote: > On 7/3/19 10:01 AM, Denis Plotnikov wrote: > >>>> + * with QCOW2_COMPRESSION_TYPE_ZLIB the corresponding incompatible >>>> + * feature flag must be absent, with other compression types the >>>> +

Re: [Qemu-devel] [PATCH v1 3/3] qcow2: add zstd cluster compression

2019-07-03 Thread Denis Plotnikov
On 03.07.2019 17:36, Eric Blake wrote: > On 7/3/19 6:00 AM, Denis Plotnikov wrote: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining >> the same level of compression ratio in comparison with >> zlib, whi

Re: [Qemu-devel] [PATCH v1 1/3] qcow2: introduce compression type feature

2019-07-03 Thread Denis Plotnikov
On 03.07.2019 17:14, Eric Blake wrote: > On 7/3/19 6:00 AM, Denis Plotnikov wrote: >> The patch adds some preparation parts for incompatible compression type >> feature to QCOW2 header that indicates that*all* compressed clusters >> must be (de)compressed using a cer

[Qemu-devel] [PATCH v1 2/3] qcow2: rework the cluster compression routine

2019-07-03 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 93 --- 1 file changed, 73 insertions(+), 20

[Qemu-devel] [PATCH v1 3/3] qcow2: add zstd cluster compression

2019-07-03 Thread Denis Plotnikov
size in both cases: 1.4G Signed-off-by: Denis Plotnikov --- block/qcow2.c| 96 configure| 32 +++ qapi/block-core.json | 3 +- 3 files changed, 130 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2

[Qemu-devel] [PATCH v1 0/3] add zstd cluster compression

2019-07-03 Thread Denis Plotnikov
compressed image size in both cases: ~1.4G Denis Plotnikov (3): qcow2: introduce compression type feature qcow2: rework the cluster compression routine qcow2: add zstd cluster compression block/qcow2.c | 283 +++--- block/qcow2.h

[Qemu-devel] [PATCH v1 1/3] qcow2: introduce compression type feature

2019-07-03 Thread Denis Plotnikov
providing a comparable compression ratio and therefore provide a performance advantage in backup scenarios. The default compression is ZLIB. Images created with ZLIB compression type is backward compatible with older qemu versions. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 94

Re: [Qemu-devel] [PATCH v0 3/3] qcow2: add zstd cluster compression

2019-07-02 Thread Denis Plotnikov
On 02.07.2019 17:37, Kevin Wolf wrote: > Am 02.07.2019 um 14:49 hat Denis Plotnikov geschrieben: >> On 28.06.2019 14:57, Kevin Wolf wrote: >>> Am 28.05.2019 um 16:37 hat Denis Plotnikov geschrieben: >>>> diff --git a/configure b/configure >>&g

Re: [Qemu-devel] [Qemu-block] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-07-02 Thread Denis Plotnikov
On 28.06.2019 15:32, Kevin Wolf wrote: > Am 26.06.2019 um 10:46 hat Denis Plotnikov geschrieben: >> On 24.06.2019 12:46, Denis Plotnikov wrote: >>> On 21.06.2019 12:59, Vladimir Sementsov-Ogievskiy wrote: >>>> 21.06.2019 12:16, Kevin Wolf wrote: >>>&

Re: [Qemu-devel] [PATCH v0 3/3] qcow2: add zstd cluster compression

2019-07-02 Thread Denis Plotnikov
On 28.06.2019 14:57, Kevin Wolf wrote: > Am 28.05.2019 um 16:37 hat Denis Plotnikov geschrieben: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining >> the same level of compression ratio in compariso

Re: [Qemu-devel] [PATCH v0 3/3] qcow2: add zstd cluster compression

2019-07-02 Thread Denis Plotnikov
Thanks for reviewing, I'll take into account the suggestions below and send the next version of the series soon. On 28.06.2019 14:57, Kevin Wolf wrote: > Am 28.05.2019 um 16:37 hat Denis Plotnikov geschrieben: >> zstd significantly reduces cluster compression time. >> It

Re: [Qemu-devel] [PATCH v0 2/3] qcow2: add compression type processing

2019-07-02 Thread Denis Plotnikov
On 28.06.2019 22:34, Eric Blake wrote: > On 6/28/19 9:54 AM, Kevin Wolf wrote: > We would save most of this code if we added a new field to the header instead of adding a header extension. Not saying that we should definitely do this, but let's discuss it at least.

Re: [Qemu-devel] [PATCH v0 2/3] qcow2: add compression type processing

2019-06-28 Thread Denis Plotnikov
On 28.06.2019 18:03, Max Reitz wrote: > On 28.06.19 16:54, Kevin Wolf wrote: >> Am 28.06.2019 um 16:40 hat Denis Plotnikov geschrieben: >>> >>> >>> On 28.06.2019 17:24, Kevin Wolf wrote: >>>> Am 28.06.2019 um 14:56 hat Denis Plotnikov geschrieb

Re: [Qemu-devel] [PATCH v0 2/3] qcow2: add compression type processing

2019-06-28 Thread Denis Plotnikov
On 28.06.2019 17:24, Kevin Wolf wrote: > Am 28.06.2019 um 14:56 hat Denis Plotnikov geschrieben: >> >> >> On 28.06.2019 15:06, Kevin Wolf wrote: >>> Am 28.06.2019 um 13:24 hat Denis Plotnikov geschrieben: >>>> >>>> >>>> On 28

Re: [Qemu-devel] [PATCH v0 2/3] qcow2: add compression type processing

2019-06-28 Thread Denis Plotnikov
On 28.06.2019 15:06, Kevin Wolf wrote: > Am 28.06.2019 um 13:24 hat Denis Plotnikov geschrieben: >> >> >> On 28.06.2019 13:23, Kevin Wolf wrote: >>> Am 28.05.2019 um 16:37 hat Denis Plotnikov geschrieben: >>>> With the patch, qcow2 is able to p

Re: [Qemu-devel] [PATCH v0 2/3] qcow2: add compression type processing

2019-06-28 Thread Denis Plotnikov
On 28.06.2019 13:23, Kevin Wolf wrote: > Am 28.05.2019 um 16:37 hat Denis Plotnikov geschrieben: >> With the patch, qcow2 is able to process image compression type >> defined in the image header and choose the corresponding method >> for clusters compressing. >> >

Re: [Qemu-devel] [PATCH v0 1/3] qcow2: introduce compression type feature

2019-06-28 Thread Denis Plotnikov
On 28.06.2019 12:54, Kevin Wolf wrote: > Am 28.05.2019 um 16:37 hat Denis Plotnikov geschrieben: >> The patch adds some preparation parts for incompatible compression type >> feature to QCOW2 header that indicates that *all* compressed clusters >> must be (de)compr

Re: [Qemu-devel] [PATCH v6] qemu-io: add pattern file for write command

2019-06-27 Thread Denis Plotnikov
On 19.06.2019 13:09, Vladimir Sementsov-Ogievskiy wrote: > 10.06.2019 16:21, Denis Plotnikov wrote: >> The patch allows to provide a pattern file for write >> command. There was no similar ability before. >> >> Signed-off-by: Denis Plotnikov >> --- >> v6:

[Qemu-devel] [PING PING] [PATCH v0 0/3] add zstd cluster compression

2019-06-27 Thread Denis Plotnikov
On 04.06.2019 10:56, Denis Plotnikov wrote: > > > On 28.05.2019 17:37, Denis Plotnikov wrote: >> The goal of the patch-set is to enable qcow2 to use zstd compression for >> clusters. ZSTD provides better (de)compression performance than currently >> used ZLIB. Using

Re: [Qemu-devel] [Qemu-block] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-06-26 Thread Denis Plotnikov
On 24.06.2019 12:46, Denis Plotnikov wrote: > > > On 21.06.2019 12:59, Vladimir Sementsov-Ogievskiy wrote: >> 21.06.2019 12:16, Kevin Wolf wrote: >>> Am 09.04.2019 um 12:01 hat Kevin Wolf geschrieben: >>>> Am 02.04.2019 um 10:35 hat Denis Plotnikov geschrieb

Re: [Qemu-devel] [Qemu-block] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-06-24 Thread Denis Plotnikov
On 21.06.2019 12:59, Vladimir Sementsov-Ogievskiy wrote: > 21.06.2019 12:16, Kevin Wolf wrote: >> Am 09.04.2019 um 12:01 hat Kevin Wolf geschrieben: >>> Am 02.04.2019 um 10:35 hat Denis Plotnikov geschrieben: >>>> On 13.03.2019 19:04, Kevin Wolf wrote: >>

[Qemu-devel] [PATCH v6] qemu-io: add pattern file for write command

2019-06-10 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v6: * the pattern file is read once to reduce io v5: * file name initiated with null to make compilers happy v4: * missing signed-off clause added v3

Re: [Qemu-devel] [PATCH v5] qemu-io: add pattern file for write command

2019-06-10 Thread Denis Plotnikov
On 31.05.2019 18:13, Eric Blake wrote: > On 5/31/19 2:46 AM, Denis Plotnikov wrote: >> The patch allows to provide a pattern file for write >> command. There was no similar ability before. >> >> Signed-off-by: Denis Plotnikov >> --- >> v5: >>* fi

[Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2019-06-10 Thread Denis Plotnikov
on the channel level. Fortunately, monitor protocol is synchronous right now thus we should not face side effects in reality. Signed-off-by: Denis V. Lunev Signed-off-by: Denis Plotnikov --- include/monitor/monitor.h | 2 +- monitor.c | 2 +- 2 files changed, 2 insertions(+), 2

[Qemu-devel] [PING] [PATCH v0 0/3] add zstd cluster compression

2019-06-04 Thread Denis Plotnikov
On 28.05.2019 17:37, Denis Plotnikov wrote: > The goal of the patch-set is to enable qcow2 to use zstd compression for > clusters. ZSTD provides better (de)compression performance than currently > used ZLIB. Using it will improve perforamnce (reduce compression time) > when th

[Qemu-devel] [PATCH v5] qemu-io: add pattern file for write command

2019-05-31 Thread Denis Plotnikov
The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v5: * file name initiated with null to make compilers happy v4: * missing signed-off clause added v3: * missing file closing added * exclusive flags

<    1   2   3   4   5   6   >