Re: [Qemu-devel] [PATCH] x86: Fix x86_64 'g' packet response to gdb from 32-bit mode.

2016-11-04 Thread Doug Evans
On Fri, Nov 4, 2016 at 12:01 PM, Pedro Alves <pal...@redhat.com> wrote: > On 11/04/2016 04:34 PM, Peter Maydell wrote: >> On 4 November 2016 at 16:29, Richard Henderson <r...@twiddle.net> wrote: >>> On 11/03/2016 05:35 PM, Doug Evans wrote: >>>> >>&

[Qemu-devel] [PATCH] Document how x86 gdb_num_core_regs is computed.

2016-11-03 Thread Doug Evans
Hi. It helps when reading the code to see how the number is arrived at. Signed-off-by: Doug Evans <d...@google.com> --- target-i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 14c5186..01f1ab0 100644 --- a/target-i386/cpu.c

[Qemu-devel] [PATCH] x86: Fix x86_64 'g' packet response to gdb from 32-bit mode.

2016-11-03 Thread Doug Evans
The remote protocol can't handle flipping back and forth between 32-bit and 64-bit regs. To compensate, pretend "as if" on 64-bit cpu when in 32-bit mode. Signed-off-by: Doug Evans <d...@google.com> --- target-i386/gdbstub.c | 52 ++--

[Qemu-devel] [PATCH] x86: Fix eflags tracking for syscall insn

2016-12-06 Thread Doug Evans
393243eda30d4429a07a0f7c29b0f6297616a355 Author: Doug Evans <d...@google.com> Date: Tue Dec 6 09:00:42 2016 -0800 syscall insn: update eflags to CC_OP_EFLAGS Signed-off-by: Doug Evans <d...@google.com> diff --git a/target-i386/translate.c b/target-i386/translate.c index 324103c..9fd1a04 100644

Re: [Qemu-devel] [PATCH] x86: Fix eflags tracking for syscall insn

2016-12-06 Thread Doug Evans
On Tue, Dec 6, 2016 at 11:43 AM, Richard Henderson <r...@twiddle.net> wrote: > On 12/06/2016 09:13 AM, Doug Evans wrote: >> @@ -7104,6 +7104,10 @@ static target_ulong disas_insn(CPUX86State *env, >> DisasContext *s, >> gen_update_cc_op(s); >>

Re: [Qemu-devel] [PATCH] x86: Fix x86_64 'g' packet response to gdb from 32-bit mode.

2016-12-14 Thread Doug Evans
On Wed, Dec 14, 2016 at 9:14 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 04/11/2016 00:35, Doug Evans wrote: >> The remote protocol can't handle flipping back and forth >> between 32-bit and 64-bit regs. To compensate, pretend "as if" >> on 6

Re: [Qemu-devel] [PATCH] target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns

2016-12-12 Thread Doug Evans
On Tue, Dec 6, 2016 at 3:06 PM, Doug Evans <d...@google.com> wrote: > Hi. > > While qemu's behaviour matches what one would expect from reading > the docs, it does not match what I'm seeing on h/w. > Can anyone else confirm what the correct behaviour is here? > > ---

Re: [Qemu-devel] [PULL 24/25] target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns

2016-12-23 Thread Doug Evans
Paolo Bonzini writes: > From: Doug Evans <d...@google.com> > > The syscall and sysret instructions behave a bit differently: > TF is checked after the instruction completes. > This allows the o/s to disable #DB at a syscall by adding TF to FMASK. > And then whe

[Qemu-devel] [PATCH] target/i386: Fix bad patch application to translate.c

2016-12-24 Thread Doug Evans
In commit c52ab08aee6f7d4717fc6b517174043126bd302f, the patch snippet for the "syscall" insn got applied to "iret". Signed-off-by: Doug Evans <d...@google.com> --- target/i386/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH] target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns

2016-12-06 Thread Doug Evans
. This allows the o/s to disable #DB at a syscall by adding TF to FMASK. And then when the sysret is executed the #DB is taken "as if" the syscall insn just completed. Signed-off-by: Doug Evans <d...@google.com> --- target-i386/bpt_helper.c | 12 target-i386/helper.h

[Bug 1905651] Re: Tests cannot call g_error

2020-11-26 Thread Doug Evans
I don't know QEMU that well yet, but the following question arises: Why can't QEMU be driven in a way that allows it to see that its controlling parent has died -> causing QEMU to terminate as well. That way the test doesn't need to care how it dies (e.g., we don't want a segfault to hang testing;

[Bug 1905651] [NEW] Tests cannot call g_error

2020-11-25 Thread Doug Evans
Public bug reported: I stumbled on this writing a new test, using tests/qtest/e1000e-test.c as a template. g_error() causes SIGTRAP, not SIGABRT, and thus the abort handler doesn't get run. This in turn means qemu is not killed, which hangs the test because the tap-driver.pl script hangs

[Bug 1905651] Re: Tests cannot call g_error

2020-11-25 Thread Doug Evans
An alternative is of course to allow g_error to be called. One might restrict tests to not call it, but it might be impractical to impose that on all code that goes into a test. One will need to find a way to get glib to not call G_BREAKPOINT for this case. if (debugger_present && breakpoint)

[DISCUSSION] Running one qtest test: how?

2020-11-25 Thread Doug Evans
Hi. I can run a subset of qtest tests with "make check-qtest-TARGET", but that's the limit of the granularity that I can find. Why would one want more granularity? When adding a test one wants the edit/test cycle as short as possible and needlessly running other tests is a pain. It'd be really

[Bug 1906463] [NEW] "-device help" does not report all devices

2020-12-01 Thread Doug Evans
Public bug reported: -device help doesn't report all devices. E.g., devices that are instantiated by a board don't get printed in part because they don't exist when "-device help" is processed. As an experiment I deferred processing of "-device help" as long as possible and some devices were

Re: [Bug 1906463] [NEW] "-device help" does not report all devices

2020-12-02 Thread Doug Evans
On Wed, Dec 2, 2020 at 9:41 AM Peter Maydell wrote: > On Wed, 2 Dec 2020 at 16:51, Doug Evans wrote: > > > > Btw, if I may ask another dumb question, I get this: > > > > @ruffy:build-arm$ ./qemu-system-arm -M virt -monitor stdio > > Unable to init server: Coul

Re: [Bug 1906463] [NEW] "-device help" does not report all devices

2020-12-02 Thread Doug Evans
On Tue, Dec 1, 2020 at 10:53 PM Markus Armbruster wrote: > Doug Evans <1906...@bugs.launchpad.net> writes: > > > Public bug reported: > > > > -device help doesn't report all devices. > > E.g., devices that are instantiated by a board don't get printed in

[DISCUSSION] How to set properties of non-pluggable devices?

2020-12-02 Thread Doug Evans
Hi. Suppose I want to set a property of a non-pluggable device that cannot be set after the device has been realized (e.g., I can't use qmp to set the property after QEMU has started). Being non-pluggable means I can't use "-device foo,bar=baz" on the command line. [But I can use "-device

Re: [PATCH 1/1] trace: Send "-d trace:help" output to stdout

2020-12-11 Thread Doug Evans
Thanks. I gather this is a first step in getting the patch into master? If so, OOC, how many separate "staging" trees are there for the master branch? (is there a list?) On Thu, Dec 10, 2020 at 3:25 AM Stefan Hajnoczi wrote: > On Wed, Nov 25, 2020 at 01:52:45PM -0800, Dou

checkpatch.pl block comment detection fail

2020-12-11 Thread Doug Evans
Hi. The coding style docs don't specify this as being bad: foo(/*bar=*/true); which improves readability at the call site. It's not a style to be used liberally, but sometimes it's helpful. Alas checkpatch.pl claims this is a block comment. Would it be ok if I try to fix checkpatch.pl to

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-03 Thread Doug Evans
On Wed, Feb 3, 2021 at 1:37 PM Doug Evans wrote: > ... in preparation for adding ipv6 host forwarding support. > --- > net/slirp.c | 200 +--- > slirp | 2 +- > 2 files changed, 130 insertions(+), 72 deletions(-) >

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-03 Thread Doug Evans
On Wed, Feb 3, 2021 at 2:15 PM Samuel Thibault wrote: > Doug Evans, le mer. 03 févr. 2021 13:37:28 -0800, a ecrit: > > ... in preparation for adding ipv6 host forwarding support. > > Reviewed-by: Samuel Thibault > > except > > > diff --git a/slirp b/slirp > >

Re: [PATCH v2 2/2] net: Add -ipv6-hostfwd option, ipv6_hostfwd_add/remove commands

2021-02-03 Thread Doug Evans
On Wed, Feb 3, 2021 at 2:20 PM Samuel Thibault wrote: > Doug Evans, le mer. 03 févr. 2021 13:37:29 -0800, a ecrit: > > @@ -1392,6 +1392,34 @@ SRST > >Remove host-to-guest TCP or UDP redirection. > > ERST > > > > +#ifdef CONFIG_SLIRP > > +{ >

[RFC] Change default ipv6 network from fec0/10 (site local) to fe80/10 (link local)

2021-01-27 Thread Doug Evans
Hi. This is just an information gathering question. I don't know enough to formally propose the change. I happened to notice QEMU's default for the ipv6 network is fec0::/10 which is deprecated (RFC3879). I think(!) an obvious replacement is fe80::/10, link local. Has anyone thought about this

Re: [PATCH v7 0/4] Add support for ipv6 host forwarding

2021-06-15 Thread Doug Evans
Ping. On Wed, Jun 9, 2021 at 9:41 PM Doug Evans wrote: > Ping. > > On Fri, May 28, 2021 at 4:53 PM Doug Evans wrote: > >> This patchset takes the original patch from Maxim, >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html >> and updates it. &g

Re: [PULL 1/2] Update libslirp to v4.5.0

2021-06-18 Thread Doug Evans
slirp_version_string()` now has the git sha suffix when building form > git > - Limit DNS redirection to port 53 #16 > > ### Fixed > > - Fix build regression with mingw & NetBSD > - Fix use-afte-free in `ip_reass()` (CVE-2020-1983) > > Sign

Re: [PATCH v7 0/4] Add support for ipv6 host forwarding

2021-06-09 Thread Doug Evans
Ping. On Fri, May 28, 2021 at 4:53 PM Doug Evans wrote: > This patchset takes the original patch from Maxim, > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > and updates it. > > Option hostfwd is extended to support ipv6 addresses. > Commands hostfwd_a

Re: [PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-05-07 Thread Doug Evans
On Fri, May 7, 2021 at 8:23 AM Marc-André Lureau wrote: > Hi > > [...] >> >> >> Changes from v5: >> >> 1/4 slirp: Advance libslirp submodule to current master >> NOTE TO REVIEWERS: It may be a better use of everyone's time if a >> maintainer takes on advancing QEMU's libslirp to libslirp's

Re: [PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-05-12 Thread Doug Evans
Ping. On Fri, May 7, 2021 at 8:46 AM Doug Evans wrote: > On Fri, May 7, 2021 at 8:23 AM Marc-André Lureau < > marcandre.lur...@gmail.com> wrote: > >> Hi >> >> [...] >>> >>> >>> Changes from v5: >>> >>> 1/4 sli

Re: [PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-05-12 Thread Doug Evans
On Wed, May 12, 2021 at 10:18 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Wed, May 12, 2021 at 8:43 PM Doug Evans wrote: > >> Ping. >> >> On Fri, May 7, 2021 at 8:46 AM Doug Evans wrote: >> >>> On Fri, May 7, 20

Re: RFC: IPv6 hostfwd command line syntax [was Re: [PATCH v6 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse]

2021-05-26 Thread Doug Evans
On Wed, May 26, 2021 at 6:57 AM Daniel P. Berrangé wrote: > On Tue, May 25, 2021 at 12:37:21PM -0700, Doug Evans wrote: > > Hi. > > > > I want to confirm the command line syntax y'all want for ipv6 host > > forwarding. > > > > IIUC, the command l

[PATCH v7 4/4] net: Extend host forwarding to support IPv6

2021-05-28 Thread Doug Evans
Net option "-hostfwd" now supports IPv6 addresses. Commands hostfwd_add, hostfwd_remove now support IPv6 addresses. Tested: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v6: No changes. Changes from v5: Recognize ipv4=,ipv6= options. hmp-c

[PATCH v7 3/4] net/slirp.c: Refactor address parsing

2021-05-28 Thread Doug Evans
... in preparation for adding ipv6 host forwarding support. Tested: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v6: Add support for --enable-slirp=system Tested with system libslirp 4.4.0. Changes from v5: Use InetSocketAddress and getaddrinfo(). Use

[PATCH v7 1/4] slirp: Advance libslirp submodule to 4.5 release

2021-05-28 Thread Doug Evans
5eraph (2): disable_dns option limit vnameserver_addr to port 53 Akihiro Suda (1): libslirp.h: fix SlirpConfig v3 documentation Doug Evans (11): Add ipv6 host forward support tcpx_listen: Pass sizeof(addr) to memset Reject host forwarding to ipv6 "add

[PATCH v7 0/4] Add support for ipv6 host forwarding

2021-05-28 Thread Doug Evans
m v2: - split out libslirp commit - clarify spelling of ipv6 addresses in docs - tighten parsing of ipv6 addresses Change from v1: - libslirp part is now upstream - net/slirp.c changes split into two pieces (refactor, add ipv6) - added docs Doug Evans (4): slirp: Advance libslirp submodule to 4.5 rel

[PATCH v7 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-05-28 Thread Doug Evans
The parsing is moved into new function inet_parse_host_port. Also split out is ipv4=flag, ipv6=flag processing into inet_parse_ipv46. This is done in preparation for using these functions in net/slirp.c. Signed-off-by: Doug Evans Reviewed-by: Marc-André Lureau --- Changes from v6: No changes

Re: [PATCH v2] Update libslirp to v4.5.0

2021-05-27 Thread Doug Evans
ith the git sha suffix when building > from git > - `SlirpConfig.disable_dns`, to disable DNS redirection #16 > > ### Changed > > - `slirp_version_string()` now has the git sha suffix when building form > git > - Limit DNS redirection to port 53 #16 > > ### Fixed >

RFC: IPv6 hostfwd command line syntax [was Re: [PATCH v6 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse]

2021-05-25 Thread Doug Evans
write that as ":[]:60022-[]:22" to mean "this is for ipv6" one cannot do so. On Fri, May 7, 2021 at 8:23 AM Marc-André Lureau wrote: > > > On Thu, Apr 15, 2021 at 7:40 AM Doug Evans wrote: > >> The parsing is moved into new function inet_p

Ethernet-over-usb with linux guest using USB Device Controller ?

2021-04-26 Thread Doug Evans
Hi. I'm working on a project where I want to have the linux qemu guest communicate with another linux system via ethernet-over-usb (as far as the guest is concerned, as it will be using a usb network gadget). In this case the linux guest will be using a USB Device Controller (UDC) to drive its

Re: [PATCH v6 0/4] Add support for ipv6 host forwarding

2021-04-28 Thread Doug Evans
Ping. On Wed, Apr 14, 2021 at 8:39 PM Doug Evans wrote: > This patchset takes the original patch from Maxim, > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > and updates it. > > Option hostfwd is extended to support ipv6 addresses. > Commands hostfwd_a

Re: Ethernet-over-usb with linux guest using USB Device Controller ?

2021-05-03 Thread Doug Evans
On Tue, Apr 27, 2021 at 12:31 AM Gerd Hoffmann wrote: > Hi, > > > Questions: Is this support in QEMU and if so got any pointers to source > for > > existing examples? > > If not, any guidance on how to proceed? > > qemu has only usb host controller emulation, not any usb device > controller

Re: [PATCH v6 0/4] Add support for ipv6 host forwarding

2021-05-05 Thread Doug Evans
Ping. On Wed, Apr 28, 2021 at 8:37 PM Doug Evans wrote: > Ping. > > On Wed, Apr 14, 2021 at 8:39 PM Doug Evans wrote: > >> This patchset takes the original patch from Maxim, >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html >> and updates it. &g

Re: [PATCH v3 1/3] slirp: Placeholder for libslirp ipv6 hostfwd support

2021-02-04 Thread Doug Evans
> based on the From: dje--- via header (that looks > like our mailing list rewrote things due to SPF policies, but that it > botched your name in the process), rather than your Reply-to: Doug Evans > header. To fix the latter, you can convince git to > include a From: line in the fi

Re: [PATCH v2 1/3] hw/net: Add npcm7xx emc model

2021-02-08 Thread Doug Evans
On Mon, Feb 8, 2021 at 9:17 AM Peter Maydell wrote: > On Tue, 2 Feb 2021 at 23:29, Doug Evans wrote: > > > > This is a 10/100 ethernet device that has several features. > > Only the ones needed by the Linux driver have been implemented. > > See npcm7xx_emc.c for a lis

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-08 Thread Doug Evans
On Mon, Feb 8, 2021 at 3:09 AM Philippe Mathieu-Daudé wrote: > Hi Doug, > > On 2/3/21 10:37 PM, dje--- via wrote: > > ... in preparation for adding ipv6 host forwarding support. > > Please duplicate subject line, else this commit description as it > doesn't make sense. > Hmmm. Is this a bug in

Re: [PATCH v3 0/3]

2021-02-09 Thread Doug Evans
On Thu, Feb 4, 2021 at 10:25 AM Doug Evans wrote: > On Thu, Feb 4, 2021 at 2:03 AM Daniel P. Berrangé > wrote: > >> On Wed, Feb 03, 2021 at 03:35:36PM -0800, dje--- via wrote: >> > Add support for ipv6 host forwarding >> > >> > This patchset takes

Re: [PATCH v3 0/3]

2021-02-10 Thread Doug Evans
On Wed, Feb 10, 2021 at 1:31 AM Daniel P. Berrangé wrote: > On Tue, Feb 09, 2021 at 06:16:57PM -0800, Doug Evans wrote: > > On Thu, Feb 4, 2021 at 10:25 AM Doug Evans wrote: > > > > > On Thu, Feb 4, 2021 at 2:03 AM Daniel P. Berrangé > > > > wrote: > &

Re: [PATCH v3 0/3]

2021-02-10 Thread Doug Evans
On Wed, Feb 10, 2021 at 8:49 AM Daniel P. Berrangé wrote: > On Wed, Feb 10, 2021 at 08:31:40AM -0800, Doug Evans wrote: > > On Wed, Feb 10, 2021 at 1:31 AM Daniel P. Berrangé > > wrote: > > > > > On Tue, Feb 09, 2021 at 06:16:57PM -0800, Doug Evans wrote: > >

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-14 Thread Doug Evans
On Sat, Mar 6, 2021 at 11:29 AM Samuel Thibault wrote: > Hello, > > Doug Evans, le ven. 05 mars 2021 17:00:13 -0800, a ecrit: > > Is it possible for QEMU to lazily determine the guest's IPv6 > > address? I.e., postpone the ""->guest address mapping until i

[PATCH] net/npcm7xx_emc.c: Fix handling of receiving packets when RSDR not set

2021-03-19 Thread Doug Evans
Turning REG_MCMDR_RXON is enough to start receiving packets. Signed-off-by: Doug Evans --- hw/net/npcm7xx_emc.c | 4 +++- tests/qtest/npcm7xx_emc-test.c | 30 +- 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/hw/net/npcm7xx_emc.c b/hw/net

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-03 Thread Doug Evans
On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault wrote: > [...] > > > + Examples: > > + hostfwd_add net0 tcp:127.0.0.1:10022-:22 > > + hostfwd_add net0 tcp:[::1]:10022-[fe80::1:2:3:4]:22 > > Yep, that looks good to me. > > Daniel, you wanted me to use inet_parse(). Is the above syntax ok with

Re: [PATCH] net: remove qemu_ether_ntoa()

2021-02-26 Thread Doug Evans
On Fri, Feb 26, 2021 at 4:06 AM wrote: > From: Marc-André Lureau > > The function is not thread-safe and sets a bad example. It's used in a > single place for tracing, so open-code the format string like other > trace events with MAC addresses. > > Cc: qemu-triv...@nongnu.org > Signed-off-by:

Re: [PATCH v5 0/3] Add npcm7xx emc model

2021-03-04 Thread Doug Evans
Ping. On Thu, Feb 18, 2021 at 1:24 PM Doug Evans wrote: > This is a 10/100 ethernet device that has several features. > Only the ones needed by the Linux driver have been implemented. > See npcm7xx_emc.c for a list of unimplemented features. > > Doug Evans (3): > hw/net: Add

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-07 Thread Doug Evans
5-1-...@google.com > Switched to a new branch 'test' > 6e42a49 inet_parse: Clarify IPv6 comment and error message > > === OUTPUT BEGIN === > ERROR: Author email address is mangled by the mailing list > #2: > Author: Doug Evans via > > total: 1 errors, 0 warnings, 14 lines check

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Doug Evans
On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault wrote: > Hello, > > Daniel P. Berrangé, le lun. 22 févr. 2021 09:39:41 +, a ecrit: > > > The is_v6 flag is only needed > > for the legacy compat needs in slirp, even that is only if we want to > > have strict equivalence with historical

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Doug Evans
On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault wrote: > [...] > > Note that one issue I am leaving for later (i.e., I don't want to drag > this > > patch series out to include it), is whether and how to support > ipv4-host-> > > ipv6-guest forwarding and vice versa. Can libslirp support this? >

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-23 Thread Doug Evans
On Mon, Feb 22, 2021 at 1:39 AM Daniel P. Berrangé wrote: > On Fri, Feb 19, 2021 at 02:17:42PM -0800, Doug Evans wrote: > > On Fri, Feb 19, 2021 at 2:00 AM Daniel P. Berrangé > > wrote: > > > > > On Thu, Feb 18, 2021 at 12:15:36PM -0800, Doug Evans wrote: > &g

Re: [PATCH v5 1/5] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-23 Thread Doug Evans
On Fri, Feb 19, 2021 at 4:20 PM Philippe Mathieu-Daudé wrote: > Hi Doug, > > On 2/20/21 1:13 AM, Doug Evans via wrote: > > When updating submodules, the commit description is a good > good place to include the output of: > > $ git shortlog 8f43a99..26ae658 > &g

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-05 Thread Doug Evans
On Fri, Mar 5, 2021 at 1:28 PM Samuel Thibault wrote: > Daniel P. Berrangé, le mer. 03 mars 2021 18:11:41 +, a ecrit: > > On Wed, Mar 03, 2021 at 10:06:50AM -0800, Doug Evans wrote: > > > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault < > samuel.thiba

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-05 Thread Doug Evans
On Fri, Mar 5, 2021 at 1:51 PM Doug Evans wrote: > On Fri, Mar 5, 2021 at 1:28 PM Samuel Thibault > wrote: > >> Daniel P. Berrangé, le mer. 03 mars 2021 18:11:41 +, a ecrit: >> > On Wed, Mar 03, 2021 at 10:06:50AM -0800, Doug Evans wrote: >> > > On

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-05 Thread Doug Evans
On Fri, Mar 5, 2021 at 1:28 PM Samuel Thibault wrote: > Daniel P. Berrangé, le mer. 03 mars 2021 18:11:41 +, a ecrit: > > On Wed, Mar 03, 2021 at 10:06:50AM -0800, Doug Evans wrote: > > > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault < > samuel.thiba

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-05 Thread Doug Evans
On Fri, Mar 5, 2021 at 4:10 PM Samuel Thibault wrote: > Doug Evans, le ven. 05 mars 2021 16:05:05 -0800, a ecrit: > > Given that the code is not supposed to be able to know brackets were > present > > (they're stripped off early on), what does the above mean w.r.t. the > gu

[PATCH v6 0/4] Add support for ipv6 host forwarding

2021-04-14 Thread Doug Evans
tighten parsing of ipv6 addresses Change from v1: - libslirp part is now upstream - net/slirp.c changes split into two pieces (refactor, add ipv6) - added docs Doug Evans (4): slirp: Advance libslirp submodule to add ipv6 host-forward support util/qemu-sockets.c: Split host:port parsing out of i

[PATCH v6 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-04-14 Thread Doug Evans
5eraph (2): disable_dns option limit vnameserver_addr to port 53 Akihiro Suda (1): libslirp.h: fix SlirpConfig v3 documentation Doug Evans (11): Add ipv6 host forward support tcpx_listen: Pass sizeof(addr) to memset Reject host forwarding to ipv6 "add

[PATCH v6 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-04-14 Thread Doug Evans
The parsing is moved into new function inet_parse_host_port. Also split out is ipv4=flag, ipv6=flag processing into inet_parse_ipv46. This is done in preparation for using these functions in net/slirp.c. Signed-off-by: Doug Evans --- Changes from v5: Also split out parsing of ipv4=on|off, ipv6

[PATCH v6 4/4] net: Extend host forwarding to support IPv6

2021-04-14 Thread Doug Evans
Net option "-hostfwd" now supports IPv6 addresses. Commands hostfwd_add, hostfwd_remove now support IPv6 addresses. Tested: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v5: Recognize ipv4=,ipv6= options. hmp-commands.hx | 18 ++

[PATCH v6 3/4] net/slirp.c: Refactor address parsing

2021-04-14 Thread Doug Evans
... in preparation for adding ipv6 host forwarding support. Tested: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v5: Use InetSocketAddress and getaddrinfo(). Use new libslirp calls: slirp_remove_hostxfwd, slirp_add_hostxfwd. include/qemu/sockets.h

Re: [PATCH v6 3/4] net/slirp.c: Refactor address parsing

2021-04-15 Thread Doug Evans
On Wed, Apr 14, 2021 at 8:40 PM Doug Evans wrote: > ... in preparation for adding ipv6 host forwarding support. > > Tested: > avocado run tests/acceptance/hostfwd.py > > Signed-off-by: Doug Evans > --- > > [...] > > diff --git a/tests/acceptance/hostfwd.py b/

Re: [PATCH v3 0/3]

2021-02-04 Thread Doug Evans
On Thu, Feb 4, 2021 at 2:03 AM Daniel P. Berrangé wrote: > On Wed, Feb 03, 2021 at 03:35:36PM -0800, dje--- via wrote: > > Add support for ipv6 host forwarding > > > > This patchset takes the original patch from Maxim, > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > > and

Re: [PATCH v3 0/3] Add npcm7xx emc model

2021-02-12 Thread Doug Evans
On Thu, Feb 11, 2021 at 11:48 AM Peter Maydell wrote: > On Thu, 11 Feb 2021 at 11:34, Peter Maydell > wrote: > > > > On Tue, 9 Feb 2021 at 01:55, Doug Evans wrote: > > > > > > This is a 10/100 ethernet device that has several features. > > > Only

Re: [PATCH v3 0/3]

2021-02-18 Thread Doug Evans
On Thu, Feb 11, 2021 at 1:12 AM Daniel P. Berrangé wrote: > [...] > > I think the key useful part to keep common impl for is the handling > of the [] brackets for IPv6 raw addrs. I'd suggest we try to pull the > "address:port" part out into a new inet_addr_parse() helper that can be > called

Re: [PATCH v4 0/3] Add npcm7xx emc model

2021-02-18 Thread Doug Evans
On Wed, Feb 17, 2021 at 3:01 AM Peter Maydell wrote: > On Tue, 16 Feb 2021 at 14:28, Peter Maydell > wrote: > > > > On Sat, 13 Feb 2021 at 00:25, Doug Evans wrote: > > > > > > This is a 10/100 ethernet device that has several features. > > > Only

Re: [PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-19 Thread Doug Evans
On Fri, Feb 19, 2021 at 1:38 AM Daniel P. Berrangé wrote: > On Thu, Feb 18, 2021 at 12:15:35PM -0800, Doug Evans wrote: > > FWIW, normally when QEMU updates libslirp, the commit message is > set to contain the "git shortlog old..new" output > Ah. In this case I'm no

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-19 Thread Doug Evans
On Fri, Feb 19, 2021 at 2:00 AM Daniel P. Berrangé wrote: > On Thu, Feb 18, 2021 at 12:15:36PM -0800, Doug Evans wrote: > > The parsing is moved into new function inet_parse_host_and_port. > > This is done in preparation for using the function in net/slirp.c. > > > >

[PATCH v8 2/3] net/slirp.c: Refactor address parsing

2021-08-13 Thread Doug Evans
... in preparation for adding ipv6 host forwarding support. Tested: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v7: No changes. Changes from v6: Add support for --enable-slirp=system Tested with system libslirp 4.4.0. Changes from v5: Use

[PATCH v8 0/3] Add support for ipv6 host forwarding

2021-08-13 Thread Doug Evans
of ipv6 addresses Change from v1: - libslirp part is now upstream - net/slirp.c changes split into two pieces (refactor, add ipv6) - added docs Doug Evans (3): util/qemu-sockets.c: Split host:port parsing out of inet_parse net/slirp.c: Refactor address parsing net: Extend host forwarding

[PATCH v8 1/3] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-08-13 Thread Doug Evans
The parsing is moved into new function inet_parse_host_port. Also split out is ipv4=flag, ipv6=flag processing into inet_parse_ipv46. This is done in preparation for using these functions in net/slirp.c. Signed-off-by: Doug Evans Reviewed-by: Marc-André Lureau --- Changes from v7: No changes

[PATCH v8 3/3] net: Extend host forwarding to support IPv6

2021-08-13 Thread Doug Evans
Net option "-hostfwd" now supports IPv6 addresses. Commands hostfwd_add, hostfwd_remove now support IPv6 addresses. Tested: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v7: No changes. Changes from v6: No changes. Changes from v5: Recognize

Re: [PATCH] net: Add "info neighbors" command

2021-09-03 Thread Doug Evans
On Fri, Sep 3, 2021 at 6:08 AM Markus Armbruster wrote: > Doug Evans writes: > > > This command dumps the ARP and NDP tables maintained within slirp. > > One use-case for it is showing the guest's IPv6 address(es). > > > > Signed-off-by: Doug Evans >

[PATCH] net: Add "info neighbors" command

2021-09-02 Thread Doug Evans
This command dumps the ARP and NDP tables maintained within slirp. One use-case for it is showing the guest's IPv6 address(es). Signed-off-by: Doug Evans --- hmp-commands-info.hx | 15 +++ include/net/slirp.h| 1 + net/slirp.c| 15

Re: [PATCH v8 0/3] Add support for ipv6 host forwarding

2021-08-30 Thread Doug Evans
Ping. On Fri, Aug 13, 2021 at 4:44 PM Doug Evans wrote: > This patchset takes the original patch from Maxim, > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > and updates it. > > Option hostfwd is extended to support ipv6 addresses. > Commands hostfwd_a

Re: [PULL 1/2] Update libslirp to v4.5.0

2021-07-27 Thread Doug Evans
Hi all. Just checking in to see where we are. I just checked and master is still using the older libslirp. On Fri, Jun 18, 2021 at 11:14 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Fri, Jun 18, 2021 at 8:05 PM Doug Evans wrote: > >> Hi.

[PATCH 1/1] trace: Send "-d trace:help" output to stdout

2020-11-25 Thread Doug Evans via
... for consistency with "-d help". Signed-off-by: Doug Evans --- trace/control.c | 12 ++-- trace/control.h | 3 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/trace/control.c b/trace/control.c index b82fb87316..cd04dd4e0c 100644 --- a/trace/control.c +

[PATCH v3 0/3] Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

[PATCH v3 1/3] hw/net: Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- Differences from v2: - move call

[PATCH v3 2/3] hw/arm: Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans

[PATCH v3 3/3] tests/qtests: Add npcm7xx emc model test

2021-02-08 Thread Doug Evans via
Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences from v2: - remove use of C99 mixed decls/statements tests/qtest/meson.build| 1 + tests/qtest/npcm7xx_emc-test.c | 812 + 2 files

[PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-07 Thread Doug Evans via
Wrapping an IP address in square brackets does not necessarily mean the address is an IPv6 address. The wrapping is just an aid to parsing since IPv6 addresses have colons, but does not provide semantic information. E.g., [127.0.0.1] is a valid way to write 127.0.0.1. Signed-off-by: Doug Evans

[PATCH v4 1/3] hw/net: Add npcm7xx emc model

2021-02-12 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans

[PATCH v4 3/3] tests/qtests: Add npcm7xx emc model test

2021-02-12 Thread Doug Evans via
Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences from v3: - handle big endian hosts, tested on sparc64 Differences from v2: - remove use of C99 mixed decls/statements tests/qtest/meson.build| 1 + tests/qtest

[PATCH v4 2/3] hw/arm: Add npcm7xx emc model

2021-02-12 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans

[PATCH v4 0/3] Add npcm7xx emc model

2021-02-12 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

[PATCH v5 2/3] hw/arm: Add npcm7xx emc model

2021-02-18 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans

[PATCH v5 3/3] tests/qtests: Add npcm7xx emc model test

2021-02-18 Thread Doug Evans via
Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences from v4: - handle --disable-slirp Differences from v3: - handle big endian hosts, tested on sparc64 Differences from v2: - remove use of C99 mixed decls/statements tests/qtest

[PATCH v4 3/4] net/slirp.c: Refactor address parsing

2021-02-18 Thread Doug Evans via
... in preparation for adding ipv6 host forwarding support. New test: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v3: - this patch renamed from 2/3 to 3/4 - call inet_parse_host_and_port from util/qemu-sockets.c - added tests/acceptance/hostfwd.py

[PATCH v4 0/4] Add support for ipv6 host forwarding

2021-02-18 Thread Doug Evans via
libslirp part is now upstream - net/slirp.c changes split into two pieces (refactor, add ipv6) - added docs Doug Evans (4): slirp: Advance libslirp submodule to add ipv6 host-forward support util/qemu-sockets.c: Split host:port parsing out of inet_parse net/slirp.c: Refactor address parsing net

[PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-18 Thread Doug Evans via
Signed-off-by: Doug Evans --- Changes from v3: - pick up latest libslirp patch to reject ipv6 addr-any for guest address - libslirp currently only provides a stateless DHCPv6 server, which means it can't know in advance what the guest's IP address is, and thus cannot do the "add

[PATCH v4 4/4] net: Extend host forwarding to support IPv6

2021-02-18 Thread Doug Evans via
Net option "-hostfwd" now supports IPv6 addresses. Commands hostfwd_add, hostfwd_remove now support IPv6 addresses. Signed-off-by: Doug Evans --- Differences from v3: - this patch renamed from 3/3 to 4/4 - ipv6 support added to existing hostfwd option, commands - instead of creatin

[PATCH v5 0/3] Add npcm7xx emc model

2021-02-18 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

[PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-18 Thread Doug Evans via
The parsing is moved into new function inet_parse_host_and_port. This is done in preparation for using the function in net/slirp.c. Signed-off-by: Doug Evans --- Changes from v3: - this patch is new in v4 - provides new utility: inet_parse_host_and_port, updates inet_parse to use

  1   2   >