On Thu, Jul 12, 2012 at 07:37:26PM +, Blue Swirl wrote:
On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost ehabk...@redhat.com wrote:
[...]
+#ifndef __QEMU_X86_TOPOLOGY_H__
+#define __QEMU_X86_TOPOLOGY_H__
Please remove the leading and trailing underscores. The name should
match
On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote:
[...]
diff --git a/tests/Makefile b/tests/Makefile
index b605e14..89bd890 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -15,6 +15,7 @@ check-unit-y +=
tests/test-string-output-visitor$(EXESUF)
check-unit-y +=
to know what others think about this approach. I think it
is a much simpler approach than relying on some APIC ID = CPU ID
translation to make Seabios and QEMU agree. This way, Seabios has
absolute freedom to choose the ACPI Processor IDs.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
src
On Mon, Jul 16, 2012 at 09:31:30PM -0700, Chegu Vinod wrote:
Changes since v3:
- using bitmap_set() instead of set_bit() in numa_add() routine.
- removed call to bitmak_zero() since bitmap_new() also zeros' the bitmap.
- Rebased to the latest qemu.
Tested-by: Eduardo Habkost ehabk
Otherwise 'make check' won't recompile files that need to be recompiled
because of header changes.
To reproduce the bug, run:
$ make check # succeeds
$ echo B0RKED hw/mc146818rtc_regs.h
$ make check # is supposed to try to rebuild tests/rtc-test.o and fail
Signed-off-by: Eduardo Habkost
On Thu, Jul 19, 2012 at 12:58:46PM +0300, Gleb Natapov wrote:
On Tue, Jul 17, 2012 at 06:56:30PM -0300, Eduardo Habkost wrote:
This patch is an attempt to fix the non-continguous-APIC-ID problem without
the
FW_CFG_LAPIC_INFO approach I have sent proposed last week.
Basically
On Thu, Jul 19, 2012 at 11:28:54AM -0300, Eduardo Habkost wrote:
On Thu, Jul 19, 2012 at 12:58:46PM +0300, Gleb Natapov wrote:
On Tue, Jul 17, 2012 at 06:56:30PM -0300, Eduardo Habkost wrote:
This patch is an attempt to fix the non-continguous-APIC-ID problem
without
CPUs are
present on boot.
Eduardo Habkost (2):
acpi: set I/O APIC ID to 0 by default
allow CPUs to have non-contiguous Local APIC IDs
src/acpi-dsdt.dsl |4 +++-
src/acpi.c| 11 ++-
src/config.h |2 ++
src/mptable.c |2 +-
src/smp.c | 17
When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the
MADT table too.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
src/acpi.c |2 +-
src/config.h |2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/acpi.c b/src/acpi.c
index 55e4607
.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
src/acpi-dsdt.dsl |4 +++-
src/acpi.c|9 +
src/mptable.c |2 +-
src/smp.c | 17 +
src/util.h|1 +
5 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/src/acpi
On Thu, Jul 19, 2012 at 09:12:54PM -0400, Kevin O'Connor wrote:
On Thu, Jul 19, 2012 at 05:52:42PM -0300, Eduardo Habkost wrote:
Extract Local APIC IDs directly from the CPUs, and instead of check for
i CountCPUs, check if the APIC ID was present on boot, when building
ACPI tables
On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote:
On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote:
When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the
MADT table too.
Actually BIOS needs to configure ioapic id to a uniqe value. This does
Small changes from the previous series:
- Patch 1/2: cosmetic whitespace change
- Patch 2/2: use size suffixes on asm instructions on smp.c
- New patch descriptions
Eduardo Habkost (2):
acpi: report real I/O APIC ID (0) on MADT table
allow CPUs to have non-contiguous Local APIC IDs (v2
v1 - v2:
- Cosmetic: whitespace change (removed extra newline)
- New patch description
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
src/acpi.c |2 +-
src/config.h |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/acpi.c b/src/acpi.c
index d39cbd9
be exactly the
same. This patch will simply allow QEMU to start setting non-contiguous
APIC IDs (that is a requirement for some sockets/cores/threads topology
settings).
Changes v1 - v2:
- Use size suffixes on all asm instructions on smp.c
- New patch description
Signed-off-by: Eduardo Habkost ehabk
Hi,
While working at the CPU index vs APIC ID changes, I stumbled upon
another not-very-well-defined interface between SeaBIOS and QEMU, and I
would like to clarify the semantics and constraints of some FW_CFG
entries.
First, the facts/assumptions:
- There's no concept of CPU index or CPU
On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote:
On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost ehabk...@redhat.com wrote:
On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote:
[...]
diff --git a/tests/Makefile b/tests/Makefile
index b605e14..89bd890 100644
On Mon, Jul 23, 2012 at 06:40:51PM +, Blue Swirl wrote:
On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost ehabk...@redhat.com wrote:
Hi,
While working at the CPU index vs APIC ID changes, I stumbled upon
another not-very-well-defined interface between SeaBIOS and QEMU, and I
would
On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote:
On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost ehabk...@redhat.com wrote:
On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote:
On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost ehabk...@redhat.com
wrote:
On Sat, Jul 14
On Mon, Jul 23, 2012 at 07:25:01PM +, Blue Swirl wrote:
On Mon, Jul 23, 2012 at 7:09 PM, Eduardo Habkost ehabk...@redhat.com wrote:
On Mon, Jul 23, 2012 at 06:40:51PM +, Blue Swirl wrote:
On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost ehabk...@redhat.com
wrote:
Hi,
While
On Mon, Jul 23, 2012 at 07:44:44PM +, Blue Swirl wrote:
On Mon, Jul 23, 2012 at 7:28 PM, Eduardo Habkost ehabk...@redhat.com wrote:
On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote:
On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost ehabk...@redhat.com
wrote:
On Mon, Jul 23
On Mon, Jul 23, 2012 at 03:16:30PM +0300, Gleb Natapov wrote:
On Fri, Jul 20, 2012 at 02:04:49PM -0300, Eduardo Habkost wrote:
When resetting an I/O APIC, its ID is set to 0, and SeaBIOS doesn't
change it, so report it correctly on the MADT table.
Some hardware may require the BIOS
On Mon, Jul 23, 2012 at 02:42:27PM +0300, Gleb Natapov wrote:
On Fri, Jul 20, 2012 at 01:22:43PM -0300, Eduardo Habkost wrote:
On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote:
On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote:
When resetting an I/O APIC, its ID
cooper john.coo...@redhat.com
Changes v1 - v2:
- Rebase against latest Qemu git tree
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sysconfigs/target/target-x86_64.conf
b
to compare the flag values in the
config files:
https://gist.github.com/1004885
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf | 36 +-
1 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/sysconfigs/target/target
submission is
at Message-ID: 4ddad5e7.2020...@redhat.com,
http://marc.info/?l=qemu-develm=130618871926030.
Changes v1 - v2:
- Rebase patch against latest Qemu git tree
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |6 +++---
target-i386/cpuid.c
] -- Intel host
[Opteron_G1, Opteron_G2, Opteron_G3] x [F12-64, win64, win32] -- AMD
host
Yielding successful boots in all cases.
Signed-off-by: john cooper john.coo...@redhat.com
Changes v1 - v2:
- Rebase against latest Qemu git tree
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
://marc.info/?l=qemu-develm=130618871926030.
Changes v1 - v2:
- Rebase against latest Qemu git tree
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
sysconfigs/target/target-x86_64.conf |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sysconfigs/target/target-x86_64.conf
as ffxsr, so allow this named to be
used too.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpuid.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index b9bfeaf..aa19260 100644
--- a/target-i386/cpuid.c
://marc.info/?l=qemu-develm=130704282917358
Eduardo Habkost (7):
cpu models: reorder flag list to match bit order
cpu flags: aliases: pclmuldq|pclmulqdq and ffxsr|fxsr_opt
cpu defs: use Intel flag names for Intel models (v2)
cpu defs: add pse36, mca, mtrr to AMD CPU definitions (v2)
cpu defs
separate fro Nehalem allows us to more easily address
such quirks.
[ehabkost: edited commit message to have a better Subject line]
Signed-off-by: john cooper john.coo...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Changes version 1 - version 2:
- Remove
On Wed, Mar 14, 2012 at 06:53:29PM +0100, Andreas Färber wrote:
[...]
+/**
+ * X86CPUClass:
+ * @parent_reset: The parent class' reset handler.
+ *
+ * An x86 CPU model or family.
+ */
+typedef struct X86CPUClass {
+/* private */
+CPUClass parent_class;
+/* public */
+
+
This series change the Makefile to use $(confdir) instead of
$(sysconfdir)/qemu, and allows the full config path configurable instead of
forcing the use of $(sysconfdir)/qemu.
Eduardo Habkost (3):
Makefile: use $(confdir) instead of hardcoding $(sysconfdir)/qemu
qemu-options.hx: refer
some code to qemu-config-arch.c, as it will eventually have
arch-specific features
Eduardo Habkost (3):
qemu-config.h: include qemu-option.h
-readconfig: use QemuOpts option format (v2)
-readconfig: accept fd=fd option (v2)
Makefile.target|2 +-
qemu-config-arch.c | 86
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 1bc3cb0..9d583c4 100644
--- a/Makefile
+++ b/Makefile
@@ -279,8 +279,8 @@ ifdef CONFIG_VIRTFS
$(INSTALL_DATA) fsdev/virtfs
Chhanges v1 - v2:
- Moved code to qemu-config-arch.c
Cc: Ronnie Sahlberg ronniesahlb...@gmail.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
qemu-config-arch.c | 21 +++--
qemu-config.c | 16
qemu-config.h |4
qemu-options.hx
stuff, such as the list of default config files, and
qemu-config.o is not arch-specific.
Changes v1 - v2:
- Create qemu-config-arch.c for the readconfig-specific code
that will depend on arch-specific stuff
Cc: Ronnie Sahlberg ronniesahlb...@gmail.com
Signed-off-by: Eduardo Habkost ehabk
It uses QemuOptList, so it needs qemu-option.h to be included.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
qemu-config.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qemu-config.h b/qemu-config.h
index 20d707f..ba7796c 100644
--- a/qemu-config.h
+++ b/qemu
Instead of hardcoding $sysconfdir/qemu, let the user choose the full
path.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 8b4e3c1..98027c1 100755
--- a/configure
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
qemu-options.hx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index daefce3..39578f1 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2676,8 +2676,8 @@ DEF(nodefconfig, 0
This method will list the paths of all default config files.
This is where the placement of qemu_read_config_arg() on
qemu-config-arch.c becomes necessary: we have to use the list of config
files to implement the new help option.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
qemu
of both the ./configure --confdir and
the -readconfig fd=fd series I submitted earlier today.
Eduardo Habkost (3):
move list of default config files to qemu-config-arch.c
implement -readconfig help=defconfig option
move cpudef config sections to /usr/share/qemu/cpudefs-x86_64.conf
Makefile
On Mon, Mar 19, 2012 at 10:14:54AM -0500, Anthony Liguori wrote:
On 03/19/2012 09:47 AM, Eduardo Habkost wrote:
This series change the Makefile to use $(confdir) instead of
$(sysconfdir)/qemu, and allows the full config path configurable instead of
forcing the use of $(sysconfdir)/qemu
Move the list to an array, with a type field to identify the config
file purpose/type.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c|1 -
arch_init.h|2 --
qemu-config-arch.c | 36
qemu-config-arch.h |4
On Mon, Mar 19, 2012 at 10:10:27AM -0500, Anthony Liguori wrote:
On 03/19/2012 09:54 AM, Eduardo Habkost wrote:
This is a resubmit of a previous series I sent as a RFC, with some changes to
prepare for an upcoming patch that will make additional changes to the
default
config-file loading
in
the future. This patch will make sure management systems can reuse the
cpudefs today using -readconfig, without worrying about how the cpudef
config syntax works.
As agreed on previous discussions, -nodefconfig will disable the loading
of this file, as expected.
Signed-off-by: Eduardo Habkost ehabk
On Mon, Mar 19, 2012 at 10:34:06AM -0500, Anthony Liguori wrote:
On 03/19/2012 10:31 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 10:14:54AM -0500, Anthony Liguori wrote:
On 03/19/2012 09:47 AM, Eduardo Habkost wrote:
This series change the Makefile to use $(confdir) instead
On Mon, Mar 19, 2012 at 10:39:10AM -0500, Anthony Liguori wrote:
On 03/19/2012 10:37 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 10:10:27AM -0500, Anthony Liguori wrote:
On 03/19/2012 09:54 AM, Eduardo Habkost wrote:
This is a resubmit of a previous series I sent as a RFC, with some
On Mon, Mar 19, 2012 at 10:59:35AM -0500, Anthony Liguori wrote:
On 03/19/2012 10:43 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 10:34:06AM -0500, Anthony Liguori wrote:
On 03/19/2012 10:31 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 10:14:54AM -0500, Anthony Liguori wrote
On Mon, Mar 19, 2012 at 05:13:22PM +0100, Paolo Bonzini wrote:
Il 19/03/2012 16:43, Eduardo Habkost ha scritto:
No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm
would carry a patch to configure that changed a fixed PACKAGE_NAME
define.
Are you really suggesting
On Mon, Mar 19, 2012 at 11:21:07AM -0500, Anthony Liguori wrote:
On 03/19/2012 11:06 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 10:39:10AM -0500, Anthony Liguori wrote:
On 03/19/2012 10:37 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 10:10:27AM -0500, Anthony Liguori wrote
On Mon, Mar 19, 2012 at 11:22:26AM -0500, Anthony Liguori wrote:
On 03/19/2012 11:20 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 05:13:22PM +0100, Paolo Bonzini wrote:
Il 19/03/2012 16:43, Eduardo Habkost ha scritto:
No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm
On Mon, Mar 19, 2012 at 11:45:00AM -0500, Anthony Liguori wrote:
On the other hand, I:
- Would like to let the user (a human) list where are the default config
files being used by Qemu;
This should be provided via a QMP command and as part of
-query-capabilities (see previous series).
On Mon, Mar 19, 2012 at 05:31:34PM +0100, Paolo Bonzini wrote:
Il 19/03/2012 17:20, Eduardo Habkost ha scritto:
Anyway, even if we decide that package name shouldn't be changed: why
changing mandir,
This one is because all manpages are under /usr/man/manSECT
docdir and datadir doesn't
On Tue, Mar 20, 2012 at 12:53:57PM +, Liu, Jinsong wrote:
Rik van Riel wrote:
On 03/09/2012 01:27 PM, Liu, Jinsong wrote:
As for 'tsc deadline' feature exposing, my patch (as attached) just
obey qemu general cpuid exposing method, and also satisfied your
target I think.
One
, Eduardo Habkost wrote:
Resurrecting an old thread:
[...]
--
Eduardo
On Mon, Mar 19, 2012 at 10:09:22AM -0500, Anthony Liguori wrote:
This dumps the results of query-version, query-commands, and
query-config-capabilities into a single JSON object on stdout.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
What about a mode where no machine and devices are
On Mon, Mar 19, 2012 at 05:09:57PM +0100, Paolo Bonzini wrote:
Il 19/03/2012 16:09, Anthony Liguori ha scritto:
[...]
I would like to push this series into 1.1
I think it's too early. However, we can definitely apply 1/2/7/8/9 now.
I like patch 3 a lot, too. It would open the door for
This way we can choose a configuration file path different from
${sysconfdir}/PACKAGE.
This also changes the configure output to show the full configuration
dir path (including $confsuffix), instead of just $sysconfdir.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |7
The current docs are wrong: ${sysconfdir} is (by default) /etc,
${confdir} is (by default) /etc/qemu, that's where the config files are
stored.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
qemu-options.hx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu
This is a new try to make the full configuration path configurable.
As the approach using --confdir was rejected because the package name is
something immutable, this adds a option where we can ask Qemu to use a
directory name that is not equal to the package name.
Eduardo Habkost (3
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 1bc3cb0..9d583c4 100644
--- a/Makefile
+++ b/Makefile
@@ -279,8 +279,8 @@ ifdef CONFIG_VIRTFS
$(INSTALL_DATA) fsdev/virtfs
Fix stupid copypaste mistake at commit
ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
optarg on the cpu_list() call.
Reported-by: Jiri Denemark jdene...@redhat.com
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
vl.c |2 +-
1 files changed, 1 insertions(+), 1
On Wed, Mar 21, 2012 at 01:43:58PM +0100, Paolo Bonzini wrote:
Il 20/03/2012 21:15, Eduardo Habkost ha scritto:
The current docs are wrong: ${sysconfdir} is (by default) /etc,
${confdir} is (by default) /etc/qemu, that's where the config files are
stored.
Signed-off-by: Eduardo Habkost
On Wed, Mar 21, 2012 at 01:39:39PM +0100, Paolo Bonzini wrote:
Il 20/03/2012 21:15, Eduardo Habkost ha scritto:
This way we can choose a configuration file path different from
${sysconfdir}/PACKAGE.
This also changes the configure output to show the full configuration
dir path
On Wed, Mar 21, 2012 at 11:23:00PM +0100, Paolo Bonzini wrote:
Il 21/03/2012 15:42, Eduardo Habkost ha scritto:
For this one, we would have compatibility issues to take care of:
./configure --datadir=FOO --sysconfdir=SYS
qemu data dir: FOO
(it would be better if it was FOO/qemu
On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, trying to summarize what was discussed in the call:
On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote:
Let's say we moved CPU definitions
On Thu, Mar 22, 2012 at 02:46:48PM +0100, Andreas Färber wrote:
Am 22.03.2012 14:28, schrieb Stefan Berger:
On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
Fix stupid copypaste mistake at commit
ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
optarg on the cpu_list
On Thu, Mar 22, 2012 at 04:30:55PM +0200, Gleb Natapov wrote:
On Thu, Mar 22, 2012 at 10:31:21AM -0300, Eduardo Habkost wrote:
On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote:
What does this mean? Will -nodefconfig disable loading of bios.bin,
option roms, keymaps
On Thu, Mar 22, 2012 at 11:37:39AM -0500, Anthony Liguori wrote:
On 03/22/2012 04:32 AM, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, this problem is solved if the defaults are easily found on
/usr/share.
What problem is solved and why are we
On Fri, Mar 23, 2012 at 03:49:27AM +, Liu, Jinsong wrote:
Eduardo Habkost wrote:
[1] From Documentation/virtual/kvm/api.txt:
KVM_GET_SUPPORTED_CPUID
[...]
This ioctl returns x86 cpuid features which are supported by both the
hardware and kvm. Userspace can use the information
On Sun, Mar 25, 2012 at 12:19:13PM +0200, Gleb Natapov wrote:
(That's why I said that perhaps keymaps could become configuration
someday. Because maybe they can be converted to a key=value model
relatively easily)
Such whole sale approach is harmful since it starts to affect design
On Mon, Mar 26, 2012 at 02:03:21PM +0200, Gleb Natapov wrote:
On Mon, Mar 26, 2012 at 01:59:05PM +0200, Avi Kivity wrote:
On 03/26/2012 01:24 PM, Jiri Denemark wrote:
...
The command line becomes unstable if you use -nodefconfig.
-no-user-config solves this but I fully expect
On Sun, Mar 25, 2012 at 01:11:04PM -0500, Anthony Liguori wrote:
On 03/25/2012 10:40 AM, Avi Kivity wrote:
On 03/25/2012 05:26 PM, Anthony Liguori wrote:
Put the emphasis around *configuration*.
So how about:
1) Load ['@SYSCONFDIR@/qemu/qemu.cfg',
'@SYSCONFDIR@/qemu/target-@ARCH@.cfg',
As now that block handles only the prefix variable, the code can be much
simpler. This also removes the CONFIG_QEMU_PREFIX define as it is not
used by any C code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
scripts/create_config |7 +--
1 files changed, 1 insertions(+), 6
This will allow the user to make Qemu use a different subdirectory name
inside $datadir and $sysconfdir, instead of /qemu.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index
Instead of hardcoding the directory suffix, use the qemu-specific
directory variable.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 605f1aa..bda3680 100644
--- a/Makefile
+++ b
The autoconf docdir variable is used for the program-specific
subdirectory, but anyway it's better to make it clear that the variable
is used for the qemu-specific subdirectory path.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |8
1 files changed, 4 insertions
There's no confdir variable on Autoconf, but it's good to make it
clear that it's a variable for the Qemu-specific subdirectory inside
$sysconfdir.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
There is no code using that variable according to 'git grep', so kill
it.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index fc206ff..b02dfa3 100755
--- a/configure
+++ b/configure
on create_config is removed:
create_config: remove *dir block
create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX
Finally, the user-visible changes:
configure: change meaning of --datadir to Autoconf convention
configure: add --confsuffix option
Eduardo Habkost (14
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile |4 ++--
configure |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index bda3680..a308471 100644
--- a/Makefile
+++ b/Makefile
@@ -267,8 +267,8 @@ BLOBS=
endif
install-doc
Cosmetic change.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index b02dfa3..5de58cb 100755
--- a/configure
+++ b/configure
@@ -2973,10 +2973,10 @@ echo bindir=$bindir
) for
both datadir and qemu_datadir variables.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile|8
Makefile.target |4 ++--
configure |2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index d8e1f36..605f1aa 100644
-by: Eduardo Habkost ehabk...@redhat.com
---
configure | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 14ef738..97294a6 100755
--- a/configure
+++ b/configure
@@ -155,7 +155,7 @@ mingw32=no
EXESUF=
prefix=/usr/local
mandir=\${prefix}/share/man
(CONFIG_QEMU_CONFDIR) for
both confdir and qemu_confdir variables.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index 15bb48d..58c6f17 100755
--- a/configure
+++ b/configure
@@ -2976,7 +2976,7
Autoconf uses --datadir for the /usr/share directory, not the
program-specific subdirectory inside /usr/share. This changes configure
to match autoconf behavior.
Note that this will break compatibility with existing build scripts.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure
CONFIG_QEMU_XXXDIR as
well (instead of becoming a CONFIG_QEMU_QEMU_XXXDIR define).
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
scripts/create_config |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/scripts/create_config b/scripts/create_config
index 0098e68
This patch keeps the 'prefix=*' (CONFIG_QEMU_PREFIX) pattern because
other variables may use $prefix on their config-host.mak definitions.
The remaining code will be simplified on a further patch.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
scripts/create_config |2 +-
1 files changed
On Wed, Apr 04, 2012 at 05:26:10PM +0200, Paolo Bonzini wrote:
Il 30/03/2012 19:33, Eduardo Habkost ha scritto:
[...]
-echo --sysconfdir=PATHinstall config in PATH/qemu
+echo --sysconfdir=PATHinstall config in PATH$confsuffix
+echo --with-confsuffix=SUFFIX suffix
On Wed, Apr 04, 2012 at 05:25:14PM +0200, Paolo Bonzini wrote:
Il 30/03/2012 19:33, Eduardo Habkost ha scritto:
Autoconf uses --datadir for the /usr/share directory, not the
program-specific subdirectory inside /usr/share. This changes configure
to match autoconf behavior.
Note
Autoconf uses --datadir for the /usr/share directory, not the
program-specific subdirectory inside /usr/share. This changes configure
to match autoconf behavior.
Note that this will break compatibility with existing build scripts.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure
Instead of hardcoding the directory suffix, use the qemu-specific
directory variable.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 1c9abec..795f9c4 100644
--- a/Makefile
+++ b
:
create_config: remove *dir block
create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX
Finally, the user-visible changes:
configure: change meaning of --datadir to Autoconf convention
configure: add --with-confsuffix option
Eduardo Habkost (14):
configure: rename $datadir
CONFIG_QEMU_XXXDIR as
well (instead of becoming a CONFIG_QEMU_QEMU_XXXDIR define).
Changes v1 - v2:
- Rebase on top of newer qemu.git changes, that changed
tr '[:lower:]' '[:upper:]' to LC_ALL=C tr '[a-z]' '[A-Z]'.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
scripts/create_config |9
(CONFIG_QEMU_CONFDIR) for
both confdir and qemu_confdir variables.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index 76144aa..7009030 100755
--- a/configure
+++ b/configure
@@ -2983,7 +2983,7
There is no code using that variable according to 'git grep', so kill
it.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index f15b714..eca08bb 100755
--- a/configure
+++ b/configure
The autoconf docdir variable is used for the program-specific
subdirectory, but anyway it's better to make it clear that the variable
is used for the qemu-specific subdirectory path.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |8
1 files changed, 4 insertions
This will allow the user to make Qemu use a different subdirectory name
inside $datadir and $sysconfdir, instead of /qemu.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
configure |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index
) for
both datadir and qemu_datadir variables.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile|8
Makefile.target |4 ++--
configure |2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index 35c7a2a..1c9abec 100644
401 - 500 of 11343 matches
Mail list logo
