nCapabilitiesStatus
> +#
> +# Since: 1.2
> +##
> +{ 'command': 'query-migrate-capabilities', 'returns':
> ['MigrationCapabilityStatus']}
...and 'query-migrate-capabilities' return the same information. So we
don't need two comma
ram-duplicate: A kbytes
> +transferred ram-normal: B kbytes
> +transferred ram-xbrle: C kbytes
> +overflow ram-xbrle: D pages
> +cache-miss ram-xbrle: E pages
Names such as 'ram-xbrle' do not match the code in the remainder of this
series; make sure this example is accurate.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
+Example:
> +
> +-> { "execute": "query-migrate-cache-size" }
> +<- { "return": { "size":"67108864" } }
...this example is returning a JSON object '{"size":"67108864"}' instead
of an int '67108864
gt;
> @@ -2152,7 +2166,10 @@ Examples:
> "ram":{
> "transferred":123,
> "remaining":123,
> -"total":246
> +"total":246,
> +"duplicate":123,
> +"normal":123,
> +"normal-bytes":123456
Again, need total-time.
> }
>}
> }
> @@ -2166,7 +2183,10 @@ Examples:
> "ram":{
> "total":1057024,
> "remaining":1053304,
> -"transferred":3720
> +"transferred":3720,
> +"duplicate":123,
> +"normal":123,
> +"normal-bytes":123456
and again.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
_pages;
> +uint64_t xbzrle_bytes;
> +uint64_t xbzrle_pages;
> +uint64_t xbzrle_cache_miss;
> uint64_t iterations;
> +uint64_t xbzrle_overflows;
Any reason you stagger where these stats are stored, rather than piling
them all at the end?
--
Eric Blake ebl..
On 08/06/2012 10:04 AM, Orit Wasserman wrote:
> On 08/06/2012 05:26 PM, Eric Blake wrote:
>> On 08/05/2012 03:13 AM, Orit Wasserman wrote:
>>> The management can enable/disable a capability for the next migration by
>>> using
>>> migrate-set-apabilities QMP
I think this should be:
{ "return": 67108864 }
That's based solely off my reading of the schema, and not of the code
itself, so please actually execute your code, to see what really came
over the wire.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
are fixing
an unreleased naming glitch). Also, I would suggest rebasing this to
occur before 9/11.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
s already being discarded via your
query-migrate-supported-capabilities command). That is, your
implementation for query-migrate-capabilities is sufficient to satisfy
both class of users, without needing query-migrate-supported-capabilities.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
al and duplicate pages
> Add XBZRLE statistics
We've been through the wringer on this one, but I'm now comfortable
giving a series:
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
nsions will probably result in a noisy testsuite failure rather than
silent disk corruption, I'm okay overlooking this non-portable aspect
for now. (Not to mention that you're not the first offender, seeing
that cluster_size earlier in the context also used \+.)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/06/2012 03:54 PM, Eric Blake wrote:
> On 08/06/2012 02:44 PM, Kevin Wolf wrote:
>> qemu-iotests already filters out image creation options that may be
>> present or not in order to get the same output in both cases. However,
>> often it only considers the default value
ype=pseries,?' to see what options the given
machine has, and preferably through a QMP interface rather than through
the command line.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
re not closed until @refcount is zero,
> +#and either @in_use is false or @removed is true.
> +#
> +##
> +{ 'command': 'query-fdsets', 'returns': ['FdsetInfo'] }
> diff --git a/qerror.c b/qerror.c
> index 92c4eff..63a0aa1 100644
> ---
f both options can be used together, but cannot both be omitted, then
this style works:
{ -foo [ -bar ] | -bar }
Mutually exclusive options, but where omission is okay, would then be:
[ { -foo | -bar } ]
or even this variant, to express the default when both are omitted:
{ -foo | [ -bar ] }
same character as the separator (whether you end up with : or , as
the separator)? If you support a larger quorum (whether always n/(2n-1)
or whether fully configurable n/m), rather than hard-coded 2/3, then you
also need a way to specify how many quorum members will follow.
--
Eric Blake ebl...@
ually find useful, once I complete some
counterpart libvirt patches. If libvirt can get by without any extra
information and without needing to hack things from procfs, then it's
not worth you spending the effort coding something that will be ignored;
conversely, if a piece of info is so important that I end up hacking
procfs anyways, that says we have a hole in QMP. I'm okay waiting for now.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
elp in implementing Daiki's
patchset for calling an arbitrary command and knowing whether to block
on expecting a response rather than forcing the user to know which magic
--timeout values to use.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
fact, even nicer than returning a markup of O_RDONLY
- if the management app cares about knowing details on an fd, such as
whether it is read-only, then an opaque string tied to the fd in the
fdset becomes very useful. The string needs to be optional on add-fd.
(Libvirt might even use an xml-like string like "", but of course, being an opaque
string, qemu doesn't have to care what the string contains.)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/09/2012 09:01 AM, Kevin Wolf wrote:
> Instead of building a huge pipeline, just pass all expressions to a
> single sed process.
>
> Suggested-by: Eric Blake
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/common.rc | 20 ++--
> 1 file
the event arrives may break if the event arrives after the guest
> is already running.
Yeah, no problem with that semantic change from libvirt.
> +WAKEUP
> +--
> +
> +Emitted when the guest has been waken up from S3 and is running.
grammar:
s/has been waken/has woken/
o
? I'm assuming those
were blank lines, and that spacing is more consistent now, but it's
nicer to see a code motion patch with matching diffstat.
Reviewed-by: Eric Blake
>
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index b8afedb..e37a04e 100644
> --- a/QMP/qmp-
uot;: { "seconds": 1344456160, "microseconds": 309119 } }
> +
> +Note: QEMU shutdowns when entering S4 state.
s/shutdowns/shuts down/
Is that true when you use the -no-shutdown flag? Do you get this event
if you did not use the -no-shutdown flag?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/09/2012 11:28 AM, Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino
> ---
> QMP/qmp-events.txt | 12
> 1 file changed, 12 insertions(+)
Reviewed-by: Eric Blake
>
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index e37a04e..2001a71 1
ather go through QMP than any
new syntax when talking to newer qemu (that is, I'm okay if we
completely lose the spelling as long as we don't lose the feature).
>
> Any suggestions for what the sane syntax for these options would be?
> (ie the analogous change to having '?
comma
> + "fds": [
> + {
> + "fd": 21,
JSON does not permit trailing commas.
> + },
> + {
> + "fd": 23,
and again
> + }
> + ],
> + },
> + {
> + "fdset-id": 2
missing a comma
> + "fds": [
> + {
> + "fd": 22,
trailing comma
Also, it might be nice to include something like:
"opaque":"rdonly:/path/to/file"
in one of the examples to give a hint to the reader how to use opaque.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
if (fd == -1) {
> +return -1;
> +}
> +
> +ret = monitor_fdset_dup_fd_add(fdset_id, dupfd);
> +if (ret == -1) {
> +return -1;
Leaks dupfd (admittedly only on a corner-case failure, but still worth
addressing).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the list of dup'd fds that are tied to
the set until a call to qemu_close. That is, a set must remain alive as
long as there is either an add-fd that has not yet been removed, or
there is at least one dup'd fd that has not been qemu_close()d.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
> @@ -1382,10 +1380,7 @@
> # Returns: a list of @ObjectPropertyInfo that describe the properties of the
> # object.
> #
> -# Since: 1.1
> -#
> -# Notes: This command is experimental. It's syntax may change in future
Yay, getting rid of bad grammar in the proces
On 08/10/2012 11:44 AM, Luiz Capitulino wrote:
> Besides of being unused, they operate on the current error format,
s/ of//
> which is going to be replaced soon.
>
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
sign
"fds": [
> + {
> + "fd": 30,
> + "opaque": "rdonly:/path/to/file"
> + },
> + {
> + "fd": 24,
> + "opaque": "rdwr:/path/to/file"
> + }
> +
ntees a reasonable
errno, and even if it does, close() can corrupt errno. I think that
prior to returning here, you either need an explicit errno=ENOMEM, or
fix monitor_fdset_dup_fd to guarantee a nice errno, plus a save and
restore of errno here. Unless no one cares about errno on failure, in
which case yo
p-commands.hx for the examples (but your cover letter mentioned
that).
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
gt;
> - luiz added in case he has QMP commets.
>
> - erik added for libvirt comments.
Eric, actually.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/13/2012 04:50 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> migration.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http:/
PRIu64 " milliseconds\n",
> info->total_time);
> +if (strcmp(info->status, "completed") == 0) {
> +monitor_printf(mon, "downtime: %" PRIu64 " milliseconds\n",
> + info->downt
On 08/13/2012 09:02 AM, Eric Blake wrote:
> On 08/13/2012 04:50 AM, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> hmp.c| 4
>> migration.c | 5 -
>> migration.h | 1 +
>> qapi-schema.json | 6 +-
&
't transferred anything this round, force
> + * expected_downtime to a a very high value, but without
s/a a/a/
Latent typo, but the reformatting exposes it more. With that fixed,
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualiz
On 08/13/2012 04:50 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> migration.c | 2 +-
> migration.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualizati
Should this field be marked optional? That is, it makes sense to expose
the field while migration is ongoing, but when reporting the stats after
migration is complete, there is no longer any expected downtime.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library
d by second by the
> +#guest. (since 1.2)
Inconsistent on whether we have a '.' prior to the (since 1.2) marking.
Since HMP only prints this stat when it is non-zero, should this field
be marked optional? Then again, once you have dirty page tracking, I
suspect this would ne
for this information.
I guess with XBZRLE, you _do_ have a count of how many cache hits you
had, which is somewhat related (a cache hit implies sending a page more
than once).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ther than failing with ENOMEM)?
And the more I think about it, the more I think that qemu_open MUST
provide a sane errno value on exit, so you need to make sure that all
exit paths out of qemu_open have a sensible errno (whether or not the
helper functions also have to leave errno sane is a matter o
o don't let libvirt hold up the inclusion of this
useful information on the qemu side of things.
Maybe another option would be to return [U]INT_MAX when there is not
enough data to yet provide a valid number, where having a non-zero value
at least lets people know that the stat will be available in
we have in v10 if that's ok.
The problems of reading my inbox in FIFO order - I see now that v10
landed before my comments on v9 :) Yes, what you did in v10 is probably
fine.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
; block: Enable qemu_open/close to work with fd sets
> monitor: Clean up fd sets on monitor disconnect
Hooray - I think we're there! Series:
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
gt; info->ram->transferred = ram_bytes_transferred();
>> info->ram->remaining = ram_bytes_remaining();
>> info->ram->total = ram_bytes_total();
>> +info->ram->total_time = qemu_get_clock_ms(rt_clock)
>> +
ncy).
> - It works as early as serial console output does (panics before
> that should be rare).
> - It allows you to see why the guest panicked.
I think your arguments for a serial console have already been made and
refuted in earlier versions of this patch series, which is WHY this
series
6: error: overflow in implicit constant conversion
>
> Fix this by making the cast explicit, rather than implicit.
>
> Signed-off-by: Alexander Graf
> ---
> savevm.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Reviewed-by: Eric Blake
>
> dif
names[i] = '\0';
> +s->filenames[j] = names + i + 1;
> +j += 1;
Isn't this usually written 'j++'?
> +}
> +
> +if (!escape && names[i] == '\\') {
> +escape = 1;
this implementation right? Shouldn't this be a quorum decision,
where all s->bs[...] elements have to agree on the same size, or even
where they can differ on size, as long as all files with larger size
have unallocated holes past the size of the smaller member?
--
Eric Blake e
t; script
> use it.
> Would an additional -json option to qemu-img info be welcome ?
Yes, please. See also:
https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03835.html
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.
_t ier;// interrupt enable register
> +
> +int _derived int_pending; // whether we have a pending queued
> interrupt
> +CharDriverState _immutable *chr;
Now you've changed the example; before it used QIDL(immutable).
> +Variable Sized, Fixed Ca
short option of
'-j' even if the long option is spelled '--format', even if it means a
theoretical addition of '--format=xml' would map to the odd-looking '-j
xml'.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-exec' rather than unsafe 'find | xargs'
> or unportable 'find -print0 | xargs -0'.
>
> Makefile | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virt
Jeff - where do we stand on block-commit and friends?
https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04293.html
Libvirt would really love to target these commands in qemu 1.2; I'm more
than willing to do some speedy reviews before the hard freeze deadline
if you have rebased series rea
> If there are existing patches and/or pull requests on the mailing list
> that you think should be in 1.2, please respond to the email with a
> pointer to the mail.
I think the latest block patches should be marked for-1.2:
https://lists.gnu.org/archive/html/qemu-devel/2012-08/msg02836.
On 08/15/2012 08:51 AM, Jeff Cody wrote:
> On 08/15/2012 10:36 AM, Eric Blake wrote:
>> On 08/15/2012 08:22 AM, anth...@codemonkey.ws wrote:
>>>
>>> Hi,
>>>
>>> Today is the hard freeze for 1.2. If you have any pull requests and/or
>>> patc
Should this be #optional, in the case where there are no snapshots?
> +#
> +# Since: 1.3
So no way it will make 1.2 hard freeze today :)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
{"help", no_argument, 0, 'h'},
> +{"format", required_argument, 0, 'f'},
> +{"machine", required_argument, 0, 'm'},
> +{0, 0, 0, 0}
> +};
> +c = getopt_long(argc, argv, "f
.html
and it's already in the ppc PULL request:
https://lists.gnu.org/archive/html/qemu-devel/2012-08/msg02755.html
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
m qemu-img in 1.2:
https://lists.gnu.org/archive/html/qemu-devel/2012-08/msg02864.html
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/15/2012 10:17 AM, Eric Blake wrote:
> On 08/15/2012 08:54 AM, Benoît Canet wrote:
>> Signed-off-by: Benoit Canet
>> ---
>> qapi-schema.json | 33 +
>> 1 file changed, 33 insertions(+)
>> +# @ImageInfo:
>> +#
&g
e for the VM clock? Is that additional
precision available for querying?
I have no problem if you want to squash patches 1 and 2 together into a
single commit.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
r propagation, ctxt->err must be freed seperately */
s/seperately/separately/
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ve", "arguments": { "name": "my_snapshot" } }
> +<- { "return": {} }
Again, you need to return the id of the just-created snapshot.
> @@ -2176,21 +2174,20 @@ void do_savevm(Monitor *mon, const QDict *qdict)
> }
>
> /* Delete old snapshots of the same name */
> -if (name && del_existing_snapshots(name, NULL) < 0) {
> +if (has_name && del_existing_snapshots(name, errp) < 0) {
Here's hoping later in the series updates this to make saner decisions.
(Maybe I should peruse the entire series before commenting on
individual patches?)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/15/2012 12:45 PM, Michael Roth wrote:
> Signed-off-by: Michael Roth
> ---
> qlist.c | 13 +
> qlist.h |1 +
> 2 files changed, 14 insertions(+)
No cover-letter?
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt
h valgrind, make check, and QMP.
>
> Signed-off-by: Michael Roth
> ---
> json-parser.c | 230
> +++--
> 1 file changed, 142 insertions(+), 88 deletions(-)
I'm not the most familiar with this code, so take my review with a grain
of salt, but I read through i
+#
> +# Set the whole virtual machine to the snapshot identified by the tag
> +# 'tag' or the unique snapshot ID 'id'.
> +#
> +# @name: tag or id of existing snapshot
> +#
> +# Returns: Nothing on success
> +# If an error occurs, GenericError with error m
On 08/15/2012 09:31 PM, Eric Blake wrote:
>
>> +
>> +##
>> +# @vm-snapshot-load:
>> +#
>> +# Set the whole virtual machine to the snapshot identified by the tag
>> +# 'tag' or the unique snapshot ID 'id'.
>> +#
>> +# @name:
to load offline snapshots, it might be worth an
additional field in the JSON that says whether a snapshot is online or
offline, to make it easier for the parsing application to determine
whether it can be loaded or must go through qemu-img while the guest is
offline (then again, keeping vm-state-si
val = 0;
> +} else if (*typestr == '?') {
> +typestr++;
> +break;
> } else {
> monitor_printf(mon, "Expected 'on' or 'off'\n");
>
ed on the JSON below, this needs an #optional marking, as well as
mentioning that the default is false.
> #
> # Returns: Nothing on success
> # If an error occurs, GenericError with error message
Knowing that a creation failed due to a snapshot already existing by the
same name or id might be worth a distinct error class (do we already
have an error class that we could reuse?)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
erations. Also, be
aware that querying an image that is being modified by another process
may encounter inconsistent state.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/16/2012 07:35 AM, Kevin Wolf wrote:
> Am 16.08.2012 14:56, schrieb Eric Blake:
>> On 08/16/2012 04:00 AM, Peter Maydell wrote:
>>> On 16 August 2012 10:00, Kevin Wolf wrote:
>>>> People have repeatedly expected that you can do things like snapshotting
>&
7;type': 'MigrationInfo',
>'data': {'*status': 'str', '*ram': 'MigrationStats',
> '*disk': 'MigrationStats',
> - '*xbzrle-cache': 'XBZRLECacheStats'} }
> + '*xbzrle-cache': 'XBZRLECacheStats',
> + 'total-time': 'int'} }
Anthony - are you planning on taking this series for 1.2? If we don't
get this patch in on time, then taking this for 1.3 would result in
changing released QMP interface (right now, there has been no release
with the field in the wrong type).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
formation (in bytes):
> - "transferred": amount transferred (json-int)
> @@ -2279,6 +2281,7 @@ Examples:
>"remaining":123,
>"total":246,
>"total-time":12345,
> + "expected-downtime&q
t;status" is "active", it is a json-object with the
>following RAM information (in bytes):
> - "transferred": amount transferred (json-int)
> @@ -2305,6 +2308,7 @@ Examples:
> "remaining":123,
> "total":246,
>
On 08/19/2012 10:39 PM, Amos Kong wrote:
> This series converted 'sendkey' command to qapi. The raw value
> in hexadecimal format is not supported by 'send-key' of qmp.
Are we still trying to get this into 1.2, or have we missed that deadline?
--
Eric Blake ebl..
even better, since mixing 'e.g.' and 'etc.' in the same sentence
sounds stupid, just go with the much simpler:
@arch: the name of the target architecture (such as "x86_64" or "i686")
> +# @bits: number of bits in physical address (eg 32 or 64)
Ditto.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
\ escapes itself (although admittedly : is more likely than \ in a
file name needing escaping).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
pi-schema-guest.json
> +++ b/qapi-schema-guest.json
> @@ -91,10 +91,14 @@
> #
> # @enabled: whether command is currently enabled by guest admin
> #
> +# @success-response: whether command report success response or not.
> +# See 'uest-shutdown' command
On 08/21/2012 06:17 AM, Eric Blake wrote:
> On 08/21/2012 06:03 AM, Michal Privoznik wrote:
>> This is a useful hint for users (or libvirt) whether a command returns
>> anything success and hence wait for reply or not.
>> +++ b/qapi-schema-guest.json
>> @@ -91,10 +91
n this information from QMP commands than
from scraping -help output. Can we get at all of this information from QMP?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t; Have I got it right?
Yes - if the user is going to issue arbitrary guest agent commands, and
we know the command won't reply on success, we should still wait a
reasonable amount of time for an error, but we should also return
control to the caller to allow them to detect the command
mainGetHostname).
> Cheers
> -- Guido
Still, this feels like a new feature and not a bug fix, so
> +
> +##
> +# @guest-get-hostname:
> +#
> +# Get the guest's hostname
> +#
> +# Returns: The guest's hostname
> +#
> +# Since: 1.2
...this should probably b
f the backing file
> +#
> +# @full-backing-filename: #optional full path of the backing file
> +#
> +# @backing-filename-format: #optional the format of the backing file
> +#
> +# @snapshots: #optional list of VM snapshots
> +#
> +# Since: 1.2
Again, 1.3.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
name, backing_filename2) != 0) {
> -printf(" (actual path: %s)", backing_filename2);
> -}
> -putchar('\n');
> +
> +if (json) {
> +collect_snapshots(bs, info);
> +dump_json_image_info(info);
> }
> -dump_snapshots(bs);
> +
> +qapi_free_ImageInfo(info);
...you will end up with no output. You want to default to human output
for back-compat to older usage.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
would result in
>> changing released QMP interface (right now, there has been no release
>> with the field in the wrong type).
>
> Ack. We need to preserve compat with the 1.2 interface.
Yes, this particular patch 3 is a bug fix in order to prevent a future
regression when 1.
nd fraction, for the same reasoning? My point is
that we have two different bike shed colors showing in this one API, but
I would prefer we be consistent and pick just one (as to _which_ color,
I can be persuaded either way).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtua
+# Information describing the QEMU target.
> +#
> +# @arch: the target architecture (eg "x86_64", "i386", etc)
Missed my v1 comment that 'eg' is misspelled (would be 'e.g.'), and with
my recommendation for an alternate wording:
@arch: the tar
fall back to -help scraping (since
older versions won't be further modifying their -help output now that
they are released). I like the idea, although I'm not familiar enough
with this part of the code to know if my review counts for anything:
Reviewed-by: Eric Blake
--
Eric Blake
+++ b/qapi-schema.json
> @@ -235,6 +235,34 @@
> ##
> { 'command': 'query-chardev', 'returns': ['ChardevInfo'] }
>
> +{ 'enum': 'DataFormat'
> + 'data': [ 'utf8', 'base64' ] }
Missing do
'size': 'int', '*format': 'DataFormat'},
> + 'returns': 'str' }
While writing can default to UTF-8, I'm worried about reading - does
encoding in UTF-8 allow transmission of NUL bytes through JSON, or do
you have to use base64 to allow full binary data through? What happens
if the data read includes a NUL byte that can't be encoded back into the
requested DataFormat?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ossibly for 1.2, since it improves documentation?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
eems
okay for 1.3 from my viewpoint.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/26/2012 12:38 AM, Yonit Halperin wrote:
> On 08/21/2012 03:31 PM, Eric Blake wrote:
>> On 08/21/2012 04:54 AM, Yonit Halperin wrote:
>>> Added all spice options to the help string. This can be used by libvirt
>>> to determine which spice related features are s
is now mandatory on the command line.
This statement is not true, but doesn't affect the series itself.
> in v6:
>
> Blue Swirl: -Add missing const in getopt structure declaration.
>
> Eric Blake: -Remove spurious undef.
> -Use an enum instead of two boolean.
rum files "img,test.raw", "img2.raw"
> and "img3.raw" invocation look like:
>
> -drive file=quorum:2/3:img\\,,test.raw,,img2.raw,,img3.raw
> (note the double ,, and \\)
Yes, that's what I'm worried about.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ncy, does
reading the contents beyond the end of the shorter files consider the
contents to be okay if the longer files have only NUL bytes in the extra
length? I'm worried that you haven't fully thought through all the
scenarios here.
--
Eric Blake ebl...@redhat.com+1-919-301-
1 - 100 of 23137 matches
Mail list logo
