| 20 ++--
5 files changed, 31 insertions(+), 26 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
/libqtest.c | 66
tests/libqtest.h | 37 +++
2 files changed, 89 insertions(+), 14 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
+static void qmp_response(JSONMessageParser *parser, QList *tokens
-by: Stefan Hajnoczi stefa...@redhat.com
---
tests/Makefile| 2 ++
tests/blockdev-test.c | 59
+++
2 files changed, 61 insertions(+)
create mode 100644 tests/blockdev-test.c
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake
Hajnoczi stefa...@redhat.com
---
tests/Makefile| 2 ++
tests/qdev-monitor-test.c | 81
+++
2 files changed, 83 insertions(+)
create mode 100644 tests/qdev-monitor-test.c
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake
is
the first member of dev, so it is the same pointer address.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
files changed, 20 insertions(+), 0 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 11/04/2013 05:37 PM, Wenchao Xia wrote:
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
Cc: qemu-sta...@nongnu.org
---
tests/test-qmp-input-visitor.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
You should repost your mem
:
+sys.stderr.write(Base '%s' is not a valid type\n
+ % base)
+sys.exit(1)
+
+descriminator_type = base_fields.get(discriminator)
s/descriminator/discriminator/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
+-
tests/qapi-schema/qapi-schema-test.out |4 +++-
3 files changed, 18 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
class. By
using a non-name character, it becomes more obvious that the leading
character has a special meaning to the qapi generator.
I'm also not convinced yet that we want this shorthand; in particular,
I'm worried whether it will make the introspection patches harder to write.
--
Eric Blake
additional digits, or any other odd behavior.
By the time you've added code to sanitize untrusted input, it's just as
fast to use strtol() anyways.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
CONFIG_NETMAP
+-net netmap,ifname=name[,vlan=n][,devname=name]\n
So where does the optional vlan command-line option appear in the QMP
interface?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
constant is too large for 'long'
type
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
tests/endianness-test.c | 3 ++-
tests/test-bitops.c | 4 ++--
tests/test-opts-visitor.c | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
-by: Eric Blake ebl...@redhat.com
Still, wouldn't it be easier to patch error_setg_errno (and friends) to
guarantee that errno is unchanged on exit compared to its value on
entrance, rather than having to audit for other mistakes like this?
diff --git a/block.c b/block.c
index 58efb5b..0e96a22
it in 1.7), as well as removing mention of it being experimental.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
union types in the meantime,
my understanding is Amos is planning on posting another version soon for
the 1.8 timeframe.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
it was never broken.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/i386/pc_piix.c| 7 ---
hw/i386/pc_q35.c | 7 ---
hw/misc/pvpanic.c| 5 -
include/hw/i386/pc.h | 1 -
4 files changed, 20 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake
': { 'passthrough' : 'TPMPassthroughOptions',
+ 'libtpms' : 'TPMLibtpmsOptions' } }
Otherwise it looks okay to me.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
that it will always be non-NULL in that case (none with
absolute-paths).
Signed-off-by: Max Reitz mre...@redhat.com
---
blockdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake ebl...@redhat.com
diff --git a/blockdev.c b/blockdev.c
index b260477..1c426b0 100644
Objections?
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
docs/rdma.txt| 24 ++--
migration-rdma.c |2 +-
migration.c |6 +++---
qapi-schema.json |7 +++
4 files changed, 17 insertions(+), 22 deletions(-)
Reviewed-by: Eric Blake ebl
to me.
Thanks for the comments. I'll add them to the next version. Can I add
your Reviewed-by to this patch?
Yes, now that I've looked at the full patch (and not just the .json):
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
+ int dirty_flag)
Indentation off by one.
But whitespace doesn't impact the patch, so you can mark 1 through 6 as:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301
.
For 7 and 8,
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
(-)
But the code is correct.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
not worth respinning that patch just for
whitespace. And since my subsequent nits in commit headers could be
touched up by a maintainer when adding my Reviewed-by, you may have
escaped a respin if the rest of the series is clean :)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake
---
3 files changed, 13 insertions(+), 11 deletions(-)
But the code looks correct. For 14-19,
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
changed, 18 insertions(+), 17 deletions(-)
For 19-23,
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
/memory-internal.h | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
For 24-27,
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
(errp, Could not open backing file: %s,
+ error_get_pretty(local_err));
return ret;
Needs a v2, that doesn't leak local_err.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
-off-by: Max Reitz mre...@redhat.com
---
Follow-up to:
- block/drive-mirror: Check for NULL backing_hd
---
qapi-schema.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake ebl...@redhat.com
Trivial enough to include in 1.7, if desired.
--
Eric Blake eblake
and fix all of these
constructs, just make sure error_setg() and error_setg_errno() indeed do
not clobber errno.
Suggested-by: Eric Blake ebl...@redhat.com
Signed-off-by: Max Reitz mre...@redhat.com
---
util/error.c | 6 ++
1 file changed, 6 insertions(+)
Reviewed-by: Eric Blake ebl
there are no duplicate
node names (other than the magic undefined)?
Seems like it's moving in the right direction, although I'm not sure
it's worth applying this until we know the qapi for working with node
names makes sense.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
?
Overall, I'm looking forward to getting this into qemu 1.8; I'm still
waiting to see what else you propose for QMP interfaces.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
] != '\0') {
back_drv = bdrv_find_format(bs-backing_format);
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
is a little bit better.
Signed-off-by: Fam Zheng f...@redhat.com
---
v2: Don't leak local_err (Eric).
Thanks.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
the stack. I personally prefer malloc'd buffers rather than
attempting to guess at how large to size things, although the rest of
the code base also has similar caps at 1024 so this isn't making it worse.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
points of execution, rather than trying to make
complex calls from within the handler context.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
completion
and the later code that checks the value of errno. There, errno will
NOT be EINTR, and it is vital that the signal handler not corrupt errno
prior to returning control to normal execution context.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
place, and you don't
need the reinstall voodoo in your handlers).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 11/11/2013 10:05 AM, Paolo Bonzini wrote:
That said, aren't all signals in QEMU (except SIG_IPI) caught with
signalfd and the handlers run synchronously in the iothread?
signalfd is currently a Linux-only concept - what happens on BSD?
--
Eric Blake eblake redhat com+1-919-301
have built up the map, it's a simple matter to detect
configurations where a single L2 entry is valid.
We can them speed up the lookup by skipping one or more levels.
s/them/then/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
bitmaps, in order
to resume long-running operations such as drive-mirror even across
migration between different qemu processes, but I don't think we are
quite there yet, and I also don't think that removal of 'dirty' from
BlockInfo impedes in that goal.
--
Eric Blake eblake redhat com+1-919
| grep -q $i || echo $i; done) \
| uid_name_filter
echo
echo who has not yet uploaded a signature by $my_id on their key:
for i in $(echo $keys); do
gpg --list-sig $i | grep -qi $my_id || gpg --list-key $i
done | uid_name_filter
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
),
+wait the given number of seconds and attempt to reconnect.
Sounds cool. Are you planning on also adding the QMP counterpart for
specifying this option when doing hotplugs of a chardev? Does reconnect
make any sense when not using server mode?
--
Eric Blake eblake redhat com+1-919-301-3266
question is rather broad; an online snapshot is currently done via
the 'savevm' HMP monitor command, so your best bet might be to step
through that code, or ask more specific questions.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
require up-front that all enum
values are covered, and loudly complain if an enum type is extended
without also extending the use of that enum type in a union, than it is
to silently generate a runtime error and wait for the bug reports
several weeks down the road.
--
Eric Blake eblake redhat com
for enum values
not covered by a union branch.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
test in case 048.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Amos Kong ak...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
There was another case of overwritten ret that I added in v3.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com
pbonz...@redhat.com
---
@@ -1856,8 +1865,9 @@ static int32_t scsi_disk_emulate_command(SCSIRequest
*req, uint8_t *buf)
/*
* We only support WRITE SAME with the unmap bit set for now.
+ * Reject UNMAP=0 or ANCHOR=1.
TAB damage.
--
Eric Blake eblake redhat com+1
but there are
no jobs at the moment; on the other hand, doing that would mean the
field is not marked optional, and then we would always have to output it
for back-compat reasons. So keeping the field marked optional makes sense.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
to be in a followup
patch, since Kevin already put it in his staging tree)
Also, we have an odd mix of tray_open and dirty-bitmaps (but that mix
was already there with io-status); more reason that we should eventually
add a patch for treating - and _ as synonyms in QMP keys.
--
Eric Blake eblake
in an
output-only type:
https://lists.gnu.org/archive/html/qemu-devel/2013-11/msg01446.html
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
,
and fixing libvirt to supply the correct devices when it doesn't use -vga.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
are
done right away).
CCing Eric Blake because strictly speaking, adding a error where we
previously used to return success breaks API compatibility. Any
suggestions (I guess QEMU could just log a warning instead of failing
the command)?
Turning this into an error would be a regression
by writing -e $'s#\r##' (using $'' to do the \r interpolation prior to
handing the argument to sed).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
than hand-rolling a loop, you should use realpath() (guaranteed
by POSIX, but not always portable) or its appropriate glib wrapper,
where we can assume that glib will properly account for // being
distinct on platforms where it matters.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
is involved, but then you also introduce network protocols
(and there, it's worse: gluster://host1/vol/img and
gluster://host2/vol/img could be the same file, if host1 and host2 are
part of the same storage cluster, but there is no devno/inode to tell
you that).
--
Eric Blake eblake redhat com
access the devices when not running root/root).
Libvirt can be patched so that the .conf file does not have to be edited
(ie. change the defaults so that if cgroup_device_acl is not present in
the conf file, the defaults could still let a domainaccess the
/dev/infiniband devices).
--
Eric Blake
On 11/15/2013 12:44 PM, Michael R. Hines wrote:
On 11/15/2013 02:25 PM, Eric Blake wrote:
On 11/15/2013 10:40 AM, Michael R. Hines wrote:
This is unrelated to RDMA - accessing the /dev/infiniband
device nodes is already supported by libvirt my modifying
the configuration file in /etc
that drops an unused FW CFG entry.
I think it's best to include it before 1.7 to avoid
the need to maintain it in compat machine types.
Which is it? Last minute fixes to be included in 1.7, or some of the
first patches to be applied for 1.8 once 1.7 is out the door?
--
Eric Blake eblake redhat
already found it,
http://wiki.qemu.org/Contribute/SubmitAPatch is a great resource (and
again, knowing what pages you HAVE found may help us figure out if we
can tweak those pages to more prominently point to this page).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
On 11/18/2013 11:41 AM, Varad Gautam wrote:
On Mon, Nov 18, 2013 at 10:31 PM, Eric Blake ebl...@redhat.com wrote:
Varad, as a new contributor, you are in a position to possibly help us:
what documentation pages did you read to learn where to post your
patches, so that we can try and modify
}
# replace occurrences of QEMU_PROG with qemu
Question - why do you pipeline 'sed | sed'? It should be sufficient to
just add the s/qemu-io //g instruction into the existing sed
pipeline, for one fewer process per filter run.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
On 11/18/2013 12:21 AM, Fam Zheng wrote:
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/025 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake ebl...@redhat.com
diff --git a/tests/qemu-iotests/025 b/tests/qemu-iotests/025
index a7241cc
-by: Kevin Wolf kw...@redhat.com
---
block.c | 49 +++--
1 file changed, 23 insertions(+), 26 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the reading of nb_snapshots right before the call to
qcow2_read_snapshots().
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Are you intending this series as a bug fix for 1.7?
Reviewed-by: Eric Blake ebl
(+)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
+
1 file changed, 5 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
is snipped because the size would be rejected by list. See cover
letter for the address to pull.
Thanks for the updated commit message; and I did indeed verify that the
sed you listed gives the same results in my tree as the one I fetched
from your cover letter.
Reviewed-by: Eric Blake ebl...@redhat.com
, and it is
+ * passed to pc_isa_bios_init(). Merging severral drives for isa-bios is not
s/severral/several/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
high word
first including the bit, and where real hardware just glitches over the
temporary half-written address where our emulation locks the user out
entirely? (Asked by someone that has not read the datasheet, so take
with a grain of salt)
--
Eric Blake eblake redhat com+1-919-301-3266
) {
+s-mac_changed = true;
+} else if (addr == MAC0+5) {
Doesn't coding style recommend s/MAC0+5/MAC0 + 5/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
The case for all bits dirty is still rather slow, this
is due to the implementation of find_and_clear_dirty_height.
This will be addresses in a separate patch.
s/addresses/addressed/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
.
This is especially true if we later add new block ops later than 1.8, so
such additions can have the useful '(since 1.9)' notation.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the code leading up to it
(but do think your array of blockers, containing a ready-to-return error
message, is kind of slick)
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
of the
default. It's not much harder to make libvirt aware of handling a split
image, and a split image is easier to handle than having to copy the
default into a destination.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description
in any QMP log you read off of libvirt
interactions).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
This feels like it is worth including in 1.7 as a documentation bug fix.
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
), we
can safely assume there is no such API relying on that case yet.
Suggested-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Max Reitz mre...@redhat.com
---
blockdev.c | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
And definitely agree
.
Signed-off-by: Max Reitz mre...@redhat.com
---
tests/qemu-iotests/041 | 32
tests/qemu-iotests/041.out | 4 ++--
2 files changed, 26 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301
to
those contents.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
while leaving max-bytes alone)? Or is this an ABI change where
libvirt will have to be taught to be smart enough to know whether it is
old qemu or new qemu to adjust how libvirt does its calculations when
converting the user's rate into qemu terms?
--
Eric Blake eblake redhat com+1-919-301
truncation. If you are trying to detect overflow, you MUST assign the
results into a long, then check that the long does not overflow
uint32_t, rather than checking (too late) whether the uint32_t has
already been overflowed.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
max-bytes and period
(either with a period set by user, or with the period forced to 1000).
Nothing need to do in Libvirt for _this patch_
Agreed. Phew.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
On 11/27/2013 12:52 AM, Hannes Reinecke wrote:
strtoul(l) might overflow, in which case it'll return '-1' and set
the appropriate error code. So update the calls to strtoul(l) when
parsing hex properties to avoid silent overflows.
Cc: Peter Maydell peter.mayd...@linaro.org
Cc: Eric Blake
to be deleted, valid values [0..max_cpus)
+#
+# Returns: Nothing on success
+#
+# Since 1.7
Since this mail is still titled RFC, there's no way it will make it into
1.7. Are you shooting for 1.8?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
parsing.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
;
+break;
+case 0x15: /* pack and return is_* fields */
+val |= mdev-is_enabled ? 1 : 0;
+val |= mdev-is_inserting ? 2 : 0;
This is bit 0 and 1, not bit 1 and 2.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
this assert_no_error() is dead code in its current position. To be
useful, you probably want:
if (!errp) {
assert_no_error(local_error);
} else if (local_error) {
error_propagate(errp, local_error);
}
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
that sizeof(unsigned long long)==sizeof(uint64_t), rather than
writing a range limit that is in practice just dead code.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
whatever (now unknown) commit I first reviewed is thus
limited to rebase differences. I'm happy with the commit, so feel free
to (re-)add:
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
error case
(including the error of qemu-ga exiting without seeing a QMP thaw
request), if only to minimize the chance of failure leaving the system
wedged with no chance of further recovery attempts.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
',
'*dhcpstart': 'str',
+'*nextserver': 'str',
This is a command addition that libvirt can't take advantage of unless
we get introspection working in a timely manner.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description
adds the features,
since there are more users of qemu than just libvirt.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
is a nice compact representation
that works for humans, but may be a bit TOO compact for handling via
machines.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
401 - 500 of 23003 matches
Mail list logo
