Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-06 Thread Gerd Hoffmann
> diff --git a/configure b/configure > index cef0a71..5fcd315 100755 > --- a/configure > +++ b/configure > @@ -2630,7 +2630,7 @@ EOF >spice_cflags=$($pkg_config --cflags spice-protocol spice-server > 2>/dev/null) >spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null) >

Re: [Qemu-devel] [BUG] BSOD on Win2003 Server when 64bit PCI resource is present

2012-08-06 Thread Gerd Hoffmann
On 07/28/12 17:27, Kevin O'Connor wrote: > On Thu, Jul 26, 2012 at 03:38:47PM +, Alexey Korolev wrote: >> HI, >> >> Current version of Seabios is causing blue screen on Windows2003 when 64bit >> PCI resource is present and occupies high memory. >> >> BSOD Error code is: 0x00A5 (0x02, 0xFFF

Re: [Qemu-devel] vga-pci and MMIO BAR

2012-08-06 Thread Gerd Hoffmann
ev. Maybe you can reuse some bits nevertheless. /me wonders what the advantage of using drm is for non-3D hardware? cheers, Gerd From 637f637df63a2fc676d7fa09c4fec40172559bab Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Tue, 6 Mar 2012 14:34:38 +0100 Subject: [PATCH] add bochs dispi interfa

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
On 07/30/12 14:08, Benjamin Herrenschmidt wrote: > On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: >> Let's balkanize some more then? >> >> No, qxl is our paravirt vga, we should improve it instead of spawning >> new ones (which will be horrible in the eyes of the next person to look >> at the

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
Hi, Hi, > Minor improvements to stdvga actual help qxl (presumably). qxl still > provides a vga interface which is used when guest drivers aren't > available. > > It's not clear to me why it doesn't enable VBE but presumably if it did, > then accelerations could be mapped through VBE. QXL a

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
Hi, > QXL has a lot of short comings. Here's a short list: > > - It's 100% PC centric. It requires PCI and is completely oblivious to > endianness. No. The endianess is actually clearly defined. It's little endian for both guest/host interface (aka qxl) and the network protocol. So it i

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
Hi, > The latter sounds like a better long term approach, however it lacks > backward compat with qemu-vga, but I doubt it's a big deal especially if > we provide a working VBE ROM for x86. A vbe rom isn't a big deal. You probably want support the 0x01CE and 0x01CF ports (on x86) so the vgabio

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
On 08/06/12 23:16, Benjamin Herrenschmidt wrote: > On Mon, 2012-08-06 at 15:20 +0200, Gerd Hoffmann wrote: >> There are discussions about re-doing the guest/host interface (command >> rings etc) now and then, by adding a qxl2 device (or maybe even extend >> stdvga), droppin

[Qemu-devel] [PATCH v3] fix info qtree indention

2012-08-06 Thread Gerd Hoffmann
ch applied everything is lined up properly: [ ... ] dev: fw_cfg, id "" ctl_iobase = 0x510 data_iobase = 0x511 irq 0 mmio /0002 mmio /0001 [ ... ] Needed to make the autotest qtree parser happy. Signed-off-by: Gerd Ho

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-07 Thread Gerd Hoffmann
Hi, > Why not make libspice mandatory? spice needs to build and run on alot of platforms where it doesn't run today. So it isn't an option right now. Which doesn't imply it will never happen, but spice certainly needs some work before we can seriously discuss that. Make spice work on bigendi

[Qemu-devel] [PATCH 2/2] usb-storage: fix SYNCHRONIZE_CACHE

2012-08-07 Thread Gerd Hoffmann
Commit 59310659073d85745854f2f10c4292555c5a1c51 is incomplete, we'll arrive in the scsi command complete callback in CSW state and must handle that case correctly. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PULL 0/2] usb patch queue

2012-08-07 Thread Gerd Hoffmann
Hi, This is the usb patch queue, pretty small this time, carrying a little fix for usb-storage. please pull, Gerd Gerd Hoffmann (2): usb-storage: improve debug logging usb-storage: fix SYNCHRONIZE_CACHE hw/usb/dev-storage.c | 11 +-- 1 files changed, 9 insertions(+), 2

[Qemu-devel] [PATCH 1/2] usb-storage: improve debug logging

2012-08-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 7fa8b83..976fe1a 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -383,6 +383,9 @@ static int

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-07 Thread Gerd Hoffmann
On 08/07/12 15:05, Erlon Cruz wrote: > Em 07/08/2012 05:01, "Gerd Hoffmann" escreveu: >> >> Hi, >> >>> Why not make libspice mandatory? >> >> spice needs to build and run on alot of platforms where it doesn't run >> today. So it i

[Qemu-devel] [PULL 0/1] update qemu seabios / seabios release?

2012-08-07 Thread Gerd Hoffmann
into qemu 1.2 Anthony? Kevin? Fine are you ok with this? qemu release schedule is here: http://wiki.qemu.org/Planning/1.2 cheers, Gerd Gerd Hoffmann (1): update seabios to latest master pc-bios/bios.bin | Bin 131072 -> 131072 bytes roms/seabios |2 +- 2 files changed, 1 inse

[Qemu-devel] [PATCH 1/1] update seabios to latest master

2012-08-07 Thread Gerd Hoffmann
booting from lsi scsi hba. - Support for booting from usb attached scsi. - Support for non-linear apic ids. Signed-off-by: Gerd Hoffmann --- pc-bios/bios.bin | Bin 131072 -> 131072 bytes roms/seabios |2 +- 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pc-bios/bios.bi

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-07 Thread Gerd Hoffmann
Hi, >>> The only thing >>> its missing is to fix the endianess for server/client handshaking. >> >> What exactly do you mean here? > > Well that are negotiation messages configuring each channel, its > capabilities, encryption keys , etc. After this negotiation, the > server start to send SPICE

Re: [Qemu-devel] [PATCH] ivshmem: add 64bit option

2012-08-08 Thread Gerd Hoffmann
On 07/12/12 17:08, Gerd Hoffmann wrote: > This patch adds a "use64" property which will make the ivshmem driver > register a 64bit memory bar when set, so you have something to play with > when testing 64bit pci bits. It also allows to have quite big shared > memory regions, like this: Ping?

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-08 Thread Gerd Hoffmann
Hi, >> Maybe the guest driver places the qxl commands in native endian instead >> of big endian into memory? > > The guest drivers places the commands in the memory in its native > endianess. That why the device only works when guest/host has the same > endianess. That's sanit-checks doesn't fa

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-08-09 Thread Gerd Hoffmann
the > dongle gets finally detected / usable on the guest. Can you try if the attached patch makes a difference? thanks, Gerd >From d51ea0d80009eb58a09e8e571a7eca5da562becc Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Thu, 9 Aug 2012 10:57:32 +0200 Subject: [PATCH] async control xfer fix

Re: [Qemu-devel] [PULL 0/1] update qemu seabios / seabios release?

2012-08-09 Thread Gerd Hoffmann
On 08/09/12 13:57, Kevin O'Connor wrote: > On Tue, Aug 07, 2012 at 05:45:07PM +0200, Gerd Hoffmann wrote: >> Hi, >> >> This pull updates seabios in qemu to the latest bits from seabios >> master, so the upcoming 1.2 qemu release gets all the new shiny >> stu

Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-09 Thread Gerd Hoffmann
On 08/09/12 15:41, Alon Levy wrote: > On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote: >>> diff --git a/configure b/configure >>> index cef0a71..5fcd315 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -2630,7 +2630,7 @@ EOF

Re: [Qemu-devel] [PATCH 0/4]: qmp: WAKEUP event related fixes

2012-08-10 Thread Gerd Hoffmann
On 08/09/12 19:28, Luiz Capitulino wrote: > Fixes the RESET event being emitted on wakeup from S3. Changes when > the WAKEUP event is emitted and a few doc fixes. series looks good to me. Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCH 2/2] scsi: fix warning

2012-08-10 Thread Gerd Hoffmann
hw/scsi-bus.c:758: warning: ‘xfer’ may be used uninitialized in this function Isn't true, but older gcc versions (for example 4.1 as shipped in rhel5) are not clever enougth to figure, so sprinkle in a default: line to make them happy. Signed-off-by: Gerd Hoffmann --- hw/scsi-bus.c |

[Qemu-devel] [PATCH 0/2] two little build fixes

2012-08-10 Thread Gerd Hoffmann
Hi, $subject says all. cheers, Gerd Gerd Hoffmann (2): avoid asprintf (not available on mingw) scsi: fix warning hw/msix.c |5 ++--- hw/scsi-bus.c |2 ++ 2 files changed, 4 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 1/2] avoid asprintf (not available on mingw64)

2012-08-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/msix.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 800fc32..04345f2 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -307,9 +307,8 @@ int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries

Re: [Qemu-devel] [PATCH 1/2] avoid asprintf (not available on mingw64)

2012-08-12 Thread Gerd Hoffmann
On 08/10/12 16:18, Markus Armbruster wrote: >> -if (asprintf(&name, "%s-msix", dev->name) == -1) { > > What about g_strdup_printf()? Ah, nice. Didn't know glib has this. cheers, Gerd

[Qemu-devel] [PATCH v2 0/2] two little build fixes

2012-08-13 Thread Gerd Hoffmann
Hi, Patch #1 uses g_strdup_printf now, #2 is unchanged. cheers, Gerd Gerd Hoffmann (2): Avoid asprintf() which is not available on mingw scsi: fix warning hw/msix.c |8 ++-- hw/scsi-bus.c |2 ++ 2 files changed, 4 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v2 2/2] scsi: fix warning

2012-08-13 Thread Gerd Hoffmann
hw/scsi-bus.c:758: warning: ‘xfer’ may be used uninitialized in this function Isn't true, but older gcc versions (for example 4.1 as shipped in rhel5) are not clever enougth to figure, so sprinkle in a default: line to make them happy. Signed-off-by: Gerd Hoffmann --- hw/scsi-bus.c |

[Qemu-devel] [PATCH v2 1/2] Avoid asprintf() which is not available on mingw

2012-08-13 Thread Gerd Hoffmann
Use g_strdup_printf() instead. Signed-off-by: Gerd Hoffmann --- hw/msix.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 800fc32..aea340b 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -307,13 +307,9 @@ int msix_init_exclusive_bar

Re: [Qemu-devel] [PATCH v3] fix info qtree indention

2012-08-15 Thread Gerd Hoffmann
On 08/07/12 08:27, Gerd Hoffmann wrote: > Without the patch bus properties are are not in line with the other > properties: > > [ ... ] > dev: fw_cfg, id "" > ctl_iobase = 0x510 > data_iobase = 0x511 > irq 0 > mmio f

Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-15 Thread Gerd Hoffmann
On 08/09/12 16:21, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. Patch doesn't apply cleanly to master. > +if $pkg_config --atleast-version=0.12.0 spice-protocol >/dev/

Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-15 Thread Gerd Hoffmann
Hi, >> Or maybe just use >> >> #ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC >> #define QXL_HAS_IO_MONITORS_CONFIG_ASYNC $whatever >> #endif > > I don't get this. You mean to have add > #define QXL_HAS_IO_MONITORS_CONFIG_ASYNC bla > to spice-protocol? No, to qemu, so QXL_HAS_IO_MONITORS_CONFIG_ASYN

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-15 Thread Gerd Hoffmann
On 08/15/12 13:22, Hans de Goede wrote: > Hi, > > On 08/14/2012 06:12 PM, Hans de Goede wrote: >> Hi, >> >> While testing qemu-master I've encountered 2 problems caused by the >> ehci changes >> made since 1.1: >> >> 1) Newly plugged in devices don't get recognized by the guest >> This seems to be

[Qemu-devel] [PATCH] ehci: fix Interrupt Threshold Control implementation

2012-08-15 Thread Gerd Hoffmann
First, not all interrupts are subject to Interrupt Threshold Control, some of them must be delivered without delay. Second, Interrupt Threshold Control state must be part of vmstate, otherwise we might loose IRQs on migration. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 12

Re: [Qemu-devel] [PATCH] ehci: Fix setting of halt bit from usbcmd register updates

2012-08-15 Thread Gerd Hoffmann
On 08/15/12 17:08, Hans de Goede wrote: > This fixes linux guests started without any USB devices not seeing newly > plugged devices until "lsusb" is done inside the guest. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] Hard freeze for 1.2 today

2012-08-15 Thread Gerd Hoffmann
Hi, > Today is the hard freeze for 1.2. If you have any pull requests and/or > patches targetted for the hard freeze, please send them by 3pm > US/Central time today and clearly mark them "for-1.2". > > If there are existing patches and/or pull requests on the mailing list > that you think sho

Re: [Qemu-devel] Apparent USB assignment issue on 1.1+

2012-08-16 Thread Gerd Hoffmann
On 08/16/12 09:45, Michael Tokarev wrote: > Hello. > > This issue has been reported several times already, > but I can't reproduce it locally. Gerd, can you > please take a look, maybe you may ask better > question to the OP(s) about what to try. > > https://bugs.launchpad.net/qemu/+bug/1033727

Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop

2012-08-16 Thread Gerd Hoffmann
On 08/16/12 10:23, Yonit Halperin wrote: > Spice server needs to know about the vm state in order to prevent > attempts to write to devices when they are stopped, mainly during > the non-live stage of migration. Why this new hook? qemu already notifies spice-server using QXLWorker start/stop call

[Qemu-devel] [PATCH for-1.2 3/4] ehci: fix Interrupt Threshold Control implementation

2012-08-16 Thread Gerd Hoffmann
First, not all interrupts are subject to Interrupt Threshold Control, some of them must be delivered without delay. Second, Interrupt Threshold Control state must be part of vmstate, otherwise we might loose IRQs on migration. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 12

[Qemu-devel] [PATCH for-1.2 2/4] usb: update uas product id

2012-08-16 Thread Gerd Hoffmann
Pick other product id to fix clash with audio. Current usage list (after applying this patch): 46f4:0001 -- usb-storage 46f4:0002 -- usb-audio 46f4:0003 -- usb-uas Signed-off-by: Gerd Hoffmann --- hw/usb/dev-uas.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw

[Qemu-devel] [PULL for-1.2 0/4] usb bugfix patch queue

2012-08-16 Thread Gerd Hoffmann
Hi, USB patch queue, carrying some bugfixes for qemu 1.2. please pull, Gerd Gerd Hoffmann (3): usb: async control xfer fixup usb: update uas product id ehci: fix Interrupt Threshold Control implementation Hans de Goede (1): ehci: Fix setting of halt bit from usbcmd register updates

[Qemu-devel] [PATCH for-1.2 1/4] usb: async control xfer fixup

2012-08-16 Thread Gerd Hoffmann
Need to clear p->result after copying setup data using usb_packet_copy() because we'll reuse the USBPacket for the data transfer. Signed-off-by: Gerd Hoffmann --- hw/usb/core.c |1 + hw/usb/host-linux.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH for-1.2 4/4] ehci: Fix setting of halt bit from usbcmd register updates

2012-08-16 Thread Gerd Hoffmann
From: Hans de Goede This fixes linux guests started without any USB devices not seeing newly plugged devices until "lsusb" is done inside the guest. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 15 --- 1 files changed, 8 insert

Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop

2012-08-16 Thread Gerd Hoffmann
On 08/16/12 15:00, Yonit Halperin wrote: > On 08/16/2012 12:42 PM, Gerd Hoffmann wrote: >> On 08/16/12 10:23, Yonit Halperin wrote: >>> Spice server needs to know about the vm state in order to prevent >>> attempts to write to devices when they are stopped, mainly durin

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-16 Thread Gerd Hoffmann
Hi, > Ok, I've managed to significantly narrow this down, this is caused > by ehci_fill_queue() adding packets to the queue with different > qtdaddr values then the first one already queued up, this is of > course more or less fully expected, Yes. > but does trigger the assert in question ...

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-17 Thread Gerd Hoffmann
Hi, > 2) happens when a packet fails, and the queue should be halted, in > this case Should we just cancel all queued packets on endpoint halts then? If the guest decides to go on we'll easily re-queue everything (with the existing code). If the guest does something else we don't have to do a

Re: [Qemu-devel] [PATCH 1/3] usb: Halt ep queue en cancel pending packets on a packet error

2012-08-17 Thread Gerd Hoffmann
Hi, > Note this patch only touches the ehci and uhci controller changes, since AFAIK > no other controllers actually queue up multiple transfer. If I'm wrong on this > other controllers need to be updated too! xhci does it too (although it is hard to test as xhci can happily submit 256k transfe

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-19 Thread Gerd Hoffmann
Hi, >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 >> >> Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > > So you are telling me to undo a change that Gerd asked for - could you > please at least debate about the merits of bot

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
On 08/20/12 10:00, Alon Levy wrote: >> Hi, >> > +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define > QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). >>> >>> So you are telling me to undo a change that Gerd asked for -

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
Hi, >> Maybe revisit upstream spice packaging? spice internal usage of >> spice-protocol is handled via submodules now. Are there external >> users, other than qemu? Does it make sense to keep the >> spice-server / spice-protocol split in the first place? Or should >> spice-server just pro

Re: [Qemu-devel] [PATCH v8 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
Hi, Patch looks alot nicer now with a bunch if #ifdefs removed. One issue left I missed before: > case QXL_MODE_COMPAT: > /* note: no need to call qxl_create_memslots, qxl_set_mode > @@ -2065,6 +2124,7 @@ static VMStateDescription qxl_vmstate = { > VMSTATE_ARRAY(guest_su

Re: [Qemu-devel] [PATCH v2 2/5] spice: notify on vm state change only via spice_server_vm_start/stop

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 09:09, Yonit Halperin wrote: > Hi, > On 08/21/2012 09:58 AM, Gerd Hoffmann wrote: >>Hi, >> >>> +#if SPICE_SERVER_VERSION>= 0x000b02 /* 0.11.2 */ >>> +static void display_start(void) >>> +{ >>> +DisplayListItem *it

Re: [Qemu-devel] [PATCH v2 2/5] spice: notify on vm state change only via spice_server_vm_start/stop

2012-08-21 Thread Gerd Hoffmann
Hi, > +#if SPICE_SERVER_VERSION >= 0x000b02 /* 0.11.2 */ > +static void display_start(void) > +{ > +DisplayListItem *item; > + > +QLIST_FOREACH(item, &display_list, link) { > +item->display->running = true; > +} > +} I think we should simply use a global variable for 'runnin

Re: [Qemu-devel] [PATCH] usb-redir: Never return USB_RET_NAK for async handled packets

2012-08-21 Thread Gerd Hoffmann
On 08/17/12 17:27, Hans de Goede wrote: > USB_RET_NAK is not a valid response for async handled packets (and will > trigger an assert as such). > > Also drop the warning when receiving a status of cancelled for packets not > cancelled by qemu itself, this can happen when a device gets unredirected

Re: [Qemu-devel] [PATCH] usb: Halt ep queue en cancel pending packets on a packet error

2012-08-21 Thread Gerd Hoffmann
On 08/17/12 15:24, Hans de Goede wrote: > For controllers which queue up more then 1 packet at a time, we must halt the > ep queue, and inside the controller code cancel all pending packets on an > error. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v10 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 12:16, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and > defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > This io calls the corresponding new sp

Re: [Qemu-devel] [PATCH v3 0/5] add support for spice migration v3

2012-08-21 Thread Gerd Hoffmann
> Yonit Halperin (5): > spice: notify spice server on vm start/stop > spice: notify on vm state change only via spice_server_vm_start/stop > spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED > spice: add 'migrated' flag to spice info > spice: adding seamless-migration option to the comm

Re: [Qemu-devel] [PATCH v11 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 12:51, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and > defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. All four patches added to spice patch queu

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 12:54, Yonit Halperin wrote: > Added all spice options to the help string. This can be used by libvirt > to determine which spice related features are supported by qemu. Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v11 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 13:06, Gerd Hoffmann wrote: > On 08/21/12 12:51, Alon Levy wrote: >> Revision bumped to 4 for new IO support, enabled for spice-server >= >> 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and >> defaults to 4, iff spice-server >

Re: [Qemu-devel] [PATCH v12 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-23 Thread Gerd Hoffmann
On 08/22/12 10:16, Alon Levy wrote: > v11->v12: > fix build with older spice server (Gerd). Replaced patches in the spice queue. thanks, Gerd

[Qemu-devel] [PATCH v4] ivshmem: add 64bit option

2012-08-23 Thread Gerd Hoffmann
t master again ] [ v3: rebase & adapt to latest master ] [ v2: default to on as suggested by avi, turn off for pc-$old using compat property ] Signed-off-by: Gerd Hoffmann Tested-by: Cam Macdonell --- hw/ivshmem.c | 13 ++--- hw/pc_piix.c |4 2 files changed, 1

Re: [Qemu-devel] [PATCH] Better name usb braille device

2012-08-23 Thread Gerd Hoffmann
On 08/23/12 09:59, Samuel Thibault wrote: > Windows users need to know that they have to use the Baum driver to make > the qemu braille device work. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v3] fix info qtree indention

2012-08-23 Thread Gerd Hoffmann
On 08/15/12 10:26, Gerd Hoffmann wrote: > On 08/07/12 08:27, Gerd Hoffmann wrote: >> Without the patch bus properties are are not in line with the other >> properties: >> >> [ ... ] >> dev: fw_cfg, id "" >> ctl_iobase = 0x510 >&g

Re: [Qemu-devel] [PATCH 1/4] qxl: create a qxl common struct!

2012-08-26 Thread Gerd Hoffmann
On 08/24/12 21:14, Erlon Cruz wrote: > From: Fabiano Fidêncio > > This commit is creating a QXLDevice struct, entirely based on > PCIQXLDevice struct, but separating parts that will be shared between > PCIQXLDevice and VirtIOQXLDevice. All functions were changed to support > the new QXLDevice str

Re: [Qemu-devel] [PATCH 2/4] qxl: split qxl functions in common and pci files

2012-08-26 Thread Gerd Hoffmann
On 08/24/12 21:14, Erlon Cruz wrote: > From: Fabiano Fidêncio > > This commit splits qxl functions into common functions (located in > qxl.c) and pci-specific functions (located in qxl-pci.c). > All prototypes are being kept in qxl.h, as common MACROS and inline > functions. Moreover, this commit

Re: [Qemu-devel] [PATCH 4/4] qxl: introducing virtio-qxl

2012-08-26 Thread Gerd Hoffmann
Hi, > To enable the VirtIOQXL device, use '-virtio-qxl'. Video output will be Please don't add a new option. 'qemu -vga none -device virtio-qxl' should work these days. You could also make virtio-qxl a valid choice for '-vga' for convenience. cheers, Gerd

Re: [Qemu-devel] Implementing qxl-virtio on QEMU

2012-08-26 Thread Gerd Hoffmann
On 08/24/12 21:14, Erlon Cruz wrote: > The following patches makes provides video support to non PCI architectures, > please review! Can you give an overview on the virtio-qxl virtual hardware design? thanks, Gerd

Re: [Qemu-devel] [PATCH] Add new client_present and client capabilities fields to QXLRom

2012-08-27 Thread Gerd Hoffmann
On 08/27/12 19:20, Søren Sandmann Pedersen wrote: > From: Søren Sandmann Pedersen > > The client_present field is a byte that is set of non-zero when a > client is connected and to zero when no client is connected. > > The client_capabilities[58] array contains 464 bits that indicate the > capab

Re: [Qemu-devel] [PATCH] qxl: Add set_client_capabilities() interface to QXLInterface

2012-08-27 Thread Gerd Hoffmann
On 08/27/12 19:20, Søren Sandmann Pedersen wrote: > From: Søren Sandmann Pedersen > > This new interface lets spice server inform the guest whether > > (a) a client is connected > (b) what capabilities the client has > > There is a fixed number (464) of bits reserved for capabilities, and > whe

Re: [Qemu-devel] [PATCH 1/2] spice: Change NUM_SURFACES to 4096

2012-08-27 Thread Gerd Hoffmann
On 08/27/12 18:21, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > It's not uncommon for an X workload to have more than 1024 pixmaps > live at the same time. Ideally, there wouldn't be any fixed limit like > this, but since we have one, increase it to 4096. > --- > ui/spice-display.h

Re: [Qemu-devel] [Bug 1042084] [NEW] Windows 7 guest cannot boot after seabios updated

2012-08-28 Thread Gerd Hoffmann
On 08/28/12 10:07, Stefan Hajnoczi wrote: > On Mon, Aug 27, 2012 at 7:54 AM, Vic wrote: >> Public bug reported: >> >> Hi, >> >> I can no longer boot my Windows 7 guest after this commit (update >> seabios to latest master) >> >> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=01afdadc92e71e29700e64

Re: [Qemu-devel] [PATCH 1/2] spice: Change NUM_SURFACES to 4096

2012-08-28 Thread Gerd Hoffmann
Hi, > /* move from ARRAY to VARRAY with sive on num_surfaces */ > VMSTATE_VARRAY_INT32(guest_surfaces.cmds, PCIQXLDevice, num_surfaces, > 0, >vmstate_info_uint64, uint64_t), Ah. Yes, VARRAY will do, somehow I didn't find it. > And thinking about it, no

[Qemu-devel] [PATCH 02/25] usb: kill USB_MSG_RESET

2012-01-23 Thread Gerd Hoffmann
called directly. Also rename the existing usb_reset() function to usb_port_reset() to avoid confusion. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c |4 ++-- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |4 ++-- hw/usb-uhci.c | 10 +++--- hw/usb-xhci.c |4

Re: [Qemu-devel] [PATCH] usb-ehci: Clear the portstatus powner bit on device disconnect

2012-01-23 Thread Gerd Hoffmann
On 01/23/12 17:12, Andreas Färber wrote: > Am 23.01.2012 15:51, schrieb Gerd Hoffmann: >> On 01/13/12 14:28, Hans de Goede wrote: >>> According to the EHCI spec port ownerhsip should revert to the EHCI >>> controller > > ownership Fixed. thanks, Gerd

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Gerd Hoffmann
Hi, >>> We really should view RAM as just another device so I don't like the >>> idea of >>> propagating a global concept of "when RAM is restored" because that >>> treats it >>> specially compared to other devices. >>> >>> But viewing RAM as just another device, having Xen only restore a >>> su

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Gerd Hoffmann
t;? Sure. cheers, Gerd >From 4c17b5a36e6228536318e06a18a41166ff8356c5 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Thu, 26 Jan 2012 11:40:07 +0100 Subject: [PATCH] nic: zap obsolote romloading bits from ne2k + pcnet These days one just needs to specify the romfile in PCiDeviceInfo

Re: [Qemu-devel] [PATCH] usb-redir: Add the posibility to filter out certain devices from redirecion

2012-01-26 Thread Gerd Hoffmann
On 01/25/12 09:50, Hans de Goede wrote: > This patch adds the posibility to filter out certain devices from redirecion. > To use this pass the filter property to -device usb-redir. The filter > property takes a string consisting of filter rules, the format for a rule is: > > Patch added to

[Qemu-devel] [PATCH] nic: zap obsolote romloading bits from ne2k + pcnet

2012-01-26 Thread Gerd Hoffmann
These days one just needs to specify the romfile in PCiDeviceInfo and everything magically works. It also allows to disable pxe rom loading via "romfile=" like it is possible for all other nics. Signed-off-by: Gerd Hoffmann --- hw/ne2000.c|9 + hw/pcnet-pc

[Qemu-devel] [PATCH] usb-uhci: implement bandwidth management

2012-01-26 Thread Gerd Hoffmann
a 64M stick goes down from five seconds to a half second. Reason for this is that we are now processing up to 24 transfer descriptors (with 64 bytes each) per frame instead of a single one. Signed-off-by: Gerd Hoffmann --- hw/usb-uhci.c | 29 ++--- 1 files changed, 22

[Qemu-devel] [PATCH v3 4/6] suspend: make ps/2 devices wakeup the guest

2012-02-08 Thread Gerd Hoffmann
. Signed-off-by: Gerd Hoffmann --- hw/ps2.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/ps2.c b/hw/ps2.c index 1d9057b..d1b2505 100644 --- a/hw/ps2.c +++ b/hw/ps2.c @@ -24,6 +24,7 @@ #include "hw.h" #include "ps2.h" #include "conso

[Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-08 Thread Gerd Hoffmann
. Signed-off-by: Gerd Hoffmann --- sysemu.h |3 +++ vl.c | 28 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index 9d5ce33..3b9d7f5 100644 --- a/sysemu.h +++ b/sysemu.h @@ -39,6 +39,9 @@ void vm_stop(RunState state); void

[Qemu-devel] [PATCH v3 3/6] suspend: add system_wakeup monitor command

2012-02-08 Thread Gerd Hoffmann
This patch adds the system_wakeup monitor command which will simply wake up suspended guests. Signed-off-by: Gerd Hoffmann --- hmp-commands.hx | 14 ++ hmp.c|5 + hmp.h|1 + qapi-schema.json | 11 +++ qmp-commands.hx | 21

[Qemu-devel] [PATCH v3 2/6] suspend: switch acpi s3 to new infrastructure.

2012-02-08 Thread Gerd Hoffmann
leaving suspend instantly, so it is useful for more than just testing whenever the suspend/resume cycle actually works. Signed-off-by: Gerd Hoffmann --- hw/acpi.c| 11 +-- hw/acpi.h|2 -- hw/acpi_piix4.c |3 +-- hw/mc146818rtc.c | 12 hw

[Qemu-devel] [PATCH v3 6/6] suspend: make rtc alarm wakeup the guest.

2012-02-08 Thread Gerd Hoffmann
Add a 'wakeup' property to the mc146818rtc. It is on by default. When enabled the rtc will wake up the guest when the alarm fires. Signed-off-by: Gerd Hoffmann --- hw/mc146818rtc.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc1

[Qemu-devel] [PATCH v3 5/6] suspend: make serial ports wakeup the guest.

2012-02-08 Thread Gerd Hoffmann
Add a 'wakeup' property to the serial port. It is off by default. When enabled any incoming character on the serial line will wake up the guest. Useful for guests which have a serial console configured. Signed-off-by: Gerd Hoffmann --- hw/serial.c |6 ++ 1 files changed, 6

[Qemu-devel] [PATCH v3 0/6] initial suspend support

2012-02-08 Thread Gerd Hoffmann
th the notifier, zap a bunch of hackish cmos_s3 windup code (this touches xen-all.c, thus cc xen-devel). * Add rtc wakeup support. Gerd Hoffmann (6): suspend: add infrastructure suspend: switch acpi s3 to new infrastructure. suspend: add system_wakeup monitor command suspend: make ps/2

[Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2012-02-08 Thread Gerd Hoffmann
client via Alt-F4, guest continues to see the pressed alt key and will not react to key events in any useful way until you tap the alt key once to unstuck it. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/ui

[Qemu-devel] [PATCH] build: allow turning off debuginfo

2012-02-08 Thread Gerd Hoffmann
This patch adds --{enable,disable}-debug-info switches to configure which allows to include/exclude the '-g' switch on the gcc & ld command lines. Not building debug info reduces ressource usage (especially disk) alot and is quite useful for test builds. Signed-off-by:

[Qemu-devel] [PATCH v2] nic: zap obsolote romloading bits from ne2k + pcnet

2012-02-08 Thread Gerd Hoffmann
These days one just needs to specify the romfile in PCiDeviceInfo and everything magically works. It also allows to disable pxe rom loading via "romfile=" like it is possible for all other nics. [ v2: rebased & adapted to qom changes ] Signed-off-by: Gerd Hoffmann --- hw/ne20

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-02-08 Thread Gerd Hoffmann
gt; supported. See: http://spice-space.org/faq.html Outdated. 64bit restrictions are gone, spice server works on 32bit too. Thats why 32bit spice packages exist in the first place ;) Attached patch fixes the warnings. cheers, Gerd >From a45a8229260d45804fea654fb9b45c35eb454478 Mon Sep

[Qemu-devel] [PATCH 0/5] rom build scripting, switch vgabios implementation

2012-02-09 Thread Gerd Hoffmann
s are updated. Tests, comments etc, are welcome. cheers, Gerd The following changes since commit cf4dc461a4cfc3e056ee24edb26154f4d34a6278: Restore consistent formatting (2012-02-07 22:11:04 +0400) are available in the git repository at: git://git.kraxel.org/qemu bios.1 Gerd Hoffma

[Qemu-devel] [PATCH 1/5] update seabios to latest master [feb 9th]

2012-02-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- pc-bios/vgabios-cirrus.bin | Bin 35840 -> 35328 bytes roms/seabios |2 +- 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pc-bios/vgabios-cirrus.bin b/pc-bios/vgabios-cirrus.bin index 424dd0c70c4a52e1a98d8a64ebf4aa382b85d

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gerd Hoffmann
On 02/09/12 09:48, Gleb Natapov wrote: > On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: >> * qemu_system_wakeup_request is supposed to be called on events which >>should wake up the guest. >> > qemu_system_wakeup_request() should get wakeup source as

[Qemu-devel] [PATCH 4/5] Add seabios build scripts to roms/

2012-02-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile |6 ++ roms/config.seabios |1 + 2 files changed, 7 insertions(+), 0 deletions(-) create mode 100644 roms/config.seabios diff --git a/roms/Makefile b/roms/Makefile index 5c3d5f4..b24c728 100644 --- a/roms/Makefile +++ b/roms

Re: [Qemu-devel] [PATCH v3 2/6] suspend: switch acpi s3 to new infrastructure.

2012-02-09 Thread Gerd Hoffmann
Hi, >> Pretend that resume was caused by power button */ >> pm1a->sts |= >> (ACPI_BITMASK_WAKE_STATUS | >> ACPI_BITMASK_POWER_BUTTON_STATUS); > Here we should report real reason for a wakeup (if it can be reported in > mp1sts that is). These are av

[Qemu-devel] [PATCH 2/5] Add vgabios build scripts to roms/

2012-02-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile | 17 + roms/config.vga.cirrus|3 +++ roms/config.vga.isavga|3 +++ roms/config.vga.qxl |6 ++ roms/config.vga.stdvga|3 +++ roms/config.vga.vmware|6 ++ roms/configure

Re: [Qemu-devel] [PATCH v3 6/6] suspend: make rtc alarm wakeup the guest.

2012-02-09 Thread Gerd Hoffmann
On 02/09/12 09:56, Gleb Natapov wrote: > On Wed, Feb 08, 2012 at 12:00:19PM +0100, Gerd Hoffmann wrote: >> Add a 'wakeup' property to the mc146818rtc. It is on by default. >> When enabled the rtc will wake up the guest when the alarm fires. >> >> Signed

Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-09 Thread Gerd Hoffmann
On 02/09/12 12:19, Gleb Natapov wrote: > On Thu, Feb 09, 2012 at 11:45:21AM +0100, Gerd Hoffmann wrote: >> On 02/09/12 09:48, Gleb Natapov wrote: >>> On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: >>>> * qemu_system_wakeup_request is suppose

  1   2   3   4   5   6   7   8   9   10   >