[Qemu-devel] [PATCH v3 3/5] virtio-9p: block hot-unplug when device is active

accordingly. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p.c| 14 ++ hw/9pfs/virtio-9p.h|2 ++ hw/s390x/virtio-ccw.c |8 hw/virtio/virtio-pci.c |8 4 files changed, 32 insertions(+) diff --git a/hw/9pfs/virtio-

[Qemu-devel] [PATCH v3 1/5] virtio-9p-coth: fix init function

The v9fs thread pool is a singleton, shared by all virtio-9p devices. The current code leaks underlying glib pointers each time a new virtio-9p device gets realized. Let's fix that ! While we're here, we also fix the trivial error path when memory allocation is failing. Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support

On Tue, 20 Oct 2015 15:53:08 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Oct 20, 2015 at 11:16:40AM +0200, Greg Kurz wrote: > > We already have a blocker to prevent migration of an active virtio-9p > > device. > > But in fact, there is no

Re: [Qemu-devel] [PATCH v3 3/5] virtio-9p: block hot-unplug when device is active

On Tue, 20 Oct 2015 15:42:03 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Oct 20, 2015 at 11:17:00AM +0200, Greg Kurz wrote: > > Hot-unplug of an active virtio-9p device is not currently supported. Until > > we have that, let's block hot-unpluggi

Re: [Qemu-devel] [PATCH] net: don't set native endianness

t support BE vnet headers"); } } return r; } Cheers. -- Greg > Reported-by: Marcel Apfelbaum <mar...@redhat.com> > Cc: Greg Kurz <gk...@linux.vnet.ibm.com> > Cc: qemu-sta...@nongnu.org > Signed-off-by: Michael S. Tsirkin <m...@redhat.com>

[Qemu-devel] [PATCH v2 0/5] virtio-9p: hotplug and migration support

post is the introduction of an unplug blocker (patch 2/5 and 3/5). I also reworked the series so that some fixes appear in more appropriate patches (see individual changelogs). Please comment. -- Greg --- Greg Kurz (5): virtio-9p-coth: fix init function qdev: add the HotUnpluggable

[Qemu-devel] [PATCH v2 4/5] virtio-9p: add unrealize handler

to be reached if the 9p share is mounted in the guest. No need to bother about in-flight I/O requests in this case. This patch fixes a QEMU crash on the source node if the user device_add a virtio-9p device and then migrate. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- V2: - now intr

[Qemu-devel] [PATCH v2 5/5] virtio-9p: add savem handlers

device... This patch simply registers migration handlers for virtio-9p-device. Whether migration is possible or not still depends on the migration blocker. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p-device.c | 12 1 file changed, 12 insertions(+)

[Qemu-devel] [PATCH v2 3/5] virtio-9p: block hot-unplug when device is active

accordingly. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p.c| 14 ++ hw/9pfs/virtio-9p.h|2 ++ hw/s390x/virtio-ccw.c |8 hw/virtio/virtio-pci.c |8 4 files changed, 32 insertions(+) diff --git a/hw/9pfs/virtio-

[Qemu-devel] [PATCH v2 2/5] qdev: add the HotUnpluggable handler

This handler allows to ask a device instance if it can be hot-unplugged. It is to be defined in device classes where hot-unpluggability depends on the device state (for example, virtio-9p devices cannot be unplugged if the 9p share is mounted in the guest). Signed-off-by: Greg Kurz <

[Qemu-devel] [PATCH v2 1/5] virtio-9p-coth: fix init function

The v9fs thread pool is a singleton, shared by all virtio-9p devices. The current code leaks underlying glib pointers each time a new virtio-9p device gets realized. Let's fix that ! While we're here, we also fix the trivial error path when memory allocation is failing. Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

On Tue, 6 Oct 2015 09:09:14 +0100 Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: > > If the user tries to hot unplug a virtio-9p device, it seems to succeed but > > in fact: > > - virtio-9p coroutines thread pool

Re: [Qemu-devel] [PATCH 1/3] virtio-9p-coth: add release function and fix init error path

On Mon, 05 Oct 2015 11:07:16 +0200 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > This is preliminary work to support hotplug/unplug of virtio-9p-device. > > Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > --- Hmm... still not good. Since this is shared by all vi

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

On Fri, 9 Oct 2015 10:36:56 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Fri, Oct 09, 2015 at 09:23:49AM +0200, Greg Kurz wrote: > > On Wed, 07 Oct 2015 14:20:28 +0530 > > "Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> wrote:

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

On Wed, 07 Oct 2015 14:20:28 +0530 "Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> wrote: > Stefan Hajnoczi <stefa...@gmail.com> writes: > > > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: > >> If the user tries to hot unp

[Qemu-devel] [PATCH v3 1/3] virtio-net: use the backend cross-endian capabilities

paths. The current vhost-net code also tries to configure net backends. This will be no more needed and will be addressed in a subsequent patch. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- v3: - dropped extraneous peer_has_vnet_hdr() declaration - only rely on the flag to

[Qemu-devel] [PATCH v3 2/3] Revert "vhost-net: tell tap backend about the vnet endianness"

This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991. Cross-endian is now configured by the core virtio-net code. We simply fall back on full emulation if the net backend cannot support the requested endianness for vnet headers. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> -

[Qemu-devel] [PATCH v3 0/3] virtio-net/vhost-net: share cross-endian enablement

and full emulation can now benefit from it. Of course we keep the current hack to fall back on when the backend doesn't support cross-endian. --- Greg Kurz (3): virtio-net: use the backend cross-endian capabilities Revert "vhost-net: tell tap backend about the vnet endianness"

[Qemu-devel] [PATCH v3 3/3] virtio: drop the virtio_needs_swap() helper

It is not used anymore. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- include/hw/virtio/virtio-access.h |9 - 1 file changed, 9 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h index 8aec843c8ff3..a01fff2e51d7

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

On Thu, 27 Aug 2015 15:30:55 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August

Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

that are identical save the ring region name, we can simplify further with a macro. I have pasted a patch below. You may fold it directly into your patch if people agree, In any case, you have: Acked-by: Greg Kurz gk...@linux.vnet.ibm.com Tested-by: Greg Kurz gk...@linux.vnet.ibm.com Merci Pierre ! -- Greg

Re: [Qemu-devel] [PATCH v2] virtio dataplane: adapt dataplane for virtio Version 1

On Wed, 26 Aug 2015 15:24:42 +0200 Pierre Morel pmo...@linux.vnet.ibm.com wrote: Let dataplane allocate different region for the desc/avail/used ring regions. Signed-off-by: Pierre Morel pmo...@linux.vnet.ibm.com Acked-by: Greg Kurz gk...@linux.vnet.ibm.com Stefan, In case SoB is more

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

: Greg Kurz gk...@linux.vnet.ibm.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com This seems to me like a bug in the caller. Why would anything try to call into the memory subsystem to do a zero-size transaction? thanks -- PMM Here's the patch

Re: [Qemu-devel] [PATCH v4] virtio dataplane: adapt dataplane for virtio Version 1

On Wed, 2 Sep 2015 18:53:44 +0200 Pierre Morel wrote: > Let dataplane allocate different region for the desc/avail/used > ring regions. > Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail > rings accordingly. > > Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH V2 5/8] memory: don't try to adjust endianness for zero length eventfd

rd mmio eventfd > in ppc. > > Cc: Greg Kurz <gk...@linux.vnet.ibm.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Jason Wang <jasow...@redhat.com> > --- Indeed, this patch prevents the crash to oc

Re: [Qemu-devel] [PATCH] virtio: right size for virtio_queue_get_avail_size

On Wed, 2 Sep 2015 17:50:55 +0200 Cornelia Huck wrote: > On Wed, 2 Sep 2015 17:23:49 +0200 > Pierre Morel wrote: > > > Being working on dataplane I notice something strange: > > > > virtio_queue_get_avail_size() used a 64bit size index > >

Re: [Qemu-devel] [PATCH v5] virtio dataplane: adapt dataplane for virtio Version 1

ff-by: Pierre Morel <pmo...@linux.vnet.ibm.com> > (changed __virtio16 into uint16_t, > map descriptor table and available ring read-only) > Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > --- > I have tested it works on ppc64. Tested-by: Greg Kurz <gk...@linu

Re: [Qemu-devel] [PATCH v5] virtio dataplane: adapt dataplane for virtio Version 1

ff-by: Pierre Morel <pmo...@linux.vnet.ibm.com> > (changed __virtio16 into uint16_t, > map descriptor table and available ring read-only) > Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > --- > As suggested by Michael during the review of v2. Cc: qemu-sta...@nongnu.

Re: [Qemu-devel] [PATCH v4] virtio dataplane: adapt dataplane for virtio Version 1

On Wed, 2 Sep 2015 18:53:44 +0200 Pierre Morel wrote: > Let dataplane allocate different region for the desc/avail/used > ring regions. > Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail > rings accordingly. > > Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH] virtio: right size for virtio_queue_get_avail_size

On Wed, 2 Sep 2015 19:57:25 +0200 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Wed, 2 Sep 2015 17:50:55 +0200 > Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > > > On Wed, 2 Sep 2015 17:23:49 +0200 > > Pierre Morel <pmo...@linux.vnet.ibm.com> wrote:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

On Wed, 9 Sep 2015 10:54:20 +1000 Sam Bobroff wrote: > On Tue, Sep 08, 2015 at 07:38:12AM +0200, Thomas Huth wrote: > > On 08/09/15 07:03, Sam Bobroff wrote: > > > On Tue, Sep 01, 2015 at 12:53:26PM +0200, Thomas Huth wrote: > > >> On 01/09/15 02:38, David Gibson wrote:

Re: [Qemu-devel] [PATCH v5] virtio dataplane: adapt dataplane for virtio Version 1

ccount to increase the used/avail > > rings accordingly. > > > > Signed-off-by: Pierre Morel <pmo...@linux.vnet.ibm.com> > > (changed __virtio16 into uint16_t, > > map descriptor table and available ring read-only) > > Signed-off-by: Greg Kurz <gk...@li

Re: [Qemu-devel] [PATCH v2 1/2] spapr: Add support for hwrng when available

On Mon, 31 Aug 2015 20:46:01 +0200 Thomas Huth wrote: > From: Michael Ellerman > > Some powerpc systems have support for a hardware random number generator > (hwrng). If such a hwrng is present the host kernel can provide access > to it via the

Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

gt; were guaranteed to be set. Other virtio devices looks fine. > > Fixes: 019a3edbb25f1571e876f8af1ce4c55412939e5d >("virtio: make features 64bit wide") > Cc: qemu-sta...@nongnu.org > Cc: Gerd Hoffmann <kra...@redhat.com> > Signed-off-by: Jason Wang <jasow...

Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

On Fri, 11 Sep 2015 10:30:21 +0200 Cornelia Huck wrote: > On Fri, 11 Sep 2015 16:01:56 +0800 > Jason Wang wrote: > > > After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make > > features 64bit wide"). Device's guest_features was

Re: [Qemu-devel] [PATCH] virtio: add some migration doc

ll > prevent myself getting a headache everytime I look at that code :) > > Feedback welcome. Excellent ! This is a very good to start with. Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> Just a thought below... > --- > docs/virtio-migration.txt | 101 > +

[Qemu-devel] [PATCH v2] virtio-9p: migrate virtio subsections

-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- v2: more detailed change log --- hw/9pfs/virtio-9p-device.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 93a407c45926..e3abcfaffb2a 100644 --- a/hw/9pfs/vir

[Qemu-devel] [PATCH] spapr: add a default rng device

as already passed on the command line The default device is created at reset time to ensure devices specified on the command line have been created. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/ppc/spapr.c | 17 + hw/ppc/spapr_rng.c |2 +-

[Qemu-devel] [PATCH] ppc: drop useless register sync

Since msr is always synced, no need to read it from KVM. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- target-ppc/translate_init.c |2 -- 1 file changed, 2 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index b54147350d88..49611e8e41fe

Re: [Qemu-devel] [PATCH] spapr: add a default rng device

On Wed, 30 Sep 2015 11:10:52 +0200 Thomas Huth <th...@redhat.com> wrote: > On 30/09/15 10:33, Greg Kurz wrote: > > On Tue, 29 Sep 2015 15:01:09 +1000 > > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > >> On Mon, Sep 28, 2015 at 12:13:47PM +0

Re: [Qemu-devel] [PATCH] spapr: add a default rng device

On Tue, 29 Sep 2015 15:01:09 +1000 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Mon, Sep 28, 2015 at 12:13:47PM +0200, Greg Kurz wrote: > > A recent patch by Thomas Huth brought a new spapr-rng pseudo-device to > > provide high-quality random numbers to guests.

Re: [Qemu-devel] [PATCH v2] virtio-9p: migrate virtio subsections

On Tue, 29 Sep 2015 14:06:43 +0200 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > In a cross-endian setup, the virtio-9p device has state in @device_endian. It > must be migrated. This patch just adds the minimal support to live migrate > generic virtio subsections where @device_en

Re: [Qemu-devel] [PATCH] ppc: drop useless register sync

On Fri, 2 Oct 2015 16:03:56 +0200 Thomas Huth <th...@redhat.com> wrote: > On 01/10/15 18:56, Greg Kurz wrote: > > Since msr is always synced, no need to read it from KVM. > > Out of curiosity: Where does that happen? > It does not happen in fact... and this patch

Re: [Qemu-devel] [PATCH] spapr: add a default rng device

Cc'ing qemu-ppc@ On Mon, 28 Sep 2015 12:13:47 +0200 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > A recent patch by Thomas Huth brought a new spapr-rng pseudo-device to > provide high-quality random numbers to guests. The device may either be > backed by a "RngBacke

[Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

above issues. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p-device.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 93a407c45926..ed133c40493a 100644 --- a/hw/9pfs/virtio-9p-device.c

[Qemu-devel] [PATCH 1/3] virtio-9p-coth: add release function and fix init error path

This is preliminary work to support hotplug/unplug of virtio-9p-device. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p-coth.c | 13 + hw/9pfs/virtio-9p-coth.h |1 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/9pfs/vir

[Qemu-devel] [PATCH 3/3] virtio-9p: add savem handlers

device... This patch simply registers migration handlers for virtio-9p-device. Whether migration is possible or not still depends on the migration blocker. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p-device.c | 12 1 file changed, 12 insertions(+)

[Qemu-devel] [PATCH 0/3] virtio-9p: hotplug and migration support

This series brings both hoplug and migration support to virtio-9p devices. Patch 1 is preliminary work. Patch 2 brings hotplug and fixes a QEMU crash. Patch 3 brings migration (of course it still depends on the 9p to be unmounted) --- Greg Kurz (3): virtio-9p-coth: add release function

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

On Thu, 17 Sep 2015 10:49:41 +0200 Thomas Huth wrote: > The PAPR interface defines a hypercall to pass high-quality > hardware generated random numbers to guests. Recent kernels can > already provide this hypercall to the guest if the right hardware > random number generator is

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

On Mon, 21 Sep 2015 12:10:00 +1000 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Fri, Sep 18, 2015 at 11:05:52AM +0200, Greg Kurz wrote: > > On Thu, 17 Sep 2015 10:49:41 +0200 > > Thomas Huth <th...@redhat.com> wrote: > > > > > The PAPR interfac

Re: [Qemu-devel] [PATCH] virtio-9p: migrate virtio subsections

On Mon, 21 Sep 2015 10:09:34 +0200 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Sat, 19 Sep 2015 15:34:02 +0530 > "Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> wrote: > > > Greg Kurz <gk...@linux.vnet.ibm.com> writes: > > > > &g

[Qemu-devel] [PATCH] virtio-9p: migrate virtio subsections

In a cross-endian setup, the virtio-9p device has state in @device_endian. It must be migrated. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p-device.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/vir

Re: [Qemu-devel] [PATCH] virtio-9p: migrate virtio subsections

On Sat, 19 Sep 2015 15:34:02 +0530 "Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> wrote: > Greg Kurz <gk...@linux.vnet.ibm.com> writes: > > > In a cross-endian setup, the virtio-9p device has state in @device_endian. > > It > > must be

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

On Mon, 21 Sep 2015 10:26:52 +0200 Thomas Huth <th...@redhat.com> wrote: > On 21/09/15 10:01, Greg Kurz wrote: > > On Mon, 21 Sep 2015 12:10:00 +1000 > > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > >> On Fri, Sep 18, 2015 at 11:05:52AM +0

[Qemu-devel] [PATCH for-2.5] virtio-9p-device: add minimal unrealize handler

supported in QEMU, and not supported by linux guests either. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p-device.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 944b5f5e9fcc..b42

Re: [Qemu-devel] [PATCH v2] util/mmap-alloc: fix hugetlb support on ppc64

t this and create the PROT_NONE mapping using the same fd. > > Naturally, this makes the guard page bigger with hugetlbfs. > > Based on patch by Greg Kurz. > > Cc: Rik van Riel <r...@redhat.com> > CC: Greg Kurz <gk...@linux.vnet.ibm.com> > Signed-off-b

Re: [Qemu-devel] [PATCH] mmap-alloc: tweak a comment on ppc64

ch the fd is mapped, instead. > > It's also not clear what does "in this case" refer > to, rearrange text to make it clearer. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- This is better indeed. Thanks ! Reviewed-by: Greg Kurz <gk...@linux.vnet.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr/pci: populate PCI DT in reverse order

On Tue, 1 Dec 2015 22:48:38 +0100 Thomas Huth <th...@redhat.com> wrote: > On 30/11/15 11:45, Greg Kurz wrote: > > Since commit 1d2d974244c6 "spapr_pci: enumerate and add PCI device tree", > > QEMU > > populates the PCI device tree in the opposite or

Re: [Qemu-devel] [PULL 0/2] virtio-9p fixes for 2.5

On Tue, 1 Dec 2015 16:30:09 + Peter Maydell <peter.mayd...@linaro.org> wrote: > On 30 November 2015 at 16:11, Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > The following changes since commit 714487515dbe0c65d5904251e796cd3a5b3579fb: > > > > Merge remote-

[Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes

This series tries to rework cross-endian helpers for better clarity. It does not change behaviour, except perhaps patch 3/3 even if I could not measure any performance gain. --- Greg Kurz (3): virtio: move cross-endian helper to vhost vhost: move virtio 1.0 check to cross-endian

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr/pci: populate PCI DT in reverse order

On Thu, 3 Dec 2015 15:53:17 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Tue, 1 Dec 2015 22:48:38 +0100 > Thomas Huth <th...@redhat.com> wrote: > > > On 30/11/15 11:45, Greg Kurz wrote: > > > Since commit 1d2d974244c6 "spapr_pci: enumer

[Qemu-devel] [PATCH v2 2/3] vhost: move virtio 1.0 check to cross-endian helper

Indeed vhost doesn't need to ask for vring endian fixing if the device is virtio 1.0, since it is already handled by the in-kernel vhost driver. This patch simply consolidates the logic into the existing helper. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> Reviewed-by: Corneli

[Qemu-devel] [PATCH v2 3/3] virtio: optimize virtio_access_is_big_endian() for little-endian targets

a runtime check for virtio 1.0, which ruins the benefit of the virtio_access_is_big_endian() helper for always little-endian targets. With this patch, always little-endian targets stop checking for virtio 1.0, since the result is little-endian in all cases. Signed-off-by: Greg Kurz <

Re: [Qemu-devel] [PATCH v3 0/3] virtio-net/vhost-net: share cross-endian enablement

On Wed, 18 Nov 2015 22:46:55 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Wed, 18 Nov 2015 22:48:06 +0200 > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > On Wed, Nov 18, 2015 at 05:23:00PM +0100, Greg Kurz wrote: > > > Since QEMU

[Qemu-devel] [PATCH v2 1/3] virtio: move cross-endian helper to vhost

, where indeed non bi-endian targets don't have to deal with cross-endian issues. This patch moves the helper to vhost.c and gives it a more appropriate name. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- hw/vi

[Qemu-devel] [PATCH 2/7] target-ppc: rename and export maybe_bswap_register()

This helper will be used to support FP, Altivec and VSX registers when the guest is little-endian. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- target-ppc/cpu.h |1 + target-ppc/gdbstub.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/

[Qemu-devel] [PATCH 0/7] target-ppc: endian fixes for KVM and gdbstub

to patch 1 since it is needed for the gdbstub fixes to actually work, but it could even be handled separately. And finally, patch 7 is Anton's + the byteswapping for little-endian guests. Cheers. --- Anton Blanchard (1): target-ppc: gdbstub: Add VSX support Greg Kurz (6): target-ppc

[Qemu-devel] [PATCH 3/7] target-ppc: gdbstub: fix float registers for little-endian guests

Let's reuse the ppc_maybe_bswap_register() helper, like we already do with the general registers. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- target-ppc/translate_init.c |4 1 file changed, 4 insertions(+) diff --git a/target-ppc/translate_init.c b/targ

[Qemu-devel] [PATCH 1/7] target-ppc: kvm: fix floating point registers sync on little-endian hosts

for little-endian hosts. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- target-ppc/kvm.c | 12 1 file changed, 12 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index ac70f0897b35..acd327538ce2 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@

[Qemu-devel] [PATCH 4/7] target-ppc: gdbstub: introduce avr_need_swap()

This helper will be used to support Altivec registers in little-endian guests. This patch does not change functionnality. Note: I had to put the helper some lines away from the gdb_*_avr_reg() routines to get a more readable patch. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> ---

[Qemu-devel] [PATCH 6/7] target-ppc: gdbstub: fix spe registers for little-endian guests

Let's reuse the ppc_maybe_bswap_register() helper, like we already do with the general registers. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- target-ppc/translate_init.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/target-ppc/translate_in

[Qemu-devel] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

, for both system and user mode. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- target-ppc/translate_init.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 18e9e561561f..80d53e4dcf5a

[Qemu-devel] [PATCH 7/7] target-ppc: gdbstub: Add VSX support

From: Anton Blanchard <an...@samba.org> Add the XML and functions to get and set VSX registers. Signed-off-by: Anton Blanchard <an...@samba.org> (fixed little-endian guests) Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- configure |6 +++--- gdb

Re: [Qemu-devel] [PATCH for-2.5] virtio-9p-device: add minimal unrealize handler

On Thu, 10 Dec 2015 11:17:09 + Peter Maydell <peter.mayd...@linaro.org> wrote: > On 8 December 2015 at 16:19, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Tue, Dec 08, 2015 at 04:54:57PM +0100, Greg Kurz wrote: > >> Since commit 4652f1640e029e1f2433fa77b

Re: [Qemu-devel] [PATCH 0/7] target-ppc: endian fixes for KVM and gdbstub

On Fri, 18 Dec 2015 11:18:16 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > Hi, > > This series is a sequel to Anton's tentative at bringing VSX support in > our gdbstub: > > http://patchwork.ozlabs.org/patch/453758/ > > Indeed, FP, SPE and Altivec registe

Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

On Tue, 5 Jan 2016 18:29:56 +0100 Cédric Le Goater <c...@fr.ibm.com> wrote: > Signed-off-by: Cédric Le Goater <c...@fr.ibm.com> > --- Acked-by: Greg Kurz <gk...@linux.vnet.ibm.com> Just some minor comments on the form below. >

Re: [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify

On Wed, 6 Jan 2016 16:22:55 +0800 Cao jin <caoj.f...@cn.fujitsu.com> wrote: > Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> > --- Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> > hw/char/virtio-serial-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [Qemu-devel] [PATCH v2] trace-events: fix broken format strings

: also remove trailing null strings [Laurent] > > Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> > trace-events | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/trace-events b/trace-events > index 6f036384a84f8..98ec7482

[Qemu-devel] [PATCH] linux-user: fix typo in trace formats

); Fixes: c8ee0a445a6a85635e962c0346bc7b1259c1a3f5 Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- trace-events | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/trace-events b/trace-events index 6f036384a84f..ea5872dd72e2 100644 --- a/trace-events +++ b

Re: [Qemu-devel] [PATCH] linux-user: fix typo in trace formats

On Tue, 5 Jan 2016 08:52:39 -0700 Eric Blake <ebl...@redhat.com> wrote: > On 01/05/2016 08:29 AM, Greg Kurz wrote: > > When building all targets, I get tons of warnings like below: > > > > ./trace/generated-tracers.h: In function ‘trace_user_s390x_restore_sigr

Re: [Qemu-devel] [PATCH 3/8] ipmi: add GET_SYS_RESTART_CAUSE chassis command

On Tue, 5 Jan 2016 18:29:57 +0100 Cédric Le Goater <c...@fr.ibm.com> wrote: > This is a simulator. Just return an unknown cause (0). > > Signed-off-by: Cédric Le Goater <c...@fr.ibm.com> > --- Acked-by: Greg Kurz <gk...@linux.vnet.ibm.com>

Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes

On Wed, 23 Dec 2015 17:28:23 +0100 Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > On Wed, 23 Dec 2015 15:47:00 +0200 > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote: > > > This series t

[Qemu-devel] [PATCH 4/6] virtio: move cross-endian helper to vhost

, where indeed non bi-endian targets don't have to deal with cross-endian issues. This patch moves the helper to vhost.c and gives it a more appropriate name. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- hw/vi

[Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper

Indeed vhost doesn't need to ask for vring endian fixing if the device is virtio 1.0, since it is already handled by the in-kernel vhost driver. This patch simply consolidates the logic into the existing helper. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> Reviewed-by: Corneli

[Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper

It is not used anymore. Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- include/hw/virtio/virtio-access.h |9 - 1 file changed, 9 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h index 8aec843c8ff3..a01fff2e51d7

[Qemu-devel] [PATCH 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets

a runtime check for virtio 1.0, which ruins the benefit of the virtio_access_is_big_endian() helper for always little-endian targets. With this patch, always little-endian targets stop checking for virtio 1.0, since the result is little-endian in all cases. Signed-off-by: Greg Kurz <

Re: [Qemu-devel] [PATCH 2/6] Revert "vhost-net: tell tap backend about the vnet endianness"

On Thu, 7 Jan 2016 20:52:04 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > > > On 07/01/2016 12:32, Greg Kurz wrote: > > This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991. > > > > Cross-endian is now configured by the core virtio-net code

Re: [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper

On Thu, 7 Jan 2016 20:55:50 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > > > On 07/01/2016 12:32, Greg Kurz wrote: > > It is not used anymore. > > > > Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > > --- > > include/hw/virtio/v

Re: [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper

On Thu, 7 Jan 2016 21:07:26 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > > > On 07/01/2016 12:32, Greg Kurz wrote: > > Indeed vhost doesn't need to ask for vring endian fixing if the device is > > virtio 1.0, since it is already handled by the in-kernel vhost dr

Re: [Qemu-devel] [PATCH 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets

On Thu, 7 Jan 2016 21:25:19 +0100 Laurent Vivier <lviv...@redhat.com> wrote: > > > On 07/01/2016 12:32, Greg Kurz wrote: > > When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro > > and the virtio_access_is_big_endian() helper to

Re: [Qemu-devel] [PATCH 2/6] Revert "vhost-net: tell tap backend about the vnet endianness"

On Fri, 8 Jan 2016 11:11:20 +0100 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > On Thu, 07 Jan 2016 12:32:08 +0100 > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991. > > > > Cross-endian i

Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes

On Wed, 23 Dec 2015 15:47:00 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote: > > This series tries to rework cross-endian helpers for better clarity. > > It does not change behaviour, except pe

Re: [Qemu-devel] 9pfs is broken in 2.5 (SIGSEGV) (bisected)

On Sat, 19 Dec 2015 12:16:58 +0300 Michael Tokarev wrote: > 19.12.2015 11:15, Michael Tokarev wrote: > >> commit ebac1202c95a4f1b76b6ef3f0f63926fa76e753e > >> Author: Paolo Bonzini > >> Date: Fri Nov 27 12:43:06 2015 +0100 > >> virtio-9p: use QEMU

[Qemu-devel] [PATCH] virtio-9p: use accessor to get thread_pool

: ebac1202c95a4f1b76b6ef3f0f63926fa76e753e Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- Michael, I did not have time to reproduce the issue, and therefore to effectively test this patch fixes it. Maybe you can do it ? Thanks. -- Greg hw/9pfs/virtio-9p-coth.c |2 +- 1 file changed, 1 insertion(+), 1 de

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr/pci: populate PCI DT in reverse order

On Mon, 21 Dec 2015 12:56:24 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote: > On Thu, Dec 17, 2015 at 09:43:29AM +0100, Greg Kurz wrote: > > On Thu, 3 Dec 2015 15:53:17 +0100 > > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > > > On Tue, 1

[Qemu-devel] [PULL] virtio-9p: use accessor to get thread_pool

: ebac1202c95a4f1b76b6ef3f0f63926fa76e753e Reviewed-by: Michael Tokarev <m...@tls.msk.ru> Tested-by: Michael Tokarev <m...@tls.msk.ru> Cc: qemu-sta...@nongnu.org Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> --- hw/9pfs/virtio-9p-coth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Qemu-devel] [PULL] 9p fix

to fetch changes up to 4b3a4f2d458ca5a7c6c16ac36a8d9ac22cc253d6: virtio-9p: use accessor to get thread_pool (2015-12-23 10:56:58 +0100) Fix a 2.5 regression. Greg

Re: [Qemu-devel] [PATCH for-2.5] fsdev-proxy-helper: avoid TOC/TOU race

t;pbonz...@redhat.com> > --- Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> > fsdev/virtfs-proxy-helper.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c > index 9097d15..ad

Re: [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool

p-coth.h but anyway: Reviewed-by: Greg Kurz <gk...@linux.vnet.ibm.com> Tested-by: Greg Kurz <gk...@linux.vnet.ibm.com> > hw/9pfs/virtio-9p-coth.c | 79 > +++--- > hw/9pfs/virtio-9p-coth.h | 9 +- > hw/9pfs/virtio-9p-devic

Re: [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool

On Fri, 27 Nov 2015 14:08:47 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 27/11/2015 13:42, Greg Kurz wrote: > > On Fri, 27 Nov 2015 12:43:06 +0100 > > Paolo Bonzini <pbonz...@redhat.com> wrote: > > > >> The QEMU thread

<    1   2   3   4   5   6   7   8   9   10   >