On 18.03.22 16:08, John Snow wrote:
On Fri, Mar 18, 2022, 9:36 AM Hanna Reitz wrote:
On 18.03.22 00:49, John Snow wrote:
> Hiya!
>
> This series effectively replaces qemu_img_pipe_and_status() with a
> rewritten function named qemu_img() that raises
On 09.03.22 11:16, Thomas Huth wrote:
These two spots have been missed in commit 9086c7639822 ("Rework the
checks and spots using GNU sed") - they need GNU sed, too, since they
are using the "+" address form.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/common.filter | 4 ++--
1 file
printed; but afterwards, they are. So I’m afraid all I can give is a
Tested-by: Hanna Reitz
If noone else steps up and you need a tree for this to go in, I’d be up
for it.
Hanna
On 17.03.22 16:11, Paolo Bonzini wrote:
On 3/16/22 13:32, Stefan Hajnoczi wrote:
You can define rules and a way to enforce a subset of C++, but I think
over time the code will be C++. A policy that is complicated discourages
contributors.
For these reasons I think that if code runs through a
On 17.03.22 16:58, John Snow wrote:
On Thu, Mar 17, 2022 at 11:28 AM Hanna Reitz wrote:
On 09.03.22 04:54, John Snow wrote:
With the exceptional 'create' calls removed in the prior commit, change
qemu_img_log() and img_info_log() to call qemu_img() directly
instead.
In keeping
On 17.03.22 16:13, John Snow wrote:
On Thu, Mar 17, 2022 at 5:23 AM Hanna Reitz wrote:
On 08.03.22 02:57, John Snow wrote:
This adds an Exception that extends the Python stdlib
subprocess.CalledProcessError.
The difference is that the str() method of this exception also adds the
stdout
On 17.03.22 16:24, John Snow wrote:
On Thu, Mar 17, 2022 at 6:25 AM Hanna Reitz wrote:
On 08.03.22 02:57, John Snow wrote:
+if check and subp.returncode or (subp.returncode < 0):
I wouldn’t expect these parentheses here in any other language, are they
required in Python?
I
in
negative tests, to see a crash from qemu-img.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
---
tests/qemu-iotests/257| 8 +++--
tests/qemu-iotests/iotests.py | 56 ++-
2 files changed, 54 insertions(+), 10 deletions(-)
Reviewed-by: Hanna Reitz
On 17.03.22 17:31, John Snow wrote:
On Thu, Mar 17, 2022 at 11:56 AM Hanna Reitz wrote:
On 17.03.22 16:13, John Snow wrote:
On Thu, Mar 17, 2022 at 5:23 AM Hanna Reitz wrote:
On 08.03.22 02:57, John Snow wrote:
This adds an Exception that extends the Python stdlib
On 17.05.22 13:39, Alberto Faria wrote:
Signed-off-by: Alberto Faria
---
block/block-backend.c | 11 ---
block/coroutines.h| 2 --
include/sysemu/block-backend-io.h | 2 +-
3 files changed, 1 insertion(+), 14 deletions(-)
Reviewed-by: Hanna Reitz
On 17.05.22 13:39, Alberto Faria wrote:
Keep generated_co_wrapper and coroutine_fn pairs together. This should
make it clear that each I/O function has these two versions.
Also move blk_co_{pread,pwrite}()'s implementations out of the header
file for consistency.
Signed-off-by: Alberto Faria
On 17.05.22 13:39, Alberto Faria wrote:
Signed-off-by: Alberto Faria
---
block/block-backend.c | 12
block/coroutines.h| 3 ---
include/sysemu/block-backend-io.h | 3 ++-
3 files changed, 2 insertions(+), 16 deletions(-)
Reviewed-by: Hanna Reitz
-by: Hanna Reitz
On 05.07.22 11:57, Yu Zhang wrote:
Hi All,
since QEMU-5.2, the QMP command "nbd-server-add" was deprecated and
replaced with "block-export-add" [1].
Arguments for the two are different. For using "block-export-add",
"id" and "node-name" are needed, of which "id" is "device" for
be initialized here, too.
With that done:
Reviewed-by: Hanna Reitz
+QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, sizeof(buf));
+int ret;
+
+/* Success */
+ret = blk_pwritev_part(blk, 0, sizeof(buf), , 0, 0);
+g_assert_cmpint(ret, ==, 0);
+
+/* Early error: Negative offset
insertions(+), 10 deletions(-)
Reviewed-by: Hanna Reitz
On 05.07.22 11:35, Thomas Huth wrote:
Hi!
I've just hit a failure in iotest 183:
--- /home/thuth/devel/qemu/tests/qemu-iotests/183.out
+++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/183/183.out.bad
@@ -30,7 +30,7 @@
'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk':
changed, 24 insertions(+), 5 deletions(-)
Reviewed-by: Hanna Reitz
-by: Hanna Reitz
++
3 files changed, 27 insertions(+), 6 deletions(-)
Reviewed-by: Hanna Reitz
| 38 -
6 files changed, 79 insertions(+), 79 deletions(-)
Reviewed-by: Hanna Reitz
insertions(+), 219 deletions(-)
Reviewed-by: Hanna Reitz
+++---
include/block/block-io.h | 10 +++---
tests/unit/test-block-iothread.c | 8 ++---
24 files changed, 242 insertions(+), 239 deletions(-)
Reviewed-by: Hanna Reitz
fic check).
Given that, and given that there’s precedent (e.g. bdrv_pread()), I’m OK
with the change.
Reviewed-by: Hanna Reitz
| 5 ++---
tests/unit/test-block-iothread.c | 4 ++--
10 files changed, 19 insertions(+), 31 deletions(-)
Reviewed-by: Hanna Reitz
On 09.06.22 17:27, Alberto Faria wrote:
It does not mutate the buffer.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
---
include/block/block_int-io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Hanna Reitz
| 41
include/block/block-io.h | 15 +--
2 files changed, 9 insertions(+), 47 deletions(-)
Reviewed-by: Hanna Reitz
files changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Hanna Reitz
On 09.06.22 17:27, Alberto Faria wrote:
Start by making the interfaces of analogous non-coroutine and coroutine
functions consistent with each other, then implement the non-coroutine
ones using generated_co_wrapper.
For the bdrv_pwrite_sync() case, also add the missing
bdrv_co_pwrite_sync()
+++---
qemu-img.c| 18 ++--
qemu-io-cmds.c| 4 +--
tests/unit/test-block-iothread.c | 8 +++---
38 files changed, 150 insertions(+), 149 deletions(-)
Reviewed-by: Hanna Reitz
insertions(+), 6 deletions(-)
Reviewed-by: Hanna Reitz
On 01.07.22 18:15, John Snow wrote:
On Fri, Jul 1, 2022 at 4:05 AM Hanna Reitz wrote:
On 16.06.22 16:26, John Snow wrote:
In certain container environments we may not have FUSE at all, so skip
the test in this circumstance too.
Signed-off-by: John Snow
---
tests/qemu-iotests/108 | 5
/qcow2-snapshot.c | 6 +++---
block/qcow2.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Hanna Reitz
(-)
Reviewed-by: Hanna Reitz
deletions(-)
Reviewed-by: Hanna Reitz
-block-iothread.c | 4 ++--
12 files changed, 43 insertions(+), 41 deletions(-)
Overall, looks good to me, so first of all:
Reviewed-by: Hanna Reitz
There are a couple of places where you decided to replace “*len”
variables that used to store the return value by a plain “ret”. That
seems
| 4
block/meson.build | 1 +
include/sysemu/block-backend-io.h | 10 ++
4 files changed, 7 insertions(+), 31 deletions(-)
Reviewed-by: Hanna Reitz
On 17.05.22 13:38, Alberto Faria wrote:
It does not mutate the buffer.
Signed-off-by: Alberto Faria
---
include/sysemu/block-backend-io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Hanna Reitz
On 16.06.22 16:26, John Snow wrote:
In certain container environments we may not have FUSE at all, so skip
the test in this circumstance too.
Signed-off-by: John Snow
---
tests/qemu-iotests/108 | 5 +
1 file changed, 5 insertions(+)
Reviewed-by: Hanna Reitz
On 13.04.22 14:26, Raphael Pour wrote:
This patch completes the reopen functionality for an attached RBD where altered
driver options can be passed to. This is necessary to move RBDs between ceph
clusters without interrupting QEMU, where some ceph settings need to be
adjusted.
The
On 16.06.22 16:26, John Snow wrote:
Fixes: 58a6fdcc
Signed-off-by: John Snow
Tested-by: Daniel P. Berrangé
Reviewed-by: Daniel P. Berrangé
---
tests/qemu-iotests/223.out | 4 ++--
tests/qemu-iotests/307.out | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Hanna
On 30.06.22 16:09, Hanna Reitz wrote:
> [snip]
On 30.06.22 16:53, Markus Armbruster wrote:
> [snip]
On 01.07.22 12:00, Gerd Hoffmann wrote:
> [snip]
I have addressed the things mentioned:
- limiting line length to 80 in ui.json, qemu-options.hx
- limiting line length in commit
Ping
On 09.06.22 14:26, Hanna Reitz wrote:
Hi,
QEMU (the system emulator) and the storage daemon (QSD) write their PID
to the given file when you specify --pidfile. They keep the path around
and register exit handlers (QEMU uses an exit notifier, QSD an atexit()
function) to unlink this file
On 09.06.22 14:26, Hanna Reitz wrote:
Hi,
QEMU (the system emulator) and the storage daemon (QSD) write their PID
to the given file when you specify --pidfile. They keep the path around
and register exit handlers (QEMU uses an exit notifier, QSD an atexit()
function) to unlink this file when
ner
---
qapi/ui.json| 7 ++-
qemu-options.hx | 6 +-
ui/gtk.c| 4
3 files changed, 15 insertions(+), 2 deletions(-)
Reviewed-by: Hanna Reitz
declarations in block-backend-io.h
block: Remove remaining unused symbols in coroutines.h
Hanna Reitz (5):
qsd: Do not use error_report() before monitor_init
iotests/297: Have mypy ignore unused ignores
qsd: Unlink absolute PID file path
vl: Conditionally register PID file unlink notifier
, buf, bytes, 0)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20220609152744.3891847-2-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Sign
From: Alberto Faria
Also convert bdrv_pwrite_sync() to being implemented using
generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Message-Id: <20220609152744.3891847-9-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna
: <20220609152744.3891847-5-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
include/crypto/block.h | 32 ++---
block/crypto.c | 52 +-
block/qcow2.c | 22 +++---
crypto/block-
if 'bytes' is negative or greater than
BDRV_REQUEST_MAX_BYTES, which in turns never exceeds SIZE_MAX.
Signed-off-by: Alberto Faria
Message-Id: <20220609152744.3891847-7-afa...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
block/corout
From: Alberto Faria
Use bdrv_pwrite_sync() instead of calling bdrv_pwrite() and bdrv_flush()
separately.
Signed-off-by: Alberto Faria
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Message-Id: <20220609152744.3891847-11-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by:
, buf, bytes, 0)
It had no effect on hw/block/nand.c, presumably due to the #if, so that
file was updated manually.
Overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Greg Kurz
Reviewed-by: Hanna Reitz
Message-Id
From: Alberto Faria
Implement blk_preadv_part() using generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-9-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
block/coroutines.h
From: Alberto Faria
It does not mutate the buffer.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-6-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backend-io.h | 2 +-
1 file changed, 1 ins
.
Signed-off-by: Alberto Faria
Message-Id: <20220705161527.1054072-2-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
block.c | 8 +---
block/block-backend.c| 7 ++-
block/qcow.c | 6 +++---
hw/block/
From: Alberto Faria
It does not mutate the buffer.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Message-Id: <20220609152744.3891847-6-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
include/block/block_int-io.h | 2
viewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
block/parallels.c | 2 +-
block/qcow2-snapshot.c | 6 +++---
block/qcow2.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index f22444efff..8b23b9580d 100644
--- a
-Ogievskiy
Message-Id: <20220609152744.3891847-3-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
include/block/block-io.h | 10 +++---
block/blklogwrites.c | 6 ++--
block/bochs.c| 10 +++---
block/cloop.c
From: John Snow
In certain container environments we may not have FUSE at all, so skip
the test in this circumstance too.
Signed-off-by: John Snow
Message-Id: <20220616142659.3184115-3-js...@redhat.com>
Reviewed-by: Thomas Huth
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
From: Alberto Faria
For consistency with other I/O functions, and in preparation to
implement them using generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-5-afa...@redhat.com>
Signed-off-by: Hanna
.
The few callers that rely on the previous behavior are adjusted
accordingly by hand.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Message-Id: <20220609152744.3891847-4-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
From: Alberto Faria
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-15-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
block/coroutines.h| 2 --
include/sysemu/block-backend-io.h | 2 +-
block
From: Alberto Faria
Also convert blk_pwrite_compressed() into a generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-12-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backen
the BDRV_REQ_MAY_UNMAP flag when appropriate, which it didn't
previously.
Signed-off-by: Alberto Faria
Message-Id: <20220609152744.3891847-8-afa...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
include/block/block-io.h | 15 +--
bloc
From: Alberto Faria
Also convert blk_ioctl() into a generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-16-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
block/coroutines.h
Bonzini
Message-Id: <20220705161527.1054072-18-afa...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backend-io.h | 77 +--
block/block-backend.c | 22 +
2 files changed, 54 insertions(+), 45 del
From: Alberto Faria
Also convert it into a generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-10-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
block/coroutines.h| 5 -
i
From: John Snow
Fixes: 58a6fdcc
Signed-off-by: John Snow
Tested-by: Daniel P. Berrangé
Reviewed-by: Daniel P. Berrangé
Message-Id: <20220616142659.3184115-2-js...@redhat.com>
Reviewed-by: Hanna Reitz
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/223.out | 4 ++--
tests/qemu-iotes
that
file was updated manually.
Overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-4-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backend-io.h | 4 +--
b
From: Alberto Faria
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-13-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backend-io.h | 5 +++--
block/block-backend.c | 8
From: Alberto Faria
Also convert blk_truncate() into a generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-17-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backend-io.
From: Alberto Faria
Implement them using generated_co_wrapper.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-8-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-backend-io.h | 6 +
test
$ kill $(cat qsd.pid)
$ file qsd.pid
qsd.pid: ASCII text
(qsd.pid should be gone after the process has terminated.)
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2092322
Signed-off-by: Hanna Reitz
Message-Id: <20220609122701.17172-2-hre...@redhat.com>
Reviewed-by: Daniel P. Be
From: Alberto Faria
Some can be made static, others are unused generated_co_wrappers.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-19-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
block/coroutines.h
From: Alberto Faria
Swap 'buf' and 'bytes' around for consistency with other I/O functions.
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-11-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
include/sysemu/block-b
Currently, the exit notifier for unlinking the PID file is registered
unconditionally. Limit it to only when we actually do create a PID
file.
Signed-off-by: Hanna Reitz
Message-Id: <20220609122701.17172-3-hre...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
softmmu/vl.
0.950 mypy, as far as I can tell; just for different `ignore`
lines).
Signed-off-by: Hanna Reitz
Message-Id: <20220621092536.19837-1-hre...@redhat.com>
Acked-by: John Snow
---
tests/qemu-iotests/mypy.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/mypy.
From: Alberto Faria
We need to add include/sysemu/block-backend-io.h to the inputs of the
block-gen.c target defined in block/meson.build.
Signed-off-by: Alberto Faria
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-7-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
From: Alberto Faria
Signed-off-by: Alberto Faria
Reviewed-by: Paolo Bonzini
Reviewed-by: Hanna Reitz
Message-Id: <20220705161527.1054072-14-afa...@redhat.com>
Signed-off-by: Hanna Reitz
---
block/coroutines.h| 3 ---
include/sysemu/block-backend-io.h | 3 ++-
block
error_report() only works once monitor_init_globals_core() has been
called, which is not the case when parsing the --daemonize option. Use
fprintf(stderr, ...) instead.
Fixes: 2525edd85fec53e23fda98974a15e3b3c8957596 ("qsd: Add --daemonize")
Signed-off-by: Hanna Reitz
$ kill $(cat qemu.pid)
$ file qemu.pid
qemu.pid: ASCII text
(qemu.pid should be gone after the process has terminated.)
Signed-off-by: Hanna Reitz
Message-Id: <20220609122701.17172-4-hre...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
softmmu/vl.c | 30 ++
()
- don't keep **child indirection, move to just returning a child ptr
(honestly, I didn't analyze all the callers do they need this int value.
Do you think it's needed?)
- handle snapshot-access.c
14: get rid of _ptr
15: update comment
Reviewed-by: Hanna Reitz
Patch 2
Hi,
(Thanks for the patch!)
On 27.06.22 18:44, Felix xq Queißner wrote:
The patch adds "show_tabs" command line option for GTK ui similar to
"grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at
each start of the VM.
I’m not sure we have a hard rule on
On 30.06.22 16:09, Hanna Reitz wrote:
Hi,
(Thanks for the patch!)
On 27.06.22 18:44, Felix xq Queißner wrote:
The patch adds "show_tabs" command line option for GTK ui similar to
"grab_on_hover". This option allows tabbed view mode to not have to
be enabled by hand at
perly as I ended
up with 0 return values which are handled by filling in with 0 (reads
after eof) and that didn't work well)
Anyway, this looks OK to me now.
Thanks,
Dominique
block/io_uring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Hanna Reitz
On 06.07.22 16:46, Vladimir Sementsov-Ogievskiy wrote:
On 7/6/22 13:26, Hanna Reitz wrote:
On 05.07.22 17:37, Vladimir Sementsov-Ogievskiy wrote:
strerror() represents ETIMEDOUT a bit different in Linux and macOS /
FreeBSD. Let's support the latter too.
Fixes: 9d05a87b77 ("iotests:
--
tests/unit/test-block-iothread.c | 4 ++--
12 files changed, 49 insertions(+), 51 deletions(-)
Reviewed-by: Hanna Reitz
Reviewed-by: Paolo Bonzini
---
block/block-backend.c | 22 +
include/sysemu/block-backend-io.h | 77 +--
2 files changed, 54 insertions(+), 45 deletions(-)
Reviewed-by: Hanna Reitz
On 05.07.22 18:15, Alberto Faria wrote:
Adjust existing pairs of non-coroutine and coroutine functions to share
the same calling convention, and add non-coroutine/coroutine
counterparts where they don't exist.
Also make the non-coroutine versions generated_co_wrappers.
This series sits on top
On 05.07.22 17:37, Vladimir Sementsov-Ogievskiy wrote:
strerror() represents ETIMEDOUT a bit different in Linux and macOS /
FreeBSD. Let's support the latter too.
Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout
option")
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
(-)
Reviewed-by: Hanna Reitz
+++
tests/unit/test-block-iothread.c | 19 +++
4 files changed, 49 insertions(+), 12 deletions(-)
Reviewed-by: Hanna Reitz
| 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Hanna Reitz
++---
1 file changed, 18 insertions(+), 27 deletions(-)
Reviewed-by: Hanna Reitz
(-)
Reviewed-by: Hanna Reitz
*q,
return 0;
}
+/*
+ * @list is any list of nodes. List is completed by all subtreees and
*subtrees
With that fixed:
Reviewed-by: Hanna Reitz
+ * topologically sorted. It's not a problem if some node occurs in the @list
+ * several times.
+ */
+static int bdrv_list_refresh_perms
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
To be used in further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 48
1 file changed, 48 insertions(+)
Looking at bdrv_child_try_set_aio_context(), it looks like
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
Now the function can remove any child, so give it more common name.
Drop assertions and drop bs argument which becomes unused. Function
would be reused in a further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 22
(-)
Reviewed-by: Hanna Reitz
2 files changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Hanna Reitz
901 - 1000 of 1120 matches
Mail list logo
