Re: [PATCH v3] hvf: guard xgetbv call.

2021-01-18 Thread Hill Ma
gentle bump :) On Tue, Jan 12, 2021 at 10:07 PM Hill Ma wrote: > > This prevents illegal instruction on cpus do not support xgetbv. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 > Signed-off-by: Hill Ma > --- > v3: addressed feedback. > v2: xgetbv() mo

[PATCH v3] hvf: guard xgetbv call.

2021-01-12 Thread Hill Ma
This prevents illegal instruction on cpus do not support xgetbv. Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 Signed-off-by: Hill Ma --- v3: addressed feedback. v2: xgetbv() modified based on feedback. target/i386/hvf/x86_cpuid.c | 34 ++ 1 file changed

Re: [PATCH v2] hvf: guard xgetbv call.

2021-01-11 Thread Hill Ma
On Sun, Jan 10, 2021 at 8:38 PM Roman Bolshakov wrote: > I'm not sure if eax should be modified with mask because the mask has no > value per se. I.e. eax &= supp_xcr0 from below should be placed inside > the if. It'd express clearly that eax is not modified unless xgetbv is > supported. Like

[PATCH v2] hvf: guard xgetbv call.

2021-01-10 Thread Hill Ma
This prevents illegal instruction on cpus do not support xgetbv. Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 Signed-off-by: Hill Ma --- v2: xgetbv() modified based on feedback. target/i386/hvf/x86_cpuid.c | 28 +++- 1 file changed, 19 insertions(+), 9

[PATCH] hvf: guard xgetbv call.

2020-12-19 Thread Hill Ma
This prevents illegal instruction on cpus do not support xgetbv. Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 Signed-off-by: Hill Ma --- target/i386/hvf/x86_cpuid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386