Re: [PATCH v3 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

2024-07-16 Thread Igor Mammedov
n-isa/riscv-brs/blob/main/acpi.adoc > (commit : 241575b3189c5d9e60b5e55e78cf0443092713bf) in spec links 'See RVI ACPI IDs' and right below it 'additional guidance', do lead nowhere hence do not clarify anything. > > Signed-off-by: Sunil V L > Acked-by: Alistair

Re: [PATCH V15 0/7] Add architecture agnostic code to support vCPU Hotplug

2024-07-16 Thread Igor Mammedov
On Tue, 16 Jul 2024 03:38:29 + Salil Mehta wrote: > Hi Igor, > > On 15/07/2024 15:11, Igor Mammedov wrote: > > On Mon, 15 Jul 2024 14:19:12 + > > Salil Mehta wrote: > > > >>> From: qemu-arm-bounces+salil.mehta=huawei@nongnu.or

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-07-16 Thread Igor Mammedov
On Sun, 30 Jun 2024 12:40:24 -0700 Steve Sistare wrote: > Allocate anonymous memory using mmap MAP_ANON or memfd_create depending > on the value of the anon-alloc machine property. This affects > memory-backend-ram objects, guest RAM created with the global -m option > but without an associated

Re: [PATCH V15 0/7] Add architecture agnostic code to support vCPU Hotplug

2024-07-15 Thread Igor Mammedov
On Mon, 15 Jul 2024 14:19:12 + Salil Mehta wrote: > > From: qemu-arm-bounces+salil.mehta=huawei@nongnu.org > arm-bounces+salil.mehta=huawei@nongnu.org> On Behalf Of Salil > > Mehta via > > Sent: Monday, July 15, 2024 3:14 PM > > To: Igo

Re: [PATCH v5 10/13] hw/acpi: Generic Port Affinity Structure support

2024-07-15 Thread Igor Mammedov
On Fri, 12 Jul 2024 12:08:14 +0100 Jonathan Cameron wrote: > These are very similar to the recently added Generic Initiators > but instead of representing an initiator of memory traffic they > represent an edge point beyond which may lie either targets or > initiators. Here we add these ports su

Re: [PATCH v5 09/13] hw/pci-host/gpex-acpi: Use acpi_uid property.

2024-07-15 Thread Igor Mammedov
On Fri, 12 Jul 2024 12:08:13 +0100 Jonathan Cameron wrote: > Reduce the direct use of PCI internals inside ACPI table creation. > > Suggested-by: Igor Mammedov > Tested-by: "Huang, Ying" > Signed-off-by: Jonathan Cameron Reviewed-by: Igor Mammedov > --- > v

Re: [PATCH v5 08/13] hw/i386/acpi: Use TYPE_PXB_BUS property acpi_uid for DSDT

2024-07-15 Thread Igor Mammedov
On Fri, 12 Jul 2024 12:08:12 +0100 Jonathan Cameron wrote: > Rather than relying on PCI internals, use the new acpi_property > to obtain the ACPI _UID values. These are still the same > as the PCI Bus numbers so no functional change. > > Suggested-by: Igor Mammedov > Teste

Re: [PATCH v5 07/13] hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS

2024-07-15 Thread Igor Mammedov
can be made completely independent of PCI internals. > > Suggested-by: Igor Mammedov > Tested-by: "Huang, Ying" > Signed-off-by: Jonathan Cameron > Reviewed-by: Igor Mammedov > --- > v5: Add missing property description. > --- > hw/pci-bridge/pci_expander_

Re: [PATCH v5 06/13] acpi/pci: Move Generic Initiator object handling into acpi/pci.*

2024-07-15 Thread Igor Mammedov
> hw/acpi/pci.c file and header. If support for ACPI Device Handles is > added in the future, perhaps this will be moved again. > > Also push the struct AcpiGenericInitiator down into the c file as not > used outside pci.c. > > Suggested-by: Igor Mammedov > Tested-by: "H

Re: [PATCH v5 06/13] acpi/pci: Move Generic Initiator object handling into acpi/pci.*

2024-07-15 Thread Igor Mammedov
> hw/acpi/pci.c file and header. If support for ACPI Device Handles is > added in the future, perhaps this will be moved again. > > Also push the struct AcpiGenericInitiator down into the c file as not > used outside pci.c. > > Suggested-by: Igor Mammedov > Tested-by: "H

Re: [PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old()

2024-07-15 Thread Igor Mammedov
qemu_open(). > > Cc: David Hildenbrand > Cc: Igor Mammedov > Signed-off-by: Zhao Liu Reviewed-by: Igor Mammedov > --- > backends/hostmem-epc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/backends/hostmem-epc.c b/backends/hostmem-epc.c

Re: [PATCH V15 0/7] Add architecture agnostic code to support vCPU Hotplug

2024-07-15 Thread Igor Mammedov
On Mon, 15 Jul 2024 11:27:57 + Salil Mehta wrote: > Hi Michael, > > > From: Michael S. Tsirkin > > Sent: Monday, July 15, 2024 12:13 PM > > To: Salil Mehta > > > > On Sat, Jul 13, 2024 at 07:25:09PM +0100, Salil Mehta wrote: > > > [Note: References are present at the last after th

Re: [PATCH V15 0/7] Add architecture agnostic code to support vCPU Hotplug

2024-07-15 Thread Igor Mammedov
On Sat, 13 Jul 2024 19:25:09 +0100 Salil Mehta wrote: > [Note: References are present at the last after the revision history] > > Virtual CPU hotplug support is being added across various architectures > [1][3]. > This series adds various code bits common across all architectures: > > 1. vCPU

Re: [PATCH V15 7/7] gdbstub: Add helper function to unregister GDB register space

2024-07-15 Thread Igor Mammedov
ed-by: Miguel Luis > Reviewed-by: Shaoqin Huang > Reviewed-by: Vishnu Pajjuri > Tested-by: Zhao Liu Acked-by: Igor Mammedov > --- > gdbstub/gdbstub.c | 13 + > hw/core/cpu-common.c | 4 +++- > include/exec/gdbstub.h | 6 ++ > 3 files

Re: [PATCH V15 5/7] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-07-15 Thread Igor Mammedov
gt; > Co-developed-by: Keqian Zhu > Signed-off-by: Keqian Zhu > Signed-off-by: Salil Mehta > Reviewed-by: Gavin Shan > Tested-by: Vishnu Pajjuri > Reviewed-by: Jonathan Cameron > Tested-by: Xianglai Li > Tested-by: Miguel Luis > Reviewed-by: Shaoqin Huang > Te

Re: [PATCH V15 1/7] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-15 Thread Igor Mammedov
On Mon, 15 Jul 2024 14:49:25 +0200 Igor Mammedov wrote: > On Sat, 13 Jul 2024 19:25:10 +0100 > Salil Mehta wrote: > > > KVM vCPU creation is done once during the vCPU realization when Qemu vCPU > > thread > > is spawned. This is common to all the architectures as

Re: [PATCH V15 3/7] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-07-15 Thread Igor Mammedov
On Sat, 13 Jul 2024 19:25:12 +0100 Salil Mehta wrote: > ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the > _CRS object of GED to intimate OSPM about an event. Later then demultiplexes > the > notified event by evaluating ACPI _EVT method to know the type of event. Use

Re: [PATCH V15 4/7] hw/acpi: Update GED _EVT method AML with CPU scan

2024-07-15 Thread Igor Mammedov
off-by: Salil Mehta > Reviewed-by: Jonathan Cameron > Reviewed-by: Gavin Shan > Tested-by: Vishnu Pajjuri > Tested-by: Xianglai Li > Tested-by: Miguel Luis > Reviewed-by: Shaoqin Huang > Tested-by: Zhao Liu Reviewed-by: Igor Mammedov > --- > hw/acpi/generic

Re: [PATCH V15 2/7] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-07-15 Thread Igor Mammedov
Reviewed-by: Alex Bennée > Reviewed-by: Jonathan Cameron > Reviewed-by: Gavin Shan > Reviewed-by: David Hildenbrand > Reviewed-by: Shaoqin Huang > Tested-by: Vishnu Pajjuri > Tested-by: Xianglai Li > Tested-by: Miguel Luis > Tested-by: Zhao Liu > Revie

Re: [PATCH V15 1/7] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-15 Thread Igor Mammedov
ishnu Pajjuri > Reviewed-by: Jonathan Cameron > Tested-by: Xianglai Li > Tested-by: Miguel Luis > Reviewed-by: Shaoqin Huang > Reviewed-by: Vishnu Pajjuri > Reviewed-by: Nicholas Piggin > Tested-by: Zhao Liu > Reviewed-by: Zhao Liu > Reviewed-by:

Re: [PATCH v2 0/9] RISC-V: ACPI: Namespace updates

2024-07-15 Thread Igor Mammedov
On Sun, 14 Jul 2024 03:46:36 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 12, 2024 at 03:50:10PM +0200, Igor Mammedov wrote: > > On Fri, 12 Jul 2024 13:51:04 +0100 > > Daniel P. Berrangé wrote: > > > > > On Fri, Jul 12, 2024 at 02:43:19PM +0200, I

[PATCH v2] smbios: make memory device size configurable per Machine

2024-07-15 Thread Igor Mammedov
with help of '-device' option[s] (pcdimm,nvdimm,...) 2) SMBIOS 3.1.0 7.18.5 Memory Device — Extended Size PS: * tested on 8Tb host with RHEL6 guest, which seems to parse type 17 SMBIOS table entries correctly (according to 'dmidecode'). Signed-off-by: Igor Mammedov --- v2:

Re: [PATCH v2 0/9] RISC-V: ACPI: Namespace updates

2024-07-12 Thread Igor Mammedov
On Fri, 12 Jul 2024 13:51:04 +0100 Daniel P. Berrangé wrote: > On Fri, Jul 12, 2024 at 02:43:19PM +0200, Igor Mammedov wrote: > > On Mon, 8 Jul 2024 17:17:32 +0530 > > Sunil V L wrote: > > > > > This series adds few updates to RISC-V ACPI namespace for virt pl

Re: [PATCH v2 0/9] RISC-V: ACPI: Namespace updates

2024-07-12 Thread Igor Mammedov
On Mon, 8 Jul 2024 17:17:32 +0530 Sunil V L wrote: > This series adds few updates to RISC-V ACPI namespace for virt platform. > Additionally, it has patches to enable ACPI table testing for RISC-V. > > 1) PCI Link devices need to be created outside the scope of the PCI root > complex to ensure

Re: [PATCH v2 6/9] tests/qtest/bios-tables-test.c: Remove the fall back path

2024-07-11 Thread Igor Mammedov
path > as well. > > Suggested-by: Igor Mammedov > Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test.c | 14 -- > 1 file changed, 14 deletions(-) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-tes

Re: [PATCH v2 3/9] tests/acpi: Allow DSDT acpi table changes for aarch64

2024-07-11 Thread Igor Mammedov
On Mon, 8 Jul 2024 17:17:35 +0530 Sunil V L wrote: > so that CI tests don't fail when those ACPI tables are updated in the > next patch. This is as per the documentation in bios-tables-tests.c. > > Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov > --- > tests

Re: [PATCH v2 4/9] acpi/gpex: Create PCI link devices outside PCI root bridge

2024-07-11 Thread Igor Mammedov
On Mon, 8 Jul 2024 17:17:36 +0530 Sunil V L wrote: > Currently, PCI link devices (PNP0C0F) are always created within the > scope of the PCI root bridge. However, RISC-V needs these link devices > to be created outside to ensure the probing order in the OS. This > matches the example given in the

Re: [PATCH v2 2/9] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

2024-07-11 Thread Igor Mammedov
On Mon, 8 Jul 2024 17:17:34 +0530 Sunil V L wrote: > The RISC-V BRS specification [1] requires NS16550 compatible UART to > have the HID RSCV0003. So, update the HID for the UART. > > [1] - https://github.com/riscv-non-isa/riscv-brs it point's repo with a bunch of files, please make it easier

Re: [PATCH v2 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

2024-07-11 Thread Igor Mammedov
On Mon, 8 Jul 2024 17:17:33 +0530 Sunil V L wrote: > PLIC and APLIC should be in namespace as well. So, add them using the > defined HID. > > Signed-off-by: Sunil V L > Acked-by: Alistair Francis > --- > hw/riscv/virt-acpi-build.c | 47 ++ > 1 file changed

Re: [PATCH v2 1/9] hw/riscv/virt-acpi-build.c: Add namespace devices for PLIC and APLIC

2024-07-11 Thread Igor Mammedov
On Mon, 8 Jul 2024 17:17:33 +0530 Sunil V L wrote: > PLIC and APLIC should be in namespace as well. So, add them using the > defined HID. defined where? REader shouldn't be forced to go over all web to find source. Cite it here. > > Signed-off-by: Sunil V L > Acked-by: Alistair Francis > --

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 07:13:27 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 11, 2024 at 09:48:22AM +0200, Igor Mammedov wrote: > > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > > which is fine for the most cases (QEMU uses it to describe initial >

Re: [PATCH v4 08/13] hw/i386/acpi: Use TYPE_PXB_BUS property acpi_uid for DSDT

2024-07-11 Thread Igor Mammedov
On Tue, 2 Jul 2024 14:14:13 +0100 Jonathan Cameron wrote: > Rather than relying on PCI internals, use the new acpi_property > to obtain the ACPI _UID values. These are still the same > as the PCI Bus numbers so no functional change. > > Suggested-by: Igor Mammedov > Signe

Re: [PATCH v4 07/13] hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS

2024-07-11 Thread Igor Mammedov
can be made completely independent of PCI internals. > > Suggested-by: Igor Mammedov > Signed-off-by: Jonathan Cameron > > --- > v4: Generalize to all TYPE_PXB_BUS. The handling for primary root > bridges is separate and doesn't overlap with this change. > --- &g

Re: [PATCH v4 05/13] hw/pci: Add a busnr property to pci_props and use for acpi/gi

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 13:53:31 +0200 Igor Mammedov wrote: > On Tue, 2 Jul 2024 14:14:10 +0100 > Jonathan Cameron wrote: > > > Using a property allows us to hide the internal details of the PCI device > > from the code to build a SRAT Generic Initiator Affinity Structur

Re: [PATCH v4 06/13] acpi/pci: Move Generic Initiator object handling into acpi/pci.*

2024-07-11 Thread Igor Mammedov
> hw/acpi/pci.c file and header. If support for ACPI Device Handles is > added in the future, perhaps this will be moved again. > > Also push the struct AcpiGenericInitiator down into the c file as not > used outside pci.c. > > Suggested-by: Igor Mammedov > Signed-off-by

Re: [PATCH v4 05/13] hw/pci: Add a busnr property to pci_props and use for acpi/gi

2024-07-11 Thread Igor Mammedov
On Tue, 2 Jul 2024 14:14:10 +0100 Jonathan Cameron wrote: > Using a property allows us to hide the internal details of the PCI device > from the code to build a SRAT Generic Initiator Affinity Structure with > PCI Device Handle. > > Suggested-by: Igor Mammedov > Signed-off-by

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 09:43:46 +0100 Daniel P. Berrangé wrote: > On Thu, Jul 11, 2024 at 09:48:22AM +0200, Igor Mammedov wrote: > > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > > which is fine for the most cases (QEMU uses it to describe initial > > RAM

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 10:19:27 +0200 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 11/7/24 09:48, Igor Mammedov wrote: > > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > > which is fine for the most cases (QEMU uses it to describe initial > > RAM (t

Re: [PATCH V13 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 03:29:40 + Salil Mehta wrote: > Hi Igor, > > > On 06/07/2024 14:28, Igor Mammedov wrote: > > On Fri, 7 Jun 2024 12:56:45 +0100 > > Salil Mehta wrote: > > > >> OSPM evaluates _EVT method to map the event. The CPU hotplug event &

[PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Igor Mammedov
' guest OS, either by fixing up the next machine type or giving users a CLI option to customize it. 1) SMBIOS 3.1.0 7.18.5 Memory Device — Extended Size PS: * tested on 8Tb host with RHEL6 guest, which seems to parse type 17 SMBIOS table entries correctly (according to 'dmidecode&#

Re: [PATCH V13 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-09 Thread Igor Mammedov
On Mon, 8 Jul 2024 23:30:01 + Salil Mehta wrote: > Hi Igor, > > On 08/07/2024 13:32, Igor Mammedov wrote: > > On Sat, 6 Jul 2024 15:43:01 + > > Salil Mehta wrote: > > > >> Hi Igor, > >> Thanks for taking out time to review. > >

Re: [PATCH V13 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-07-08 Thread Igor Mammedov
On Mon, 8 Jul 2024 05:32:28 + Salil Mehta wrote: > On 06/07/2024 14:45, Igor Mammedov wrote: > > On Fri, 7 Jun 2024 12:56:49 +0100 > > Salil Mehta wrote: > > > >> GED interface is used by many hotplug events like memory hotplug, NVDIMM > >> hotplug

Re: [PATCH V13 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-07-08 Thread Igor Mammedov
On Mon, 8 Jul 2024 05:26:00 + Salil Mehta wrote: > On 06/07/2024 14:35, Igor Mammedov wrote: > > On Fri, 7 Jun 2024 12:56:46 +0100 > > Salil Mehta wrote: > > > >> CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO > >> por

Re: [PATCH V13 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-07-08 Thread Igor Mammedov
On Mon, 8 Jul 2024 05:21:06 + Salil Mehta wrote: > Hi Igor, > > On 06/07/2024 14:28, Igor Mammedov wrote: > > On Fri, 7 Jun 2024 12:56:45 +0100 > > Salil Mehta wrote: > > > >> OSPM evaluates _EVT method to map the event. The CPU hotplug event > >

Re: [PATCH V13 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-07-08 Thread Igor Mammedov
On Mon, 8 Jul 2024 05:12:48 + Salil Mehta wrote: > On 06/07/2024 13:46, Igor Mammedov wrote: > > On Fri, 7 Jun 2024 12:56:44 +0100 > > Salil Mehta wrote: > > > >> ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in > >> the &

Re: [PATCH V13 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-08 Thread Igor Mammedov
On Sat, 6 Jul 2024 15:43:01 + Salil Mehta wrote: > Hi Igor, > Thanks for taking out time to review. > > On Sat, Jul 6, 2024 at 1:12 PM Igor Mammedov wrote: > > > On Fri, 7 Jun 2024 12:56:42 +0100 > > Salil Mehta wrote: > > > > > KVM

Re: [PATCH] i386/cpu: Drop the check of phys_bits in host_cpu_realizefn()

2024-07-06 Thread Igor Mammedov
and can cover all > teh x86 case. Remove the one in host_cpu_realizefn(). > > Signed-off-by: Xiaoyao Li Reviewed-by: Igor Mammedov > --- > target/i386/host-cpu.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/target/i386/h

Re: [PATCH V13 8/8] docs/specs/acpi_hw_reduced_hotplug: Add the CPU Hotplug Event Bit

2024-07-06 Thread Igor Mammedov
On Fri, 7 Jun 2024 12:56:49 +0100 Salil Mehta wrote: > GED interface is used by many hotplug events like memory hotplug, NVDIMM > hotplug > and non-hotplug events like system power down event. Each of these can be > selected using a bit in the 32 bit GED IO interface. A bit has been reserved >

Re: [PATCH V13 7/8] gdbstub: Add helper function to unregister GDB register space

2024-07-06 Thread Igor Mammedov
On Fri, 7 Jun 2024 12:56:48 +0100 Salil Mehta wrote: > Add common function to help unregister the GDB register space. This shall be > done in context to the CPU unrealization. > > Note: These are common functions exported to arch specific code. For example, > for ARM this code is being referred

Re: [PATCH V13 6/8] physmem: Add helper function to destroy CPU AddressSpace

2024-07-06 Thread Igor Mammedov
by: Vishnu Pajjuri > Reviewed-by: Gavin Shan > Tested-by: Xianglai Li > Tested-by: Miguel Luis > Reviewed-by: Shaoqin Huang > Tested-by: Zhao Liu Acked-by: Igor Mammedov > --- > include/exec/cpu-common.h | 8 > include/hw/core/cpu.h

Re: [PATCH V13 5/8] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2024-07-06 Thread Igor Mammedov
On Fri, 7 Jun 2024 12:56:46 +0100 Salil Mehta wrote: > CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port > based and existing CPUs AML code assumes _CRS objects would evaluate to a > system > resource which describes IO Port address. But on ARM arch CPUs control > de

Re: [PATCH V13 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-07-06 Thread Igor Mammedov
On Fri, 7 Jun 2024 12:56:45 +0100 Salil Mehta wrote: > OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually > results in start of the CPU scan. Scan figures out the CPU and the kind of > event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT > metho

Re: [PATCH V13 3/8] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2024-07-06 Thread Igor Mammedov
On Fri, 7 Jun 2024 12:56:44 +0100 Salil Mehta wrote: > ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the > _CRS object of GED to intimate OSPM about an event. Later then demultiplexes > the > notified event by evaluating ACPI _EVT method to know the type of event. Use

Re: [PATCH V13 2/8] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2024-07-06 Thread Igor Mammedov
On Fri, 7 Jun 2024 12:56:43 +0100 Salil Mehta wrote: > CPU ctrl-dev MMIO region length could be used in ACPI GED and various other > architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more > appropriate common header file. > > Signed-off-by: Salil Mehta > Reviewed-by: Alex Ben

Re: [PATCH V13 1/8] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-06 Thread Igor Mammedov
On Fri, 7 Jun 2024 12:56:42 +0100 Salil Mehta wrote: > KVM vCPU creation is done once during the vCPU realization when Qemu vCPU > thread > is spawned. This is common to all the architectures as of now. > > Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the > correspond

Re: [PATCH v4 06/16] tests/qtest/bios-tables-test.c: Add support for arch in path

2024-07-02 Thread Igor Mammedov
thout arch in the path. we probably should remove fallback path lookup after series is merged. it' fine to do it as a follow up patch. > > Signed-off-by: Sunil V L > Acked-by: Alistair Francis > Reviewed-by: Igor Mammedov

Re: [v2 1/1] hw/i386/acpi-build: add OSHP method support for SHPC driver load

2024-07-02 Thread Igor Mammedov
On Mon, 1 Jul 2024 14:27:50 + "Gao,Shiyuan" wrote: > > > > > If I want to use ACPI PCI hotplug in the pxb bridge, what else need > > > > > to be done? > > > > > > > > does it have to be hotplug directly into pxb or > > > > would be it be sufficient to have hotplug support > > > > on pci-br

Re: [PATCH 02/23] target/i386: fix gen_prepare_size_nz condition

2024-07-01 Thread Igor Mammedov
On Fri, 28 Jun 2024 15:34:58 +0100 Alex Bennée wrote: > Alex Bennée writes: > > > Incorrect brace positions causes an unintended overflow on 32 bit > > builds and shenanigans result. > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2413 > > Suggested-by: Mark Cave-Ayland > > Sig

Re: [PATCH v3 08/11] hw/acpi: Generic Port Affinity Structure support

2024-07-01 Thread Igor Mammedov
On Thu, 20 Jun 2024 17:03:16 +0100 Jonathan Cameron wrote: > These are very similar to the recently added Generic Initiators > but instead of representing an initiator of memory traffic they > represent an edge point beyond which may lie either targets or > initiators. Here we add these ports su

Re: [PATCH V12 0/8] Add architecture agnostic code to support vCPU Hotplug

2024-07-01 Thread Igor Mammedov
On Wed, 26 Jun 2024 17:53:52 + Salil Mehta wrote: > Hi Gavin, > > > From: Gavin Shan > > Sent: Wednesday, June 26, 2024 5:13 AM > > To: Salil Mehta ; Igor Mammedov > > > > > > Hi Salil and Igor, > > > > On 6/26/24 9:51 AM

Re: [v2 1/1] hw/i386/acpi-build: add OSHP method support for SHPC driver load

2024-07-01 Thread Igor Mammedov
On Fri, 28 Jun 2024 03:04:28 + "Gao,Shiyuan" wrote: > > > that OS cannot get control of SHPC hotplug and hotplug device to > > > the PCI bridge will fail when we use SHPC Native type: > > > > > >   [3.336059] shpchp :00:03.0: Requesting control of SHPC hotplug via > > >OSHP (\_SB_.PCI0.S

Re: [PATCH v3 05/11] hw/pci: Add a bus property to pci_props and use for acpi/gi

2024-06-28 Thread Igor Mammedov
On Thu, 27 Jun 2024 15:09:12 +0200 Igor Mammedov wrote: > On Thu, 20 Jun 2024 17:03:13 +0100 > Jonathan Cameron wrote: > > > Using a property allows us to hide the internal details of the PCI device > > from the code to build a SRAT Generic Initiator Affinity Structur

Re: [PATCH v3 07/11] hw/pci-bridge: Add acpi_uid property to CXL PXB

2024-06-28 Thread Igor Mammedov
On Thu, 27 Jun 2024 14:46:14 +0100 Jonathan Cameron wrote: > On Thu, 27 Jun 2024 15:27:58 +0200 > Igor Mammedov wrote: > > > On Thu, 20 Jun 2024 17:03:15 +0100 > > Jonathan Cameron wrote: > > > > > This allows the ACPI SRAT Generic Port Affinity Struct

Re: [PATCH v3 1/3] tests/acpi: pc: allow DSDT acpi table changes

2024-06-28 Thread Igor Mammedov
On Fri, 7 Jun 2024 14:17:24 + Ricardo Ribalda wrote: > Signed-off-by: Ricardo Ribalda > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > b/tests/qtest/bios-tables-test-allowed-diff.h >

Re: [PATCH v3 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table

2024-06-28 Thread Igor Mammedov
}, > > Package (0x04) > { > 0x0001, > Zero, > LNKS, > Zero > }, > Context: > https://lore.

Re: [PATCH v3 09/11] bios-tables-test: Allow for new acpihmat-generic-x test data.

2024-06-27 Thread Igor Mammedov
On Thu, 27 Jun 2024 14:51:55 +0200 Igor Mammedov wrote: > On Thu, 20 Jun 2024 17:03:17 +0100 > Jonathan Cameron wrote: > > > The test to be added exercises many corners of the SRAT and HMAT table > did you mean 'corner

Re: [v2 1/1] hw/i386/acpi-build: add OSHP method support for SHPC driver load

2024-06-27 Thread Igor Mammedov
On Tue, 25 Jun 2024 11:52:24 +0800 Shiyuan Gao wrote: > SHPC driver will be loaded fail in i440fx machine, the dmesg shows > that OS cannot get control of SHPC hotplug and hotplug device to > the PCI bridge will fail when we use SHPC Native type: > > [3.336059] shpchp :00:03.0: Requesting

Re: [PATCH v3 07/11] hw/pci-bridge: Add acpi_uid property to CXL PXB

2024-06-27 Thread Igor Mammedov
On Thu, 20 Jun 2024 17:03:15 +0100 Jonathan Cameron wrote: > This allows the ACPI SRAT Generic Port Affinity Structure > creation to be independent of PCI internals. Note that > the UID is currently the PCI bus number. > > Suggested-by: Igor Mammedov > Signed-off-by

Re: [PATCH v3 05/11] hw/pci: Add a bus property to pci_props and use for acpi/gi

2024-06-27 Thread Igor Mammedov
On Thu, 20 Jun 2024 17:03:13 +0100 Jonathan Cameron wrote: > Using a property allows us to hide the internal details of the PCI device > from the code to build a SRAT Generic Initiator Affinity Structure with > PCI Device Handle. > > Suggested-by: Igor Mammedov > Signe

Re: [PATCH v3 04/11] hw/acpi: Rename build_all_acpi_generic_initiators() to build_acpi_generic_initiator()

2024-06-27 Thread Igor Mammedov
On Thu, 20 Jun 2024 17:03:12 +0100 Jonathan Cameron wrote: > Igor noted that this function only builds one instance, so was rather > misleadingly named. Fix that. > > Suggested-by: Igor Mammedov > Signed-off-by: Jonathan Cameron Reviewed-by: Igor Mammedov > >

Re: [PATCH v3 09/11] bios-tables-test: Allow for new acpihmat-generic-x test data.

2024-06-27 Thread Igor Mammedov
On Thu, 20 Jun 2024 17:03:17 +0100 Jonathan Cameron wrote: > The test to be added exercises many corners of the SRAT and HMAT table did you mean 'corner cases"? > generation. > > Signed-off-by: Jonathan Cameron > --- > v3: No change > --- > tests/qtes

Re: [PATCH v3 03/11] hw/acpi: Move AML building code for Generic Initiators to aml_build.c

2024-06-27 Thread Igor Mammedov
On Thu, 27 Jun 2024 08:44:14 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jun 27, 2024 at 02:42:44PM +0200, Igor Mammedov wrote: > > On Thu, 20 Jun 2024 17:03:11 +0100 > > Jonathan Cameron wrote: > > > > > Rather than attempting to create

Re: [PATCH v3 01/11] hw/acpi: Fix ordering of BDF in Generic Initiator PCI Device Handle.

2024-06-27 Thread Igor Mammedov
us and devfn and write them as single bytes in the correct > order. > > [1] ACPI Spec 6.3, Table 5.80 > > Fixes: 0a5b5acdf2d8 ("hw/acpi: Implement the SRAT GI affinity structure") > Signed-off-by: Jonathan Cameron Reviewed-by: Igor Mammedov > > --- > v3: Ne

Re: [PATCH v3 02/11] hw/acpi/GI: Fix trivial parameter alignment issue.

2024-06-27 Thread Igor Mammedov
On Thu, 20 Jun 2024 17:03:10 +0100 Jonathan Cameron wrote: > Before making additional modification, tidy up this misleading indentation. > > Reviewed-by: Ankit Agrawal > Signed-off-by: Jonathan Cameron Reviewed-by: Igor Mammedov > --- > v3: Unchange

Re: [PATCH v3 03/11] hw/acpi: Move AML building code for Generic Initiators to aml_build.c

2024-06-27 Thread Igor Mammedov
with little duplicated code. > > Drop the PCIDeviceHandle in favor of just passing the bus, devfn > and segment directly. devfn kept as a single byte because ARI means > that in cases this is just an 8 bit function number. > > Suggested-by: Igor Mammedov > Link: >

Re: [PATCH v4 16/16] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

2024-06-27 Thread Igor Mammedov
These are all new files being added for the first time. Hence, iASL diff > output is not added. > > Signed-off-by: Sunil V L > Acked-by: Alistair Francis > Acked-by: Igor Mammedov Michael, can it go via risc-v tree or do you plan to merge it via your tree? > --- > tests/data

Re: [PATCH v3 14/15] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

2024-06-25 Thread Igor Mammedov
On Tue, 25 Jun 2024 17:59:33 +0530 Sunil V L wrote: > On Tue, Jun 25, 2024 at 02:05:58PM +0200, Igor Mammedov wrote: > > On Tue, 25 Jun 2024 13:19:59 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 21 Jun 2024 17:29:05 +0530 > > > Sunil V L wrote: >

Re: [PATCH v3 14/15] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

2024-06-25 Thread Igor Mammedov
On Tue, 25 Jun 2024 13:19:59 +0200 Igor Mammedov wrote: > On Fri, 21 Jun 2024 17:29:05 +0530 > Sunil V L wrote: > > > Add basic ACPI table test case for RISC-V. > > > > Signed-off-by: Sunil V L > > Reviewed-by: Alistair Francis > > Reviewed-by:

Re: [PATCH v3 14/15] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

2024-06-25 Thread Igor Mammedov
On Fri, 21 Jun 2024 17:29:05 +0530 Sunil V L wrote: > Add basic ACPI table test case for RISC-V. > > Signed-off-by: Sunil V L > Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test.c | 26 ++ > 1 file c

Re: [PATCH v3 08/15] tests/data/acpi: Move x86 ACPI tables under x86/${machine} path

2024-06-25 Thread Igor Mammedov
On Fri, 21 Jun 2024 17:28:59 +0530 Sunil V L wrote: > To support multiple architectures using same machine name, create x86 > folder and move all x86 related AML files for each machine type inside. > > Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov > --- > tests/

Re: [PATCH v3 09/15] tests/data/acpi/virt: Move ARM64 ACPI tables under aarch64/${machine} path

2024-06-25 Thread Igor Mammedov
On Fri, 21 Jun 2024 17:29:00 +0530 Sunil V L wrote: > Same machine name can be used by different architectures. Hence, create > aarch64 folder and move all aarch64 related AML files for virt machine > inside. > > Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov > ---

Re: [PATCH v3 07/15] tests/qtest/bios-tables-test.c: Set "arch" for x86 tests

2024-06-25 Thread Igor Mammedov
On Fri, 21 Jun 2024 17:28:58 +0530 Sunil V L wrote: > To search for expected AML files under ${arch}/${machine} path, set this > field for X86 related test cases. > > Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-

Re: [PATCH v3 06/15] tests/qtest/bios-tables-test.c: Set "arch" for aarch64 tests

2024-06-25 Thread Igor Mammedov
On Fri, 21 Jun 2024 17:28:57 +0530 Sunil V L wrote: > To search for expected AML files under ${arch}/${machine} path, set this > field for AARCH64 related test cases. > > Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test.c | 8

Re: [PATCH v3 05/15] tests/qtest/bios-tables-test.c: Add support for arch in path

2024-06-25 Thread Igor Mammedov
thout arch in the path. > > Signed-off-by: Sunil V L Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test.c | 23 --- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-t

Re: [PATCH v3 02/15] uefi-test-tools: Add support for python based build script

2024-06-25 Thread Igor Mammedov
t; required to support the python based build script. > > Signed-off-by: Sunil V L Acked-by: Igor Mammedov > --- > tests/uefi-test-tools/Makefile | 19 +++ > tests/uefi-test-tools/uefi-test-build.config | 52 > 2 files changed, 59 inser

Re: [PATCH v3 01/15] uefi-test-tools/UefiTestToolsPkg: Add RISC-V support

2024-06-25 Thread Igor Mammedov
On Fri, 21 Jun 2024 17:28:52 +0530 Sunil V L wrote: > Enable building the test application for RISC-V with appropriate > dependencies updated. > > Signed-off-by: Sunil V L > Acked-by: Gerd Hoffmann > Acked-by: Alistair Francis Acked-by: Igor Mammedov > --- >

Re: [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64

2024-06-20 Thread Igor Mammedov
On Wed, 19 Jun 2024 23:30:35 +0530 Sunil V L wrote: > On Wed, Jun 19, 2024 at 05:20:50AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jun 19, 2024 at 11:17:43AM +0200, Igor Mammedov wrote: > > > On Mon, 27 May 2024 20:46:29 +0530 > > > Sunil V L wrote: > > >

Re: [PATCH v2 12/12] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V

2024-06-19 Thread Igor Mammedov
These are all new files being added for the first time. Hence, iASL diff > output is not added. > > Signed-off-by: Sunil V L Acked-by: Igor Mammedov > --- > tests/data/acpi/virt/riscv64/APIC | Bin 0 -> 116 bytes > tests/data/acpi/virt/riscv64/DSDT | Bin

Re: [PATCH v2 11/12] tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V

2024-06-19 Thread Igor Mammedov
On Fri, 24 May 2024 11:44:10 +0530 Sunil V L wrote: > Add basic ACPI table test case for RISC-V. > > Signed-off-by: Sunil V L > --- > tests/qtest/bios-tables-test.c | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qte

Re: [PATCH v2 10/12] tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V

2024-06-19 Thread Igor Mammedov
On Fri, 24 May 2024 11:44:09 +0530 Sunil V L wrote: > As per process documented (steps 1-3) in bios-tables-test.c, add empty > AML data files for RISC-V ACPI tables and add the entries in > bios-tables-test-allowed-diff.h. > > Signed-off-by: Sunil V L Reviewed-by

Re: [PATCH v2 09/12] tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V

2024-06-19 Thread Igor Mammedov
On Fri, 24 May 2024 11:44:08 +0530 Sunil V L wrote: > Update the list of supported architectures to include RISC-V. > > Signed-off-by: Sunil V L > Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov > --- > tests/data/acpi/rebuild-expected-aml.sh | 5 +++-- &g

Re: [PATCH v2 08/12] pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs

2024-06-19 Thread Igor Mammedov
On Fri, 24 May 2024 11:44:07 +0530 Sunil V L wrote: > Update list of images supported in unpack_edk2_blobs to enable RISC-V > ACPI table testing. > > Signed-off-by: Sunil V L > Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov > --- > pc-bios/meson.build

Re: [PATCH v2 05/12] tests/qtest/bios-tables-test.c: Add support for arch in path

2024-06-19 Thread Igor Mammedov
On Fri, 24 May 2024 11:44:04 +0530 Sunil V L wrote: > Since virt machine is common for multiple architectures, add "arch" in > the path to search expected AML files. Since the AML files are still > under old path, support both by searching with and without arch in the > path. > > Signed-off-by:

Re: [PATCH v2 07/12] meson.build: Add RISC-V to the edk2-target list

2024-06-19 Thread Igor Mammedov
On Fri, 24 May 2024 11:44:06 +0530 Sunil V L wrote: > so that ACPI table test can be supported. > > Signed-off-by: Sunil V L > Reviewed-by: Alistair Francis Reviewed-by: Igor Mammedov > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > &g

Re: [PATCH v2 06/12] tests/data/acpi/virt: Move ACPI tables under aarch64

2024-06-19 Thread Igor Mammedov
On Mon, 27 May 2024 20:46:29 +0530 Sunil V L wrote: > On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > > Hi Sunil, > > > > On 24/5/24 08:14, Sunil V L wrote: > > > Since virt is a common machine name across architectures like ARM64 and > > > RISC-V, move existing ARM64

Re: [PATCH v2 04/12] qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them

2024-06-18 Thread Igor Mammedov
iewed-by: Alistair Francis Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test.c | 35 ++ > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index d1ff4db

Re: [PATCH qemu ] hw/acpi: Fix big endian host creation of Generic Port Affinity Structures

2024-06-18 Thread Igor Mammedov
On Mon, 17 Jun 2024 13:05:15 +0100 Jonathan Cameron wrote: > On Fri, 14 Jun 2024 15:08:35 +0100 > Jonathan Cameron wrote: > > > On Fri, 14 Jun 2024 12:57:25 +0200 > > Igor Mammedov wrote: > > > > > On Thu, 6 Jun 2024 18:47:16 +0100 > > > Jonat

Re: [PATCH v6 23/23] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

2024-06-17 Thread Igor Mammedov
; > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Thomas Huth > Reviewed-by: Zhao Liu Reviewed-by: Igor Mammedov > --- > include/hw/i386/pc.h | 4 > hw/i386/pc.c | 19 --- > 2 files changed, 12 insertions(+), 11 deletions(-) >

Re: [PATCH v6 22/23] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-06-17 Thread Igor Mammedov
Liu > Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov > --- > target/i386/cpu.h | 3 --- > target/i386/cpu.c | 2 -- > target/i386/kvm/kvm.c | 7 +-- > 3 files changed, 1 insertion(+), 11 deletions(-) > > diff --git a/target/i386/cpu.h b/target/i386/c

Re: [PATCH v6 21/23] hw/i386/pc: Simplify DEFINE_I440FX_MACHINE() macro

2024-06-17 Thread Igor Mammedov
gt; Reviewed-by: Thomas Huth > Reviewed-by: Zhao Liu > Reviewed-by: Daniel P. Berrangé Reviewed-by: Igor Mammedov > --- > hw/i386/pc_piix.c | 69 --- > 1 file changed, 29 insertions(+), 40 deletions(-) > > diff --git a/hw/i386

<    1   2   3   4   5   6   7   8   9   10   >