-by: Igor Mitsyanko i.mitsya...@gmail.com i.mitsya...@gmail.com
--
Best wishes,
Igor Mitsyanko
email: i.mitsya...@gmail.com
|= SDHC_NIS_WBUFRDY;
}
/* Generate Block Gap Event if requested and if not the last block */
Reviewed-by: Igor Mitsyanko i.mitsya...@gmail.com i.mitsya...@gmail.com
--
Best wishes,
Igor Mitsyanko
email: i.mitsya...@gmail.com
. */
if (req.arg)
sd-state = sd_ready_state;
I couldn't find any info in SD specification that would confirm this change
correctness, what about
table Table 4-29: Card State Transition Table which states that ACMD41 is
illegal in ready state?
--
Best wishes,
Igor Mitsyanko
email: i.mitsya
);
-DPRINT_L2(read %ub: addr[0x%04x] - %u\n, size, offset, ret);
+DPRINT_L2(read %ub: addr[0x%04x] - %u(0x%x)\n, size, offset,
+ ret, ret);
return ret;
}
break;
Reviewed-by: Igor Mitsyanko i.mitsya...@gmail.com i.mitsya...@gmail.com
);
-if (s-norintstsen SDHC_NISEN_DMA) {
-s-norintsts |= SDHC_NIS_DMA;
-}
-
-sdhci_update_irq(s);
-return;
-}
}
/* we have unfinished business - reschedule to continue ADMA */
Reviewed-by: Igor Mitsyanko i.mitsya...@gmail.com
On 05/23/2013 03:42 AM, Peter Crosthwaite wrote:
Hi Igor,
On Wed, May 22, 2013 at 11:37 PM, Igor Mitsyanko i.mitsya...@gmail.com
wrote:
On 05/21/2013 10:50 AM, peter.crosthwa...@xilinx.com wrote:
From: Peter Crosthwaite peter.crosthwa...@xilinx.com
the SD command ACMD41 can be used
).
+ */
+if (req.arg ACMD41_ENQUIRY_MASK) {
sd-state = sd_ready_state;
+}
return sd_r3;
Reviewed-by: Igor Mitsyanko i.mitsya...@gmail.com
--
Best wishes,
Igor Mitsyanko
email: i.mitsya...@gmail.com
My email address in samsung.com domain is no longer accessible, change
it to my personal gmail address.
Signed-off-by: Igor Mitsyanko i.mitsya...@gmail.com
---
Currently I can't send patches properly with send-email command, I can only
use gmail web interface for this. I'm not sure that it would
On 01/06/2012 12:02 AM, Mark Langsdorf wrote:
Hello, Mark. According to technical specification on Calxeda website,
highbank SoC has SD 3.0 host controller, are you planning to implement
it in qemu? I'm asking because I recently have submitted a patch
implementing SD 2.0 host controller, and
On 01/06/2012 10:45 PM, Peter Maydell wrote:
On 6 January 2012 18:37, Igor Mitsyankoi.mitsya...@gmail.com wrote:
On 01/06/2012 12:02 AM, Mark Langsdorf wrote:
+if (!cpu_model) {
+cpu_model = cortex-a9;
+}
Google said there is only cortexA9-based Highbank SoC version, maybe
On 06.01.2012 11:11 PM, Andreas Färber wrote:
Am 06.01.2012 20:10, schrieb Igor Mitsyanko:
On 01/06/2012 10:45 PM, Peter Maydell wrote:
On 6 January 2012 18:37, Igor Mitsyankoi.mitsya...@gmail.com wrote:
On 01/06/2012 12:02 AM, Mark Langsdorf wrote:
+if (!cpu_model
A straightforward conversion of SD card implementation to a proper QEMU object.
Wrapper functions were introduced for SDClass methods in order to avoid SD card
users modification. Because of this, name change for several functions in
hw/sd.c
was required.
Signed-off-by: Igor Mitsyanko i.mitsya
Public bug reported:
After running make clean qemu won't build with -j option.
When I run ./configure make clean and then make -j5, following errors
occur:
GEN config-host.h
GEN trace.h
GEN qemu-options.def
GEN qmp-commands.h
GEN qapi-types.h
GEN qapi-visit.h
GEN
For the sake of code clarity
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
---
hw/sd.c |2 +-
hw/sd.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index d4a8927..a51d18d 100644
--- a/hw
And drop passing is_spi argument to SDCardClass::init function.
spi property could be set only while SD card object is not
attached to any BlockDriverState.
It defaults to false.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
Cc: Paul Brook p...@codesourcery.com
---
hw/sd.c | 33
This patch updates SD card model to support save/load of card's state.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 88 +-
1 files changed, 64 insertions(+), 24 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index
Add wrapper function sd_addr_to_wpnum() to replace long address--wg_group
conversion line.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 27 +--
1 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index e24d04a
Rather that repeatedly call SD_GET_CLASS() in a loop, call it once before
a loop starts.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/omap_mmc.c|9 +
hw/pl181.c |7 ---
hw/pxa2xx_mmci.c |6 --
3 files changed, 13 insertions(+), 9 deletions
Representing each group write protection flag with only one bit instead of int
variable significantly reduces memory consumption.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 33 +++--
1 files changed, 19 insertions(+), 14 deletions(-)
diff
For the sake of code clarity
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index a51d18d..20ebd8e 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -544,7 +544,7 @@ static void sd_function_switch
variable introduced in
SDState
to hold size of wp_groups array.
PATCH6 converts SD state to QOM object. QOMified implementation doesn't have any
advantages over current one but it gives us enormous possibilities for further
improvements.
Igor Mitsyanko (12):
hw/sd.c: convert wp_groups in SDState
Setting drive SD card property ties SD card with BlockDriverState of the
same name. This property can be set dynamically, allowing for SD card
hot-insert.
With drive property we no longer need SDClass::init method, all work is
done in property setter.
Signed-off-by: Igor Mitsyanko i.mitsya
Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards use
block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32
and CMD33, we have to account for this.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c |6 --
1 files
Several members of SDState have type int when they actually are binary
variables.
Change type of these variables to bool to improve code readability. Change SD
API
to be in consistency with new variables type.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
Reviewed-by: Peter Maydell
Currently sd_wp_addr() accepts 32 bit address arguments therefore implicitly
restricting SD card address range. Change address argument type to uint64_t.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw
On 07/31/2012 01:29 PM, Markus Armbruster wrote:
Igor Mitsyanko i.mitsya...@samsung.com writes:
Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards use
block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32
and CMD33, we have to account
On 07/31/2012 01:33 PM, Markus Armbruster wrote:
Igor Mitsyanko i.mitsya...@samsung.com writes:
This patch updates SD card model to support save/load of card's state.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 88
On 07/31/2012 01:45 PM, Markus Armbruster wrote:
Igor Mitsyanko i.mitsya...@samsung.com writes:
A straightforward conversion of SD card implementation to a proper QEMU object.
Wrapper functions were introduced for SDClass methods in order to avoid SD card
users modification. Because
On 07/31/2012 06:34 PM, Peter Maydell wrote:
On 27 July 2012 20:29, Igor Mitsyanko i.mitsya...@samsung.com wrote:
Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards use
block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32
and CMD33, we have
On 07/31/2012 08:17 PM, Peter Maydell wrote:
On 31 July 2012 16:29, Markus Armbruster arm...@redhat.com wrote:
Igor Mitsyanko i.mitsya...@samsung.com writes:
QEMU requires all objects derived from TYPE_DEVICE to be connected to
some bus, if no bus was specified in new object class description
On 07/31/2012 07:43 PM, Peter Maydell wrote:
On 27 July 2012 20:29, Igor Mitsyanko i.mitsya...@samsung.com wrote:
Rather that repeatedly call SD_GET_CLASS() in a loop, call it once before
a loop starts.
Anthony claims that SD_GET_CLASS should be cheap enough that we don't
need to hoist it out
On 07/31/2012 09:47 PM, Peter Maydell wrote:
On 31 July 2012 18:33, Igor Mitsyanko i.mitsya...@samsung.com wrote:
On 07/31/2012 07:43 PM, Peter Maydell wrote:
Anthony claims that SD_GET_CLASS should be cheap enough that we don't
need to hoist it out of loops like this. Do you have profiling
On 07/31/2012 06:56 PM, Peter Maydell wrote:
On 27 July 2012 20:29, Igor Mitsyanko i.mitsya...@samsung.com wrote:
+VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0, wpgrps_size,
+sizeof(unsigned long)),
Isn't this trying to use wpgrps_size as the number
On 07/31/2012 10:15 PM, Anthony Liguori wrote:
How many loop iterations that? 300us is a huge amount of time, unless
you were looping on every byte, I have a hard time understanding that
delta.
I'm not sure I understand what you mean, I did loop on every byte,
that's how our SD model works.
On 07/31/2012 02:20 PM, Peter Crosthwaite wrote:
Hi All,
A lot of devices have little internal fifos that are often implemented
as circular buffers in the device state. Any reason to not factor that
out into a helper module? Was thinkin just a struct defintion
containing the key elements (the
On 08/06/2012 06:16 AM, Peter A. G. Crosthwaite wrote:
Added a FIFO API that can be used to create and operate byte FIFOs.
Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
---
hw/Makefile.objs |1 +
hw/fifo.c| 79
On 08/06/2012 06:16 AM, Peter A. G. Crosthwaite wrote:
Added a FIFO API that can be used to create and operate byte FIFOs.
Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
---
hw/Makefile.objs |1 +
hw/fifo.c| 79
On 08/06/2012 02:30 PM, Peter Maydell wrote:
On 6 August 2012 04:25, Peter A. G. Crosthwaite
peter.crosthwa...@petalogix.com wrote:
+static void sdhci_sdma_transfer_multi_blocks(SDHCIState *s)
+{
+bool page_aligned = false;
+unsigned int n, begin;
+const uint16_t block_size =
On 08/06/2012 03:15 PM, Peter Maydell wrote:
On 6 August 2012 04:25, Peter A. G. Crosthwaite
peter.crosthwa...@petalogix.com wrote:
From: Igor Mitsyanko i.mitsya...@samsung.com
Device model for standard SD Host Controller Interface (SDHCI) compliant with
version 2.00 of SD association
On 08/06/2012 02:56 PM, Peter Maydell wrote:
On 6 August 2012 04:25, Peter A. G. Crosthwaite
peter.crosthwa...@petalogix.com wrote:
+static uint64_t
+exynos4210_sdhci_readfn(void *opaque, target_phys_addr_t offset, unsigned size)
+{
+Exynos4SDHCIState *s = (Exynos4SDHCIState *)opaque;
+
Recently I've noticed that drive_get_next() usage is not very convenient
if you want to use specific SD controller interface. Maybe we should
switch from drive_get_next() to DEFINE_PROP_DRIVE()? It'll still
preserve -sd .. behaviour. What do you think Peter?
On 08/06/2012 01:48 PM, Peter Maydell wrote:
On 6 August 2012 03:16, Peter A. G. Crosthwaite
peter.crosthwa...@petalogix.com wrote:
Added a FIFO API that can be used to create and operate byte FIFOs.
I'm not asking for actual conversions, but it would be nice to see a
list of some devices that
On 08/07/2012 10:10 AM, Peter Crosthwaite wrote:
+
+extern const VMStateDescription vmstate_fifo8;
+
+#define VMSTATE_FIFO8(_field, _state) { \
+.name = (stringify(_field)), \
+.size = sizeof(Fifo8),
On 08/08/2012 08:25 PM, Andreas Färber wrote:
Am 31.01.2012 15:01, schrieb Mitsyanko Igor:
On 01/31/2012 05:15 PM, Andreas Färber wrote:
Am 31.01.2012 00:53, schrieb Anthony Liguori:
On 01/30/2012 05:41 PM, Andreas Färber wrote:
Am 30.01.2012 19:55, schrieb Juan Quintela:
Please send in any
and value in ram_list.dirty_pages variable, which in turn could (and will)
result
in errors during VM migration.
Zero initialize new dirty bitmap bytes to fix this problem.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
exec.c |2 ++
1 files changed, 2 insertions(+), 0 deletions
migration since I don't have a bigendian machine
at my disposal.
Tested-by: Igor Mitsyanko i.mitsya...@samsung.com
On 08/10/2012 07:06 PM, Peter Maydell wrote:
On 27 July 2012 20:29, Igor Mitsyanko i.mitsya...@samsung.com wrote:
Igor Mitsyanko (12):
hw/sd.c: convert wp_groups in SDState to bitfield
hw/sd.c: make sd_wp_addr() accept 64 bit address argument
hw/sd.c: introduce wrapper for conversion
On 08/10/2012 08:30 PM, Peter Maydell wrote:
On 10 August 2012 17:22, Igor Mitsyanko i.mitsya...@samsung.com wrote:
On 08/09/2012 03:54 PM, Peter Maydell wrote:
--- a/vmstate.h
+++ b/vmstate.h
@@ -139,6 +139,7 @@ extern const VMStateInfo vmstate_info_uint64;
extern const VMStateInfo
..
Igor Mitsyanko (3):
exynos4210: drop All rights reserved line from files license
exynos4210.c: register chipid_mem and rom_mem with vmstate
hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE
hw/exynos4210.c |6 --
hw/exynos4210.h |2 +-
hw
, specifically, it could cause segfault during VM saving.
Setting chipid_and_omr aray size to TARGET_PAGE_SIZE helps us to avoid any
problems.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/exynos4210.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw
for migration to avoid this problem.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/exynos4210.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/exynos4210.c b/hw/exynos4210.c
index a3a06f7..94d2e41 100644
--- a/hw/exynos4210.c
+++ b/hw/exynos4210.c
It has been noted that All rights reserved statement conflicts with GPL,
remove it.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/exynos4210.c |2 +-
hw/exynos4210.h |2 +-
hw/exynos4210_combiner.c |3 +--
hw/exynos4210_fimd.c |3 +--
hw
On 08/10/2012 08:21 PM, Peter Maydell wrote:
Last call for any ARM related patches to go into 1.2. My current
queue looks like this:
59cbd70 hw/sd.c: make sd_wp_addr() return bool
8b4cc14 hw/sd.c: make sd_dataready() return bool
025caa6 hw/sd.c: convert binary variables to bool
38d24e6 hw/sd.c:
On 06/28/2012 11:22 PM, Juan Quintela wrote:
Notice that the live migration users never unregister, so no problem
about freeing the ops structure.
Signed-off-by: Juan Quintela quint...@redhat.com
---
arch_init.c |9 +++--
block-migration.c | 10 --
migration.h
.
Igor Mitsyanko (2):
hw: introduce standard SD host controller
sdhci.h:
s/sdhc_not_stoped/sdhc_not_stopped/
s/stoped_state/stopped_state/
Interrupt handling code looks a little suspicious -- is s-slotint
supposed to track the state of the outgoing interrupt line or is
it distinct state
On 06/29/2012 07:01 PM, Peter Maydell wrote:
On 29 June 2012 15:52, Igor Mitsyanko i.mitsya...@samsung.com wrote:
On 06/29/2012 02:59 PM, Peter Maydell wrote:
The irq code looks dubious: we seem to have a single output
irq, but the code does things like:
qemu_set_irq(sdhci-irq, sdhci
On 6/28/2012 11:22 PM, Juan Quintela wrote:
Enable the creation of a method to tell migration if that section is
active and should be migrate. We use it for blk-migration, that is
normally not active. We don't create the method for RAM, as setups
without RAM are very strange O:-)
On 6/28/2012 11:22 PM, Juan Quintela wrote:
We only need to synchronize the bitmap when the number of dirty pages is low.
Not every time that we call the function.
Signed-off-by: Juan Quintela quint...@redhat.com
---
arch_init.c |9 ++---
1 file changed, 6 insertions(+), 3
*/
{ .name = NOP, .cp = 15, .crn = 7, .crm = 0, .opc1 = 0, .opc2 = 4,
just like it named in architecture reference manual
Reviewed-by: Igor Mitsyanko i.mitsya...@samsung.com
On 07/01/2012 07:26 PM, Paolo Bonzini wrote:
Il 29/06/2012 14:26, Andreas Färber ha scritto:
Oh, I see. Should we place this device to hw/Makefile.objs in v2?
That would've been nice, but I'll do it as a follow-up now.
Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introducing
On 07/02/2012 03:44 PM, Andreas Färber wrote:
Am 01.07.2012 17:26, schrieb Paolo Bonzini:
Il 29/06/2012 14:26, Andreas Färber ha scritto:
Oh, I see. Should we place this device to hw/Makefile.objs in v2?
That would've been nice, but I'll do it as a follow-up now.
Yes, so we can also use
On 07/05/2012 08:44 AM, Peter Crosthwaite wrote:
On Tue, Jul 3, 2012 at 9:30 PM, Igor Mitsyanko i.mitsya...@samsung.com wrote:
Hi Peter, here's a few review comments for your patch
On 06/18/2012 04:42 AM, Peter A. G. Crosthwaite wrote:
Device model for Primecell PL330 dma controller.
Signed
On 07/16/2012 09:13 PM, Peter Maydell wrote:
On 5 July 2012 05:04, Peter A. G. Crosthwaite
peter.crosthwa...@petalogix.com wrote:
From: Igor Mitsyanko i.mitsya...@samsung.com
Custom Exynos4210 SD/MMC host controller, based on SD association standard host
controller ver. 2.00.
Signed-off
On 07/17/2012 05:37 PM, Peter Maydell wrote:
On 17 July 2012 13:55, Igor Mitsyanko i.mitsya...@samsung.com wrote:
On 07/16/2012 09:13 PM, Peter Maydell wrote:
The IRQ handling code still looks really weird. I would expect
that the code would be:
[code which updates various kinds of irq
, in alsa test
failing.
This means that QEMU won't configure with --audio-drv-list=alsa.
Initialize handle variable to fix compilation warning.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
configure |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b
I see now that this bug was already noticed, please ignore this mail
On 07/17/2012 09:34 PM, Igor Mitsyanko wrote:
After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are
executed with -Werror flag. Current ALSA configure test program invokes a
warning:
warning: ‘handle
Create 9 exynos4210 i2c interfaces.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
Reviewed-by: Andreas Färber afaer...@suse.de
---
Previous versions of this patch were sent to mailing list within a Exynos:
i2c, gpio and
touchscreen support for NURI board patchset some time ago. V4
On 07/19/2012 01:16 PM, jagan wrote:
Yes, I have used same drive_get(IF_PFLASH, 0, 0) with two flashes.
As these flashes are two different banks with individual bases address,
I used the same.
Was there any block allocation problem with this..will you please elaborate.
I couldn't understand
On 07/20/2012 05:30 PM, jagan wrote:
I think I understand the situation, like when I called
pflash_cfi01_register, it verifies BlockDriverState is 0.
Was my understanding correct?
If ie so. I think I need to change drive_get(IF_PFLASH, 0, 0) to
drive_get_next(IF_PFLASH) on second flash
(this is why parallel build works fine after ./configure if you
havn't run make clean).
Another reason to apply this fix is that CFLAGS are more related to object
files (meaning
$(qga-obj-y)) then to executable file qemu-ga$(EXESUF).
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
Makefile |2
On 13.03.2012 3:13 PM, Andreas Färber wrote:
In SysBusDeviceClass etc. we use the specific object type, too.
Obviously my CPU is the first new QOM type, so we can go different
ways if we want to. As long as it's a CPU-specific mechanism, using the
specific type avoids some casts.
It will be
definitions;
- Weird big spaces after .field members of VMStateDescriptions are replaced
with single space;
- maxtouch.c is not ARM target specific from now on.
Igor Mitsyanko (3):
exynos4210: add Exynos4210 i2c implementation
exynos4210: add exynos4210 GPIO implementation
hw: add Atmel
Create 9 exynos4210 i2c interfaces.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
Makefile.target |1 +
hw/exynos4210.c | 26 +++
hw/exynos4210.h |3 +
hw/exynos4210_i2c.c | 469 +++
4 files changed, 499
And use it for exynos4210 NURI board emulation
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
Makefile.objs |1 +
default-configs/arm-softmmu.mak |1 +
hw/exynos4_boards.c | 11 +-
hw/maxtouch.c | 1079
Now that we have GPIO emulation for exynos4210 SoC we can use it to
properly hook up IRQ line to lan9215 controller on SMDK board.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
Makefile.target |2 +-
hw/exynos4210.c | 46 ++
hw/exynos4210.h | 64 +++
hw
On 03/15/2012 01:48 PM, Andreas Färber wrote:
Am 15.03.2012 08:35, schrieb Igor Mitsyanko:
And use it for exynos4210 NURI board emulation
Signed-off-by: Igor Mitsyankoi.mitsya...@samsung.com
Thanks for moving this to libhw. Looks okay, not knowing I2C or the
device and assuming you've
On 03/20/2012 05:27 PM, Peter Maydell wrote:
On 15 March 2012 07:35, Igor Mitsyankoi.mitsya...@samsung.com wrote:
Now that we have GPIO emulation for exynos4210 SoC we can use it to
properly hook up IRQ line to lan9215 controller on SMDK board.
+#elif EXYNOS4210_GPIO_DEBUG == 1
+#define
On 03/21/2012 03:55 PM, Peter Maydell wrote:
On 15 March 2012 07:35, Igor Mitsyankoi.mitsya...@samsung.com wrote:
Create 9 exynos4210 i2c interfaces.
Signed-off-by: Igor Mitsyankoi.mitsya...@samsung.com
Mostly this looks OK but I still find the i2c slave stuff
odd -- should the controller
On 03/21/2012 05:09 PM, Peter Maydell wrote:
On 21 March 2012 13:07, Igor Mitsyankoi.mitsya...@samsung.com wrote:
On 03/21/2012 03:55 PM, Peter Maydell wrote:
I suspect that what's happening here is that the hardware
lets you put the i2c controller into slave mode so some
other device on the
On 20.03.2012 1:57 AM, Juan Quintela wrote:
This allows to sent a partial array where the size is another
structure field multiplied by a constant.
Signed-off-by: Juan Quintelaquint...@redhat.com
---
savevm.c |6 ++
vmstate.h | 35 +++
2 files
On 20.03.2012 1:57 AM, Juan Quintela wrote:
We have an array of structs whose size is an int32 in the same struct that
depends on a test value to know if it is there or not.
Signed-off-by: Juan Quintelaquint...@redhat.com
---
vmstate.h | 10 ++
1 files changed, 10 insertions(+), 0
On 04/02/2012 12:00 PM, Andreas Färber wrote:
Am 02.04.2012 09:20, schrieb Peter Maydell:
On 2 April 2012 07:24, Peter A. G. Crosthwaite
peter.crosthwa...@petalogix.com wrote:
device more for standard SD host controller interface (SDHCI).
Signed-off-by: Peter A. G.
On 04/02/2012 03:05 PM, Peter Crosthwaite wrote:
On Mon, Apr 2, 2012 at 6:38 PM, Igor Mitsyankoi.mitsya...@samsung.com wrote:
On 04/02/2012 12:00 PM, Andreas Färber wrote:
Am 02.04.2012 09:20, schrieb Peter Maydell:
On 2 April 2012 07:24, Peter A. G. Crosthwaite
On 04/02/2012 05:46 PM, Peter Maydell wrote:
On 2 April 2012 09:38, Igor Mitsyankoi.mitsya...@samsung.com wrote:
It looks like this sdhc implements version 1 of standard SDHC specification,
while ours implements second version. Second version should be backwards
compatible with first, I
On 04/02/2012 05:47 PM, Peter Crosthwaite wrote:
Yes, I've been trying to get my sdhc accepted since last year :) I tried to
comply with specification entirely, your implementation is obviously much
smaller but enough for use with Linux driver (i've tested it with exynos
board emulation).
For the sake of code clarity
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c |2 +-
hw/sd.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index 4c29907..338c125 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -1707,7 +1707,7 @@ uint8_t
Several members of SDState have type int when they actually are binary
variables.
Change type of these variables to bool to improve code readability. Change SD
API
to be in consistency with new variables type.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 24
to QOM object. QOMified implementation doesn't have any
advantages over current one but it gives us enormous possibilities for further
improvements.
Igor Mitsyanko (6):
hw/sd.c: convert wp_groups in SDState to bitfield
hw/sd.c: convert binary variables to bool
hw/sd.c: make sd_dataready() return
Representing each group write protection flag with only one bit instead of int
variable significantly reduces memory consumption.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 36 ++--
1 files changed, 22 insertions(+), 14 deletions
A straightforward conversion of SD card implementation to a proper QEMU object.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/milkymist-memcard.c | 25 +++--
hw/omap_mmc.c | 29 +
hw/pl181.c | 14
This patch updates SD card emulation to support save/load of card's state.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 90 --
1 files changed, 64 insertions(+), 26 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
For the sake of code clarity
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index 338c125..63e458f 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -539,11 +539,11 @@ static void
On 02.04.2012 5:42 PM, Peter Maydell wrote:
On 2 April 2012 15:28, Igor Mitsyankoi.mitsya...@samsung.com wrote:
Representing each group write protection flag with only one bit instead of int
variable significantly reduces memory consumption.
Can we use the bitmap.h functions here rather than
On 02.04.2012 7:48 PM, Peter Maydell wrote:
On 2 April 2012 15:28, Igor Mitsyankoi.mitsya...@samsung.com wrote:
+s-card = SD_CARD(object_new(TYPE_SD_CARD));
dinfo = drive_get_next(IF_SD);
-s-card = sd_init(dinfo ? dinfo-bdrv : NULL, 0);
+SD_GET_CLASS(s-card)-init(s-card, dinfo
On 04/03/2012 01:02 AM, Paolo Bonzini wrote:
Il 02/04/2012 22:56, Igor Mitsyanko ha scritto:
2) At first I made SD card child of SD host controller, but it most
certainly wrong, it should be a link.
This is a bit thorny, because BlockDriverState exposes a slot and its
medium, not just
On 04/03/2012 05:54 PM, Dmitry Zhurikhin wrote:
Let me add my two cents here. I tested this patch slightly and didn't
find any problems.
Great, thanks!
On 2012-03-15 11:35, Igor Mitsyanko wrote:
Create 9 exynos4210 i2c interfaces.
Signed-off-by: Igor Mitsyankoi.mitsya...@samsung.com
for SDState, intermediate variable introduced in
SDState
to hold size of wp_groups array.
PATCH6 converts SD state to QOM object. QOMified implementation doesn't have any
advantages over current one but it gives us enormous possibilities for further
improvements.
Igor Mitsyanko (10):
hw/sd.c: convert
For the sake of code clarity
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index e1c998c..7160e8c 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -539,9 +539,9 @@ static void
A straightforward conversion of SD card implementation to a proper QEMU object.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/milkymist-memcard.c | 24 ++--
hw/omap_mmc.c | 28
hw/pl181.c | 14
This patch updates SD card emulation to support save/load of card's state.
Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com
---
hw/sd.c | 89 +-
1 files changed, 64 insertions(+), 25 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
1 - 100 of 271 matches
Mail list logo
