Why?
And it breaks pointer operation like
cur = ar-gpe.sts + addr;
thanks,
On Wed, May 22, 2013 at 11:46:35AM +0800, liguang wrote:
Signed-off-by: liguang lig.f...@cn.fujitsu.com
---
hw/acpi/core.c |8
hw/acpi/ich9.c |2 +-
hw/acpi/piix4.c
On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote:
在 2013-05-22三的 14:28 +0900，Isaku Yamahata写道：
Why?
And it breaks pointer operation like
the fact is I can't guess why gpe-sts is defined uint8_t
but the real hardware is 32-bit width.
Which section of ACPI spec?
I expand
Since more integer parameters would come in the future, so how about
set_migrate_parameter similar to set_migrate_capability?
It sets integer value, while set_migrate_capability sets bool value.
thanks,
On Mon, Oct 21, 2013 at 01:14:21AM +,
mrhi...@linux.vnet.ibm.com wrote:
From: Michael
ram_handle_compressed() should be aware size TARGET_PAGE_SIZE
migration-rdma can call it with larger size.
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
arch_init.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/arch_init.c b
On Wed, Sep 18, 2013 at 02:08:40PM +0200, Juan Quintela wrote:
Isaku Yamahata yamah...@private.email.ne.jp wrote:
ram_handle_compressed() should be aware size TARGET_PAGE_SIZE
migration-rdma can call it with larger size.
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
ram_handle_compressed() should be aware of size TARGET_PAGE_SIZE.
migration-rdma can call it with larger size.
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
changes v1 - v2:
- don't loop
---
arch_init.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff
On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote:
On 09/03/2013 10:32 PM, Isaku Yamahata wrote:
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/migration-rdma.c b
Later is_zero_page will be used for non TARGET_PAGE_SIZE
range.
And rename it to is_zero_range as it isn't page size any more.
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
arch_init.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/arch_init.c b
ram_handle_compressed() should be aware of size TARGET_PAGE_SIZE.
migration-rdma can call it with larger size.
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
Changes v2 - v3:
- use is_zero_range()
changes v1 - v2:
- don't loop
---
arch_init.c | 11 ++-
1 file changed
On Wed, Sep 18, 2013 at 11:01:16AM -0400, Michael R. Hines wrote:
The value of chunk_end changes based on whether or not the value of
block-is_ram_block is true of false.
When is block-is_ram_block set to false?
Looking at __qemu_rdma_add_block() and qemu_rdma_init_ram_blocks(),
is_ram_block
RDMA_WRID_CONTROL should be used. And remove related work around.
Cc: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/migration-rdma.c b
Cc: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration-rdma.c b/migration-rdma.c
index 67069d2..871f9cd 100644
--- a/migration-rdma.c
+++ b
Small fixes/clean up to rdma. found through code review.
Isaku Yamahata (3):
rdma: don't use negative index to array
rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX
rdma: use RDMA_WRID_READY
migration-rdma.c | 43 +++
1 file changed
Cc: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/migration-rdma.c b/migration-rdma.c
index 4828738..edbae9f 100644
It is allocated by g_strdup(), so needs to be freed.
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/migration-rdma.c b/migration-rdma.c
index 4828738..2c15d95 100644
--- a/migration-rdma.c
+++ b/migration
On Fri, Aug 02, 2013 at 09:40:58AM -0400,
Michael R. Hines mrhi...@linux.vnet.ibm.com wrote:
On 08/01/2013 11:56 PM, Isaku Yamahata wrote:
Small fixes/clean up to rdma. found through code review.
Isaku Yamahata (3):
rdma: don't use negative index to array
rdma
RDMAControlHeader::len is provided from remote, so check if the value
match the actual transferred byte_len.
Cc: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c | 32 ++--
1 file changed, 22
RMDAControlHeader::len is provided from remote, so validate it.
Cc: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c |5 +
1 file changed, 5 insertions(+)
diff --git a/migration-rdma.c b/migration-rdma.c
index 6721266
RDMAControlHeader::len is remote-provided. So validate the value before use.
Isaku Yamahata (3):
rdma: use resp.len after validation in qemu_rdma_registration_stop
rdma: validate RDMAControlHeader::len
rdma: check if RDMAControlHeader::len match transferred byte
migration-rdma.c | 44
resp.len is given from remote host. So should be validated before use.
Otherwise memcpy can access beyond the buffer.
Cc: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
---
migration-rdma.c |7 +++
1 file changed, 3 insertions(+), 4
On Wed, Nov 06, 2013 at 11:34:25AM -0500,
Michael R. Hines mrhi...@linux.vnet.ibm.com wrote:
On 10/23/2013 07:00 AM, Isaku Yamahata wrote:
Since more integer parameters would come in the future, so how about
set_migrate_parameter similar to set_migrate_capability?
It sets integer value, while
. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
--
Isaku Yamahata isaku.yamah...@gmail.com
reviews.
changes v1 - v2:
- update msi
- dropped already pushed out patches.
- added msix patches.
Isaku Yamahata (15):
pci: make pci_del_capability() update for w1cmask
pci: introduce helper functions to clear/set bits in configuration
space
pci: use pci_clear_bit_word
.) and helper functions for it.
helper functions for chassis, slot - PCIESlot conversion.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- Initialize prefetchable memory base/limit registers correctly.
They must support 64bit.
- compilation adjustment.
Changes v2 - v3
When deleting pci capability, w1cmask should be 0
to make those registers writablein addition to wmask.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index abddc6d..e3462a9 100644
Implement TI x3130 pcie upstream port switch.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Chnages v3 - v4:
- rename pcie_upstream - x3130_upstream.
- compilation adjustment.
Changes v2 - v3:
- compilation adjustment.
---
Makefile.objs |2 +-
hw/xio3130_upstream.c | 188
Implement TI x3130 pcie downstream port switch.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- rename: pcie_downstream - x3130_downstream
- compilation adjustment.
Changes v2 - v3:
- compilation adjustment.
---
Makefile.objs |2 +-
hw
glue pcie_push_attention_button command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie_port.c | 82 +++
qemu-monitor.hx | 14 +
sysemu.h|4 +++
3 files changed, 100 insertions(+), 0 deletions(-)
diff
This patch implements helper functions for pci express capability
and pci express extended capability allocation.
NOTE: presence detection depends on pci_qdev_init() change.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- various clean up
- dropped pcie_notify
This patch introduces helper functions to clear/set bits in configuration
space. pci_{clear_set, clear, set}_bit_{byte, word, long, quad}().
They will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h | 72
Implements pcie root port switch in intel X58 ioh
whose device id is 0x3420.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- rename pcie_root - ioh3420
- compilation adjustment.
Changes v2 - v3:
- compilation adjustment.
---
Makefile.objs |1 +
hw/ioh3420.c
introduce pcie_aer_inject_error command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- s/PCIE_AER/PCIEAER/g for structure names.
- compilation adjustment.
Changes v2 - v3:
- compilation adjustment.
---
hw/pcie_aer.c | 84
use pci_clear_bit_word() in pci_device_reset() where appropriate.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index e3462a9..5954476 100644
--- a/hw/pci.c
+++ b/hw/pci.c
This patch implements helper functions for pcie aer capability
which will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- various naming fixes.
- use pci bit operation helper function
- eliminate errmsg function pointer
- replace pci_shift_xxx
implements msi related functions.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- use pci_set_bit_xxx helper function.
- make nr_vectors, vector unsigned int.
- introduce PCI_MSI_VECTORS_MAX.
- fix undefined bit operations.
- eliminate msi_set_pending().
Changes v2
lower 4bits of base/limit register is RO, and
should not be modified on reset.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci_bridge.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c
index 638e3b3..7229610
add pcie constants to pcie_regs.h.
Those constants should go to Linux pci_regs.h and then the file should
go away eventually.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- removed copyright notice as requested.
Changes v2 - v3:
- moved out pcie constants from pcie.c
record which is written into pci configuration space.
introduce helper function to zero PCIDevice::written.
They will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c | 10 ++
hw/pci.h |5 +
2 files changed, 15 insertions(+), 0 deletions(-)
diff
On Mon, Oct 18, 2010 at 08:22:24AM +0200, Michael S. Tsirkin wrote:
On Mon, Oct 18, 2010 at 12:17:46PM +0900, Isaku Yamahata wrote:
lower 4bits of base/limit register is RO, and
should not be modified on reset.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci_bridge.c
On Mon, Oct 18, 2010 at 07:38:53AM +0200, Michael S. Tsirkin wrote:
On Mon, Oct 18, 2010 at 12:17:45PM +0900, Isaku Yamahata wrote:
record which is written into pci configuration space.
introduce helper function to zero PCIDevice::written.
They will be used later.
Signed-off-by: Isaku
On Mon, Oct 18, 2010 at 09:08:09AM +0200, Michael S. Tsirkin wrote:
The spec says the lower bits are read-only and they have its meaning.
Yes. but my question is why even touch io base/io limit at all
in this function?
It looks like guest can not rely on these being 0 after reset.
Oh, now
, and the second patch fixes
the overflow case with pci_region.
Isaku Yamahata (2):
pci: introduce pci_region to manage pci io/memory/prefmemory regions.
pciinit: use pci_region functions.
Makefile |3 +-
src/pci_region.c | 70 +++
src/pciinit.c| 122
This patch adds helper functions to manage pci area.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile |3 +-
src/pci_region.c | 70 ++
src/util.h | 15 +++
3 files changed, 87 insertions(+), 1
This patch cleans up pci region allocation with pci_region.
Now it is aware of overflow.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
src/pciinit.c | 122 -
1 files changed, 60 insertions(+), 62 deletions(-)
diff --git a/src
On Mon, Oct 18, 2010 at 11:55:08AM +0200, Michael S. Tsirkin wrote:
+static u32 pci_region_alloc_align(struct pci_region *r, u32 size, u32
align)
+{
+if (r-cur_end == PCI_REGION_DISABLED) {
+return 0;
+}
So is special value PCI_REGION_DISABLED or cur_end?
cur_end
-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- drop the lines in pci_bridge_reset()
- introduced two functions to reset base/limit registers.
---
hw/pci_bridge.c | 57 +++---
hw/pci_bridge.h |2 +
2 files changed, 51 insertions
glue pcie_push_attention_button command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie_port.c | 82 +++
qemu-monitor.hx | 14 +
sysemu.h|4 +++
3 files changed, 100 insertions(+), 0 deletions(-)
diff
this patch implements helper functions to handle msi-x and msi
uniformly.
They will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c | 19 +++
hw/pci.h |3 +++
2 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw
introduce pcie_aer_inject_error command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- s/PCIE_AER/PCIEAER/g for structure names.
- compilation adjustment.
Changes v2 - v3:
- compilation adjustment.
---
hw/pcie_aer.c | 84
This patch introduces helper functions to test-and-{clear, set} mask in
configuration
space. pci_{byte, word, long, quad}_test_and_{clear, set}_mask().
They will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h | 70
use pci_clear_bit_word() in pci_device_reset() where appropriate.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5
- use pci_word_test_and_clear_mask()
---
hw/pci.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index
by following reviews.
changes v1 - v2:
- update msi
- dropped already pushed out patches.
- added msix patches.
Isaku Yamahata (14):
pci: introduce helper functions to test-and-{clear, set} mask in
configuration space
pci: introduce helper function to handle msi-x and msi.
pci: use
Implement TI x3130 pcie upstream port switch.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- remove flr related stuff.
This will be addressed at the next phase.
- use pci_xxx_test_and_xxx_mask().
Chnages v3 - v4:
- rename pcie_upstream - x3130_upstream
This patch implements helper functions for pcie aer capability
which will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask()
- rewrote PCIDevice::written bits.
- eliminated pcie_aer_notify()
- introduced PCIExpressDevice
add pcie constants to pcie_regs.h.
Those constants should go to Linux pci_regs.h and then the file should
go away eventually.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- removed copyright notice as requested.
Changes v2 - v3:
- moved out pcie constants from pcie.c
This patch implements helper functions for pci express capability
and pci express extended capability allocation.
NOTE: presence detection depends on pci_qdev_init() change.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- dropped FLR related members
implements msi related functions.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- use pci_xxx_test_and_clear/set_mask().
Changes v3 - v4:
- use pci_set_bit_xxx helper function.
- make nr_vectors, vector unsigned int.
- introduce PCI_MSI_VECTORS_MAX.
- fix undefined
Implement TI x3130 pcie downstream port switch.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask().
- removed flr related stuff.
Changes v3 - v4:
- rename: pcie_downstream - x3130_downstream
- compilation adjustment.
Changes v2 - v3
.) and helper functions for it.
helper functions for chassis, slot - PCIESlot conversion.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask()
Changes v3 - v4:
- Initialize prefetchable memory base/limit registers correctly.
They must support 64bit
Implements pcie root port switch in intel X58 ioh
whose device id is 0x3420.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask()
Changes v3 - v4:
- rename pcie_root - ioh3420
- compilation adjustment.
Changes v2 - v3:
- compilation
Isaku Yamahata (14):
pci: introduce helper functions to test-and-{clear, set} mask in
configuration space
pci: introduce helper function to handle msi-x and msi.
pci: use pci_word_test_and_clear_mask() in pci_device_reset()
pci/bridge: fix pci_bridge_reset()
msi
On Tue, Oct 19, 2010 at 01:51:31PM +0200, Michael S. Tsirkin wrote:
On Tue, Oct 19, 2010 at 06:06:27PM +0900, Isaku Yamahata wrote:
On uncorrectable error status register in pcie_aer_write_config().
The register is RW1CS, so making it writable and test-and-clear doesn't
work.
Sure
On Tue, Oct 19, 2010 at 07:06:55PM +0200, Michael S. Tsirkin wrote:
On Wed, Oct 20, 2010 at 12:19:47AM +0900, Isaku Yamahata wrote:
On Tue, Oct 19, 2010 at 01:51:31PM +0200, Michael S. Tsirkin wrote:
On Tue, Oct 19, 2010 at 06:06:27PM +0900, Isaku Yamahata wrote:
On uncorrectable error
━
From: Isaku Yamahata [mailto:yamah...@valinux.co.jp]
To: Michael S. Tsirkin [mailto:m...@redhat.com]
Cc: qemu-devel@nongnu.org, skand...@cisco.com, etmar...@cisco.com,
we...@cisco.com, ad...@khaleel.us
Sent: Tue, 19 Oct 2010 08:55
On Wed, Oct 20, 2010 at 12:40:49AM +0200, Michael S. Tsirkin wrote:
I think I suggested once a good way to implement this:
- always make the bits w1c
- after config write:
if MHR is enabled, and you see that error log is not empty and that bit is
0,
this means that someone has
working on qemu-kvm, though on a little bit
old code base.
Great news. I'd like to have a look at the code.
thanks,
Wei
On 10/19/10 3:39 PM, Isaku Yamahata yamah...@valinux.co.jp wrote:
On Tue, Oct 19, 2010 at 11:07:34AM -0500, Adnan Khaleel wrote:
Are all these patches going
Implement TI x3130 pcie downstream port switch.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v5 - v6:
- compilation adjustment.
- eliminate aer bits.
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask().
- removed flr related stuff.
Changes v3 - v4:
- rename: pcie_downstream
glue pcie_push_attention_button command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie_port.c | 82 +++
qemu-monitor.hx | 14 +
sysemu.h|4 +++
3 files changed, 100 insertions(+), 0 deletions(-)
diff
patches.
Isaku Yamahata (12):
pcie: comment on hpev_intx
pci/bridge: fix pci_bridge_reset()
pcie port: define struct PCIEPort/PCIESlot and helper functions
ioh3420: pcie root port in X58 ioh
x3130: pcie upstream port
x3130: pcie downstream port
pcie/hotplug: introduce pushing
.) and helper functions for it.
helper functions for chassis, slot - PCIESlot conversion.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask()
Changes v3 - v4:
- Initialize prefetchable memory base/limit registers correctly.
They must support 64bit
Implements pcie root port switch in intel X58 ioh
whose device id is 0x3420.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v5 - v6:
- compilation adjustment.
- eliminated aer bits.
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask()
Changes v3 - v4:
- rename pcie_root
This patch implements helper functions for pcie aer capability
which will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Chnages v5 - v6:
- cleaned up pcie_aer_write_config().
- enum definition.
Changes v4 - v5:
- use pci_xxx_test_and_xxx_mask()
- rewrote PCIDevice
Implement TI x3130 pcie upstream port switch.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v5 - v6:
- compilation adjustment.
- delete aer bits.
Changes v4 - v5:
- remove flr related stuff.
This will be addressed at the next phase.
- use pci_xxx_test_and_xxx_mask
introduce pcie_aer_inject_error command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v3 - v4:
- s/PCIE_AER/PCIEAER/g for structure names.
- compilation adjustment.
Changes v2 - v3:
- compilation adjustment.
---
hw/pcie_aer.c | 84
-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v5 - v6:
- pci_bridge_disable_base_limit()
Changes v4 - v5:
- drop the lines in pci_bridge_reset()
- introduced two functions to reset base/limit registers.
---
hw/pci_bridge.c | 48 ++--
hw
Add aer support.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/ioh3420.c | 52 ++--
1 files changed, 46 insertions(+), 6 deletions(-)
diff --git a/hw/ioh3420.c b/hw/ioh3420.c
index 1f340d3..09c94f9 100644
--- a/hw/ioh3420.c
+++ b
add aer support.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/xio3130_downstream.c | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/xio3130_downstream.c b/hw/xio3130_downstream.c
index a44e188..9087c0b 100644
--- a/hw/xio3130_downstream.c
document hpev_intx.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie.h | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/hw/pcie.h b/hw/pcie.h
index 68327d8..2871e27 100644
--- a/hw/pcie.h
+++ b/hw/pcie.h
@@ -65,7 +65,15 @@ struct PCIExpressDevice
add aer support.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/xio3130_upstream.c | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/xio3130_upstream.c b/hw/xio3130_upstream.c
index d9d637f..36ed4b1 100644
--- a/hw/xio3130_upstream.c
+++ b/hw
On Wed, Oct 20, 2010 at 10:49:20AM +0200, Michael S. Tsirkin wrote:
On Wed, Oct 20, 2010 at 05:18:51PM +0900, Isaku Yamahata wrote:
The default value of base/limit registers aren't specified in the spec.
So pci_bridge_reset() shouldn't touch them.
Instead, introduced two functions to reset
On Wed, Oct 20, 2010 at 12:00:11PM +0200, Michael S. Tsirkin wrote:
On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote:
glue pcie_push_attention_button command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
So as a high level command, I think we need to
think about
Thank you for detailed review.
On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S. Tsirkin wrote:
+static uint32_t aer_log_del(PCIEAERLog *aer_log)
+{
+uint32_t i = aer_log-consumer;
+aer_log-consumer = aer_log_next(aer_log-consumer, aer_log-log_max);
+return i;
+}
On Thu, Oct 21, 2010 at 10:02:37AM +0200, Michael S. Tsirkin wrote:
On Thu, Oct 21, 2010 at 12:46:33PM +0900, Isaku Yamahata wrote:
On Wed, Oct 20, 2010 at 12:00:11PM +0200, Michael S. Tsirkin wrote:
On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote:
glue
On Thu, Oct 21, 2010 at 10:07:01AM +0200, Michael S. Tsirkin wrote:
On Thu, Oct 21, 2010 at 02:15:24PM +0900, Isaku Yamahata wrote:
Thank you for detailed review.
On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S. Tsirkin wrote:
+static uint32_t aer_log_del(PCIEAERLog *aer_log
On Fri, Oct 22, 2010 at 04:38:49PM +0200, Michael S. Tsirkin wrote:
On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote:
glue pcie_push_attention_button command
On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote:
On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote:
On Fri, Oct 22, 2010 at 04:38:49PM +0200, Michael S. Tsirkin wrote:
On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote:
Michael S. Tsirkin m
Seems good.
For consistency, the range check in msix_write_config() should
be also removed.
On Mon, Oct 25, 2010 at 08:07:25AM +0200, Michael S. Tsirkin wrote:
config write handlers should be idempotent.
So no need for range checks.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote:
On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote:
On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
Simplify logic for hotplug notification, by tracking state of the
logical interrupt
On Mon, Oct 25, 2010 at 07:55:57AM +0200, Michael S. Tsirkin wrote:
On Mon, Oct 25, 2010 at 02:53:16PM +0900, Isaku Yamahata wrote:
On Mon, Oct 25, 2010 at 06:15:37AM +0200, Michael S. Tsirkin wrote:
On Mon, Oct 25, 2010 at 12:29:57PM +0900, Isaku Yamahata wrote:
On Fri, Oct 22, 2010
On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
Simplify logic for hotplug notification, by tracking state of the
logical interrupt condition. We then simply use this variable to make
the interrupt decision, according to spec.
API is made cleaner as we no longer force
Some comments below.
On Mon, Oct 25, 2010 at 07:05:51AM +0200, Michael S. Tsirkin wrote:
config cycle operations should be idempotent, so
there's no need to complicate code with range checks.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Untested. Pls comment.
hw/pcie.c |
On Mon, Oct 25, 2010 at 04:02:36PM +0900, Isaku Yamahata wrote:
What I am also saying is that the same command should be able
to work for pci and express I think.
I see. Then, I think that the slot numbering needs to be discussed.
Yes.
More concretely, it's what type
This patch series fixes isseus which introduced by
5704608988972359473ce609f9e4884808115b58
cd870502e228f8f028f93fb585ae3b208fcb46c7
4b78560503a802eae3663ace9f9cf080319e7265
Isaku Yamahata (6):
pcie: fix pcie_cap_slot_write_config().
pcie/slot: fix hotplug_event_notify().
pcie/slot: clean
-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie.c | 25 ++---
1 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/hw/pcie.c b/hw/pcie.c
index 0385f53..64cc003 100644
--- a/hw/pcie.c
+++ b/hw/pcie.c
@@ -19,6 +19,7 @@
*/
#include sysemu.h
+#include
remove redundant return and blank line from hotplug_event_notify().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/pcie.c b/hw/pcie.c
index 3c52849..37d7457 100644
--- a/hw/pcie.c
+++ b/hw/pcie.c
This patch fixes the miscondition to trigger slot event
which is introduced by cd870502e228f8f028f93fb585ae3b208fcb46c7.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pcie.c b/hw/pcie.c
index
This patch factors out the hot plug event logic.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pcie.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/pcie.c b/hw/pcie.c
index 37d7457..97d17fa 100644
--- a/hw/pcie.c
+++ b/hw/pcie.c
@@ -139,9
This patch fixes save/load of pcie slot which was broken by
cd870502e228f8f028f93fb585ae3b208fcb46c7.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/ioh3420.c|1 +
hw/pcie.c |7 +++
hw/pcie.h |1 +
hw/xio3130_downstream.c
Same as 4b78560503a802eae3663ace9f9cf080319e7265
config write handlers should be idempotent.
So no need for range checks.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/msix.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/hw/msix.c b/hw/msix.c
index
Looks good.
On Wed, Oct 27, 2010 at 04:30:03PM +0200, Michael S. Tsirkin wrote:
Comment fixup (tell what it does not what it does not do),
typo fix, whitespace fix.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/msi.c |7 +++
1 files changed, 3 insertions(+), 4
1 - 100 of 1486 matches
Mail list logo
