introduce helper function to find device from table and initialize it.
pci_find_init_device(). This will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
src/pci.c | 12
src/pci.h |1 +
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/src
specific operation into dev-i440fx.c with it.
Thus q35 specific register value/operation will be added easily.
Isaku Yamahata (5):
seabios: pci: introduce helper function to find device from table and
initialize it.
seabios: acpi: move out endian conversion helper function.
seabios: acpi
Make it table driven to other chip set.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
src/acpi.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/acpi.c b/src/acpi.c
index 5818d4c..e91f8e0 100644
--- a/src/acpi.c
+++ b/src/acpi.c
@@ -522,6 +522,13
Move ACPI_TABLE_HEADER_DEF and struct fadt_descriptor_rev1
from acpi.h to acpi.c for later use.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
src/acpi.c | 73 -
src/acpi.h | 76
move out piix4 specific smram logic to dev-i440fx.c.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
changes v2 - v3.
- abstract device level and simplified it.
- factor out smm ram relocation.
---
src/dev-i440fx.c | 32 +
src/dev-i440fx.h |1 +
src
/operation will be added easily.
Changes v1 - v2:
- separated non-arguable part to make the merge easy.
- factor out intel specific shadow memory operation.
- factor out smm operation.
- abstract at device level, not register level.
Isaku Yamahata (2):
seabios: shadow: make device finding more generic
On Wed, Jul 14, 2010 at 09:10:28AM -0600, Cam Macdonell wrote:
On Tue, Jul 13, 2010 at 8:52 PM, Isaku Yamahata yamah...@valinux.co.jp
wrote:
On Tue, Jul 13, 2010 at 04:48:19PM -0600, Cam Macdonell wrote:
On Tue, Jul 13, 2010 at 2:41 PM, Isaku Yamahata yamah...@valinux.co.jp
wrote
Added Cc: seab...@seabios.org
On Wed, Jul 21, 2010 at 06:31:01AM +0300, Michael S. Tsirkin wrote:
On Tue, Jul 20, 2010 at 06:52:23PM +0900, Isaku Yamahata wrote:
On Wed, Jul 14, 2010 at 09:10:28AM -0600, Cam Macdonell wrote:
On Tue, Jul 13, 2010 at 8:52 PM, Isaku Yamahata yamah
Ping?
On Tue, Jul 13, 2010 at 01:01:38PM +0900, Isaku Yamahata wrote:
Changes v2 - v1:
v3
- dropped first patch as it is merdged.
- rebased to mst's pci branch.
- eliminated pci_brdige_qdev_register(), pci_brdige_create(),
pci_brdige_create_simple() by exporting PCIBus
On Thu, Jul 22, 2010 at 11:28:27AM +0300, Michael S. Tsirkin wrote:
On Thu, Jul 22, 2010 at 11:33:32AM +0900, Isaku Yamahata wrote:
Ping?
You said you will rebase and repost?
This is it. Probably there was a race between them
On Tue, Jul 13, 2010 at 01:01:38PM +0900, Isaku Yamahata
On Thu, Jul 22, 2010 at 09:54:46PM +, Blue Swirl wrote:
diff --git a/hw/pci.c b/hw/pci.c
index a98d6f3..49f03fb 100644
--- a/hw/pci.c
+++ b/hw/pci.c
...
@@ -817,6 +825,25 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
pci_set_long(pci_dev-wmask + addr, wmask
To match Linux PCI register definition,
rename PCI_SUBVENDOR_ID to PCI_SUBSYSTEM_VENDOR_ID.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |2 +-
hw/pci.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 344d72b..fb03ee2
make pci_bar_address independent of PCI_BAR_UNMAPPED value.
PCI_BAR_UNMAPPED could be arbitrary value which doesn't match
possible pci bar. So == PCI_BAR_UNMAPPED check is not good.
This patch cleans it up.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |3 +--
1 files
There is no user and they're obsolete. So remove them.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/pci.h b/hw/pci.h
index 0309674..91f3809 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -154,9 +154,7
Define symbolic value in i440fx configuration space
for 0x59, 0x5f and 0x7f and use them.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/piix_pci.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 1b67475
PCIBus::config_reg isn't used anymore, so remove it.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 404eead..aed3a24 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -40,7 +40,6 @@ struct
use range helper function in i440fx_write_config().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/piix_pci.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 7bbaf50..304f84a 100644
--- a/hw/piix_pci.c
+++ b/hw
use range helper function in msix_write_config().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/msix.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/msix.c b/hw/msix.c
index 0baedef..2ca0900 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -175,7 +175,7
They call only pci_default_{read, write}_config().
So they aren't necessary.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/gt64xxx.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c
index fb7f5bd..c8034e2 100644
use range helper function in pm_write_config().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Michael S. Tsirkin m...@redhat.com
---
hw/acpi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index 9a69e7d..ad72297 100644
--- a/hw
:
- dropped the patch pci: clean up pci_bar_address()
- reordered
- rebased to git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci
- updated I440FX patch.
- added link to I440FX link
Isaku Yamahata (10):
pci: remove PCIBus::config_reg.
pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g
pci
use range helper function in i440fx_write_config().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/piix_pci.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 0dae6f9..384d31c 100644
--- a/hw/piix_pci.c
+++ b/hw
include pci_regs.h and remove duplicated defines.
And remove unused PCI_REVISION and PCI_SUBDEVICE_ID.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Michael S. Tsirkin m...@redhat.com
---
hw/pci.h | 77 ++---
1 files
PCIBus::config_reg isn't used anymore, so remove it.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Michael S. Tsirkin m...@redhat.com
---
hw/pci.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 404eead..aed3a24 100644
--- a/hw
Define symbolic value in i440fx configuration space
for 0x59, 0x5f and 0x7f and use them.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/piix_pci.c | 17 -
1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 1b67475
Import Linux pci_regs.h. Later PCI register definitions in pci.h
will be eliminated.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci_regs.h | 665 +
1 files changed, 665 insertions(+), 0 deletions(-)
create mode 100644 hw
add link to i440fx data sheet.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/piix_pci.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 384d31c..cd12212 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -29,6 +29,11
By introducing a registering function, make pc_init1() not refer to
ferr_irq directly in order to make ferr_irq piix independent.
Later pc_init1() will be split out into another file keeping ferr_irq
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |8 +++-
hw
Introduce a function, pc_allocate_cpu_irq(), to allocate cpu irq
in order to make pic_irq_request() piix independent.
Later piix code will be split out to another file keeping pic_irq_request()
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |7 ++-
1 files
Split out pci device initialization from pc_init1() into pc_pci_device_init().
and removed unnecessary braces.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 35 +++
1 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/hw/pc.c b
Move rtc_xxx declarations from pc.h into mc146818rtc.h.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.h | 10 ++
hw/pc.h | 10 ++
2 files changed, 12 insertions(+), 8 deletions(-)
create mode 100644 hw/mc146818rtc.h
diff --git a/hw
remove #ifdef DEBUG_CMOS by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 1eb991c..0e1dc07 100644
--- a/hw/mc146818rtc.c
qdevfy acpi_piix4.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c | 56 ++
1 files changed, 43 insertions(+), 13 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 2d12da7..0083731 100644
--- a/hw
*rtc_state.
- minor compilation fixes
Changes from v2:
- clean up pc_pci_device_init() not to use unnecessary braces.
Changes from v1:
- make patches full bisectable
- typo s/allocte/allocate/
- some minor fixes
- dropped a merged patch
Isaku Yamahata (27):
acpi: split out pc smbus routines
Split acpi.c into the common part and the piix4 specific part.
The common part will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |4 +-
hw/acpi.c | 557 ---
hw/{acpi.c
The argument will be used later to remove global variable.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c |6 +++---
hw/pci.c|8 +---
hw/pci.h|4 ++--
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw
Remove a global variable, floppy_controller.
Since it is unnecessarily global, make it local and pass it as
a function argument.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
To match rtc_xxx with qdev, make rtc_xxx accept and return ISADevice
instead of RTCState.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.c | 26 +++---
hw/mc146818rtc.h |8
hw/mips_jazz.c |1 +
hw/mips_malta.c |3 ++-
hw
Split out vga initialization which is independent of piix
from pc_init1() as pc_vga_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 41 +++--
1 files changed, 23 insertions(+), 18 deletions(-)
diff --git
remove global variables, gpe and pci0_status by moving them
into PIIX4PMState.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c | 71 +-
hw/pc.h |1 -
hw/pc_piix.c|1 -
3 files changed, 38
Split out pc smbus routines from acpi.c into pc_smbus.c and
use it.
The split out smbus emulation will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |2 +
hw/acpi.c | 164 +++
hw/pc_smbus.c
remove unnecessary global static variables, pit.
Make it local.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 00f4efa..93d0ce4 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -66,7 +66,6
removed #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c | 54 ++
1 files changed, 18 insertions(+), 36 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 59a4d0f..aa63f0e
split out cpu initialization which is piix independent from pc_init1()
into pc_cpus_init(). Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 32 +++-
1 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/hw/pc.c b
remove #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc_smbus.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/pc_smbus.c b/hw/pc_smbus.c
index 850260d..9581aba 100644
--- a/hw/pc_smbus.c
+++ b/hw
remove #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc_apm.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/pc_apm.c b/hw/pc_apm.c
index f6bcd7d..e1cee96 100644
--- a/hw/pc_apm.c
+++ b/hw/pc_apm.c
@@ -23,6
make cpu_smm_update() generic to be independent on i440fx by
registering a callback.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 18 +++---
hw/pc.h |8 +++-
hw/piix_pci.c |5 -
3 files changed, 26 insertions(+), 5 deletions
Split out apm register emulation for acpi.c into pc_apm.c.
The apm emulation will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |4 +-
hw/acpi.c | 57 ++--
hw/pc_apm.c | 85
variable rtc_state.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Cc: Paolo Bonzini bonz...@gnu.org
---
hw/acpi_piix4.c |8
hw/mips_malta.c |3 ++-
hw/pc.c | 27 ++-
hw/pc.h |4 ++--
4 files changed, 22 insertions(+), 20 deletions
The changeset of 2c8d9340203c7f19265fd4cb2341f568217a3af6
prevents isa_irq_handler() from NULL refering of IsaIrqState::ioapic.
However it would be better to initialize the member before reference.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |6 +++---
1 files changed, 3
Split out memory allocation and rom/bios loading which doesn't depend
on piix from pc_init1() into pc_memory_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 74 +++---
1 files changed, 46
Split out basic device, i.e. legacy devices like floppy, initialization
from pc_init1() into pc_basic_device_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 87 +++---
1 files changed, 49
Finally, we can safely split out the piix specific part from pc.c
into pc_piix.c.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |2 +-
hw/pc.c | 264 +-
hw/pc.h | 33 +++
hw/pc_piix.c
remove unused variable in get_pmsts().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 53efa2a..887c82f 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
add acpi constants from linux header files and
replace the old constants with them.
The acpi constants will be used by other file.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi.c | 56 +++
hw/acpi.h | 78
Yamahata yamah...@valinux.co.jp
Date: Mon, 4 Jan 2010 19:39:36 +0900
Subject: [PATCH] pci: pcihost clean up.
remove some codes by introduce callback to calculate pci device and offset
in configuration space.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/gt64xxx.c |9
On Mon, Jan 04, 2010 at 11:55:10AM +0100, Alexander Graf wrote:
On 04.01.2010, at 11:45, Isaku Yamahata wrote:
On Mon, Jan 04, 2010 at 04:26:46AM +0100, Alexander Graf wrote:
On 03.01.2010, at 21:50, Benjamin Herrenschmidt wrote:
On Sun, 2010-01-03 at 21:27 +0100, Alexander Graf
split out cpu initialization which is piix independent from pc_init1()
into pc_cpus_init(). Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 32 +++-
1 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/hw/pc.c b
Basically it looks good.
Some minor comments below.
Although further clean up is possible,
this is first small step.
On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote:
Different host buses may have different layouts for config space accessors.
The Mac U3 for example uses the
remove #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc_smbus.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/pc_smbus.c b/hw/pc_smbus.c
index 30cdaa7..1d44d1e 100644
--- a/hw/pc_smbus.c
+++ b/hw
qdevfy acpi_piix4.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
changes v10 - v11:
- pass DeviceState of piix4-pm to pc_smbus_init().
Now info qtree shows smbus.
---
hw/acpi_piix4.c | 56 ++
1 files changed, 43 insertions
Split out pci device initialization from pc_init1() into pc_pci_device_init().
and removed unnecessary braces.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 35 +++
1 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/hw/pc.c b
remove unnecessary global static variables, pit.
Make it local.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index cdd9de6..0dee9d7 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -66,7 +66,6
Split acpi.c into the common part and the piix4 specific part.
The common part will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |4 +-
hw/acpi.c | 557 ---
hw/{acpi.c
Finally, we can safely split out the piix specific part from pc.c
into pc_piix.c.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |2 +-
hw/pc.c | 264 +-
hw/pc.h | 33 +++
hw/pc_piix.c
bisectable
- typo s/allocte/allocate/
- some minor fixes
- dropped a merged patch
Isaku Yamahata (27):
acpi: split out pc smbus routines from acpi.c into pc_smbus.c
acpi: split out apm register emulation from acpi.c
acpi: add acpi constants from linux header files and use them.
acpi: split acpi.c
Split out basic device, i.e. legacy devices like floppy, initialization
from pc_init1() into pc_basic_device_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 87 +++---
1 files changed, 49
remove unused variable in get_pmsts().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 71b1156..802cd92 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
make cpu_smm_update() generic to be independent on i440fx by
registering a callback.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 18 +++---
hw/pc.h |8 +++-
hw/piix_pci.c |5 -
3 files changed, 26 insertions(+), 5 deletions
remove global variables, gpe and pci0_status by moving them
into PIIX4PMState.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v10 - v11:
- change callback argument of hotplug from void* to DeviceState*.
---
hw/acpi_piix4.c | 72
variable rtc_state.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Cc: Paolo Bonzini bonz...@gnu.org
---
hw/acpi_piix4.c |8
hw/mips_malta.c |3 ++-
hw/pc.c | 27 ++-
hw/pc.h |4 ++--
4 files changed, 22 insertions(+), 20 deletions
To match rtc_xxx with qdev, make rtc_xxx accept and return ISADevice
instead of RTCState.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.c | 26 +++---
hw/mc146818rtc.h |8
hw/mips_jazz.c |1 +
hw/mips_malta.c |3 ++-
hw
Split out vga initialization which is independent of piix
from pc_init1() as pc_vga_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 41 +++--
1 files changed, 23 insertions(+), 18 deletions(-)
diff --git
By introducing a registering function, make pc_init1() not refer to
ferr_irq directly in order to make ferr_irq piix independent.
Later pc_init1() will be split out into another file keeping ferr_irq
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |8 +++-
hw
Split out memory allocation and rom/bios loading which doesn't depend
on piix from pc_init1() into pc_memory_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 74 +++---
1 files changed, 46
add acpi constants from linux header files and
replace the old constants with them.
The acpi constants will be used by other file.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi.c | 56 +++
hw/acpi.h | 78
Split out apm register emulation for acpi.c into pc_apm.c.
The apm emulation will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |4 +-
hw/acpi.c | 57 ++--
hw/pc_apm.c | 85
The changeset of 2c8d9340203c7f19265fd4cb2341f568217a3af6
prevents isa_irq_handler() from NULL refering of IsaIrqState::ioapic.
However it would be better to initialize the member before reference.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |6 +++---
1 files changed, 3
Add argument, DeviceState*, to pci hot plug callback.
The argument will be used later to remove global variable.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
changes v10 - v11:
- change callback argument from void* to DeviceState*.
---
hw/acpi_piix4.c |6 +++---
hw/pci.c
Split out pc smbus routines from acpi.c into pc_smbus.c and
use it.
The split out smbus emulation will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
changes v10 - v11
- add DeviceState *qdev argument to pc_smbus_init()
for info qtree.
---
Makefile.target |2 +
hw
remove #ifdef DEBUG_CMOS by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 1eb991c..0e1dc07 100644
--- a/hw/mc146818rtc.c
Introduce a function, pc_allocate_cpu_irq(), to allocate cpu irq
in order to make pic_irq_request() piix independent.
Later piix code will be split out to another file keeping pic_irq_request()
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |7 ++-
1 files
Remove a global variable, floppy_controller.
Since it is unnecessarily global, make it local and pass it as
a function argument.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
remove #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc_apm.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/pc_apm.c b/hw/pc_apm.c
index f6bcd7d..e1cee96 100644
--- a/hw/pc_apm.c
+++ b/hw/pc_apm.c
@@ -23,6
removed #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c | 54 ++
1 files changed, 18 insertions(+), 36 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index e64a2dd..2540626
Move rtc_xxx declarations from pc.h into mc146818rtc.h.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.h | 10 ++
hw/pc.h | 10 ++
2 files changed, 12 insertions(+), 8 deletions(-)
create mode 100644 hw/mc146818rtc.h
diff --git a/hw
On Mon, Jan 04, 2010 at 03:56:50PM +0100, Gerd Hoffmann wrote:
On 12/24/09 09:09, Isaku Yamahata wrote:
The argument will be used later to remove global variable.
-static int piix4_device_hotplug(PCIDevice *dev, int state);
+static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int
On Tue, Jan 05, 2010 at 11:11:00PM +0100, Aurelien Jarno wrote:
On Tue, Jan 05, 2010 at 03:27:24PM +0900, Isaku Yamahata wrote:
Split out pc smbus routines from acpi.c into pc_smbus.c and
use it.
Given the code is not specific to PC, but is also used on MIPS, I am not
sure pc_smbus
remove #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
---
hw/apm.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/apm.c b/hw/apm.c
index d20db3d..3cbde43 100644
--- a/hw/apm.c
remove #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
---
hw/pm_smbus.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/pm_smbus.c b/hw/pm_smbus.c
index 6ef6b9e..9929d72
minor fixes
- dropped a merged patch
Isaku Yamahata (27):
acpi: split out piix4 smbus routines from acpi.c into pm_smbus.c
acpi: split out apm register emulation from acpi.c
acpi: add acpi constants from linux header files and use them.
acpi: split acpi.c into the common part and the piix4
remove global variables, gpe and pci0_status by moving them
into PIIX4PMState.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
---
Changes v10 - v11:
- change callback argument of hotplug from void* to DeviceState*.
---
hw/acpi_piix4.c | 72
variable rtc_state.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Cc: Paolo Bonzini bonz...@gnu.org
Acked-by: Gerd Hoffmann kra...@redhat.com
---
hw/acpi_piix4.c |8
hw/mips_malta.c |3 ++-
hw/pc.c | 27 ++-
hw/pc.h |4 ++--
4
Introduce a function, pc_allocate_cpu_irq(), to allocate cpu irq
in order to make pic_irq_request() piix independent.
Later piix code will be split out to another file keeping pic_irq_request()
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
Remove a global variable, floppy_controller.
Since it is unnecessarily global, make it local and pass it as
a function argument.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
---
hw/pc.c |8 +---
1 files changed, 5 insertions(+), 3
removed #ifdef DEBUG by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
---
hw/acpi_piix4.c | 54 ++
1 files changed, 18 insertions(+), 36 deletions(-)
diff --git a/hw/acpi_piix4.c
Split out piix4 smbus routines from acpi.c into pm_smbus.c and
use it.
The split out smbus emulation will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
Cc: Aurelien Jarno aurel...@aurel32.net
---
changes v11 - v12
- switch
remove unused variable in get_pmsts().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
---
hw/acpi_piix4.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index c44ab5d..30401a1 100644
By introducing a registering function, make pc_init1() not refer to
ferr_irq directly in order to make ferr_irq piix independent.
Later pc_init1() will be split out into another file keeping ferr_irq
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra
remove #ifdef DEBUG_CMOS by using macro.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Acked-by: Gerd Hoffmann kra...@redhat.com
---
hw/mc146818rtc.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index
601 - 700 of 1486 matches
Mail list logo
