id rtl8139_transfer_frame(RTL8139State *s,
> uint8_t *buf, int size,
> { .iov_base = buf + ETHER_ADDR_LEN * 2,
> .iov_len = size - ETHER_ADDR_LEN * 2 },
> };
> +
> +memcpy(vlan_iov, iov, sizeof(vlan_iov));
> +iov = vlan_iov;
> }
>
> if (TxLoopBack == (s->TxConfig & TxLoopBack))
Reviewed-by: Jason Wang
On 11/25/2014 02:44 AM, Stefano Stabellini wrote:
> On Mon, 24 Nov 2014, Stefano Stabellini wrote:
>> On Mon, 24 Nov 2014, Stefano Stabellini wrote:
>>> CC'ing Paolo.
>>>
>>>
>>> Wen,
>>> thanks for the logs.
>>>
>>> I investigated a little bit and it seems to me that the bug occurs when
>>> QEMU t
On 11/25/2014 09:53 PM, Stefano Stabellini wrote:
> On Tue, 25 Nov 2014, Jason Wang wrote:
>> On 11/25/2014 02:44 AM, Stefano Stabellini wrote:
>>> On Mon, 24 Nov 2014, Stefano Stabellini wrote:
>>>> On Mon, 24 Nov 2014, Stefano Stabellini wrote:
>>>
On 11/26/2014 06:53 PM, Stefano Stabellini wrote:
On Wed, 26 Nov 2014, Jason Wang wrote:
>On 11/25/2014 09:53 PM, Stefano Stabellini wrote:
> >On Tue, 25 Nov 2014, Jason Wang wrote:
> >>On 11/25/2014 02:44 AM, Stefano Stabellini wrote:
> >>>On Mon, 24 Nov
Congyang
Cc: Stefano Stabellini
Cc: qemu-sta...@nongnu.org
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 9b88775..fdb4edd 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net
On Thu, Nov 27, 2014 at 3:45 PM, Fam Zheng wrote:
On Thu, 11/27 13:59, Jason Wang wrote:
virtio_net_handle_ctrl() and other functions that process control vq
request call iov_discard_front() which will shorten the iov. This
will
lead unmapping in virtqueue_push() leaks mapping.
Fixes
On 11/27/2014 05:08 PM, Fam Zheng wrote:
> On Thu, 11/27 13:59, Jason Wang wrote:
>> > virtio_net_handle_ctrl() and other functions that process control vq
>> > request call iov_discard_front() which will shorten the iov. This will
>> > lead unmapping in
Congyang
Cc: Stefano Stabellini
Cc: qemu-sta...@nongnu.org
Signed-off-by: Jason Wang
---
Changes from V1:
- Use g_memdup() to simplify codes
---
hw/net/virtio-net.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 9b88775
On Fri, Nov 28, 2014 at 9:16 AM, Fam Zheng wrote:
On Thu, 11/27 23:13, Michael S. Tsirkin wrote:
On Thu, Nov 27, 2014 at 07:21:35PM +, Stefan Hajnoczi wrote:
> On Thu, Nov 27, 2014 at 4:33 PM, Michael S. Tsirkin
wrote:
> > We leak cpu mappings when 1st s/g is not exactly the
> > he
On Fri, Nov 28, 2014 at 5:26 PM, arei.gong...@huawei.com wrote:
From: Gonglei
Signed-off-by: Gonglei
---
hw/scsi/vhost-scsi.c | 1 +
hw/virtio/vhost.c| 2 ++
2 files changed, 3 insertions(+)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index 308b393..dcb2bc5 100644
--- a/hw
On Mon, Dec 1, 2014 at 2:27 PM, Gonglei wrote:
On 2014/12/1 13:03, Jason Wang wrote:
On Fri, Nov 28, 2014 at 5:26 PM, arei.gong...@huawei.com wrote:
From: Gonglei
Signed-off-by: Gonglei
---
hw/scsi/vhost-scsi.c | 1 +
hw/virtio/vhost.c| 2 ++
2 files changed, 3 insertions
r;
+pci_dev->config_write = e1000_write_config;
+
pci_conf = pci_dev->config;
/* TODO: RST# value should be 0, PCI spec 6.2.4 */
--
MST
Reviewed-by: Jason Wang
- Original Message -
> Some drivers set RDT=RDH. Oddly, this works on real hardware. To work
> around this, autodecrement RDT when this happens.
>
> Signed-off-by: Richard Tollerton
> Signed-off-by: Jeff Westfahl
> ---
> hw/net/e1000.c | 6 ++
> 1 file changed, 6 insertions(+)
Pl
e set to precisely
> MDIC_ERROR|MDIC_READY.
>
> Signed-off-by: Richard Tollerton
> Signed-off-by: Jeff Westfahl
> ---
Looks correct.
Reviewed-by: Jason Wang
> hw/net/e1000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e
On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote:
After enabled network debug of e1000 in Win2012-64r2 guest,
Bus mastering of e1000 can't be enabled by e1000 driver. It
caused guest can't get IP address.
# bcdedit /debug on
# bcdedit /dbgsettings net hostip:192.168.122.100 port:5
(
On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote:
Win2012-64r2 guest doesn't set bus mastering correctly,
it caused guest network down, this patch ignored it for
e1000 nic for workarounding the guest issue.
Patch 1 is an update version of:
http://lists.gnu.org/archive/html/qemu-devel/2014-12/
On Thu, Dec 18, 2014 at 7:11 PM, Denis V. Lunev
wrote:
On 18/12/14 14:01, Denis V. Lunev wrote:
On 18/12/14 13:05, Jason Wang wrote:
On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote:
Win2012-64r2 guest doesn't set bus mastering correctly,
it caused guest network down, this
On Fri, Dec 19, 2014 at 11:09 AM, Amos Kong wrote:
On Thu, Dec 18, 2014 at 10:13:07AM +0008, Jason Wang wrote:
On Thu, Dec 18, 2014 at 5:22 PM, Amos Kong wrote:
>Win2012-64r2 guest doesn't set bus mastering correctly,
>it caused guest network down, this patch ignored it
On 12/19/2014 09:25 PM, Amos Kong wrote:
> Passing some invalid fds in QEMU commandline, the fds don't exist.
> QEMU will get error "TUNGETIFF ioctl() failed: Bad file descriptor",
> and coredump in setting queues.
>
> This patch checked return value of first operate to fd, QEMU will
> report erro
On 12/22/2014 01:28 PM, Amos Kong wrote:
> On Mon, Dec 22, 2014 at 11:48:29AM +0800, Jason Wang wrote:
>> On 12/19/2014 09:25 PM, Amos Kong wrote:
>>> Passing some invalid fds in QEMU commandline, the fds don't exist.
>>> QEMU will get error "TUNGETIF
On 12/21/2014 03:48 PM, Roy Vardi wrote:
> From: Roy Vardi
>
> Add 'persistent' boolean flag to -net tap option.
> When set to off - tap interface will be released on shutdown
> When set to on\not specified - tap interface will remain
I'm interested of the user cases in the case. Usu
default_devaddr,
&err);
if (!res) {
-error_report_err(err);
+if (err) {
+error_report_err(err);
+}
exit(1);
}
return res;
--
1.8.3.1
Reviewed-by: Jason Wang
This patches adds machine type specific instance initialization
functions. Those functions will be used by following patches to compat
class properties for legacy machine types.
Cc: Alexander Graf
Cc: qemu-...@nongnu.org
Signed-off-by: Jason Wang
---
hw/ppc/spapr.c | 23
The following patches will limit the following things to legacy
machine type:
- maximum number of virtqueues for virtio-pci were limited to 64
- auto msix bar size for virtio-net-pci were disabled by default
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Michael S. Tsirkin
Signed-off-by: Jason
Virtqueue were indexed from zero, so don't delete virtqueue whose
index is n->max_queues * 2 + 1.
Cc: Michael S. Tsirkin
Cc: qemu-stable
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/ne
l one,
this will allow us to just increase the limit of one transport
without disturbing others.
- only increase the queue limit of virtio-pci
- limit the maximum number of virtio queues to 64 for legacy machine
types
Jason Wang (16):
virtio-net: fix the upper bound when trying to delete qu
This patch replace the magic number 255, and increase it to
MAX_QUEUE_NUM which is maximum number of queues supported by a nic.
Cc: Luiz Capitulino
Signed-off-by: Jason Wang
---
monitor.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/monitor.c b
The following patches will limit the following things to legacy
machine type:
- maximum number of virtqueues for virtio-pci were limited to 64
- auto msix bar size for virtio-net-pci were disabled by default
Cc: Alexander Graf
Cc: qemu-...@nongnu.org
Signed-off-by: Jason Wang
---
hw/ppc
Signed-off-by: Jason Wang
---
hw/s390x/s390-virtio-ccw.c | 7 +--
hw/s390x/virtio-ccw.c| 19 ---
include/hw/s390x/s390_flic.h | 4 +++-
3 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index
255 queues.
Cc: Luiz Capitulino
Signed-off-by: Jason Wang
---
monitor.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index a039edf..2b5643d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4477,7 +4477,7 @@ void set_link_completion(ReadLineState
.
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index c38f33f..7d01500 100644
--- a/hw/virtio/virtio-pci.c
+++
qemu-...@nongnu.org
Signed-off-by: Jason Wang
---
hw/i386/pc_piix.c | 5 +
hw/i386/pc_q35.c | 5 +
hw/ppc/spapr.c | 5 +
hw/virtio/virtio-pci.c | 3 ++-
4 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 212e263..6e
There's no need to use vector 0 for invalid virtqueue. So this patch
changes to use VIRTIO_NO_VECTOR instead.
Cc: Michael S. Tsirkin
Cc: Cornelia Huck
CC: Christian Borntraeger
Cc: Richard Henderson
Cc: Alexander Graf
Signed-off-by: Jason Wang
---
hw/s390x/virtio-ccw.c | 2 +-
1
S. Tsirkin
Signed-off-by: Jason Wang
---
hw/pci/msix.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index 24de260..f8748cf 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -295,29 +295,37 @@ int msix_init_ex
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-mmio.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
index 2ae6942..dbd44b6 100644
--- a/hw/virtio/virtio-mmio.c
+++ b/hw/virtio/virtio-mmio.c
Instead of depending on a macro, switch to use a bus specific queue
limit.
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 12 +++-
include/hw/virtio/virtio.h | 2 --
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/virtio
unmasking handling.
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 8
hw/virtio/virtio.c | 36 ++--
include/hw/virtio/virtio-bus.h | 1 +
include/hw/virtio/virtio.h | 3 +++
4 files changed, 46
Instead of depending on marco, switch to use a bus specific queue
limit.
Cc: Alexander Graf
Cc: Richard Henderson
Cc: Christian Borntraeger
Cc: Cornelia Huck
Signed-off-by: Jason Wang
---
hw/s390x/s390-virtio-bus.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a
: Jason Wang
---
hw/char/virtio-serial-bus.c| 2 +-
hw/net/virtio-net.c| 4 ++--
hw/s390x/s390-virtio-bus.c | 1 +
hw/s390x/virtio-ccw.c | 1 +
hw/scsi/virtio-scsi.c | 4 ++--
hw/virtio/virtio-mmio.c| 1 +
hw/virtio/virtio-pci.c | 1 +
hw
On 04/17/2015 07:46 PM, Cornelia Huck wrote:
> On Fri, 17 Apr 2015 12:48:33 +0800
> Jason Wang wrote:
>
>> Instead of depending on marco, using a bus specific limit. Also make
>> it clear that the number of gsis per I/O adapter is not directly
>> depending on the n
On 04/17/2015 07:31 PM, Cornelia Huck wrote:
> On Fri, 17 Apr 2015 12:48:31 +0800
> Jason Wang wrote:
>
>> There's no need to use vector 0 for invalid virtqueue. So this patch
> s/There's no need/It's a bad idea/
>
>> changes to use VIRTIO_NO_VECTOR
On 04/17/2015 07:31 PM, Cornelia Huck wrote:
> On Fri, 17 Apr 2015 12:48:31 +0800
> Jason Wang wrote:
>
>> There's no need to use vector 0 for invalid virtqueue. So this patch
> s/There's no need/It's a bad idea/
>
>> changes to use VIRTIO_NO_VECTOR
This patches adds machine type specific instance initialization
functions. Those functions will be used by following patches to compat
class properties for legacy machine types.
Cc: Alexander Graf
Cc: qemu-...@nongnu.org
Signed-off-by: Jason Wang
---
hw/ppc/spapr.c | 23
io-pci
- limit the maximum number of virtio queues to 64 for legacy machine
types
Jason Wang (16):
virtio-net: fix the upper bound when trying to delete queues
pc: add 2.4 machine types
spapr: add machine type specific instance init function
ppc: spapr: add 2.4 machine type
monitor: replac
Virtqueue were indexed from zero, so don't delete virtqueue whose
index is n->max_queues * 2 + 1.
Cc: Michael S. Tsirkin
Cc: qemu-stable
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/ne
The following patches will limit the following things to legacy
machine type:
- maximum number of virtqueues for virtio-pci were limited to 64
Cc: Alexander Graf
Cc: qemu-...@nongnu.org
Signed-off-by: Jason Wang
---
hw/ppc/spapr.c | 31 +--
1 file changed, 29
The following patches will limit the following things to legacy
machine type:
- maximum number of virtqueues for virtio-pci were limited to 64
- auto msix bar size for virtio-net-pci were disabled by default
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Michael S. Tsirkin
Signed-off-by: Jason
: Jason Wang
Reviewed-by: Cornelia Huck
---
hw/char/virtio-serial-bus.c| 2 +-
hw/net/virtio-net.c| 4 ++--
hw/s390x/s390-virtio-bus.c | 1 +
hw/s390x/virtio-ccw.c | 1 +
hw/scsi/virtio-scsi.c | 4 ++--
hw/virtio/virtio-mmio.c| 1 +
hw/virtio
This patch replace the magic number 255, and increase it to
MAX_QUEUE_NUM which is maximum number of queues supported by a nic.
Cc: Luiz Capitulino
Signed-off-by: Jason Wang
---
monitor.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/monitor.c b
S. Tsirkin
Signed-off-by: Jason Wang
---
hw/pci/msix.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index 24de260..f8748cf 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -295,29 +295,37 @@ int msix_init_ex
255 queues.
Cc: Luiz Capitulino
Signed-off-by: Jason Wang
---
monitor.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index a039edf..2b5643d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4477,7 +4477,7 @@ void set_link_completion(ReadLineState
It's a bad idea to need to use vector 0 for invalid virtqueue. So this patch
changes to using VIRTIO_NO_VECTOR instead.
Cc: Michael S. Tsirkin
Cc: Cornelia Huck
CC: Christian Borntraeger
Cc: Richard Henderson
Cc: Alexander Graf
Signed-off-by: Jason Wang
Acked-by: Cornelia Huck
--
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-mmio.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
index 2ae6942..dbd44b6 100644
--- a/hw/virtio/virtio-mmio.c
+++ b/hw/virtio/virtio-mmio.c
Signed-off-by: Jason Wang
---
hw/s390x/s390-virtio-ccw.c | 7 +--
hw/s390x/virtio-ccw.c| 21 +
include/hw/s390x/s390_flic.h | 4 +++-
3 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index
Instead of depending on macro, switch to use a bus specific queue
limit.
Cc: Alexander Graf
Cc: Richard Henderson
Cc: Christian Borntraeger
Cc: Cornelia Huck
Signed-off-by: Jason Wang
Reviewed-by: Cornelia Huck
---
hw/s390x/s390-virtio-bus.c | 8 +---
1 file changed, 5 insertions(+), 3
unmasking handling.
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 8
hw/virtio/virtio.c | 36 ++--
include/hw/virtio/virtio-bus.h | 1 +
include/hw/virtio/virtio.h | 3 +++
4 files changed, 46
Instead of depending on a macro, switch to use a bus specific queue
limit.
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 12 +++-
include/hw/virtio/virtio.h | 2 --
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/virtio
.
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index c38f33f..7d01500 100644
--- a/hw/virtio/virtio-pci.c
+++
qemu-...@nongnu.org
Signed-off-by: Jason Wang
---
hw/i386/pc_piix.c | 5 +
hw/i386/pc_q35.c | 5 +
hw/ppc/spapr.c | 5 +
hw/virtio/virtio-pci.c | 6 +-
4 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 21
On Thu, Apr 23, 2015 at 7:24 PM, Cornelia Huck
wrote:
On Thu, 23 Apr 2015 14:21:48 +0800
Jason Wang wrote:
This patch increases the maximum number of virtqueues for pci from
64
to 513. This will allow booting a virtio-net-pci device with 256
queue
^^^
pairs on recent Linux host
On Mon, Apr 27, 2015 at 7:03 PM, Michael S. Tsirkin
wrote:
On Thu, Apr 23, 2015 at 02:21:35PM +0800, Jason Wang wrote:
The following patches will limit the following things to legacy
machine type:
- maximum number of virtqueues for virtio-pci were limited to 64
- auto msix bar size
On Mon, Apr 27, 2015 at 7:02 PM, Michael S. Tsirkin
wrote:
On Thu, Apr 23, 2015 at 02:21:48PM +0800, Jason Wang wrote:
This patch increases the maximum number of virtqueues for pci from
64
to 513. This will allow booting a virtio-net-pci device with 256
queue
pairs on recent Linux host
On Mon, Apr 27, 2015 at 7:05 PM, Michael S. Tsirkin
wrote:
On Thu, Apr 23, 2015 at 02:21:41PM +0800, Jason Wang wrote:
This patch introduces a bus specific queue limitation. It will be
useful for increasing the limit for one of the bus without
disturbing
other buses.
Cc: Michael S
On Thu, Apr 23, 2015 at 7:27 PM, Cornelia Huck
wrote:
On Thu, 23 Apr 2015 14:21:33 +0800
Jason Wang wrote:
Stress/migration test on virtio-pci, compile test on other
targets. And make check on s390x-softmmu and ppc64-softmmu.
This passes my smoke tests on the s390-ccw-virtio and s390
On Tue, Apr 28, 2015 at 1:13 PM, Michael S. Tsirkin
wrote:
On Tue, Apr 28, 2015 at 11:14:04AM +0800, Jason Wang wrote:
On Mon, Apr 27, 2015 at 7:05 PM, Michael S. Tsirkin
wrote:
>On Thu, Apr 23, 2015 at 02:21:41PM +0800, Jason Wang wrote:
>> This patch introduces a bus
On Tue, Apr 28, 2015 at 5:37 PM, Michael S. Tsirkin
wrote:
On Fri, Apr 10, 2015 at 05:33:35PM +0800, Jason Wang wrote:
Currently we allocate one vhost log per vhost device. This is sub
optimal when:
- Guest has several device with vhost as backend
- Guest has multiqueue devices
In
On Tue, Apr 28, 2015 at 6:30 PM, Michael S. Tsirkin
wrote:
On Tue, Apr 28, 2015 at 05:58:28PM +0800, Jason Wang wrote:
On Tue, Apr 28, 2015 at 5:37 PM, Michael S. Tsirkin
wrote:
>On Fri, Apr 10, 2015 at 05:33:35PM +0800, Jason Wang wrote:
>> Currently we allocate one vhos
On Wed, Apr 29, 2015 at 6:37 PM, Fam Zheng wrote:
This callback is called by main loop before polling s->fd, if it
returns
false, the fd will not be polled in this iteration.
This is redundant with checks inside read callback. After this patch,
the data will be sent to peer when it arrives.
On Thu, Apr 30, 2015 at 4:09 PM, Michael S. Tsirkin
wrote:
On Thu, Apr 30, 2015 at 04:05:09PM +0800, Jason Wang wrote:
On Tue, Apr 28, 2015 at 6:30 PM, Michael S. Tsirkin
wrote:
>On Tue, Apr 28, 2015 at 05:58:28PM +0800, Jason Wang wrote:
>> On Tue, Apr 28, 2015 a
qemu.git
eba05e922e8e7f307bc5d4104a78797e55124e97, kernel 4.1-rc4, I get the
following assert:
qemu-system-x86_64: /net/gimli/home/alwillia/Work/qemu.git/kvm-
all.c:1033: kvm_irqchip_commit_routes: Assertion `ret == 0' failed.
Bisected to:
commit 851c2a75a6e80c8aa5e713864d98cfb512e7229b
Author: Jason Wang
Da
a/Work/qemu.git/kvm-
all.c:1033: kvm_irqchip_commit_routes: Assertion `ret == 0' failed.
Bisected to:
commit 851c2a75a6e80c8aa5e713864d98cfb512e7229b
Author: Jason Wang
Date: Thu Apr 23 14:21:47 2015 +0800
virtio-pci: speedup MSI-X masking and unmasking
This
ll be allocated and
each vhost device will use the new log then drop the refcnt of old log.
- The old log will be synced and freed when reference count drops to zero.
Tested by doing scp during migration for a 2 queues virtio-net-pci.
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
Changes
irtio-pci: speedup MSI-X
masking and unmasking")
Reported-by: Alex Williamson
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 867c9d1..4f7f
On 05/27/2015 02:26 PM, Pankaj Gupta wrote:
> Ping.
>
> Can I get any suggestions on this patch.
>
> Best regards,
> Pankaj
>
>> vhostforce was added to enable vhost when
>> guest don't have MSI-X support.
>> Now, we have scenarios like DPDK in Guest which dont use
>> interrupts and still use
On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote:
> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote:
>> >
>> >
>> > On 05/27/2015 02:26 PM, Pankaj Gupta wrote:
>>> > > Ping.
>>> > >
>>> > > Can I get
On 05/28/2015 11:21 AM, Jason Wang wrote:
>
> On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote:
>> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote:
>>>>
>>>> On 05/27/2015 02:26 PM, Pankaj Gupta wrote:
>>>>>> Ping.
On 05/28/2015 02:28 PM, Michal Privoznik wrote:
> On 28.05.2015 05:36, Jason Wang wrote:
>>
>> On 05/28/2015 11:21 AM, Jason Wang wrote:
>>> On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote:
>>>> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote:
&
Fixes b0b3db79559e57db340b292621c397e7a6cdbdc5 ("vhost-net: cleanup
host notifiers at last step")
Cc: qemu-sta...@nongnu.org
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/vhost.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virti
ncrease the queue limit of virtio-pci
- limit the maximum number of virtio queues to 64 for legacy machine
types
Jason Wang (9):
virtio-net: adding all queues in .realize()
virtio: device_plugged() can fail
virtio: introduce virtio_get_num_queues()
virtio-ccw: introduce ccw specific queue
This patch introduce a virtio-s390 specific device_plugged() function
and doing the number of virtqueue validation inside.
Cc: Alexander Graf
Cc: Richard Henderson
Signed-off-by: Jason Wang
---
hw/s390x/s390-virtio-bus.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: Richard Henderson
Cc: Alexander Graf
Signed-off-by: Jason Wang
---
hw/s390x/virtio-ccw.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index aaa9833..18fc697 100644
--- a/hw/s390x
Instead of adding queues for multiqueue during feature set. This patch
did this in .realize(), this will help the following patches that
count the number of virtqueues used in .device_plugged() callback.
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c | 59
Increase the queue limit to 1024. But virtio-ccw and s390-virtio won't
support this, this is done through failing device_plugged() for those
two transports if the number of virtqueues is greater than 64.
Signed-off-by: Jason Wang
---
include/hw/virtio/virtio.h | 2 +-
1 file chang
Cc: Alexander Graf
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: Richard Henderson
Signed-off-by: Jason Wang
---
hw/s390x/s390-virtio-ccw.c | 2 +-
hw/s390x/virtio-ccw.c| 12 ++--
include/hw/s390x/s390_flic.h | 5 -
3 files changed, 11 insertions(+), 8 deletions
: Christian Borntraeger
Cc: Richard Henderson
Cc: Alexander Graf
Signed-off-by: Jason Wang
---
hw/s390x/virtio-ccw.c | 2 +-
hw/virtio/virtio-bus.c | 6 ++
hw/virtio/virtio-mmio.c| 2 +-
hw/virtio/virtio-pci.c | 2 +-
hw/virtio/virtio.c | 7
VIRTIO_PCI_QUEUE_MAX is not only used for pci, so rename it be generic.
Cc: Amit Shah
Cc: Paolo Bonzini
Signed-off-by: Jason Wang
---
hw/char/virtio-serial-bus.c | 2 +-
hw/net/virtio-net.c | 4 ++--
hw/scsi/virtio-scsi.c | 4 ++--
hw/virtio/virtio-mmio.c | 4 ++--
hw
This patch introduces virtio_get_num_queues() which iterates the vqs
array and return the number of virtqueues used by device.
Signed-off-by: Jason Wang
---
hw/virtio/virtio.c | 13 +
include/hw/virtio/virtio.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/hw
Cc: Alexander Graf
Cc: Richard Henderson
Signed-off-by: Jason Wang
---
hw/s390x/s390-virtio-bus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
index 0e35ac9..3801c73 100644
--- a/hw/s390x/s390-virtio-bus.c
On Fri, Feb 27, 2015 at 5:34 PM, Cornelia Huck
wrote:
On Fri, 27 Feb 2015 03:42:00 +0008
Jason Wang wrote:
On Thu, Feb 26, 2015 at 8:57 PM, Cornelia Huck
wrote:
> On Thu, 26 Feb 2015 15:04:38 +0800
> Jason Wang wrote:
>
>> This patch introduces a bus specific q
On Fri, Feb 27, 2015 at 5:41 PM, Cornelia Huck
wrote:
On Fri, 27 Feb 2015 03:46:25 +0008
Jason Wang wrote:
On Thu, Feb 26, 2015 at 9:02 PM, Cornelia Huck
wrote:
> On Thu, 26 Feb 2015 15:04:39 +0800
> Jason Wang wrote:
>
>> Instead of depending on marco, using
On Fri, Feb 27, 2015 at 5:49 PM, Cornelia Huck
wrote:
On Fri, 27 Feb 2015 06:42:57 +0008
Jason Wang wrote:
On Thu, Feb 26, 2015 at 9:05 PM, Cornelia Huck
wrote:
> On Thu, 26 Feb 2015 15:04:41 +0800
> Jason Wang wrote:
>
>> typedef struc
We don't validate the backend queue numbers against bus limitation,
this will easily crash qemu if it exceeds the limitation. Fixing this
by doing the validation and fail early.
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/h
Virtqueue were indexed from zero, so don't delete virtqueue whose
index is n->max_queues * 2 + 1.
Cc: Anthony Liguori
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c
Bonzini
Signed-off-by: Jason Wang
---
hw/net/virtio-net.c| 4 ++--
hw/s390x/s390-virtio-bus.c | 1 +
hw/s390x/virtio-ccw.c | 1 +
hw/scsi/virtio-scsi.c | 4 ++--
hw/virtio/virtio-mmio.c| 1 +
hw/virtio/virtio-pci.c | 1 +
hw/virtio/virtio.c
Instead of depending on marco, switch to use a bus specific queue
limit. Left is AdapterRouters->gsi[], this could be done in the future
if we want to increase s390's queue limit really.
Cc: Alexander Graf
Cc: Richard Henderson
Cc: Christian Borntraeger
Cc: Cornelia Huck
Signed-off-b
queues to 64 for legacy machine
types
Jason Wang (14):
virtio-net: validate backend queue numbers against bus limitation
virtio-net: fix the upper bound when trying to delete queues
virito: introduce bus specific queue limit
virtio-ccw: introduce ccw specific queue limit
virtio-s390
unmasking handling.
Cc: Anthony Liguori
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 8
hw/virtio/virtio.c | 32 ++--
include/hw/virtio/virtio-bus.h | 1 +
include/hw/virtio/virtio.h | 3 +++
4 files
Instead of depending on marco, using a bus specific limit.
Cc: Alexander Graf
Cc: Cornelia Huck
Cc: Christian Borntraeger
Cc: Richard Henderson
Signed-off-by: Jason Wang
---
hw/s390x/s390-virtio-ccw.c | 7 +--
hw/s390x/virtio-ccw.c| 13 +++--
include/hw/s390x
. Tsirkin
Signed-off-by: Jason Wang
---
hw/i386/pc_piix.c | 6 ++
hw/i386/pc_q35.c | 5 +
hw/virtio/virtio-pci.c | 2 +-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 38b42b0..821d44c 100644
--- a/hw/i386/pc_piix.c
.
Cc: Anthony Liguori
Cc: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/virtio/virtio-pci.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 280bba2..327a3fc 100644
--- a/hw/v
501 - 600 of 6557 matches
Mail list logo
