[Qemu-devel] [PATCH V3 13/14] pci: remove hard-coded bar size in msix_init_exclusive_bar()

2015-03-04 Thread Jason Wang
start from half of bar size. Cc: Keith Busch Cc: Kevin Wolf Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Cc: Anthony Liguori Signed-off-by: Jason Wang --- hw/block/nvme.c| 2 +- hw/misc/ivshmem.c | 2 +- hw/pci/msix.c | 18 +++--- hw/virtio/virtio-pci.c | 2

[Qemu-devel] [PATCH V3 06/14] virtio-serial-bus: switch to bus specific queue limit

2015-03-04 Thread Jason Wang
Cc: Amit Shah Signed-off-by: Jason Wang --- hw/char/virtio-serial-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 37a6f44..f280e95 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial

[Qemu-devel] [PATCH V3 08/14] virtio-pci: switch to use bus specific queue limit

2015-03-04 Thread Jason Wang
Instead of depending on a macro, switch to use a bus specific queue limit. Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 12 +++- include/hw/virtio/virtio.h | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH V3 10/14] virtio: introduce virtio_queue_get_index()

2015-03-04 Thread Jason Wang
This patch introduces a helper that can get the queue index of a VirtQueue. This is useful when traversing the list of VirtQueues. Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio.c | 5 + include/hw/virtio/virtio.h | 1 + 2 files changed

[Qemu-devel] [PATCH V3 14/14] virtio-pci: introduce auto_msix_bar_size property

2015-03-04 Thread Jason Wang
queue were associated with a specific MSI-X entry. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Anthony Liguori Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Jason Wang --- hw/i386/pc_piix.c | 4 hw/i386/pc_q35.c | 4 hw/ppc/sp

[Qemu-devel] [PATCH V3 07/14] virtio-mmio: switch to bus specific queue limit

2015-03-04 Thread Jason Wang
Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-mmio.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index ad03218..7884fb7 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw

Re: [Qemu-devel] [PATCH V3 10/14] virtio: introduce virtio_queue_get_index()

2015-03-06 Thread Jason Wang
On Thu, Mar 5, 2015 at 2:12 PM, Fam Zheng wrote: On Thu, 03/05 13:48, Jason Wang wrote: This patch introduces a helper that can get the queue index of a VirtQueue. This is useful when traversing the list of VirtQueues. Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Jason

Re: [Qemu-devel] [PATCH V3 05/14] virtio-s390: switch to bus specific queue limit

2015-03-09 Thread Jason Wang
On Fri, Mar 6, 2015 at 8:18 PM, Cornelia Huck wrote: On Thu, 5 Mar 2015 13:48:42 +0800 Jason Wang wrote: Instead of depending on marco, switch to use a bus specific queue limit. Left is AdapterRouters->gsi[], this could be done in the future if we want to increase s390's que

Re: [Qemu-devel] [PATCH V3 06/14] virtio-serial-bus: switch to bus specific queue limit

2015-03-09 Thread Jason Wang
On Fri, Mar 6, 2015 at 8:27 PM, Cornelia Huck wrote: On Thu, 5 Mar 2015 13:48:43 +0800 Jason Wang wrote: Cc: Amit Shah Signed-off-by: Jason Wang --- hw/char/virtio-serial-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/virtio-serial-bus.c b

Re: [Qemu-devel] [PATCH V3 08/14] virtio-pci: switch to use bus specific queue limit

2015-03-09 Thread Jason Wang
On Fri, Mar 6, 2015 at 8:28 PM, Cornelia Huck wrote: On Thu, 5 Mar 2015 13:48:45 +0800 Jason Wang wrote: Instead of depending on a macro, switch to use a bus specific queue limit. Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio

Re: [Qemu-devel] [PATCH V3 09/14] virtio: introduce vector to virtqueues mapping

2015-03-09 Thread Jason Wang
On Fri, Mar 6, 2015 at 8:55 PM, Cornelia Huck wrote: On Thu, 5 Mar 2015 13:48:46 +0800 Jason Wang wrote: Currently we will try to traverse all virtqueues to find a subset that using a specific vector. This is sub optimal when we will support hundreds or even thousands of virtqueues

Re: [Qemu-devel] [PATCH V3 04/14] virtio-ccw: introduce ccw specific queue limit

2015-03-09 Thread Jason Wang
On Fri, Mar 6, 2015 at 8:13 PM, Cornelia Huck wrote: On Thu, 5 Mar 2015 13:48:41 +0800 Jason Wang wrote: Instead of depending on marco, using a bus specific limit. Cc: Alexander Graf Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Signed-off-by: Jason Wang

Re: [Qemu-devel] [PATCH V3 08/14] virtio-pci: switch to use bus specific queue limit

2015-03-09 Thread Jason Wang
On Mon, Mar 9, 2015 at 4:04 PM, Cornelia Huck wrote: On Mon, 09 Mar 2015 15:32:51 +0800 Jason Wang wrote: On Fri, Mar 6, 2015 at 8:28 PM, Cornelia Huck wrote: > On Thu, 5 Mar 2015 13:48:45 +0800 > Jason Wang wrote: > >> Instead of depending on a macro, swit

Re: [Qemu-devel] [PATCH V3 00/14] Support more virtio queues

2015-03-12 Thread Jason Wang
On Thu, Mar 12, 2015 at 5:28 PM, Michael S. Tsirkin wrote: On Thu, Mar 05, 2015 at 01:48:37PM +0800, Jason Wang wrote: We current limit the max virtio queues to 64. This is not sufficient to support multiqueue deivces (e.g recent Linux support up to 256 tap queues). So this series try to

[Qemu-devel] [PATCH V2] virtio: validate the existence of handle_output before calling it

2015-03-12 Thread Jason Wang
. Cc: qemu-sta...@nongnu.org Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- Changes from V1: - check the existence of both vring.desc and handle_output in the same line - describe the reproducer in the commit log --- hw/virtio/virtio.c | 3 ++- 1 file changed, 2 insertions(+), 1 del

[Qemu-devel] [PATCH] e1000: use alias for default model

2015-09-27 Thread Jason Wang
Instead of using a new type for default model (82540em), using an alias for this to avoid bit duplication. Cc: Markus Armbruster Signed-off-by: Jason Wang --- hw/net/e1000.c | 8 +--- qdev-monitor.c | 1 + 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/net/e1000.c b/hw

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-27 Thread Jason Wang
On 09/25/2015 10:10 PM, Markus Armbruster wrote: > Jason Wang writes: > >> On 09/24/2015 07:52 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: >>> >>>> On 09/24/2015 04:41 PM, Markus Armbruster wrote: >>>>> Yang Hongyang wr

Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

2015-09-27 Thread Jason Wang
On 09/25/2015 11:07 PM, Markus Armbruster wrote: > Yang Hongyang writes: > >> On 09/24/2015 05:12 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: >>> This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solu

Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes

2015-09-27 Thread Jason Wang
On 09/25/2015 10:30 PM, Eric Blake wrote: > On 09/25/2015 02:08 AM, Yang Hongyang wrote: >> This patchset addressed Markus comment on netfilter patch >> series, most of them are comment fixes. >> >> It is based on jason's net tree: >> https://github.com/jasowang/qemu/tree/net > If that tree is no

Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes

2015-09-27 Thread Jason Wang
On 09/25/2015 11:33 PM, Markus Armbruster wrote: > Yang Hongyang writes: > >> This patchset addressed Markus comment on netfilter patch >> series, most of them are comment fixes. >> >> It is based on jason's net tree: >> https://github.com/jasowang/qemu/tree/net >> >> Signed-off-by: Yang Hongyan

Re: [Qemu-devel] [PATCH] e1000: use alias for default model

2015-09-28 Thread Jason Wang
On 09/28/2015 04:57 PM, Markus Armbruster wrote: > Jason Wang writes: > >> Instead of using a new type for default model (82540em), using an >> alias for this to avoid bit duplication. > Suggest to rephrase as > > Instead of duplicating the "e1000

Re: [Qemu-devel] Problems on vlan-based vnics!

2015-09-28 Thread Jason Wang
On 09/28/2015 07:52 PM, cauchy-love wrote: > hi stefan. >I have setup a VM on a server with two NICs (eth0 and eth1). eth0 is > connected with vlan22 and eth1 is connected with vlan33. I then added eth0.22 > to br2 and eth1.33 to br3. after that tap2 and tap3 were added to br2 and > br3

Re: [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command

2015-10-09 Thread Jason Wang
On 10/01/2015 03:00 PM, Shmulik Ladkani wrote: > Ping... > > On Fri, 18 Sep 2015 08:55:04 +0300, shmulik.ladk...@ravellosystems.com wrote: >> Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO >> command. >> >> Currently, due to lack of support, a bogus value (-1) is re

[Qemu-devel] [PULL 01/14] net/vmxnet3: Refine l2 header validation

2015-10-12 Thread Jason Wang
be dropped. Signed-off-by: Dana Rubin Signed-off-by: Shmulik Ladkani Signed-off-by: Jason Wang --- hw/net/vmxnet3.c | 4 +--- hw/net/vmxnet_tx_pkt.c | 19 --- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 04159c8.

[Qemu-devel] [PULL 02/14] vmxnet3: Support reading IMR registers on bar0

2015-10-12 Thread Jason Wang
From: Shmulik Ladkani Instead of asserting, return the actual IMR register value. This is aligned with what's returned on ESXi. Signed-off-by: Shmulik Ladkani Tested-by: Dana Rubin Signed-off-by: Jason Wang --- hw/net/vmxnet3.c | 6 +- 1 file changed, 5 insertions(+), 1 del

[Qemu-devel] [PULL 00/14] Net patches

2015-10-12 Thread Jason Wang
a Rubin (1): net/vmxnet3: Refine l2 header validation Jason Wang (1): e1000: use alias for default model Shmulik Ladkani (2): vmxnet3: Support reading IMR registers on bar0 vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command Yang Hongyang (10): vl.c: init dela

[Qemu-devel] [PULL 13/14] netfilter: add a netbuffer filter

2015-10-12 Thread Jason Wang
sorts. Usage: -netdev tap,id=bn0 -object filter-buffer,id=f0,netdev=bn0,queue=rx,interval=1000 NOTE: Interval is in microseconds, it can't be omitted currently, and can't be 0. Signed-off-by: Yang Hongyang Reviewed-by: Markus Armbruster Signed-off-by: Jason Wang --- net/Makefile.objs

[Qemu-devel] [PULL 03/14] e1000: use alias for default model

2015-10-12 Thread Jason Wang
Instead of duplicating the "e1000-82540em" device model as "e1000", make the latter an alias for the former. Cc: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: Jason Wang --- hw/net/e1000.c | 8 +--- qdev-monitor.c | 1 + 2 files changed, 2 insert

[Qemu-devel] [PULL 09/14] net/queue: introduce NetQueueDeliverFunc

2015-10-12 Thread Jason Wang
From: Yang Hongyang net/queue.c has logic to send/queue/flush packets but a qemu_deliver_packet_iov() call is hardcoded. Abstract this func so that we can use our own deliver function in netfilter. Signed-off-by: Yang Hongyang Cc: Stefan Hajnoczi Signed-off-by: Jason Wang --- include/net

[Qemu-devel] [PULL 05/14] vl.c: init delayed object after net_init_clients

2015-10-12 Thread Jason Wang
From: Yang Hongyang Init delayed object after net_init_clients, because netfilters need to be initialized after net clients initialized. Signed-off-by: Yang Hongyang Signed-off-by: Jason Wang --- vl.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/vl.c b

[Qemu-devel] [PULL 11/14] netfilter: print filter info associate with the netdev

2015-10-12 Thread Jason Wang
From: Yang Hongyang When execute "info network", print filter info also. add a info_str member to NetFilterState, store specific filters info. Signed-off-by: Yang Hongyang Signed-off-by: Jason Wang --- include/net/filter.h | 1 + net/filter.c | 20

[Qemu-devel] [PULL 06/14] init/cleanup of netfilter object

2015-10-12 Thread Jason Wang
it is useless. Signed-off-by: Yang Hongyang Reviewed-by: Markus Armbruster Signed-off-by: Jason Wang --- include/net/filter.h| 61 + include/net/net.h | 1 + include/qemu/typedefs.h | 1 + net/Makefile.objs | 1 + net/filter.c| 138

[Qemu-devel] [PULL 04/14] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command

2015-10-12 Thread Jason Wang
ned-off-by: Jason Wang --- hw/net/vmxnet3.c | 9 + hw/net/vmxnet3.h | 6 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 057f0dc..3c5e10d 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1631,6 +1631,11 @@ s

[Qemu-devel] [PULL 08/14] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-10-12 Thread Jason Wang
From: Yang Hongyang qemu_deliver_packet_iov already have the compat delivery, we can drop qemu_deliver_packet. Signed-off-by: Yang Hongyang Signed-off-by: Jason Wang --- include/net/net.h | 5 - net/net.c | 51 --- net/queue.c

[Qemu-devel] [PULL 07/14] netfilter: hook packets before net queue send

2015-10-12 Thread Jason Wang
From: Yang Hongyang Capture packets that will be sent. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth Signed-off-by: Jason Wang --- include/net/filter.h | 8 +++ net/filter.c | 17 ++ net/net.c| 66

[Qemu-devel] [PULL 12/14] net/queue: export qemu_net_queue_append_iov

2015-10-12 Thread Jason Wang
From: Yang Hongyang This will be used by buffer filter implementation later to queue packets. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth Signed-off-by: Jason Wang --- include/net/queue.h | 7 +++ net/queue.c | 12 ++-- 2 files changed, 13 insertions(+), 6

[Qemu-devel] [PULL 10/14] netfilter: add an API to pass the packet to next filter

2015-10-12 Thread Jason Wang
From: Yang Hongyang add an API qemu_netfilter_pass_to_next() to pass the packet to next filter. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth Signed-off-by: Jason Wang --- include/net/filter.h | 7 +++ net/filter.c | 58

[Qemu-devel] [PULL 14/14] tests: add test cases for netfilter object

2015-10-12 Thread Jason Wang
From: Yang Hongyang Using qtest qmp interface to implement following cases: 1) add/remove netfilter 2) add a netfilter then delete the netdev 3) add/remove more than one netfilters 4) add more than one netfilters and then delete the netdev Signed-off-by: Yang Hongyang Signed-off-by: Jason Wang

[Qemu-devel] [PULL 01/10] net: cadence_gem: Set initial MAC address

2015-10-26 Thread Jason Wang
From: Sebastian Huber Set initial MAC address to the one specified by the command line. Signed-off-by: Sebastian Huber Reviewed-by: Jason Wang Reviewed-by: Peter Crosthwaite Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/net

[Qemu-devel] [PULL 00/10] Net patches

2015-10-26 Thread Jason Wang
The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into staging (2015-10-26 13:13:38 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request fo

[Qemu-devel] [PULL 04/10] net/dump: Separate the NetClientState from the DumpState

2015-10-26 Thread Jason Wang
From: Thomas Huth With the upcoming dumping-via-netfilter patch, the DumpState should not be related to NetClientState anymore, so move the related information to a new struct called DumpNetClient. Reviewed-by: Yang Hongyang Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net

[Qemu-devel] [PULL 06/10] options: Add documentation for filter-dump

2015-10-26 Thread Jason Wang
From: Thomas Huth Add a short description for the filter-dump command line options. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- qemu-options.hx | 8 1 file changed, 8 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index edee5f4..949db7f 100644 --- a/qemu

[Qemu-devel] [PULL 02/10] net/dump: Add support for receive_iov function

2015-10-26 Thread Jason Wang
From: Thomas Huth Adding a proper receive_iov function to the net dump module. This will make it easier to support the dump filter feature for the -netdev option in later patches. Reviewed-by: Yang Hongyang Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net/dump.c | 24

[Qemu-devel] [PULL 10/10] net: free the string returned by object_get_canonical_path_component

2015-10-26 Thread Jason Wang
From: Yang Hongyang The value returned from object_get_canonical_path_component must be freed. Signed-off-by: Yang Hongyang Cc: Jason Wang Cc: Paolo Bonzini Signed-off-by: Jason Wang --- net/net.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net

[Qemu-devel] [PULL 09/10] net: make iov_to_buf take right size argument in nc_sendv_compat()

2015-10-26 Thread Jason Wang
From: Yang Hongyang We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a pointer, which is wrong. Thanks to Paolo for pointing it out. Signed-off-by: Yang Hongyang Cc: Jason Wang Cc: Paolo Bonzini Signed-off-by: Jason Wang --- net/net.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 05/10] net/dump: Provide the dumping facility as a net-filter

2015-10-26 Thread Jason Wang
From: Thomas Huth Use the net-filter infrastructure to provide the dumping functions for netdev devices, too. Reviewed-by: Yang Hongyang Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net/dump.c | 129 - vl.c | 7

[Qemu-devel] [PULL 03/10] net/dump: Rework net-dump init functions

2015-10-26 Thread Jason Wang
Hongyang Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net/dump.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/net/dump.c b/net/dump.c index aa0d45d..e6f6be0 100644 --- a/net/dump.c +++ b/net/dump.c @@ -118,13 +118,10 @@ static

[Qemu-devel] [PULL 08/10] net: Remove duplicate data from query-rx-filter on multiqueue net devices

2015-10-26 Thread Jason Wang
Yasevich Signed-off-by: Jason Wang --- net/net.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/net.c b/net/net.c index 3c68f3f..70a3576 100644 --- a/net/net.c +++ b/net/net.c @@ -1227,6 +1227,12 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name

[Qemu-devel] [PULL 07/10] vmxnet3: Do not fill stats if device is inactive

2015-10-26 Thread Jason Wang
result, guest memory gets corrupted and may lead to guest OS crashes. Fix, by not filling the stats descriptors if device is inactive. Reported-by: Leonid Shatz Acked-by: Dmitry Fleytman Signed-off-by: Dana Rubin Signed-off-by: Shmulik Ladkani Signed-off-by: Jason Wang --- hw/net/vmxnet3.c | 4

Re: [Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code

2015-10-27 Thread Jason Wang
On 10/28/2015 02:39 AM, Paolo Bonzini wrote: > Wasn't someone else going to help Jan as SLIRP comaintainer? > > Jason, perhaps you can pick up this patch in the meanwhile? > > Paolo Not familiar with slirp, but the patch looks good. Picked in https://github.com/jasowang/qemu/commits/net Thank

Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation

2015-10-27 Thread Jason Wang
On 10/27/2015 09:20 PM, Leonid Bloch wrote: > This series fixes issues with packet/octet counting in e1000's Statistic > registers, fixes a bug in the packet address filtering procedure, and > implements many MAC registers that were absent before, some Statistic > counters among them. Additionall

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-10-27 Thread Jason Wang
On 10/26/2015 01:00 AM, Leonid Bloch wrote: > Hello qemu-devel, > > This patch series is an RFC for the new networking device emulation > we're developing for QEMU. > > This new device emulates the Intel 82574 GbE Controller and works > with unmodified Intel e1000e drivers from the Linux/Windows

Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation

2015-10-27 Thread Jason Wang
On 10/28/2015 01:41 PM, Jason Wang wrote: > > On 10/27/2015 09:20 PM, Leonid Bloch wrote: >> This series fixes issues with packet/octet counting in e1000's Statistic >> registers, fixes a bug in the packet address filtering procedure, and >> implements many MAC regi

Re: [Qemu-devel] [PATCH v3 2/6] e1000: Trivial implementation of various MAC registers

2015-10-28 Thread Jason Wang
On 10/28/2015 11:31 PM, Leonid Bloch wrote: > These registers appear in Intel's specs, but were not implemented. > These registers are now implemented trivially, i.e. they are initiated > with zero values, and if they are RW, they can be written or read by the > driver, or read only if they are R

Re: [Qemu-devel] [PATCH v3 2/6] e1000: Trivial implementation of various MAC registers

2015-10-29 Thread Jason Wang
On 10/29/2015 05:33 PM, Leonid Bloch wrote: > On Thu, Oct 29, 2015 at 5:04 AM, Jason Wang wrote: >> >> On 10/28/2015 11:31 PM, Leonid Bloch wrote: >>> These registers appear in Intel's specs, but were not implemented. >>> These registers are now implemen

Re: [Qemu-devel] [PATCH v3 2/6] e1000: Trivial implementation of various MAC registers

2015-10-29 Thread Jason Wang
On 10/29/2015 06:27 PM, Leonid Bloch wrote: > On Thu, Oct 29, 2015 at 12:01 PM, Jason Wang wrote: >> >> On 10/29/2015 05:33 PM, Leonid Bloch wrote: >>> On Thu, Oct 29, 2015 at 5:04 AM, Jason Wang wrote: >>>> On 10/28/2015 11:31 PM, Leonid Bloch wrote: >

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-10-29 Thread Jason Wang
On 10/28/2015 01:44 PM, Jason Wang wrote: > > On 10/26/2015 01:00 AM, Leonid Bloch wrote: >> Hello qemu-devel, >> >> This patch series is an RFC for the new networking device emulation >> we're developing for QEMU. >> >> This new device emulates t

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-11-01 Thread Jason Wang
On 10/31/2015 01:52 PM, Dmitry Fleytman wrote: > Hello Jason, > > Thanks for reviewing. See my answers inline. > > >> On 30 Oct 2015, at 07:28 AM, Jason Wang > <mailto:jasow...@redhat.com>> wrote: >> >> >> >> On 10/28/2015 01:44 PM, Jason

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2015-11-02 Thread Jason Wang
On 11/02/2015 03:49 PM, Dmitry Fleytman wrote: > >> On 2 Nov 2015, at 05:35 AM, Jason Wang > <mailto:jasow...@redhat.com>> wrote: >> >> >> >> On 10/31/2015 01:52 PM, Dmitry Fleytman wrote: >>> Hello Jason, >>> >>> Thanks for

Re: [Qemu-devel] [PATCH v4 2/7] e1000: Add support for migrating the entire MAC registers' array

2015-11-03 Thread Jason Wang
On 11/03/2015 07:14 PM, Leonid Bloch wrote: > This patch enables the migration of the entire array of MAC registers > during live migration. The entire array is just 128 KB long, so > practically no penalty should be felt when transmitting it, over the > individual registers. But the advantages a

Re: [Qemu-devel] [PATCH v4 3/7] e1000: Trivial implementation of various MAC registers

2015-11-03 Thread Jason Wang
On 11/03/2015 07:14 PM, Leonid Bloch wrote: > These registers appear in Intel's specs, but were not implemented. > These registers are now implemented trivially, i.e. they are initiated > with zero values, and if they are RW, they can be written or read by the > driver, or read only if they are R

Re: [Qemu-devel] [PATCH v4 7/7] e1000: Implementing various counters

2015-11-03 Thread Jason Wang
On 11/03/2015 07:14 PM, Leonid Bloch wrote: > This implements the following Statistic registers (various counters) > according to Intel's specs: > > TSCTC GOTCL GOTCH GORCL GORCH MPRC BPRC RUCROC > BPTC MPTC PTC... PRC... > > Signed-off-by: Leonid Bloch > Signed-off-by: Dmitry F

Re: [Qemu-devel] [PATCH COLO-Frame v10 33/38] netfilter: Introduce an API to delete the timer of all buffer-filters

2015-11-03 Thread Jason Wang
hailiang Hi: Then you'd better explain this in commit log. Thanks > >> On 2015年11月03日 19:56, zhanghailiang wrote: >>> Signed-off-by: zhanghailiang >>> Cc: Jason Wang >>> --- >>> v10: new patch >>> --- >>> include/net/fi

Re: [Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero interval

2015-11-03 Thread Jason Wang
On 11/03/2015 08:43 PM, Yang Hongyang wrote: > Some commit message would be better. +1 > > On 2015年11月03日 19:56, zhanghailiang wrote: >> Signed-off-by: zhanghailiang >> Cc: Jason Wang > > Reviewed-by: Yang Hongyang > >> --- >> v10: new

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

2015-11-03 Thread Jason Wang
On 11/03/2015 07:56 PM, zhanghailiang wrote: > Signed-off-by: zhanghailiang > Cc: Jason Wang Commit log please. > --- > v10: new patch > --- > include/net/filter.h | 1 + > include/net/net.h| 3 ++ > n

Re: [Qemu-devel] [vhost-user BUG ?] QEMU process segfault when shutdown or reboot with vhost-user

2015-11-03 Thread Jason Wang
On 11/04/2015 10:24 AM, zhanghailiang wrote: > On 2015/11/3 22:54, Marc-André Lureau wrote: >> Hi >> >> On Tue, Nov 3, 2015 at 2:01 PM, zhanghailiang >> wrote: >>> The corresponding codes where gdb reports error are: (We have added >>> some >>> codes in net.c) >> >> Can you reproduce with unmodi

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-11-03 Thread Jason Wang
On 11/04/2015 02:49 AM, P J P wrote: > +-- On Tue, 20 Oct 2015, Jason Wang wrote --+ > | Can this survive if we had a chain like? > | A->B->A > > No, current patch wouldn't cope with it. Though I wonder if such a loop is > possible? Just wondering. Tx.link

Re: [Qemu-devel] [PATCH v4 2/7] e1000: Add support for migrating the entire MAC registers' array

2015-11-04 Thread Jason Wang
On 11/04/2015 10:48 PM, Leonid Bloch wrote: >>> >> }, >>> >> .subsections = (const VMStateDescription*[]) { >>> >> &vmstate_e1000_mit_state, >>> >> +&vmstate_e1000_full_mac_state, >>> >> +&vmstate_e1000_compat_mac_state, >>> >> NULL >>> >> } >> > >

Re: [Qemu-devel] [PATCH v4 3/7] e1000: Trivial implementation of various MAC registers

2015-11-04 Thread Jason Wang
On 11/04/2015 11:21 PM, Leonid Bloch wrote: > On Wed, Nov 4, 2015 at 4:44 AM, Jason Wang wrote: >> >> On 11/03/2015 07:14 PM, Leonid Bloch wrote: >>> These registers appear in Intel's specs, but were not implemented. >>> These registers are now implemen

Re: [Qemu-devel] [PATCH v4 7/7] e1000: Implementing various counters

2015-11-04 Thread Jason Wang
On 11/04/2015 11:44 PM, Leonid Bloch wrote: > On Wed, Nov 4, 2015 at 4:46 AM, Jason Wang wrote: >> >> On 11/03/2015 07:14 PM, Leonid Bloch wrote: >>> This implements the following Statistic registers (various counters) >>> according to Intel's specs: >

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

2015-11-05 Thread Jason Wang
On 11/05/2015 03:43 PM, zhanghailiang wrote: > Hi Jason, > > On 2015/11/4 10:56, Jason Wang wrote: >> >> >> On 11/03/2015 07:56 PM, zhanghailiang wrote: >>> Signed-off-by: zhanghailiang >>> Cc: Jason Wang >> >> Commit log please. >>

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

2015-11-05 Thread Jason Wang
On 11/05/2015 04:52 PM, Wen Congyang wrote: > On 11/05/2015 03:43 PM, zhanghailiang wrote: >> > Hi Jason, >> > >> > On 2015/11/4 10:56, Jason Wang wrote: >>> >> >>> >> >>> >> On 11/03/2015 07:56 PM, zhanghai

[Qemu-devel] [PATCH V3 3/6] KVM: add support for any length io eventfd

2015-11-06 Thread Jason Wang
Signed-off-by: Jason Wang --- include/sysemu/kvm.h | 8 kvm-all.c| 4 kvm-stub.c | 1 + 3 files changed, 13 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 4ac6176..b31f325 100644 --- a/include/sysemu/kvm.h +++ b/include/sysemu

[Qemu-devel] [PATCH V3 0/6] virtio 1.0 pci optimizations and fixes

2015-11-06 Thread Jason Wang
ould allow us to extend the future improvement without changing the core. - don't check virtio_virtqueue_needed() in virtio_extra_state_needed() - drop the ppc 2.5 machine type patch - squash Eduardo's 2.5 machine type patches into this series Jason Wang (6): virtio-pci: fix 1.0 virtqu

[Qemu-devel] [PATCH V3 1/6] virtio-pci: fix 1.0 virtqueue migration

2015-11-06 Thread Jason Wang
i for whether or not to migrate extra state. - compat the migration for 2.4 and elder machine types Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 129 + hw/virtio/virtio-pci.h | 20 --- hw/virtio/vir

[Qemu-devel] [PATCH V3 4/6] virtio-pci: use zero length mmio eventfd for 1.0 notification cap when possible

2015-11-06 Thread Jason Wang
: data with '[]' is the one whose significance is greater than 95%. Thanks Wenli Quan for the benchmarking. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virt

[Qemu-devel] [PATCH V3 2/6] memory: don't try to adjust endianness for zero length eventfd

2015-11-06 Thread Jason Wang
Kurz Signed-off-by: Jason Wang --- memory.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index c435c88..e193658 100644 --- a/memory.c +++ b/memory.c @@ -1688,7 +1688,9 @@ void memory_region_add_eventfd(MemoryRegion *mr, }; unsig

[Qemu-devel] [PATCH V3 5/6] virtio-pci: introduce pio notification capability for modern device

2015-11-06 Thread Jason Wang
Management can enable when it thinks it was needed. Benchmarks shows almost no obvious difference compared to legacy device on machines without ept. Thanks Wenli Quan for the benchmarking. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-p

[Qemu-devel] [PATCH V3 6/6] virtio-pci: unbreak queue_enable read

2015-11-06 Thread Jason Wang
Guest always get zero when reading queue_enable. This violates spec. Fixing this by setting the queue_enable to true during any guest writing and setting it to zero during reset. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 7 +++ 1 file changed, 7

Re: [Qemu-devel] [PATCH V3 1/6] virtio-pci: fix 1.0 virtqueue migration

2015-11-09 Thread Jason Wang
On 11/09/2015 08:56 PM, Cornelia Huck wrote: > On Fri, 6 Nov 2015 16:02:44 +0800 > Jason Wang wrote: > >> We don't migrate the followings fields for virtio-pci: >> >> uint32_t dfselect; >> uint32_t gfselect; >> uint32_t guest_features[2]; >>

Re: [Qemu-devel] [PATCH V3 6/6] virtio-pci: unbreak queue_enable read

2015-11-09 Thread Jason Wang
On 11/09/2015 09:14 PM, Cornelia Huck wrote: > On Fri, 6 Nov 2015 16:02:49 +0800 > Jason Wang wrote: > >> Guest always get zero when reading queue_enable. This violates >> spec. Fixing this by setting the queue_enable to true during any guest >> writing and sett

Re: [Qemu-devel] [PATCH v5 3/8] e1000: Introduced an array to control the access to the MAC registers

2015-11-09 Thread Jason Wang
On 11/09/2015 10:59 PM, Leonid Bloch wrote: > The array of uint8_t's which is introduced here, contains useful metadata > about the MAC registers: if a register should be always accessible, or if > it is accessible, but partly implemented, or if the register requires a > certain compatibility fla

Re: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation

2015-11-09 Thread Jason Wang
On 11/09/2015 10:59 PM, Leonid Bloch wrote: > This series fixes issues with packet/octet counting in e1000's Statistic > registers, fixes a bug in the packet address filtering procedure, and > implements many MAC registers that were absent before, some Statistic > counters among them. > > Besides

Re: [Qemu-devel] [POC]colo-proxy in qemu

2015-11-09 Thread Jason Wang
On 11/10/2015 01:26 PM, Tkid wrote: > Hi,all > > We are planning to reimplement colo proxy in userspace (Here is in > qemu) to > cache and compare net packets.This module is one of the important > components > of COLO project and now it is still in early stage, so any comments and > feedback are

Re: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation

2015-11-10 Thread Jason Wang
On 11/10/2015 07:39 PM, Leonid Bloch wrote: > On Tue, Nov 10, 2015 at 8:21 AM, Jason Wang wrote: >> >> On 11/09/2015 10:59 PM, Leonid Bloch wrote: >>> This series fixes issues with packet/octet counting in e1000's Statistic >>> registers, fixes a bug in

Re: [Qemu-devel] [PATCH] e1000: eliminate infinite loops on out-of-bounds transfer start

2016-01-21 Thread Jason Wang
tend the existing failsafes with the > above condition. > > Cc: "Michael S. Tsirkin" > Cc: Petr Matousek > Cc: Stefano Stabellini > Cc: Prasad Pandit > Cc: Michael Roth > Cc: Jason Wang > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1296044 > Signed-o

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-21 Thread Jason Wang
On 01/20/2016 06:30 PM, Wen Congyang wrote: > On 01/20/2016 06:19 PM, Jason Wang wrote: >> > >> > >> > On 01/20/2016 06:01 PM, Wen Congyang wrote: >>> >> On 01/20/2016 02:54 PM, Jason Wang wrote: >>>> >>> &g

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-21 Thread Jason Wang
On 01/20/2016 06:34 PM, Wen Congyang wrote: > On 01/20/2016 06:03 PM, Jason Wang wrote: >> >> On 01/20/2016 05:49 PM, Wen Congyang wrote: >>> On 01/20/2016 05:20 PM, Jason Wang wrote: >>>> On 01/20/2016 03:44 PM, Wen Congyang wrote: >>>>&

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-21 Thread Jason Wang
On 01/22/2016 11:28 AM, Wen Congyang wrote: > On 01/22/2016 11:15 AM, Jason Wang wrote: >> >> On 01/20/2016 06:30 PM, Wen Congyang wrote: >>> On 01/20/2016 06:19 PM, Jason Wang wrote: >>>>> >>>>> On 01/20/2016 06:01 PM, Wen Congyang w

Re: [Qemu-devel] [PATCH] e1000: eliminate infinite loops on out-of-bounds transfer start

2016-01-21 Thread Jason Wang
On 01/22/2016 02:11 PM, Michael Tokarev wrote: > 22.01.2016 06:09, Jason Wang wrote: >> On 01/19/2016 09:17 PM, Laszlo Ersek wrote: >>> The start_xmit() and e1000_receive_iov() functions implement DMA transfers >>> iterating over a set of descriptors that the guest&

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-21 Thread Jason Wang
On 01/22/2016 01:56 PM, Wen Congyang wrote: > On 01/22/2016 01:41 PM, Jason Wang wrote: >> > >> > >> > On 01/22/2016 11:28 AM, Wen Congyang wrote: >>> >> On 01/22/2016 11:15 AM, Jason Wang wrote: >>>> >>> >>>> >

Re: [Qemu-devel] [PATCH] net: set endianness on all backend devices

2016-01-21 Thread Jason Wang
t;> >> r = k->set_guest_notifiers(qbus->parent, total_queues * 2, true); >> @@ -343,8 +341,9 @@ err_start: >> fflush(stderr); >> } >> err_endian: >> -vhost_net_set_vnet_endian(dev, ncs[0].peer, false); >> -err: >> +while (--j >= 0) { >> +vhost_net_set_vnet_endian(dev, ncs[j].peer, false); >> +} >> return r; >> } >> Reviewed-by: Jason Wang

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-21 Thread Jason Wang
On 01/22/2016 02:47 PM, Wen Congyang wrote: > On 01/22/2016 02:21 PM, Jason Wang wrote: >> >> On 01/22/2016 01:56 PM, Wen Congyang wrote: >>> On 01/22/2016 01:41 PM, Jason Wang wrote: >>>>> >>>>> On 01/22/2016 11:28 AM, Wen Congyang w

Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter

2016-01-24 Thread Jason Wang
On 01/22/2016 06:07 PM, Daniel P. Berrange wrote: > On Fri, Jan 22, 2016 at 04:36:44PM +0800, zhanghailiang wrote: >> This series is a prerequisite for COLO, here we add each netdev >> a default buffer filter, it is disabled by default, and has >> no side effect for delivering packets in net laye

Re: [Qemu-devel] [PATCH] net: walk through filters reversely if traffic is outgress

2016-01-24 Thread Jason Wang
On 01/22/2016 04:11 PM, Li Zhijian wrote: > Previously, if the netdev has more than one filters, the ingress > or outgress traffic pass the filter in the same order. this patch > is to make the outgress pass the filter in a reverse order Need a description why we need this. > > Signed-off-by: W

Re: [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network'

2016-01-24 Thread Jason Wang
On 01/22/2016 04:36 PM, zhanghailiang wrote: > The properties of netfilter object could be changed by 'qom-set' > command, but the output of 'info network' command is not updated, > because it got the old information through nf->info_str, it will > not be updated while we change the value of netf

Re: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets

2016-01-24 Thread Jason Wang
On 01/22/2016 05:32 PM, Wen Congyang wrote: > On 01/22/2016 04:36 PM, zhanghailiang wrote: >> If the filter is disabled, don't go through it. >> >> Signed-off-by: zhanghailiang >> --- >> include/net/filter.h | 5 + >> net/net.c| 4 >> 2 files changed, 9 insertions(+) >> >>

Re: [Qemu-devel] [PATCH RFC 2/7] net/filter: Add a 'status' property for filter object

2016-01-24 Thread Jason Wang
On 01/22/2016 04:36 PM, zhanghailiang wrote: > With this property, users can control if this filter is 'enable' > or 'disable'. The default behavior for filter is enabled. > > Signed-off-by: zhanghailiang Let's squash patch 3 into this for a complete implementation of 'status'. > --- > includ

Re: [Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev

2016-01-24 Thread Jason Wang
On 01/22/2016 04:36 PM, zhanghailiang wrote: > We add each netdev a default buffer filter, which the name is > 'nop', and the default buffer filter is disabled, so it has > no side effect for packets delivering in qemu net layer. > > The default buffer filter can be used by COLO or Micro-checkpoi

Re: [Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval

2016-01-24 Thread Jason Wang
On 01/22/2016 04:36 PM, zhanghailiang wrote: > We may want to accept zero interval when VM FT solutions like MC > or COLO use this filter to release packets on demand. > > Signed-off-by: zhanghailiang > Reviewed-by: Yang Hongyang > --- > net/filter-buffer.c | 10 -- > 1 file changed, 1

<    2   3   4   5   6   7   8   9   10   11   >