On Tue, May 21, 2013 at 11:33:57AM -0400, Tomoki Sekiyama wrote:
Add VSS requester functions for to qemu-ga.
This provides facility to request VSS service in Windows guest to quisce
applications and filesystems. This function is only supported in Windows
2003 or later. In older guests, this
On Thu, May 23, 2013 at 06:36:35PM +, Tomoki Sekiyama wrote:
On 5/23/13 8:22 , Stefan Hajnoczi stefa...@gmail.com wrote:
On Tue, May 21, 2013 at 11:33:52AM -0400, Tomoki Sekiyama wrote:
Implements a basic stub of software VSS provider. Currently, this
modules
only provides a relay
On Tue, May 21, 2013 at 11:34:08AM -0400, Tomoki Sekiyama wrote:
To build type library (.tlb) for qga-provider.dll from COM IDL (.idl),
MIDL in VisualC++ and stdole2.tlb in Windows SDK are required.
This patch adds pre-compiled .tlb file in the repository in order to
enable cross-compile
error, the stats for the offending
commit will be shown.
Signed-off-by: Jeff Cody jc...@redhat.com
---
scripts/git-compile-check | 202 ++
1 file changed, 202 insertions(+)
create mode 100755 scripts/git-compile-check
diff --git a/scripts/git-compile
On Thu, Jun 06, 2013 at 10:58:25AM +0200, Laszlo Ersek wrote:
comments below
On 05/31/13 18:39, Jeff Cody wrote:
+usage() {
+echo
+echo $0 [OPTIONS]
+echo $desc
+echo
+echo OPTIONS:
+echo -r git range
+optional; default is '$range
On Sat, Jun 08, 2013 at 02:36:33AM +1000, Peter Crosthwaite wrote:
Hi Jeff,
On Sat, Jun 1, 2013 at 2:39 AM, Jeff Cody jc...@redhat.com wrote:
This is a git script that will iterate through every commit in a
specified range, and perform a configure and make. The intention of
this script
On Fri, Jun 07, 2013 at 11:51:36AM -0500, Anthony Liguori wrote:
Laszlo Ersek ler...@redhat.com writes:
On 06/07/13 16:44, Jeff Cody wrote:
Thanks. I can either do the above changes for a v2, or as follow on
patches.
Whichever is easier for you, certainly! I'm fine with the script
On Mon, Sep 30, 2013 at 01:36:55PM +0200, Benoît Canet wrote:
This field is used by blkverify to disable external snapshots creation.
I will also be used by block filters like quorum to disable external snapshots
creation.
Signed-off-by: Benoit Canet ben...@irqsave.net
Reviewed-by: Jeff
On Tue, Oct 01, 2013 at 01:31:36PM +0200, Stefan Hajnoczi wrote:
On Wed, Sep 25, 2013 at 05:02:53PM -0400, Jeff Cody wrote:
+static int vhdx_log_read_desc(BlockDriverState *bs, BDRVVHDXState *s,
+ VHDXLogEntries *log, VHDXLogDescEntries
**buffer
On Tue, Oct 01, 2013 at 01:42:18PM +0200, Stefan Hajnoczi wrote:
On Wed, Sep 25, 2013 at 05:02:54PM -0400, Jeff Cody wrote:
+/* Check for region overlaps inside the VHDX image */
+static int vhdx_region_check(BDRVVHDXState *s, uint64_t start, uint64_t
length)
+{
+int ret = 0
On Tue, Oct 01, 2013 at 03:04:15PM +0200, Stefan Hajnoczi wrote:
On Wed, Sep 25, 2013 at 05:02:55PM -0400, Jeff Cody wrote:
+static int vhdx_log_write(BlockDriverState *bs, BDRVVHDXState *s,
+ void *data, uint32_t length, uint64_t offset)
+{
+int ret = 0
On Tue, Oct 01, 2013 at 03:29:17PM +0200, Stefan Hajnoczi wrote:
On Wed, Sep 25, 2013 at 05:02:56PM -0400, Jeff Cody wrote:
@@ -1070,7 +1070,43 @@ exit:
return ret;
}
+/*
+ * Allocate a new payload block at the end of the file.
+ *
+ * Allocation will happen at 1MB
On Tue, Oct 01, 2013 at 03:41:04PM +0200, Stefan Hajnoczi wrote:
On Wed, Sep 25, 2013 at 05:02:45PM -0400, Jeff Cody wrote:
This patch series contains the initial VHDX log parsing, replay,
write support, and image creation.
=== v6 changes ===
https://github.com/codyprime/qemu-kvm
This blocks migration for VHDX image files, until the
functionality can be supported.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/vhdx.c b/block/vhdx.c
index b8aa49c..6cb0412 100644
--- a/block/vhdx.c
+++ b
entry must match the file log GUID in order to be valid (along
with other criteria). Once we have flushed all valid log entries, we
marked the file log GUID to be zero, which indicates a buffer with no
valid entries.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2 +-
block
In preparation for vhdx_create(), move more endian translation
functions out to vhdx-endian.c.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx-endian.c | 75 +
block/vhdx.c| 20 +++---
block/vhdx.h| 9
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 241703a..3f06ce3 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -778,6 +778,17 @@ exit:
}
+static void
Allow tracking of first file write in the VHDX image, as well as
the ability to update the GUID in the header. This is in preparation
for log support.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 30 --
block/vhdx.h | 6 ++
2 files changed, 30
This is preperation for vhdx_create(). The ability to write headers,
and calculate the number of BAT entries will be needed within the
create() functions, so move this relevant code into helper functions.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 121
wording in comments,
and those have been fixed up as well.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.h b/block/vhdx.h
index 15486c7..f222d18 100644
--- a/block/vhdx.h
+++ b/block/vhdx.h
@@ -58,7
about, but are not required).
This adds the capability to register a region for later checking, and
to check against registered regions for any overlap.
Also, if neither the BAT or Metadata region tables are found, return
error.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 82
and updated
in the header.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx-log.c | 279 +++
block/vhdx.h | 3 +
2 files changed, 282 insertions(+)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 0284729..e9a0b4b 100644
) |(H)|
| Journal Log | BAT / Bitmap | Metadata | data ..
| | | |
. ~ --- ~ ~ ~ ---.
1MB (var.) (var.) (var.)
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c
file,
post log replay, matched.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/065 | 67 +
tests/qemu-iotests/065.out | 8 +++
tests/qemu-iotests/group | 1 +
.../sample_images
In preparation for VHDX log support, move these structures to the
header.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 52
block/vhdx.h | 48
2 files changed, 48 insertions
This adds support for writing to VHDX image files, using coroutines.
Writes into the BAT table goes through the VHDX log. Currently, BAT
table writes occur when expanding a dynamic VHDX file, and allocating a
new BAT entry.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 196
VHDX: --enable-vhdx, --disable-vhdx
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2 +-
block/vhdx.c| 161 +++-
block/vhdx.h| 14 -
configure | 24
4 files changed, 196 insertions
This removes the IMGFMT_GENERIC blocker for read-only, so existing
iotests run read/write tests for vhdx images created by qemu-img (e.g.
tests 001, 002, 003).
In addition, this updates the sample image test for the Hyper-V
created image, to verify we can write it as well.
Signed-off-by: Jeff
to a true uint64_t file offset.
This replaces those steps with just a bit mask, to get rid of the lower
20 bits instead.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 6 ++
block/vhdx.h | 1 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block
Jeff Cody (19):
block: vhdx - minor comments and typo correction.
block: vhdx - add header update capability.
block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to
header.
block: vhdx - log support struct and defines
block: vhdx - break endian translation functions out
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 6 --
block/vhdx.h | 6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 6cb0412
The non-global option output is suppresed in _make_test_img() for
output verification in the 0?? tests. This adds suppression for
the vhdx-unique options as well. This allows check -vhdx to run
successfully.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/common.rc | 4 +++-
1
This adds some magic number defines, and internal structure definitions
for VHDX log replay support. The struct VHDXLogEntries does not reflect
an on-disk data structure, and thus does not need to be packed.
Some minor code style fixes are applied as well.
Signed-off-by: Jeff Cody jc
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2
On Sat, Oct 12, 2013 at 02:05:45PM +0800, Fam Zheng wrote:
There is only one failure point: bdrv_change_backing_file in this
function, so we can drop the qlist and try to change the backing file
before deleting anything.
This way bdrv_drop_intermediate is simplified while keeping the
...@redhat.com
+S: Supported
+F: block/vmdk.c
+
+RBD
+M: Josh Durgin josh.dur...@dreamhost.com
+S: Supported
+F: block/rbd.c
+
+Sheepdog
+M: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
+S: Supported
+F: block/sheepdog.c
+
+VHDX
+M: Jeff Cody jc...@redhat.com
+S: Supported
+F: block
On Tue, Oct 15, 2013 at 03:25:00PM +0800, Fam Zheng wrote:
There is only one failure point: bdrv_change_backing_file in this
function, so we can drop the qlist and try to change the backing file
before deleting anything.
This way bdrv_drop_intermediate is simplified while keeping the
://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v2-upstream
The latest vhdx work (including anything beyond these patches, such as
backing/parent file support) can be found at:
https://github.com/codyprime/qemu-kvm-jtc/tree/jtc-vhdx-latest
Jeff Cody (19):
block: vhdx - minor comments and typo
VHDX: --enable-vhdx, --disable-vhdx
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2 +-
block/vhdx.c| 161 +++-
block/vhdx.h| 14 -
configure | 24
4 files changed, 196 insertions
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 6 --
block/vhdx.h | 6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 6cb0412
Allow tracking of first file write in the VHDX image, as well as
the ability to update the GUID in the header. This is in preparation
for log support.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 30 --
block/vhdx.h | 6 ++
2 files changed, 30
In preparation for VHDX log support, move these structures to the
header.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 52
block/vhdx.h | 48
2 files changed, 48 insertions
This adds some magic number defines, and internal structure definitions
for VHDX log replay support. The struct VHDXLogEntries does not reflect
an on-disk data structure, and thus does not need to be packed.
Some minor code style fixes are applied as well.
Signed-off-by: Jeff Cody jc
entry must match the file log GUID in order to be valid (along
with other criteria). Once we have flushed all valid log entries, we
marked the file log GUID to be zero, which indicates a buffer with no
valid entries.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2 +-
block
and updated
in the header.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx-log.c | 282 +++
block/vhdx.h | 3 +
2 files changed, 285 insertions(+)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 0284729..ee5583c 100644
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2
This is preperation for vhdx_create(). The ability to write headers,
and calculate the number of BAT entries will be needed within the
create() functions, so move this relevant code into helper functions.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 121
) |(H)|
| Journal Log | BAT / Bitmap | Metadata | data ..
| | | |
. ~ --- ~ ~ ~ ---.
1MB (var.) (var.) (var.)
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c
In preparation for vhdx_create(), move more endian translation
functions out to vhdx-endian.c.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx-endian.c | 75 +
block/vhdx.c| 20 +++---
block/vhdx.h| 9
file,
post log replay, matched.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/068 | 67 +
tests/qemu-iotests/068.out | 8 +++
tests/qemu-iotests/group | 1 +
.../sample_images
to a true uint64_t file offset.
This replaces those steps with just a bit mask, to get rid of the lower
20 bits instead.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 6 ++
block/vhdx.h | 1 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block
This removes the IMGFMT_GENERIC blocker for read-only, so existing
iotests run read/write tests for vhdx images created by qemu-img (e.g.
tests 001, 002, 003).
In addition, this updates the sample image test for the Hyper-V
created image, to verify we can write it as well.
Signed-off-by: Jeff
wording in comments,
and those have been fixed up as well.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.h b/block/vhdx.h
index 15486c7..f222d18 100644
--- a/block/vhdx.h
+++ b/block/vhdx.h
@@ -58,7
The non-global option output is suppresed in _make_test_img() for
output verification in the 0?? tests. This adds suppression for
the vhdx-unique options as well. This allows check -vhdx to run
successfully.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/common.rc | 5
This adds support for writing to VHDX image files, using coroutines.
Writes into the BAT table goes through the VHDX log. Currently, BAT
table writes occur when expanding a dynamic VHDX file, and allocating a
new BAT entry.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 212
about, but are not required).
This adds the capability to register a region for later checking, and
to check against registered regions for any overlap.
Also, if neither the BAT or Metadata region tables are found, return
error.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 82
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 241703a..3f06ce3 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -778,6 +778,17 @@ exit:
}
+static void
to pathnames with spaces, and
are not addressed in this series: 059, 067.
Jeff Cody (7):
block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests
block: qemu-iotests, fix _make_test_img() to work with spaced
pathnames
block: qemu-iotests, add quotes to $TEST_IMG.base usage in 017
block
There were still instances of $TEST_IMG not being properly quoted.
This was in the usage of a string built up for a 'for' loop; modify
the loop so we can quote $TEST_IMG properly.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/019 | 6 +++---
1 file changed, 3 insertions(+), 3
_make_test_img() currently works with spaced pathnames only when not
specifying a backing file. This fixes it so that the backing file
argument is properly quoted.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/common.rc | 13 +++--
1 file changed, 11 insertions(+), 2
$TEST_IMG.base is used unquoted. Add quotes so that pathnames with
spaces are supported.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/017 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/017 b/tests/qemu-iotests/017
index 45f2c0b..aba3faf
Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/039 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
index f85b4ce..8bade92 100755
There were still a couple of instances of unquoted usage of
$TEST_IMG and $TEST_IMG.orig. Quoted these so they will not fail
on pathnames with spaces in them.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/051 | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
When creating images with backing files in the test, the backing
file argument was not quoted properly. This caused the test to fail
when run from a pathname with a space. Pass the backing argument in
with the -b option to _make_test_img, so it can be properly quoted.
Signed-off-by: Jeff Cody
The usage of $TEST_IMG was not properly quoted everywhere in
common.pattern.
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests/common.pattern | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/common.pattern
b/tests/qemu-iotests
On Fri, Nov 01, 2013 at 06:04:19AM +0100, Philipp Hahn wrote:
Hello,
sorry for high-jacking this thread, but I have a questing regarding VHD
(without the X): Xen-4.3 switched to upstream QEMUs support for VHD. The
dropped their own VHD implementation in blktap2, which supported backing
On Thu, Oct 31, 2013 at 02:10:48PM +0100, Stefan Hajnoczi wrote:
On Wed, Oct 30, 2013 at 10:44:37AM -0400, Jeff Cody wrote:
This patch series contains the initial VHDX log parsing, replay,
write support, and image creation.
=== v8 changes ===
https://github.com/codyprime/qemu-kvm-jtc
On Thu, Aug 22, 2013 at 11:29:03AM +0200, Stefan Hajnoczi wrote:
Print a warning when opening a file O_DIRECT fails with EINVAL. This
saves users a lot of time trying to figure out the EINVAL error, which
is typical when attempting to open a file O_DIRECT on Linux tmpfs.
Reported-by: Deepak
The header struct VdiHeader is an on-disk structure for the image
format, and as such should be packed.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vdi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vdi.c b/block/vdi.c
index dcbc27c..f8bdc92 100644
.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vpc.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index db61274..5daca43 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -46,7 +46,7 @@ enum vhd_type {
#define
QCowHeader and QCowExtension are structs that reside in the on-disk
image format, and are read and written directly via bdrv_pread()/write(),
and as such should be packed to avoid any unintentional struct padding.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/qcow2.c | 2 +-
block/qcow2.h
QEDHeader is read, and written, directly from on-disk images
via bdrv_pread()/write(). To avoid any unintentional padding,
these structs should be packed.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/qed.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qed.h b
cow_header_v2 is read and written directly from the image file
with bdrv_pread()/bdrv_pwrite(), and as such should be packed to
avoid unintentional padding.
Also change struct cow_header_v2 to a typedef, and some minor
code style changes to keep checkpatch.pl happy.
Signed-off-by: Jeff Cody jc
ensued, to keep checkpatch.pl happy)
Jeff Cody (5):
block: vdi - use QEMU_PACKED for on-disk structures
block: vpc - use QEMU_PACKED for on-disk structures
block: qcow2 - used QEMU_PACKED for on-disk structures
block: cow - used QEMU_PACKED for on-disk structures
block: qed - use QEMU_PACKED
This provides:
Patch 1/2: A basic framework for using sample image files. This is intended
to be sample images created with the image format native tool; e.g.
a VHDX image created with Hyper-V.
Patch 2/2: VHDX read test on a sample image created with Hyper-V.
Jeff
boundary)
The pattern 0x96 exists from 33MB-66MB (past another block boundary,
and leaving a partial blank block)
From 66MB-1024MB, all reads should return 0.
Although 1GB dynamic image with 66MB of data, the bzip2'ed image
file size is only 874 bytes.
Signed-off-by: Jeff Cody jc...@redhat.com
.
Image files should be compressed with bzip2.
To use a sample image from a bash script, the _use_sample_img function
will copy and decompress the image into $TEST_DIR, and set $TEST_IMG to
be the decompressed sample image copy. To cleanup, call
_cleanup_test_img as normal.
Signed-off-by: Jeff Cody jc
On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote:
On 09/19/2013 11:43 AM, Jeff Cody wrote:
cow_header_v2 is read and written directly from the image file
with bdrv_pread()/bdrv_pwrite(), and as such should be packed to
avoid unintentional padding.
Also change struct
On Fri, Sep 20, 2013 at 11:18:14AM +0200, Kevin Wolf wrote:
Am 20.09.2013 um 11:10 hat Alex Bennée geschrieben:
jc...@redhat.com writes:
This adds the VHDX format to the qemu-iotests format, and adds
a read test. The test reads from an existing sample image, that
was created
On Fri, Sep 20, 2013 at 02:32:26PM +0200, Stefan Hajnoczi wrote:
On Thu, Sep 19, 2013 at 11:48:42PM -0400, Jeff Cody wrote:
For image formats that are not QEMU native, but supported for
compatibility, it is useful to verify that an image created with
the 'gold standard' native tool can
On Fri, Sep 20, 2013 at 06:46:56AM -0600, Eric Blake wrote:
On 09/19/2013 09:48 PM, Jeff Cody wrote:
For image formats that are not QEMU native, but supported for
compatibility, it is useful to verify that an image created with
the 'gold standard' native tool can be read / written
.
Image files should be compressed with bzip2.
To use a sample image from a bash script, the _use_sample_img function
will copy and decompress the image into $TEST_DIR, and set $TEST_IMG to
be the decompressed sample image copy. To cleanup, call
_cleanup_test_img as normal.
Signed-off-by: Jeff Cody jc
boundary)
The pattern 0x96 exists from 33MB-66MB (past another block boundary,
and leaving a partial blank block)
From 66MB-1024MB, all reads should return 0.
Although 1GB dynamic image with 66MB of data, the bzip2'ed image
file size is only 874 bytes.
Signed-off-by: Jeff Cody jc...@redhat.com
read test on a sample image created with Hyper-V.
Patch 3/3: Quote around usage of $TEST_IMG and $TEST_DIR, so that pathnames
and filenames with spaces can safely be used.
Jeff Cody (3):
block: qemu-iotests - add basic ability to use binary sample images
block: qemu-iotests for vhdx
On Mon, Sep 23, 2013 at 02:45:13PM +0200, Stefan Hajnoczi wrote:
On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote:
diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043
index 478773d..ae7cf27 100755
--- a/tests/qemu-iotests/043
+++ b/tests/qemu-iotests/043
@@ -31,7 +31,7
that pathnames
and filenames with spaces can safely be used.
Jeff Cody (3):
block: qemu-iotests - add basic ability to use binary sample images
block: qemu-iotests for vhdx, read sample dynamic image
block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage
tests/qemu-iotests/001
boundary)
The pattern 0x96 exists from 33MB-66MB (past another block boundary,
and leaving a partial blank block)
From 66MB-1024MB, all reads should return 0.
Although 1GB dynamic image with 66MB of data, the bzip2'ed image
file size is only 874 bytes.
Signed-off-by: Jeff Cody jc...@redhat.com
.
Image files should be compressed with bzip2.
To use a sample image from a bash script, the _use_sample_img function
will copy and decompress the image into $TEST_DIR, and set $TEST_IMG to
be the decompressed sample image copy. To cleanup, call
_cleanup_test_img as normal.
Signed-off-by: Jeff Cody jc
On Fri, Sep 20, 2013 at 08:23:54AM +0200, Markus Armbruster wrote:
Jeff Cody jc...@redhat.com writes:
On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote:
On 09/19/2013 11:43 AM, Jeff Cody wrote:
cow_header_v2 is read and written directly from the image file
have ensued, to keep checkpatch.pl happy)
Jeff Cody (4):
block: vdi - use QEMU_PACKED for on-disk structures
block: vpc - use QEMU_PACKED for on-disk structures
block: qcow2 - used QEMU_PACKED for on-disk structures
block: qed - use QEMU_PACKED for on-disk structures
block/qcow2.c | 2
The header struct VdiHeader is an on-disk structure for the image
format, and as such should be packed.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vdi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vdi.c b/block/vdi.c
index dcbc27c..b6ec002 100644
.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vpc.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index db61274..b5dca39 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -46,7 +46,7 @@ enum vhd_type {
#define
QCowHeader and QCowExtension are structs that reside in the on-disk
image format, and are read and written directly via bdrv_pread()/write(),
and as such should be packed to avoid any unintentional struct padding.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/qcow2.c | 2 +-
block/qcow2.h
QEDHeader is read, and written, directly from on-disk images
via bdrv_pread()/write(). To avoid any unintentional padding,
these structs should be packed.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/qed.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qed.h b
On Wed, Sep 25, 2013 at 07:25:20PM +0200, Kevin Wolf wrote:
Am 25.09.2013 um 17:12 hat Jeff Cody geschrieben:
On Fri, Sep 20, 2013 at 08:23:54AM +0200, Markus Armbruster wrote:
Jeff Cody jc...@redhat.com writes:
On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.c | 6 --
block/vhdx.h | 6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index b8aa49c
, such as
backing/parent file support) can be found at:
https://github.com/codyprime/qemu-kvm-jtc/tree/jtc-vhdx-latest
Jeff Cody (20):
block: vhdx - minor comments and typo correction.
block: vhdx - add header update capability.
block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2
This adds some magic number defines, and internal structure definitions
for VHDX log replay support. The struct VHDXLogEntries does not reflect
an on-disk data structure, and thus does not need to be packed.
Some minor code style fixes are applied as well.
Signed-off-by: Jeff Cody jc
VHDX: --enable-vhdx, --disable-vhdx
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/Makefile.objs | 2 +-
block/vhdx.c| 161 +++-
block/vhdx.h| 14 -
configure | 24
4 files changed, 196 insertions
1 - 100 of 2383 matches
Mail list logo
