Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status

; > Commit 4eae2a657d is doing the right thing, but >> > > > > > > 's->stats_vq_elem' >> > > > > > > should be treated as part of balloon device state and migrated >> > > > > > > to destination if it's not NULL to make

Re: [Qemu-devel] [PATCH trivial] Remove unused function declarations

On Mon, Jun 13, 2016 at 4:20 PM, Ladi Prosek <lpro...@redhat.com> wrote: > Unused function declarations were found using a simple gcc plugin and > manually verified by grepping the sources. > > Signed-off-by: Ladi Prosek <lpro...@redhat.com> > --- > Posting as one t

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

t; status. >> > >> > Signed-off-by: Liang Li <liang.z...@intel.com> >> > Cc: Michael S. Tsirkin <m...@redhat.com> >> > Cc: Ladi Prosek <lpro...@redhat.com> >> > Cc: Paolo Bonzini <pbonz...@redhat.com> >> > --- >> >

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

n, > and the check in the function 'balloon_stats_poll_cb()' will > prevent the 'virtio_notify()' from executing. So guest will not > update the memory status. > > Signed-off-by: Liang Li <liang.z...@intel.com> > Cc: Michael S. Tsirkin <m...@redhat.com> > Cc: Ladi Pro

[Qemu-devel] [PATCH trivial] Remove unused function declarations

Unused function declarations were found using a simple gcc plugin and manually verified by grepping the sources. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- Posting as one trivial patch because no domain specific knowledge is required to verify correctness. block/q

[Qemu-devel] ipxe-virtio subtree announcement

Hi all, Just a quick announcement that there's a new iPXE subtree at https://github.com/ladipro/ipxe-virtio focused on Virtio networking and related areas. The plan is to be sending regular pull requests to ipxe/ipxe with reviewed patches. Any and all Virtio contributions are welcome and will be

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 6:04 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, May 05, 2016 at 05:27:03PM +0200, Ladi Prosek wrote: >> On Thu, May 5, 2016 at 5:20 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Thu, May 05, 2016 at 05:15:01PM +0200, L

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 5:20 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, May 05, 2016 at 05:15:01PM +0200, Ladi Prosek wrote: >> On Thu, May 5, 2016 at 5:02 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Thu, May 05, 2016 at 04:59:13PM +0200, L

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 5:02 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, May 05, 2016 at 04:59:13PM +0200, Ladi Prosek wrote: >> On Thu, May 5, 2016 at 3:36 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Thu, May 05, 2016 at 11:13

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

On Thu, May 5, 2016 at 3:36 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, May 05, 2016 at 11:13:37AM +0200, Ladi Prosek wrote: >> There is a discrepancy between dataplane and no-dataplane virtio >> behavior with respect to the ISR status register and MSI-X >>

[Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

code path. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/virtio/virtio.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 08275a9..4053313 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -

Re: [Qemu-devel] [PULL v2 8/9] input-linux: refine mouse detection

On Wed, Apr 13, 2016 at 5:45 PM, Gerd Hoffmann wrote: > Read absolute and relative axis information, only classify > devices as mouse/tablet in case the x axis is present. I, too, had to come up with a heuristic to classify input devices in my guest driver and what I ended up

Re: [Qemu-devel] [PATCH] virtio-input: support absolute axis config in pass-through

On Wed, Apr 13, 2016 at 5:45 PM, Gerd Hoffmann <kra...@redhat.com> wrote: > On Mi, 2016-04-13 at 16:43 +0200, Ladi Prosek wrote: >> VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input >> devices. This patch follows the existing design and pre-fetches the >&

[Qemu-devel] [PATCH] virtio-input: support absolute axis config in pass-through

VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input devices. This patch follows the existing design and pre-fetches the config for all absolute axes using EVIOCGABS at realize time. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/input/virtio-input-host.c

[Qemu-devel] [PATCH] virtio-input: fix emulated tablet axis ranges

The reported maximum was wrong. The X and Y coordinates are 0-based so if size is 8000 maximum must be 7FFF. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/input/virtio-input-hid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/virtio-input-hid.

Re: [Qemu-devel] [PATCH] add 1394 OHCI device

;> -device ohci-1394,chardev=serial10,idserial10 >> >> Results: >> I've successfully connected to the Target VM using WindbgX64 and ran basic >> debugging functions such as "Break" and "stack trace". >> Moreover I've successfully viewed li

[Qemu-devel] [PATCH v2] virtio-input: implement pass-through evdev writes

The write path for pass-through devices, commonly used for controlling keyboard LEDs via EV_LED, was not implemented. This commit adds the necessary plumbing to connect the status virtio queue to the host evdev file descriptor. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- v1

Re: [Qemu-devel] [PATCH] virtio-input: implement pass-through evdev writes

On Fri, Apr 1, 2016 at 12:20 PM, Gerd Hoffmann <kra...@redhat.com> wrote: > On Fr, 2016-04-01 at 11:31 +0200, Ladi Prosek wrote: >> The write path for pass-through devices, commonly used for controlling >> keyboard LEDs via EV_LED, was not implemented. This commit adds the

[Qemu-devel] [PATCH] virtio-input: implement pass-through evdev writes

The write path for pass-through devices, commonly used for controlling keyboard LEDs via EV_LED, was not implemented. This commit adds the necessary plumbing to connect the status virtio queue to the host evdev file descriptor. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- Most of t

[Qemu-devel] [PATCH] virtio-input: retrieve EV_LED host config bits

VIRTIO_INPUT_CFG_EV_BITS with subsel of EV_LED was always returning an empty bitmap for pass-through input devices. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/input/virtio-input-host.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/input/virtio-input-host.c b/hw/input/

[Qemu-devel] [PATCH] virtio-input: add missing key mappings

KEY_PAUSE is flat out missing. KEY_SYSRQ already has a keycode assigned but it's not what I'm seeing on my system. The mapping doesn't appear to have to be unique so both keycodes now map to KEY_SYSRQ which is what the "Keyboard PrintScreen", HID usage ID 0x46, translates to. Signed-of

Re: [Qemu-devel] [PATCH] add 1394 OHCI device

Just a friendly ping after two weeks of silence. Thanks, Ladi

Re: [Qemu-devel] [PATCH] rng: switch request queue to QSIMPLEQ

On Fri, Mar 4, 2016 at 10:12 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 04/03/2016 09:04, Ladi Prosek wrote: >>>> >> +QSIMPLEQ_INIT(>requests); >>>> >> } >>> > >>> > This init here isn't necessary,

Re: [Qemu-devel] [PATCH] rng: switch request queue to QSIMPLEQ

On Fri, Mar 4, 2016 at 7:27 AM, Amit Shah <amit.s...@redhat.com> wrote: > On (Thu) 03 Mar 2016 [14:16:11], Ladi Prosek wrote: >> QSIMPLEQ supports appending to tail in O(1) and is intrusive so >> it doesn't require extra memory allocations for the bookkeeping >> data

[Qemu-devel] [PATCH] rng: switch request queue to QSIMPLEQ

QSIMPLEQ supports appending to tail in O(1) and is intrusive so it doesn't require extra memory allocations for the bookkeeping data. Suggested-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c| 9 - backends/

[Qemu-devel] [PATCH] virtio-rng: ask for more data if queue is not fully drained

to see if the queue is empty as a little bit of optimization. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- This commit has a logical dependency on [PATCH v3 0/4] rng-random: implement request queue which removes a synchronous invocation of the receive_func callback in rng_random_req

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

On Thu, Mar 3, 2016 at 6:05 AM, Amit Shah <amit.s...@redhat.com> wrote: > On (Thu) 04 Feb 2016 [13:07:35], Ladi Prosek wrote: >> - Original Message - >> > - Original Message - >> > > >> > > >> > > On 03/02/2016 13:36,

[Qemu-devel] [PATCH v3 4/4] rng: add request queue support to rng-random

completion of reads from virtio-rng, i.e. a read was completed only after another read was issued. By switching rng-random to use the same request queue as rng-egd, the unsafe stack-based allocation of the entropy buffer is eliminated and replaced with g_malloc. Signed-off-by: Ladi Prosek <l

[Qemu-devel] [PATCH v3 3/4] rng: move request queue cleanup from RngEgd to RngBackend

RngBackend is now in charge of cleaning up the linked list on instance finalization. It also exposes a function to finalize individual RngRequest instances, called by its child classes. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c

[Qemu-devel] [PATCH v3 1/4] rng: remove the unused request cancellation code

rng_backend_cancel_requests had no callers and none of the code deleted in this commit ever ran. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c | 12 backends/rng.c | 9 - include/sysemu/rng.h | 11 --- 3 files changed, 32 del

[Qemu-devel] [PATCH v3 2/4] rng: move request queue from RngEgd to RngBackend

The 'requests' field now lives in the RngBackend parent class. There are no functional changes in this commit. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c | 28 +--- include/sysemu/rng.h | 11 +++ 2 files changed, 20 insertions(

[Qemu-devel] [PATCH v3 0/4] rng-random: implement request queue

As suggested by Paolo, I have moved the RngRequest implementation up to the RngBackend parent class and made both child classes use it. Apart from the refactoring, the only functional change compared to v1 is the use of heap instead of stack allocation for the read buffer in rng-random. The

[Qemu-devel] [PATCH] add 1394 OHCI device

This patch adds 1394 (FireWire) virtual device support to QEMU. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- I am resurrecting this patch sent to the list by Itamar last year. My motivation is remote Windows kernel debugging - probably the same reason why this work was started in the

Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

On Wed, Mar 2, 2016 at 10:56 AM, Amit Shah <amit.s...@redhat.com> wrote: > On (Wed) 10 Feb 2016 [16:53:25], Ladi Prosek wrote: >> Requests are now created in the RngBackend parent class and the >> code path is shared by both rng-egd and rng-random. >> >>

Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

On Wed, Mar 2, 2016 at 8:15 AM, Amit Shah <amit.s...@redhat.com> wrote: > On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote: >> RngBackend is now in charge of cleaning up the linked list on >> instance finalization. It also exposes a function to finalize >> individual R

[Qemu-devel] [PATCH] balloon: fix segfault and harden the stats queue

admittedly the device assumed too much about the stats queue protocol even before that commit. This commit adds a few more checks and ensures that the one stats buffer gets deallocated on device reset. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/virtio/virtio-balloon.

[Qemu-devel] [PATCH v2 2/4] rng: move request queue from RngEgd to RngBackend

The 'requests' field now lives in the RngBackend parent class. There are no functional changes in this commit. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c | 28 +--- include/sysemu/rng.h | 11 +++ 2 files changed, 20 insertions(

[Qemu-devel] [PATCH v2 1/4] rng: remove the unused request cancellation code

rng_backend_cancel_requests has no callers and none of the code deleted in this commit ever runs. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c | 12 backends/rng.c | 9 - include/sysemu/rng.h | 11 --- 3 files changed, 32 del

[Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue

As suggested by Paolo, I have moved the RngRequest implementation up to the RngBackend parent class and made both child classes use it. Apart from the refactoring, the only functional change compared to v1 is the use of heap instead of stack allocation for the read buffer in rng-random. The

[Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

as delayed completion of reads from virtio-rng, i.e. a read is completed only after another read is issued. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c| 16 ++-- backends/rng-random.c | 43 +++ backends

[Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

RngBackend is now in charge of cleaning up the linked list on instance finalization. It also exposes a function to finalize individual RngRequest instances, called by its child classes. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- backends/rng-egd.c

Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

> > > On 10/02/2016 16:53, Ladi Prosek wrote: > > +req->size = size; > > +req->receive_entropy = receive_entropy; > > +req->opaque = opaque; > > +req->data = g_malloc(req->size); > > + > > +

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

Hi Pankaj, - Original Message - > > Hi Ladi, > > I think this is fine if we have multiple requests from Guests and > depending on entropy pool available we can honour individual requests > and return with the entropy. > > Just one point I have is, Suppose we have multiple requests from

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

- Original Message - > > > On 03/02/2016 13:36, Amit Shah wrote: > > ... and this can lead to breaking migration (the queue of requests on > > the host needs to be migrated, else the new host will have no idea of > > the queue). > > It is already migrated as part of virtio_rng_save's

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

- Original Message - > - Original Message - > > > > > > On 03/02/2016 13:36, Amit Shah wrote: > > > ... and this can lead to breaking migration (the queue of requests on > > > the host needs to be migrated, else the new host will have no idea of > > > the queue). > > > > It is

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

Hi Amit, - Original Message - > Hi Ladi, > > Adding Pankaj to CC, he too looked at this recently. > > On (Fri) 22 Jan 2016 [13:19:58], Ladi Prosek wrote: > > If the guest adds a buffer to the virtio queue while another buffer > > is still pending and hasn

[Qemu-devel] [PATCH] rng-random: implement request queue

completion of reads from virtio-rng, i.e. a read is completed only after another read is issued. This patch adds an internal queue of requests, analogous to what rng-egd uses, to make sure that requests and responses are balanced and correctly ordered. Signed-off-by: Ladi Prosek <lpro...@redhat.

<    1   2   3