@@
#if defined(__GLIBC__)
# include pty.h
#elif defined CONFIG_BSD
+# include termios.h
# if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
defined(__DragonFly__)
# include libutil.h
# else
Can't see how it could hurt.
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 05/22/13 00:32, Michael Roth wrote:
When this VMSD was introduced it's version fields were set to
sizeof(I6300State), making them essentially random from build to build,
version to version.
To fix this, we lock in a high version id and low minimum version id to
support old-new migration
---
1 file changed, 16 insertions(+), 3 deletions(-)
Always alert to make a difference :),
Reviewed-by: Laszlo Ersek ler...@redhat.com
Sekiyama-san,
On 05/21/13 17:33, Tomoki Sekiyama wrote:
* About errors in Windows 7 with patch v2
VSS requires to write to snapshot volumes just before making them read-only
at final commit phase. This feature is called `auto-recovery'
(See
On 05/21/13 17:33, Tomoki Sekiyama wrote:
diff --git a/scripts/qapi.py b/scripts/qapi.py
index afc5f32..b174acb 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -156,9 +156,16 @@ def c_var(name, protect=True):
# GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.html
On 05/21/13 23:02, Tomoki Sekiyama wrote:
Maybe it also should have an additional check and a message to install
Msitools for the case msiextract isn't exectable.
Right. One POSIX-y way would be
command -v msiextract /dev/null
and checking the exit status.
On 05/21/13 17:33, Tomoki Sekiyama wrote:
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script
to extract VSS SDK headers on POSIX-systems using msitools.
* http://www.microsoft.com/en-us/download/details.aspx?id=23490
From: Paolo Bonzini pbonz...@redhat.com
On 05/21/13 18:53, Eric Blake wrote:
On 05/21/2013 09:33 AM, Tomoki Sekiyama wrote:
To enable VSS support in qemu-ga for Windows, header files included in
VSS SDK is required.
The VSS support is enabled when the option like below:
./configure --with-vss-sdk=/pass/to/VSS SDK
VSS SDK is
On 05/21/13 17:33, Tomoki Sekiyama wrote:
+if test $vss_win32_sdk != ; then
+ echo ERROR: Please download and install Microsoft VSS SDK:
+ echo ERROR:
http://www.microsoft.com/en-us/download/details.aspx?id=23490;
+ echo ERROR: On POSIX-systems, you can extract the SDK
On 05/24/13 17:59, Eric Blake wrote:
On 05/24/2013 07:38 AM, Laszlo Ersek wrote:
+++ b/scripts/extract-vsssdk-headers
@@ -0,0 +1,25 @@
+#! /bin/bash
+
+MAGIC=$'\xd0\xcf\x11\xe0\xa1\xb1\x1a\xe1'
Can't help mentioning the following portable (alas, octal) equivalent :)
MAGIC=$(printf
On 05/24/13 21:05, Luiz Capitulino wrote:
Hi,
Today I accidentally started qemu w/o -enable-kvm to run a Windows guest and
noticed it didn't boot: sometimes it hangs on a blue screen and sometimes it
keeps rebooting in a loop.
I tried with Windows 2008 and Windows 8, and went back to qemu
On 05/24/13 19:25, Duane Voth wrote:
qemu: fatal: Trying to execute code outside RAM or ROM; worked in
1.4.0, fails in 1.4.92
Want to bring a little attention to this bug - the break is in
target-i386/translate.c which affects all x86_64 soft emulation in a
fairly subtle way (ie. users will
...@twiddle.net
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
target-i386/translate.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 0aeccdb..86f2678 100644
--- a/target-i386/translate.c
+++ b/target-i386
** Changed in: qemu
Status: New = In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1180970
Title:
qemu: fatal: Trying to execute code outside RAM or ROM; worked in
1.4.0, fails
Proposed patch: http://thread.gmane.org/gmane.comp.emulators.qemu/213023
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1180970
Title:
qemu: fatal: Trying to execute code outside RAM or ROM; worked
On 05/08/13 13:39, Brad Smith wrote:
Remove the OSS support for OpenBSD. The OSS API has not been usable
for quite some time.
Signed-off-by: Brad Smith b...@comstyle.com
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 00be9c9..007c641 100644
--- a/audio/ossaudio.c
+++
)
bsd=yes
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 05/26/13 10:33, Paolo Bonzini wrote:
Il 26/05/2013 01:23, Richard Henderson ha scritto:
On 2013-05-24 14:37, Laszlo Ersek wrote:
@@ -4813,7 +4813,11 @@ static target_ulong disas_insn(CPUX86State
*env, DisasContext *s,
/* 0x66 is ignored if rex.w is set */
dflag
On 05/26/13 15:34, Andreas Färber wrote:
From: Laszlo Ersek ler...@redhat.com
The qemu guest agent creates a bunch of files with insecure permissions
when started in daemon mode. For example:
-rw-rw-rw- 1 root root /var/log/qemu-ga.log
-rw-rw-rw- 1 root root /var/run/qga.state
-rw
On 05/27/13 02:11, Laszlo Ersek wrote:
On 05/26/13 15:34, Andreas Färber wrote:
From: Laszlo Ersek ler...@redhat.com
The qemu guest agent creates a bunch of files with insecure permissions
when started in daemon mode. For example:
-rw-rw-rw- 1 root root /var/log/qemu-ga.log
-rw-rw-rw
On 05/27/13 02:19, Andreas Färber wrote:
Am 27.05.2013 02:11, schrieb Laszlo Ersek:
Do you plan to backport
8fe6bbc qga: distinguish binary modes in guest_file_open_modes map
2b72001 qga: unlink just created guest-file if fchmod() or fdopen()
fails on it
too
On 05/27/13 02:19, Andreas Färber wrote:
Am 27.05.2013 02:11, schrieb Laszlo Ersek:
Also, a side-note: existing world-writable log files etc. are not
recreated nor have their modes changed, so maybe a release note or some
such would be useful for admins (delete your previous logfile
On 05/28/13 10:06, Paolo Bonzini wrote:
Il 28/05/2013 09:40, Amos Kong ha scritto:
bootindex parameter of scsi device doesn't work, it causes
by wrong pattern in seabios.
qemu passes the following firmware dev_path to seabios:
/pci@i0cf8/scsi@4/virtio-scsi-device/channel@0/disk@0,0
No,
Hi,
the driver in question is intended as a fallback driver when the iPXE
EFI driver for virtio-net is not present as an oprom. The series starts
with technical notes that should help the virtio-net expert catch any
errors more easily.
This review could easily take up a lot of time; my hope is
= virtio_bus_get_fw_dev_path;
}
static const TypeInfo virtio_bus_info = {
Ah, the happiness of finally understanding what Paolo suggested. (Or at
least believing so.)
My R-b is superfluous after Paolo's, but I can't resist.
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 05/30/13 11:23, David Woodhouse wrote:
On Wed, 2013-05-29 at 11:18 -0500, Anthony Liguori wrote:
Certainly an option, but that is a long-term project.
Out of curiousity, are there other benefits to using coreboot as a core
firmware in QEMU?
Is there a payload we would ever plausibly use
On 05/30/13 13:23, Gonglei (Arei) wrote:
Hi all,
My environment is xen-4.1.2 + qemu-1.2.2
I made a pvscsi driver for Redhat guest, but I encountered a problem
that I could see two scsi disks, one was simulated by QEMU, another was
passthrough.
Actually I want to unplug the
();
+if (runstate_check(RUN_STATE_DEBUG)) {
+vm_start();
+}
#endif
}
I sought to check the gdb_continue() call sites, and uses of
RUN_STATE_DEBUG. Seems reasonable.
Reviewed-by: Laszlo Ersek ler...@redhat.com
(
FWIW I wonder why in commit ad02b96a Luiz allowed DEBUG - SUSPENDED. As
far
I can't offer any opinion about the values you put into w32 and w64, but I have
some remarks.
First, please consider passing -O/path/to/some/order_file to git-format-patch,
so that .h files show up at the top of each patch.
On 05/30/13 13:07, Michael S. Tsirkin wrote:
Will be used to pass
On 05/30/13 14:19, David Woodhouse wrote:
Yeah, but if we're shoving a lot of hardware-specific ACPI table
generation into the guest's firmware, instead of just doing it on the
qemu side where a number of us seem to think it belongs, then there *is*
a benefit to using Coreboot. When stuff
, because simple patches like this are prime territory
to burn someone's R-b's worth (ie. to expose a reviewer's lack of
information / experience). But hey, what can I lose? The patch does look
good to me, so
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
PS: I (obviously) don't any more core
On 05/30/13 15:27, Michael S. Tsirkin wrote:
Use the type-safe FWCfgState structure instead
of the unsafe void *.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/misc/pvpanic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/pvpanic.c
On 05/30/13 17:41, Paolo Bonzini wrote:
Il 30/05/2013 17:05, Laszlo Ersek ha scritto:
But, again object_resolve_path() returns pointer-to-Object. I'm checking
struct Object in include/qom/object.h, and it suggests that derived
structs should embed Object as first member. However FWCfgState
On 05/30/13 17:05, Laszlo Ersek wrote:
On 05/30/13 15:27, Michael S. Tsirkin wrote:
Use the type-safe FWCfgState structure instead
of the unsafe void *.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/misc/pvpanic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
| 2 ++
3 files changed, 17 insertions(+), 7 deletions(-)
series
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 05/30/13 15:28, Michael S. Tsirkin wrote:
diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
index 1483f27..910e44f 100644
--- a/hw/misc/pvpanic.c
+++ b/hw/misc/pvpanic.c
@@ -96,7 +96,7 @@ static int pvpanic_isa_initfn(ISADevice *dev)
isa_register_ioport(dev, s-io, s-ioport);
On 05/30/13 13:07, Michael S. Tsirkin wrote:
/* PC hardware initialisation */
static void pc_init1(MemoryRegion *system_memory,
@@ -122,6 +122,7 @@ static void pc_init1(MemoryRegion *system_memory,
}
guest_info = pc_guest_info_init(below_4g_mem_size, above_4g_mem_size);
+
On 05/30/13 18:20, Jordan Justen wrote:
I think ACPI table generation lives in firmware on real products,
because on real products the firmware is the point that best
understands the actual hardware layout for the machine. In qemu, I
would say that qemu best knows the hardware layout, given
On 05/30/13 18:57, Jordan Justen wrote:
On Thu, May 30, 2013 at 9:41 AM, Laszlo Ersek ler...@redhat.com wrote:
On 05/30/13 18:20, Jordan Justen wrote:
I think ACPI table generation lives in firmware on real products,
because on real products the firmware is the point that best
understands
On 05/31/13 09:09, Jordan Justen wrote:
Why is updating the ACPI tables in seabios viewed as such a burden?
Either qemu does it, or seabios... (And, OVMF too, but I don't think
you guys are concerned with that. :)
I am :)
On the flip side, why is moving the ACPI tables to QEMU such an
On 05/31/13 06:41, Jordan Justen wrote:
On Thu, May 30, 2013 at 7:06 PM, Kevin O'Connor ke...@koconnor.net wrote:
On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote:
The isapc machine with seabios currently requires the BIOS region
to be read/write memory rather than read-only
On 05/31/13 10:13, Peter Stuge wrote:
ACPI bytes are obviously a function of QEMU configuration.
Precisely!
When we evaluate that (mathematical-sense) function in boot firmware, we
need to retrieve the function's arguments. Those arguments are bits of
QEMU configuration, as you say, and fw_cfg
On 05/31/13 16:08, David Woodhouse wrote:
On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote:
soapbox
Fork OVMF, drop the fat module, and just add GPL code. It's an easily
solvable problem.
Heh. Actually it doesn't need to be a fork. It's modular, and the FAT
driver is just a
On 05/31/13 17:43, Anthony Liguori wrote:
David Woodhouse dw...@infradead.org writes:
On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote:
soapbox
Fork OVMF, drop the fat module, and just add GPL code. It's an easily
solvable problem.
Heh. Actually it doesn't need to be a fork.
On 05/31/13 16:38, Anthony Liguori wrote:
It's either Open Source or it's not. It's currently not.
I disagree with this binary representation of Open Source or Not. If it
weren't (mostly) Open Source, how could we fork (most of) it as you're
suggesting (from the soapbox :))?
I have a hard
On 05/31/13 18:33, David Woodhouse wrote:
On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote:
It's even more fundamental. OVMF as a whole (at least in it's usable
form) is not Open Source.
The FAT module is required to make EDK2 usable, and yes, that's not Open
Source. So in a sense
On 05/31/13 23:03, Jordan Justen wrote:
Of course, the fact that the current FAT driver is exclusionary for
free software projects is a point that is not lost on me. I just don't
agree that the best response to this is a GPL'd FAT driver.
What would you suggest?
Thank you,
Laszlo
CODE64 expands to the
constant zero when TARGET_X86_64 is undefined.
Cc: Paolo Bonzini pbonz...@redhat.com
Reported-by: Laszlo Ersek ler...@redhat.com
Signed-off-by: Richard Henderson r...@twiddle.net
---
target-i386/translate.c | 30 +++---
1 file changed, 15 insertions
: Stefan Hajnoczi shajn...@redhat.com
Cc: Laszlo Ersek ler...@redhat.com
Cc: qemu-sta...@nongnu.org
Signed-off-by: Jason Wang jasow...@redhat.com
---
net/tap.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index e0b7a2a..477505f
On 06/03/13 14:42, Michael Tokarev wrote:
03.06.2013 16:34, Eric Blake wrote:
On 06/03/2013 03:20 AM, Michael Tokarev wrote:
Initially the code ensured that we have exactly one of data= or file=
option for -acpitable. But after some transformations, the condition
becomes
if (has_data ==
)
+
+echo
+All patches in $range compiled successfully! | tee -a $logfile
+exit 0
I think my remarks are not important, the script should work in any
practical environment. We should get this merged and small fixes can be
posted incrementally if needed.
Reviewed-by: Laszlo Ersek ler
6b0db02..fd76f91 100644
--- a/include/qemu/log.h
+++ b/include/qemu/log.h
@@ -2,6 +2,9 @@
#define QEMU_LOG_H
#include stdarg.h
+#include stdbool.h
+#include stdio.h
+#include qemu/compiler.h
#ifdef NEED_CPU_H
#include disas/disas.h
#endif
Reviewed-by: Laszlo Ersek ler
/smbios.c | 24
2 files changed, 12 insertions(+), 13 deletions(-)
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 06/06/13 18:27, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 3 ++-
hw/nvram/fw_cfg.c | 2 +-
include/sysemu/sysemu.h | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch_init.c b/arch_init.c
100644
--- a/include/qemu/error-report.h
+++ b/include/qemu/error-report.h
@@ -14,6 +14,7 @@
#define QEMU_ERROR_H
#include stdarg.h
+#include qemu/compiler.h
typedef struct Location {
/* all members are private to qemu-error.c */
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 06/06/13 18:27, Markus Armbruster wrote:
Having size preceed the associated pointer is odd. Swap them, and fix
up the types.
Can you proceed to fix the spelling of precede? :)
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 2 +-
hw/i386/smbios.c
(struct smbios_type_0,
system_bios_major_release),
major, 1);
Strictly speaking these should be %hhu, if it's not much of a bother.
Otherwise:
Reviewed-by: Laszlo Ersek ler...@redhat.com
(BTW what was wrong with the definitions
be represented in the space provided, the behavior is undefined.)
Reviewed-by: Laszlo Ersek ler...@redhat.com
.)
Reviewed-by: Laszlo Ersek ler...@redhat.com
On 06/07/13 08:12, Gerd Hoffmann wrote:
On 06/06/13 17:10, Philipp Hahn wrote:
Hello,
I'm using libvirt to manage my VMs and configured one VM to boot from
a CDROM connected via virtio. This does neither work with QEMU-1.1.2
nor with QEMU-1.5; neither with SeaBIOS is 1.7.0 nor 1.7.2.
On 06/07/13 15:00, Markus Armbruster wrote:
v2: Address Hawkeye Laszlo's review
You're too kind, but it did crack me up :)
(Next time I'll miss something I'll have to hang my head in shame all
the more!)
* 1-3/7 unchanged
* Drop 4/7 because it's buggy, and the fixed version isn't worthwhile
On 06/07/13 16:44, Jeff Cody wrote:
Thanks. I can either do the above changes for a v2, or as follow on
patches.
Whichever is easier for you, certainly! I'm fine with the script
going-in as is.
Cheers,
Laszlo
On 06/10/13 20:58, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
This adds support for device hotplug behind
pci bridges. Bridge devices themselves need
to be pre-configured on qemu command line.
One of the goals of this project was to
demonstrate the advantages of
On 06/10/13 21:57, Anthony Liguori wrote:
Laszlo Ersek ler...@redhat.com writes:
Please take a look at my series for OVMF that adds basic support for
SMBIOS tables. It took me three days of basically uninterrupted coding
and two approaches to throw away until I got something submittable
Sorry about replying to myself...
On 06/10/13 22:43, Laszlo Ersek wrote:
It's not a design purity argument, just what's cheaper.
You probably consider SMBIOS/ACPI table generation guest code that has
no place in the machine emulator. You're likely willing to expose the
needed bits on a case
On 06/11/13 17:45, Michael S. Tsirkin wrote:
To summarize, there's a concensus now that generating ACPI
tables in QEMU is a good idea.
Two issues that need to be addressed:
- original patches break cross-version migration. Need to fix that.
- Anthony requested that patchset is merged
On 06/12/13 13:51, Michael Tokarev wrote:
06.06.2013 01:22, Peter Maydell wrote:
Personally I think a lot of the random rubbish in
our .gitignore is bogus and should be removed.
Basically anything that's an editor dropping or
.patch or TAGS file or similar is a local workflow
thing and
On 10/14/13 10:18, Phi Debian wrote:
Hi All,
I tried to subscribe to this list, but never got teh confirm mail.
So I write here non subscribed, so add my email addr in replies.
I am trying to use guest-dump-memory on arm (arm32, armv7* name it)
with qemu 1.6.1. The command is
Also sort the test-* entries in the latter.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
.gitignore | 9 -
tests/.gitignore | 11 +--
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/.gitignore b/.gitignore
index 8e1b73f..7f4c106 100644
--- a/.gitignore
On 10/15/13 16:11, Eric Blake wrote:
On 10/15/2013 07:10 AM, Laszlo Ersek wrote:
Also sort the test-* entries in the latter.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
.gitignore | 9 -
tests/.gitignore | 11 +--
2 files changed, 9 insertions(+), 11 deletions
Hi,
Appendix X: virtio-mmio in the virtio spec says
• 0x040 | RW | QueuePFN
[...] When the Guest stops using the queue it must write zero
(0x0) to this register.
[...]
and
Virtqueue Configuration
[...]
2. Check if the queue is not already in use: read
My apologies, I used Anthony's previous (now obsolete) email. Updated it
now keeping full context below. Sorry.
On 10/22/13 19:49, Laszlo Ersek wrote:
Hi,
Appendix X: virtio-mmio in the virtio spec says
• 0x040 | RW | QueuePFN
[...] When the Guest stops using the queue it must
On 10/22/13 19:55, Laszlo Ersek wrote:
The question arises because Olivier has posted a series to edk2-devel
that adds virtio-mmio support to TianoCore, and Mark tested it (using
OVMF) with a Linux guest and found problems. Namely, OVMF itself can
drive the virtio devices via virtio-mmio
On 10/11/13 19:54, Stefan Hajnoczi wrote:
On Thu, Sep 12, 2013 at 9:46 PM, Laszlo Ersek ler...@redhat.com wrote:
When qemu dies unexpectedly, for example in response to an explicit
abort() call, or (more importantly) when an external signal is delivered
to it that results in a coredump
On 10/29/13 11:50, Peter Lieven wrote:
On 29.10.2013 11:48, Paolo Bonzini wrote:
Il 29/10/2013 11:40, Peter Lieven ha scritto:
The KVM signature should be at CPUID leaf 0x4100.
If I enable hyperv for all vServers the signature is at
KVM_CPUID_SIGNATURE_NEXT (0x4100) otherwise
at
On 09/04/13 16:21, Stefan Hajnoczi wrote:
On Thu, Aug 29, 2013 at 03:37:50PM +0200, Laszlo Ersek wrote:
+static void dump_cmd_req(const VirtIOSCSIReq *req, uint32_t cdb_size)
+{
+const VirtIOSCSICmdReq *cr;
+char *cdb_hex;
+
+if (!trace_event_get_state
On 09/05/13 15:26, Paolo Bonzini wrote:
Il 05/09/2013 14:19, Michal Novotny ha scritto:
This is the patch to introduce SIGILL handler to be able to trigger
SIGSEGV signal in qemu. This has been written to help debugging
state when qemu crashes by SIGSEGV as a simple reproducer to
emulate such
On 09/10/13 05:24, Bo Yang wrote:
This patch has been sent to upstream vgabios maillist, but there
is no response. Since it is useful for windows8 resolution, I
resend it to qemu maillist for review.
Signed-off-by: Bo Yang boy...@suse.com
---
vbe.c | 42
,
nvcsw = 0,
- nivcsw = 1000,
+ nivcsw = 1764,
start_time = {
tv_sec = 0,
tv_nsec = 0
- name_droppingI asked for Dave Anderson's help with verifying the
extracted vmcore, and his comments make me think I should post
this./name_dropping
Signed-off-by: Laszlo Ersek ler
On 09/12/13 21:46, Laszlo Ersek wrote:
When qemu dies unexpectedly, for example in response to an explicit
abort() call, or (more importantly) when an external signal is delivered
to it that results in a coredump, sometimes it is useful to extract the
guest vmcore from the qemu process' memory
On 09/23/13 15:39, Michael S. Tsirkin wrote:
On Mon, Sep 23, 2013 at 02:36:41PM +0200, Paolo Bonzini wrote:
Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto:
Detect presence of IASL compiler and use it
to process ASL source. If not there, use pre-compiled
files in-tree. Add script to update
is equivalent to
-numa node,nodeid=3,cpus=65534,cpus=65535,cpus=65536,cpus=65537
and visit_type_uint16() [qapi/qapi-visit-core.c] will catch the first
element (= 65536) that has been parsed by opts_type_int() but cannot be
represented as 'uint16'.
Laszlo Ersek (8):
OptsVisitor: introduce basic list
When a well-formed range value, bounded by signed integers, is encountered
while processing a repeated option, enter LM_SIGNED_INTERVAL and return
the low bound.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 34 --
1 files changed, 28
to parse a scalar into it. List mode restrictions are expressed in
positive / inclusive form.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
rfc-v1:
- replace assert(0) with abort() for when opts_next_list() encounters a
nonexistent / invalid list mode [Paolo]
qapi/opts-visitor.c | 45
Prevent mistyped command line options from incurring high memory and CPU
usage at startup. 64K elements in a range should be enough for everyone
(TM).
The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can
construct corner cases with it.
Signed-off-by: Laszlo Ersek ler...@redhat.com
When a well-formed range value, bounded by unsigned integers, is
encountered while processing a repeated option, enter LM_UNSIGNED_INTERVAL
and return the low bound.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 32 +++-
1 files changed, 27
Simplify the code in preparation for the next patch.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
qapi/opts-visitor.c | 23 +--
1 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 90be583..d8f9a0e 100644
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
tests/Makefile|6 +-
qapi-schema-test.json | 15 +++
tests/test-opts-visitor.c | 275 +
.gitignore|1 +
4 files changed, 296 insertions(+), 1 deletions
Probably missed in commit 6046c620
(int128: optimize and add test cases).
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 0fe114d..388cb45 100644
--- a/.gitignore
+++ b/.gitignore
/ inclusive
sense. The restrictions for lookup_scalar() and processed() are
automatically satisfied by current qapi traversals if the schema to build
is compatible with OptsVisitor.
The new list modes are not entered yet.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
rfc-v1:
- replace sub-modes
On 07/23/13 00:04, Eric Blake wrote:
On 07/22/2013 03:07 PM, Laszlo Ersek wrote:
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
tests/Makefile|6 +-
qapi-schema-test.json | 15 +++
tests/test-opts-visitor.c | 275
On 07/23/13 00:26, Eric Blake wrote:
On 07/22/2013 04:24 PM, Laszlo Ersek wrote:
Pretty thorough, although I thought of a couple other ideas to test:
i64=5z-6 should fail; i64=5-6-7 should fail
I can add them if you insist, but I wrote (and single-stepped all of)
the test cases so that all
On 07/17/13 17:07, Laszlo Ersek wrote:
On 07/10/13 15:51, Michael S. Tsirkin wrote:
This fills in guest info table with misc
information of interest to the guest.
Will be used by ACPI table generation code.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/acpi/ich9.c | 7
On 07/25/13 23:44, Michael Roth wrote:
The QEMU v1.5.2 stable release is now available at:
http://wiki.qemu.org/download/qemu-1.5.2.tar.bz2
This is release is solely to address a security issue (CVE-2013-2231) found
in the QEMU Guest Agent on Windows. More details on the nature of the
On 07/22/13 23:07, Laszlo Ersek wrote:
rfc-v1:
- addressed Paolo's comments for patches 1 and 2,
- patches 7 and 8 are new (unit tests),
- updated the cover letter to take native lists into account, plus
cleaned it up.
Will this be considered for 1.7?
I'm not sure how Wanlong's NUMA stuff
On 07/29/13 13:11, Wanlong Gao wrote:
On 07/29/2013 07:01 PM, Paolo Bonzini wrote:
Il 29/07/2013 11:47, Laszlo Ersek ha scritto:
On 07/22/13 23:07, Laszlo Ersek wrote:
rfc-v1:
- addressed Paolo's comments for patches 1 and 2,
- patches 7 and 8 are new (unit tests),
- updated the cover
guests (paging=false).
Please refer to Red Hat Bugzilla 981582
https://bugzilla.redhat.com/show_bug.cgi?id=981582.
Disclaimer: as you can tell from my progress in the RHBZ, I'm new to the
memory API. The way I'm using it might be retarded.
Laszlo Ersek (4):
dump: clamp guest-provided mapping
, and contiguous in host virtual address space.
The maximal ranges that remain in the end constitute the guest-physical
memory map that the dump will be based on.
Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
include/sysemu
=981582
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
include/sysemu/memory_mapping.h | 22 ++
dump.c | 31 +++
memory_mapping.c| 17 +
3 files changed, 58 insertions(+), 12 deletions
of the PT_LOAD entry.
Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=981582
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
dump.c | 65 +++
1 files changed, 40 insertions(+), 25 deletions(-)
diff --git a/dump.c b/dump.c
index 6a3a72a
1 - 100 of 4203 matches
Mail list logo
