Signed-off-by: Laszlo Ersek
---
net/slirp.c | 93 ---
1 files changed, 25 insertions(+), 68 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index 9b925b7..166304c 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -654,89 +654,46 @@ void
On 06/13/12 12:50, Paolo Bonzini wrote:
> Il 13/06/2012 10:22, Laszlo Ersek ha scritto:
>> +static void
>> +opts_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
>> +{
>> +OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
>> +const
On 04/18/12 21:30, Luiz Capitulino wrote:
> A child created by bios_supports_mode() could terminate during the call
> to close() or g_free(). This could cause the SIGCHLD signal to be
> deliveried in the midle of their execution. Possible problems range from
> resource leak to segfault. Fix that by
storage duration) an
error.
Build tested only. Please CC me on any followup, I'm not subscribed. Thank you.
Signed-off-by: Laszlo Ersek
---
cpus.c | 13 ++---
sysemu.h |2 +-
vl.c |6 +++---
3 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/cpus.c
On 09/15/11 21:44, Peter Maydell wrote:
On 15 September 2011 18:22, Laszlo Ersek wrote:
-int no_shutdown = 0;
+volatile int no_shutdown = 0;
So why 'volatile' and not 'sig_atomic_t', then?
The sigaction() spec says"volatile sig_atomic_t", so that would be
On 09/15/11 21:16, Anthony Liguori wrote:
On 09/15/2011 12:22 PM, Laszlo Ersek wrote:
http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_04_03_03
I don't think you can rely on snprintf being signal safe. I think you
should just exit on failure.
OpenBSD
3
[2] http://lists.nongnu.org/archive/html/qemu-devel/2011-09/msg01757.html
Build tested only.
Signed-off-by: Laszlo Ersek
---
cpus.c |7 ---
sysemu.h |2 +-
vl.c |6 +++---
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/cpus.c b/cpus.c
index 54c188c..b38
http://wiki.qemu.org/Planning/1.7
Thank you.
Laszlo
On 03/24/14 22:50, Andreas Färber wrote:
> Laszlo,
>
> Am 24.03.2014 20:23, schrieb Laszlo Ersek:
>> http://wiki.qemu.org/Planning/1.7
>>
>> Thank you.
>> Laszlo
>
> Since you're not addressing anyone in particular who could create the
> relea
On 03/25/14 15:44, Michael Roth wrote:
> Hi everyone,
>
> I am pleased to announce that the QEMU v1.7.1 stable release is now
> available at:
>
> http://wiki.qemu.org/download/qemu-1.7.1.tar.bz2
>
> v1.7.1 is now tagged in the official qemu.git repository,
> and the stable-1.7 branch has been
On 03/26/14 11:31, Michael S. Tsirkin wrote:
> On Wed, Mar 26, 2014 at 06:45:10AM -, Robert Hu wrote:
>> Date: Mon Mar 17 17:05:16 2014 +0100
>>
>> i386/acpi-build: allow more than 255 elements in CPON
>>
>> The build_ssdt() function builds a number of AML objects that are related
>
On 03/26/14 13:58, Michael S. Tsirkin wrote:
> On Wed, Mar 26, 2014 at 01:28:02PM +0100, Laszlo Ersek wrote:
>> On 03/26/14 11:31, Michael S. Tsirkin wrote:
>>
>>> On Wed, Mar 26, 2014 at 06:45:10AM -, Robert Hu wrote:
>>
>>>> Date: Mon Mar 17 1
On 03/26/14 14:48, Igor Mammedov wrote:
> On Wed, 26 Mar 2014 14:58:28 +0200
> "Michael S. Tsirkin" wrote:
>> If we want to change ACPI rev, I think we should do this
>> conditionally when max_cpus > 255.
>> Would be worth it if this fixes some guests.
>>
>> As for reverting, I think it's a probl
On 03/26/14 16:23, Eduardo Habkost wrote:
> On Wed, Mar 26, 2014 at 05:09:29PM +0200, Michael S. Tsirkin wrote:
>> On Wed, Mar 26, 2014 at 12:06:38PM -0300, Eduardo Habkost wrote:
>>> On Wed, Mar 26, 2014 at 04:54:31PM +0200, Michael S. Tsirkin wrote:
On Wed, Mar 26, 2014 at 02:48:29PM +0100,
On 03/27/14 09:41, Erik Rull wrote:
> Hi all,
>
> I would like to have the guest "drifting" to a new set clock on the host.
>
> My problem is the following:
>
> - Host System (Linux) starts up, hwclock and kernel time are synced,
> guest starts up with -rtc clock=host,driftfix=slew (which I assu
On 03/27/14 13:40, Gerd Hoffmann wrote:
> On Do, 2014-03-27 at 10:57 +0100, Markus Armbruster wrote:
>> Olaf Hering writes:
>>
>>> Right now qemu does appearently just emulate a graphics card (Cirrus for
>>> example), but not an attached monitor/display. The result is confusion
>>> in the guest OS
On 03/27/14 21:14, Erik Rull wrote:
> Laszlo Ersek wrote:
>> On 03/27/14 09:41, Erik Rull wrote:
>>> Hi all,
>>>
>>> I would like to have the guest "drifting" to a new set clock on the
>>> host.
>>>
>>> My problem is the fo
et {
> uint8_t nobcast;
> uint8_t vhost_started;
> struct {
> -int in_use;
> -int first_multi;
> +uint32_t in_use;
> +uint32_t first_multi;
> uint8_t multi_overflow;
> uint8_t uni_overflow;
> uint8_t *macs;
>
I ran
git grep -EHn '\<(in_use|first_multi)\>'
Many hits, hard to audit (esp. because I'm unfamiliar with the code).
Several loops with signed int loop variables. I checked cursorily.
Reviewed-by: Laszlo Ersek
On 03/31/14 22:18, Gabriel L. Somlo wrote:
> On Wed, Mar 26, 2014 at 06:36:10PM -0400, Kevin O'Connor wrote:
>> On Wed, Mar 26, 2014 at 03:58:50PM -0400, Gabriel L. Somlo wrote:
>>> - SeaBIOS is still in charge of providing the smbios_entry_point
>>> structure, and it's unlikely we can reasonably
On 04/01/14 16:39, Kevin O'Connor wrote:
> On Tue, Apr 01, 2014 at 10:40:00AM +0200, Laszlo Ersek wrote:
>> On 03/31/14 22:18, Gabriel L. Somlo wrote:
>>> The only sticking point remaining would be who gets to generate the
>>> Type 0 (BIOS Information) table a
On 04/01/14 17:01, Fabio Fantoni wrote:
> Today I tried latest qemu 2.0 compiled from git (commit
> 63678e17cf399ff81b93417fe7bee8d6ef6b6b1b) on this dom0:
> Debian 7 (Wheezy) 64 bit with kernel from package
> linux-image-3.2.0-4-amd64 version 3.2.54-2 and all dependency packages
> for xen, spice a
On 04/01/14 23:28, Gabriel L. Somlo wrote:
> On Tue, Apr 01, 2014 at 04:28:32PM -0400, Kevin O'Connor wrote:
>>> From the conversation so far, it seems to me that:
>>>
>>> - type 0 is best left to the BIOS (user overrides via
>>> command line at their own risk)
>>>
>>> - therefore, th
On 04/02/14 00:00, Kevin O'Connor wrote:
> On Tue, Apr 01, 2014 at 11:44:12PM +0200, Laszlo Ersek wrote:
>> Right now, OVMF can accept individual fields, or table-at-a-time blobs,
>> via fw_cfg.
>>
>> The internal interface (EFI_SMBIOS_PROTOCOL) expects one table at
On 04/02/14 13:13, Fabio Fantoni wrote:
> Il 01/04/2014 18:24, Laszlo Ersek ha scritto:
>> On 04/01/14 17:01, Fabio Fantoni wrote:
>>> Today I tried latest qemu 2.0 compiled from git (commit
>>> 63678e17cf399ff81b93417fe7bee8d6ef6b6b1b) on this dom0:
>>> Debia
On 04/02/14 14:38, Gabriel L. Somlo wrote:
> On Wed, Apr 02, 2014 at 12:35:26AM +0200, Laszlo Ersek wrote:
>> On 04/02/14 00:00, Kevin O'Connor wrote:
>>> On Tue, Apr 01, 2014 at 11:44:12PM +0200, Laszlo Ersek wrote:
>>>> Right now, OVMF can accept individu
On 04/03/14 03:57, Gabriel L. Somlo wrote:
> On Wed, Apr 02, 2014 at 01:01:28PM -0400, Gabriel L. Somlo wrote:
>> Speaking of, I *thought* I had a vague idea of how all this stuff fits
>> together, but it turns out I don't... There's
>>
>> - OVMF
>>http://sourceforge.net/apps/mediawiki
On 04/02/14 00:09, Andy Lutomirski wrote:
> Running:
>
> ./virtme-run --installed-kernel
>
> from this virtme commit:
>
> https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git/commit/?id=2b409a086d15b7a878c7d5204b1f44a6564a341f
>
> results in a bunch of missing lines of text once bootup fi
On 04/03/14 15:32, Gabriel L. Somlo wrote:
> On Thu, Apr 03, 2014 at 11:42:31AM +0200, Laszlo Ersek wrote:
>> You don't see SMBIOS tables in the guest because you've built upstream
>> OVMF. As I said before, upstream OvmfPkg doesn't include my SMBIOS
>>
On 04/06/14 13:08, Michael Tokarev wrote:
> 06.04.2014 14:53, Michael S. Tsirkin wrote:
>> On Sun, Apr 06, 2014 at 01:49:11PM +0400, Michael Tokarev wrote:
>>> When building RSDT table, pick OEM ID fields from uer-supplied SLIC
>>> table instead of using hard-coded QEMU defaults. This way, say,
>>
On 04/07/14 16:14, Kevin O'Connor wrote:
> On Mon, Apr 07, 2014 at 09:09:56AM +0200, Gerd Hoffmann wrote:
The only fly in this ointment may be that type 0 doesn't have a fixed
length that could be edited in place, if you consider the various
strings that get tacked on to the end of i
t = -EINVAL;
> + goto fail;
> }
>
> if (s->catalog_size < bs->total_sectors / s->extent_size) {
>
Reviewed-by: Laszlo Ersek
> }
>
> -if (s->catalog_size < bs->total_sectors / s->extent_size) {
> +if (s->catalog_size < DIV_ROUND_UP(bs->total_sectors,
> + s->extent_size / BDRV_SECTOR_SIZE))
> +{
> error_setg(
On 04/03/14 07:18, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> assigned_dev_register_msix_mmio(), meanwhile the set the one
> page memmory to zero, so the rest memory will be random value
> (maybe etnry.data is not 0). In the as
qemu_parse_fd() used to handle at least the following strings incorrectly:
o "-2": simply let through
o "2147483648": returned as LONG_MAX==INT_MAX on ILP32 (with ERANGE
ignored); implementation-defined behavior on LP64
Signed-off-by: Laszlo Ersek
---
... and rebase pci_add_capability() to it.
Signed-off-by: Laszlo Ersek
---
include/hw/pci/pci.h | 4
hw/pci/pci.c | 32 ++--
2 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 693dd6b
-by: Laszlo Ersek
---
include/monitor/monitor.h | 1 +
monitor.c | 29 +++--
2 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
index a49ea11..07e3d29 100644
--- a/include/monitor/monitor.h
rror_report()
get_real_device_id()
get_real_id()
error_report()
error_printf()
error_report()
assign_intx()
check_irqchip_in_kernel()
error_report()
error_report()
error_printf()
Lasz
d-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index b4696aa..f91d4fb 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-ass
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 45 +++--
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index c6d1094..2de6559 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw
ff-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index a825871..bfce97f 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-assign.c
@@ -539,22 +539,27 @@ stati
Rename check_irqchip_in_kernel() to verify_irqchip_in_kernel(), so that
the name reflects our expectation better. Rather than returning a bool,
make it do nothing or set an Error.
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 25 +
1 file changed, 17
This allows us to report the entire error with one error_report() call,
easing future error propagation.
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw
Among the callers, only assigned_initfn() should set the monitor's stored
error. Other callers may run in contexts where the monitor's stored error
makes no sense. For example:
assigned_dev_pci_write_config()
assigned_dev_update_msix()
assign_intx()
Signed-off-by: Laszlo Erse
The return type is also changed from "int" to "void", because it was used
in a success vs. failure sense only (the caller didn't distinguish error
codes from each other, and even assigned_dev_register_msix_mmio() masked
mmap()'s errno values with a common -EFAULT)
assigned_initfn()
get_real_device()
read()
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index f91d4fb..e89bb6a 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index e89bb6a..c6d1094 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386
get_real_id() has two thin wrappers (and no other callers),
get_real_vendor_id() and get_real_device_id(); it's easiest to convert
them in one fell swoop.
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 45 +++--
1 file changed, 27 inser
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index 3a904e8..9aa92a1 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-assign.c
Also, change the return type to "void"; the function is static (with a
sole caller) and the negative errno values are not distinguished from each
other.
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 29 +++--
1 file changed, 15 insertions(+), 14
Signed-off-by: Laszlo Ersek
---
hw/i386/kvm/pci-assign.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index 6891729..e55421a 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci
On 04/11/14 14:02, Michael Tokarev wrote:
> Chris Boot updated his qemu from 1.7.0 to 1.7.1, and noticed that windows
> guests
> which was using virtio-scsi does not work anymore. Windows BSODs at
> boot with the following error:
>
>
> STOP: c221 Unknown Hard Error
>\StstenRiit\System
On 04/11/14 14:27, Laszlo Ersek wrote:
> On 04/11/14 14:02, Michael Tokarev wrote:
>> More, the same issue exists on 2.0-tobe as well, but in this case, reverting
>> the same commit from there -- a87f39543a9259f671c5413723311180ee2ad2a8 --
>> does NOT fix the problem. I'
On 03/20/14 20:21, Michael Roth wrote:
> Quoting Markus Armbruster (2014-03-18 04:32:08)
>> Peter Maydell writes:
>>
>>> This is something clang's -fsanitize=undefined spotted. The
>>> code generated by qapi-commands.py in qmp-marshal.c for
>>> qmp_marshal_* functions where there are some optional
On 04/13/14 02:55, Gabriel L. Somlo wrote:
> Kevin,
>
> Thanks for the comments. I'll work your feedback (and any other
> feedback I get by early next week) into another iteration of smbios
> patches for both SeaBIOS and QEMU.
>
> In the mean time, there's one remaining "big picture" design quest
On 04/14/14 04:27, Amos Kong wrote:
> We already have a function buffer_is_zero() in util/cutils.c
>
> Signed-off-by: Amos Kong
> ---
> arch_init.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 60c975d..342e5dc 100644
> --- a
On 04/14/14 20:47, Pieter Hollants wrote:
> Public bug reported:
>
> libvirtd 1.2.3
> virt-manager 1.0.1
> qemu 1.7.92 (2.0.0-rc2)
I think this should be fixed by Cole's patch, in rc3:
commit 92b3eeadd9bc72f1f4e5ba1f62a289dc0190e88f
Author: Cole Robinson
Date: Thu Apr 10 14:47:38 2014 -0400
On 04/15/14 01:55, Michael R. Hines wrote:
> On 04/14/2014 05:19 PM, Laszlo Ersek wrote:
>> On 04/14/14 04:27, Amos Kong wrote:
>>> We already have a function buffer_is_zero() in util/cutils.c
>>>
>>> Signed-off-by: Amos Kong
>>> ---
>>&g
On 04/15/14 11:58, Dr. David Alan Gilbert wrote:
> * Kevin Grandemange (grandemange.ke...@gmail.com) wrote:
>> Hi,
>>
>> I was wondering if a document describing how the differents parts of Qemu
>> worked together existed and if someone could pinpoint it to me. (or explain
>> it to me ;) )
>> This
to 83d08f26 ("pc: map PCI address space as catchall region
for not mapped addresses").
Signed-off-by: Laszlo Ersek
---
include/hw/i386/pc.h | 1 +
hw/i386/pc_piix.c| 1 +
hw/pci-host/piix.c | 11 ++-
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/inclu
On 12/22/13 16:34, Gabriel L. Somlo wrote:
> AppleSMC (-device isa-applesmc) is required to boot OS X guests.
> OS X expects a SMC node to be present in the ACPI DSDT. This patch
> adds a SMC node to the DSDT, and dynamically patches the return value
> of SMC._STA to either 0x0B if the chip is pres
On 12/22/13 18:14, Gabriel L. Somlo wrote:
> On Sun, Dec 22, 2013 at 04:58:58PM +0100, Laszlo Ersek wrote:
>> After this patch, ISA interrupt 6 is used by both "SMC" and "FDC0". The
>> latter depends on the FDEN object, but FDEN is currently constant 1.
>>
On 12/23/13 17:24, Igor Mammedov wrote:
> On Mon, 23 Dec 2013 16:48:49 +0200
> "Michael S. Tsirkin" wrote:
>
>> On Mon, Dec 23, 2013 at 02:06:27PM +0100, Igor Mammedov wrote:
>>> On Mon, 23 Dec 2013 13:26:37 +0200
>>> "Michael S. Tsirkin" wrote:
Interesting. This seems to imply that it can
ohan
> ---
> dump.c | 16
> 1 files changed, 8 insertions(+), 8 deletions(-)
I assume the direct calls to fd_write_vmcore() (which we're not
replacing here) will be substituted / abstracted later on in the series.
Reviewed-by: Laszlo Ersek
mu_write_full(fd, buf, sizeof(buf));
> +if (written_size != sizeof(buf)) {
> +return -1;
> +}
> +
> +return 0;
> +}
I might have coded this in different style (using a union etc), but
that's not your problem :)
> [...]
Reviewed-by: Laszlo Ersek
ze)
> +{
You might have wanted to const-qualify "*buf" here, but it certainly
doesn't warrant a respin.
Reviewed-by: Laszlo Ersek
uf" would have been preferable.
Addition to a pointer-to-void is a constraint violation in standard C
("... operand shall be a pointer to an object type ..."), ie. it's a gcc
extension here, but I guess we can live with it.
Using s->note_size as limit seems correct.
> +
> +s->note_buf_offset += size;
> +
> +return 0;
> +}
> +
> static ram_addr_t get_start_block(DumpState *s)
> {
> GuestPhysBlock *block;
>
Reviewed-by: Laszlo Ersek
he snappy libs and headers installed."
> +fi
> +
> +libs_softmmu="$libs_softmmu -lsnappy"
> +fi
> +
> +##
> # libseccomp check
>
> if test "$seccomp" != "no" ; then
> @@ -4135,6 +4177,14 @@ if test "$glx" = "yes" ; then
>echo "GLX_LIBS=$glx_libs" >> $config_host_mak
> fi
>
> +if test "$lzo" = "yes" ; then
> + echo "CONFIG_LZO=y" >> $config_host_mak
> +fi
> +
> +if test "$snappy" = "yes" ; then
> + echo "CONFIG_SNAPPY=y" >> $config_host_mak
> +fi
> +
> if test "$libiscsi" = "yes" ; then
>echo "CONFIG_LIBISCSI=y" >> $config_host_mak
> fi
>
You could have displayed the lzo / snappy settings along with the other
settings in the "big echo block". But it's not too important; if you
want you can add it later.
Reviewed-by: Laszlo Ersek
On 01/07/14 07:25, Qiao Nuohan wrote:
> On 01/07/2014 03:25 AM, Laszlo Ersek wrote:
>> You could have displayed the lzo / snappy settings along with the other
>> settings in the "big echo block". But it's not too important; if you
>> want you can add it lat
On 01/07/14 07:32, Qiao Nuohan wrote:
> Hello Eric, Luiz and Laszlo,
>
> What do you think about my series? And I have add the light-weight
> introspection in the last patch, do you have some comments on it?
I haven't finished reviewing it yet, but thus far (up to & including
patch 05) I'm OK wit
> +/* write note */
> +s->note_buf = g_malloc0(s->note_size);
> +s->note_buf_offset = 0;
> +
> + /* use s->note_buf to store notes temporarily */
> +if (write_elf64_notes(buf_write_note, s) < 0) {
> +ret = -1;
> +goto out;
> +}
> +
> +if (write_buffer(s->fd, s->flag_flatten, kh->offset_note, s->note_buf,
> + s->note_size) < 0) {
> +ret = -1;
> +goto out;
> +}
> +
> +/* get offset of dump_bitmap */
> +s->offset_dump_bitmap = (DISKDUMP_HEADER_BLOCKS + dh->sub_hdr_size) *
> + dh->block_size;
> +
> +/* get offset of page */
> +s->offset_page = (DISKDUMP_HEADER_BLOCKS + dh->sub_hdr_size +
> + dh->bitmap_blocks) * dh->block_size;
> +
> +out:
> +g_free(dh);
> +g_free(kh);
> +g_free(s->note_buf);
> +
> +return ret;
> +}
I diffed this against the 32-bit version of the function, and the only
"suprising" difference is
-+s->note_buf = g_malloc(s->note_size);
++s->note_buf = g_malloc0(s->note_size);
which I already mentioned above.
I couldn't find anything in this patch that I'd call a direct bug. I
think you can address what you want from the above later too.
Reviewed-by: Laszlo Ersek
const struct GuestPhysBlockList *guest_phys_blocks);
>
I feel that stuff that depends on page size should be centralized
somehow. I can't describe it very well now, but I feel that having a
bunch of macros that open-code the page size as 4096, and using struct
members elsewhere (with dynamically set values) for the same purpose, is
a mess.
However that could be refactored in a separate series, *if* you think it
would be worthwhile.
Reviewed-by: Laszlo Ersek
UMP_SIGNATURE "KDUMP "
> #define SIG_LEN (sizeof(KDUMP_SIGNATURE) - 1)
> #define PHYS_BASE (0)
> #define DUMP_LEVEL (1)
> #define DISKDUMP_HEADER_BLOCKS (1)
> +#define BUFSIZE_BITMAP (PAGE_SIZE)
> +#define PFN_BUFBITMAP (CHAR_BIT * BUFSIZE_BITMAP)
> +#define ARCH_PFN_OFFSET (0)
> +
> +#define paddr_to_pfn(X, page_shift) \
> +(((unsigned long long)(X) >> (page_shift)) - ARCH_PFN_OFFSET)
>
> typedef struct ArchDumpInfo {
> int d_machine; /* Architecture */
>
I think these magic constants are somewhat tied to x86, and therefore
should be in an arch-specific file rather than a common file, but
whoever wants to extend this to another architecture can do that.
I think I haven't found anything that I'd call a bug.
Reviewed-by: Laszlo Ersek
On 01/07/14 15:49, Laszlo Ersek wrote:
>
> On 01/05/14 08:27, Qiao Nuohan wrote:
>> diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h
>> index 9e47b4c..b5eaf8d 100644
>> --- a/include/sysemu/dump.h
>> +++ b/include/sysemu/dump.h
>> @@ -27,11 +27,18 @
comments below
On 01/05/14 08:27, Qiao Nuohan wrote:
> functions are used to write page to vmcore. vmcore is written page by page.
> page desc is used to store the information of a page, including a page's size,
> offset, compression format, etc.
>
> Signed-off-by: Qiao Nuohan
> ---
> dump.c
comments below
On 01/05/14 08:27, Qiao Nuohan wrote:
> Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
> format. The command's usage:
>
> dump [-p] protocol [begin] [length] [format]
>
> 'format' is used to specified the format of vmcore and can be:
> 1. 'elf': ELF
comments below
On 01/05/14 08:27, Qiao Nuohan wrote:
> 'query-dump-guest-memory-capability' is used to query whether option 'format'
> is available for 'dump-guest-memory' and the available format. The output
> of the command will be like:
>
> -> { "execute": "query-dump-guest-memory-capability"
; 3 files changed, 7 insertions(+), 6 deletions(-)
>
It looks sane to me (which might not mean much of course).
series
Reviewed-by: Laszlo Ersek
On 11/28/13 17:03, Laszlo Ersek wrote:
> Mike,
>
> On 11/27/13 12:57, Gerd Hoffmann wrote:
>> Make the 32bit pci hole start at end of ram, so all possible address
>> space is covered. Of course the firmware can use less than that.
>> Leaving space unused is no proble
On 01/13/14 11:03, Qiao Nuohan wrote:
> Sorry for responsing late.
>
> On 01/07/2014 07:38 PM, Laszlo Ersek wrote:
>>> > +kh->offset_note = DISKDUMP_HEADER_BLOCKS * dh->block_size +
>>> size;
>>> > +kh->note_size = s->not
On 01/14/14 03:07, Qiao Nuohan wrote:
> On 01/13/2014 06:39 PM, Laszlo Ersek wrote:
>>>> >>
>>>> >> - When this write_buffer() is directed to a regular file in
>>>> non-flat
>>>> >> mode, then the file might become sparse (y
Hi,
On 01/21/14 10:56, Qiao Nuohan wrote:
> Do you have some comments on the version?
it's in my review queue. The last version took a lot of energy on my
part to review (it's long and complex) so I'm still "gearing up".
I very much hope I can review this version by diffing it with the last
ver
i, (uint64_t)run->internal.data[i]);
> }
> -} else {
> -fprintf(stderr, "\n");
> }
> if (run->internal.suberror == KVM_INTERNAL_ERROR_EMULATION) {
> fprintf(stderr, "emulation failure\n");
>
Based on earlier discussion
Reviewed-by: Laszlo Ersek
Not sure how much it counts, but I personally can agree with you on this
direction :)
One note below:
> @@ -603,8 +604,72 @@ acpi_setup(void)
> if (! CONFIG_ACPI)
> return;
>
> +int acpi_generate = 1;
> +
> dprintf(3, "init ACPI tables\n");
>
> +struct romfile_s *fi
On 04/29/13 14:39, Kevin O'Connor wrote:
> On Mon, Apr 29, 2013 at 11:20:15AM +0300, Michael S. Tsirkin wrote:
>> in particular, seabios wants to interpret presence
>> of any file in etc/acpi as a signal not to generate
>> its own tables.
>
> Right.
In that case,
>> So merging this patch but wi
On 05/04/13 17:22, akoskov...@gmx.com wrote:
> From: Ákos Kovács
>
> Cc: Laszlo Ersek
> Signed-off-by: Ákos Kovács
> ---
> po/hu.po | 63
> ++
> 1 files changed, 63 insertions(+), 0 deletions(-)
> creat
On 05/05/13 21:29, Paolo Bonzini wrote:
> Il 05/05/2013 20:47, Laszlo Ersek ha scritto:
>>> +
>>> +#: ../ui/gtk.c:1252
>>> +msgid "_Pause"
>>> +msgstr "_Megállítva"
>>
>> I think the word is used here as a verb, ie.
On 05/05/13 22:11, BALATON Zoltan wrote:
> On Sun, 5 May 2013, Laszlo Ersek wrote:
>> On 05/04/13 17:22, akoskov...@gmx.com wrote:
>>> +#: ../ui/gtk.c:217
>>> +msgid " [Paused]"
>>> +msgstr " [Leállítva]"
>>
>> Hrmph. Yet anot
On 05/06/13 19:14, akoskov...@gmx.com wrote:
> From: Ákos Kovács
>
> Cc: Laszlo Ersek
> Signed-off-by: Ákos Kovács
> ---
> Changes in v2:
> * Fixed input release/grab translations
> * Fixed inconsistency with the "leállítva"/"
On 05/06/13 22:49, Andreas Färber wrote:
> Am 06.05.2013 19:14, schrieb akoskov...@gmx.com:
>> From: Ákos Kovács
>>
>> Cc: Laszlo Ersek
>> Signed-off-by: Ákos Kovács
>> ---
>> Changes in v2:
>> * Fixed input release/grab translations
>
On 05/07/13 10:01, Paolo Bonzini wrote:
> Il 07/05/2013 09:22, Laszlo Ersek ha scritto:
>>>> diff --git a/po/hu.po b/po/hu.po
>>>> new file mode 100644
>>>> index 000..340709f
>>>> --- /dev/null
>>>> +++ b/po/hu.po
>>>>
In Windows guests this may make a difference.
Suggested-by: Eric Blake
Signed-off-by: Laszlo Ersek
---
qga/commands-posix.c | 22 --
1 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 04c6951..2eec712 100644
We shouldn't allow guest filesystem pollution on error paths.
Suggested-by: Eric Blake
Signed-off-by: Laszlo Ersek
---
qga/commands-posix.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 2eec712..d301b1f 100644
On 05/07/13 19:30, Eric Blake wrote:
> On 05/07/2013 10:56 AM, Laszlo Ersek wrote:
>> We shouldn't allow guest filesystem pollution on error paths.
>>
>> Suggested-by: Eric Blake
>> Signed-off-by: Laszlo Ersek
>> ---
>> qga/commands-posix.c |
-off-by: Laszlo Ersek
---
qga/commands-posix.c | 22 --
1 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 04c6951..2eec712 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -242,17 +242,27 @@ static
We shouldn't allow guest filesystem pollution on error paths.
Suggested-by: Eric Blake
Signed-off-by: Laszlo Ersek
---
qga/commands-posix.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 2eec712..e199738 100644
I should have paid more attention to portability and error path cleanup
in the CVE-2013-2007 fix.
(We continue to assume, like the rest of qemu code, that
qemu_set_cloexec() never fails internally. This should be a reasonable
assumption when the input fd is valid.)
Laszlo Ersek (2):
qga
On 05/09/13 01:33, Michael Roth wrote:
> +case PTYPE_NUMBER: {
> +numberList *ptr;
> +char *double1, *double2;
> +if (cur_head) {
> +ptr = cur_head;
> +cur_head = ptr->next;
> +} else {
> +cur_h
On 05/09/13 13:42, Gonglei (Arei) wrote:
> Hi all,
>we use the command "virsh edit" to modify the VM configuration
> information online on KVM Platform(libvirt-1.0.0 and qemu-1.4),
> but it does not take effect after reboot. However, it works fine on Xen
> Platform.
>
>for an example
On 05/09/13 01:33, Michael Roth wrote:
> These patches apply on top of qemu.git master, and can also be obtained from:
> git://github.com/mdroth/qemu.git qapi-native-lists
>
> Sending this now since a number of series have popped up in the past that
> wanted this, and Amos has some pending patches
On 05/10/13 04:20, Michael Roth wrote:
> Currently our JSON parser assumes that numbers lacking a mantissa are
> integers and attempts to store them as QInt/int64 values. This breaks in
> the case where the number overflows/underflows int64 values (which is
> still valid JSON)
>
> Fix this by dete
501 - 600 of 4218 matches
Mail list logo
