Mark Burton writes:
>> On 13 Feb 2015, at 08:24, Peter Maydell wrote:
>>
>> On 13 February 2015 at 07:16, Mark Burton wrote:
>>> If the kernel is doing this - then effectively - for X86, each CPU only
>>> flush’s it’s own TLB (from the perspective of Qemu) - correct?
>>> (in which case, for Qem
Bastian Koppelmann writes:
> There is no overview, that shows all the frontend operation one can use, as
> found on the wiki. Unfortunatly the wiki is out of date, so let's try to move
> this documentation to the source files, which has the benefit, that it is easy
> to update the documentation, i
Bastian Koppelmann writes:
> On 01/14/2015 03:36 PM, Lluís Vilanova wrote:
>> Bastian Koppelmann writes:
>>
>>> There is no overview, that shows all the frontend operation one can use, as
>>> found on the wiki. Unfortunatly the wiki is out of date, s
Richard Henderson writes:
> On 01/14/2015 10:15 AM, Lluís Vilanova wrote:
>> Sorry I wasn't clear. I meant that it might be better to remove tcg/README
>> and
>> instead document all the operations (those in the readme and the additional
>> ones) in the header
Peter Maydell writes:
> I was looking at our confusing mess of memory accessor functions,
> and I realised that partly it was confusing because we have a
> bunch of unnecessary junk lurking in there :-) This series
> attempts to clean things up by removing things we weren't using
> at all or were
Peter Maydell writes:
> On 15 January 2015 at 15:32, Lluís Vilanova wrote:
>> I haven't reviewed the patches, but that's a much appreciated cleanup! I was
>> also trying to make sense of all the variants while implementing guest memory
>> access tracing
> I dre
Stefan Hajnoczi writes:
> On Sun, Nov 02, 2014 at 10:37:59PM +0100, christoph.seif...@posteo.de wrote:
>> From: Christoph Seifert
>>
>> simpletrace.py does not recognize the tcg option while reading trace-events
>> file. In result simpletrace does not work on binary traces and tcg enabled
>> eve
Mark Burton writes:
> Hi all,
> We are now actively going to pursue TCG Multithreading to improve the
> performance of the TCG for Qemu models that include multiple cores.
> We have set up a wiki page to track the project
> http://wiki.qemu.org/Features/tcg-multithread
> At this point, I would
Mark Burton writes:
> All - first a huge thanks for those who have contributed, and those who have
> expressed an interest in helping out.
> One issue I’d like to see more opinions on is the question of a cache per
> core,
> or a shared cache.
> I have heard anecdotal evidence that a shared cach
Alexander Graf writes:
> On 01.12.14 22:00, Lluís Vilanova wrote:
>> Mark Burton writes:
>>
>>> All - first a huge thanks for those who have contributed, and those who have
>>> expressed an interest in helping out.
>>
>>> One issue I’d like to see
Frederic Konrad writes:
> Hi everybody,
> Here is the plan we will follow:
> We will be focusing - from the outset - on the end goal of multi-threaded TCG
> in full system emulation mode. On the way, we expect this will ‘fix’ user
> mode.
> The plan is:
> * Create one cache per CPU as a first
Mark Burton writes:
> We will roll a patch for this approach shortly.
> For the ‘better’ approach - I think it’s something we will consider doing….
> but as you say, one thing at a time.
> I dont think it will be too bad to implement, given what already exists in the
> tlb’s - (except if we have
Mark Burton writes:
> (please note the address of the match list server is
> mt...@listserver.greensocs.com)
> On 9 Dec 2014, at 18:57, Lluís Vilanova wrote:
> Frederic Konrad writes:
> Hi everybody,
> Here is the plan we will follow:
Alexey Kardashevskiy writes:
> On 05/21/2014 06:16 PM, Alexey Kardashevskiy wrote:
>> At the moment QEMU exits if trace point is not defined which makes
>> a developer life harder if he has to switch between branches with
>> different traces implemented.
>>
>> This replaces error+exit wit WARNING
Stefan Hajnoczi writes:
> On Tue, May 13, 2014 at 08:04:13PM +0200, Lluís Vilanova wrote:
>> Adds support to compile QEMU with multiple tracing backends at the same time.
>>
>> For example, you can compile QEMU with:
>>
>> $ ./configure --enable-trace-backends=f
used to extract more information from the system.
This patch allows having both available without recompiling QEMU.
Signed-off-by: Lluís Vilanova
---
.travis.yml |8 +++--
Makefile |4 +--
Makefile.target |
Lluís Vilanova writes:
> Adds support to compile QEMU with multiple tracing backends at the same time.
> For example, you can compile QEMU with:
> $ ./configure --enable-trace-backends=ftrace,dtrace
> Where 'ftrace' can be handy for having an in-flight record of events,
Stefan Hajnoczi writes:
> This new tracetool "format" generates a SystemTap .stp file that outputs
> simpletrace binary trace data.
> In contrast to simpletrace or ftrace, SystemTap does not define its own
> trace format. All output from SystemTap is generated by .stp files.
> This patch lets us
Stefan Hajnoczi writes:
> On Wed, May 21, 2014 at 06:16:01PM +1000, Alexey Kardashevskiy wrote:
>> At the moment QEMU exits if trace point is not defined which makes
>> a developer life harder if he has to switch between branches with
>> different traces implemented.
>>
>> This replaces error+exi
Alexey Kardashevskiy writes:
> On 05/28/2014 10:34 PM, Lluís Vilanova wrote:
>> Stefan Hajnoczi writes:
>>
>>> On Wed, May 21, 2014 at 06:16:01PM +1000, Alexey Kardashevskiy wrote:
>>>> At the moment QEMU exits if trace point is not defined which makes
>&
Otherwise the user has to explicitly include an auto-generated header.
Signed-off-by: Lluís Vilanova
---
include/trace.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace.h b/include/trace.h
index c15f498..44a1f1f 100644
--- a/include/trace.h
+++ b/include/trace.h
@@ -2,5
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/transform.py | 166
1 file changed, 166 insertions(+)
create mode 100644 scripts/tracetool/transform.py
diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py
new file mode
ate the TCG code to later trace the event at execution time.
Signed-off-by: Lluís Vilanova
---
.gitignore|1 +
Makefile |2 +
include/trace-tcg.h |7 +
scripts/tracetool/format/tcg_h.py | 56 +++
Transforms event:
tcg name(...) "...", "..."
into two internal events:
tcg-trans name_trans(...) "..."
tcg-exec name_exec(...) "..."
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py| 64 +++-
7;trace_${event}_exec'.
Signed-off-by: Lluís Vilanova
---
.gitignore |1 +
Makefile |1 +
Makefile.objs|7
Makefile.target |5 +++
scripts/tracetool/format/tc
Signed-off-by: Lluís Vilanova
---
docs/tracing.txt | 40
1 file changed, 40 insertions(+)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index c6ab1c1..2e035a5 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -307,3 +307,43 @@ guard such
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index e8e8edc..bd3fd85 100644
--- a/scripts/tracetool/__init__.py
Signed-off-by: Lluís Vilanova
---
target-alpha/helper.h |2 ++
target-arm/helper.h|2 ++
target-cris/helper.h |2 ++
target-i386/helper.h |2 ++
target-lm32/helper.h |2 ++
target-m68k/helper.h |2 ++
target-microblaze/helper.h |2
r_trace_${event}_exec_proxy'.
* helper_trace_${event}_exec_proxy
TCG helper to cast TCG-compatible argument types to native types and call
tracing routine 'trace_${event}_exec'.
NOTE: 'gen_gelper_trace_${event}_exec_proxy' is generated by the TCG helper
m
I forgot to add the cover. I'll resend as v3 with a cover.
Sorry,
Lluis
must use 'uint32_t' instead of 'bool').
* trace_${name}_exec(bool, uint64_t)
Declared: "trace/generated-tracers.h"
Defined : "trace/generated-tracers.h"
Invokes the actual tracing backends for the execution-time event.
Signed-off-by: Lluís Vilanova
---
Ch
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index e8e8edc..bd3fd85 100644
--- a/scripts/tracetool/__init__.py
Transforms event:
tcg name(...) "...", "..."
into two internal events:
tcg-trans name_trans(...) "..."
tcg-exec name_exec(...) "..."
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py| 64 +++-
7;trace_${event}_exec'.
Signed-off-by: Lluís Vilanova
---
.gitignore |1 +
Makefile |1 +
Makefile.objs|7
Makefile.target |5 +++
scripts/tracetool/format/tc
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/transform.py | 166
1 file changed, 166 insertions(+)
create mode 100644 scripts/tracetool/transform.py
diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py
new file mode
Signed-off-by: Lluís Vilanova
---
docs/tracing.txt | 40
1 file changed, 40 insertions(+)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index c6ab1c1..2e035a5 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -307,3 +307,43 @@ guard such
Signed-off-by: Lluís Vilanova
---
target-alpha/helper.h |2 ++
target-arm/helper.h|2 ++
target-cris/helper.h |2 ++
target-i386/helper.h |2 ++
target-lm32/helper.h |2 ++
target-m68k/helper.h |2 ++
target-microblaze/helper.h |2
Otherwise the user has to explicitly include an auto-generated header.
Signed-off-by: Lluís Vilanova
---
include/trace.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace.h b/include/trace.h
index c15f498..44a1f1f 100644
--- a/include/trace.h
+++ b/include/trace.h
@@ -2,5
ate the TCG code to later trace the event at execution time.
Signed-off-by: Lluís Vilanova
---
.gitignore|1 +
Makefile |2 +
include/trace-tcg.h |7 +
scripts/tracetool/format/tcg_h.py | 56 +++
Signed-off-by: Lluís Vilanova
---
target-alpha/translate.c |3 +++
target-arm/translate-a64.c|2 ++
target-arm/translate.c|3 +++
target-cris/translate.c |3 +++
target-i386/translate.c |3 +++
target-lm32/translate.c |3 +++
target-m68k
Signed-off-by: Lluís Vilanova
---
target-alpha/translate.c |3 +++
target-arm/translate-a64.c|2 ++
target-arm/translate.c|3 +++
target-cris/translate.c |3 +++
target-i386/translate.c |3 +++
target-lm32/translate.c |3 +++
target-m68k
r_trace_${event}_exec_proxy'.
* helper_trace_${event}_exec_proxy
TCG helper to cast TCG-compatible argument types to native types and call
tracing routine 'trace_${event}_exec'.
NOTE: 'gen_gelper_trace_${event}_exec_proxy' is generated by the TCG helper
m
Richard Henderson writes:
> On 05/28/2014 10:42 AM, Lluís Vilanova wrote:
>> Files generating guest code (TCG) must include "trace-tcg.h". Files declaring
>> per-target helpers ("${target}/helper.h") must include
>> "trace/generated-helpers.h&qu
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/transform.py | 166
1 file changed, 166 insertions(+)
create mode 100644 scripts/tracetool/transform.py
diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py
new file mode
to the appropriate type before
calling "trace_${name}_exec".
This is necessary because TCG helpers can only receive a limited number of
argument types (e.g., must use 'uint32_t' instead of 'bool').
* trace_${name}_exec(bool, uint64_t)
Declared: "trace/gener
Transforms event:
tcg name(...) "...", "..."
into two internal events:
tcg-trans name_trans(...) "..."
tcg-exec name_exec(...) "..."
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py| 64 +++-
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index e8e8edc..bd3fd85 100644
--- a/scripts/tracetool/__init__.py
Signed-off-by: Lluís Vilanova
---
docs/tracing.txt | 40
1 file changed, 40 insertions(+)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index c6ab1c1..2e035a5 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -307,3 +307,43 @@ guard such
r_trace_${event}_exec_proxy'.
* helper_trace_${event}_exec_proxy
TCG helper to cast TCG-compatible argument types to native types and call
tracing routine 'trace_${event}_exec'.
NOTE: 'gen_gelper_trace_${event}_exec_proxy' is generated by the TCG helper
m
Signed-off-by: Lluís Vilanova
---
include/exec/helper-gen.h |3 +++
include/exec/helper-proto.h |1 +
include/exec/helper-tcg.h |1 +
3 files changed, 5 insertions(+)
diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h
index a04a034..ba5a379 100644
--- a/include
Signed-off-by: Lluís Vilanova
---
target-alpha/translate.c |3 +++
target-arm/translate-a64.c|2 ++
target-arm/translate.c|3 +++
target-cris/translate.c |3 +++
target-i386/translate.c |3 +++
target-lm32/translate.c |3 +++
target-m68k
7;trace_${event}_exec'.
Signed-off-by: Lluís Vilanova
---
.gitignore |1 +
Makefile |1 +
Makefile.objs|7
Makefile.target |5 +++
scripts/tracetool/format/tc
or is not traceable.
Thanks,
Lluis
> This moves local variables to the beginning of the function because of
> the QEMU coding style.
> Suggested-by: Lluís Vilanova
> Signed-off-by: Alexey Kardashevskiy
> ---
> Lluís, or it is s/Suggested-by/From/ ?
> Stefan, this is
Otherwise the user has to explicitly include an auto-generated header.
Signed-off-by: Lluís Vilanova
---
include/trace.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace.h b/include/trace.h
index c15f498..44a1f1f 100644
--- a/include/trace.h
+++ b/include/trace.h
@@ -2,5
ate the TCG code to later trace the event at execution time.
Signed-off-by: Lluís Vilanova
---
.gitignore|1 +
Makefile |2 +
include/trace-tcg.h |7 +
scripts/tracetool/format/tcg_h.py | 57 +++
Richard Henderson writes:
> On 05/29/2014 05:23 AM, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova
>> ---
>> target-alpha/translate.c |3 +++
>> target-arm/translate-a64.c|2 ++
>> target-arm/translate.c|3 +++
>&g
Richard Henderson writes:
> On 05/29/2014 05:23 AM, Lluís Vilanova wrote:
>>
>> #include "helper.h"
>> +#define HELPER_GEN_TRACE_PROXY 1
>> +#include "trace/generated-helpers.h"
>> +#undef HELPER_GEN_TRACE_PROXY
>> #include "tc
pper that casts arguments to the appropriate type before
calling "trace_${name}_exec".
This is necessary because TCG helpers can only receive a limited number of
argument types (e.g., must use 'uint32_t' instead of 'bool').
* trace_${name}_exec(b
Signed-off-by: Lluís Vilanova
---
docs/tracing.txt | 40
1 file changed, 40 insertions(+)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index c6ab1c1..2e035a5 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -307,3 +307,43 @@ guard such
Signed-off-by: Lluís Vilanova
---
include/exec/helper-gen.h |2 ++
include/exec/helper-proto.h |1 +
include/exec/helper-tcg.h |1 +
3 files changed, 4 insertions(+)
diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h
index a04a034..0d0da3a 100644
--- a/include
Transforms event:
tcg name(...) "...", "..."
into two internal events:
tcg-trans name_trans(...) "..."
tcg-exec name_exec(...) "..."
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py| 64 +++-
Otherwise the user has to explicitly include an auto-generated header.
Signed-off-by: Lluís Vilanova
---
include/trace.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace.h b/include/trace.h
index c15f498..44a1f1f 100644
--- a/include/trace.h
+++ b/include/trace.h
@@ -2,5
ts") and call
the tracing routine ('trace_${event}_exec').
Signed-off-by: Lluís Vilanova
---
.gitignore |1 +
Makefile |1 +
Makefile.objs|7
Makefile.target
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/transform.py | 166
1 file changed, 166 insertions(+)
create mode 100644 scripts/tracetool/transform.py
diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py
new file mode
nt}_exec_proxy').
Signed-off-by: Lluís Vilanova
---
.gitignore |1
Makefile |1
scripts/tracetool/format/tcg_helper_wrapper_h.py | 70 ++
trace/Makefile.objs
Generates file "trace/generated-helpers.h" with TCG helper declarations to trace
events in guest code at execution time ('trace_${event}_exec_proxy').
Signed-off-by: Lluís Vilanova
---
.gitignore |1 +
Makefile
ate the TCG code to later trace the event at execution time.
Signed-off-by: Lluís Vilanova
---
.gitignore|1 +
Makefile |2 +
include/trace-tcg.h |7 +
scripts/tracetool/format/tcg_h.py | 57 +++
Signed-off-by: Lluís Vilanova
---
target-alpha/translate.c |3 +++
target-arm/translate-a64.c|2 ++
target-arm/translate.c|3 +++
target-cris/translate.c |3 +++
target-i386/translate.c |3 +++
target-lm32/translate.c |3 +++
target-m68k
Signed-off-by: Lluís Vilanova
---
scripts/tracetool/__init__.py | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index e8e8edc..bd3fd85 100644
--- a/scripts/tracetool/__init__.py
Alexey Kardashevskiy writes:
> On 05/29/2014 10:42 PM, Lluís Vilanova wrote:
>> Alexey Kardashevskiy writes:
>>
>>> This replaces fprintf(stderr) with error_report.
>>> This prints line number of the trace which does not exist or is not
>>> traceable.
&
Alexey Kardashevskiy writes:
> On 05/31/2014 12:08 AM, Lluís Vilanova wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 05/29/2014 10:42 PM, Lluís Vilanova wrote:
>>>> Alexey Kardashevskiy writes:
>>>>
>>>>> This replaces fprintf(
Stefan Hajnoczi writes:
> The Makefile uses intermediate timestamp files to avoid rebuilding if
> tracetool output is unchanged.
> Timestamps are implemented incorrectly. This was fixed for rules.mak in
> commit 4b25966ab976f3a7fd9008193b2defcc82f8f04d ("rules.mak: cleanup
> config generation ru
Stefan Hajnoczi writes:
> Patches that change tracetool can break the build if old build output
> files are lying around.
> This happens because the Makefile does not specify dependencies on
> tracetool. The build will use old object files that do not match the
> current source code.
> Signed-o
Stefan Hajnoczi writes:
> v2:
> * Use find(1) to catch all tracetool *.py files [Lluís]
>Note: I used find -name instead of find -path for better POSIX compliance
Looks great to me.
Thanks,
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the
Bastian Koppelmann writes:
> Hi Peter,
> thank you for your feedback.
>> (2) it feels a bit unpolished at the moment (lack of documentation,
>> doesn't have any existing analysis tools that produce the format that
>> the code reads that would make it immediately usable by an end-user)
>>
> Sure
Thomas Huth writes:
> On 20.01.2016 15:10, Lluís Vilanova wrote:
>> Thomas Huth writes:
>>
>>> On 18.01.2016 21:26, Eric Blake wrote:
>>>> On 01/15/2016 06:54 AM, Lluís Vilanova wrote:
>>>>> Gives some general guidelines for reporting errors
Lluís Vilanova writes:
> Thomas Huth writes:
>> On 20.01.2016 15:10, Lluís Vilanova wrote:
>>> Thomas Huth writes:
>>>
>>>> On 18.01.2016 21:26, Eric Blake wrote:
>>>>> On 01/15/2016 06:54 AM, Lluís Vilanova wrote:
>>>
Bastian Koppelmann writes:
> Hi Lluis,
> On 01/27/2016 07:54 PM, Lluís Vilanova wrote:
>> There is this modified version I wrote [1], which precisely provides a plugin
>> infrastructure to attach callbacks into guest code events (a binary
>> instrumentation framework bas
Thomas Huth writes:
> On 27.01.2016 20:20, Lluís Vilanova wrote:
>> Lluís Vilanova writes:
>>
>>> Thomas Huth writes:
>>>> On 20.01.2016 15:10, Lluís Vilanova wrote:
>>>>> Thomas Huth writes:
>>>>>
>>>>>> O
In linux-user builds, the LTTng backend pulls "syscall.h", which
resets defines in "errno_defs.h", while "qemu.h" pulls "errno_defs.h"
after "syscall.h" has been included.
Signed-off-by: Lluís Vilanova
---
translate-all.c |2 +-
1 file ch
r_report()'
[suggested by Markus Armbruster].
Changes in v2
=
* Split in two patches.
* Explicitly add a warning error object.
Signed-off-by: Lluís Vilanova
---
Lluís Vilanova (5):
util: Introduce error reporting functions with fatal/abort
util: Use new error_report_f
r_report()'
[suggested by Markus Armbruster].
Changes in v2
=
* Split in two patches.
* Explicitly add a warning error object.
Signed-off-by: Lluís Vilanova
---
Lluís Vilanova (5):
util: Introduce error reporting functions with fatal/abort
util: Use new error_report_f
Provide two lean functions to report error messages that fatal/abort
QEMU.
Signed-off-by: Lluís Vilanova
---
include/qemu/error-report.h | 19 +++
util/qemu-error.c | 33 +
2 files changed, 52 insertions(+)
diff --git a/include/qemu
Replaces all direct uses of 'error_setg(&error_fatal/abort)' with
'error_report_fatal/abort'. Also reimplements the former on top of the
latter.
Signed-off-by: Lluís Vilanova
---
hw/block/fdc.c |6 +++---
hw/ppc/spapr.c |8
hw/ppc/spapr_drc.c
Signed-off-by: Lluís Vilanova
---
target-ppc/kvm.c|5 +--
target-ppc/translate.c |7 ++--
target-ppc/translate_init.c | 80 +--
3 files changed, 44 insertions(+), 48 deletions(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
Signed-off-by: Lluís Vilanova
---
target-ppc/kvm.c|4 ++--
target-ppc/kvm_ppc.h| 15 +--
target-ppc/mmu-hash32.c |5 +++--
target-ppc/mmu_helper.c |3 +--
4 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
Gives some general guidelines for reporting errors in QEMU.
Signed-off-by: Lluís Vilanova
---
HACKING | 33 +
1 file changed, 33 insertions(+)
diff --git a/HACKING b/HACKING
index 12fbc8a..f5783d4 100644
--- a/HACKING
+++ b/HACKING
@@ -157,3 +157,36 @@ painful
Signed-off-by: Lluís Vilanova
---
target-ppc/kvm.c|5 +--
target-ppc/translate.c |7 ++--
target-ppc/translate_init.c | 80 +--
3 files changed, 44 insertions(+), 48 deletions(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
* Drop special object 'error_warn' in favour of raw 'error_report()'
[suggested by Markus Armbruster].
Changes in v2
=
* Split in two patches.
* Explicitly add a warning error object.
Signed-off-by: Lluís Vilanova
---
Lluís Vilanova (5):
util: Introduce e
Provide two lean functions to report error messages that fatal/abort
QEMU.
Signed-off-by: Lluís Vilanova
---
include/qemu/error-report.h | 19 +++
util/qemu-error.c | 33 +
2 files changed, 52 insertions(+)
diff --git a/include/qemu
Replaces all direct uses of 'error_setg(&error_fatal/abort)' with
'error_report_fatal/abort'. Also reimplements the former on top of the
latter.
Signed-off-by: Lluís Vilanova
---
hw/block/fdc.c |6 +++---
hw/ppc/spapr.c |8
hw/ppc/spapr_drc.c
Signed-off-by: Lluís Vilanova
---
target-ppc/kvm.c|4 ++--
target-ppc/kvm_ppc.h| 15 +--
target-ppc/mmu-hash32.c |5 +++--
target-ppc/mmu_helper.c |3 +--
4 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
Please ignore this version; I forgot to fix a typo (fixed in v5).
Cheers,
Lluis
Lluís Vilanova writes:
> Adds leaner error-reporting functions for simple cases, and documents the
> purpose of the different facilities available in QEMU.
> Although not all printf+exit/abort are repl
Gives some general guidelines for reporting errors in QEMU.
Signed-off-by: Lluís Vilanova
---
HACKING | 33 +
1 file changed, 33 insertions(+)
diff --git a/HACKING b/HACKING
index 12fbc8a..aecc77c 100644
--- a/HACKING
+++ b/HACKING
@@ -157,3 +157,36 @@ painful
Eric Blake writes:
> On 01/28/2016 02:41 PM, Lluís Vilanova wrote:
>> Gives some general guidelines for reporting errors in QEMU.
>>
>> Signed-off-by: Lluís Vilanova
>> ---
>> HACKING | 33 +
>> 1 file changed, 33 inse
Eric Blake writes:
> On 01/28/2016 02:41 PM, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova
>> ---
>> target-ppc/kvm.c|4 ++--
>> target-ppc/kvm_ppc.h| 15 +--
>> target-ppc/mmu-hash32.c |5 +++--
>> target-ppc/mmu_hel
The LTTng tracing backend includes the system's "syscall.h", but QEMU
replaces it with its own for linux-user builds. This results in a double
include on some targets (when LTTng is enabled).
Signed-off-by: Lluís Vilanova
---
linux-user/aarch64/syscall.h |5 +
l
Peter Maydell writes:
> On 28 January 2016 at 20:36, Lluís Vilanova wrote:
>> The LTTng tracing backend includes the system's "syscall.h", but QEMU
>> replaces it with its own for linux-user builds. This results in a double
>> include on some targets (when LTT
David Gibson writes:
> On Thu, Jan 28, 2016 at 10:53:43PM +0100, Lluís Vilanova wrote:
>> Replaces all direct uses of 'error_setg(&error_fatal/abort)' with
>> 'error_report_fatal/abort'. Also reimplements the former on top of the
>> latter.
>>
Eric Blake writes:
> On 01/28/2016 02:53 PM, Lluís Vilanova wrote:
>> Gives some general guidelines for reporting errors in QEMU.
>>
>> Signed-off-by: Lluís Vilanova
>> ---
>> HACKING | 33 +
>> 1 file changed, 33 insert
601 - 700 of 1848 matches
Mail list logo
