Re: [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown

2013-05-21 Thread Luiz Capitulino
On Fri, 17 May 2013 16:23:51 +0200 Pavel Hrdina phrd...@redhat.com wrote: On 25.4.2013 16:31, Luiz Capitulino wrote: On Thu, 25 Apr 2013 16:29:45 +0200 Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Apr 25, 2013 at 09:51:47AM -0400, Luiz Capitulino wrote: On Mon, 22 Apr 2013 15:53

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-22 Thread Luiz Capitulino
On Wed, 22 May 2013 10:09:19 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-5-20 10:39, Wenchao Xia 写道: 于 2013-5-17 20:30, Luiz Capitulino 写道: On Fri, 17 May 2013 11:30:31 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-5-16 20:17, Luiz Capitulino 写道: On Thu

Re: [Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-22 Thread Luiz Capitulino
On Wed, 22 May 2013 14:37:37 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: Hi eric and luiz, Does you have some comments on this version? I haven't reviewed it yet, but we need introspection support before merging this.

[Qemu-devel] [PATCH] monitor: allow to disable the default monitor

2013-05-22 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx | 1 + vl.c| 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index fb3961d..bf94862 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2528,6 +2528,7

Re: [Qemu-devel] RFC: Full introspection support for QMP

2013-05-22 Thread Luiz Capitulino
On Wed, 22 May 2013 21:40:07 +0800 Amos Kong ak...@redhat.com wrote: Hi all, We already have query-command-line-options to query details of command-line options. As we discussed in the list, we also need full introspection of QMP (command). The qmp-events also need to be dumped, we can

Re: [Qemu-devel] RFC: Full introspection support for QMP

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 07:08:59 -0500 Anthony Liguori aligu...@us.ibm.com wrote: then we don't need introspection at all. There's no user for it then. Introspection is not the right approach to feature discovery. The schema does answer the question of what features are enabled, it just

Re: [Qemu-devel] Designing QMP APIs at KVM Forum

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 13:51:22 +0200 Stefan Hajnoczi stefa...@gmail.com wrote: With better QMP introspection on the horizon and work in various subsystems pushing QMP boundaries it would be useful to bring together the latest best practices for designing QMP APIs. There are design rules for

Re: [Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros

2013-05-23 Thread Luiz Capitulino
On Thu, 16 May 2013 13:19:47 +0800 Amos Kong ak...@redhat.com wrote: It's clearer to use defined macros than magic numbers. Signed-off-by: Amos Kong ak...@redhat.com Applied to the qmp branch, thanks. --- ui/input.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 13:24:59 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 05:07:59PM +0800, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong ak...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 17:57:56 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote: On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: Please stress this is only for the NIC. It does not apply to non-NIC netclients. Stress it in

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 16 May 2013 18:17:23 +0300 Michael S. Tsirkin m...@redhat.com wrote: The existing throttling approach ensures that if the event includes latest guest information, then the host doesn't even have to do do a query, and is guaranteed that reacting to the final event will always see

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 17:08:00 +0800 Amos Kong ak...@redhat.com wrote: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event to notify management of rx-filter

Re: [Qemu-devel] [PATCH V2 4/5] util: add new function message_printf()

2013-05-23 Thread Luiz Capitulino
. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com This solution looks good to me: Reviewed-by: Luiz Capitulino lcapitul...@redhat.com --- include/qemu/error-report.h | 13 + util/qemu-error.c | 28 ++-- 2 files changed, 39 insertions(+), 2

[Qemu-devel] [PULL 00/12] QMP queue

2013-05-23 Thread Luiz Capitulino
The changes (since 95de21a430f7bc4166a153b1f69b1425c8a99c7b) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Amos Kong (1): ui/input.c: replace magic numbers with macros Luiz Capitulino (1): monitor: allow to disable the default monitor

[Qemu-devel] [PULL 02/12] qapi: qapi-visit.py, fix list handling for union types

2013-05-23 Thread Luiz Capitulino
visitors, so use that here as well. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Amos Kong ak...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-visit.py | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 01/12] qapi: qapi-types.py, native list support

2013-05-23 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py | 45 ++--- scripts/qapi.py | 23 +++ 2 files changed, 65 insertions(+), 3 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 9e19920

[Qemu-devel] [PULL 08/12] qapi: add native list coverage for visitor serialization tests

2013-05-23 Thread Luiz Capitulino
From: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Amos Kong ak...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- tests/test-visitor-serialization.c | 451

[Qemu-devel] [PULL 03/12] qapi: qapi-visit.py, native list support

2013-05-23 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-visit.py | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 4c4de4b..6cac05a 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi

[Qemu-devel] [PULL 06/12] qapi: add QMP input test for large integers

2013-05-23 Thread Luiz Capitulino
if we're expected an integer value: errors for out of range integer values that got promoted to doubles in this fashion. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Amos Kong ak...@redhat.com Signed-off-by: Luiz Capitulino lcapitul

[Qemu-devel] [PULL 10/12] qapi: add native list coverage for QMP input visitor tests

2013-05-23 Thread Luiz Capitulino
...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- tests/test-qmp-input-visitor.c | 338 + 1 file changed, 338 insertions(+) diff --git a/tests/test-qmp-input-visitor.c b/tests/test-qmp-input-visitor.c index b308cf9..2741eef 100644

[Qemu-devel] [PULL 09/12] qapi: add native list coverage for QMP output visitor tests

2013-05-23 Thread Luiz Capitulino
...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qapi-schema-test.json | 15 ++ tests/test-qmp-output-visitor.c | 332 2 files changed, 347 insertions(+) diff --git a/qapi-schema-test.json b/qapi-schema-test.json index

[Qemu-devel] [PULL 07/12] qapi: fix visitor serialization tests for numbers/doubles

2013-05-23 Thread Luiz Capitulino
...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- tests/test-visitor-serialization.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/tests/test-visitor-serialization.c b/tests/test-visitor-serialization.c index 8c8adac..fed6810 100644

[Qemu-devel] [PULL 05/12] json-parser: fix handling of large whole number values

2013-05-23 Thread Luiz Capitulino
this by detecting such cases and using a QFloat to store the value instead. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Amos Kong ak...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qobject/json-parser.c | 26

[Qemu-devel] [PULL 11/12] ui/input.c: replace magic numbers with macros

2013-05-23 Thread Luiz Capitulino
From: Amos Kong ak...@redhat.com It's clearer to use defined macros than magic numbers. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- ui/input.c | 13 +++-- 1 file changed, 7 insertions

[Qemu-devel] [PULL 04/12] qapi: enable generation of native list code

2013-05-23 Thread Luiz Capitulino
From: Michael Roth mdr...@linux.vnet.ibm.com Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs qapi-types.c/qapi-visit.c Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Amos Kong ak...@redhat.com Signed-off-by: Luiz

[Qemu-devel] [PULL 12/12] monitor: allow to disable the default monitor

2013-05-23 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx | 1 + vl.c| 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index fb3961d..bf94862 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2528,6 +2528,7

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 20:18:34 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote: On Thu, 16 May 2013 18:17:23 +0300 Michael S. Tsirkin m...@redhat.com wrote: The existing throttling approach ensures that if the event

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 11:08:13 +0800 Amos Kong ak...@redhat.com wrote: On Thu, May 23, 2013 at 12:03:25PM -0400, Luiz Capitulino wrote: On Thu, 23 May 2013 17:08:00 +0800 Amos Kong ak...@redhat.com wrote: A flag is used to avoid events flooding, if user don't query rx-filter after

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 15:10:16 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: On Thu, 23 May 2013 20:18:34 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 11:54:03AM -0400, Luiz Capitulino wrote

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 06:55:44 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 06:23 AM, Luiz Capitulino wrote: I don't think we need this argument. This command is quite simple in its response, let's do this filtering in HMP only. Event message contains the net client name

Re: [Qemu-devel] qmp commands get rejected

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 07:50:33 +0200 Stefan Priebe s.pri...@profihost.ag wrote: Hello list, since upgrading from qemu 1.4.1 to 1.5.0 i've problems with qmp commands. With Qemu 1.5 i've the following socket communication: '{execute:qmp_capabilities,id:12125:1,arguments:{}}' '{return:

Re: [Qemu-devel] qmp commands get rejected

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 15:57:59 +0200 Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 24.05.2013 um 15:23 schrieb Luiz Capitulino lcapitul...@redhat.com: On Fri, 24 May 2013 07:50:33 +0200 Stefan Priebe s.pri...@profihost.ag wrote: Hello list, since upgrading from qemu

Re: [Qemu-devel] qmp commands get rejected

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 16:36:26 +0200 Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 24.05.2013 um 16:02 schrieb Luiz Capitulino lcapitul...@redhat.com: On Fri, 24 May 2013 15:57:59 +0200 Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 24.05.2013 um 15:23

[Qemu-devel] tcg: Windows guests don't boot

2013-05-24 Thread Luiz Capitulino
Hi, Today I accidentally started qemu w/o -enable-kvm to run a Windows guest and noticed it didn't boot: sometimes it hangs on a blue screen and sometimes it keeps rebooting in a loop. I tried with Windows 2008 and Windows 8, and went back to qemu v1.2.0 to see if it's a bisectable regression,

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 12:05:12 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 10:12 AM, Michael S. Tsirkin wrote: Event message contains the net client name, management might only want to query the single net client. The client can do the filtering itself. I'm not sure I

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-27 Thread Luiz Capitulino
On Mon, 27 May 2013 17:34:25 +0800 Amos Kong ak...@redhat.com wrote: On Fri, May 24, 2013 at 08:51:36AM -0400, Luiz Capitulino wrote: On Fri, 24 May 2013 15:10:16 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 01:26:33PM -0400, Luiz Capitulino wrote: On Thu

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-27 Thread Luiz Capitulino
On Mon, 27 May 2013 09:10:11 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: We use the QMP event to notify management about the mac changing. In this thread, we _wrongly_ considered to use qmp approach to delay the event for avoiding the flooding. eg

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Luiz Capitulino
no more issue of truncation, and they can be used by both qemu and qemu-img with correct parameter specified. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com I don't like the casting and the void pointers very much, but I can't suggest anything better: Reviewed-by: Luiz Capitulino lcapitul

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-27 Thread Luiz Capitulino
On Sun, 26 May 2013 10:33:39 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: In the past, CHR_EVENT_OPENED events were emitted via a pre-expired QEMUTimer. Due to timers being processing at the tail end of each main loop iteration, this generally meant that such events would be emitted

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Luiz Capitulino
On Mon, 27 May 2013 17:40:59 +0200 Kevin Wolf kw...@redhat.com wrote: Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: On Sat, 25 May 2013 11:09:45 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now

Re: [Qemu-devel] [Bug 1180970] *** affects all x86_64 soft emulation

2013-05-27 Thread Luiz Capitulino
On Fri, 24 May 2013 23:23:02 +0200 Laszlo Ersek ler...@redhat.com wrote: --[ proposed fix ]-- diff --git a/target-i386/translate.c b/target-i386/translate.c index 0e0356f..4fbd6c0 100644 --- a/target-i386/translate.c +++

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-28 Thread Luiz Capitulino
On Tue, 28 May 2013 06:43:04 +0800 Amos Kong ak...@redhat.com wrote: On Mon, May 27, 2013 at 09:24:28AM -0400, Luiz Capitulino wrote: On Mon, 27 May 2013 09:10:11 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: We use the QMP event to notify management about the mac changing

[Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-28 Thread Luiz Capitulino
but also selects the XD bit (execute-disable) which happens to be enabled by Windows 8, causing qemu_get_ram_ptr() to abort. This commit fixes that problem by replacing ~0xfff by a correct mask that only selects the address bit range (ie. bits 51:12). Signed-off-by: Luiz Capitulino lcapitul

Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details

2013-05-29 Thread Luiz Capitulino
On Thu, 23 May 2013 13:44:47 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com Looks good to me, only one small nit below. --- hmp.c| 32 hmp.h|1 + monitor.c|7 +

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-29 Thread Luiz Capitulino
On Mon, 27 May 2013 12:59:25 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Sun, 26 May 2013 10:33:39 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: In the past

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

2013-05-29 Thread Luiz Capitulino
On Sun, 26 May 2013 22:20:58 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: With the introduction of native list types, we now have types such as int64List where the 'value' field is not a pointer, but the actual 64-bit value. On 32-bit architectures, this can lead to situations where

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-05-29 Thread Luiz Capitulino
On Wed, 29 May 2013 10:13:42 +0200 Kevin Wolf kw...@redhat.com wrote: Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf wrote: The QMP version is flagged with a __org.qemu.debug- prefix in order to reinforce the statement that qemu-io is for testing

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

2013-05-29 Thread Luiz Capitulino
On Wed, 29 May 2013 13:12:18 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: On Wed, May 29, 2013 at 01:32:52PM -0400, Luiz Capitulino wrote: On Sun, 26 May 2013 22:20:58 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: With the introduction of native list types, we now have types

Re: [Qemu-devel] [PATCH] gdbstub: do not restart crashed guest

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 13:55:50 +0200 Laszlo Ersek ler...@redhat.com wrote: On 05/30/13 13:20, Paolo Bonzini wrote: If a guest has crashed with an internal error or similar, detaching gdb (or any other debugger action) should not restart it. Cc: Jan Kiszka jan.kis...@siemens.com

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Luiz Capitulino
On Tue, 28 May 2013 14:19:22 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: The code used to walk IA-32e page-tables, and possibly PAE page-tables, uses the bit mask ~0xfff to get the next PML4E/PDPTE/PDE/PTE address. However, as we use a uint64_t to store the resulting address

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 15:16:18 +0200 Laszlo Ersek ler...@redhat.com wrote: On 05/30/13 14:59, Luiz Capitulino wrote: On Tue, 28 May 2013 14:19:22 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: The code used to walk IA-32e page-tables, and possibly PAE page-tables, uses the bit mask

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 16:10:28 +0200 Andreas Färber afaer...@suse.de wrote: Am 30.05.2013 15:16, schrieb Luiz Capitulino: On Thu, 30 May 2013 15:16:18 +0200 Laszlo Ersek ler...@redhat.com wrote: On 05/30/13 14:59, Luiz Capitulino wrote: On Tue, 28 May 2013 14:19:22 -0400 Luiz

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 16:22:32 +0200 Andreas Färber afaer...@suse.de wrote: Am 30.05.2013 16:14, schrieb Luiz Capitulino: On Thu, 30 May 2013 16:10:28 +0200 Andreas Färber afaer...@suse.de wrote: Am 30.05.2013 15:16, schrieb Luiz Capitulino: On Thu, 30 May 2013 15:16:18 +0200 Laszlo

Re: [Qemu-devel] [PATCH v2 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown

2013-05-30 Thread Luiz Capitulino
while closing and deleting all devices on shutdown. I'll defer review to the block guys, but as this works for me: Tested-by: Luiz Capitulino lcapitul...@redhat.com Luiz Capitulino (1): block: make bdrv_dev_change_media_cb() public Pavel Hrdina (1): block: move

[Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Luiz Capitulino
The culprit is commit: commit 235e8982ad393e5611cb892df54881c872eea9e1 Author: Jordan Justen jordan.l.jus...@intel.com Date: Wed May 29 01:27:26 2013 -0700 kvm: support using KVM_MEM_READONLY flag for regions I'm running 3.9.2-200.fc18, btw. And, error checking is missing on the first

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 18:03:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 30/05/2013 17:46, Luiz Capitulino ha scritto: The culprit is commit: commit 235e8982ad393e5611cb892df54881c872eea9e1 Author: Jordan Justen jordan.l.jus...@intel.com Date: Wed May 29 01:27:26 2013 -0700

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 09:50:10 -0700 Jordan Justen jljus...@gmail.com wrote: On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 30 May 2013 18:03:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 30/05/2013 17:46, Luiz Capitulino ha scritto

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 10:32:36 -0700 Jordan Justen jljus...@gmail.com wrote: On Thu, May 30, 2013 at 10:03 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 30 May 2013 09:50:10 -0700 Jordan Justen jljus...@gmail.com wrote: On Thu, May 30, 2013 at 9:08 AM, Luiz Capitulino lcapitul

Re: [Qemu-devel] [BUG]: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 20:05:29 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 30/05/2013 19:56, Luiz Capitulino ha scritto: On Thu, 30 May 2013 10:32:36 -0700 Jordan Justen jljus...@gmail.com wrote: On Thu, May 30, 2013 at 10:03 AM, Luiz Capitulino lcapitul...@redhat.com wrote

Re: [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-05-31 Thread Luiz Capitulino
On Fri, 31 May 2013 16:52:18 +0800 Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: Luiz Capitulino reported that guest refused to boot and qemu complained with: kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument It is caused by commit 235e8982ad that did double

Re: [Qemu-devel] [PATCH qom-cpu v3 4/9] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:56 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de Nitpick alarm on. --- include/qom/cpu.h | 10 ++ include/sysemu/memory_mapping.h | 1 - memory_mapping-stub.c | 6 --

Re: [Qemu-devel] [PATCH qom-cpu v3 6/9] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:58 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 11 +++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c | 6 -- memory_mapping.c

Re: [Qemu-devel] [PATCH qom-cpu v3 9/9] memory_mapping: Change qemu_get_guest_memory_mapping() semantics

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:08:01 +0200 Andreas Färber afaer...@suse.de wrote: Previously it would search for the first CPU with paging enabled and retrieve memory mappings from this and any following CPUs or return an error if that fails. Instead walk all CPUs and if paging is enabled retrieve

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-31 Thread Luiz Capitulino
On Fri, 31 May 2013 21:04:10 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-5-30 10:41, Wenchao Xia 写道: 于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp

Re: [Qemu-devel] [PATCH qom-cpu v3 0/9] dump: Build cleanups redone

2013-05-31 Thread Luiz Capitulino
...@cn.fujitsu.com Cc: Qiao Nuohan qiaonuo...@cn.fujitsu.com Cc: Jens Freimann jf...@linux.vnet.ibm.com Cc: Vincent Rabin ra...@rab.in Cc: Paolo Bonzini pbonz...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Andreas Färber (7): dump: Move stubs into libqemustub.a cpu: Turn

[Qemu-devel] [PULL 0/3] QMP queue

2013-05-31 Thread Luiz Capitulino
One qapi fix and two fixes that affect the dump-guest-memory QMP command. The changes (since 87d23f78aa79b72da022afda358bbc8a8509ca70) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (1): target-i386: fix abort on bad PML4E/PDPTE

[Qemu-devel] [PULL 1/3] qapi: pad GenericList value fields to 64 bits

2013-05-31 Thread Luiz Capitulino
-pointer types, which would be more memory efficient in itself and allow us to roll back this change. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- include/qapi/visitor.h | 5 - scripts/qapi-types.py | 10

[Qemu-devel] [PULL 2/3] target-i386: fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-31 Thread Luiz Capitulino
but also selects the XD bit (execute-disable) which happens to be enabled by Windows 8, causing qemu_get_ram_ptr() to abort. This commit fixes that problem by replacing ~0xfff by a correct mask that only selects the address bit range (ie. bits 51:12). Signed-off-by: Luiz Capitulino lcapitul

[Qemu-devel] [PULL 3/3] target-i386: Fix mask of pte index in memory mapping

2013-05-31 Thread Luiz Capitulino
...@linux.vnet.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- target-i386/arch_memory_mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/arch_memory_mapping.c b/target-i386/arch_memory_mapping.c index

Re: [Qemu-devel] [PATCH] correct RTC_CHANGE_EVENT description

2013-06-03 Thread Luiz Capitulino
On Fri, 31 May 2013 15:24:03 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Fix RTC_CHANGE event description to match implementation. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Applied to the qmp branch, thanks. diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-06-03 Thread Luiz Capitulino
On Mon, 3 Jun 2013 09:12:55 + Libaiqing libaiq...@huawei.com wrote: Hi, Thanks for your advice,it works well when using prefix=x86_64-w64-mingw32-. The dlls may download from here: http://qemu.weilnetz.de/w64/dll/. One more question: Qemu-ga.exe can't run successfully

Re: [Qemu-devel] [PATCH 0/2] gdbstub runstate check follow-ups

2013-06-03 Thread Luiz Capitulino
On Mon, 3 Jun 2013 17:06:53 +0200 Paolo Bonzini pbonz...@redhat.com wrote: My patch committed at 87f25c12bfeaaa0c41fb857713bbc7e8a9b757dc was broken. These patches fix the problem in a better way. Looks good to me: Reviewed-by: Luiz Capitulino lcapitul...@redhat.com

[Qemu-devel] [PATCH 1/2] MAINTAINERS: new maintainers for qapi-schema.json

2013-06-03 Thread Luiz Capitulino
that touches the qapi-schema.json file. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index be02724..432185a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -706,6 +706,13 @@ F: nbd.* F

[Qemu-devel] [PATCH 0/2] MAINTAINERS: QMP: entry update and new maintainers

2013-06-03 Thread Luiz Capitulino
Hi, This is an small update on QMP/HMP/QAPI mainternership. Please, check individual patches for details. Luiz Capitulino (2): MAINTAINERS: new maintainers for qapi-schema.json MAINTAINERS: split Monitor (QMP/HMP) entry MAINTAINERS | 24 ++-- 1 file changed, 22

[Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

2013-06-03 Thread Luiz Capitulino
. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- MAINTAINERS | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 432185a..45f2e68 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -685,11 +685,12 @@ M: Anthony Liguori aligu

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

2013-06-03 Thread Luiz Capitulino
On Mon, 03 Jun 2013 11:24:58 -0600 Eric Blake ebl...@redhat.com wrote: On 06/03/2013 11:17 AM, Luiz Capitulino wrote: This entry doesn't reflect reality for a few years now. This commit splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped as a maintainer. This is what

Re: [Qemu-devel] [PATCH 0/2] MAINTAINERS: QMP: entry update and new maintainers

2013-06-03 Thread Luiz Capitulino
On Mon, 03 Jun 2013 11:27:51 -0600 Eric Blake ebl...@redhat.com wrote: On 06/03/2013 11:17 AM, Luiz Capitulino wrote: Hi, This is an small update on QMP/HMP/QAPI mainternership. Please, check individual patches for details. Luiz Capitulino (2): MAINTAINERS: new maintainers

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

2013-06-03 Thread Luiz Capitulino
On Mon, 03 Jun 2013 21:13:30 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 03/06/2013 19:17, Luiz Capitulino ha scritto: This entry doesn't reflect reality for a few years now. This commit splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped as a maintainer

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

2013-06-03 Thread Luiz Capitulino
On Mon, 3 Jun 2013 15:05:03 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: On Mon, Jun 03, 2013 at 03:54:48PM -0400, Luiz Capitulino wrote: On Mon, 03 Jun 2013 21:13:30 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 03/06/2013 19:17, Luiz Capitulino ha scritto: This entry doesn't

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Luiz Capitulino
On Tue, 4 Jun 2013 12:08:23 +0200 Kevin Wolf kw...@redhat.com wrote: Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: On Wed, 29 May 2013 10:13:42 +0200 Kevin Wolf kw...@redhat.com wrote: Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: On 05/28/2013 09:27 AM, Kevin Wolf

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-06-04 Thread Luiz Capitulino
On Tue, 4 Jun 2013 14:49:55 +0200 Kevin Wolf kw...@redhat.com wrote: Am 04.06.2013 um 14:40 hat Luiz Capitulino geschrieben: On Tue, 4 Jun 2013 12:08:23 +0200 Kevin Wolf kw...@redhat.com wrote: Am 29.05.2013 um 19:51 hat Luiz Capitulino geschrieben: On Wed, 29 May 2013 10:13:42

[Qemu-devel] [PATCH v2 0/2] MAINTAINERS: QMP: entry update and new maintainers

2013-06-04 Thread Luiz Capitulino
Hi, This is an small update on QMP/HMP/QAPI mainternership. Please, check individual patches for details. v2 o add QMP/ to the QMP entry o add Michael as a maintainer for the QAPI Luiz Capitulino (2): MAINTAINERS: new maintainers for qapi-schema.json MAINTAINERS: split Monitor (QMP/HMP

[Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

2013-06-04 Thread Luiz Capitulino
. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- MAINTAINERS | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 432185a..13c0cc5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[Qemu-devel] [PATCH 1/2] MAINTAINERS: new maintainers for qapi-schema.json

2013-06-04 Thread Luiz Capitulino
that touches the qapi-schema.json file. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index be02724..432185a 100644 --- a/MAINTAINERS +++ b

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Luiz Capitulino
On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: I haven't reviewed it yet, but we need introspection support before merging this. Hello Luiz, Is it possible to get this reviewed, or I am supposed to wait until introspection support being settled? I

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Luiz Capitulino
[CC'ing Amos this time] On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: I haven't reviewed it yet, but we need introspection support before merging this. Hello Luiz, Is it possible to get this reviewed, or I am supposed to wait until introspection

Re: [Qemu-devel] [PATCH v5] net: add support of mac-programming over macvtap in QEMU side

2013-06-07 Thread Luiz Capitulino
On Wed, 5 Jun 2013 18:42:13 +0800 Amos Kong ak...@redhat.com wrote: Currently macvtap based macvlan device is working in promiscuous mode, we want to implement mac-programming over macvtap through Libvirt for better performance. Design: QEMU notifies Libvirt when rx-filter config is

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread Luiz Capitulino
On Tue, 4 Jun 2013 16:35:09 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 Which we basically used to print out a greeting/prompt for the

Re: [Qemu-devel] [PATCH v2 16/16] Make qemu-io commands available in HMP

2013-06-07 Thread Luiz Capitulino
On Wed, 5 Jun 2013 14:19:41 +0200 Kevin Wolf kw...@redhat.com wrote: It was decided to not make this command available in QMP in order to make clear that this is not supposed to be a stable API and should be used only for testing and debugging purposes. I like this as a temporary solution.

Re: [Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-07 Thread Luiz Capitulino
On Fri, 7 Jun 2013 09:56:00 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: On Fri, Jun 07, 2013 at 09:50:39AM -0400, Luiz Capitulino wrote: On Tue, 4 Jun 2013 16:35:09 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET

[Qemu-devel] [PATCH 4/9] block: mirror_complete(): use error_setg_file_open()

2013-06-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 8b07dec..89d531d 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -512,7 +512,7 @@ static void mirror_complete

[Qemu-devel] [PATCH 1/9] error: add error_setg_file_open() helper

2013-06-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- include/qapi/error.h | 5 + util/error.c | 5 + 2 files changed, 10 insertions(+) diff --git a/include/qapi/error.h b/include/qapi/error.h index 5cd2f0c..ffd1cea 100644 --- a/include/qapi/error.h +++ b/include/qapi/error.h

[Qemu-devel] [PATCH 0/9] QMP/HMP: add error reason to open failures

2013-06-07 Thread Luiz Capitulino
reason to open failures: (qemu) dump-guest-memory -p /sfmdkjf/foo Could not open '/sfmdkjf/foo': No such file or directory (qemu) Luiz Capitulino (9): error: add error_setg_file_open() helper rng-random: use error_setg_file_open() block: bdrv_reopen_prepare(): use error_setg_file_open() block

[Qemu-devel] [PATCH 3/9] block: bdrv_reopen_prepare(): use error_setg_file_open()

2013-06-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block.c b/block.c index 79ad33d..c78f152 100644 --- a/block.c +++ b/block.c @@ -1291,8 +1291,7 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state

[Qemu-devel] [PULL 3/3] MAINTAINERS: split Monitor (QMP/HMP) entry

2013-06-07 Thread Luiz Capitulino
. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Acked-by: Markus Armbruster arm...@redhat.com --- MAINTAINERS | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 432185a..13c0cc5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[Qemu-devel] [PULL 0/3] QMP queue

2013-06-07 Thread Luiz Capitulino
The changes (since 7387de16d0e4d2988df350926537cd12a8e34206) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (2): MAINTAINERS: new maintainers for qapi-schema.json MAINTAINERS: split Monitor (QMP/HMP) entry Marcelo Tosatti (1

[Qemu-devel] [PATCH 5/9] blockdev: use error_setg_file_open()

2013-06-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9937311..c09adba 100644 --- a/blockdev.c +++ b/blockdev.c @@ -899,7 +899,7 @@ static void external_snapshot_prepare

[Qemu-devel] [PULL 1/3] correct RTC_CHANGE_EVENT description

2013-06-07 Thread Luiz Capitulino
From: Marcelo Tosatti mtosa...@redhat.com Fix RTC_CHANGE event description to match implementation. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 6/9] cpus: use error_setg_file_open()

2013-06-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..c8bc8ad 100644 --- a/cpus.c +++ b/cpus.c @@ -1278,7 +1278,7 @@ void qmp_memsave(int64_t addr, int64_t size, const char *filename

[Qemu-devel] [PATCH 8/9] savevm: qmp_xen_save_devices_state(): use error_setg_file_open()

2013-06-07 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index 2ce439f..ff5ece6 100644 --- a/savevm.c +++ b/savevm.c @@ -2410,7 +2410,7 @@ void qmp_xen_save_devices_state(const char *filename, Error

  1   2   3   4   5   6   7   8   9   10   >