[Qemu-devel] [PATCH 03/19] QMP: Don't use do_info()

2010-09-30 Thread Luiz Capitulino
commands in QMP. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 39 +++ 1 files changed, 31 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 8324e65..af8bdfe 100644 --- a/monitor.c +++ b/monitor.c @@ -3387,6 +3387,11

[Qemu-devel] [PATCH 05/19] Monitor: Drop is_async_return()

2010-09-30 Thread Luiz Capitulino
If I understood it correcty, the is_async_return() logic was only used to prevent QMP from issuing duplicated success responses for asynchronous handlers. However, QMP doesn't use do_info() anymore so this is dead logic and (hopefully) can be safely dropped. Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 14/19] Monitor: Drop monitor_cmd_user_only()

2010-09-30 Thread Luiz Capitulino
This function was only needed when QMP and HMP were sharing dispatch tables, this is no longer true so just drop it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 - monitor.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/monitor.c b

[Qemu-devel] [PATCH 04/19] Monitor: Drop QMP bits from do_info()

2010-09-30 Thread Luiz Capitulino
As of last commit, QMP doesn't use do_info() anymore. Simplify it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 39 --- 1 files changed, 8 insertions(+), 31 deletions(-) diff --git a/monitor.c b/monitor.c index af8bdfe..f638017

[Qemu-devel] [PATCH 07/19] Monitor: Introduce the qmp-commands.hx file

2010-09-30 Thread Luiz Capitulino
entries from HMP's tables. NOTE: HMP specific constructions, like q|quit, have been dropped. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile|2 +- QMP/README |2 +- qmp-commands.hx | 1541 +++ 3 files changed

[Qemu-devel] [PATCH 10/19] QMP: Introduce query commands dispatch table

2010-09-30 Thread Luiz Capitulino
The new table is a copy of HMP's table, containing only QObject handlers. In the near future HMP will be making QMP calls and then we will be able to drop QObject handlers from HMP's table. From now on, QMP and HMP have different query command dispatch tables. Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 06/19] Monitor: Convert do_info() back to HMP

2010-09-30 Thread Luiz Capitulino
This is a HMP specific handler, it makes no sense to have it under QMP. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 ++--- qemu-monitor.hx |3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 5b57810..c22f5d6

[Qemu-devel] [PATCH 09/19] QMP: Introduce command dispatch table

2010-09-30 Thread Luiz Capitulino
Also update QMP functions to use it. The table is generated from the qmp-commands.hx file. From now on, QMP and HMP have different command dispatch tables. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile.target |7 +-- monitor.c | 11 +-- 2 files

[Qemu-devel] [PATCH 13/19] Monitor: Drop QMP info from the qemu-monitor.hx file

2010-09-30 Thread Luiz Capitulino
removed. This will only happen when we introduce a proper QMP call interface. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |8 - qemu-monitor.hx | 1358 --- 2 files changed, 0 insertions(+), 1366 deletions(-) diff

[Qemu-devel] [PATCH 11/19] QMP: Simplify do_info_commands()

2010-09-30 Thread Luiz Capitulino
We now iterate over QMP's dispatch tables, no need to check for QMP-only handlers anymore. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 7cb66df..dbf6e18 100644

[Qemu-devel] [PATCH 15/19] Monitor: Rename monitor_handler_ported()

2010-09-30 Thread Luiz Capitulino
That name makes no sense anymore, as dispatch tables have been split, a better name is handler_is_qobject(), which really communicates the handler's type. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 16/19] Monitor: Rename monitor_handler_is_async()

2010-09-30 Thread Luiz Capitulino
Let's follow the convention introduced by the previous commit and call it handler_is_async(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 91473f4..a48f919 100644

[Qemu-devel] [PATCH 17/19] Monitor: Directly call QObject handlers

2010-09-30 Thread Luiz Capitulino
This avoids handle_user_command() calling monitor_call_handler(), which is currently shared with QMP. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index a48f919..adc5bbd

[Qemu-devel] [PATCH 18/19] QMP: Introduce qmp_call_cmd()

2010-09-30 Thread Luiz Capitulino
Calls a QObject handler and emits the QMP response, also drops monitor_call_handler() which is now unused. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 39 +++ 1 files changed, 15 insertions(+), 24 deletions(-) diff --git

[Qemu-devel] [PATCH 08/19] QMP: Introduce qmp_find_cmd()

2010-09-30 Thread Luiz Capitulino
Next commit needs this new function: it will introduce the the QMP's command dispatch table and qmp_find_cmd() will be used to search on it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 10/19] QMP: Introduce query commands dispatch table

2010-10-01 Thread Luiz Capitulino
On Fri, 01 Oct 2010 08:31:11 -0500 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On 09/30/2010 03:56 PM, Luiz Capitulino wrote: The new table is a copy of HMP's table, containing only QObject handlers. In the near future HMP will be making QMP calls and then we will be able

[Qemu-devel] [PULL 00/23]: Monitor queue

2010-10-01 Thread Luiz Capitulino
): Add support for JSON pretty printing Add option to turn on JSON pretty printing in monitor Eduardo Habkost (1): disable guest-provided stats on info balloon command Luiz Capitulino (20): Monitor: Introduce search_dispatch_table() QMP: handle_qmp_command(): Move 'cmd' sanity

[Qemu-devel] [PATCH 01/23] Add support for JSON pretty printing

2010-10-01 Thread Luiz Capitulino
: { version: { micro: 50, minor: 12, package: , major: 0 }, capabilities: [ ] } } NB: this is not turned on for the QMP monitor. Signed-off-by: Daniel P. Berrange berra...@redhat.com Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 06/23] QMP: Don't use do_info()

2010-10-01 Thread Luiz Capitulino
commands in QMP. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 39 +++ 1 files changed, 31 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 2efff8a..ff65f38 100644 --- a/monitor.c +++ b/monitor.c @@ -3390,6 +3390,11

[Qemu-devel] [PATCH 02/23] Add option to turn on JSON pretty printing in monitor

2010-10-01 Thread Luiz Capitulino
From: Daniel P. Berrange berra...@redhat.com Expaned '-mon' arg to allow a 'pretty=on' flag. This makes the monitor pretty print its replies to easy human debugging / reading Signed-off-by: Daniel P. Berrange berra...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com

[Qemu-devel] [PATCH 09/23] Monitor: Convert do_info() back to HMP

2010-10-01 Thread Luiz Capitulino
This is a HMP specific handler, it makes no sense to have it under QMP. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 ++--- qemu-monitor.hx |3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 7f2af49..f0854c4

[Qemu-devel] [PATCH 07/23] Monitor: Drop QMP bits from do_info()

2010-10-01 Thread Luiz Capitulino
As of last commit, QMP doesn't use do_info() anymore. Simplify it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 39 --- 1 files changed, 8 insertions(+), 31 deletions(-) diff --git a/monitor.c b/monitor.c index ff65f38..4fc0ad3

[Qemu-devel] [PATCH 04/23] Monitor: Introduce search_dispatch_table()

2010-10-01 Thread Luiz Capitulino
It's a generic version of monitor_find_command() which searches the dispatch table passed as an argument. Future commits will introduce new dispatch tables, so we need common code to search them. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 -- 1 files

[Qemu-devel] [PATCH 03/23] disable guest-provided stats on info balloon command

2010-10-01 Thread Luiz Capitulino
disabled the corresponding (guest-visible) virtio feature bit, causing issues for migration. Original discussion is available at: http://marc.info/?l=qemu-develm=128448124328314w=2 Signed-off-by: Eduardo Habkost ehabk...@redhat.com Acked-by: Adam Litke a...@us.ibm.com Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 05/23] QMP: handle_qmp_command(): Move 'cmd' sanity check

2010-10-01 Thread Luiz Capitulino
Next commit will change how query commands are handled in a way that the 'cmd' sanity check is also going to be needed for query commands handling. Let's move it out of the else body then. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 +- 1 files changed, 5

[Qemu-devel] [PATCH 20/23] Monitor: Directly call QObject handlers

2010-10-01 Thread Luiz Capitulino
This avoids handle_user_command() calling monitor_call_handler(), which is currently shared with QMP. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 7959504..03f3c18

[Qemu-devel] [PATCH 08/23] Monitor: Drop is_async_return()

2010-10-01 Thread Luiz Capitulino
If I understood it correcty, the is_async_return() logic was only used to prevent QMP from issuing duplicated success responses for asynchronous handlers. However, QMP doesn't use do_info() anymore so this is dead logic and (hopefully) can be safely dropped. Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 14/23] QMP: Simplify do_info_commands()

2010-10-01 Thread Luiz Capitulino
We now iterate over QMP's dispatch tables, no need to check for QMP-only handlers anymore. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index bf5da50..612ee56 100644

[Qemu-devel] [PATCH 17/23] Monitor: Drop monitor_cmd_user_only()

2010-10-01 Thread Luiz Capitulino
This function was only needed when QMP and HMP were sharing dispatch tables, this is no longer true so just drop it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 - monitor.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/monitor.c b

[Qemu-devel] [PATCH 12/23] QMP: Introduce command dispatch table

2010-10-01 Thread Luiz Capitulino
Also update QMP functions to use it. The table is generated from the qmp-commands.hx file. From now on, QMP and HMP have different command dispatch tables. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile.target |7 +-- monitor.c | 11 +-- 2 files

[Qemu-devel] [PATCH 11/23] QMP: Introduce qmp_find_cmd()

2010-10-01 Thread Luiz Capitulino
Next commit needs this new function: it will introduce the the QMP's command dispatch table and qmp_find_cmd() will be used to search on it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 16/23] Monitor: Drop QMP info from the qemu-monitor.hx file

2010-10-01 Thread Luiz Capitulino
removed. This will only happen when we introduce a proper QMP call interface. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |8 - qemu-monitor.hx | 1358 --- 2 files changed, 0 insertions(+), 1366 deletions(-) diff

[Qemu-devel] [PATCH 23/23] QMP/README: Update QMP homepage address

2010-10-01 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/README |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/QMP/README b/QMP/README index 7e2b51a..80503f2 100644 --- a/QMP/README +++ b/QMP/README @@ -88,4 +88,4 @@ doing any code change. This is so because

[Qemu-devel] [PATCH 10/23] Monitor: Introduce the qmp-commands.hx file

2010-10-01 Thread Luiz Capitulino
entries from HMP's tables. NOTE: HMP specific constructions, like q|quit, have been dropped. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile|2 +- QMP/README |2 +- qmp-commands.hx | 1541 +++ 3 files changed

[Qemu-devel] [PATCH 21/23] QMP: Introduce qmp_call_cmd()

2010-10-01 Thread Luiz Capitulino
Calls a QObject handler and emits the QMP response, also drops monitor_call_handler() which is now unused. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 39 +++ 1 files changed, 15 insertions(+), 24 deletions(-) diff --git

[Qemu-devel] [PATCH 15/23] QMP: Small cleanup in handle_qmp_command()

2010-10-01 Thread Luiz Capitulino
are 'ported', no need to check for that o monitor_cmd_user_only(): no HMP handler will exist in QMP's dispatch tables, that's why we have split them after all :-) Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 ++ 1 files changed, 2 insertions

[Qemu-devel] [PATCH 19/23] Monitor: Rename monitor_handler_is_async()

2010-10-01 Thread Luiz Capitulino
Let's follow the convention introduced by the previous commit and call it handler_is_async(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index b9dab78..7959504 100644

[Qemu-devel] [PATCH 18/23] Monitor: Rename monitor_handler_ported()

2010-10-01 Thread Luiz Capitulino
That name makes no sense anymore, as dispatch tables have been split, a better name is handler_is_qobject(), which really communicates the handler's type. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 13/23] QMP: Introduce query commands dispatch table

2010-10-01 Thread Luiz Capitulino
The new table is a copy of HMP's table, containing only QObject handlers. In the near future HMP will be making QMP calls and then we will be able to drop QObject handlers from HMP's table. From now on, QMP and HMP have different query command dispatch tables. Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 0/9][PULL]: QMP/Monitor queue

2010-04-26 Thread Luiz Capitulino
Kiszka (3): monitor: Cleanup ID assignment for compat switch monitor: Reorder intialization to drop initial mux focus chardev: Document mux option Luiz Capitulino (5): QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER QError

[Qemu-devel] [PATCH 1/9] QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER

2010-04-26 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 8d885cd..b6aaec7 100644 --- a/qerror.c +++ b/qerror.c @@ -173,6 +173,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 2/9] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER

2010-04-26 Thread Luiz Capitulino
The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only for two problems: the input is not an object or the execute key is missing. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b

[Qemu-devel] [PATCH 3/9] QError: Improve QERR_QMP_BAD_INPUT_OBJECT desc

2010-04-26 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qerror.c b/qerror.c index b6aaec7..034c7de 100644 --- a/qerror.c +++ b/qerror.c @@ -170,7 +170,7 @@ static const QErrorStringTable qerror_table

[Qemu-devel] [PATCH 4/9] QMP: Check arguments member's type

2010-04-26 Thread Luiz Capitulino
Otherwise the following input crashes QEMU: { execute: migrate, arguments: tcp:0:4446 } Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 0611b29..ef84298 100644

[Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
that by moving the exit() call to the main loop, so that do_quit() requests the system to quit, instead of calling exit() directly. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |2 +- sysemu.h |2 ++ vl.c | 18 ++ 3 files changed, 21

[Qemu-devel] [PATCH 6/9] monitor: Cleanup ID assignment for compat switch

2010-04-26 Thread Luiz Capitulino
From: Jan Kiszka jan.kis...@siemens.com Canonicalize the ID assignment when creating monitor devices via the legacy switch and use less easily colliding names. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- vl.c |8 +++- 1

[Qemu-devel] [PATCH 7/9] monitor: Reorder intialization to drop initial mux focus

2010-04-26 Thread Luiz Capitulino
for that, we may also consider assigning the initial focus explicitly. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- vl.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 20d24be..a485c58 100644

[Qemu-devel] [PATCH 8/9] chardev: Document mux option

2010-04-26 Thread Luiz Capitulino
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/qemu-options.hx b/qemu

[Qemu-devel] [PATCH 9/9] stash away SCM_RIGHTS fd until a getfd command arrives

2010-04-26 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |9 - qemu-char.c |9 +++-- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/monitor.c b/monitor.c index 611cbe9..814b7dc 100644 --- a/monitor.c +++ b/monitor.c @@ -2414,15 +2414,6 @@ static int do_getfd

[Qemu-devel] Re: [PATCH] Revert PCI: Convert pci_device_hot_add() to QObject

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 19:44:19 +0200 Markus Armbruster arm...@redhat.com wrote: We don't want pci_add in QMP. Use device_add instead. This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949. Conflicts: hw/pci-hotplug.c sysemu.h Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 04/26/2010 10:47 AM, Luiz Capitulino wrote: The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 13:25:38 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 04/26/2010 01:22 PM, Luiz Capitulino wrote: On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 04/26/2010 10:47 AM, Luiz Capitulino wrote: The 'quit' Monitor

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
. Final version of the patch below, for-anthony branch updated. From 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d Mon Sep 17 00:00:00 2001 From: Luiz Capitulino lcapitul...@redhat.com Date: Tue, 6 Apr 2010 18:55:54 -0300 Subject: [PATCH 5/9] Monitor: Return before exiting with 'quit' The 'quit' Monitor

Re: [Qemu-devel] Re: KVM call agenda for Apr 27

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 12:51:08 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 04/26/2010 12:26 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. While I don't expect it to be the case this week, if we have a lack of agenda items I'll cancel the

[Qemu-devel] GSoC: Accepted students announced

2010-04-26 Thread Luiz Capitulino
Ciurcio Filho Title: Converting Monitor interface functions to QMP Mentor: Luiz Capitulino Student: Mohammed Gamal Title: Completing Big Real Mode Support for KVM Mentor: Avi Kivity Student: Roland Elek Title: AHCI emulation Mentor: Alexander Graf Congratulations to you all! If you're a student

[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-27 Thread Luiz Capitulino
On Tue, 27 Apr 2010 13:52:29 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 04/26/2010 09:44 PM, Luiz Capitulino wrote: +qemu_system_exit_request(); Untested suggestion: why add qemu_system_exit_request, exit_requested, and a hook in the main loop? You can do instead

Re: [Qemu-devel] Multiple monitor interfaces?

2010-04-27 Thread Luiz Capitulino
On Tue, 27 Apr 2010 23:23:45 +0900 Jun Koi junkoi2...@gmail.com wrote: Hi, I am wondering if is it possible to have multiple monitor interfaces at the same time? If so, how can we open more than one? The following command will create three monitors (stdio, vc and telnet on port ): #

[Qemu-devel] [PATCH] QMP: Introduce RESUME event

2010-04-27 Thread Luiz Capitulino
. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt | 12 monitor.c |3 +++ monitor.h |1 + vl.c |1 + 4 files changed, 17 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index

Re: [Qemu-devel] Multiple monitor interfaces?

2010-04-28 Thread Luiz Capitulino
On Wed, 28 Apr 2010 12:20:42 +0900 Jun Koi junkoi2...@gmail.com wrote: On Wed, Apr 28, 2010 at 3:26 AM, Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 27 Apr 2010 23:23:45 +0900 Jun Koi junkoi2...@gmail.com wrote: Hi, I am wondering if is it possible to have multiple monitor

[Qemu-devel] Re: [PATCH 1/2] block: Add wr_highest_sector blockstat

2010-04-28 Thread Luiz Capitulino
On Wed, 28 Apr 2010 11:01:12 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 04/28/2010 10:56 AM, Kevin Wolf wrote: This adds the wr_highest_sector blockstat which implements what is generally known as the high watermark. It is the highest offset of a sector written to the respective

[Qemu-devel] Re: [PATCH 1/2] block: Add wr_highest_sector blockstat

2010-04-28 Thread Luiz Capitulino
On Wed, 28 Apr 2010 17:56:20 +0200 Kevin Wolf kw...@redhat.com wrote: This adds the wr_highest_sector blockstat which implements what is generally known as the high watermark. It is the highest offset of a sector written to the respective BlockDriverState since it has been opened. The

[Qemu-devel] Re: [PATCH 1/2] block: Add wr_highest_sector blockstat

2010-04-28 Thread Luiz Capitulino
On Wed, 28 Apr 2010 12:47:49 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 04/28/2010 12:04 PM, Luiz Capitulino wrote: On Wed, 28 Apr 2010 11:01:12 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 04/28/2010 10:56 AM, Kevin Wolf wrote: This adds

[Qemu-devel] [PATCH 0/2]: QMP: expose errno in the BLOCK_IO_ERROR event

2010-04-28 Thread Luiz Capitulino
Details in the patches.

[Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-04-28 Thread Luiz Capitulino
of is to return the string representation of the name. For example, EIO becomes EIO. This is what get_errno_name() does. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-error.c | 85 ++ qemu-error.h |1 + 2 files changed, 86

[Qemu-devel] [PATCH 2/2] QMP: Add 'reason' member to the BLOCK_IO_ERROR event

2010-04-28 Thread Luiz Capitulino
It's a parsable errno string representation, this is needed because some management tools want to base their action on the error cause. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt |4 +++- block.c|8 +--- block.h|2 +- hw

Re: [Qemu-devel] [PATCH 2/2] QMP: Add 'reason' member to the BLOCK_IO_ERROR event

2010-04-29 Thread Luiz Capitulino
On Wed, 28 Apr 2010 18:24:29 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 04/28/2010 03:32 PM, Luiz Capitulino wrote: It's a parsable errno string representation, this is needed because some management tools want to base their action on the error cause. Signed-off-by: Luiz

[Qemu-devel] Re: [PATCH 1/2] block: Add wr_highest_sector blockstat

2010-04-29 Thread Luiz Capitulino
On Thu, 29 Apr 2010 12:00:45 +0200 Kevin Wolf kw...@redhat.com wrote: /** * bdrv_info_stats(): show block device statistics * @@ -1544,19 +1580,34 @@ void bdrv_stats_print(Monitor *mon, const QObject *data) * - wr_bytes: bytes written * - rd_operations: read

[Qemu-devel] [PATCH 0/2] QMP: Commands doc

2010-04-30 Thread Luiz Capitulino
Details in the patches.

[Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-04-30 Thread Luiz Capitulino
not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. This is not ideal for a number of reasons (harder to maintain, text-only, etc) but is a lot better than the current situation. Signed-off-by: Luiz

[Qemu-devel] [PATCH 2/2] Monitor: Drop QMP documentation from code

2010-04-30 Thread Luiz Capitulino
. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 55 hw/pci.c| 61 --- hw/qdev.c | 13 --- input.c | 18 -- migration.c | 38 -- monitor.c | 102

Re: [Qemu-devel] [PATCH 0/2] QMP: Commands doc

2010-04-30 Thread Luiz Capitulino
On Fri, 30 Apr 2010 19:30:36 +0200 Kevin Wolf kw...@redhat.com wrote: Am 30.04.2010 19:03, schrieb Luiz Capitulino: Details in the patches. This conflicts with the high watermark patch which changes the query-blockstats description. Can I convince you to rebase on top of it? Sure, but I

Re: [Qemu-devel] [PATCH 0/2] QMP: Commands doc

2010-04-30 Thread Luiz Capitulino
On Fri, 30 Apr 2010 15:15:50 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 30 Apr 2010 19:30:36 +0200 Kevin Wolf kw...@redhat.com wrote: Am 30.04.2010 19:03, schrieb Luiz Capitulino: Details in the patches. This conflicts with the high watermark patch which changes

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-04 Thread Luiz Capitulino
On Mon, 03 May 2010 08:16:35 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: We need to expose errno in QMP, for three reasons: 1. Some error handling functions print errno codes

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-05 Thread Luiz Capitulino
On Tue, 04 May 2010 09:03:47 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/04/2010 08:56 AM, Luiz Capitulino wrote: On Mon, 03 May 2010 08:16:35 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-05 Thread Luiz Capitulino
On Mon, 03 May 2010 18:24:11 +0200 Markus Armbruster arm...@redhat.com wrote: + +Example: + +{ execute: migrate, arguments: { uri: tcp:0:4446 } } + +Notes: + +(1) The 'query-migrate' command should be used to check migration's progress +and final result (this information

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-05 Thread Luiz Capitulino
On Tue, 04 May 2010 16:56:19 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/04/2010 03:30 PM, Luiz Capitulino wrote: StateVmSaveFailed is not like CommandFailed, there are five errors in do_savevm() and StateVmSaveFailed happens to be one of them. But I understand what

[Qemu-devel] [PATCH 2/2] Monitor: Drop QMP documentation from code

2010-05-05 Thread Luiz Capitulino
. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 70 hw/pci.c| 61 --- hw/qdev.c | 13 --- input.c | 18 -- migration.c | 38 -- monitor.c | 102

[Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-05 Thread Luiz Capitulino
not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. This is not ideal for a number of reasons (harder to maintain, text-only, etc) but does improve the current situation. Signed-off-by: Luiz

[Qemu-devel] [PATCH v2 0/2]: QMP: Commands doc

2010-05-05 Thread Luiz Capitulino
changelog - v1 - v2 - Rebased - Addressed Markus's comments - Changed indentation style - Minor fixes and clarifications

[Qemu-devel] Re: Registering buffers with a qdict

2010-05-07 Thread Luiz Capitulino
On Fri, 07 May 2010 13:45:03 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Hi Luiz, what is the recommended way of pushing larger buffers (up to 64K so far) into a qdict? QLIST of QINT (one per byte) looks a bit heavy. I thought about hex-encoding the content first (series of %02X), then

[Qemu-devel] Re: [PATCH] QMP: Add Downstream extension of QMP to spec

2010-05-07 Thread Luiz Capitulino
On Fri, 07 May 2010 11:49:42 +0200 Markus Armbruster arm...@redhat.com wrote: +Any new names downstream wishes to add must begin with '__'. To ensure +compatibility with other downstreams, it is strongly recommended that +you prefix the commands with '__RFQDN_' where RFQDN is a valid, reverse

[Qemu-devel] Re: Registering buffers with a qdict

2010-05-07 Thread Luiz Capitulino
On Fri, 07 May 2010 16:21:13 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Luiz Capitulino wrote: On Fri, 07 May 2010 13:45:03 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Hi Luiz, what is the recommended way of pushing larger buffers (up to 64K so far) into a qdict? QLIST

[Qemu-devel] Re: Bug in net/socket.c: info_str is overwritten

2010-05-07 Thread Luiz Capitulino
On Thu, 6 May 2010 10:42:10 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: Hi there, I'm working on the conversion of the 'info network' command do QMP, and I think I've found some problems. Running qemu like this: qemu -net socket,listen=: In net/socket.c, the

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Luiz Capitulino
On Mon, 10 May 2010 14:23:05 +0200 Jan Kiszka jan.kis...@web.de wrote: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for

[Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Luiz Capitulino
On Mon, 10 May 2010 12:59:47 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Luiz Capitulino wrote: On Fri, 07 May 2010 16:21:13 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Luiz Capitulino wrote: On Fri, 07 May 2010 13:45:03 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Hi

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. - Exposing named errno in QMP errors (hope it's not too late)

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Tue, 11 May 2010 15:50:32 +0200 Alexander Graf ag...@suse.de wrote: Luiz Capitulino wrote: On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. - Exposing named errno in QMP errors

Re: [Qemu-devel] KVM call agenda for May 11

2010-05-11 Thread Luiz Capitulino
On Tue, 11 May 2010 15:57:10 +0200 Jes Sorensen jes.soren...@redhat.com wrote: On 05/11/10 15:53, Luiz Capitulino wrote: On Tue, 11 May 2010 15:50:32 +0200 Alexander Graf ag...@suse.de wrote: Luiz Capitulino wrote: On Mon, 10 May 2010 08:02:50 -0700 Chris Wright chr...@redhat.com

[Qemu-devel] Re: [PATCH v2] QMP: Add Downstream extension of QMP to spec

2010-05-11 Thread Luiz Capitulino
On Mon, 10 May 2010 09:16:05 +0200 Markus Armbruster arm...@redhat.com wrote: Signed-off-by: Markus Armbruster arm...@redhat.com Looks good to me. --- v2: Clarify use of __RFQDN (Thanks, Luiz!) QMP/qmp-spec.txt | 55 ++ 1 files

[Qemu-devel] Re: [PATCH v2 0/2] Drop pci_add and pci_del from QMP

2010-05-12 Thread Luiz Capitulino
On Wed, 12 May 2010 10:52:59 +0200 Markus Armbruster arm...@redhat.com wrote: See PATCH 1/1 for rationale. v2: Cover pci_del, better commit message, rebased (no conflicts) Markus Armbruster (2): Revert PCI: Convert pci_device_hot_add() to QObject Revert monitor: Convert

[Qemu-devel] [PATCH 1/3] Revert Monitor: Return before exiting with 'quit'

2010-05-12 Thread Luiz Capitulino
This reverts commit 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d. Next commits will do the same thing in a better way. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |3 +-- sysemu.h |2 -- vl.c | 18 -- 3 files changed, 1 insertions(+), 22

[Qemu-devel] [PATCH 3/3] Monitor: Return before exiting with 'quit'

2010-05-12 Thread Luiz Capitulino
if QEMU exited because of a problem or because the 'quit' command has been executed. This commit fixes that by making do_quit() use qemu_system_shutdown_request(), so that we exit gracefully. Thanks to Paolo Bonzini pbonz...@redhat.com for suggesting this solution. Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 0/3]: Monitor: Better fix for 'quit' return

2010-05-12 Thread Luiz Capitulino
Right after when 0e8d2b55 was merged, Paolo suggested using qemu_system_shutdown_request() instead of adding yet another 'system request' operation. This series implements his suggestion, passes my tests :)

[Qemu-devel] [PATCH 2/3] sysemu: Export 'no_shutdown'

2010-05-12 Thread Luiz Capitulino
It's a global variable already, do_quit() will use it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- sysemu.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index fcfccdf..58c9733 100644 --- a/sysemu.h +++ b/sysemu.h @@ -128,6 +128,7

[Qemu-devel] [PATCH] Fix qtypes' licenses

2010-05-12 Thread Luiz Capitulino
- Change from GPL to LGPL - Add license text when missing - Minor cosmetic changes to make all headers look the same Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- check-qdict.c |3 +++ check-qfloat.c |5 - check-qint.c|3 +++ check-qlist.c |4 ++-- check

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-12 Thread Luiz Capitulino
On Wed, 12 May 2010 18:48:38 +0200 Markus Armbruster arm...@redhat.com wrote: +query-block +--- + +Show the block devices. + +Each block device information is stored in a json-object and the returned value +is a json-array of all devices. + +Each json-object contain

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Luiz Capitulino
On Thu, 13 May 2010 09:01:21 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 12 May 2010 18:48:38 +0200 Markus Armbruster arm...@redhat.com wrote: +query-block +--- + +Show the block devices. + +Each block

Re: [Qemu-devel] [PATCH 0/3]: Monitor: Better fix for 'quit' return

2010-05-13 Thread Luiz Capitulino
Sorry for the duplicated emails, git-send-email is misbehaving.

[Qemu-devel] [RFC] New Monitor command: 'info netdevices'

2010-05-13 Thread Luiz Capitulino
Hi there, Miguel is working on converting 'info network' to QMP, but turns out that it's been quite difficult to maintain the exact same output. The main problem seems to be the usage of the 'info_str' string, which some drivers (like tap, xen, vde, socket, etc) write arbitrary data into it.

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-13 Thread Luiz Capitulino
On Thu, 13 May 2010 16:48:13 +0300 Avi Kivity a...@redhat.com wrote: On 05/05/2010 10:11 PM, Luiz Capitulino wrote: One of the most important missing feature in QMP today is its supported commands documentation. The plan is to make it part of self-description support, however self

<    2   3   4   5   6   7   8   9   10   11   >