On Wed, 23 Jun 2010 12:28:27 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Markus Armbruster wrote:
Jan Kiszka jan.kis...@web.de writes:
From: Jan Kiszka jan.kis...@siemens.com
This enables command line completion inside option strings. A list of
expected key names and their
On Mon, 28 Jun 2010 16:40:58 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Luiz Capitulino wrote:
On Wed, 23 Jun 2010 12:28:27 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Markus Armbruster wrote:
Jan Kiszka jan.kis...@web.de writes:
From: Jan Kiszka jan.kis...@siemens.com
On Wed, 23 Jun 2010 12:39:59 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
There is no standard format when formatting VLANClientState.info_str,
so it is difficult to extract information and transmit it over QMP.
This patch adds info_dict, a QDict to better handle this
On Wed, 23 Jun 2010 12:40:03 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com
---
monitor.c |8 +++
net.c | 70
+
net.h |2 +
3 files
On Wed, 23 Jun 2010 12:39:56 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
This series implement the previously discussed QMP command query-netdev.
There is small change in the specification from the last version: when type
is
tap, the attribute sndbuf have been removed.
cmd flags and convert the async tag
QMP: Teach basic capability negotiation to python example
QMP: Fix python helper /wrt long return strings
monitor: Allow to exclude commands from QMP
Luiz Capitulino (16):
QMP: Fix error reporting in the async API
QError: Enhance
From: Jan Kiszka jan.kis...@siemens.com
Given too many arguments or an invalid command, we were leaking the
duplicated argument strings.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 23 +++
1 files
From: Jan Kiszka jan.kis...@siemens.com
We now have to move forward to the next argument type via next_arg_type.
This patch fixes completion for 'eject' and maybe also other commands.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
From: Jan Kiszka jan.kis...@siemens.com
Remove the arbitrary limitation of 1024 characters per return string and
read complete lines instead. Required for device_show.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/qmp.py |6
From: Jan Kiszka jan.kis...@siemens.com
As we want to add more flags to monitor commands, convert the only so
far existing one accordingly.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |6 +++---
monitor.h
will be
sent to the client.
This commit fixes the problem by making qmp_async_cmd_handler()
return the handler's error code and then calling
monitor_protocol_emitter() if the handler has returned an error.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 12
1 files
, arguments: { type: user, id: netdev1 } }
This results in DuplicatedId error.
Because the first command was invalid, it should be able to reuse the
same id, and the second command should work.
Reported-by: Luiz Capitulino lcapitul...@redhat.com
Signed-off-by: Yoshiaki Tamura tamura.yoshi
From: Jan Kiszka jan.kis...@siemens.com
As sending qmp_capabilities on session start became mandatory, both
python examples were broken.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/qmp-shell |1 +
QMP/vm-info |1 +
2
Let's call a 'hash' only what is returned by our hash function,
anything else is a 'bucket'.
This helps avoiding confusion with regard to how we traverse
our table.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qdict.c |2 +-
qdict.c | 24
A missing key is not an error.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qdict.c |6 +++---
qdict.h |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/qdict.c b/qdict.c
index 175bc17..c974d6f 100644
--- a/qdict.c
+++ b/qdict.c
@@ -272,16 +272,16
hopefully better than any English description):
QDict *qdict;
const QDictEntry *ent;
[...]
for (ent = qdict_first(qdict); ent; ent = qdict_next(qdict, ent)) {
printf(%s , qdict_entry_key(ent));
}
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qdict.c | 37
Next commit will introduce a new QDict iteration API which
returns QDictEntry entries, but we don't want users to directly
access its members since QDictEntry should be private to QDict.
In the near future this kind of data type will be turned into a
forward reference.
Signed-off-by: Luiz
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qdict.c | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/check-qdict.c b/check-qdict.c
index 1b070f4..6afce5a 100644
--- a/check-qdict.c
+++ b/check-qdict.c
@@ -194,6 +194,36
and iterate over it.
Next commit adds the new checker's second part: type checking and
invalid argument detection.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 106 +
1 files changed, 106 insertions(+), 0 deletions
default behavior
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
blockdev.c |2 +-
migration.c | 16 +++-
monitor.c | 17 +++--
3 files changed, 11 insertions(+), 24 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 3b8c606..4dcfad8
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qdict.c | 18 ++
qdict.h |1 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/qdict.c b/qdict.c
index a28a0a9..dee0fb4 100644
--- a/qdict.c
+++ b/qdict.c
@@ -308,6 +308,24 @@ int64_t qdict_get_try_int
'/' and '.' are currently unsupported under QMP,
thus they're not handled
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 94 -
1 files changed, 93 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index cce1e7b..2f6f590 100644
--- a/qerror.c
+++ b/qerror.c
@@ -177,6 +177,10 @@ static const QErrorStringTable
Previous two commits added qmp_check_client_args(), which
fully replaces this code and is way better.
It's important to note that the new checker doesn't support
the '/' arg type. As we don't have any of those handlers
converted to QMP, this is just dead code.
Signed-off-by: Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 18 +++---
monitor.h |1 +
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 00a627a..f319fee 100644
--- a/monitor.c
+++ b/monitor.c
@@ -333,6 +333,11 @@ static inline bool
to the specification.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 62 -
1 files changed, 61 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index 172dc21..22e0650 100644
--- a/monitor.c
+++ b/monitor.c
Previous commit added qmp_check_input_obj(), it does all the
checking we need.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 19 +--
1 files changed, 1 insertions(+), 18 deletions(-)
diff --git a/monitor.c b/monitor.c
index 22e0650..1c8992b 100644
Drop a unneeded label and QDECREF() call.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index 1c8992b..00a627a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4234,7
On Wed, 30 Jun 2010 11:52:57 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
This series implement the previously discussed QMP command query-netdev.
Looks good to me now, applied to the monitor queue.
Thanks.
On Mon, 05 Jul 2010 14:45:23 +0200
Juan Quintela quint...@redhat.com wrote:
Please send in any agenda items you are interested in covering.
- 0.13 release
On Fri, 2 Jul 2010 18:27:02 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
---
qemu-monitor.hx | 68
+++
1 files changed, 68 insertions(+), 0 deletions(-)
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index
This helps ensuring two things:
1. An initial warning on client writers playing with current QMP
2. Clients using unstable QMP will break when we declare QMP stable and
drop that argument
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/README |2 +-
QMP/qmp-shell
First patch is a small README update, important change is in second patch.
Thanks.
On Mon, 5 Jul 2010 16:34:22 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
Possible values for type are defined in the patch on the
qdev_property_type_to_string() function. To spot them in the current
code, hw/qdev.c:77:
enum PropertyType {
PROP_TYPE_UNSPEC = 0,
On Fri, 09 Jul 2010 10:44:32 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
This helps ensuring two things:
1. An initial warning on client writers playing with current QMP
2. Clients using unstable QMP will break when we declare QMP
On Fri, 09 Jul 2010 15:24:48 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
On Fri, 09 Jul 2010 10:44:32 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
This helps ensuring two things
On Fri, 9 Jul 2010 15:13:48 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
Changelog from v1
-
- renamed props to properties
- updated the examples
- reworded the explanations of name and description
- split type into a json-object, adding qmp and qdev
- list
On Fri, 9 Jul 2010 15:18:51 -0300
Marcelo Tosatti mtosa...@redhat.com wrote:
If -write fails, declare migration status as MIG_STATE_ERROR.
Also, in buffered_file.c, -close the object in case of an
error.
Fixes migrate -d exec:dd of=file, where dd fails to open file.
Signed-off-by:
On Tue, 13 Jul 2010 13:49:46 +0200
Markus Armbruster arm...@redhat.com wrote:
[cc: kraxel]
I didn't get around to review v1. Sorry.
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes:
Changelog from v1
-
- renamed props to properties
- updated the examples
-
On Tue, 13 Jul 2010 10:30:24 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
[...]
On Tue, Jul 13, 2010 at 8:49 AM, Markus Armbruster arm...@redhat.com wrote:
+- properties: a list where each element is an json-object that
describes a
+ property of the device. Each
On Tue, 13 Jul 2010 10:40:40 +0300
Avi Kivity a...@redhat.com wrote:
On 07/13/2010 09:57 AM, Aurelien Jarno wrote:
Avi Kivity a écrit :
On 07/12/2010 05:57 PM, Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
0.12.n+1
On Tue, 13 Jul 2010 14:30:22 -0300
Marcelo Tosatti mtosa...@redhat.com wrote:
If -write fails, declare migration status as MIG_STATE_ERROR.
Also, in buffered_file.c, -close the object in case of an
error.
Fixes migrate -d exec:dd of=file, where dd fails to open file.
Signed-off-by:
-by: Marcelo Tosatti mtosa...@redhat.com
Looks good now, I guess it's good for stable too, isn't it?
Reviewed-by: Luiz Capitulino lcapitul...@redhat.com
diff --git a/buffered_file.c b/buffered_file.c
index 54dc6c2..be147d6 100644
--- a/buffered_file.c
+++ b/buffered_file.c
@@ -222,8 +222,10
On Tue, 13 Jul 2010 18:20:20 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
On Tue, 13 Jul 2010 13:49:46 +0200
Markus Armbruster arm...@redhat.com wrote:
[cc: kraxel]
I didn't get around to review v1. Sorry.
Miguel Di Ciurcio
On Tue, 20 Jul 2010 09:07:11 +0300
Avi Kivity a...@redhat.com wrote:
On 07/20/2010 12:46 AM, Chris Wright wrote:
Please send in any agenda items you are interested in covering.
Last week's agenda, minus the item that we started to discuss.
(includes 0.13)
On Mon, 19 Jul 2010 13:51:27 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
Converts the 'info qdm' command to QMP, allowing the discovery of all devices
known to the QEMU binary without relying on command line paramaters like
-device ? and -device devtype,?
This change does
On Wed, 21 Jul 2010 18:51:19 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Jul 21, 2010 at 02:42:28PM -0300, Luiz Capitulino wrote:
On Mon, 19 Jul 2010 13:51:27 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
Converts the 'info qdm' command to QMP, allowing
On Sun, 18 Jul 2010 15:43:55 +0300
Michael Goldish mgold...@redhat.com wrote:
Signed-off-by: Michael Goldish mgold...@redhat.com
Do you need this for 0.13? I think the development window is already closed.
---
monitor.c | 15 ---
qemu-monitor.hx | 22
On Wed, 21 Jul 2010 20:06:56 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Jul 21, 2010 at 03:44:14PM -0300, Luiz Capitulino wrote:
On Sun, 18 Jul 2010 15:43:55 +0300
Michael Goldish mgold...@redhat.com wrote:
Signed-off-by: Michael Goldish mgold...@redhat.com
Do you
On Wed, 21 Jul 2010 23:30:56 +0300
Michael Goldish mgold...@redhat.com wrote:
On 07/21/2010 09:44 PM, Luiz Capitulino wrote:
On Sun, 18 Jul 2010 15:43:55 +0300
Michael Goldish mgold...@redhat.com wrote:
Signed-off-by: Michael Goldish mgold...@redhat.com
Do you need this for 0.13? I
On Wed, 21 Jul 2010 15:55:28 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 07/21/2010 03:32 PM, Bruce Rogers wrote:
Libvirt parses qemu help output to determine qemu features. In particular
it probes for the following: cache=writethrough|writeback|none. The
addition of the
On Thu, 22 Jul 2010 14:45:35 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Jul 22, 2010 at 10:28:39AM -0300, Luiz Capitulino wrote:
On Wed, 21 Jul 2010 20:06:56 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Jul 21, 2010 at 03:44:14PM -0300, Luiz Capitulino
On Thu, 22 Jul 2010 15:03:27 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Jul 22, 2010 at 10:50:00AM -0300, Luiz Capitulino wrote:
On Thu, 22 Jul 2010 14:45:35 +0100
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Jul 22, 2010 at 10:28:39AM -0300, Luiz Capitulino
This commit add the following new key to QMP's greeting message:
warning: QMP is unstable, it will change soon!
The goal is to go beyond document warnings with regard to QMP's
current state.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/README |2 +-
monitor.c |3
A number of changes I prefer to do in one shot:
- Add a note about instability
- Add multiple monitors example
- Add 'Development Process' section
- Small clarifications
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/README | 67
This is good for 0.13, please check individual patches for details.
Thanks.
On Thu, 22 Jul 2010 23:17:39 +0200
Artyom Tarasenko atar4q...@googlemail.com wrote:
2010/7/21 Luiz Capitulino lcapitul...@redhat.com:
Do you need this for 0.13? I think the development window is already closed.
Was it announced somewhere?
I heard it on the conf call and iirc it was said
On Fri, 23 Jul 2010 16:15:15 +0530
Amit Shah amit.s...@redhat.com wrote:
When a 'cont' is issued on a VM that's just waiting for an incoming
migration, the VM reboots and boots into the guest, possibly corrupting
its storage since it could be shared with another VM running elsewhere.
Ensure
On Fri, 23 Jul 2010 13:47:37 -0300
Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote:
This series introduces the documentation for the query-available-devices
command
and the conversion of the monitor command 'info qdm' to QMP.
The documentation and code were based on a patch previously
On Thu, 10 Dec 2009 18:24:38 +0200
Avi Kivity a...@redhat.com wrote:
Let me put it another way, I don't think adding null to the json
parser and incorporating it into this command is a good idea at this
stage in the release so if we want to do something like this, we need
to defer it
On Thu, 10 Dec 2009 19:02:37 +0200
Avi Kivity a...@redhat.com wrote:
On 12/10/2009 06:54 PM, Luiz Capitulino wrote:
On Thu, 10 Dec 2009 18:24:38 +0200
Avi Kivitya...@redhat.com wrote:
Let me put it another way, I don't think adding null to the json
parser and incorporating
On Thu, 10 Dec 2009 17:38:13 +
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Dec 10, 2009 at 02:54:57PM -0200, Luiz Capitulino wrote:
An option we have is: libvirt actually uses four or five of those
info commands. So, we could drop all the rest and guarantee that
only those
On Thu, 10 Dec 2009 09:30:16 -0600
Anthony Liguori aligu...@linux.vnet.ibm.com wrote:
malc wrote:
On Thu, 10 Dec 2009, Luiz Capitulino wrote:
Return a QDict with server information. Connected clients are returned
as a QList of QDicts.
The new functions (vnc_qdict_remote_addr
Hi,
This submission is the most important one. :-)
changelog
-
v4 - v5
- Coding style fixes
v3 - v4
- do_info_name(): Return an empty dict if name == NULL
- do_info_commands(): Return a dict
- Don't use spaces nor '-' in json-object keys
- Minor documention fixes
v2 - v3
- Change
An easy way to include all QEMU objects.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-objects.h | 24
1 files changed, 24 insertions(+), 0 deletions(-)
create mode 100644 qemu-objects.h
diff --git a/qemu-objects.h b/qemu-objects.h
new file mode
Other subsystems will need to link against them.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 85ad688..ea90c23 100644
--- a/Makefile
+++ b/Makefile
@@ -82,6 +82,12
This is a helper function that does type checking before retrieving
a QBool from the dictionary.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile |2 +-
qdict.c | 15 +++
qdict.h |1 +
3 files changed, 17 insertions(+), 1 deletions(-)
diff --git
A helper function to get a QList from a QDict.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile |2 +-
qdict.c | 13 +
qdict.h |2 ++
3 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index b4356ae..f1b0131 100644
Monitor commands should always return values in bytes and info
commands should always return a QDict.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 19 ---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index
Should return a QDict and should not print the user protocol bits
(eg. c|cont).
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 30 +++---
1 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index aa56ec7..5010ce4
While there update the documentation as well.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 38 +-
1 files changed, 25 insertions(+), 13 deletions(-)
diff --git a/monitor.c b/monitor.c
index 5010ce4..49db7cf 100644
--- a/monitor.c
All 'info' commands should use QDict, this commit also kills
monitor_print_qobject() as do_info_version() doesn't use it
anymore (and no handler will).
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 42 ++
1 files changed, 22
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 44 +++-
1 files changed, 35 insertions(+), 9 deletions(-)
diff --git a/monitor.c b/monitor.c
index 481a0fa..01d5827 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1933,16 +1933,41
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 41 +
1 files changed, 33 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index 01d5827..3f26c5a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1806,16 +1806,40 @@ static
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 32
1 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index 3f26c5a..a2433e9 100644
--- a/monitor.c
+++ b/monitor.c
@@ -514,10 +514,33 @@ static void
snprintf() is used because the UUID_FMT is too complex for
qobject_from_jsonf().
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 26 +++---
1 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index a824648..0163c07
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 24 +---
1 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index a2433e9..a824648 100644
--- a/monitor.c
+++ b/monitor.c
@@ -597,10 +597,27 @@ static void
Each mouse is represented by a QDict, the returned QObject is a QList of
all mice.
This commit should not change user output.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
console.h |3 +-
monitor.c |3 +-
vl.c | 62
.
This commit should not change user output.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
migration.c | 117 +++
migration.h |4 ++-
monitor.c |3 +-
3 files changed, 107 insertions(+), 17 deletions(-)
diff --git
Each block device information is stored in a QDict and the
returned QObject is a QList of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile |6 +-
block.c | 123
Each device statistic information is stored in a QDict and
the returned QObject is a QList of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
block.c | 82
block.h
Each device is represented by a QDict. The returned QObject is a QList
of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |3 ++-
qemu-char.c | 43 +--
qemu-char.h |4
Return a QDict with information about the just added device.
This commit should not change user output.
Please, note that this patch does not do error handling
conversion. In error conditions the handler still calls
monitor_printf().
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hw
On Thu, 10 Dec 2009 18:00:31 +
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Dec 10, 2009 at 03:49:20PM -0200, Luiz Capitulino wrote:
On Thu, 10 Dec 2009 17:38:13 +
Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Dec 10, 2009 at 02:54:57PM -0200, Luiz Capitulino
On Fri, 11 Dec 2009 07:18:27 -0600
Anthony Liguori aligu...@linux.vnet.ibm.com wrote:
Let's focus on converting the remaining monitor commands. The goal is
that any user of the monitor today can convert over to QMP.
Once we've achieved that goal, let's start looking at introducing proper
This small series contains some QMP related fixes.
Thanks.
Key replacement should not update the dictionary's size.
This commit also adds a test for the bug.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qdict.c |2 ++
qdict.c |3 +--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/check-qdict.c b/check
().
This can potentially hide bugs, but for some reason this has
been the behavior for a long time.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index b518cc4..ebd0282 100644
On Tue, 15 Dec 2009 10:42:46 +0100
Markus Armbruster arm...@redhat.com wrote:
Before the code motion, we throw QERR_UNDEFINED_ERROR on
monitor_vprintf(NULL, ...). Afterwards, we don't. Could you explain
why that's okay?
We never did that. A call like that will just segfault QEMU
w/o this
On Tue, 15 Dec 2009 10:54:23 +0100
Markus Armbruster arm...@redhat.com wrote:
Markus Armbruster arm...@redhat.com writes:
Luiz Capitulino lcapitul...@redhat.com writes:
The monitor_read_command() function is readline specific
and should only be used when readline is available
On Tue, 15 Dec 2009 15:41:33 +0100
Gerd Hoffmann kra...@redhat.com wrote:
2.) If you specify an USB device at the command line like -usbdevice
host:0421:00ab and the device is not available (not plugged-in) when you
start the guest, qemu segfaults.
Haven't heard this one yet. I'm
Apart form that there are two important changes:
1. New output for success response
2. A new argument type
Thanks.
Looks like I dropped this check when addressing the 'query-'
commands request.
QMP should only handle converted commands, obviously.
Reported-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |2 +-
1 files changed, 1 insertions
Currently, when a regular command doesn't have any data to output,
QMP will emit:
{ return: OK }
Returning an empty dict is better though, because dicts can support
some protocol changes in a compatible way.
So, with this commit we will return:
{ return: {} }
Signed-off-by: Luiz Capitulino
This is for debug purposes only.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index d238660..8ef1582 100644
--- a/monitor.c
+++ b/monitor.c
@@ -283,6 +283,7 @@ static void
- Fix output description
- Fix command-line usage notes
- Minor improvements
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/README | 34 +++---
1 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/QMP/README b/QMP/README
index 50c31f2
- Remove draft status
- Change default success response to be json-object
- Change error and event data member to be a json-object
- Update examples
- Add new section Compatibility Considerations
- Other fixes and clarifications
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/qmp
This is a target long value in megabytes which should be
converted to bytes.
It will be used by handlers which accept a megabyte value
when in user mode.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git
This makes do_balloon() accept megabyte values from the user
Monitor while accepting byte values for QMP.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |3 +--
qemu-monitor.hx |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/monitor.c b
On Fri, 18 Dec 2009 11:44:27 -0600
Anthony Liguori aligu...@linux.vnet.ibm.com wrote:
Markus Armbruster wrote:
While I think these promises are appropriate for a mature version of the
protocol, I do not think we should make them for 0.12.
We've just dreamed up version 0.1 of the
901 - 1000 of 5290 matches
Mail list logo
