Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-08 Thread Maciej S. Szmigiero
On 08.04.2020 22:26, Roman Kagan wrote: > On Tue, Apr 07, 2020 at 09:03:05PM +0200, Maciej S. Szmigiero wrote: >> On 07.04.2020 20:56, Roman Kagan wrote: >>> On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote: >>>> Well I want it to be merged in :-) >&

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-07 Thread Maciej S. Szmigiero
On 07.04.2020 20:56, Roman Kagan wrote: > On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote: >> Well I want it to be merged in :-) > > Hmm I'm curious why, it has little to offer over virtio. > > Anyway the series you've posted seems to be based on a fairly old > version. > > The one in

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
Do you think you have a more recent version I dont mind diffing and >> resubmitting a new version of the patchset? >> >> Thanks, >> -- Jon. >> >> On Fri, Apr 3, 2020 at 5:56 PM Maciej S. Szmigiero >> wrote: >>> >>> Hi Jon, >>> >&

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
Hi Jon, On 03.04.2020 16:23, Jon Doron wrote: > Guest OS uses ACPI to discover vmbus presence. Add a corresponding > entry to DSDT in case vmbus has been enabled. > > Experimentally Windows guests were found to require this entry to > include two IRQ resources, so this patch adds two

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
then please also add: "Signed-off-by: Maciej S. Szmigiero ". Thanks for the effort, Maciej On 03.04.2020 17:30, Jon Doron wrote: > Thank you Maciej it seems like your version is really ahead I'll do > the required work and merge it so i can submit a v2 with the latest > patchset from

Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

2020-04-03 Thread Maciej S. Szmigiero
It seems to me that Roman might not be getting our e-mails since his new e-mail address seems to be "rvka...@yandex-team.ru". @Roman, are you with us? Thanks, Maciej On 03.04.2020 19:18, Maciej S. Szmigiero wrote: > Hi Jon, > > The patches are available here: &

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-06 Thread Maciej S. Szmigiero
On 05.05.2020 17:38, Jon Doron wrote: > On 05/05/2020, Igor Mammedov wrote: > > I dont know what were the original intentions of the original patch authors > (at this point I simply rebased it, and to be honest I did not need this > patch to get where I was going to, but it was part of the

Re: Who uses TYPE_VMBUS_DEVICE?

2020-10-09 Thread Maciej S. Szmigiero
Hi Eduardo, On 09.10.2020 21:39, Eduardo Habkost wrote: > Hi, > > I've just stumbled upon hw/hyperv/vmbus.c and I'm a bit confused: > I haven't found any subclasses of the abstract type > TYPE_VMBUS_DEVICE in the QEMU tree. > > I see a few patches in qemu-devel implementing a few vmbus >

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2020-10-09 Thread Maciej S. Szmigiero
On 09.10.2020 22:07, Eduardo Habkost wrote: > Having properties registered conditionally makes QOM type > introspection difficult. Instead of skipping registration of the > "instanceid" property, always register the property but validate > its value against the instance id required by the class.

Re: [PATCH] pc-dimm: remove unnecessary get_vmstate_memory_region() method

2020-10-10 Thread Maciej S. Szmigiero
On 20.09.2020 15:25, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > The get_vmstate_memory_region() method from PCDIMMDeviceClass is only > ever called from this class and is never overridden, so it can be converted > into an ordinary function. >

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2020-10-10 Thread Maciej S. Szmigiero
On 09.10.2020 23:33, Eduardo Habkost wrote: > On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: >> On 09.10.2020 22:07, Eduardo Habkost wrote: >>> Having properties registered conditionally makes QOM type >>> introspection difficult. Inste

Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-21 Thread Maciej S. Szmigiero
has to support rather big guests, up to 1 TB of RAM, so performance-related things are important. Further answers are bellow. On 21.09.2020 11:10, David Hildenbrand wrote: > On 20.09.20 15:25, Maciej S. Szmigiero wrote: >> From: "Maciej S. Szmigiero" >> >> Thi

Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-24 Thread Maciej S. Szmigiero
On 23.09.2020 14:48, David Hildenbrand wrote: (...) >> >> I know that this a source of significant hot removal slowdown, especially >> when a "ripple effect" happens on removal: >> 1) There are 3 extra DIMMs plugged into the guest: A, B, C. >>A and B are nearly empty, but C is nearly full. >>

Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-22 Thread Maciej S. Szmigiero
On 22.09.2020 09:26, David Hildenbrand wrote: > On 22.09.20 00:22, Maciej S. Szmigiero wrote: >> Hi David, >> >> Thank you for your comments. >> (...) >> >> The idea is to use virtual DIMM sticks for hot-adding extra memory at >> runtime, while using b

[PATCH 1/3] haprot: add a device for memory hot-add protocols

2020-09-20 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This device works like a virtual DIMM stick: it allows inserting extra RAM into the guest at run time. The main differences from the ACPI-based PC DIMM hotplug are: * Notifying the guest about the new memory range is not done via ACPI but via a protoc

[PATCH 3/3] Add a Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-20 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and inserting extra RAM into it by adding haprot virtual DIMM sticks. One of advantages of these over ACPI-based PC DIMM hotplug is that such

[PATCH 2/3] Add Hyper-V Dynamic Memory Protocol definitions

2020-09-20 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This commit adds Hyper-V Dynamic Memory Protocol definitions, taken from hv_balloon Linux kernel driver, adapted to the QEMU coding style and definitions. Signed-off-by: Maciej S. Szmigiero --- include/hw/hyperv/dynmem-pro

[PATCH] pc-dimm: remove unnecessary get_vmstate_memory_region() method

2020-09-20 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" The get_vmstate_memory_region() method from PCDIMMDeviceClass is only ever called from this class and is never overridden, so it can be converted into an ordinary function. Signed-off-by: Maciej S. Szmigiero --- hw/mem/pc-dimm.c

[PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2020-09-20 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This series adds a Hyper-V Dynamic Memory Protocol driver (hv-balloon) and its protocol definitions. Also included is a driver providing backing devices for memory hot-add protocols ("haprots"). A haprot device works like a virtual DIMM stick:

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-06-15 Thread Maciej S. Szmigiero
On 15.06.2020 04:40, Jon Doron wrote: > On 14/06/2020, Maciej S. Szmigiero wrote: >> Hi Jon, >> >> On 14.06.2020 16:11, Jon Doron wrote: >>> On 28/05/2020, Jon Doron wrote: >>>> On 28/05/2020, Igor Mammedov wrote: >>>>> On Thu, 28 May 2020

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-06-14 Thread Maciej S. Szmigiero
Hi Jon, On 14.06.2020 16:11, Jon Doron wrote: > On 28/05/2020, Jon Doron wrote: >> On 28/05/2020, Igor Mammedov wrote: >>> On Thu, 28 May 2020 08:26:42 +0300 >>> Jon Doron wrote: >>> On 22/05/2020, Igor Mammedow wrote: > On Thu, 21 May 2020 18:02:07 +0200 > Paolo Bonzini wrote:

Re: [PATCH 0/2] Improve vmstate_vmbus_dev handling

2021-06-05 Thread Maciej S. Szmigiero
Hi Thomas, On 03.06.2021 12:41, Thomas Huth wrote: I accidentally came accross vmstate_vmbus_dev and noticed that it is currently not used at all ... wire it up and make it static, since it is only used in one file. Thomas Huth (2): hw/hyperv/vmbus: Wire up vmstate_vmbus_dev

[PATCH RESEND] pc-dimm: remove unnecessary get_vmstate_memory_region() method

2021-04-25 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" The get_vmstate_memory_region() method from PCDIMMDeviceClass is only ever called from this class and is never overridden, so it can be converted into an ordinary function. This saves us from having to do an indirect call in order to reach it. Signed-off-by

Re: [PATCH] vmbus: Don't make QOM property registration conditional

2021-04-25 Thread Maciej S. Szmigiero
On 11.10.2020 01:30, Maciej S. Szmigiero wrote: On 09.10.2020 23:33, Eduardo Habkost wrote: On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: On 09.10.2020 22:07, Eduardo Habkost wrote: Having properties registered conditionally makes QOM type introspection difficult

[PATCH] MAINTAINERS: Add myself as a reviewer for Hyper-V VMBus

2021-11-20 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This way there is at least some contact point for incoming patches. We'll see whether the code still gets just a random patch a few times a year or whether it requires a permanent maintainer to take care of it. Signed-off-by: Maciej S. Szmigiero --- M

Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?

2021-11-13 Thread Maciej S. Szmigiero
On 08.11.2021 08:30, Philippe Mathieu-Daudé wrote: On 11/6/21 20:28, Maciej S. Szmigiero wrote: On 06.11.2021 14:41, Philippe Mathieu-Daudé wrote: This is the 4th time I send this patch. Is the VMBus infrastructure used / maintained? Should we deprecate & remove?    $ ./scr

Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?

2021-11-13 Thread Maciej S. Szmigiero
On 12.11.2021 21:39, Roman Kagan wrote: On Fri, Nov 12, 2021 at 09:32:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add Den and Roman (his new address) Thanks, I missed it on the list indeed. 06.11.2021 16:41, Philippe Mathieu-Daudé wrote: This is the 4th time I send this patch. Is the

Re: [PATCH v4 0/1] hw/hyperv/vmbus: Is it maintained?

2021-11-06 Thread Maciej S. Szmigiero
o me, so for it: Reviewed-by: Maciej S. Szmigiero Thanks, Maciej [1]: https://lore.kernel.org/qemu-devel/20201009193919.gf7...@habkost.net/T/#u

Re: [PATCH v4 12/12] KVM: Expose KVM_MEM_PRIVATE

2022-02-21 Thread Maciej S. Szmigiero
On 17.02.2022 14:45, Chao Peng wrote: On Tue, Jan 25, 2022 at 09:20:39PM +0100, Maciej S. Szmigiero wrote: On 18.01.2022 14:21, Chao Peng wrote: KVM_MEM_PRIVATE is not exposed by default but architecture code can turn on it by implementing kvm_arch_private_memory_supported(). Also private

Re: [PATCH v4 12/12] KVM: Expose KVM_MEM_PRIVATE

2022-02-23 Thread Maciej S. Szmigiero
On 23.02.2022 13:00, Chao Peng wrote: On Tue, Feb 22, 2022 at 02:16:46AM +0100, Maciej S. Szmigiero wrote: On 17.02.2022 14:45, Chao Peng wrote: On Tue, Jan 25, 2022 at 09:20:39PM +0100, Maciej S. Szmigiero wrote: On 18.01.2022 14:21, Chao Peng wrote: KVM_MEM_PRIVATE is not exposed

Re: [PATCH v4 12/12] KVM: Expose KVM_MEM_PRIVATE

2022-01-25 Thread Maciej S. Szmigiero
On 18.01.2022 14:21, Chao Peng wrote: KVM_MEM_PRIVATE is not exposed by default but architecture code can turn on it by implementing kvm_arch_private_memory_supported(). Also private memslot cannot be movable and the same file+offset can not be mapped into different GFNs. Signed-off-by: Yu

Re: [PATCH v3 13/16] memory: Clarify mapping requirements for RamDiscardManager

2023-09-16 Thread Maciej S. Szmigiero
), remove the check in memory_region_get_ram_discard_manager() and clarify the doc. Signed-off-by: David Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 11/16] vhost: Add vhost_get_max_memslots()

2023-09-16 Thread Maciej S. Szmigiero
On 8.09.2023 16:21, David Hildenbrand wrote: Let's add vhost_get_max_memslots(). Signed-off-by: David Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 09/16] memory-device, vhost: Support memory devices that dynamically consume memslots

2023-09-16 Thread Maciej S. Szmigiero
. Signed-off-by: David Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 10/16] kvm: Add stub for kvm_get_max_memslots()

2023-09-16 Thread Maciej S. Szmigiero
On 8.09.2023 16:21, David Hildenbrand wrote: We'll need the stub soon from memory device context. While at it, use "unsigned int" as return value and place the declaration next to kvm_get_free_memslots(). Signed-off-by: David Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 08/16] memory-device: Track required and actually used memslots in DeviceMemoryState

2023-09-16 Thread Maciej S. Szmigiero
ce for our device memory and register a memory listener (add/remove) for that address space. Signed-off-by: David Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 05/16] vhost: Return number of free memslots

2023-09-16 Thread Maciej S. Szmigiero
Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 04/16] kvm: Return number of free memslots

2023-09-16 Thread Maciej S. Szmigiero
. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 07/16] stubs: Rename qmp_memory_device.c to memory_device.c

2023-09-16 Thread Maciej S. Szmigiero
On 8.09.2023 16:21, David Hildenbrand wrote: We want to place non-qmp stubs in there, so let's rename it. While at it, put it into the MAINTAINERS file under "Memory devices". Signed-off-by: David Hildenbrand Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 06/16] memory-device: Support memory devices with multiple memslots

2023-09-16 Thread Maciej S. Szmigiero
Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v3 12/16] memory-device, vhost: Support automatic decision on the number of memslots

2023-09-17 Thread Maciej S. Szmigiero
t to make it any worse.So let's keep it simple and simply reject plugging such vhost devices in such a configuration. Eventually, all vhost devices that want to be fully compatible with such memory devices should support a decent number of memslots (>= 509). Signed-off-by: David Hildenbrand --- Re

Re: [PATCH v3 14/16] virtio-mem: Expose device memory via multiple memslots if enabled

2023-09-17 Thread Maciej S. Szmigiero
memslot metadata is no longer an issue, we could simply stop optimizing for that. Migration source and destination can differ on the setting of "multiple-memslots". Signed-off-by: David Hildenbrand --- Reviewed-by: Maciej S. Szmigiero Hope this patch was well-tested, especially on corn

[PATCH v7 6/7] qapi: Add HV_BALLOON_STATUS_REPORT event and its QMP query command

2023-08-28 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the hv-balloon driver for (optional) guest memory status reports. Signed-off-by: Maciej S. Szmigiero --- hw/hyperv/hv-balloon.c | 31 +++- monitor/monitor.c | 1 + qapi/machine.json

[PATCH v7 5/7] qapi: Add query-memory-devices support to hv-balloon

2023-08-28 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the driver to report its provided memory state information. Co-developed-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/core/machine-hmp-cmds.c | 15 +++ hw/hyperv/hv-balloon.c | 27 ++

[PATCH v7 1/7] memory-device: Support empty memory devices

2023-08-28 Thread Maciej S. Szmigiero
From: David Hildenbrand Let's support empty memory devices -- memory devices that don't have a memory device region in the current configuration. hv-balloon with an optional memdev is the primary use case. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory

[PATCH v7 7/7] hw/i386/pc: Support hv-balloon

2023-08-28 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Add the necessary plumbing for the hv-balloon driver to the PC machine. Co-developed-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/i386/Kconfig | 1 + hw/i386/pc.c| 22 ++ 2 files changed, 23 insertions(+)

[PATCH v7 2/7] memory-device: Drop size alignment check

2023-08-28 Thread Maciej S. Szmigiero
From: David Hildenbrand There is no strong requirement that the size has to be multiples of the requested alignment, let's drop it. This is a preparation for hv-baloon. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory-device.c | 6 -- 1 file changed

[PATCH v7 4/7] Add a Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2023-08-28 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and inserting pieces of extra RAM into it on demand from a provided memory backend. One of advantages of these over ACPI-based PC DI

[PATCH v7 0/7] Hyper-V Dynamic Memory Protocol driver (hv-balloon ️)

2023-08-28 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This is a continuation of the v6 of the patch series located here: https://lore.kernel.org/qemu-devel/cover.1689786474.git.maciej.szmigi...@oracle.com/ Changes from v6: * Split the hv-balloon driver implementation into multiple files holding parti

[PATCH v7 3/7] Add Hyper-V Dynamic Memory Protocol definitions

2023-08-28 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This commit adds Hyper-V Dynamic Memory Protocol definitions, taken from hv_balloon Linux kernel driver, adapted to the QEMU coding style and definitions. Signed-off-by: Maciej S. Szmigiero --- include/hw/hyperv/dynmem-pro

Re: [PATCH v8 0/9] Hyper-V Dynamic Memory Protocol driver (hv-balloon )

2023-11-02 Thread Maciej S. Szmigiero
On 2.11.2023 14:50, David Hildenbrand wrote: On 23.10.23 19:24, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This is a continuation of the v7 of the patch series located here: https://lore.kernel.org/qemu-devel/cover.1693240836.git.maciej.szmigi...@oracle.com/ I skimmed

[PULL 0/9] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" The following changes since commit d762bf97931b58839316b68a570eecc6143c9e3e: Merge tag 'pull-target-arm-20231102' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-11-03 10:04:12 +0800) are available in the Git repository at

[PULL 4/9] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) base

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and (in the next patch) inserting pieces of extra RAM into it on demand from a provided memory backend. The actual resizing is done via

[PULL 5/9] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) hot-add support

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" One of advantages of using this protocol over ACPI-based PC DIMM hotplug is that it allows hot-adding memory in much smaller granularity because the ACPI DIMM slot limit does not apply. In order to enable this functionality a new memory backend needs to

[PULL 1/9] memory-device: Support empty memory devices

2023-11-05 Thread Maciej S. Szmigiero
From: David Hildenbrand Let's support empty memory devices -- memory devices that don't have a memory device region in the current configuration. hv-balloon with an optional memdev is the primary use case. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory

[PULL 2/9] memory-device: Drop size alignment check

2023-11-05 Thread Maciej S. Szmigiero
From: David Hildenbrand There is no strong requirement that the size has to be multiples of the requested alignment, let's drop it. This is a preparation for hv-baloon. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory-device.c | 6 -- 1 file changed

[PULL 3/9] Add Hyper-V Dynamic Memory Protocol definitions

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This commit adds Hyper-V Dynamic Memory Protocol definitions, taken from hv_balloon Linux kernel driver, adapted to the QEMU coding style and definitions. Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- include/hw/hyperv/dynmem-pro

[PULL 7/9] qapi: Add HV_BALLOON_STATUS_REPORT event and its QMP query command

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the hv-balloon driver for (optional) guest memory status reports. Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/hyperv/hv-balloon.c | 30 +++- monitor/monitor.c | 1 + qapi/machine.json

[PULL 6/9] qapi: Add query-memory-devices support to hv-balloon

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the driver to report its provided memory state information. Co-developed-by: David Hildenbrand Reviewed-by: David Hildenbrand Acked-by: Markus Armbruster Signed-off-by: Maciej S. Szmigiero --- hw/core/machine-hmp-cmds.c | 15 +++ hw

[PULL 9/9] MAINTAINERS: Add an entry for Hyper-V Dynamic Memory Protocol

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8e8a7d5be5de..d4a480ce5a62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2656,6 +26

[PULL 8/9] hw/i386/pc: Support hv-balloon

2023-11-05 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Add the necessary plumbing for the hv-balloon driver to the PC machine. Co-developed-by: David Hildenbrand Reviewed-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/i386/Kconfig | 1 + hw/i386/pc.c| 22 ++ 2 fil

Re: [PATCH] hyperv: add check for NULL for msg

2023-10-26 Thread Maciej S. Szmigiero
On 26.10.2023 11:31, Анастасия Любимова wrote: 28/09/23 19:18, Maciej S. Szmigiero пишет: On 28.09.2023 15:25, Anastasia Belova wrote: cpu_physical_memory_map may return NULL in hyperv_hcall_post_message. Add check for NULL to avoid NULL-dereference. Found by Linux Verification Center

Re: [PULL 0/9] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2023-11-06 Thread Maciej S. Szmigiero
On 6.11.2023 02:33, Stefan Hajnoczi wrote: On Sun, 5 Nov 2023 at 19:49, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" The following changes since commit d762bf97931b58839316b68a570eecc6143c9e3e: Merge tag 'pull-target-arm-20231102' of https://git.linaro.org/peopl

[PULL 03/10] memory-device: Drop size alignment check

2023-11-06 Thread Maciej S. Szmigiero
From: David Hildenbrand There is no strong requirement that the size has to be multiples of the requested alignment, let's drop it. This is a preparation for hv-baloon. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory-device.c | 6 -- 1 file changed

[PULL 00/10] Hyper-V Dynamic Memory Protocol driver (hv-balloon) pull req fixed

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Hi Stefan, Fixed the CI pipeline issues with yesterday's pull request, and: the following changes since commit d762bf97931b58839316b68a570eecc6143c9e3e: Merge tag 'pull-target-arm-20231102' of https://git.linaro.org/people/pmaydell/qemu-arm into stagin

[PULL 07/10] qapi: Add query-memory-devices support to hv-balloon

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the driver to report its provided memory state information. Co-developed-by: David Hildenbrand Reviewed-by: David Hildenbrand Acked-by: Markus Armbruster Signed-off-by: Maciej S. Szmigiero --- hw/core/machine-hmp-cmds.c | 15 +++ hw

[PULL 08/10] qapi: Add HV_BALLOON_STATUS_REPORT event and its QMP query command

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the hv-balloon driver for (optional) guest memory status reports. Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/hyperv/hv-balloon-stub.c | 19 hw/hyperv/hv-balloon.c | 30 +- hw/hyperv/m

[PULL 09/10] hw/i386/pc: Support hv-balloon

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Add the necessary plumbing for the hv-balloon driver to the PC machine. Co-developed-by: David Hildenbrand Reviewed-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/i386/Kconfig | 1 + hw/i386/pc.c| 22 ++ 2 fil

[PULL 01/10] memory-device: Support empty memory devices

2023-11-06 Thread Maciej S. Szmigiero
From: David Hildenbrand Let's support empty memory devices -- memory devices that don't have a memory device region in the current configuration. hv-balloon with an optional memdev is the primary use case. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory

[PULL 04/10] Add Hyper-V Dynamic Memory Protocol definitions

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This commit adds Hyper-V Dynamic Memory Protocol definitions, taken from hv_balloon Linux kernel driver, adapted to the QEMU coding style and definitions. Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- include/hw/hyperv/dynmem-pro

[PULL 06/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) hot-add support

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" One of advantages of using this protocol over ACPI-based PC DIMM hotplug is that it allows hot-adding memory in much smaller granularity because the ACPI DIMM slot limit does not apply. In order to enable this functionality a new memory backend needs to

[PULL 02/10] Revert "hw/virtio/virtio-pmem: Replace impossible check by assertion"

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This reverts commit 5960f254dbb46f0c7a9f5f44bf4d27c19c34cb97 since the previous commit made this situation possible again. Signed-off-by: Maciej S. Szmigiero --- hw/virtio/virtio-pmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PULL 05/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) base

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and (in the next patch) inserting pieces of extra RAM into it on demand from a provided memory backend. The actual resizing is done via

[PULL 10/10] MAINTAINERS: Add an entry for Hyper-V Dynamic Memory Protocol

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8e8a7d5be5de..d4a480ce5a62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2656,6 +26

Re: [PATCH v7 6/7] qapi: Add HV_BALLOON_STATUS_REPORT event and its QMP query command

2023-09-25 Thread Maciej S. Szmigiero
On 25.09.2023 13:49, Markus Armbruster wrote: "Maciej S. Szmigiero" writes: From: "Maciej S. Szmigiero" Used by the hv-balloon driver for (optional) guest memory status reports. Signed-off-by: Maciej S. Szmigiero [...] static void hv_balloon_handle_unballoo

Re: [PATCH] hyperv: add check for NULL for msg

2023-09-28 Thread Maciej S. Szmigiero
On 28.09.2023 18:56, Alex Bennée wrote: Anastasia Belova writes: cpu_physical_memory_map may return NULL in hyperv_hcall_post_message. Add check for NULL to avoid NULL-dereference. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 76036a5fc7 ("hyperv: process

Re: [PATCH v4 14/18] virtio-mem: Pass non-const VirtIOMEM via virtio_mem_range_cb

2023-09-28 Thread Maciej S. Szmigiero
ic int virtio_mem_prealloc_range_cb(VirtIOMEM *vmem, void *arg, uint64_t offset, uint64_t size) { void *area = memory_region_get_ram_ptr(>memdev->mr) + offset; Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH] hyperv: add check for NULL for msg

2023-09-28 Thread Maciej S. Szmigiero
On 28.09.2023 15:25, Anastasia Belova wrote: cpu_physical_memory_map may return NULL in hyperv_hcall_post_message. Add check for NULL to avoid NULL-dereference. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 76036a5fc7 ("hyperv: process POST_MESSAGE hypercall")

Re: [PATCH v4 16/18] virtio-mem: Expose device memory dynamically via multiple memslots if enabled

2023-09-30 Thread Maciej S. Szmigiero
d Hildenbrand --- The changes seem reasonable, so: Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PATCH v4 15/18] virtio-mem: Update state to match bitmap as soon as it's been migrated

2023-09-30 Thread Maciej S. Szmigiero
ion_id) return -EBUSY; } } -return 0; + +post_load_bitmap: +/* Finally, update any other state to be consistent with the new bitmap. */ +return virtio_mem_post_load_bitmap(vmem); } typedef struct VirtIOMEMMigSanityChecks { Reviewed-by: Maciej S. Szm

Re: [PATCH v7 0/7] Hyper-V Dynamic Memory Protocol driver (hv-balloon )

2023-10-18 Thread Maciej S. Szmigiero
On 18.10.2023 10:00, David Hildenbrand wrote: On 28.08.23 18:48, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This is a continuation of the v6 of the patch series located here: https://lore.kernel.org/qemu-devel/cover.1689786474.git.maciej.szmigi...@oracle.com/ Chang

[PATCH v8 1/9] memory-device: Support empty memory devices

2023-10-23 Thread Maciej S. Szmigiero
From: David Hildenbrand Let's support empty memory devices -- memory devices that don't have a memory device region in the current configuration. hv-balloon with an optional memdev is the primary use case. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory

[PATCH v8 7/9] qapi: Add HV_BALLOON_STATUS_REPORT event and its QMP query command

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the hv-balloon driver for (optional) guest memory status reports. Signed-off-by: Maciej S. Szmigiero --- hw/hyperv/hv-balloon.c | 30 +++- monitor/monitor.c | 1 + qapi/machine.json

[PATCH v8 8/9] hw/i386/pc: Support hv-balloon

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Add the necessary plumbing for the hv-balloon driver to the PC machine. Co-developed-by: David Hildenbrand Reviewed-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/i386/Kconfig | 1 + hw/i386/pc.c| 22 ++ 2 fil

[PATCH v8 4/9] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) base

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and (in the next patch) inserting pieces of extra RAM into it on demand from a provided memory backend. The actual resizing is done via

[PATCH v8 0/9] Hyper-V Dynamic Memory Protocol driver (hv-balloon ️)

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This is a continuation of the v7 of the patch series located here: https://lore.kernel.org/qemu-devel/cover.1693240836.git.maciej.szmigi...@oracle.com/ Changes from v7: * Rebase onto the current QEMU git master now that the David's memslots patch series

[PATCH v8 2/9] memory-device: Drop size alignment check

2023-10-23 Thread Maciej S. Szmigiero
From: David Hildenbrand There is no strong requirement that the size has to be multiples of the requested alignment, let's drop it. This is a preparation for hv-baloon. Signed-off-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- hw/mem/memory-device.c | 6 -- 1 file changed

[PATCH v8 9/9] MAINTAINERS: Add an entry for Hyper-V Dynamic Memory Protocol

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Signed-off-by: Maciej S. Szmigiero --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9bd4fe378d46..6cab87700f82 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2602,6 +2602,14 @@ F: hw/usb/canokey.c

[PATCH v8 3/9] Add Hyper-V Dynamic Memory Protocol definitions

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This commit adds Hyper-V Dynamic Memory Protocol definitions, taken from hv_balloon Linux kernel driver, adapted to the QEMU coding style and definitions. Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- include/hw/hyperv/dynmem-pro

[PATCH v8 5/9] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) hot-add support

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" One of advantages of using this protocol over ACPI-based PC DIMM hotplug is that it allows hot-adding memory in much smaller granularity because the ACPI DIMM slot limit does not apply. In order to enable this functionality a new memory backend needs to

[PATCH v8 6/9] qapi: Add query-memory-devices support to hv-balloon

2023-10-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the driver to report its provided memory state information. Co-developed-by: David Hildenbrand Reviewed-by: David Hildenbrand Acked-by: Markus Armbruster Signed-off-by: Maciej S. Szmigiero --- hw/core/machine-hmp-cmds.c | 15 +++ hw

Re: [PATCH v1] virtio-mem: fix division by zero in virtio_mem_activate_memslots_to_plug()

2023-10-23 Thread Maciej S. Szmigiero
9b1ee464 ("virtio-mem: Expose device memory dynamically via multiple memslots if enabled") Cc: Michael S. Tsirkin Cc: Maciej S. Szmigiero Signed-off-by: David Hildenbrand --- Reviewed-by: Maciej S. Szmigiero Thanks, Maciej

Re: [PULL 06/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) hot-add support

2023-11-09 Thread Maciej S. Szmigiero
On 9.11.2023 15:51, Peter Maydell wrote: On Mon, 6 Nov 2023 at 14:23, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" One of advantages of using this protocol over ACPI-based PC DIMM hotplug is that it allows hot-adding memory in much smaller granularity because the ACPI

[PATCH] target/i386/kvm: Fix disabling MPX on "-cpu host" with MPX-capable host

2022-05-20 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Since KVM commit 5f76f6f5ff96 ("KVM: nVMX: Do not expose MPX VMX controls when guest MPX disabled") it is not possible to disable MPX on a "-cpu host" just by adding "-mpx" there if the host CPU does indeed support MPX. QEMU

[PULL 2/2] hw/hyperv/vmbus: Remove unused vmbus_load/save_req()

2022-05-30 Thread Maciej S. Szmigiero
Message-Id: <20211106134155.582312-2-phi...@redhat.com> [MSS: Remove also corresponding variables, which are now unused] Signed-off-by: Maciej S. Szmigiero --- hw/hyperv/vmbus.c | 99 --- include/hw/hyperv/vmbus.h | 3 -- 2 files changed, 102 de

[PULL 0/2] Add myself as the maintainer for Hyper-V VMBus

2022-05-30 Thread Maciej S. Szmigiero
for being picked up since November last year. Maciej S. Szmigiero (1): MAINTAINERS: Add myself as the maintainer for Hyper-V VMBus Philippe Mathieu-Daudé (1): hw/hyperv/vmbus: Remove unused vmbus_load/save_req

[PULL 1/2] MAINTAINERS: Add myself as the maintainer for Hyper-V VMBus

2022-05-30 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This way there is some contact point for incoming patches, and somebody to review and pick up them. Signed-off-by: Maciej S. Szmigiero --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dff0200f70..

[PATCH v2] target/i386/kvm: Fix disabling MPX on "-cpu host" with MPX-capable host

2022-05-23 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Since KVM commit 5f76f6f5ff96 ("KVM: nVMX: Do not expose MPX VMX controls when guest MPX disabled") it is not possible to disable MPX on a "-cpu host" just by adding "-mpx" there if the host CPU does indeed support MPX. QEMU

Re: [PATCH] target/i386/kvm: Fix disabling MPX on "-cpu host" with MPX-capable host

2022-05-23 Thread Maciej S. Szmigiero
On 21.05.2022 10:54, Paolo Bonzini wrote: On Fri, May 20, 2022 at 8:33 PM Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Since KVM commit 5f76f6f5ff96 ("KVM: nVMX: Do not expose MPX VMX controls when guest MPX disabled") it is not possible to disable MPX o

[PATCH] hyperv: fix SynIC SINT assertion failure on guest reset

2022-07-29 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Resetting a guest that has Hyper-V VMBus support enabled triggers a QEMU assertion failure: hw/hyperv/hyperv.c:131: synic_reset: Assertion `QLIST_EMPTY(>sint_routes)' failed. This happens both on normal guest reboot or when using "system_

  1   2   3   >