Re: [Qemu-devel] [PATCH v3] chardev/char-socket: add POLLHUP handler

Hi On Fri, Jan 19, 2018 at 11:47 AM, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first

Re: [Qemu-devel] [PATCH v2 0/5] tpm: CRB device and cleanups

On Fri, Jan 19, 2018 at 3:36 PM, wrote: > /tmp/qemu-test/src/hw/tpm/tpm_crb.c: In function 'tpm_crb_mmio_read': > /tmp/qemu-test/src/hw/tpm/tpm_crb.c:126:13: error: format '%lx' expects > argument of type 'long unsigned int', but argument 2 has type 'hwaddr {aka > long

Re: [Qemu-devel] [PULL 0/1] Dump patches

On Fri, Jan 19, 2018 at 5:21 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 19 January 2018 at 16:08, Marc-Andre Lureau <mlur...@redhat.com> wrote: >> Hi >> >> On Fri, Jan 19, 2018 at 4:29 PM, Peter Maydell <peter.mayd...@linaro.org> >>

Re: [Qemu-devel] [PULL 0/1] Dump patches

Hi On Fri, Jan 19, 2018 at 3:29 PM, Peter Maydell wrote: > On 17 January 2018 at 15:02, Eric Blake wrote: >> On 01/17/2018 08:47 AM, Marc-André Lureau wrote: >>> The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: >>> >>>

Re: [Qemu-devel] [PULL 0/1] Dump patches

Hi On Fri, Jan 19, 2018 at 4:29 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 19 January 2018 at 15:24, Peter Maydell <peter.mayd...@linaro.org> wrote: >> On 19 January 2018 at 14:35, Marc-Andre Lureau <mlur...@redhat.com> wrote: >>> I have not fou

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

Hi, Stash this to fix test leaks: diff --git a/tests/tpm-crb-test.c b/tests/tpm-crb-test.c index de78a28844..8bf1507e00 100644 --- a/tests/tpm-crb-test.c +++ b/tests/tpm-crb-test.c @@ -81,6 +81,7 @@ static void *emu_tpm_thread(void *data) g_free(s->tpm_msg); s->tpm_msg = NULL; +

Re: [Qemu-devel] [PATCH] fw_cfg: don't use DMA mapping for fw_cfg device

Hi On Mon, Jan 15, 2018 at 9:55 AM, Peter Xu wrote: > fw_cfg device does not need IOMMU protection, so use physical addresses > always. That's how QEMU implements fw_cfg. Otherwise we'll see call > traces during boot when vIOMMU is enabled in guest: > > [1.018306]

Re: [Qemu-devel] [PATCH] char-pty: avoid assertion warning

Hi On Fri, Jan 26, 2018 at 12:40 AM, Peng Hao wrote: > g_source_unref(s->open_source) in pty_chr_timer may trigger a assertion like > this: > g_source_unref: assertion 'source != NULL' failed. > pty_chr_update_read_handler_locked-->pty_chr_state(chr, 0) may be called > in

Re: [Qemu-devel] [PATCH] tpm: fix alignment issues

Hi On Mon, Jan 29, 2018 at 6:41 PM, Stefan Berger wrote: > On 01/29/2018 07:32 AM, Marc-André Lureau wrote: >> >> The new tpm-crb-test fails on sparc host: >> >> TEST: tests/tpm-crb-test... (pid=230409) >>/i386/tpm-crb/test: >> Broken pipe >> FAIL >> GTester: last

Re: [Qemu-devel] [PATCH 2/2] tpm: wrap stX_be_p in tpm_cmd_set_XYZ functions

Hi On Fri, Feb 2, 2018 at 12:23 AM, Stefan Berger wrote: > Wrap the calls to stl_be_p and stw_be_p in tpm_cmd_set_XYZ functions > that are similar to existing getters. why not, Reviewed-by: Marc-André Lureau > > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 1/4] tpm: Split off tpm_crb_reset function

On Fri, Feb 2, 2018 at 3:44 PM, Stefan Berger wrote: > Split off the tpm_crb_reset function part from tpm_crb_realize > that we need to run every time the machine resets. > > Also register our reset function with the system since TYPE_DEVICE > seems to not get a reset

Re: [Qemu-devel] [PATCH 3/4] MAINTAINERS: add pointer to tpm-next repository

On Fri, Feb 2, 2018 at 3:44 PM, Stefan Berger wrote: > Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS

Re: [Qemu-devel] [PATCH RFC 05/21] qapi: Turn generators into modules

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The next commit will introduce a common driver program for all > generators. The generators need to be modules for that. qapi2texi.py > already is. Make the other generators follow suit. > > The changes are actually

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Error messages print absolute filenames of included files even gave a > relative one on the command line: > > PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py > tests/qapi-schema/include-cycle.json >

Re: [Qemu-devel] [PATCH RFC 06/21] qapi-gen: New common driver for code and doc generators

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Whenever qapi-schema.json changes, we run six programs eleven times to > update eleven files. This is silly. Replace the six programs by a > single program that spits out all eleven files. > Now we will need

Re: [Qemu-devel] [PATCH RFC 16/21] qapi/types qapi/visit: Make visitors use QAPIGen more

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The conversion is rather shallow so far: most of the output > accumulation is not converted. Take the next step: convert output > accumulation in QAPISchemaGenTypeVisitor and > QAPISchemaGenVisitVisitor. Helper

Re: [Qemu-devel] [PATCH RFC 19/21] qapi/types: Generate separate .h, .c for each module

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Our qapi-schema.json is composed of modules connected by include > directives, but the generated code is monolithic all the same: one > qapi-types.h with all the types, one qapi-visit.h with all the > visitors, and so

Re: [Qemu-devel] [PATCH RFC 11/21] qapi: Lift error reporting from QAPISchema.__init__() to callers

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > scripts/qapi-gen.py| 8 ++-- > scripts/qapi/common.py | 23

Re: [Qemu-devel] [PATCH RFC 20/21] Include less of qapi-types.h

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > In my "build everything" tree, a change to the types in > qapi-schema.json triggers a recompile of about 4500 out of 4800 > objects. > > The previous commit split up the generated qapi-types.h. Replace > includes of

Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc

Hi On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > These classes encapsulate accumulating and writing output. > > Convert C code generation to QAPIGenC and QAPIGenH. The conversion is > rather shallow: most of the output accumulation is not converted. > Left for

Re: [Qemu-devel] [PATCH RFC 13/21] qapi: Record 'include' directives in parse tree

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The parse tree is a list of expressions. Except include expressions > currently get replaced by the included file's parse tree. > > Instead of throwing away the include expression, keep it with the file > name expanded

Re: [Qemu-devel] [PATCH RFC 04/21] qapi: Reduce use of global variables in generators some

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > In preparation of the next commit, which will turn the generators into > modules. These global variables will become local to main() then. > > Signed-off-by: Markus Armbruster Reviewed-by:

Re: [Qemu-devel] [PATCH RFC 17/21] qapi/types qapi/visit: Generate built-in stuff into separate files

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Linking code from multiple separate QAPI schemata into the same > program is possible, but involves some weirdness around built-in > types: > > * We generate code for built-in types into .c only with option >

Re: [Qemu-devel] [PATCH RFC 14/21] qapi: Generate in source order

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The generators' conversion to visitors (merge commit 9e72681d16) > changed the processing order of entities from source order to > alphabetical order. The next commit needs source order, so change it > back. > >

Re: [Qemu-devel] [PATCH RFC 02/21] qapi: Generate up-to-date copyright notice

Hi On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Each generator carries a copyright notice for the generator itself, > and another one for the files it generates. Only the former have been > updated along the way, the latter have not, and are all out of date. > >

Re: [Qemu-devel] [PATCH RFC 15/21] qapi: Record 'include' directives in intermediate representation

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The include directive permits modular QAPI schemata, but the generated > code is monolithic all the same. To permit generating modular code, > the front end needs to pass more information on inclusions to the back >

Re: [Qemu-devel] [PATCH RFC 10/21] qapi/common: Eliminate QAPISchema.exprs

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > scripts/qapi/common.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [Qemu-devel] [PATCH RFC 12/21] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__()

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster It's not obvious the motivation behind this change (beside behind more elegant), but Reviewed-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH RFC 07/21] qapi: Move parse_command_line() next to its only use

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > scripts/qapi-gen.py| 52 +++- >

Re: [Qemu-devel] [PATCH RFC 01/21] qapi: Streamline boilerplate comment generation

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Every generator has separate boilerplate for .h and .c, and their > differences are boring. All of them repeat the license note. > > Reduce the repetition as follows. Move common text like the license > note to common

Re: [Qemu-devel] [PATCH RFC 18/21] qapi/common: Fix guardname() for funny filenames

On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > guardname() fails to return a valid C identifier for arguments > containing anything but [A-Za-z0-9_.-']. Fix that. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH RFC 14/21] qapi: Generate in source order

On Mon, Feb 5, 2018 at 3:33 PM, Markus Armbruster <arm...@redhat.com> wrote: > Marc-Andre Lureau <mlur...@redhat.com> writes: > >> On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <arm...@redhat.com> wrote: >>> The generators' conversion to visitor

Re: [Qemu-devel] [PATCH v4 5/9] sockets: move fd_is_socket() into common sockets code

On Mon, Feb 5, 2018 at 4:24 PM, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > The fd_is_socket() helper method is useful in a few places, so put it in > the common sockets code. Make the code more compact while moving it. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] tpm: fix alignment issues

Hi On Mon, Jan 29, 2018 at 6:57 PM, Stefan Berger <stef...@linux.vnet.ibm.com> wrote: > On 01/29/2018 12:51 PM, Marc-Andre Lureau wrote: >> >> Hi >> >> On Mon, Jan 29, 2018 at 6:41 PM, Stefan Berger >> <stef...@linux.vnet.ibm.com> wrote: >>&g

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

Hi On Mon, Feb 12, 2018 at 3:25 PM, Daniel Henrique Barboza wrote: > From: Yasmin Beatriz > > fd_write_vmcore can fail to execute for a lot of reasons that can be > retrieved by errno, but it only returns -1. This makes difficult for >

Re: [Qemu-devel] [PATCH v2 26/29] docs: Correct outdated information on QAPI

On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > * Fix guidance on error classes > > * Point to generated documentation > > * Drop plea for documentation, because the QAPI code generator > enforces it since commit 3313b6124b > > * Minor tweaks here and there > >

Re: [Qemu-devel] [PATCH v2 29/29] qapi: Don't create useless directory qapi-generated

On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > We used to generate first test and later QGA QAPI code into > qapi-generated/. Commit b93b63f574 moved the test code to tests/. > Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The > directory has been

Re: [Qemu-devel] [PATCH v2 25/29] docs/devel/writing-qmp-commands: Update for modular QAPI

On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > With modular code generation, putting stuff right into > qapi-schema.json is a bad idea. Update writing-qmp-commands.txt > accordingly. > > Signed-off-by: Markus Armbruster Reviewed-by:

Re: [Qemu-devel] [PATCH v2 20/29] qapi/types qapi/visit: Generate built-in stuff into separate files

Hi On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > Linking code from multiple separate QAPI schemata into the same > program is possible, but involves some weirdness around built-in > types: > > * We generate code for built-in types into .c only with option >

Re: [Qemu-devel] [PATCH v2 10/29] qapi: Touch generated files only when they change

Hi On Mon, Feb 12, 2018 at 8:48 PM, Eric Blake wrote: > On 02/11/2018 03:35 AM, Markus Armbruster wrote: >> >> A massive number of objects depends on QAPI-generated headers. In my >> "build everything" tree, it's roughly 4800 out of 5100. This is >> particularly annoying

Re: [Qemu-devel] [PATCH v2 09/29] qapi-gen: Convert from getopt to argparse

On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > argparse is nicer to use than getopt, and gives us --help almost for > free. > > Signed-off-by: Markus Armbruster nice, Reviewed-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH v2 04/29] qapi: Rename variable holding the QAPISchemaGenFOOVisitor

On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > Rename the variable holding the QAPISchemaGenFOOVisitor from gen to > vis, to avoid confusion in the next commit. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 23/29] Include less of the generated modular QAPI headers

On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > In my "build everything" tree, a change to the types in > qapi-schema.json triggers a recompile of about 4800 out of 5100 > objects. > > The previous commit split up qmp-commands.h, qmp-event.h, qmp-visit.h, >

Re: [Qemu-devel] [PATCH v2 28/29] Fix up dangling references to qmp-commands.* in comment and doc

On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit > 5032a16d1d. > > Fix up the reference to qmp-commands.txt in > docs/xen-save-devices-state.txt. Missed in commit 4d8bb958fa. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 01/29] Include qapi/qmp/qerror.h exactly where needed

On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > block.c | 1 - > block/qcow2.c | 1 - > chardev/char-fe.c |

Re: [Qemu-devel] [PATCH v2 18/29] qapi: Rename generated qmp-marshal.c to qmp-commands.c

On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > All generated .c are named like their .h, except for qmp-marshal.c and > qmp-commands.h. To add to the confusion, tests-qmp-commands.c falsely > matches generated test-qmp-commands.h. > > Get rid of this unnecessary

Re: [Qemu-devel] [PATCH v2 19/29] qapi: Make code-generating visitors use QAPIGen more

On Sun, Feb 11, 2018 at 10:35 AM, Markus Armbruster wrote: > The use of QAPIGen is rather shallow so far: most of the output > accumulation is not converted. Take the next step: convert output > accumulation in the code-generating visitor classes. Helper functions > outside

Re: [Qemu-devel] [PATCH v2 27/29] qapi: Move qapi-schema.json to qapi/, rename generated files

On Sun, Feb 11, 2018 at 10:36 AM, Markus Armbruster wrote: > Move qapi-schema.json to qapi/, so it's next to its modules, and all > files get generated to qapi/, not just the ones generated for modules. > > Consistently name the generated files qapi-MODULE.EXT: >

Re: [Qemu-devel] [PATCH RFC 14/14] qapi: Add #if conditions to commands, events, types, visitors

Hi On Mon, Feb 12, 2018 at 8:22 AM, Markus Armbruster wrote: > Example change to generated code: > > diff -rup test-qapi-events.h.old test-qapi-events.h > --- test-qapi-events.h.old 2018-02-12 07:02:45.672737544 +0100 > +++ test-qapi-events.h 2018-02-12

Re: [Qemu-devel] [PATCH v2 0/2] Add tests for the TPM TIS

On Thu, Feb 15, 2018 at 3:10 PM, Stefan Berger wrote: > This series of patches adds tests for the TPM TIS. > >Stefan > > v1->v2: > - moved common TPM test code into tpm-emu.c > - clearified a few comments in tpm-tis-test.c, no code changes > > Stefan Berger (2):

Re: [Qemu-devel] [PATCH v1 1/2] Revert "build-sys: silence make by default or V=0"

On Tue, Jan 23, 2018 at 5:47 PM, Daniel P. Berrange wrote: > This reverts commit 42a77f1ce4934b243df003f95bda88530631387a. > > The primary intention of this change was to silence messages > like > > make[1]: '/home/berrange/src/virt/qemu/capstone/libcapstone.a' is up to >

Re: [Qemu-devel] [PATCH v10 2/4] fw_cfg: do DMA read operation

Hi On Wed, Jan 24, 2018 at 4:25 AM, Peter Xu wrote: > On Tue, Jan 23, 2018 at 05:40:39PM +0100, Marc-André Lureau wrote: >> Modify fw_cfg_read_blob() to use DMA if the device supports it. >> Return errors, because the operation may fail. >> >> The DMA operation is expected to

Re: [Qemu-devel] [PATCH v2 4/5] tpm: add CRB device

Hi On Sun, Jan 21, 2018 at 6:46 AM, Stefan Berger wrote: > On 01/20/2018 07:54 AM, Philippe Mathieu-Daudé wrote: >> >> On 01/19/2018 11:11 AM, Marc-André Lureau wrote: >>> >>> tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) >>> Interface as defined in

Re: [Qemu-devel] [PATCH v2 4/5] tpm: add CRB device

Hi On Sun, Jan 21, 2018 at 11:01 PM, Stefan Berger <stef...@linux.vnet.ibm.com> wrote: > On 01/21/2018 02:24 PM, Marc-Andre Lureau wrote: >> >> Hi >> >> On Sun, Jan 21, 2018 at 6:46 AM, Stefan Berger >> <stef...@linux.vnet.ibm.com> wrote: >>&

Re: [Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogus V=0 variable

On Tue, Jan 23, 2018 at 5:47 PM, Daniel P. Berrange wrote: > The make rules for building QEMU are mostly silent by default. They can > be made verbose by setting the variable V=1. The default state does not > however correspond to a V=0 setting - $(V) must be undefined /

Re: [Qemu-devel] [PULL 10/51] build-sys: silence make by default or V=0

Hi On Tue, Jan 23, 2018 at 4:38 PM, Daniel P. Berrange wrote: > On Tue, Jan 16, 2018 at 03:16:52PM +0100, Paolo Bonzini wrote: >> From: Marc-André Lureau >> >> Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu >> specific). >>