On 04/01/2015 06:53 PM, Markus Armbruster wrote:
Marcel Apfelbaum writes:
[...]
I noticed something weird. I cannot actually create an instance of machine
or get a reference to current_machine in order to query its properties!
It seems that util/qemu-config is used by qemu-img which
On 04/01/2015 07:20 PM, Eric Blake wrote:
On 04/01/2015 10:11 AM, Marcel Apfelbaum wrote:
On 04/01/2015 06:53 PM, Markus Armbruster wrote:
Marcel Apfelbaum writes:
[...]
I noticed something weird. I cannot actually create an instance of
machine
or get a reference to current_machine in order
(the generic ones)
are restored only for qemu-config scope.
We need to find a better fix for 2.4.
Reported-by: Tony Krowiak
Signed-off-by: Marcel Apfelbaum
---
v1->v2:
Addressed Eric Blake's and Markus Armbruster's comments:
- Left only generic options (and not the per-machin
On 04/01/2015 07:30 PM, Eric Blake wrote:
On 04/01/2015 09:17 AM, Eric Blake wrote:
On 04/01/2015 08:08 AM, Marcel Apfelbaum wrote:
Commit 49d2e64 (machine: remove qemu_machine_opts global list) made
machine machine options specific to machine sub-type, leaving
At the risk of sounding like a
On 04/01/2015 07:47 PM, Marcel Apfelbaum wrote:
Commit 49d2e64 (machine: remove qemu_machine_opts global list)
made machine options specific to machine sub-type, leaving
the qemu_machine_opts desc array empty. Sadly this is the place
qmp_query_command_line_options is looking for supported
On 04/01/2015 08:29 PM, Eric Blake wrote:
On 04/01/2015 10:47 AM, Marcel Apfelbaum wrote:
Commit 49d2e64 (machine: remove qemu_machine_opts global list)
made machine options specific to machine sub-type, leaving
the qemu_machine_opts desc array empty. Sadly this is the place
On 12/24/2014 12:12 AM, Laszlo Ersek wrote:
Apologies if this problem is known. After building qemu at ab0302ee:
The problem is not known.
Thanks for finding it and testing it!
Marcel
$ qemu-system-x86_64 -usb
qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion `o
assert(build_state->table_ram != RAM_ADDR_MAX);
build_state->table_size = acpi_data_len(tables.table_data);
-acpi_add_rom_blob(NULL, tables.linker, "etc/table-loader");
+acpi_add_rom_blob(NULL, tables.linker, "etc/table-loader", 0);
fw_cfg_add_file(guest_info->fw_cfg, ACPI_BUILD_TPMLOG_FILE,
tables.tcpalog->data, acpi_data_len(tables.tcpalog));
Acked-by: Marcel Apfelbaum
patch avoids calling qemu_opt_get_bool() to fix the assertion
failure:
$ qemu-system-x86_64 -usb
qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type ==
QEMU_OPT_BOOL' failed.
Test the presence of -usb using qemu_opt_find() but use the
MachineState->usb fiel
The argument is not longer used and the implementation
uses now QOM instead of QemuOpts.
Signed-off-by: Marcel Apfelbaum
---
hw/arm/nseries.c| 2 +-
hw/arm/pxa2xx.c | 4 ++--
hw/arm/realview.c | 2 +-
hw/arm/versatilepb.c| 2 +-
hw/i386/pc_piix.c | 2 +-
hw
ites
As part of this series the semantics for some ppc machines to
create the default usb controller were changed, but I still think
is correct, please let me know if you see a problem there.
Based on the comments I will receive, I will continue to fix the options
properties in the same way.
Ma
Signed-off-by: Marcel Apfelbaum
---
hw/ppc/mac_newworld.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index b54f94a..c377012 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -371,6 +371,7 @@ static void
Following QOM convention, object properties should
not be accessed directly.
Signed-off-by: Marcel Apfelbaum
---
hw/core/machine.c | 5 +
include/hw/boards.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index a0ae5f9..fbd91be 100644
--- a/hw
were true.
Modified the logic to:
Create the usb controller if:
- the machine condition is true and defaults are enabled or
- the usb option is supplied and true.
The main for this is to simplify the usb_enabled method.
Signed-off-by: Marcel Apfelbaum
---
hw/ppc/mac_newworld.c | 3 ++-
hw/p
Signed-off-by: Marcel Apfelbaum
---
hw/ppc/spapr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 72c3102..53c4116 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine
Signed-off-by: Marcel Apfelbaum
---
hw/ppc/mac_newworld.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index ed37d6b..b54f94a 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
On 01/05/2015 11:21 AM, Gal Hammer wrote:
The monitor's auto-completion feature stopped working when stdio is used
as an input and qemu was resumed after it was suspended (using ctrl-z).
Thanks Gal, it works now!
Tested-by: Marcel Apfelbaum
Signed-off-by: Gal Hammer
---
qemu-c
On 01/06/2015 04:56 PM, Stefan Hajnoczi wrote:
On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote:
On 2015/1/6 9:21, Chen, Tiejun wrote:
On 2015/1/6 1:13, Eric Blake wrote:
On 01/04/2015 10:35 PM, Tiejun Chen wrote:
After one commit 49d2e648e808, "machine: remove qemu_machine_opts
g
On 01/06/2015 11:01 AM, Chen, Tiejun wrote:
On 2015/1/6 14:20, Shannon Zhao wrote:
On 2015/1/6 10:37, Chen, Tiejun wrote:
On 2015/1/5 20:14, Marcel Apfelbaum wrote:
On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote:
On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka
wrote:
On 2015-01-05 12:22, Stefan
on
file is loaded.
Cc: qemu-sta...@nongnu.org
Reported-by: William Dauchy
Signed-off-by: Marcel Apfelbaum
---
vl.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/vl.c b/vl.c
index 7786b2f..ecd8c93 100644
--- a/vl.c
+++ b/vl.c
@@ -3659,6 +3659,11 @@ int main(int argc, char **argv, c
On 01/07/2015 01:15 PM, Alexander Graf wrote:
On 07.01.15 12:07, Paolo Bonzini wrote:
On 07/01/2015 12:03, Marcel Apfelbaum wrote:
While I agree it will be better if we place this in instance_init,
setting the machine_usb to defaults_enabled() there would be problematic
since it depends
on
file is loaded.
Cc: qemu-sta...@nongnu.org
Reported-by: William Dauchy
Signed-off-by: Marcel Apfelbaum
---
v2 -> v3:
- Addressed Paolo Bonzini's comments:
- fixed whitespace
v1 -> v2:
- Addressed Paolo Bonzini's comments:
- moved the call to machine_parse after t
On 01/07/2015 01:35 PM, Paolo Bonzini wrote:
On 07/01/2015 12:34, Marcel Apfelbaum wrote:
After 'Machine as QOM' series the machine type input triggers
the creation of the machine class.
If the machine type is set in the configuration file, the machine
class is not updated accor
On 01/06/2015 09:44 PM, Paolo Bonzini wrote:
On 06/01/2015 18:41, Marcel Apfelbaum wrote:
After 'Machine as QOM' series the machine type input triggers
the creation of the machine class.
If the machine type is set in the configuration file, the machine
class is not updated accor
on
file is loaded.
Cc: qemu-sta...@nongnu.org
Reported-by: William Dauchy
Signed-off-by: Marcel Apfelbaum
---
v1 -> v2:
- Addressed Paolo Bonzini's comments:
- moved the call to machine_parse after the switch
and brought QEMU_OPTION_M near QEMU_OPTION_machine
vl.c | 17 ++
On 01/07/2015 01:34 PM, Marcel Apfelbaum wrote:
After 'Machine as QOM' series the machine type input triggers
the creation of the machine class.
If the machine type is set in the configuration file, the machine
class is not updated accordingly and remains the default.
Fixed that by qu
On 01/06/2015 10:45 PM, Paolo Bonzini wrote:
On 06/01/2015 14:29, Marcel Apfelbaum wrote:
@@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine)
/* Graphics */
if (spapr_vga_init(phb->bus)) {
spapr->has_graphics = true;
+machin
On 01/07/2015 01:37 PM, Alexander Graf wrote:
On 07.01.15 12:32, Paolo Bonzini wrote:
On 07/01/2015 12:27, Alexander Graf wrote:
Hmm, then I guess let's apply these patches and fix things up later?
Certainly works for me ;).
Send a pull request then. :)
Ok, applied the patch set to pp
On 01/07/2015 02:12 PM, Paolo Bonzini wrote:
On 07/01/2015 13:11, Marcel Apfelbaum wrote:
After 'Machine as QOM' series the machine type input triggers
the creation of the machine class.
If the machine type is set in the configuration file, the machine
class is not updated accor
On 01/08/2015 06:09 PM, Michal Privoznik wrote:
Well, after 49d2e648e8087 the options to -machine parameter no longer
has .desc nor .desc->type. That's mainly because the options are
dynamically added while .desc is allocated statically. Anyway, if user
tries to run:
qemu-system-x86_64 -mach
On 01/08/2015 07:33 PM, Michael Roth wrote:
Hi everyone,
The following new patches are queued for QEMU stable v2.1.3:
https://github.com/mdroth/qemu/commits/stable-2.1-staging
The release is planned for 2015-01-21:
http://wiki.qemu.org/Planning/2.1
Please respond here or CC qemu-sta...
The main's switch had a few cases misaligned.
Signed-off-by: Marcel Apfelbaum
---
vl.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index 7786b2f..adfdbfd 100644
--- a/vl.c
+++ b/vl.c
@@ -3147,9 +3147,9 @@ int main(int argc, char **argv,
On 01/11/2015 12:06 PM, Stefan Weil wrote:
Am 11.01.2015 um 10:37 schrieb Marcel Apfelbaum:
The main's switch had a few cases misaligned.
Signed-off-by: Marcel Apfelbaum
---
vl.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Weil
This is happening because an actual logic is performed on the memory
arguments inside the main's switch, disregarding the config file content.
Solved by extracting the logic on a separate function and calling it
after the switch.
Signed-off-by: Marcel Apfelbaum
---
vl.c
The misalignment was caused by tabs which were used instead of spaces.
Signed-off-by: Marcel Apfelbaum
---
v1 -> v2:
- Addressed Stefan Weil's comments:
- Hunted all the tabs within the switch/main
vl.c | 38 +++---
1 file changed, 19 insertion
On 12/16/2014 01:23 PM, Amit Shah wrote:
PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM
functions. Add such properties to the ICH9 chipset as well for the Q35
machine type.
S3 / S4 are not guaranteed to always work (needs work in the guest as
well as QEMU for things to w
On 01/12/2015 12:55 PM, Amit Shah wrote:
On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote:
On 12/16/2014 01:23 PM, Amit Shah wrote:
PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM
functions. Add such properties to the ICH9 chipset as well for the Q35
machine type
_plug_cb(ICH9LPCPMRegs *pm, DeviceState *dev, Error **errp)
diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
index fe975e6..12d7a7a 100644
--- a/include/hw/acpi/ich9.h
+++ b/include/hw/acpi/ich9.h
@@ -49,6 +49,10 @@ typedef struct ICH9LPCPMRegs {
AcpiCpuHotplug gpe_cpu;
Mem
On 01/12/2015 05:04 AM, Chen Fan wrote:
in spec "PCI Express 3.0" section 6.2.6 Figure 6-3 virtual bridge part,
the flowchart showing tell us SERR# enable at Bridge Control register
associate with system error at Secondary Status register can send error
message. but bridge_control from dev->confi
On 01/13/2015 07:49 PM, William Dauchy wrote:
Hello,
On Jan09 23:42, Paolo Bonzini wrote:
That's commit 364c3e6b8dd7912e01d19122d791b8c8f6df4f6c on branch
uq/master of git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git.
maybe the one for:
fix regression when reading memory size from config fi
On 01/19/2015 11:55 PM, Michael S. Tsirkin wrote:
On Mon, Jan 19, 2015 at 01:42:25PM +0100, Paolo Bonzini wrote:
On 19/12/2014 03:02, Igor Mammedov wrote:
Replace template patching and runtime
calculation in _CRS() method with static _CRS
defined in SSDT.
It also drops manual hole patching f
_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
if (o) {
pm->s4_val = qint_get_int(qobject_to_qint(o));
-} else {
-pm->s4_val = false;
}
qobject_decref(o);
Reviewed-by: Marcel Apfelbaum
2015?
Michael, can you change this on the fly?
Other than that:
Acked-by: Marcel Apfelbaum
+ *
+ * Author: Michael S. Tsirkin
+ * Author: Igor Mammedov
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as
{
GArray *package = build_alloc_array();
diff --git a/include/hw/acpi/acpi-build-utils.h
b/include/hw/acpi/acpi-build-utils.h
index e6a0b28..fd50625 100644
--- a/include/hw/acpi/acpi-build-utils.h
+++ b/include/hw/acpi/acpi-build-utils.h
@@ -12,7 +12,7 @@ void build_append_byte(GArray *array, uint8_t val);
void build_append_array(GArray *array, GArray *val);
void GCC_FMT_ATTR(2, 3)
-build_append_nameseg(GArray *array, const char *format, ...);
+build_append_namestring(GArray *array, const char *format, ...);
void build_prepend_package_length(GArray *package, unsigned min_bytes);
void build_package(GArray *package, uint8_t op, unsigned min_bytes);
Acked-by: Marcel Apfelbaum
GArray *package);
+void build_package(GArray *package, uint8_t op);
void build_append_value(GArray *table, uint32_t value, int size);
void build_append_int(GArray *table, uint32_t value);
void build_extop_package(GArray *package, uint8_t op);
Reviewed-by: Marcel Apfelbaum
l PCI buses. Generate tables to support hotplug. */
-pci_for_each_bus_depth_first(bus, build_pci_bus_begin,
- build_pci_bus_end,
&hotplug_state);
+build_append_pci_bus_devices(sb_scope, bus,
+ pm->pcihp_bridge_en);
}
-
-build_append_array(sb_scope, hotplug_state.device_table);
-build_pci_bus_state_cleanup(&hotplug_state);
}
build_package(sb_scope, op);
build_append_array(table_data, sb_scope);
This one is tricky to review...
I do agree with the concept, I like the simplification,
and no obvious errors were found.
So ... "light":
Reviewed-by: Marcel Apfelbaum
On 01/21/2015 11:56 AM, Chen Fan wrote:
On 01/16/2015 03:56 PM, Chen Fan wrote:
On 01/12/2015 09:56 PM, Marcel Apfelbaum wrote:
On 01/12/2015 05:04 AM, Chen Fan wrote:
in spec "PCI Express 3.0" section 6.2.6 Figure 6-3 virtual bridge part,
the flowchart showing tell us SERR#
If multiple root busses are used, root bus 0 cannot use all the
pci holes ranges. Remove the IO/mem ranges used by the other
primary busses.
todo: properly compute the bus ranges for root bus 0.
Signed-off-by: Marcel Apfelbaum
---
hw/i386/acpi-build.c | 74
Signed-off-by: Marcel Apfelbaum
---
hw/acpi/acpi-build-utils.c | 107 +++--
include/hw/acpi/acpi-build-utils.h | 12 +
2 files changed, 116 insertions(+), 3 deletions(-)
diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c
index
node (acpi proximity)
- Think of migration implications and missing code (Ideas?)
Any comments will be welcomed and appreciated.
I will not be able to respond next week, but after that
I'll answer to all questions/comments.
Thanks,
Marcel
Marcel Apfelbaum (17):
acpi: added needed acpi construc
From: Marcel Apfelbaum
This refactoring moves all the code needed (recursively)
to register TYPE_PCI_BUS type to a new file hw/pci/pci_bus.c .
This allows to properly add new functionality to the pci bus class.
Signed-off-by: Marcel Apfelbaum
---
arch_init.c | 1 +
hw/alpha
If the machine has several root busses, we need to add them to
acpi in order to be properly detected by guests.
Signed-off-by: Marcel Apfelbaum
---
hw/i386/acpi-build.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi
Signed-off-by: Marcel Apfelbaum
---
hw/i386/acpi-build.c | 77
1 file changed, 77 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 9837120..cb77fa3 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
From: Marcel Apfelbaum
Refactoring it as a method of PCIBusClass will allow
different implementations for subclasses.
Signed-off-by: Marcel Apfelbaum
---
hw/i386/kvm/pci-assign.c | 1 +
hw/pci/pci-hotplug-old.c | 1 +
hw/pci/pci.c | 7 ---
hw/pci/pci_bus.c | 10
From: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pci.c | 8
include/hw/pci/pci_host.h | 4
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index bf31168..d0d0035 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
From: Marcel Apfelbaum
Refactoring it as a method of PCIBusClass will allow
different implementations for subclasses.
Removed the assumption that the root bus does not
have a parent device because is specific only
to the default class implementation.
Signed-off-by: Marcel Apfelbaum
---
hw
Save the IO/mem ranges assigned to the extra root busses
to be removed from the root bus 0 range.
Todo: find the actual bus numbers range for the root busses.
Signed-off-by: Marcel Apfelbaum
---
hw/i386/acpi-build.c | 110 +++
1 file changed, 110
From: Marcel Apfelbaum
This is a marker interface used to differentiate the
"default" host bridge on a system with multiple host bridges.
This differentiation is required only for pc machines for now
by the ACPI subsystem.
Signed-off-by: Marcel Apfelbaum
---
hw/i386/acpi-build.
From: Marcel Apfelbaum
Instead of assuming it has only one bus, it
enumerates all the host bridges until it finds
the one with bus number corresponding with the
config register.
Signed-off-by: Marcel Apfelbaum
---
hw/pci-host/piix.c | 57
From: Marcel Apfelbaum
Use the newer pci_bus_num to correctly get the root bus number.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index dccb3d1..bf31168 100644
--- a/hw/pci/pci.c
+++ b/hw
The bios does not index the pxb slot number when
it computes the IRQ because it resides on bus 0
and not on the current bus.
However Qemu routes the irq through bus 0 and adds
the pxb slot to the IRQ computation.
Synchronize between bios and Qemu by canceling
pxb's effect.
Signed-off-by: M
From: Marcel Apfelbaum
PXB is a "light-weight" host bridge whose purpose is to enable
the main host bridge to support multiple PCI root buses.
As oposed to PCI-2-PCI bridge's secondary bus, PXB's bus
is a primary bus and can be associated with a NUMA node
(different from
Windows disables the pci-bridge if shpc bar has a memory conflict.
Until this problem is solved, this hack can be used for tests.
Signed-off-by: Marcel Apfelbaum
---
hw/pci-bridge/pci_bridge_dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci
The SSDT size is different from the first time is created and
the second time because between them the BIOS sets ranges for
the other PCI root busses.
The OS-es cannot find the rsdt pointer after that, until this
problem is solved, this hack can be used for testing.
Signed-off-by: Marcel
From: Marcel Apfelbaum
The bios looks for 'etc/extra-pci-roots' to decide if
is going to scan further buses after bus 0 tree.
Signed-off-by: Marcel Apfelbaum
---
hw/i386/pc.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index e07f1f
On Mon, 2014-11-03 at 13:03 +0100, Markus Armbruster wrote:
> Marcel Apfelbaum writes:
>
> > Hot-plugging a device that has a romfile (either supplied by user
> > or built-in) using rombar=0 option is a user error,
> > do not allow the device to be hot-plugged.
> &g
On Mon, 2014-11-03 at 14:40 +0100, Markus Armbruster wrote:
> Marcel Apfelbaum writes:
>
> > On Mon, 2014-11-03 at 13:03 +0100, Markus Armbruster wrote:
> >> Marcel Apfelbaum writes:
> >>
> >> > Hot-plugging a device that has a romfile (either supplie
On Mon, 2014-11-03 at 16:54 +0100, Markus Armbruster wrote:
> Marcel Apfelbaum writes:
>
> > On Mon, 2014-11-03 at 14:40 +0100, Markus Armbruster wrote:
> >> Marcel Apfelbaum writes:
> >>
> >> > On Mon, 2014-11-03 at 13:03 +0100, Markus Armbrust
Hi,
On Tue, 2014-11-04 at 17:12 +0800, Hu Tao wrote:
> This makes code more readable.
>
> Signed-off-by: Hu Tao
> ---
> hw/mips/gt64xxx_pci.c | 4 ++--
> hw/pci/pci_host.c | 5 +++--
> include/hw/pci/pci.h | 2 ++
> 3 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/hw/mips
On Tue, 2014-11-04 at 17:12 +0800, Hu Tao wrote:
> PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA are defined in PCI
> specification, so move them to common place.
>
> Signed-off-by: Hu Tao
> ---
> hw/pci-host/piix.c| 8
> hw/pci-host/q35.c | 8
> include/hw/pci-ho
On Tue, 2014-11-04 at 17:12 +0800, Hu Tao wrote:
> So that standard pci host device can share them.
>
> Signed-off-by: Hu Tao
> ---
> hw/pci-host/piix.c | 20
> hw/pci-host/q35.c | 7 ---
> hw/pci/pci_host.c | 32
> 3 files changed, 32
On Fri, 2014-10-31 at 16:38 +, Igor Mammedov wrote:
> When more memory devices han available KVM memory slots
/s/han/than
> are used, QEMU crashes with:
Better to say (from Laura Novich ):
When more memory devices are used than available
KVM memory slots, QEMU crashes with:
Thanks,
Marcel
envp=0x7fffde70) at vl.c:423
Unparent the shpc mmio region as part of shpc cleanup.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/shpc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c
index 65b2f51..2e887d7 100644
--- a/hw/pci/shpc.c
+++ b/hw/pci/shpc.c
@@ -6
,
> void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, int len);
> uint32_t pci_data_read(PCIBus *s, uint32_t addr, int len);
>
> +static inline bool pci_host_config_enabled(struct PCIHostState *pci_host)
> +{
> +return pci_host->config_reg & (1U << 31);
> +}
> +
> extern const MemoryRegionOps pci_host_conf_le_ops;
> extern const MemoryRegionOps pci_host_conf_be_ops;
> extern const MemoryRegionOps pci_host_data_le_ops;
Reviewed-by: Marcel Apfelbaum
= (1 << QEMU_PCI_SHPC_BITNR),
> + QEMU_PCI_CAP_SLOTID = (1 << QEMU_PCI_SLOTID_BITNR),
> +QEMU_PCIE_SLTCAP_PCP= (1 << QEMU_PCIE_SLTCAP_PCP_BITNR),
> };
>
> #define TYPE_PCI_DEVICE "pci-device"
Definitely more readable.
Reviewed-by: Marcel Apfelbaum
CIBus *bus, int devfn, uint8_t offset,
> uint8_t value)
> {
> -outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
> -outb(0xcfc, value);
> +outl(PCI_HOST_BRIDGE_CONFIG_ADDR, (1U << 31) | (devfn << 8) | offset);
> +outb(PCI_HOST_BRIDGE_CONFIG_DATA, value);
> }
>
> static void qpci_pc_config_writew(QPCIBus *bus, int devfn, uint8_t offset,
> uint16_t value)
> {
> -outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
> -outw(0xcfc, value);
> +outl(PCI_HOST_BRIDGE_CONFIG_ADDR, (1U << 31) | (devfn << 8) | offset);
> +outw(PCI_HOST_BRIDGE_CONFIG_DATA, value);
> }
>
> static void qpci_pc_config_writel(QPCIBus *bus, int devfn, uint8_t offset,
> uint32_t value)
> {
> -outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
> -outl(0xcfc, value);
> +outl(PCI_HOST_BRIDGE_CONFIG_ADDR, (1U << 31) | (devfn << 8) | offset);
> +outl(PCI_HOST_BRIDGE_CONFIG_DATA, value);
> }
>
> static void *qpci_pc_iomap(QPCIBus *bus, QPCIDevice *dev, int barno,
> uint64_t *sizeptr)
Reviewed-by: Marcel Apfelbaum
On Wed, 2014-11-05 at 17:02 +0800, Hu Tao wrote:
> Since the limit parameter is always set to the size of pci device's
> configuration space, and we can determine the size from the type of pci
> device.
>
> Signed-off-by: Hu Tao
> ---
> hw/pci/pci_host.c | 15 +++
> hw/pci/pc
On Sat, 2014-11-22 at 20:05 +0100, Vasilis Liaskovitis wrote:
> The test enables intel_iommu on q35 and reads the DMAR table and its only
> DRHC structure (for now), checking only the header and checksums.
>
> Signed-off-by: Vasilis Liaskovitis
> ---
> tests/bios-tables-test.c | 34 +
On Mon, 2014-11-24 at 14:37 +0100, Vasilis Liaskovitis wrote:
> The test enables intel_iommu on q35, looks for and reads the DMAR table as
> well
> as its only DRHC structure (for now), checking the header and checksums.
Hi Vaisilis,
I had a deeper look to your patch and the code already checks
h
On Mon, 2014-10-27 at 19:34 +0200, Marcel Apfelbaum wrote:
> Hot-plugging a device that has a romfile (either supplied by user
> or built-in) using rombar=0 option is a user error,
> do not allow the device to be hot-plugged.
Hi Michael,
The series has been reviewed, can you please add i
Hi,
The commits:
- 6a1fa9f5 (monitor: add del completion for peripheral device)
- 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper)
cause a QEMU crash when trying to use HMP device_del auto-completion.
It can be easily reproduced by:
-enable-kvm ~/images/fedora.qcow2 -monitor s
On Tue, 2014-11-25 at 09:12 -0500, Luiz Capitulino wrote:
> On Tue, 25 Nov 2014 16:04:19 +0200
> Marcel Apfelbaum wrote:
>
> > Hi,
> >
> > The commits:
> > - 6a1fa9f5 (monitor: add del completion for peripheral device)
> > - 66e56b13 (qdev: add qde
ively
over all the children.
Signed-off-by: Marcel Apfelbaum
---
hw/core/qdev.c | 12 ++--
include/hw/qdev-core.h | 2 +-
monitor.c | 11 ---
3 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 413b413..35
On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote:
> On Wed, 26 Nov 2014 13:50:01 +0200
> Marcel Apfelbaum wrote:
>
> > The commits:
> > - 6a1fa9f5 (monitor: add del completion for peripheral device)
> > - 66e56b13 (qdev: add qdev_build_hotpluggable_device_li
On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote:
> On Wed, 26 Nov 2014 13:50:01 +0200
> Marcel Apfelbaum wrote:
>
> > The commits:
> > - 6a1fa9f5 (monitor: add del completion for peripheral device)
> > - 66e56b13 (qdev: add qdev_build_hotpluggable_device_li
On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote:
> On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote:
> > On Wed, 26 Nov 2014 13:50:01 +0200
> > Marcel Apfelbaum wrote:
> >
> > > The commits:
> > > - 6a1fa9f5 (monitor: add del completion f
On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote:
> On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote:
> > On Wed, 2014-11-26 at 13:05 -0500, Luiz Capitulino wrote:
> > > On Wed, 26 Nov 2014 13:50:01 +0200
> > > Marcel Apfelbaum wrote:
> > >
>
On Thu, 2014-11-27 at 20:08 +0800, Zhu Guihua wrote:
> On Thu, 2014-11-27 at 13:41 +0200, Marcel Apfelbaum wrote:
> > On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote:
> > > On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote:
> > > > On Wed, 2014-11-26 a
On Thu, 2014-11-27 at 13:38 +0100, Igor Mammedov wrote:
> On Thu, 27 Nov 2014 13:41:07 +0200
> Marcel Apfelbaum wrote:
>
> > On Thu, 2014-11-27 at 19:35 +0800, Zhu Guihua wrote:
> > > On Thu, 2014-11-27 at 13:11 +0200, Marcel Apfelbaum wrote:
> > > > On
On Thu, 2014-11-27 at 14:13 +, Peter Maydell wrote:
> On 27 November 2014 at 11:41, Marcel Apfelbaum wrote:
> > I was talking about something different:
> > A hot-pluggable device that was not hot-plugged is assumed to be
> > hot-unpluggable.
> > This is no
On Fri, 2014-11-28 at 09:50 +0800, Zhu Guihua wrote:
> On Thu, 2014-11-27 at 15:48 +0200, Marcel Apfelbaum wrote:
> > On Thu, 2014-11-27 at 13:38 +0100, Igor Mammedov wrote:
> > > On Thu, 27 Nov 2014 13:41:07 +0200
> > > Marcel Apfelbaum wrote:
> > >
>
--- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -779,7 +779,7 @@ static void test_acpi_tcg(void)
>
> memset(&data, 0, sizeof(data));
> data.machine = MACHINE_Q35;
> -test_acpi_one("-machine q35,accel=tcg", &data);
> +t
On Fri, 2014-12-05 at 15:16 +, Peter Maydell wrote:
> On 3 December 2014 at 20:05, Greg Bellows wrote:
> > Adds base Vexpress class and machine objects and infrastructure. This is in
> > preparation for switching to the full QEMU object model. The base vexpress
> > infrastructure is intended
On Fri, 2014-12-05 at 15:39 +, Peter Maydell wrote:
> On 5 December 2014 at 15:33, Greg Bellows wrote:
> >
> >
> > On 5 December 2014 at 09:18, Peter Maydell wrote:
> >>
> >> On 3 December 2014 at 20:05, Greg Bellows wrote:
> >> > Added 'secure' qemu boolean option to qemu_machine_opts[].
>
for 2.3,
so we have plenty of time to do it properly.
Thanks,
Marcel
>
>
> If I missed anything please let me know.
>
>
> Regards,
>
>
> Greg
>
> On 5 December 2014 at 13:40, Marcel Apfelbaum
> wrote:
> On Fri, 2014-12-05 at 15:3
QEMU has support for options per machine, keeping
a global list of options is no longer necessary.
Signed-off-by: Marcel Apfelbaum
---
hw/core/machine.c | 45 +
hw/i386/pc.c | 7 +
hw/ppc/spapr.c| 3 ++
vl.c | 84
,? help.
Marcel Apfelbaum (3):
machine: remove qemu_machine_opts global list
vl.c: simplified machine_set_property
vl.c: add HMP help to machine
hw/core/machine.c | 45 +
hw/i386/pc.c | 7
hw/ppc/spapr.c| 3 ++
vl.c | 117
Refactored the code to re-use object_property_parse.
Signed-off-by: Marcel Apfelbaum
---
vl.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 80d30dd..f9757c3 100644
--- a/vl.c
+++ b/vl.c
@@ -2580,7 +2580,6 @@ static int machine_set_property(const char
The help is based on the actual machine properties
exposing only the relevant options.
Signed-off-by: Marcel Apfelbaum
---
vl.c | 28
1 file changed, 28 insertions(+)
diff --git a/vl.c b/vl.c
index f9757c3..fd54b44 100644
--- a/vl.c
+++ b/vl.c
@@ -1469,6 +1469,31
On Wed, 2014-12-10 at 16:59 -0600, Greg Bellows wrote:
>
>
> On 10 December 2014 at 07:19, Marcel Apfelbaum
> wrote:
> QEMU has support for options per machine, keeping
> a global list of options is no longer necessary.
>
> Signed-
601 - 700 of 2768 matches
Mail list logo
