[Qemu-devel] [PATCH 3/3] pci: add reserved slot check to do_pci_register_device()

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/pci/pci.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 239161e..9dece2a 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -961,6 +961,15 @@

[Qemu-devel] [PATCH 1/3] pci: move check for existing devfn into new pci_bus_devfn_available() helper

Also touch up the logic in do_pci_register_device() accordingly. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/pci/pci.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 0c6f74a..04e6edb

Re: [Qemu-devel] [PATCH 1/4] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function

On 18/08/17 18:06, Philippe Mathieu-Daudé wrote: > On 08/18/2017 01:51 PM, Philippe Mathieu-Daudé wrote: >> On 08/18/2017 11:15 AM, Mark Cave-Ayland wrote: >>> Separate out the standard ethernet CRC32 calculation into a new >>> net_crc32() >>> functi

Re: [Qemu-devel] [Qemu-ppc] BookE MMU question

On 20/08/17 14:35, BALATON Zoltan wrote: > Anyway, this makes more sense because if the TLB 0 entry is replaced > like the above log shows then there will be no mapping for the ff7fd648 > address until the next map_region call maps it. On real hardware this > seems to work but on QEMU this causes

Re: [Qemu-devel] [Qemu-ppc] BookE MMU question

On 20/08/17 22:59, BALATON Zoltan wrote: >> So I'd suggest adding debugging to alloc_tlb() to find out why TLB slot >> 0 is being chosen again for the 0x8000 mapping even though >> free_tlb() hasn't been called for that entry. > > I've tried that but it only confirmed what I thought. This is

[Qemu-devel] [PATCH 1/4] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function

place. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- include/net/net.h |3 ++- net/net.c | 16 +++- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 1c55a93..586098c 100644 --- a/inclu

[Qemu-devel] [PATCH 3/4] pcnet: switch lnc_mchash() over to use net_crc32_le()

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/net/pcnet.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index 6544553..c050993 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -522,23

[Qemu-devel] [PATCH 2/4] net: introduce net_crc32_le() function

This provides a standard ethernet CRC32 little-endian implementation. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- include/net/net.h |2 ++ net/net.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/include/net/net.h b/inclu

[Qemu-devel] [PATCH 4/4] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/net/eepro100.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 5a4774a..4226572 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepr

[Qemu-devel] [PATCH 0/4] net: introduce common net_crc32() and net_crc32_le() functions

patches switch the pcnet and eepro100 drivers over to use them, allowing us to remove their private implementations. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Mark Cave-Ayland (4): net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() fu

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] Add qemu_vga.ndrv MacOS PPC VGA driver from QemuMacDrivers

On 02/05/17 16:52, Howard Spoelstra wrote: > Hi, > > I successfully tested this patch set with a build for OSX. > Installed versions of Mac OS 9.04, 9.1, 9.22, 10.0, 10.1, 10.2, 10.3 > and 10.4 all work. As do three images pulled from running systems with > 10.2, 10.3, 10.4 installed, including

[Qemu-devel] [PATCH 1/2] cg3: make display updates thread safe

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/display/cg3.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index 7ef8a96..1de15a1 100644 --- a/hw/display/cg3.c ++

[Qemu-devel] [PATCH 0/2] cg3/tcx: make display updates thread safe

Now the previous fixes/cleanups have been applied, it is a fairly trivial exercise to make cg3/tcx display updates thread safe. Gerd, do you want to take these patches via your vga queue? Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Mark Cave-Ayland (2): cg3: make d

[Qemu-devel] [PATCH 2/2] tcx: make display updates thread safe

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/display/tcx.c | 68 +++--- 1 file changed, 24 insertions(+), 44 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 0e66dcd..6593c1d 100644 --- a/hw/d

Re: [Qemu-devel] ehci: fix "int" overflow for calculation ehci->last_run_ns

On 10/05/17 09:57, 李林 wrote: > If we experience large delays between echi timer callbacks (i.e. because > other periodic handlers have taken a lot of time to complete) we get a lot of > skipped frames which then delay ehci timer callback. > Then we will calculation ehci->last_run_ns,but

Re: [Qemu-devel] [PATCH 5/6] fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize()

On 12/06/17 13:16, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:20 +0100 > Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > >> This brings the function in line with fw_cfg_mem_realize(), deferring the >> actual mapping until outside of the realize functi

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers

On 12/06/17 20:15, Laszlo Ersek wrote: > Adding Peter > > On 06/12/17 13:54, Mark Cave-Ayland wrote: >> On 12/06/17 12:43, Igor Mammedov wrote: >> >>> On Sat, 10 Jun 2017 13:30:17 +0100 >>> Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: &g

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

On 12/06/17 19:27, Laszlo Ersek wrote: >> Based upon this what do you think the best solution would be? > > > if you apply patch #2 without patch #1, then the above SIGSEGV will hit > on all fw_cfg using targets / machine types, not just > qemu-system-sparc64. The reason is that, after patch #2

[Qemu-devel] [PATCHv2 2/4] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 16 +++- 1 file changed, 7 inse

[Qemu-devel] [PATCHv2 1/4] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

As indicated by Laszlo it is a QOM bug for the realize() method to actually map the device. Set up the IO regions with sysbus_init_mmio() and defer the mapping to the caller, as already done in fw_cfg_init_mem_wide(). Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw

[Qemu-devel] [PATCHv2 0/4] fw_cfg: qdev-related tidy-ups

-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> v2: - Fix the QOM bug in patch 1 as indicated by Laszlo - Minimise code churn compared to v1 Mark Cave-Ayland (4): fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize() fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg

[Qemu-devel] [PATCHv2 4/4] fw_cfg: move QOM type defines into fw_cfg.h

This allows the device to be instantiated externally for boards that wish to wire up the fw_cfg device themselves. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c |8 include/hw/nvram/fw_cfg.h |8 2 files chan

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers

On 12/06/17 20:50, Mark Cave-Ayland wrote: > Now I understand this much better, let me try a v2 of this which fixes > (1) and moves fw_cfg_init1() to a QOM method in the parent as suggested > by Igor and see what you think. Experimenting with this some more, if the aim is to try and

[Qemu-devel] [PATCHv2 3/4] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

the fw_cfg_mem_realize() and fw_cfg_io_realize() functions so it no longer needs to be called manually when instantiating the device. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

On 19/06/17 23:43, Laszlo Ersek wrote: > It looks good to me, but please await Eduardo's reply as well. > > In particular, it should be confirmed that object_resolve_path_type() > matches instances of *subclasses* as well (as I expect it would). Your > test results confirm that; let's make sure

[Qemu-devel] [PATCHv6 4/5] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

the fw_cfg_mem_realize() and fw_cfg_io_realize() functions so it no longer needs to be called manually when instantiating the device, and also rename it to fw_cfg_common_realize() which better describes its new purpose. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo

[Qemu-devel] [PATCHv6 2/5] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> Tested-by: Laszl

[Qemu-devel] [PATCHv6 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

By exposing FWCfgIoState and FWCfgMemState internals we allow the possibility for the internal MemoryRegion fields to be mapped by name for boards that wish to wire up the fw_cfg device themselves. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Erse

[Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

assert() correctly if more than one fw_cfg device is instantiated by accident. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> Tested-by: Laszlo Ersek <ler...@redhat.com> --- hw/nvram/fw_cfg.c | 14 ++

[Qemu-devel] [PATCHv6 0/5] fw_cfg: qdev-related tidy-ups

-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> v6: - Revert move of FWCfgEntry from fw_cfg.c to fw_cfg.h from v5 - Add Reviewed-by tag from Laszlo for patch 5 - Add Tested-by tags from Laszlo for the series v5: - Remove unused FWCfgIoState iobase and dma_iobase fields - Add Reviewed-By tag

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

On 21/06/17 12:36, Eduardo Habkost wrote: > On Wed, Jun 21, 2017 at 09:48:16AM +0200, Laszlo Ersek wrote: >> On 06/21/17 08:58, Mark Cave-Ayland wrote: >>> On 19/06/17 23:43, Laszlo Ersek wrote: >>> >>>> It looks good to me, but please await Eduardo's

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

On 19/06/17 15:28, Eduardo Habkost wrote: > On Mon, Jun 19, 2017 at 01:59:07PM +0100, Mark Cave-Ayland wrote: >> In preparation for calling fw_cfg_init1() during realize rather than during >> init, move the assert() checking for existing fw_cfg devices and the linking &

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

On 23/06/17 19:50, Eduardo Habkost wrote: >> Really, please go back to the earlier discussion around fw_cfg_init1() >> and you'll see my original point (which matches what you just voiced). > > Yep. I was just not sure validation on realize was necessary or > convenient. It looks like we agree

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

On 19/06/17 18:09, Laszlo Ersek wrote: >> What seems to happen is that calling object_property_add_child() only >> succeeds for the first instance and so a simple comparison is enough to >> determine that the device already exists at FW_CFG_PATH. Or is this a >> fairly terrible (ab)use of the QOM

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

On 21/06/17 14:23, Eduardo Habkost wrote: > I now have a v7 patchset ready to go (currently hosted at > https://github.com/mcayland/qemu/tree/fwcfg7 for the curious). Laszlo, > I've currently left off your Tested-by tag since I'm not sure it's still > valid for less-than-trivial

Re: [Qemu-devel] [PATCH v2 0/9] QOM'ify work for sparc

On 20/05/17 01:28, 赵小强 wrote: > 在 2017年5月20日，08:09，Philippe Mathieu-Daudé 写道： > >>> >>> changes since v1: >>> * rebased on the latest master >>> >>> xiaoqiang zhao (9): >>> hw/misc: QOM'ify eccmemctl.c >>> hw/dma: QOM'ify sparc32_dma.c >>> hw/dma: QOM'ify sun4m_iommu.c >>>

Re: [Qemu-devel] sparc64 linux-user status

On 22/05/17 14:45, Alex Bennée wrote: > Hi, > > While looking at some of the docker cross-build patches I thought I'd > checkout if I could still bootstrap some Debian linux-user images. I > made some tweaks to allow debootstrap to bootstrap from Debian's ports > to see if I could get the

Re: [Qemu-devel] [PATCH v2 0/9] QOM'ify work for sparc

On 29/04/17 11:49, xiaoqiang zhao wrote: > This patch set aims for QOM'ifying code relate with sparc. > It is part of my QOM'ify work of qemu code base. > > changes since v1: > * rebased on the latest master > > xiaoqiang zhao (9): > hw/misc: QOM'ify eccmemctl.c > hw/dma: QOM'ify

[Qemu-devel] [PULL] Update OpenBIOS images

+0100) Update OpenBIOS images Mark Cave-Ayland (1): Update OpenBIOS images to 3ebaaa2 built from submodule. pc-bios/openbios-ppc | Bin 750840 -> 750

Re: [Qemu-devel] [PATCH v3 0/8] QOM'ify work for sparc

On 25/05/17 14:34, xiaoqiang zhao wrote: > This patch set aims for QOM'ifying code relate with sparc. > It is part of my QOM'ify work of qemu code base. > > Changes: > > v2 -> v3: > * rebased on the latest master > * squash two patches about m48txx_sysbus into one > > v1 -> v2: > * rebased

[Qemu-devel] [PULL] qemu-sparc updates

Hi Peter, This request contains the SPARC QOMify work which fell through the cracks during the last release. Please pull. ATB, Mark. The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into

[Qemu-devel] [PATCHv5 2/5] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- hw/nvram/fw_

Re: [Qemu-devel] [PATCHv4 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

On 16/06/17 22:28, Laszlo Ersek wrote: > This patch is generally good, but I'd like to suggest improvements: > > (1) In the commit message, please mention that we are exposing the > internals of FWCfgIoState and FWCfgMemState so that board code can map > the MemoryRegion fields (such as

[Qemu-devel] [PATCHv5 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

assert() correctly if more than one fw_cfg device is instantiated by accident. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- hw/nvram/fw_cfg.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) dif

[Qemu-devel] [PATCHv5 1/5] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

obsolete so they can be removed. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- hw/nvram/fw_cfg.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw

[Qemu-devel] [PATCHv5 4/5] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

the fw_cfg_mem_realize() and fw_cfg_io_realize() functions so it no longer needs to be called manually when instantiating the device, and also rename it to fw_cfg_common_realize() which better describes its new purpose. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo

[Qemu-devel] [PATCHv5 0/5] fw_cfg: qdev-related tidy-ups

-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> v5: - Remove unused FWCfgIoState iobase and dma_iobase fields - Add Reviewed-By tags from Laszlo - Update commit message in patch 5 as suggested by Laszlo - Move FWCfgEntry typedef from fw_cfg.h to typedefs.h with the others v4: - Undo acci

[Qemu-devel] [PATCHv5 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

in fw_cfg.h to typedefs.h along with the others. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 55 -- include/hw/nvram/fw_cfg.h | 58 + include/qemu/type

[Qemu-devel] [PATCH 1/3] sun4u: switch to using qdev to instantiate fw_cfg interface

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/sparc64/sun4u.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 69f565d..98ee6f5 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@

[Qemu-devel] [PATCH 0/3] sun4u: move fw_cfg/NVRAM devices to ebus PCI IO address space

. Note: this patchset is dependent upon the fw_cfg patchset I recently posted. Signed-off-by: Mark Cave-Ayland Mark Cave-Ayland (3): sun4u: switch to using qdev to instantiate fw_cfg interface sun4u: expose fw_cfg on ebus PCI IO address space sun4u: expose NVRAM on ebus PCI IO address space

[Qemu-devel] [PATCH 2/3] sun4u: expose fw_cfg on ebus PCI IO address space

To allow future changes to the sun4u PCI topology. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/sparc64/sun4u.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 98ee6f5..19e64be

[Qemu-devel] [PATCH 3/3] sun4u: expose NVRAM on ebus PCI IO address space

To allow future changes to the sun4u PCI topology. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/sparc64/sun4u.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 19e64be..bf738f8 100644 --- a/hw/s

Re: [Qemu-devel] [PATCH 0/3] sun4u: move fw_cfg/NVRAM devices to ebus PCI IO address space

On 10/06/17 14:27, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. Well given that it's dependent upon the fw_cfg patchset I posted earlier, it's probably going to fail on all hosts :) Is there a way to express patch

[Qemu-devel] [PATCH 4/6] fw_cfg: move fw_cfg_init1() into the fw_cfg_*_realize() functions

And rename to fw_cfg_common_realize() which better describes its role. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index f7b78a9..8

[Qemu-devel] [PATCH 5/6] fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize()

This brings the function in line with fw_cfg_mem_realize(), deferring the actual mapping until outside of the realize function. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups

-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Mark Cave-Ayland (6): fw_cfg: move initialisation of FWCfgState into instance_init fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1() fw_cfg: move fw_cfg

[Qemu-devel] [PATCH 6/6] fw_cfg: move QOM type defines into fw_cfg.h

This allows the device to be instantiated externally. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c |8 include/hw/nvram/fw_cfg.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/nvram/fw_cfg.

[Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 316fca9..144e0c6 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw

[Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()

The dma_enabled property enables us to set the FW_CFG_ID version accordingly. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 144e0c6..1313bfd 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -919,8

Re: [Qemu-devel] [PATCHv2 3/4] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On 12/06/17 23:50, Laszlo Ersek wrote: > On 06/12/17 23:21, Mark Cave-Ayland wrote: >> When looking to instantiate a TYPE_FW_CFG_MEM or TYPE_FW_CFG_IO device to be >> able to wire it up differently, it is much more convenient for the caller to >> instantiate the device and ha

Re: [Qemu-devel] [PATCHv2 0/4] fw_cfg: qdev-related tidy-ups

On 14/06/17 13:38, Paolo Bonzini wrote: > On 12/06/2017 23:21, Mark Cave-Ayland wrote: >> As part of some ongoing sun4u work, I need to be able to wire the fw_cfg >> IO interface to a separate IO space by instantiating the qdev device instead >> of calling fw_cfg_init_io().

[Qemu-devel] [PATCHv3 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

assert() correctly if more than one fw_cfg device is instantiated by accident. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index e

[Qemu-devel] [PATCHv3 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

This allows the device to be instantiated externally for boards that wish to wire up the fw_cfg device themselves. As part of the process we add typedefs to the structs that were previously missing them. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw

[Qemu-devel] [PATCHv3 1/5] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

obsolete so they can be removed. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 316fca9..70a0d5f 100644 --- a/hw/nvram/fw

[Qemu-devel] [PATCHv3 0/5] fw_cfg: qdev-related tidy-ups

-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> v3: - Rework patch 1 to use sysbus_add_io() as suggested by Laszlo - Add Reviewed-By from Laszlo for patch 2 - Fix assert() when instantiating > 1 fw_cfg device (new patch 3) - Rename fw_cfg_init1() to fw_cfg_common_realize() as part of pa

[Qemu-devel] [PATCHv3 2/5] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- hw/nvram/fw_

[Qemu-devel] [PATCHv3 4/5] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

the fw_cfg_mem_realize() and fw_cfg_io_realize() functions so it no longer needs to be called manually when instantiating the device, and also rename it to fw_cfg_common_realize() which better describes its new purpose. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw

[Qemu-devel] [PATCHv4 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

assert() correctly if more than one fw_cfg device is instantiated by accident. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index e

[Qemu-devel] [PATCHv4 0/5] fw_cfg: qdev-related tidy-ups

-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> v4: - Undo accidental typedef change in patch 5 caught in v3 rework v3: - Rework patch 1 to use sysbus_add_io() as suggested by Laszlo - Add Reviewed-By from Laszlo for patch 2 - Fix assert() when instantiating > 1 fw_cfg device (ne

[Qemu-devel] [PATCHv4 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

This allows the device to be instantiated externally for boards that wish to wire up the fw_cfg device themselves. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 56 --- include/hw/nvram/fw_cfg.h

Re: [Qemu-devel] [PATCHv3 0/5] fw_cfg: qdev-related tidy-ups

On 16/06/17 13:18, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/include/hw/loader.h:5, > from /tmp/qemu-test/src/device_tree.c:27: > /tmp/qemu-test/src/include/hw/nvram/fw_cfg.h:75: error: redefinition of > typedef ‘FWCfgState’ >

[Qemu-devel] [PATCHv4 4/5] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

the fw_cfg_mem_realize() and fw_cfg_io_realize() functions so it no longer needs to be called manually when instantiating the device, and also rename it to fw_cfg_common_realize() which better describes its new purpose. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw

[Qemu-devel] [PATCHv4 2/5] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- hw/nvram/fw_

[Qemu-devel] [PATCHv4 1/5] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

obsolete so they can be removed. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/nvram/fw_cfg.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 316fca9..70a0d5f 100644 --- a/hw/nvram/fw

Re: [Qemu-devel] [PATCHv5 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

On 18/06/17 21:23, Michael S. Tsirkin wrote: > On Sun, Jun 18, 2017 at 09:02:14AM +0100, Mark Cave-Ayland wrote: >> By exposing FWCfgIoState and FWCfgMemState internals we allow the possibility >> for the internal MemoryRegion fields to be mapped by name for boards that >&g

Re: [Qemu-devel] [PATCHv5 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

On 19/06/17 09:57, Laszlo Ersek wrote: > On 06/18/17 22:23, Michael S. Tsirkin wrote: >> On Sun, Jun 18, 2017 at 09:02:14AM +0100, Mark Cave-Ayland wrote: >>> By exposing FWCfgIoState and FWCfgMemState internals we allow the >>> possibility >>> for the inter

[Qemu-devel] [PATCHv6 1/5] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

obsolete so they can be removed. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Laszlo Ersek <ler...@redhat.com> Tested-by: Laszlo Ersek <ler...@redhat.com> --- hw/nvram/fw_cfg.c | 16 1 file changed, 8 insertions(+), 8 deletions(-

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

On 12/06/17 12:20, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:16 +0100 > Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >> --- >> hw/nvram/fw_cfg.c | 14 ++

Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()

On 12/06/17 12:37, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:18 +0100 > Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > >> The dma_enabled property enables us to set the FW_CFG_ID version >> accordingly. > it might be not safe as patch reorders F

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers

On 12/06/17 12:43, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:17 +0100 > Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > > patch needs a commit message saying why it's needed. > maybe add something similar to: > > qdev_init_nofail() essentially

Re: [Qemu-devel] [PATCHv2 1/4] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

On 12/06/17 23:27, Laszlo Ersek wrote: > It turns out that we introduced the "iobase" and "dma_iobase" properties > *solely* so that we could pass arguments to fw_cfg_io_realize(). But > fw_cfg_io_realize() only needed those parameters for the *wrong* purpose > (namely calling sysbus_add_io()).

Re: [Qemu-devel] [PATCH 1/3] sun4u: switch to using qdev to instantiate fw_cfg interface

On 10/06/17 18:55, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On 06/10/2017 10:00 AM, Mark Cave-Ayland wrote: >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >> --- >> hw/sparc64/sun4u.c | 10 +- >> 1 file changed, 9 insert

Re: [Qemu-devel] [PATCH 3/3] sun4u: expose NVRAM on ebus PCI IO address space

; > On 06/10/2017 10:00 AM, Mark Cave-Ayland wrote: >> To allow future changes to the sun4u PCI topology. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >> --- >> hw/sparc64/sun4u.c |2 +- >> 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups

On 10/06/17 19:15, Philippe Mathieu-Daudé wrote: > Hi Mark, > > Is it possible to reorder the 3rd patch (FW_CFG_ID) first or 2nd in the > series? Mostly for cosmetic :) > > On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote: >> As part of some ongoing sun4u work, I

[Qemu-devel] pci_nic_init_nofail() only works on root PCI buses?

Hi all, Playing around with trying to set up PCI bridges for sun4u, I noticed that I get an assert with the following diff which simply moves the default NIC behind a PCI bridge rather than being directly on the root PCI bus: diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index

[Qemu-devel] [PATCH 1/2] tcx: fix cut/paste error in update_palette_entries()

Commit ee72bed0 "tcx: remove primitives for non-32-bit surfaces" accidentally left a trailing break in update_palette_entries() causing the palette update routine to exit after just one iteration. Remove it. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> ---

Re: [Qemu-devel] [PATCH v2 11/13] tcx: remove primitives for non-32-bit surfaces

On 25/04/17 15:54, Peter Maydell wrote: > On 21 April 2017 at 09:28, Mark Cave-Ayland > <mark.cave-ayl...@ilande.co.uk> wrote: >> As all surfaces in QEMU are now either shared or 32-bit ARGB regardless of >> the guest depth, remove all non-32-bit primitives

[Qemu-devel] [PATCH 2/2] cg3: add explicit ram_addr_t cast to scanline page variable

Coverity warns that multiplying two 32-bit values gives a 32-bit result which is assigned to a 64-bit variable. Add an explicit ram_addr_t cast to silence the warning. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/display/cg3.c |2 +- 1 file changed, 1 ins

[Qemu-devel] [PATCH 0/2] tcx/cg3: fix warnings reported by Coverity

This patchset fixes up a couple of issues from my last set of tcx/cg3 updates spotted by Coverity as reported by Peter. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Mark Cave-Ayland (2): tcx: fix cut/paste error in update_palette_entries() cg3: add explicit ram_addr_

Re: [Qemu-devel] [PATCH v2 01/13] cg3: remove TARGET_PAGE_SIZE rounding on dirty page detection

On 25/04/17 15:57, Peter Maydell wrote: > On 21 April 2017 at 09:28, Mark Cave-Ayland > <mark.cave-ayl...@ilande.co.uk> wrote: >> This was an artifact from very early versions of the code from before the >> memory API and is no longer needed. >> >> Signed-off

Re: [Qemu-devel] Help needed: Sparc 64, kernel panic

On 23/04/17 00:42, Ajallooiean Hossein wrote: Hi Ajallooiean, > Hi Mark, > > Thanks a lot for this. - it did work! > > So, now im wondering how did you install the iso on disk? > > would you mind sharing your command line for the install please? and hacks if > any I simply went for

[Qemu-devel] [PATCH 3/5] ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/ppc/mac_oldworld.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c index 5df94e2..97bb854 100644 --- a/hw/ppc/mac_oldworld.c +++ b/

[Qemu-devel] [PATCH 4/5] ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- hw/ppc/mac_newworld.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index 68aaedc..bae1c0a 100644 --- a/hw/ppc/mac_newworld.c +++ b/

[Qemu-devel] [PATCH 1/5] Add QemuMacDrivers as submodule

The QemuMacDrivers project provides virtualisation drivers for PPC MacOS guests. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- .gitmodules |3 +++ pc-bios/README |3 +++ roms/QemuMacDrivers |1 + 3 files changed, 7 insertions(+) create mode

[Qemu-devel] [PATCH 0/5] Add qemu_vga.ndrv MacOS PPC VGA driver from QemuMacDrivers

ayland/qemu/tree/ppc-vga-upstream. Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Mark Cave-Ayland (5): Add QemuMacDrivers as submodule Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Mac

[Qemu-devel] [PATCH 2/5] Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule

Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> --- Makefile |3 ++- pc-bios/qemu_vga.ndrv | Bin 0 -> 14752 bytes 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 pc-bios/qemu_vga.ndrv diff --git a/Makefile b/Makefile index 31d41a7

Re: [Qemu-devel] [PATCH 0/5] Add qemu_vga.ndrv MacOS PPC VGA driver from QemuMacDrivers

On 02/05/17 02:50, David Gibson wrote: > On Mon, May 01, 2017 at 02:43:29PM +0100, Mark Cave-Ayland wrote: >> Last year Ben posted an initial set of patches for OpenBIOS which provided a >> MacOS PPC VGA driver enabling MacOS guests to control the colour depth and >> resoluti

Re: [Qemu-devel] [PATCH v5 3/4] shutdown: Add source information to SHUTDOWN and RESET

st-initiated > shutdown (for now, the replayed event is always attributed to host). > > See also https://bugzilla.redhat.com/1384007 > > Signed-off-by: Eric Blake <ebl...@redhat.com> For the SPARC part: Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> ATB, Mark.

[Qemu-devel] [PULL] qemu-sparc updates

-05-05 09:49:00 +0100) qemu-sparc update Mark Cave-Ayland (2): tcx: fix cut/paste error in update_palette_entries() cg3: add explicit ram_addr_t cast

<    6   7   8   9   10   11   12   13   14   15   >