Michael S. Tsirkin m...@redhat.com writes:
On Tue, May 21, 2013 at 11:01:05PM +0100, Peter Maydell wrote:
On 21 May 2013 22:46, Michael S. Tsirkin m...@redhat.com wrote:
Once in a while make gets killed and doesn't
clean up partial object files after it.
Result is nasty errors from link.
Cc'ing qemu-trivial.
liguang lig.f...@cn.fujitsu.com writes:
when use DEBUG_DEBUGCON, screen spits:
debugcon: write addr=0x val=0x00
Rdebugcon: write addr=0x val=0x00
udebugcon: write addr=0x val=0x00
ndebugcon: write addr=0x val=0x00
ndebugcon: write addr=0x val=0x00
Eric Blake ebl...@redhat.com writes:
On 05/24/2013 06:23 AM, Luiz Capitulino wrote:
I don't think we need this argument. This command is quite simple in its
response, let's do this filtering in HMP only.
Event message contains the net client name, management might only want
to query the
Tomoki Sekiyama tomoki.sekiy...@hds.com writes:
On 5/24/13 4:52 , Stefan Hajnoczi stefa...@gmail.com wrote:
On Thu, May 23, 2013 at 06:34:43PM +, Tomoki Sekiyama wrote:
On 5/23/13 8:12 , Stefan Hajnoczi stefa...@gmail.com wrote:
On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama
Anthony Liguori anth...@codemonkey.ws writes:
Gerd Hoffmann kra...@redhat.com writes:
On 05/29/13 01:53, Kevin O'Connor wrote:
On Thu, May 23, 2013 at 03:41:32PM +0300, Michael S. Tsirkin wrote:
Juan is not available now, and Anthony asked for
agenda to be sent early.
So here comes:
Stefan Hajnoczi stefa...@redhat.com writes:
If the user fails to specify 'chardev' or 'shm' then we cannot continue.
Exit right away so that we don't invoke shm_open(3) with a NULL pointer.
It would be nice to replace exit(1) with error returns in the PCI device
.init() function, but leave
Paolo Bonzini pbonz...@redhat.com writes:
The copied code comes from vhost_scsi_start. Spotted by Coverity.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Same as Stefan's [PATCH 1/3] vhost-scsi: fix k-set_guest_notifiers()
NULL dereference
Paolo Bonzini pbonz...@redhat.com writes:
The variable is not written anymore.
This cleans up after 9e1c2ec (which accidentally left variable
pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and
buries dead code from commit dafb82e (which looks like it got confused
by
Jordan Justen jljus...@gmail.com writes:
On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini pbonz...@redhat.com wrote:
The variable is not written anymore.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/block/pc_sysfw.c | 26 +-
1 file changed, 1 insertion(+),
for qapi-schema.json
MAINTAINERS: split Monitor (QMP/HMP) entry
MAINTAINERS | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
Acked-by: Markus Armbruster arm...@redhat.com
Stefan Hajnoczi stefa...@redhat.com writes:
Paolo Bonzini pbonz...@redhat.com suggested the following test case:
1. Launch a guest and wait at the GRUB boot menu:
qemu-system-x86_64 -enable-kvm -m 1024 \
-drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop
-device
Paolo Bonzini pbonz...@redhat.com writes:
Il 04/06/2013 18:37, Markus Armbruster ha scritto:
I figure the bit that can't be resolved now is letting the user switch
off stop on error safely before a drive_del. Even if we had a command
for that, there'd still be a window between that command's
Eric Blake ebl...@redhat.com writes:
On 06/04/2013 01:24 PM, Markus Armbruster wrote:
Paolo Bonzini pbonz...@redhat.com writes:
Il 04/06/2013 18:37, Markus Armbruster ha scritto:
I figure the bit that can't be resolved now is letting the user switch
off stop on error safely before
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 3 ++-
hw/nvram/fw_cfg.c | 2 +-
include/sysemu/sysemu.h | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 5d71870..aa24660 100644
--- a/arch_init.c
+++ b
stdio.h has always been missing. Rest missed in commit eeacee4.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
include/qemu/log.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qemu/log.h b/include/qemu/log.h
index 6b0db02..fd76f91 100644
--- a/include/qemu/log.h
+++ b
Better error messages, a bit of code cleanup, and a big endian fix.
Not addressed: qemu_uuid_parse() sets an SMBIOS field by side effect.
Gross!
Markus Armbruster (7):
error-report.h: Supply missing include
log.h: Supply missing includes
smbios: Convert to error_report()
Use sizeof
Missed in commit e5924d8.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
include/qemu/error-report.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h
index c902cc1..14c1719 100644
--- a/include/qemu/error-report.h
+++ b/include
Improves diagnistics from ad hoc messages like
Invalid SMBIOS UUID string
to
qemu-system-x86_64: -smbios type=1,uuid=gaga: Invalid UUID
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 1 -
hw/i386/smbios.c | 24
2 files changed, 12
Classic endianness bug due to careless dirty coding: assuming reading
a byte from an int variable gets the least significant byte.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/i386/smbios.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/smbios.c b/hw
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/i386/smbios.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 68bd6d0..88a1360 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -140,7 +140,10 @@ static void
Having size preceed the associated pointer is odd. Swap them, and fix
up the types.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 2 +-
hw/i386/smbios.c | 26 ++
include/hw/i386/smbios.h | 2 +-
3 files changed, 16 insertions
Laszlo Ersek ler...@redhat.com writes:
On 06/06/13 18:27, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 3 ++-
hw/nvram/fw_cfg.c | 2 +-
include/sysemu/sysemu.h | 2 +-
3 files changed, 4 insertions(+), 3 deletions
Laszlo Ersek ler...@redhat.com writes:
On 06/06/13 18:27, Markus Armbruster wrote:
Having size preceed the associated pointer is odd. Swap them, and fix
up the types.
Can you proceed to fix the spelling of precede? :)
Sure.
Laszlo Ersek ler...@redhat.com writes:
On 06/06/13 18:27, Markus Armbruster wrote:
Classic endianness bug due to careless dirty coding: assuming reading
a byte from an int variable gets the least significant byte.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/i386/smbios.c
Laszlo Ersek ler...@redhat.com writes:
On 06/06/13 18:27, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/i386/smbios.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 68bd6d0..88a1360
Broken since they got added in commit 97bf485.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/misc/slavio_misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/slavio_misc.c b/hw/misc/slavio_misc.c
index a7a9368..3571850 100644
--- a/hw/misc/slavio_misc.c
Markus Armbruster (5):
cleanup-trace-events.pl: New
slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints
milkymist-minimac2: Fix minimac2_read/_write tracepoints
trace-events: Drop unused events
trace-events: Fix up source file comments
hw/misc/slavio_misc.c | 2 +-
hw
xen_unmap_block 6506e4f
qemu_spice_start67be672
qemu_spice_stop 67be672
Signed-off-by: Markus Armbruster arm...@redhat.com
---
trace-events | 14 --
1 file changed, 14 deletions(-)
diff --git a/trace-events b/trace
Broken in milkymist-minimac.c from the start (commit 0742454),
faithfully moved to milkymist-minimac2.c (commit 57aa265).
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/net/milkymist-minimac2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/milkymist
They're all wrong since (at least) Paolo's big source tree
reorganization. Need to shuffle some event declarations around to
keep them under the correct source file comment.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
trace-events | 162
Simple script to drop unused events and fix up source file comments.
The next few commits put it to use.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
Feel free to ignore this one, rewrite it in Python, frame it to hang
in your bathroom, print it on tissue paper for that other bathroom
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
This patch simply remove variable may be used uninitialized warning.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of
initialize mhHeader.
libcacard/vscclient.c
stdio.h has always been missing. Rest missed in commit eeacee4.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
include/qemu/log.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qemu/log.h b/include/qemu/log.h
index 6b0db02..fd76f91 100644
--- a/include/qemu/log.h
+++ b
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/i386/smbios.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 6431dd4..e708cb8 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -140,7 +140,10 @@ static void
Missed in commit e5924d8.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
include/qemu/error-report.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h
index c902cc1..14c1719 100644
--- a/include/qemu/error-report.h
+++ b/include
Classic endianness bug due to careless dirty coding: assuming reading
a byte from an int variable gets the least significant byte.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/i386/smbios.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/smbios.c b/hw
, stdout, SMBIOS, smbios_entries_len);
into smbios_get_table()
v2: Address Hawkeye Laszlo's review
* 1-3/7 unchanged
* Drop 4/7 because it's buggy, and the fixed version isn't worthwhile
* Spelling fix in commit message of 5/7
* Correct scanf format in 5-6/7
Markus Armbruster (6):
error-report.h
Having size precede the associated pointer is odd. Swap them, and fix
up the types.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 2 +-
hw/i386/smbios.c | 26 ++
include/hw/i386/smbios.h | 2 +-
3 files changed, 16 insertions
Improves diagnistics from ad hoc messages like
Invalid SMBIOS UUID string
to
qemu-system-x86_64: -smbios type=1,uuid=gaga: Invalid UUID
Signed-off-by: Markus Armbruster arm...@redhat.com
---
arch_init.c | 1 -
hw/i386/smbios.c | 24
2 files changed, 12
Andreas Färber afaer...@suse.de writes:
Use new qemu_for_each_cpu().
Signed-off-by: Andreas Färber afaer...@suse.de
---
monitor.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index 9be515c..f37bf3d 100644
---
Andreas Färber afaer...@suse.de writes:
Am 10.06.2013 09:20, schrieb Markus Armbruster:
Andreas Färber afaer...@suse.de writes:
Use new qemu_for_each_cpu().
Signed-off-by: Andreas Färber afaer...@suse.de
---
monitor.c | 27 +++
1 file changed, 19 insertions
':
exec.c:1283:21: error:
comparison of distinct pointer types lacks a cast [-Werror]
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: Markus Armbruster arm...@redhat.com
Stefan Weil s...@weilnetz.de writes:
Am 31.07.2013 15:11, schrieb Markus Armbruster:
All I wanted to do is exit(1) instead of abort() on guest memory
allocation failure [07/08]. But that lead me into a minor #ifdef bog,
and here's what I brought back. Enjoy!
Testing:
* Christian
Michael S. Tsirkin m...@redhat.com writes:
On Fri, Aug 16, 2013 at 03:18:29PM +0200, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
So that it can be set in config file for -readconfig.
This tightens parsing of -smbios, and makes it more consistent with
other options
Michael Tokarev m...@tls.msk.ru writes:
24.09.2013 11:43, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Commit 4f193e3 added the test, but screwed up in-tree builds
(SRCDIR=.): the tests's output overwrites the expected output, and is
thus compared to itself
Michael S. Tsirkin m...@redhat.com writes:
On Fri, Sep 27, 2013 at 07:06:44PM +0200, Markus Armbruster wrote:
Marcel Apfelbaum marcel.apfelb...@gmail.com writes:
On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin wrote:
On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote
Stefan Weil s...@weilnetz.de writes:
Am 29.09.2013 22:13, schrieb Michael Tokarev:
29.09.2013 19:41, Stefan Weil wrote:
The QEMU buildbot default_i386_debian_6_0 shows this warning:
CCmigration.o
migration.c: In function 'qmp_query_migrate_capabilities':
migration.c:149: warning:
Peter Maydell peter.mayd...@linaro.org writes:
On 30 September 2013 23:40, Michael S. Tsirkin m...@redhat.com wrote:
diff --git a/include/qapi/error.h b/include/qapi/error.h
index 7d4c696..b85e996 100644
--- a/include/qapi/error.h
+++ b/include/qapi/error.h
@@ -13,14 +13,15 @@
#define
Andreas Färber afaer...@suse.de writes:
Am 30.09.2013 17:50, schrieb Michael S. Tsirkin:
On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote:
On 30 September 2013 23:40, Michael S. Tsirkin m...@redhat.com wrote:
diff --git a/include/qapi/error.h b/include/qapi/error.h
index
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Sep 30, 2013 at 05:49:26PM +0200, Markus Armbruster wrote:
Peter Maydell peter.mayd...@linaro.org writes:
On 30 September 2013 23:40, Michael S. Tsirkin m...@redhat.com wrote:
diff --git a/include/qapi/error.h b/include/qapi/error.h
Stefan Weil s...@weilnetz.de writes:
Am 30.09.2013 11:59, schrieb Markus Armbruster:
Stefan Weil s...@weilnetz.de writes:
Am 29.09.2013 22:13, schrieb Michael Tokarev:
29.09.2013 19:41, Stefan Weil wrote:
The QEMU buildbot default_i386_debian_6_0 shows this warning:
CCmigration.o
SysBusDevice.
* Fixed typo in PXA2xx API.
* QOM'ified PXA2xx PCMCIA controller.
From Markus' IDE series:
* Instead of breaking ide_init2_with_non_qdev_drives(), dropped it after
converting last remaining pre-qdev IDE device.
Cc: Markus Armbruster arm...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Andreas Färber afaer...@suse.de writes:
Am 01.10.2013 11:15, schrieb Markus Armbruster:
Has this one fallen through the cracks?
Nobody, including yourself, has felt responsable for reviewing this, and
QOMification isn't exactly my home turf...
I wanted to get some form of test coverage
We have
-mem-path FILE provide backing storage for guest RAM
-mem-prealloc preallocate guest memory (use with -mem-path)
PATCH 2/2 adds
-mem-path-forcefail if unable to allocate RAM as specified by -mem-path
Looks like it's time to consolidate the options related to guest
Marcelo Tosatti mtosa...@redhat.com writes:
On Tue, Oct 08, 2013 at 10:02:26AM +0200, Paolo Bonzini wrote:
Il 08/10/2013 09:32, Markus Armbruster ha scritto:
We have
-mem-path FILE provide backing storage for guest RAM
-mem-prealloc preallocate guest memory (use with -mem
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/10/2013 18:01, Paolo Bonzini ha scritto:
Il 10/10/2013 16:42, arm...@redhat.com ha scritto:
From: Markus Armbruster arm...@redhat.com
An ICH9 southbridge contains several PCI devices, some of them with
multiple functions. We model each
Cole Robinson crobi...@redhat.com writes:
Using multiple calls to error_report here means every line is
prefaced with the (potentially long) pci-assign command line
arguments. Use a single error_report to preserve the intended
formatting.
The orthodox way to do this is to use error_report()
qemu.org fixed, and that's the imperfect part, but it also doesn't make
fixing qemu.org any harder. We can always switch back.
Reviewed-by: Markus Armbruster arm...@redhat.com
Marcel Apfelbaum marce...@redhat.com writes:
On Thu, 2013-10-10 at 15:00 +0200, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5.
The commit claims to sort the output of -device help by
functionality
Kevin Wolf kw...@redhat.com writes:
Am 10.10.2013 um 15:44 hat Max Reitz geschrieben:
Make use of the error parameter in the opening and creating functions in
block/raw-posix.c.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/raw-posix.c | 60
by an error_report call,
we don't lose the command line reporting.
Signed-off-by: Cole Robinson crobi...@redhat.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Mike Qiu qiud...@linux.vnet.ibm.com writes:
Without this, output of 'info block'
scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2)
[not inserted]
scsi0-cd2: [not inserted]
Removable device: not locked, tray closed
floppy0: [not inserted]
Removable device: not locked, tray closed
sd0:
Michael S. Tsirkin m...@redhat.com writes:
/scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type
[-Werror]
static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc;
^
/scm/qemu/exec.c: In function
Eduardo Habkost ehabk...@redhat.com writes:
This makes the code more readable, making each condition that makes a
field be skipped much more visible, and reduces one level of indentation
in the code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 156
Kevin Wolf kw...@redhat.com writes:
Am 15.10.2013 um 05:38 hat mike geschrieben:
On 10/14/2013 10:36 PM, Markus Armbruster wrote:
Mike Qiu qiud...@linux.vnet.ibm.com writes:
Without this, output of 'info block'
scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2)
[not inserted]
scsi0-cd2
Andreas,
To go beyond RFC with this series, I need to explain why TYPE_CPU
cannot_instantiate_with_device_add_yet. Would you be so kind and help
me out with a suitable comment?
You can find examples in PATCH 2-7/9.
Paolo, or maybe Andreas,
To go beyond RFC with this series, I need to explain why isa-i8259 and
kvm-i8259 cannot_instantiate_with_device_add_yet, or drop that. I'd
appreciate your help.
Both are derived from TYPE_PIC_COMMON, which is derived from
TYPE_ISA_DEVICE.
I figure isa-i8259
Andreas,
To go beyond RFC with this series, I need to explain why the IDE
controller functions of southbridges piix3-ide, piix3-ide-xen, piix4-ide
and via-ide cannot_instantiate_with_device_add_yet, or drop that. I'd
appreciate your help.
Our modelling of PCI devices is weird, to put it
Peter Maydell peter.mayd...@linaro.org writes:
On 15 October 2013 13:24, Markus Armbruster arm...@redhat.com wrote:
To go beyond RFC with this series, I need to explain why TYPE_CPU
cannot_instantiate_with_device_add_yet.
...isn't this just because it's an abstract type?
Abstract types have
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
于 2013/10/15 18:07, mike 写道:
On 10/15/2013 04:58 PM, Kevin Wolf wrote:
Am 15.10.2013 um 05:38 hat mike geschrieben:
On 10/14/2013 10:36 PM, Markus Armbruster wrote:
Mike Qiu qiud...@linux.vnet.ibm.com writes:
Without this, output of 'info
Paolo Bonzini pbonz...@redhat.com writes:
Il 15/10/2013 14:43, Markus Armbruster ha scritto:
Paolo, or maybe Andreas,
To go beyond RFC with this series, I need to explain why isa-i8259 and
kvm-i8259 cannot_instantiate_with_device_add_yet, or drop that. I'd
appreciate your help.
Both
Andreas Färber afaer...@suse.de writes:
Hi Markus,
Am 15.10.2013 14:24, schrieb Markus Armbruster:
To go beyond RFC with this series, I need to explain why TYPE_CPU
cannot_instantiate_with_device_add_yet. Would you be so kind and help
me out with a suitable comment?
From what I remember
Andreas Färber afaer...@suse.de writes:
Am 15.10.2013 16:41, schrieb Kevin Wolf:
having two IDE controllers using the same I/O ports won't work,
obviously. So if you would allow -device or device-add for them, you'd
need options to configure the ports at least.
Or a new
Anthony Liguori anth...@codemonkey.ws writes:
On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf kw...@redhat.com wrote:
Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben:
Am 15.10.2013 15:21, schrieb Markus Armbruster:
Andreas,
To go beyond RFC with this series, I need to explain why
Ian Campbell ian.campb...@citrix.com writes:
On Wed, 2013-10-16 at 10:54 +0100, Jan Beulich wrote:
On 16.10.13 at 08:30, Gonglei (Arei) arei.gong...@huawei.com wrote:
--- hvmloader/acpi/Makefile2013-10-16 11:51:53.0 +0800
+++ hvmloader_new//acpi/Makefile 2013-10-16
Ian Campbell ian.campb...@citrix.com writes:
On Wed, 2013-10-16 at 12:49 +0200, Markus Armbruster wrote:
Ian Campbell ian.campb...@citrix.com writes:
On Wed, 2013-10-16 at 10:54 +0100, Jan Beulich wrote:
On 16.10.13 at 08:30, Gonglei (Arei) arei.gong...@huawei.com
wrote
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/10/2013 11:51, Markus Armbruster ha scritto:
Let me try to elaborate, to make sure I understand.
Unlike ordinary ISA devices, the i8259 devices need additional wiring,
done by code.
For instance, board code like pc_q35_init(), pc_piix.c's
Andreas Färber afaer...@suse.de writes:
Am 16.10.2013 12:00, schrieb Markus Armbruster:
Anthony Liguori anth...@codemonkey.ws writes:
On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf kw...@redhat.com wrote:
Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben:
Am 15.10.2013 15:21, schrieb
Anthony Liguori anth...@codemonkey.ws writes:
On Wed, Oct 16, 2013 at 3:00 AM, Markus Armbruster arm...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws writes:
On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf kw...@redhat.com wrote:
Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben
-test.c
@@ -0,0 +1,129 @@
+/*
+ * Boot order test cases.
+ *
+ * Copyright (c) 2013 Red Hat Inc.
+ *
+ * Authors:
+ * Markus Armbruster arm...@redhat.com,
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory
Paolo Bonzini pbonz...@redhat.com writes:
Il 18/10/2013 03:11, Wenchao Xia ha scritto:
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
include/qapi/error.h |5 -
qobject/qerror.c |7 ---
util/error.c |6 --
3 files changed, 4 insertions(+), 14
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
monitor_vprintf() is called in the code path, and it will not print
when monitor is in qmp mode, so checking monitor mode in
error_printf_unless_qmp() is useless, remove it to simplify the code.
Suggest to reword:
error_printf_unless_qmp() is no
Paolo Bonzini pbonz...@redhat.com writes:
Il 18/10/2013 07:30, Markus Armbruster ha scritto:
+static void test_acpi_tcg(void)
+{
+test_acpi_one(-machine accel=tcg);
+}
Since qtest_init() adds your parameters at the end, this should result
in a command line ending with -machine
Paolo Bonzini pbonz...@redhat.com writes:
Il 18/10/2013 03:11, Wenchao Xia ha scritto:
The behavior to set sep brings trouble to modification later,
the logic is not changed by add tailing space in fprintf().
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
util/qemu-error.c |
Peter Maydell peter.mayd...@linaro.org writes:
On 17 October 2013 14:54, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
device_add plugs devices into suitable bus. For real buses, that
actually connects the device. For sysbus, the connections need to be
made
Peter Maydell peter.mayd...@linaro.org writes:
On 17 October 2013 14:55, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Drop it when there's no obvious reason why device_add could not work.
Else keep and document why.
* isa-fdc, port92, i8042, m48t59_isa, mc146818rtc
Peter Maydell peter.mayd...@linaro.org writes:
On 17 October 2013 14:54, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Many PCI host bridges consist of a sysbus device and a PCI device.
You need both for the thing to work. Arguably, these bridges should
be modelled
Peter Maydell peter.mayd...@linaro.org writes:
On 17 October 2013 14:54, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
In an ideal world, machines can be built by wiring devices together
with configuration, not code. Unfortunately, that's not the world we
live
sun4m.c and sun4u.c both define a qdev named TYPE_OPENPROM. As far as I
can tell, they differ only in the name of their memory region.
If they ever get linked into the same executable,
type_register_internal() will reject the second one. But they aren't,
so this isn't a bug. Is it bad style?
Ping!
Hu Tao hu...@cn.fujitsu.com writes:
Hi All,
I know it's been a long time since this thread. But qemu 1.7 is
releasing, do you have any consensus on this?
Thanks.
Eric Blake ebl...@redhat.com writes:
On 10/29/2013 10:08 AM, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
A PIIX3/PIIX4 southbridge has multiple functions. We model each
function as a separate qdev. Two of them need some special wiring set
up in pc_init1
Marcel Apfelbaum marce...@redhat.com writes:
On Tue, 2013-10-29 at 17:08 +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Such devices have always been unavailable and omitted from the list of
available devices shown by device_add help. Until commit 18b6dad
Marcel Apfelbaum marce...@redhat.com writes:
On Tue, 2013-10-29 at 17:08 +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
In an ideal world, machines can be built by wiring devices together
with configuration, not code. Unfortunately, that's not the world we
live
Marcel Apfelbaum marce...@redhat.com writes:
On Tue, 2013-10-29 at 17:08 +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Many PCI host bridges consist of a sysbus device and a PCI device.
You need both for the thing to work. Arguably, these bridges should
[Note cc: Eric Luiz, because this also relates to QMP]
Benoît Canet benoit.ca...@irqsave.net writes:
Hi list,
After a discussion on irc we have two potential solution in order to introduce
a new bs-node_name member in order to be able to manipulate the graph from
the
monitors.
The
Andreas Färber afaer...@suse.de writes:
Am 30.10.2013 13:30, schrieb Markus Armbruster:
Marcel Apfelbaum marce...@redhat.com writes:
On Tue, 2013-10-29 at 17:08 +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Many PCI host bridges consist of a sysbus device
Marcel Apfelbaum marce...@redhat.com writes:
On Wed, 2013-10-30 at 13:15 +0100, Markus Armbruster wrote:
Marcel Apfelbaum marce...@redhat.com writes:
On Tue, 2013-10-29 at 17:08 +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Such devices have always been
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 30, 2013 at 01:56:40PM +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs,
no version. Best SeaBIOS can do, but we can provide better defaults
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 30, 2013 at 12:29:16PM -0200, Eduardo Habkost wrote:
On Wed, Oct 30, 2013 at 04:18:16PM +0200, Michael S. Tsirkin wrote:
On Wed, Oct 30, 2013 at 01:56:40PM +0100, arm...@redhat.com wrote:
From: Markus Armbruster arm...@redhat.com
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 30, 2013 at 04:18:37PM +0100, Markus Armbruster wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Oct 30, 2013 at 12:29:16PM -0200, Eduardo Habkost wrote:
On Wed, Oct 30, 2013 at 04:18:16PM +0200, Michael S. Tsirkin wrote
1 - 100 of 27531 matches
Mail list logo
