Re: [Qemu-devel] [PATCH v3 2/2] smbios: Set system manufacturer, product version by default

2013-10-30 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 30, 2013 at 09:22:38PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 30, 2013 at 04:18:37PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 30, 2013

[Qemu-devel] [PATCH v3 3/2] smbios: Decouple system product from QEMUMachine

2013-10-30 Thread Markus Armbruster
Michael Tsirkin doesn't trust us to keep values of QEMUMachine member product stable in the future. Use copies instead, and in a way that makes it obvious that they're guest ABI. Note that we can be trusted to keep values of member name, because that has always been ABI. Signed-off-by: Markus

Re: [Qemu-devel] [PATCH v3 2/2] smbios: Set system manufacturer, product version by default

2013-10-30 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 30, 2013 at 01:56:40PM +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, no version. Best SeaBIOS can do, but we can provide better defaults

Re: [Qemu-devel] [PATCH v3 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-31 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com A PIIX3/PIIX4 southbridge has multiple functions. We model each function as a separate qdev. Two of them need some special wiring set up

Re: [Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes cleanup

2013-09-11 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Series has been on list for more than 8 weeks (not counting the initial PATCH RFC), and rebased twice. Right now, it still applies. Please either merge or tell me what I need to do to get it merged. Thanks! Twelve weeks now. Markus Armbruster

Re: [Qemu-devel] [PATCH] qdev-monitor: Avoid exiting when hot-plugging two devices with the same bootindex value

2013-09-12 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 11/09/2013 20:26, Marcel Apfelbaum ha scritto: Qemu is expected to quit if the same boot index value is used by two devices. However, hot-plugging a device with a bootindex value already used should fail with a friendly message rather than quitting

Re: [Qemu-devel] [PATCH] qdev-monitor: Avoid exiting when hot-plugging two devices with the same bootindex value

2013-09-12 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Thu, 2013-09-12 at 11:43 +0200, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 11/09/2013 20:26, Marcel Apfelbaum ha scritto: Qemu is expected to quit if the same boot index value is used by two devices. However

Re: [Qemu-devel] [RFC PATCH 0/8] Remove stub mon-protocol-event for block

2013-09-12 Thread Markus Armbruster
[Note cc: Luiz] Paolo Bonzini pbonz...@redhat.com writes: Il 12/09/2013 11:15, Wenchao Xia ha scritto: This series will remove the usage of symbols of mon-protocol-event in qemu-img, qemu-nbd and qemu-io, in short remove the connetion for block layer. Background: I am tring to decouple

Re: [Qemu-devel] [PATCH] chardev: handle qmp_chardev_add(KIND_MUX) failure

2013-09-13 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Cc: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH] exec: Fix broken build for MinGW (regression)

2013-09-18 Thread Markus Armbruster
it in qemu_ram_remap() is under #ifndef _WIN32, and your patch matches that. Makes sense. Thanks for cleaning up after me ;) Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup nicer defaults for type 1

2013-09-18 Thread Markus Armbruster
[Note cc: Andreas] Michael S. Tsirkin m...@redhat.com writes: On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side

Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-20 Thread Markus Armbruster
Jeff Cody jc...@redhat.com writes: On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote: On 09/19/2013 11:43 AM, Jeff Cody wrote: cow_header_v2 is read and written directly from the image file with bdrv_pread()/bdrv_pwrite(), and as such should be packed to avoid

Re: [Qemu-devel] KVM Guest keymap issue

2013-09-24 Thread Markus Armbruster
Not specific to KVM, adding qemu-devel. Matej Mailing mail...@tam.si writes: Dear list, I have a problem with a Windows XP guest that I connect to via VNC and is using sl keymap (option -k sl). The guest is Windows XP and the problematic characters are s, c and z with caron... when I type

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Sep 25, 2013 at 10:14:49AM +, Zhanghaoyu (A) wrote: Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-26 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Sep 25, 2013 at 01:39:48PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Sep 25, 2013 at 10:14:49AM +, Zhanghaoyu (A) wrote: Hi, all Do live migration if emulated NIC's MAC has been

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-27 Thread Markus Armbruster
-plug) - consider plug type + compliance to figure out whether a plug can go into a socket 2. Use Markus Armbruster idea of introducing a concept of plug and sockets: - dividing the devices into adapters and plugs - adding sockets to bridges(buses?). In this way it would

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-23 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 22.07.2013 23:03, schrieb Seiji Aguchi: Convert stderr messages calling error_get_pretty() to error_report(). Timestamp is prepended by -msg timstamp option with it. This is suggested by Luiz Capitulino.

[Qemu-devel] [PATCH 4/9] qapi.py: Decent syntax error reporting

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 29 +++-- tests/qapi-schema/test-qapi.py| 2 ++ tests/qapi-schema/unclosed-string.err | 2 +- 3 files changed, 30 insertions(+), 3 deletions(-) diff --git a/scripts

[Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it

2013-07-26 Thread Markus Armbruster
If you think I'm exaggerating, check out the list of issues in PATCH 3/9. Markus Armbruster (9): tests: QAPI schema parser tests tests: Use qapi-schema-test.json as schema parser test qapi.py: Restructure lexer and parser qapi.py: Decent syntax error reporting qapi.py: Reject invalid

[Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests

2013-07-26 Thread Markus Armbruster
The parser handles erroneous input badly. To be improved shortly. Signed-off-by: Markus Armbruster arm...@redhat.com --- configure | 2 +- tests/Makefile | 22 -- tests/qapi-schema/empty.exit

[Qemu-devel] [PATCH 7/9] qapi.py: Fix diagnosing non-objects at a schema's top-level

2013-07-26 Thread Markus Armbruster
Report syntax error instead of crashing. Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 10 ++ tests/qapi-schema/non-objects.err | 2 +- tests/qapi-schema/quoted-structural-chars.err | 2 +- 3 files changed, 8

[Qemu-devel] [PATCH 6/9] qapi.py: Fix schema parser to check syntax systematically

2013-07-26 Thread Markus Armbruster
Fixes at least the following parser bugs: * accepts any token in place of a colon * treats comma as optional * crashes when closing braces or brackets are missing Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 40

[Qemu-devel] [PATCH 5/9] qapi.py: Reject invalid characters in schema file

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 2 ++ tests/qapi-schema/funny-char.err | 1 + tests/qapi-schema/funny-char.exit | 2 +- tests/qapi-schema/funny-char.out | 3 --- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts

[Qemu-devel] [PATCH 8/9] qapi.py: Rename expr_eval to expr in parse_schema()

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 5677daa..1d856c9 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -153,14 +153,14 @@ def

[Qemu-devel] [PATCH 9/9] qapi.py: Permit comments starting anywhere on the line

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 1d856c9..da46fb9 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -53,13 +53,12 @@ class QAPISchema

[Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qapi-schema-test.json | 53 - tests/Makefile | 8 ++--- tests/qapi-schema/qapi-schema-test.exit | 1 + tests/qapi-schema/qapi-schema-test.json | 53

[Qemu-devel] [PATCH 3/9] qapi.py: Restructure lexer and parser

2013-07-26 Thread Markus Armbruster
a section's expression isn't a JSON object. Replace this piece of original art by a thoroughly unoriginal design. Takes care of (1), (2), (5), (6) and (7), and lays the groundwork for addressing the others. Generated source files remain unchanged. Signed-off-by: Markus Armbruster arm

Re: [Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests

2013-07-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 07/26/2013 06:39 AM, Markus Armbruster wrote: The parser handles erroneous input badly. To be improved shortly. Signed-off-by: Markus Armbruster arm...@redhat.com --- Lots of proof on how bad it is! I'd also like to see a couple tests on trailing

[Qemu-devel] [PATCH v2 3/3] qapi: Rename ChardevBackend member memory to ringbuf

2013-07-26 Thread Markus Armbruster
Commit 1da48c6 called the new member memory after commit 3949e59 standardized ringbuf. Rename for consistency. However, member name memory is visible in QMP since 1.5. It's undocumented just like the driver name. Keep it working anyway. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus

[Qemu-devel] [PATCH v2 0/3] qemu-char: ringbuf fixes

2013-07-26 Thread Markus Armbruster
. You might want to apply this after my Our QAPI parser is a hack, replace it series, so the indented comment in PATCH 3/3 works by design rather than accident. v2: Trivially rebased Markus Armbruster (3): Revert chardev: Make the name of memory device consistent qemu-char: Register ring buffer

[Qemu-devel] [PATCH v2 1/3] Revert chardev: Make the name of memory device consistent

2013-07-26 Thread Markus Armbruster
in RAM, flash, or carved into chocolate tablets by Oompa Loompas. Revert the commit. Next commit will fix just the bug. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com --- qapi-schema.json | 6 +++--- qemu-char.c | 16 qemu-options.hx | 6

[Qemu-devel] [PATCH v2 2/3] qemu-char: Register ring buffer driver with correct name ringbuf

2013-07-26 Thread Markus Armbruster
-by: Markus Armbruster arm...@redhat.com --- qemu-char.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index bd1aefb..742b73b 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3774,7 +3774,7 @@ static void register_types(void

Re: [Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it

2013-07-26 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: Markus Armbruster arm...@redhat.com writes: If you think I'm exaggerating, check out the list of issues in PATCH 3/9. You are not. However, I think we can drop the whole thing and just use the JSON module in Python. The bit below seems to work

Re: [Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests

2013-07-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 07/26/2013 08:16 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 07/26/2013 06:39 AM, Markus Armbruster wrote: The parser handles erroneous input badly. To be improved shortly. Signed-off-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH 4/9] qapi.py: Decent syntax error reporting

2013-07-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 07/26/2013 06:39 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 29 +++-- tests/qapi-schema/test-qapi.py| 2 ++ tests/qapi-schema/unclosed

Re: [Qemu-devel] [PATCH 6/9] qapi.py: Fix schema parser to check syntax systematically

2013-07-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 07/26/2013 06:39 AM, Markus Armbruster wrote: Fixes at least the following parser bugs: * accepts any token in place of a colon * treats comma as optional * crashes when closing braces or brackets are missing Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it

2013-07-26 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: Markus Armbruster arm...@redhat.com writes: Anthony Liguori aligu...@us.ibm.com writes: Markus Armbruster arm...@redhat.com writes: If you think I'm exaggerating, check out the list of issues in PATCH 3/9. You are not. However, I think we

Re: [Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test

2013-07-27 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 07/26/2013 06:39 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- qapi-schema-test.json | 53 - tests/Makefile | 8 ++--- tests/qapi-schema/qapi-schema

[Qemu-devel] [PATCH v2 7/9] qapi.py: Fix diagnosing non-objects at a schema's top-level

2013-07-27 Thread Markus Armbruster
Report syntax error instead of crashing. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 10 ++ tests/qapi-schema/non-objects.err | 2 +- tests/qapi-schema/quoted-structural

[Qemu-devel] [PATCH v2 8/9] qapi.py: Rename expr_eval to expr in parse_schema()

2013-07-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 75fc282..f64b7b2 100644 --- a/scripts/qapi.py +++ b

[Qemu-devel] [PATCH v2 3/9] qapi.py: Restructure lexer and parser

2013-07-27 Thread Markus Armbruster
a section's expression isn't a JSON object. Replace this piece of original art by a thoroughly unoriginal design. Takes care of (1), (2), (5), (6) and (7), and lays the groundwork for addressing the others. Generated source files remain unchanged. Signed-off-by: Markus Armbruster arm

[Qemu-devel] [PATCH v2 9/9] qapi.py: Permit comments starting anywhere on the line

2013-07-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 3 +-- tests/qapi-schema/comments.err | 1 - tests/qapi-schema/comments.exit | 2 +- tests/qapi-schema/comments.out | 3 +++ 4 files changed, 5 insertions(+), 4

[Qemu-devel] [PATCH v2 2/9] tests: Use qapi-schema-test.json as schema parser test

2013-07-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- tests/Makefile| 8 tests/qapi-schema/qapi-schema-test.exit | 1 + .../qapi-schema/qapi-schema-test.json | 0 tests

[Qemu-devel] [PATCH v2 5/9] qapi.py: Reject invalid characters in schema file

2013-07-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 2 ++ tests/qapi-schema/comments.err| 1 + tests/qapi-schema/comments.exit | 2 +- tests/qapi-schema/comments.out| 3 --- tests/qapi-schema/funny-char.err

[Qemu-devel] [PATCH v2 0/9] Our QAPI parser is a hack, replace it

2013-07-27 Thread Markus Armbruster
If you think I'm exaggerating, check out the list of issues in PATCH 3/9. v2: * Straightforward rebase * A few more tests in 1/9, in part suggested by Eric Markus Armbruster (9): tests: QAPI schema parser tests tests: Use qapi-schema-test.json as schema parser test qapi.py: Restructure

[Qemu-devel] [PATCH v2 1/9] tests: QAPI schema parser tests

2013-07-27 Thread Markus Armbruster
The parser handles erroneous input badly. To be improved shortly. Signed-off-by: Markus Armbruster arm...@redhat.com --- configure | 2 +- tests/Makefile | 24 ++-- tests/qapi-schema/comments.exit

[Qemu-devel] [PATCH v2 6/9] qapi.py: Fix schema parser to check syntax systematically

2013-07-27 Thread Markus Armbruster
Fixes at least the following parser bugs: * accepts any token in place of a colon * treats comma as optional * crashes when closing braces or brackets are missing Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py

[Qemu-devel] [PATCH v2 4/9] qapi.py: Decent syntax error reporting

2013-07-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 29 +++-- tests/qapi-schema/test-qapi.py| 2 ++ tests/qapi-schema/unclosed-string.err | 2 +- 3 files changed, 30 insertions

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-29 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 23/07/2013 17:57, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 05:38:00PM +0200, Kevin Wolf wrote: Am 23.07.2013 um 17:22 hat Stefan Hajnoczi geschrieben: On Tue, Jul 23, 2013 at 04:40:34PM +0200, Benoît Canet wrote: More generally,

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-29 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Mon, 29 Jul 2013 23:23:32 +0200 Andreas Färber afaer...@suse.de wrote: Am 29.07.2013 23:20, schrieb Luiz Capitulino: On Mon, 22 Jul 2013 23:23:29 +0200 Andreas Färber afaer...@suse.de wrote: Am 22.07.2013 23:03, schrieb Seiji Aguchi:

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-29 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 19 Jul 2013 04:57:51 -0600 Eric Blake ebl...@redhat.com wrote: On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote: The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be

Re: [Qemu-devel] [PATCH 0/7] smbios cleanup nicer defaults for type 1

2013-07-30 Thread Markus Armbruster
Ping for 1.6 Markus Armbruster arm...@redhat.com writes: This gets rid of one of the last get_param_value() users, makes multiple -smbios work sanely, cleans up the gross side effect in qemu_uuid_parse(), and more. Topped off with a little feature in the last patch. Markus Armbruster (7

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-30 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On Mon, Jul 29, 2013 at 7:15 PM, Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 19 Jul 2013 04:57:51 -0600 Eric Blake ebl...@redhat.com wrote: On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote

Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

2013-07-30 Thread Markus Armbruster
Michal Novotny minov...@redhat.com writes: Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. Text

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-30 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On Tue, Jul 30, 2013 at 1:39 AM, Markus Armbruster arm...@redhat.com wrote: Anthony Liguori anth...@codemonkey.ws writes: This was part of the discussion way back when this all was first introduced. Since everything was open coded and we had

Re: [Qemu-devel] [PATCH v3 0/6] Clean up bogus default boot order

2013-07-30 Thread Markus Armbruster
Any chance for this to make 1.6? It first hit the list mid-June...

Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

2013-07-30 Thread Markus Armbruster
Michal Novotny minov...@redhat.com writes: Hi Markus, should I rebase it or no need and can maintainer do it before push? Depends on the maintainer :) I'd respin.

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Markus Armbruster
Michal Novotny minov...@redhat.com writes: Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Markus Armbruster
: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com In general, I very much prefer

Re: [Qemu-devel] [PATCH v2 0/8] Guest memory allocation fixes cleanup

2013-07-31 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Ping? Has been ignored for six weeks, and now it no longer applies. Rebased version coming. *Sigh*

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Markus Armbruster
Michal Novotny minov...@redhat.com writes: On 07/31/2013 08:45 AM, Markus Armbruster wrote: Michal Novotny minov...@redhat.com writes: Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you

[Qemu-devel] [PATCH v3 for 1.6 1/8] exec: Fix Xen RAM allocation with unusual options

2013-07-31 Thread Markus Armbruster
Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index c4f2894..5b1be92 100644 --- a/exec.c +++ b/exec.c @@ -1119,6 +1119,12

[Qemu-devel] [PATCH v3 for 1.6 5/8] exec: Drop incorrect dead S390 code in qemu_ram_remap()

2013-07-31 Thread Markus Armbruster
, this can't happen, as we never remap on S390. Replace the incorrect code with an assertion. Thanks to Christian Borntraeger for help with assessing the bug's (non-)impact. Acked-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 13

[Qemu-devel] [PATCH v3 for 1.6 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-07-31 Thread Markus Armbruster
large pages in the host for KVM guests. Clean it up anyway. Thanks to Christian Borntraeger for pointing out the S390 kernel limitations. Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v3 for 1.6 2/8] exec: Clean up fall back when -mem-path allocation fails

2013-07-31 Thread Markus Armbruster
still works, but clean it up anyway: drop the special fall back allocation code, and fall back to the ordinary -mem-path not given code instead. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 7 ++- 1 file changed, 2 insertions

[Qemu-devel] [PATCH v3 for 1.6 4/8] exec: Simplify the guest physical memory allocation hook

2013-07-31 Thread Markus Armbruster
Make it a generic hook rather than a KVM hook. Less code and ifdeffery. Since the only user of the hook is old S390 KVM, there's hope we can get rid of it some day. Acked-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c

[Qemu-devel] [PATCH v3 for 1.6 7/8] exec: Don't abort when we can't allocate guest memory

2013-07-31 Thread Markus Armbruster
) instead, and do it in just one place, so the error message is consistent. Tested-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 5 + target-s390x/kvm.c | 6 +- util/oslib-posix.c | 4 +--- util/oslib-win32.c | 5

[Qemu-devel] [PATCH v3 for 1.6 8/8] pc_sysfw: Fix ISA BIOS init for ridiculously big flash

2013-07-31 Thread Markus Armbruster
pc_isa_bios_init() suffers integer overflow for flash larger than INT_MAX. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/block/pc_sysfw.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c index 7db68f0..74a5364 100644

[Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes cleanup

2013-07-31 Thread Markus Armbruster
by Richard Henderson and Peter Maydell Markus Armbruster (8): exec: Fix Xen RAM allocation with unusual options exec: Clean up fall back when -mem-path allocation fails exec: Reduce ifdeffery around -mem-path exec: Simplify the guest physical memory allocation hook exec: Drop incorrect dead S390

Re: [Qemu-devel] [PATCH] acl: acl_add can't insert before last list element, fix

2013-07-31 Thread Markus Armbruster
Ping re 1.5.3 Markus Armbruster arm...@redhat.com writes: Watch this: $ upstream-qemu -nodefaults -S -vnc :0,acl,sasl -monitor stdio QEMU 1.5.50 monitor - type 'help' for more information (qemu) acl_add vnc.username drei allow acl: added rule at position 1 (qemu

[Qemu-devel] [PATCH v3 for 1.6 3/8] exec: Reduce ifdeffery around -mem-path

2013-07-31 Thread Markus Armbruster
Instead of spreading its ifdeffery everywhere, confine it to qemu_ram_alloc_from_ptr(). Everywhere else, simply test block-fd, which is non-negative exactly when block uses -mem-path. Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 37

Re: [Qemu-devel] default slot used for vga device on q35 machines

2013-08-02 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Hi, qemu-kvm -M q35 -nodefaults -nodefconfig -qmp unix:/tmp/qemu,server -vnc :15 -vga std -usb Then ran query-pci in the qmp monitor and found that the vga device is put at slot 1 instead of slot 2. My questions: 1) Is this difference

[Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-02 Thread Markus Armbruster
possible (if unlikely) future misuse with assert(). Reported-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Markus Armbruster arm...@redhat.com --- util/qemu-option.c | 9 + 1 file changed, 9 insertions(+) diff --git a/util/qemu-option.c b/util/qemu-option.c index 7a1552a..4ebdc4c

Re: [Qemu-devel] default slot used for vga device on q35 machines

2013-08-02 Thread Markus Armbruster
Laine Stump la...@redhat.com writes: On 08/02/2013 03:23 AM, Markus Armbruster wrote: Gerd Hoffmann kra...@redhat.com writes: Hi, qemu-kvm -M q35 -nodefaults -nodefconfig -qmp unix:/tmp/qemu,server -vnc :15 -vga std -usb Then ran query-pci in the qmp monitor and found that the vga

Re: [Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-02 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 08/02/2013 01:34 AM, Markus Armbruster wrote: Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner case, but broke it for another one that can't be reached in current code. Not reachable, because we never pass lists with !list

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-08-06 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 26/07/2013 14:51, Igor Mammedov ha scritto: On Fri, 26 Jul 2013 11:26:16 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 26/07/2013 09:38, Igor Mammedov ha scritto: Perhaps denying memory add and suggesting node migration to a node with more

Re: [Qemu-devel] [PATCH] configure: disable clang -Wstring-plus-int warning

2013-08-06 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Some versions of clang will warn about adding integers to strings: disas/i386.c:4753:23: error: adding 'char' to a string does not append to the string [-Werror,-Wstring-plus-int] oappend (%es: + intel_syntax);

Re: [Qemu-devel] [PATCH qom-next for-next 0/5] QOM PCMCIA, MicroDrive and IDE cleanups

2013-08-06 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Hello, Based on an initial draft from Othmar Pasteka, this series QOM'ifies MicroDrive. As a prerequisite, PCMCIA must be QOM'ified as pointed out by Peter. We can then finally drop ide_init2_with_non_qdev_drives(), as desired by Markus for his

Re: [Qemu-devel] [PATCH for-1.6? v2 00/21] qtest: Test all targets

2013-08-06 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Hello Anthony/Aurélien, This series extends test coverage to all 16 targets. For now it tests that QOM type changes do not lead to QOM cast assertions. v2 extends it to cover virtually all machines (except Xen and pc*-x.y). Where an fprintf() is

Re: [Qemu-devel] [PATCH for-1.6? v2 00/21] qtest: Test all targets

2013-08-06 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 06.08.2013 10:39, schrieb Markus Armbruster: Andreas Färber afaer...@suse.de writes: Hello Anthony/Aurélien, This series extends test coverage to all 16 targets. For now it tests that QOM type changes do not lead to QOM cast assertions. v2

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 06.08.2013 10:36, schrieb Gleb Natapov: On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: If you see a mouse in a room, how likely is it that there's a single mouse

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Tue, Aug 06, 2013 at 01:03:34PM +0200, Andreas Färber wrote: Am 06.08.2013 12:44, schrieb Gleb Natapov: On Tue, Aug 06, 2013 at 01:19:53PM +0300, Michael S. Tsirkin wrote: It's a QEMU issue, devices that are added with -device are documented in

Re: [Qemu-devel] [PATCH v3 for-1.6 0/3] Remove legacy sysfw code

2013-08-09 Thread Markus Armbruster
Anthony sent out this series for me, because local e-mail misconfiguration has routed my attempts to the bit bucket.

Re: [Qemu-devel] [RFC PATCH] spapr: add ibmveth to the supported network adapters list

2013-11-02 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: Am 01.11.2013 um 03:52 schrieb Alexey Kardashevskiy a...@ozlabs.ru: [...] Or -net interface is deprecated and we do not want even touch it? I don't think we should deprecate it. It's easier to use than anything else. Ahci adoption heavily suffered from

Re: [Qemu-devel] [RFC PATCH] spapr: add ibmveth to the supported network adapters list

2013-11-02 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 01/11/2013 11:52, Alexey Kardashevskiy ha scritto: On 10/28/2013 05:03 AM, Alexander Graf wrote: On 10.10.2013, at 20:09, Alexey Kardashevskiy a...@ozlabs.ru wrote: The problem is that -net nic,model=? does not print ibmveth in the list while it

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-15 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: Am 14.11.2013 um 20:25 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 11/15/2013 10:03 AM, Peter Maydell wrote: On 14 November 2013 22:32, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH] hw/i2c/core.c: add the id property of i2c_slaver when created in the QEMUMachine's initialization

2013-11-15 Thread Markus Armbruster
Zhou Yuan zhouyuan.f...@cn.fujitsu.com writes: From: zhouy zhouyuan.f...@cn.fujitsu.com Date: Fri, 15 Nov 2013 15:50:52 -0500 Subject: [PATCH] add the id property of i2c_slaver when created in the QEMUMachine's initialization Signed-off-by: zhouy zhouyuan.f...@cn.fujitsu.com ---

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-21 Thread Markus Armbruster
Igor Mammedov imamm...@redhat.com writes: Along with conversion extend -m option to support following parameters: Please split this into two patches: first conversion to QemuOpts, then extension. mem - startup memory amount slots - total number of hotplug memory slots maxmem - maximum

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-11-21 Thread Markus Armbruster
Igor Mammedov imamm...@redhat.com writes: Signed-off-by: Igor Mammedov imamm...@redhat.com --- qapi/string-input-visitor.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-22 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw on the command line. The flash images will be mapped under 4G in their reverse unit order -- that is, with

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-24 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: [...] Here this made me think of the following question: should not memory available on boot be listed in CMOS? Let's assume new BIOS gets interrupt telling it there's new memory. It clears the interrupt and then system is reset. Will system after

Re: [Qemu-devel] [PATCH 1.7] configure: re-add current options in config-host.mak

2013-11-25 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 25 November 2013 09:53, Paolo Bonzini pbonz...@redhat.com wrote: I think anything that makes it easier for users to do bisections instead of us, and anything that makes it easier to script bisections (git bisect run), is valuable. Personally

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-25 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 11/22/13 13:21, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw on the command line

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-25 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw on the command line. The flash images will be mapped under 4G in their reverse unit order -- that is, with

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 11/25/13 16:22, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: On 11/22/13 13:21, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: This patch allows the user to usefully specify -drive file=img_1,if=pflash

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 11/22/13 13:21, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw on the command line

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 11/25/13 16:32, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw on the command line

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-26 Thread Markus Armbruster
Igor Mammedov imamm...@redhat.com writes: On Thu, 21 Nov 2013 11:12:43 +0100 Markus Armbruster arm...@redhat.com wrote: Igor Mammedov imamm...@redhat.com writes: Along with conversion extend -m option to support following parameters: Please split this into two patches: first conversion

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 11/26/13 14:11, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: On 11/25/13 16:32, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: This patch allows the user to usefully specify -drive file=img_1,if=pflash

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 11/26/13 13:53, Markus Armbruster wrote: Thus, we grab *all* if=pflash drives for this purpose. Your stated use case wants just two. Hmm. Are we sure we'll never want to map an if=pflash device somewhere else? No, I'm not sure. Perhaps

<    1   2   3   4   5   6   7   8   9   10   >