Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
---
blockdev.h |2 +-
hw/hd-geometry.c |4 ++--
hw/ide/c
es.
Bonus: the floppy type used in pc_cmos_init() now obviously matches
the one in the FDrive. Before, we relied on
bdrv_get_floppy_geometry_hint() picking the same type both in
fd_revalidate() and in pc_cmos_init().
Signed-off-by: Markus Armbruster
---
block
Leave it to ide_init_drive().
Signed-off-by: Markus Armbruster
---
blockdev.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 37521b5..d5f2f57 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -330,15 +330,15 @@ DriveInfo *drive_init
y.
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 19 ++-
hw/ide/internal.h |4 +++-
hw/ide/qdev.c | 21 -
3 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 84 +++---
1 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 70eb116..3f3070b 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
Each test litters /tmp with several files: a pid file and two
sockets. Tidy up.
Signed-off-by: Markus Armbruster
---
tests/libqtest.c | 29 -
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 071b6be
To prepare move of guess_disk_lchs() into hw/, where it poking
BlockDriverState member io_limits_enabled directly would be unclean.
Signed-off-by: Markus Armbruster
---
block.c | 24 +---
block.h |2 ++
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a
, just like before commit c219331e. Matches
-help, which explains cyls, heads, secs as "hard disk physical
geometry".
Signed-off-by: Markus Armbruster
---
block.c | 62 --
hw/fdc.c |3 ---
2 files changed, 28 insert
Currently, it is split between hd_geometry_guess() and
pc_cmos_init_late(). Confusing. info qtree shows the result of the
former. Also confusing.
Fold the part done in pc_cmos_init_late() into hd_geometry_guess().
Signed-off-by: Markus Armbruster
---
blockdev.h |1 +
hw/hd
New limits straight from ATA4 6.2 Register delivered data transfer
command sector addressing.
I figure the old sector limit 63 was blindly copied from the BIOS
int 13 limit. Doesn't apply to the hardware. No idea where the old
cylinder limit comes from.
Signed-off-by: Markus Armbr
So far covers only IDE and tests only CMOS contents.
Signed-off-by: Markus Armbruster
---
tests/Makefile |2 +
tests/hd-geo-test.c | 402 +++
2 files changed, 404 insertions(+), 0 deletions(-)
create mode 100644 tests/hd-geo-test.c
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
except it was put into block.c. Device-specific functionality should
be kept in device code, not the block layer. Move it to
hw/hd-geometry.c, and make stylistic changes required to keep
checkpatch.pl happy.
Signed-off-by: Markus
In preparation of purging it from the block layer, which will happen
later in this series.
Signed-off-by: Markus Armbruster
---
blockdev.c |4
blockdev.h |1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 9e0a72a..4d3b707 100644
--- a
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 3f3070b..4e47ec6 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -88,14 +88,31
number of cylinders.
Since hd_geometry_guess() returns right away when it finds a valid
geometry hint, translation can only be BIOS_ATA_TRANSLATION_AUTO in
the remainder of the function.
Assert this, and simplify accordingly.
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 17 +++---
Signed-off-by: Markus Armbruster
---
block.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/block.h b/block.h
index 052d0ce..e0121d5 100644
--- a/block.h
+++ b/block.h
@@ -427,6 +427,8 @@ typedef struct BlockConf {
uint32_t opt_io_size;
int32_t
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 0ab573c..02eb5c2 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,13 +321,15 @@ static void
rties for disk geometry
Part VI [PATCH 16-27/32]: A few more fixes and cleanups
This patch series is also available at
git://repo.or.cz/qemu/armbru.git
tag geo-v1
Markus Armbruster (32):
fdc: Drop broken code for user-defined floppy geometry
fdc: Move floppy geometry guessing back from bl
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c |7 +++
trace-events |4
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 9b22e3f..70eb116 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -23,6 +23,7
PC BIOS setup needs IDE geometry information. Get it directly from
the device model rather than through the block layer. In preparation
of purging geometry from the block layer, which will happen later in
this series.
Signed-off-by: Markus Armbruster
---
hw/ide.h |4 +++-
hw/ide
nders the hints unused. Purge them from the block layer.
Signed-off-by: Markus Armbruster
---
block.c | 32
block.h | 12
block_int.h |1 -
blockdev.c | 12 +---
blockdev.h |7 ++
0,1,1 1023,14,55 631032057
:12: 0,1,163,14,55 63 64377
The actual FAT file system nevertheless assumes the partition has
1032129 or 64449 sectors. Oops.
Signed-off-by: Markus Armbruster
---
block/vvfat.c |7 ---
1 files changed, 4
Just code motion, with one long line wrapped to keep checkpatch.pl
happy.
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 144 +-
1 files changed, 72 insertions(+), 72 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev
Blue Swirl writes:
> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
>> Unless parameter ":floppy:" is given, vvfat creates a virtual image
>> with DOS MBR defining a single partition which holds the FAT file
>> system. The size of the virtual image dep
Blue Swirl writes:
> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
>> So far covers only IDE and tests only CMOS contents.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/Makefile | 2
Blue Swirl writes:
> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
>> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
>> except it was put into block.c. Device-specific functionality should
>> be kept in device code, not the block layer.
Blue Swirl writes:
> SSE function tables could easily be corrupted because of use
> of void pointers.
>
> Introduce function pointer types and helper variables in order
> to improve type safety.
>
> Split sse_op_table3 according to types used.
>
> Signed-off-by: Blue Swirl
Clean build on master
Andreas Färber writes:
> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
>> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
>>> Best to use the same type, to avoid unwanted truncation or sign
>>> extension.
>>>
>>> BlockConf can'
;>>>
>>>>> No change without format=vvfat. With it, the user's hard disk
>>>>> geometry (-drive options cyls, heads, secs) is now obeyed, and the
>>>>> default hard disk geometry with :floppy: now matches the one without
>>>>> format
Kevin Wolf writes:
> Am 29.06.2012 22:33, schrieb Blue Swirl:
>> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
>>> Unless parameter ":floppy:" is given, vvfat creates a virtual image
>>> with DOS MBR defining a single partition which holds the
Kevin Wolf writes:
> Am 29.06.2012 17:34, schrieb Markus Armbruster:
>> Each test litters /tmp with several files: a pid file and two
>> sockets. Tidy up.
>>
>> Signed-off-by: Markus Armbruster
>
> Thanks! Still leaves the files around if a test case fails,
Kevin Wolf writes:
> Am 29.06.2012 17:34, schrieb Markus Armbruster:
>> When hd_geometry_guess() picks a geometry, it also picks the
>> appropriate translation, but only when the prior translation hint is
>> BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior
&g
Kevin Wolf writes:
> Am 05.07.2012 11:23, schrieb Markus Armbruster:
>> Kevin Wolf writes:
>>
>>> Am 29.06.2012 22:33, schrieb Blue Swirl:
>>>> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster
>>>> wrote:
>>>>> Unless paramete
Kevin Wolf writes:
> Am 29.06.2012 17:34, schrieb Markus Armbruster:
[...]
>> @@ -1067,19 +1074,16 @@ DLOG(if (stderr == NULL) {
>> else
>> dirname += i+1;
>>
>> -bs->total_sectors=bs->cyls*bs->heads*bs->secs;
>> +bs-&g
Kevin Wolf writes:
> Am 29.06.2012 17:34, schrieb Markus Armbruster:
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/hd-geo-test.c |6 --
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/hd-geo-test.c b/tests/
Kevin Wolf writes:
> Am 29.06.2012 17:34, schrieb Markus Armbruster:
>> New limits straight from ATA4 6.2 Register delivered data transfer
>> command sector addressing.
>>
>> I figure the old sector limit 63 was blindly copied from the BIOS
>> int 13 limit. D
Markus Armbruster writes:
> Kevin Wolf writes:
>
>> Am 29.06.2012 17:34, schrieb Markus Armbruster:
>>> New limits straight from ATA4 6.2 Register delivered data transfer
>>> command sector addressing.
>>>
>>> I figure the old sector limit 63 w
Marcelo Tosatti writes:
> On Mon, May 21, 2012 at 01:53:36PM -0400, Jason Baron wrote:
>> On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote:
>> > Add a command line parameter to not dump guest memory in the core dump, the
>> > command line is: -dont-dump-guest. This brought the core dum
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index db47846..1a58894 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -97,14 +97,31
Leave it to ide_init_drive().
Signed-off-by: Markus Armbruster
---
blockdev.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 3274923..201c641 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -330,15 +330,15 @@ DriveInfo *drive_init
0,1,1 1023,14,55 631032057
:12: 0,1,163,14,55 63 64377
The actual FAT file system nevertheless assumes the partition has
1032129 or 64449 sectors. Oops.
Signed-off-by: Markus Armbruster
---
block/vvfat.c |7 ---
1 files changed, 4
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index a47b945..5d9d2e4 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,15 +321,16 @@ static
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index cc447a2..a47b945 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,13 +321,15 @@ static void
PC BIOS setup needs IDE geometry information. Get it directly from
the device model rather than through the block layer. In preparation
of purging geometry from the block layer, which will happen later in
this series.
Signed-off-by: Markus Armbruster
---
hw/ide.h |4 +++-
hw/ide
Each test litters /tmp with several files: a pid file and two
sockets. Tidy up.
Signed-off-by: Markus Armbruster
---
tests/libqtest.c | 29 -
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 071b6be
Michael Tokarev writes:
> On 06.07.2012 06:42, Amos Kong wrote:
>> On 30/06/12 10:02, ak...@redhat.com wrote:
>>> From: Amos Kong
>>>
>>> Currently qemu outputs some low-level error in qemu-sockets.c
>>> when failed to start vnc server.
>>> eg. 'getaddrinfo(127.0.0.1,5902): Name or service not kn
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/s
y.
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 19 ++-
hw/ide/internal.h |4 +++-
hw/ide/qdev.c | 22 +-
3 files changed, 38 insertions(+), 7 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.
nders the hints unused. Purge them from the block layer.
Signed-off-by: Markus Armbruster
---
block.c | 32
block.h | 12
block_int.h |1 -
blockdev.c | 14 ++
hw/block-common.h|
To prepare move of guess_disk_lchs() into hw/, where it poking
BlockDriverState member io_limits_enabled directly would be unclean.
Signed-off-by: Markus Armbruster
---
block.c | 24 +---
block.h |2 ++
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a
Just code motion, with one long line wrapped to keep checkpatch.pl
happy.
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 144 +-
1 files changed, 72 insertions(+), 72 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev
now obeyed, and the
default hard disk geometry with :floppy: now matches the one without
format=vvfat.
Signed-off-by: Markus Armbruster
---
block/vvfat.c | 52
1 files changed, 28 insertions(+), 24 deletions(-)
diff --git a/block/vvfat.c b/blo
Signed-off-by: Markus Armbruster
---
block.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/block.h b/block.h
index 052d0ce..e0121d5 100644
--- a/block.h
+++ b/block.h
@@ -427,6 +427,8 @@ typedef struct BlockConf {
uint32_t opt_io_size;
int32_t
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c |7 +++
trace-events |4
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index c45eafd..f0dd021 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -32,6 +32,7
I screwed up Subject: lacks "v2". Sorry!
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 22 --
1 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 1a58894..fb849a3 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -119,8 +119,7 @@ static void
In particular, don't set disk type and geometry when a CD-ROM on bus
ide.0 has media during CMOS initialization.
Signed-off-by: Markus Armbruster
---
hw/ide/qdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index f191dd3..84
New limits straight from ATA4 6.2 Register delivered data transfer
command sector addressing.
I figure the old sector limit 63 was blindly copied from the BIOS
int 13 limit. Doesn't apply to the hardware. No idea where the old
cylinder limit comes from.
Signed-off-by: Markus Armbr
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 5d9d2e4..9a31e85 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -369,6 +369,27
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 84 +++---
1 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index f0dd021..db47846 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
So far covers only IDE and tests only CMOS contents.
Signed-off-by: Markus Armbruster
---
tests/Makefile |2 +
tests/hd-geo-test.c | 403 +++
2 files changed, 405 insertions(+), 0 deletions(-)
create mode 100644 tests/hd-geo-test.c
es.
Bonus: the floppy type used in pc_cmos_init() now obviously matches
the one in the FDrive. Before, we relied on
bdrv_get_floppy_geometry_hint() picking the same type both in
fd_revalidate() and in pc_cmos_init().
Signed-off-by: Markus Armbruster
---
block
Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
---
hw/block-common.h |2 +-
hw/hd-geometry.c |4 ++--
hw/ide/c
ry. scsi-block should get geometry from the host disk.
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c | 69 +--
1 files changed, 46 insertions(+), 23 deletions(-)
diff --git a/hw/scsi-disk.c b
the block
layer, which will happen later in this series.
Signed-off-by: Markus Armbruster
---
hw/block-common.h |3 ++-
hw/hd-geometry.c | 20 ++--
hw/ide/core.c |2 +-
hw/scsi-disk.c|4 ++--
hw/virtio-blk.c |2 +-
5 files changed, 20 insertions(+), 11
In preparation of purging it from the block layer, which will happen
later in this series.
Signed-off-by: Markus Armbruster
---
blockdev.c |4
blockdev.h |1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 9e0a72a..4d3b707 100644
--- a
, just like before commit c219331e. Matches
-help, which explains cyls, heads, secs as "hard disk physical
geometry".
Signed-off-by: Markus Armbruster
---
block.c | 62 --
hw/fdc.c |3 ---
2 files changed, 28 insert
ranslation, set with -drive trans=...
Bonus: info qtree now shows the translation. Except when it shows
"auto": that's resolved by pc_cmos_init_late(). To be addressed
shortly.
Signed-off-by: Markus Armbruster
---
hw/ide/internal.h |1 +
hw/ide/qdev.c | 10 +-
Currently, it is split between hd_geometry_guess() and
pc_cmos_init_late(). Confusing. info qtree shows the result of the
former. Also confusing.
Fold the part done in pc_cmos_init_late() into hd_geometry_guess().
Signed-off-by: Markus Armbruster
---
hw/block-common.h |1 +
hw/hd
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 15 +++
hw/qdev.h|3 +++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 002c7f9..0b18f8c 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev
rties for disk geometry
Part VI [PATCH 28-32/32]: A few more fixes and cleanups
This patch series is also available at
git://repo.or.cz/qemu/armbru.git
tag geo-v2
v2: New hw/block-common.h (Blue & Kevin)
Coding style here & there (Blue)
Tracepoint parameter types (Stefan)
Mark
cylinders.
Since hd_geometry_guess() returns right away when it finds a valid
geometry hint, translation can only be BIOS_ATA_TRANSLATION_AUTO in
the remainder of the function.
Assert this, and simplify accordingly.
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 17 +++-
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
except it was put into block.c. Device-specific functionality should
be kept in device code, not the block layer. Move it to
hw/hd-geometry.c, and make stylistic changes required to keep
checkpatch.pl happy.
Signed-off-by: Markus
Alexander Graf writes:
> On 05.07.2012, at 18:20, Markus Armbruster wrote:
[...]
>> When it comes to block device models, IDE is *always* the troublemaker.
>> And a big reason for that is the messy data structures that are
>> impractical to clean up while we still supp
Peter Maydell writes:
> On 8 July 2012 13:12, wrote:
>> -static inline uint64_t deposit64(uint64_t value, int start, int length,
>> - uint64_t fieldval)
>> +static inline uint64_t deposit64(uint64_t value, unsigned int start,
>> +
blauwir...@gmail.com writes:
> From: Blue Swirl
>
> Replace expr1 ?: expr2 with expr1 ? expr1 : expr2 as K&R intended.
>
> If expr1 has side effects, introduce a temporary variable.
>
> Signed-off-by: Blue Swirl
> ---
> block.c |6 --
> block/qcow2.c|6 --
>
blauwir...@gmail.com writes:
> From: Blue Swirl
>
> Use 'unsigned int' for bit numbers instead of 'unsigned long' or
> 'int'. Adjust asserts.
I'd like to lodge a formal objection to this part.
There is no consensus. I recognize the power of maintainers to force a
change even without consensus.
blauwir...@gmail.com writes:
> From: Blue Swirl
>
> Use 'bool' type for return value of bit test functions.
Matter of taste. 'bool' makes sense if you think of these functions as
predicates (ugly ones, with side effects). 'int' makes sense if you
think of them as returning the bit value (a bit
Alexander Graf writes:
> We've had support for creating AHCI devices using -device for a while now,
> but it's cumbersome to users. We really should provide an easier way for
> them to leverage the power of AHCI!
>
> So let's introduce a new if= option to -drive, giving users the same
> command l
Blue Swirl writes:
> On Fri, Jul 6, 2012 at 6:57 AM, Markus Armbruster wrote:
>> Each test litters /tmp with several files: a pid file and two
>> sockets. Tidy up.
>>
>> Signed-off-by: Markus Armbruster
>
> While a nice patch, I don't think it should b
Gerd Hoffmann writes:
> Hi,
>
>>> If -hda has the semantics of "create an IDE device", then no, we can't
>>> change it. It doesn't however. IIRC on -M pseries -hda creates SCSI
>>> devices. On s390 -hda creates virtio devices. So if on -M q35 -hda would
>>> create if=ahci, I don't see how th
Kevin Wolf writes:
> Am 09.07.2012 10:50, schrieb Markus Armbruster:
>> Alexander Graf writes:
>>
>>> We've had support for creating AHCI devices using -device for a while now,
>>> but it's cumbersome to users. We really should provide an easier way
Alexander Graf writes:
> On 09.07.2012, at 13:06, Markus Armbruster wrote:
>
>> Kevin Wolf writes:
>>
>>> Am 09.07.2012 10:50, schrieb Markus Armbruster:
>>>> Alexander Graf writes:
>>>>
>>>>> We've had support
Eric Blake writes:
> On 07/09/2012 06:10 AM, Peter Maydell wrote:
>> On 9 July 2012 13:07, Eric Blake wrote:
>>> That is, we are filtering based on the explicit presence of a literal
>>> '?' in the help output to determine whether we can further filter based
>>> on '-device device,?' queries wit
Kevin Wolf writes:
> Am 09.07.2012 17:01, schrieb Anthony Liguori:
>> On 07/09/2012 09:16 AM, Kevin Wolf wrote:
>>> From: Markus Armbruster
>>>
>>> Commit 5bbdbb46 moved it to block.c because "other geometry guessing
>>> functions already
Fix uninitialized variable in PATCH 02/29 (Anthony)
v2: New hw/block-common.h (Blue & Kevin)
Coding style here & there (Blue)
Tracepoint parameter types (Stefan)
Markus Armbruster (29):
fdc: Move floppy geometry guessing back from block.c
vvfat: Fix partition table
vvfat: Do not clobb
ry. scsi-block should get geometry from the host disk.
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c | 69 +--
1 files changed, 46 insertions(+), 23 deletions(-)
diff --git a/hw/scsi-disk.c b
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
except it was put into block.c. Device-specific functionality should
be kept in device code, not the block layer. Move it to
hw/hd-geometry.c, and make stylistic changes required to keep
checkpatch.pl happy.
Signed-off-by: Markus
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index a47b945..5d9d2e4 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,15 +321,16 @@ static
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 15 +++
hw/qdev.h|3 +++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 002c7f9..0b18f8c 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev
the block
layer, which will happen later in this series.
Signed-off-by: Markus Armbruster
---
hw/block-common.h |3 ++-
hw/hd-geometry.c | 20 ++--
hw/ide/core.c |2 +-
hw/scsi-disk.c|4 ++--
hw/virtio-blk.c |2 +-
5 files changed, 20 insertions(+), 11
PC BIOS setup needs IDE geometry information. Get it directly from
the device model rather than through the block layer. In preparation
of purging geometry from the block layer, which will happen later in
this series.
Signed-off-by: Markus Armbruster
---
hw/ide.h |4 +++-
hw/ide
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/s
cylinders.
Since hd_geometry_guess() returns right away when it finds a valid
geometry hint, translation can only be BIOS_ATA_TRANSLATION_AUTO in
the remainder of the function.
Assert this, and simplify accordingly.
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 17 +++-
In particular, don't set disk type and geometry when a CD-ROM on bus
ide.0 has media during CMOS initialization.
Signed-off-by: Markus Armbruster
---
hw/ide/qdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index f191dd3..84
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index cc447a2..a47b945 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,13 +321,15 @@ static void
es.
Bonus: the floppy type used in pc_cmos_init() now obviously matches
the one in the FDrive. Before, we relied on
bdrv_get_floppy_geometry_hint() picking the same type both in
fd_revalidate() and in pc_cmos_init().
Signed-off-by: Markus Armbruster
---
block
Just code motion, with one long line wrapped to keep checkpatch.pl
happy.
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 144 +-
1 files changed, 72 insertions(+), 72 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev
Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
---
hw/block-common.h |2 +-
hw/hd-geometry.c |4 ++--
hw/ide/c
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 5d9d2e4..9a31e85 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -369,6 +369,27
301 - 400 of 28273 matches
Mail list logo
