Stefan Weil w...@mail.berlios.de writes:
Am 07.02.2011 08:23, schrieb Markus Armbruster:
Stefan Weil w...@mail.berlios.de writes:
Am 05.02.2011 16:35, schrieb Blue Swirl:
[...]
The patch changes also signed longs to uintptr_t. That could introduce
regressions, so please use signed/unsigned
Anthony Liguori anth...@codemonkey.ws writes:
On 02/05/2011 03:11 AM, Michael Tokarev wrote:
04.02.2011 15:25, Anthony Liguori wrote:
To help make the stable branch more active than it has been in the past,
I'd like to split the stable branch into a separate tree to allow the
tree to
I haven't been able to follow the evolution of this series, my apologies
if I'm missing things already discussed.
Alon Levy al...@redhat.com writes:
Example usage:
EnumTable foo_enum_table[] = {
{bar, 1},
{buz, 2},
{NULL, 0},
};
DEFINE_PROP_ENUM(foo, State, foo, 1,
Stefan Weil w...@mail.berlios.de writes:
Am 05.02.2011 16:35, schrieb Blue Swirl:
[...]
The patch changes also signed longs to uintptr_t. That could introduce
regressions, so please use signed/unsigned as original.
I changed the code manually, and there was only one location where
Michael S. Tsirkin m...@redhat.com writes:
remove a confusing comment.
TAP_DEFAULT_SNDBUF 0 is later translated to INT_MAX, so
let's set that value directly.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
net/tap-linux.c |7 +--
1 files changed, 1 insertions(+), 6
Should have spotted this when doing commit 319ae529.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 24d7658..0690cc8 100644
--- a/blockdev.c
+++ b/blockdev.c
Started leaking in commit 1dae12e6.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index ecfadc1..24d7658 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -182,6 +182,7 @@ static void
Alon Levy al...@redhat.com writes:
On Mon, Feb 07, 2011 at 04:27:21PM +0200, Alon Levy wrote:
On Mon, Feb 07, 2011 at 03:00:25PM +0100, Markus Armbruster wrote:
[...]
Sounds like what I have in mind. Care to explore it?
One EnumTable should do, just make its member value wide enough
Kevin Wolf kw...@redhat.com writes:
Requests could return success even though they failed when bdrv_aio_readv
returned NULL for a backing file read.
Reported-by: Chunqiang Tang ct...@us.ibm.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c |4 +++-
1 files changed, 3
Chris Wright chr...@redhat.com writes:
[...]
- qdev/vmstate both examples of partially completed work that need more
attention
As far as qdev's concerned, I can see two kinds of to-dos:
* Further develop qdev so that more of the machine init code can becomes
qdev declarations. Specific
Anthony Liguori anth...@codemonkey.ws writes:
On 02/08/2011 11:13 AM, Markus Armbruster wrote:
Chris Wrightchr...@redhat.com writes:
[...]
- qdev/vmstate both examples of partially completed work that need more
attention
As far as qdev's concerned, I can see two kinds
Peter Maydell peter.mayd...@linaro.org writes:
On 8 February 2011 17:13, Markus Armbruster arm...@redhat.com wrote:
As far as qdev's concerned, I can see two kinds of to-dos:
* Further develop qdev so that more of the machine init code can becomes
qdev declarations. Specific ideas welcome
Aurelien Jarno aurel...@aurel32.net writes:
On Tue, Feb 08, 2011 at 06:13:53PM +0100, Markus Armbruster wrote:
Chris Wright chr...@redhat.com writes:
[...]
- qdev/vmstate both examples of partially completed work that need more
attention
As far as qdev's concerned, I can see two
Michael S. Tsirkin m...@redhat.com writes:
qemu makes it possible to disable link at tap
which is not communicated to the guest but
causes all packets to be dropped.
Handle this with vhost simply by moving to the userspace emulation.
Note: it might be a good idea to make peer link status
Peter Maydell peter.mayd...@linaro.org writes:
On 9 February 2011 08:11, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
Markus Armbruster arm...@redhat.com wrote:
I've said this before: at some point in time (sooner rather than
later, if you ask me
Anthony Liguori anth...@codemonkey.ws writes:
On 02/09/2011 02:01 AM, Markus Armbruster wrote:
Anthony Liguorianth...@codemonkey.ws writes:
[...]
We need to unify the property model. We have QemuOpts, qdev
properties, and QObject which basically reinvents variant typing three
different
Kevin Wolf kw...@redhat.com writes:
When reading a compressed cluster failed, qcow2 falsely returned success.
Reviewed-by: Markus Armbruster arm...@redhat.com
Amit Shah amit.s...@redhat.com writes:
This will be needed for hot-plugging chardevs.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
monitor.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 7fc311d..f3d7ab3 100644
---
Blue Swirl blauwir...@gmail.com writes:
Allow failure with vmware_vga device creation and use standard
VGA instead.
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/mips_malta.c |6 +-
hw/pc.c | 11 ---
hw/vmware_vga.h | 11 +--
3 files changed,
Blue Swirl blauwir...@gmail.com writes:
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/pc.h |1 -
hw/pc_piix.c |2 --
hw/vmport.c | 24 +---
3 files changed, 21 insertions(+), 6 deletions(-)
diff --git a/hw/pc.h b/hw/pc.h
index a048768..603a2a3
Blue Swirl blauwir...@gmail.com writes:
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/pci.c | 20
hw/pci.h |4
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index d5bbba9..5e6e216 100644
--- a/hw/pci.c
+++
Blue Swirl blauwir...@gmail.com writes:
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/qdev.c | 14 +-
hw/qdev.h |1 +
2 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index c7fec44..1aa1ea0 100644
--- a/hw/qdev.c
+++
Blue Swirl blauwir...@gmail.com writes:
Convert to qdev, also add a proper reset function.
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/pc.c |5 +++--
hw/pc.h |3 ---
hw/vmmouse.c | 37 +
3 files changed, 32 insertions(+),
Blue Swirl blauwir...@gmail.com writes:
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/isa-bus.c | 12
hw/isa.h |1 +
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/hw/isa-bus.c b/hw/isa-bus.c
index 0cb1afb..6f349a5 100644
--- a/hw/isa-bus.c
Blue Swirl blauwir...@gmail.com writes:
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/sysbus.c | 31 +++
hw/sysbus.h |9 +
2 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/hw/sysbus.c b/hw/sysbus.c
index 1583bd8..8980f34
Anthony Liguori anth...@codemonkey.ws writes:
On 02/12/2011 11:03 AM, Markus Armbruster wrote:
Blue Swirlblauwir...@gmail.com writes:
Convert to qdev, also add a proper reset function.
[...]
Pointer properties are for dirty hacks only. Is there really no better
solution? Why does
Blue Swirl blauwir...@gmail.com writes:
On Sat, Feb 12, 2011 at 6:57 PM, Markus Armbruster arm...@redhat.com wrote:
Blue Swirl blauwir...@gmail.com writes:
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
hw/pc.h | 1 -
hw/pc_piix.c | 2 --
hw/vmport.c | 24
Anthony Liguori anth...@codemonkey.ws writes:
On 02/14/2011 11:56 AM, Chris Wright wrote:
Please send in any agenda items you are interested in covering.
- QAPI and QMP events
- qdev future
Do we need a qdev tree and a maintainer for it?
I don't really have a coherent plan for
Anthony Liguori anth...@codemonkey.ws writes:
Hi,
In my QAPI branch[1], I've now got almost every existing QMP command
converted with (hopefully) all of the hard problems solved. There is
only one remaining thing to attack before posting for inclusion and
that's events. Here's my current
Luiz Capitulino lcapitul...@redhat.com writes:
On Mon, 14 Feb 2011 13:34:11 -0600
Anthony Liguori anth...@codemonkey.ws wrote:
On 02/14/2011 12:34 PM, Luiz Capitulino wrote:
On Mon, 14 Feb 2011 08:39:11 -0600
Anthony Liguorianth...@codemonkey.ws wrote:
On 02/14/2011 06:45 AM,
Wen Congyang we...@cn.fujitsu.com writes:
We alloc memory for dinfo-id, so we should free it in
the function drive_uninit().
Already fixed in Kevin's block tree and 0.14-rc2 (commit e5f1c196),
although not yet in stable.
Thanks anyway!
Wen Congyang we...@cn.fujitsu.com writes:
steps to reproduce this bug:
1. virsh attach-disk domain --source imagefile --target sdb --sourcetype file
--driver qemu --subdriver qcow2
error: Failed to attach disk
error: operation failed: adding
Blue Swirl blauwir...@gmail.com writes:
On Tue, Feb 15, 2011 at 12:07 PM, Markus Armbruster arm...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws writes:
On 02/12/2011 11:03 AM, Markus Armbruster wrote:
Blue Swirlblauwir...@gmail.com writes:
Convert to qdev, also add a proper
Blue Swirl blauwir...@gmail.com writes:
On Tue, Feb 15, 2011 at 12:22 PM, Markus Armbruster arm...@redhat.com wrote:
Blue Swirl blauwir...@gmail.com writes:
On Sat, Feb 12, 2011 at 6:57 PM, Markus Armbruster arm...@redhat.com
wrote:
[...]
Old code has pc_init1() call vmport_init(). Where
Stefan Weil w...@mail.berlios.de writes:
Am 04.02.2011 16:27, schrieb Markus Armbruster:
Anthony Liguorianth...@codemonkey.ws writes:
On 02/02/2011 01:28 PM, Stefan Weil wrote:
[...]
[PATCH 1/3] tests: Fix two memory leaks
(http://patchwork.ozlabs.org/patch/79945
Hu Tao hu...@cn.fujitsu.com writes:
This patch enables drive_add/drive_del qmp commands, which are required
by libvirt when connecting to qemu using QMP.
These commands were intentionally left out of QMP because they are badly
designed.
I understand the need for drive hot plug in QMP. I
Anthony Liguori anth...@codemonkey.ws writes:
On 02/04/2011 12:18 AM, Amit Shah wrote:
Hello,
This is yet another rebase of the patchset I'd sent earlier.
The usual notes apply: this is just the start, just getting the
framework in place and a few examples so that people can then pick up
Anthony Liguori anth...@codemonkey.ws writes:
On 02/17/2011 07:06 AM, Amit Shah wrote:
On (Tue) 15 Feb 2011 [10:43:42], Anthony Liguori wrote:
#define DEFINE_BLOCK_PROPERTIES(_state, _conf) \
-DEFINE_PROP_DRIVE(drive, _state, _conf.bs),
Anthony Liguori anth...@codemonkey.ws writes:
On 02/04/2011 12:18 AM, Amit Shah wrote:
Add a 'description' along with each qdev property to document the input
each qdev property takes.
Signed-off-by: Amit Shahamit.s...@redhat.com
Acked-by: Markus Armbrusterarm...@redhat.com
---
[...]
diff
Kevin Wolf kw...@redhat.com writes:
Am 15.02.2011 20:45, schrieb Chunqiang Tang:
Chunqiang Tang/Watson/IBM wrote on 01/28/2011 05:13:27 PM:
As you requested, I set up a wiki page for FVD at
http://wiki.qemu.org/Features/FVD
. It includes a summary of FVD, a detailed specification of FVD,
From 8cd4978c9be6ff2bcc414bb1c1b258b96b9a74c1 Mon Sep 17 00:00:00 2001
From: Markus Armbruster arm...@redhat.com
Date: Fri, 18 Feb 2011 15:54:02 +0100
After forcefully ejecting media locked by the guest, you can't ever
again insert new media.
Example:
(qemu) info block
hda: type=hd
Bug Reporter 722...@bugs.launchpad.net writes:
Public bug reported:
I start qemu (Linux) from the same USB memory stick on several
computers. Up to and including qemu 0.12.5, I could use or not use
qemu's -enable-kvm command line parameter as appropriate for the
hardware, and qemu would
Anthony Liguori anth...@codemonkey.ws writes:
On 02/18/2011 03:57 AM, Kevin Wolf wrote:
Am 18.02.2011 10:12, schrieb Markus Armbruster:
Kevin Wolfkw...@redhat.com writes:
Am 15.02.2011 20:45, schrieb Chunqiang Tang:
Chunqiang Tang/Watson/IBM wrote on 01/28/2011 05:13
Aurelien Jarno aurel...@aurel32.net writes:
[...]
I agree that the best would be to have a single format, and it's
probably a goal to have. That said, what is most important to my view is
having one or two formats which together have _all_ the features (and
here I consider speed as a
Tomas Bures bu...@d3s.mff.cuni.cz writes:
Dear all,
I'm preparing a class on embedded systems. I would like to make a
client that interfaces with QEMU and the application running inside
it. This client would simulate the physical environment that the
application running inside QEMU should
Kevin Wolf kw...@redhat.com writes:
Am 22.02.2011 09:37, schrieb Markus Armbruster:
Anthony Liguori anth...@codemonkey.ws writes:
On 02/18/2011 03:57 AM, Kevin Wolf wrote:
Am 18.02.2011 10:12, schrieb Markus Armbruster:
Kevin Wolfkw...@redhat.com writes:
Am 15.02.2011 20:45
Blue Swirl blauwir...@gmail.com writes:
On Sat, Jul 24, 2010 at 12:03 PM, Markus Armbruster arm...@redhat.com wrote:
Blue Swirl blauwir...@gmail.com writes:
Command line flag '-snapshot' was setting the drive flag 'snapshot'
for all drives. Therefore also CDROM devices were incorrectly
Blue Swirl blauwir...@gmail.com writes:
Block device change command did not copy BDRV_O_SNAPSHOT flag. Thus
the new image did not have this flag and the file got deleted during
opening.
Fix by copying BDRV_O_SNAPSHOT flag.
Aha: the file gets deleted because bs-is_temporary survives change,
Anthony Liguori anth...@codemonkey.ws writes:
- any additional input on probed_raw?
Isn't it a fait accompli? I stopped providing input when commit
79368c81 appeared.
Anthony Liguori anth...@codemonkey.ws writes:
On 07/26/2010 02:19 PM, Avi Kivity wrote:
Is what we are supporting just what libvirt expects there to be or
what any tool out there expects there to be?
We should try to support all users, prioritized by the number of end
users they represent.
Anthony Liguori anth...@codemonkey.ws writes:
On 07/26/2010 02:19 PM, Avi Kivity wrote:
[...]
Regardless, outside of Windows users qemu will mostly be consumed
via distribution branches, with different levels of backport
happiness. We should recognize that and work with it, not against
it.
Kevin Wolf kw...@redhat.com writes:
Am 27.07.2010 15:00, schrieb Anthony Liguori:
On 07/27/2010 02:19 AM, Markus Armbruster wrote:
Anthony Liguorianth...@codemonkey.ws writes:
- any additional input on probed_raw?
Isn't it a fait accompli? I stopped providing input when commit
Anthony Liguori anth...@codemonkey.ws writes:
On 07/27/2010 10:22 AM, Markus Armbruster wrote:
Kevin Wolfkw...@redhat.com writes:
Am 27.07.2010 15:00, schrieb Anthony Liguori:
On 07/27/2010 02:19 AM, Markus Armbruster wrote:
Anthony Liguorianth...@codemonkey.ws
Kevin Wolf kw...@redhat.com writes:
Am 28.07.2010 13:22, schrieb Markus Armbruster:
Anthony Liguori anth...@codemonkey.ws writes:
On 07/27/2010 10:22 AM, Markus Armbruster wrote:
[...]
Raw can't be probed safely, by its very nature. For historical reasons,
we try anyway. I think we
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
This set of patches adds default CPU types to the PC compat
definitions, and patch #2 sets the CPU type to kvm64/kvm32 when
running under KVM.
Long term we might want to qdev'ify the CPUs but I think it is better
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes:
The output generated by 'info snapshots' shows only snapshots that exist on
the
block device that saves the VM state. This output can cause an user to
erroneously try to load an snapshot that is not available on all block
devices.
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes:
This patch address two issues.
1) When savevm is run using an previously saved snapshot id or name, it will
delete the original and create a new one, using the same id and name and not
prompting the user of what just happened.
This
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes:
The bdrv_snaphost_find() returns zero in case it finds an snapshot or -ENOENT
in
case it doesn't.
Checking returning values as = zero doesn't make sense.
Debatable. RETVAL 0 is an idiomatic check for error. RETVAL = 0
is merely its
Why?
I figure the next patch wants it, but if that's the reason, the commit
message should state it.
Luiz Capitulino lcapitul...@redhat.com writes:
On Fri, 30 Jul 2010 11:34:57 +0200
Markus Armbruster arm...@redhat.com wrote:
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes:
This patch address two issues.
1) When savevm is run using an previously saved snapshot id or name
Victor Shkamerda 611...@bugs.launchpad.net writes:
Public bug reported:
The snapshot mode is not working if you use raw format for image instead
of qcow2. Create a raw disk image by running dd of=xxx.img bs=1 count=0
seek=8G. Then run qemu -snapshot xxx.img. In monitor console run
info
Victor Shkamerda 611...@bugs.launchpad.net writes:
Public bug reported:
isa bus emulation not working anymore.
Try running qemu -M isapc. It will crash with segmentation fault.
This is a qemu HEAD from git on Fedora linux.
** Affects: qemu
Importance: Undecided
Status:
Stefan Weil w...@mail.berlios.de writes:
All other error messages in qemu-option.c display the name
of the invalid parameter. This seems to be reasonable for
invalid identifiers, too. Without it, a debugger is needed
to find the name.
Cc: Markus Armbruster arm...@redhat.com
Cc: Anthony
Isaku Yamahata yamah...@valinux.co.jp writes:
Sorry for that.
Does the attached patch fix it?
As far as I can see, yes.
I'd prefer:
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 812ddfd..34c65d5 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -103,6 +103,7 @@ static void pc_init1(ram_addr_t
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes:
On Fri, Jul 30, 2010 at 6:45 AM, Markus Armbruster arm...@redhat.com wrote:
Why?
I figure the next patch wants it, but if that's the reason, the commit
message should state it.
To better identify what happened and where, IMHO.
To let
Stefan Weil w...@mail.berlios.de writes:
Am 02.08.2010 10:40, schrieb Markus Armbruster:
Stefan Weil w...@mail.berlios.de writes:
All other error messages in qemu-option.c display the name
of the invalid parameter. This seems to be reasonable for
invalid identifiers, too. Without
Alex Williamson alex.william...@redhat.com writes:
Several devices rely on their reset() function being called to
initialize device state, e1000 and rtl8139 in particular. When
the device is hot added, the reset doesn't occur, often leaving
the device in an unusable state. Adding a call to
Anthony Liguori anth...@codemonkey.ws writes:
On 08/17/2010 03:04 AM, Jes Sorensen wrote:
On 08/13/10 20:02, Blue Swirl wrote:
On Fri, Aug 13, 2010 at 3:22 PM, Miguel Di Ciurcio Filho
miguel.fi...@gmail.com wrote:
The existing code that I have touched don't follow the current
Alex Williamson alex.william...@redhat.com writes:
On Fri, 2010-08-20 at 11:00 +0200, Markus Armbruster wrote:
Alex Williamson alex.william...@redhat.com writes:
Several devices rely on their reset() function being called to
initialize device state, e1000 and rtl8139 in particular. When
Luiz Capitulino lcapitul...@redhat.com writes:
A number of changes I prefer to do in one shot:
- Fix example
- Small clarifications
- Add multiple monitors example
- Add 'Development Process' section
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/README | 71
Anthony Liguori anth...@codemonkey.ws writes:
On 08/20/2010 10:47 AM, Markus Armbruster wrote:
Alex Williamsonalex.william...@redhat.com writes:
On Fri, 2010-08-20 at 11:00 +0200, Markus Armbruster wrote:
Alex Williamsonalex.william...@redhat.com writes:
Several
Anthony Liguori anth...@codemonkey.ws writes:
On 08/19/2010 04:21 PM, Blue Swirl wrote:
Should CPUs appear in the QEMU device tree?
They have several properties that should be user visible.
Sure, but that's an argument for having some of the qdev features
(like variant
Blue Swirl blauwir...@gmail.com writes:
On Fri, Aug 20, 2010 at 6:44 PM, Blue Swirl blauwir...@gmail.com wrote:
On Fri, Aug 20, 2010 at 1:47 PM, Markus Armbruster arm...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws writes:
To be perfectly honest, we have enough hard problems
Anthony Liguori anth...@codemonkey.ws writes:
On 08/20/2010 11:14 AM, Markus Armbruster wrote:
The real problem is how we do reset. We shouldn't register a reset
handler for every qdev device but rather register a single reset
handler that walks the device tree and calls reset on every
Hollis Blanchard hol...@penguinppc.org writes:
I am able to run qemu with the following commandline:
/usr/local/bin/qemu-system-ppcemb -enable-kvm -kernel uImage.bamboo
-nographic -M bamboo ppc440-angstrom-linux.img
However, when I try to use virtio instead, I get this segfault:
Blue Swirl blauwir...@gmail.com writes:
On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster arm...@redhat.com wrote:
Blue Swirl blauwir...@gmail.com writes:
On Fri, Aug 20, 2010 at 6:44 PM, Blue Swirl blauwir...@gmail.com wrote:
On Fri, Aug 20, 2010 at 1:47 PM, Markus Armbruster arm
Blue Swirl blauwir...@gmail.com writes:
Combining bitwise AND and logical NOT is suspicious.
Fixed by this Coccinelle script:
// From http://article.gmane.org/gmane.linux.kernel/646367
@@ expression E1,E2; @@
(
!E1 !E2
|
- !E1 E2
+ !(E1 E2)
)
Signed-off-by: Blue Swirl
Avi Kivity a...@redhat.com writes:
On 08/22/2010 07:40 PM, Jes Sorensen wrote:
I totally agree with Markus
that it seems like wasted effort to come up with new tools and having to
maintain them when there are good ones out there like the ones from the
Linux kernel.
scripts/Lindent is
You lost me. A few messages upthread.
What's the *practical* problem again?
Anthony Liguori anth...@codemonkey.ws writes:
On 08/23/2010 10:10 AM, Markus Armbruster wrote:
You lost me. A few messages upthread.
What's the *practical* problem again?
CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug.
I believe the right short term way
Anthony Liguori anth...@codemonkey.ws writes:
On 08/22/2010 01:36 PM, malc wrote:
But how would you do that? Drop the CODING_STYLE (and accept
anything)? Switch to a new CODING_STYLE that is widely appreciated and
so all bikeshedding will cease? Enforce current style?
I would
Daniel P. Berrange berra...@redhat.com writes:
On Tue, Aug 24, 2010 at 03:46:14PM +0200, Alexander Graf wrote:
Daniel P. Berrange wrote:
On Tue, Aug 24, 2010 at 03:40:25PM +0200, Alexander Graf wrote:
Daniel P. Berrange wrote:
On Tue, Aug 24, 2010 at 12:45:19PM +0200,
Alexander Graf ag...@suse.de writes:
The monitor command for hotplugging is in i386 specific code. This is just
plain wrong, as S390 just learned how to do hotplugging too and needs to
get drives for that.
So let's add a generic copy to generic code that handles drive_add in a
way that
Daniel P. Berrange berra...@redhat.com writes:
On Fri, Aug 27, 2010 at 07:39:37AM -0500, Anthony Liguori wrote:
On 08/27/2010 04:29 AM, Daniel P. Berrange wrote:
On Fri, Aug 27, 2010 at 10:57:10AM +0530, Amit Shah wrote:
This error message denotes some command was not successful in
Amit Shah amit.s...@redhat.com writes:
On (Fri) Aug 27 2010 [07:39:37], Anthony Liguori wrote:
NACK. It has always been allowed valid to call query-balloon
to get the current balloon level. We must not throw an error
just because the recently added mem stats can't be refreshed.
I think
Anthony Liguori anth...@codemonkey.ws writes:
On 08/30/2010 03:16 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensenjes.soren...@redhat.com
pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup
at init time, it is not possible to load an option ROM for a hotplug
device
Anthony Liguori anth...@codemonkey.ws writes:
On 08/27/2010 02:24 PM, Luiz Capitulino wrote:
[...]
I think we have agreed on the internal interfaces approach. My only
concern is whether this will conflict when extending the wire protocol
(eg. adding new arguments to existing commands). Not a
Anthony Liguori anth...@codemonkey.ws writes:
On 08/30/2010 03:30 AM, Markus Armbruster wrote:
Amit Shahamit.s...@redhat.com writes:
On (Fri) Aug 27 2010 [07:39:37], Anthony Liguori wrote:
NACK. It has always been allowed valid to call query-balloon
to get the current balloon
Anthony Liguori anth...@codemonkey.ws writes:
On 08/30/2010 09:52 AM, Markus Armbruster wrote:
Because it's too easy to get it wrong in QEMU. Here's the rationale.
If I can't trivially call a QMP function in C, then I'm not going to
use QMP functions within QEMU. I'm not going to create
Anthony Liguori anth...@codemonkey.ws writes:
[...]
My position is that we aren't any closer to having compatible APIs
then we were with the human monitor. I think we need to focus on
compatibility and that that has to be solved as the QEMU interface
level. I contend that it's not solvable
Stefan Weil w...@mail.berlios.de writes:
Am 16.07.2010 09:04, schrieb Markus Armbruster:
Stefan Weilw...@mail.berlios.de writes:
An empty environment is sometimes useful in user mode.
The new option provides it for linux-user and bsd-user
(darwin-user still has no environment related
Luiz Capitulino lcapitul...@redhat.com writes:
Hi there,
I was working on a detailed writeup about monitor's internals so that I could
get some guidance regarding monitor's internal design, but after today's call
I realized that we should discuss the general design first.
I think we have
Please excuse my late reply. I'm so much behind in this list, it's not
funny anymore.
I agree with Anthony, this series looks nice. A few remarks inline.
Isaku Yamahata yamah...@valinux.co.jp writes:
Make qbus_walk_children() call busfn for root bus.
Please don't repeat the subject in the
Alex Williamson alex.william...@redhat.com writes:
On Thu, 2010-09-23 at 12:43 -0500, Anthony Liguori wrote:
On 09/22/2010 02:52 PM, Alex Williamson wrote:
During a hotplug, the netdev might be removed before the
unplug?
connected virtio device. When this happens, the guest might
be
Mathias Krause mathias.kra...@secunet.com writes:
Hi Kevin,
On 17.09.2010 12:44, Kevin Wolf wrote:
Hi Mathias,
Am 17.09.2010 08:42, schrieb Mathias Krause:
Using QEMU's block devices instead of a simple file would be
more consistent with the rest of QEMU and allow reading the
CMOS data
Anthony Liguori anth...@codemonkey.ws writes:
On 09/16/2010 08:58 AM, Mathias Krause wrote:
In contrast to the BIOS and Option ROMs the CMOS content cannot be
predefined by the user. Also the amount of useable CMOS ARM is pretty
limited, even though the amount of CMOS bytes emulated by qemu
Mathias Krause mathias.kra...@secunet.com writes:
On 17.09.2010 15:27, Anthony Liguori wrote:
On 09/17/2010 01:50 AM, Mathias Krause wrote:
Am 16.09.2010 19:20 schrieb Anthony Liguori:
Instead of using FILE, I'd suggest using a BlockDriver to read and write
the data.
I'll fix
Loïc Minier loic.min...@linaro.org writes:
When configure runs exit 1, the trap handler is run to cleanup any
files created by configure, but this trap handler itself calls exit
with no argument (which means zero exit code):
[...]
+ echo Error: zlib check failed
Error: zlib check failed
+
Hervé Poussineau hpous...@reactos.org writes:
Use it in Jazz emulation
Remove i8042_mm_init() function, which is not used anymore
Signed-off-by: Hervé Poussineau hpous...@reactos.org
---
hw/mips_jazz.c |3 ++-
hw/pc.h|3 ---
hw/pckbd.c | 55
Hervé Poussineau hpous...@reactos.org writes:
Use it in Jazz emulation
Remove protection stuff, which doesn't belong to this device
Remove ds1225y_init() and ds1225y_set_protection() functions, which are not
used anymore
Signed-off-by: Hervé Poussineau hpous...@reactos.org
I think this
701 - 800 of 27544 matches
Mail list logo
