Hervé Poussineau hpous...@reactos.org writes:
Use it in Jazz emulation
Remove jazz_led_init() function, which is not used anymore
Compile jazz_led.c file only once
[...]
diff --git a/hw/jazz_led.c b/hw/jazz_led.c
index 4cb680c..f364301 100644
--- a/hw/jazz_led.c
+++ b/hw/jazz_led.c
[...]
Blue Swirl blauwir...@gmail.com writes:
2010/9/8 Hervé Poussineau hpous...@reactos.org:
Use it in Jazz emulation
Remove rc4030_init() function, which is not used anymore
Signed-off-by: Hervé Poussineau hpous...@reactos.org
---
hw/mips.h | 4 +-
hw/mips_jazz.c | 8 +--
Loïc Minier l...@dooz.org writes:
On Sat, Sep 25, 2010, Blue Swirl wrote:
It looks like dash and ksh are not compliant and use the return value
of echo or rm inside trap handler:
dash -c 'trap sh -c \exit 4\; exit 0 1 2 3 9 11 13 15;exit 3'; echo $?
4
I've filed
Blue Swirl blauwir...@gmail.com writes:
Add logic to detect changes in generated files. If the old
and new files are identical, don't touch the generated file.
This avoids a lot of churn since many files depend on trace.h.
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
Makefile | 18
Markus Armbruster arm...@redhat.com writes:
Blue Swirl blauwir...@gmail.com writes:
Add logic to detect changes in generated files. If the old
and new files are identical, don't touch the generated file.
This avoids a lot of churn since many files depend on trace.h.
Signed-off-by: Blue
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 39 +++
qemu-common.h |1 +
vl.c | 26 +++---
3 files changed, 47
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 34 ++
1 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/cutils.c b/cutils.c
index
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Octet format relies on strtobytes which supports K/k, M/m, G/g, T/t
suffixes and unit support for humans, like 1.3G
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
monitor.c | 27
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
migration.c |4 ++--
qemu-monitor.hx |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration.c b/migration.c
index
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
'f' double is no longer used, and we should be using floating point
variables to store byte sizes. Remove it.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
monitor.c | 17 +
1 files
Amit Shah amit.s...@redhat.com writes:
Document the parameters for the virtserialport and virtioconsole
devices.
Example:
$ ./x86_64-softmmu/qemu-system-x86_64 -device virtserialport,?
virtserialport.nr=uint32, The 'number' for the port for \
predictable port numbers. Use this to spawn
Amit Shah amit.s...@redhat.com writes:
Add a 'description' along with each qdev property to document the input
each qdev property takes.
[...]
diff --git a/hw/qdev.c b/hw/qdev.c
index 35858cb..b415025 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -188,7 +188,8 @@ int qdev_device_help(QemuOpts
Amit Shah amit.s...@redhat.com writes:
Hello,
This is a rebase of the patchset I'd sent earlier.
I add the 4/4 patch, documenting common block device properties.
Other than that, the usual notes apply: this is just the start, just
getting the framework in place and a few examples so that
Luiz Capitulino lcapitul...@redhat.com writes:
It's a generic version of monitor_find_command() which searches
the dispatch table passed as an argument.
Future commits will introduce new dispatch tables, so we need
common code to search them.
Signed-off-by: Luiz Capitulino
Luiz Capitulino lcapitul...@redhat.com writes:
Since its inception, QMP has been using HMP's do_info() function
to run query commands.
This was a bad choice, as it made do_info() more complex and
contributed to couple QMP and HMP.
This commit fixes that by doing the following changes:
Luiz Capitulino lcapitul...@redhat.com writes:
If I understood it correcty, the is_async_return() logic was only
used to prevent QMP from issuing duplicated success responses
for asynchronous handlers.
However, QMP doesn't use do_info() anymore so this is dead logic
and (hopefully) can be
Luiz Capitulino lcapitul...@redhat.com writes:
Also update QMP functions to use it. The table is generated
from the qemu-monitor-qmp.hx file.
From now on, QMP and HMP have different command dispatch
tables.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile.target |7
Anthony Liguori anth...@codemonkey.ws writes:
On 09/16/2010 03:20 PM, Luiz Capitulino wrote:
The subject says it all: with this series applied we'll get different
dispatch tables for HMP and QMP, which has the side effect of making
QMP commands (such as qmp_capabilities) disappear from HMP's
Luiz Capitulino lcapitul...@redhat.com writes:
On Wed, 29 Sep 2010 13:31:13 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
Also update QMP functions to use it. The table is generated
from the qemu-monitor-qmp.hx file.
From now on, QMP
Luiz Capitulino lcapitul...@redhat.com writes:
This is a respin with the following small changes:
v1 - v2:
o Renamed qemu-monitor-qmp.hx to qmp-commands.hx
o Added a new patch which renames qemu-monitor.hx to hmp-commands.hx
o Other minor changes
ACK
Stefan Weil w...@mail.berlios.de writes:
The patch fixes these gcc warnings:
./hw/es1370.c: In function ‘es1370_update_voices’:
./hw/es1370.c:411: error: format ‘%d’ expects type ‘int’, but argument 3 has
type ‘size_t’
./hw/es1370.c: In function ‘es1370_writel’:
./hw/es1370.c:579: error:
Scott Wood scottw...@freescale.com writes:
This fixes an observed failure to detect madvise() on Linux.
To avoid similar issues, all other tests that use NULL but don't already
have stddef.h are also fixed.
Appreciated, but several instances don't need fixing, because existing
includes
Paolo Bonzini pbonz...@redhat.com writes:
On 10/06/2010 11:32 PM, Blue Swirl wrote:
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
/src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not
used
Blue Swirl blauwir...@gmail.com writes:
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/block/qcow2-refcount.c: In function 'update_refcount':
/src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set
but not used [-Werror=unused-but-set-variable]
Fix by adding a
Blue Swirl blauwir...@gmail.com writes:
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/hw/eepro100.c: In function 'eepro100_read4':
/src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used
uninitialized in this function [-Werror=uninitialized]
/src/qemu/hw/eepro100.c: In
Blue Swirl blauwir...@gmail.com writes:
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-cris/op_helper.c: In function 'helper_movl_sreg_reg':
/src/qemu/target-cris/op_helper.c:145:8: error: variable 'tlb_v' set
but not used [-Werror=unused-but-set-variable]
In file
Paolo Bonzini pbonz...@redhat.com writes:
On 10/06/2010 11:33 PM, Blue Swirl wrote:
+#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL)
} else if (strncmp(options, acl, 3) == 0) {
acl = 1;
+#endif
Not sure it's okay to reject the option altogether (i.e. maybe
Paolo Bonzini pbonz...@redhat.com writes:
On 10/06/2010 11:34 PM, Blue Swirl wrote:
Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
/src/qemu/target-mips/translate.c: In function 'gen_ld':
/src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set
but not used
Alexander Graf ag...@suse.de writes:
On 06.10.2010, at 23:34, Blue Swirl wrote:
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':
/src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but
not used
We don't want pci_add in QMP. Use device_add instead.
This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949.
Conflicts:
hw/pci-hotplug.c
sysemu.h
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/pci-hotplug.c | 46
Luiz Capitulino lcapitul...@redhat.com writes:
On Mon, 26 Apr 2010 19:44:19 +0200
Markus Armbruster arm...@redhat.com wrote:
We don't want pci_add in QMP. Use device_add instead.
This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949.
Conflicts:
hw/pci-hotplug.c
Luiz Capitulino lcapitul...@redhat.com writes:
We need to expose errno in QMP, for three reasons:
1. Some error handling functions print errno codes to the user,
while it's debatable whether this is good or not from a user
perspective, sometimes it's the best we can do because
Luiz Capitulino lcapitul...@redhat.com writes:
One of the most important missing feature in QMP today is its
supported command documentation.
The plan is to make it part of self-description support, however
self-description is a big task we have been postponing for a
long time now and still
Anthony Liguori anth...@codemonkey.ws writes:
On 05/03/2010 04:29 AM, Markus Armbruster wrote:
[...]
Why am I proposing to remove pci_add from QMP before its replacement is
ready? I want it out sooner rather than later, because it isn't fully
functional (errors and drive_add are missing
Broken in commit 2313086a.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-monitor.hx |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index bf47ae0..220ed9c 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -611,6 +611,8
Commit f3546deb replaced host_net_redir by hostfwd_add,
hostfwd_remove, but neglected to update documentation.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-monitor.hx | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/qemu-monitor.hx b/qemu
Commit 15dfcd45 added acl_add and acl_reset, but fat-fingered their
documentation to read acl_allow and acl_remove.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-monitor.hx |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/qemu-monitor.hx b/qemu
Markus Armbruster (4):
doc: Fix host forwarding monitor command documentation
doc: Fix acl monitor command documentation
doc: Heading for monitor command cpu got lost, restore it
doc: Clean up monitor command function index
qemu-monitor.hx | 26 +-
1 files
Anthony, no reply from you; did it fall through the cracks? If you're
fine with my draft, I'll turn it into a proper patch.
Markus Armbruster arm...@redhat.com writes:
Anthony asked me to take a stab at rewriting his draft to something more
along the lines of what I'm thinking. Here goes
Rules for how to extend QMP downstream (if you really have to) without
creating interoparability hassles.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
Aside:
* Advice on downstream modifications, items 1. and 2. could use a
rationale.
* Section '5 Compatibility Considerations' could
Signed-off-by: Markus Armbruster arm...@redhat.com
---
v2: Clarify use of __RFQDN (Thanks, Luiz!)
QMP/qmp-spec.txt | 55 ++
1 files changed, 55 insertions(+), 0 deletions(-)
diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt
index f3c0327
Jan Kiszka jan.kis...@web.de writes:
Luiz,
I missed this when the API was first proposed:
cur_mon is scheduled for removal (one day...). It's just an intermediate
step to convert all users to explicit 'mon' passing. Thus, new APIs
should not rely it.
I just realized that
Jan Kiszka jan.kis...@web.de writes:
Markus Armbruster wrote:
Jan Kiszka jan.kis...@web.de writes:
Luiz,
I missed this when the API was first proposed:
cur_mon is scheduled for removal (one day...). It's just an intermediate
step to convert all users to explicit 'mon' passing. Thus, new
Jan Kiszka jan.kis...@web.de writes:
Markus Armbruster wrote:
Jan Kiszka jan.kis...@web.de writes:
Markus Armbruster wrote:
Jan Kiszka jan.kis...@web.de writes:
Luiz,
I missed this when the API was first proposed:
cur_mon is scheduled for removal (one day...). It's just
Anthony Liguori anth...@codemonkey.ws writes:
On 05/03/2010 08:06 AM, Markus Armbruster wrote:
Luiz Capitulinolcapitul...@redhat.com writes:
We need to expose errno in QMP, for three reasons:
1. Some error handling functions print errno codes to the user,
while it's
Luiz Capitulino lcapitul...@redhat.com writes:
On Tue, 04 May 2010 16:56:19 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 05/04/2010 03:30 PM, Luiz Capitulino wrote:
StateVmSaveFailed is not like CommandFailed, there are five errors
in do_savevm() and StateVmSaveFailed happens
Anthony Liguori anth...@codemonkey.ws writes:
On 04/21/2010 03:28 AM, Daniel P. Berrange wrote:
On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote:
[...]
Wouldn't it be nicer to return strerror_r() output instead of errno
names ?
Both are equally wrong :-)
QMP should
Blue Swirl blauwir...@gmail.com writes:
On 5/9/10, chen huacai zltjiang...@gmail.com wrote:
This patch add initial support of VIA IDE controller used by fulong mini pc
Signed-off-by: Huacai Chen zltjiang...@gmail.com
-
[...]
diff --git a/hw/ide/via.c b/hw/ide/via.c
new file mode
Alex Williamson alex.william...@redhat.com writes:
If the init function of a device fails, as might happen with device
assignment, we never undo the work done by do_pci_register_device().
This not only causes a bit of a memory leak, but also leaves a bogus
pointer in the bus devices array
Juan Quintela quint...@redhat.com writes:
This variable contains the objects shared between tools and qemu binary.
Add qemu-error.o only in one place, it could be built in two places
depending of make ordering.
Yup, that's what I should've done when I added qemu-error.c.
Commit 6616b2ad reverted commit 40ea285c. Looks like a mismerge to
me.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
v2: rebased (v1 fell through the cracks apparently)
qemu-options.hx | 15 ++-
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/qemu
Kevin Wolf kw...@redhat.com writes:
Am 11.05.2010 13:13, schrieb Juan Quintela:
This variable contains the objects shared between tools and qemu binary.
Add qemu-error.o only in one place, it could be built in two places
depending of make ordering.
Signed-off-by: Juan Quintela
Empty file used to create an empty drive (no media). Since commit
9dfd7c7a, it's an error: qemu: could not open disk image : No such
file or directory. Older versions of libvirt can choke on this.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
If this goes in, I'll prepare a patch
Blue Swirl blauwir...@gmail.com writes:
On 5/11/10, Markus Armbruster arm...@redhat.com wrote:
Blue Swirl blauwir...@gmail.com writes:
On 5/9/10, chen huacai zltjiang...@gmail.com wrote:
This patch add initial support of VIA IDE controller used by fulong mini
pc
Signed-off
See PATCH 1/1 for rationale.
v2: Cover pci_del, better commit message, rebased (no conflicts)
Markus Armbruster (2):
Revert PCI: Convert pci_device_hot_add() to QObject
Revert monitor: Convert do_pci_device_hot_remove() to QObject
hw/pci-hotplug.c | 51
We don't want pci_del in QMP. Use device_del instead.
This reverts commit 6848d827162fea039f2658414a4adb6164a4f9b0.
Conflicts:
hw/pci-hotplug.c
sysemu.h
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/pci-hotplug.c |5 ++---
qemu-monitor.hx |3 +--
sysemu.h
-hotplug.c
sysemu.h
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/pci-hotplug.c | 46 +-
qemu-monitor.hx |3 +--
sysemu.h |3 +--
3 files changed, 7 insertions(+), 45 deletions(-)
diff --git a/hw/pci-hotplug.c b/hw
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes:
The info blockstats documentation was copy-pasted as info block
instead of info blockstats. The documentation for info qdm and
info roms is missing. This patch resolves these issues in
qemu-monitor.hx.
Signed-off-by: Stefan Hajnoczi
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes:
The info blockstats documentation was copy-pasted as info block
instead of info blockstats. The documentation for commands, jit,
numa, qdm, and roms is missing. This patch resolves these issues
in qemu-monitor.hx.
Looks good, thanks!
Luiz Capitulino lcapitul...@redhat.com writes:
One of the most important missing feature in QMP today is its
supported commands documentation.
The plan is to make it part of self-description support, however
self-description is a big task we have been postponing for a
long time now and
Luiz Capitulino lcapitul...@redhat.com writes:
On Wed, 12 May 2010 18:48:38 +0200
Markus Armbruster arm...@redhat.com wrote:
+query-block
+---
+
+Show the block devices.
+
+Each block device information is stored in a json-object and the returned
value
+is a json-array
Luiz Capitulino lcapitul...@redhat.com writes:
On Thu, 13 May 2010 19:23:11 +0300
Avi Kivity a...@redhat.com wrote:
On 05/13/2010 06:01 PM, Daniel P. Berrange wrote:
Yes, we do and it's used by libvirt iirc.
This command has been in QEMU for quite a long time now (0.9.x IIRC).
Luiz Capitulino lcapitul...@redhat.com writes:
On Thu, 13 May 2010 16:48:13 +0300
Avi Kivity a...@redhat.com wrote:
On 05/05/2010 10:11 PM, Luiz Capitulino wrote:
One of the most important missing feature in QMP today is its
supported commands documentation.
The plan is to make it
Avi Kivity a...@redhat.com writes:
On 05/05/2010 10:11 PM, Luiz Capitulino wrote:
One of the most important missing feature in QMP today is its
supported commands documentation.
The plan is to make it part of self-description support, however
self-description is a big task we have been
Avi, thanks a lot for reviewing this!
Christoph Hellwig h...@lst.de writes:
[...]
Markus was looking into separating the block device state in host/
guest portions lately, and splitting cache= would help with this.
Driver cache enabled or not (fsync means enabled, O_DSYNC disabled,
and none probably disabled given that we don't
Daniel P. Berrange berra...@redhat.com writes:
On Thu, May 13, 2010 at 10:32:52AM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Add -version-simple argument for QEMU, printing just the version
number, without any supporting text.
This makes it simpler
Luiz Capitulino lcapitul...@redhat.com writes:
Hi there,
Miguel is working on converting 'info network' to QMP, but turns out that
it's
been quite difficult to maintain the exact same output.
The main problem seems to be the usage of the 'info_str' string, which some
drivers (like
Daniel P. Berrange berra...@redhat.com writes:
On Fri, May 14, 2010 at 11:42:57AM +0200, Markus Armbruster wrote:
Daniel P. Berrange berra...@redhat.com writes:
[...]
It would also be nice to avoid having to parse the -help output to
determine
ARGV supported too. I wonder if it would
Anthony Liguori aligu...@linux.vnet.ibm.com writes:
Can we do this all via the monitor? IOW, can libvirt invoke qemu
blindly and strictly interact with the monitor?
I think that's exactly where should be heading longer term. It's not a
practical immediate solution, e.g. because device_add
Avi Kivity a...@redhat.com writes:
On 05/14/2010 11:33 AM, Markus Armbruster wrote:
And we absolutely need to make use of that license to improve stuff.
Premature stability leads to stable crap. Having to get everything
right the first time is just too hard for mortals
Avi Kivity a...@redhat.com writes:
On 05/14/2010 11:50 AM, Markus Armbruster wrote:
+
+{ execute: migrate_set_speed, arguments: { value: 1024 } }
Oh, we do have more.
Please document the units for this value (bits per second)?
bytes per second?
Bandwidth
Avi Kivity a...@redhat.com writes:
On 05/14/2010 08:03 PM, Markus Armbruster wrote:
Avi Kivitya...@redhat.com writes:
On 05/14/2010 11:50 AM, Markus Armbruster wrote:
[...]
We have a list of buses, each containing a list of device functions.
Not sure the additional level of nesting
Avi Kivity a...@redhat.com writes:
On 05/15/2010 01:54 AM, Luiz Capitulino wrote:
On Fri, 14 May 2010 19:03:36 +0200
Markus Armbrusterarm...@redhat.com wrote:
What about PCI domains?
Good point. Better to provide for them neatly now, instead of kludging
them in later.
Would you mind sending patch series with proper References: headers, so
that the parts of the series are properly threaded?
You can ask either git-format-patch or git-send-email to add them.
Blue Swirl blauwir...@gmail.com writes:
On 5/16/10, Stefan Weil w...@mail.berlios.de wrote:
Am 15.05.2010 22:49, schrieb Blue Swirl:
Hi,
With this mingw32 compiler:
$ i586-mingw32msvc-gcc -v
Using built-in specs.
Target: i586-mingw32msvc
Configured with:
[...]
build will not
Avi Kivity a...@redhat.com writes:
On 05/17/2010 11:27 AM, Markus Armbruster wrote:
A slot is the hotpluggable entity. Open your computer and you can
actually see them.
QEMU doesn't really know that.
How can that be? Do we signal hotplug notifications
Blue Swirl blauwir...@gmail.com writes:
Thanks, applied all.
Thanks indeed! 13 versions and I-don't-remember-how-many months, must
have taxed your patience.
Blue Swirl blauwir...@gmail.com writes:
On 5/17/10, Markus Armbruster arm...@redhat.com wrote:
Blue Swirl blauwir...@gmail.com writes:
On 5/16/10, Stefan Weil w...@mail.berlios.de wrote:
Am 15.05.2010 22:49, schrieb Blue Swirl:
Hi,
With this mingw32 compiler
Blue Swirl blauwir...@gmail.com writes:
Signed-off-by: Blue Swirl blauwir...@gmail.com
---
audio/audio_template.h |2 +-
block/curl.c|9 ---
block/parallels.c |7 -
block/qcow2.c |8 --
darwin-user/commpage.c |2 +-
Anthony Liguori anth...@codemonkey.ws writes:
On 05/15/2010 01:19 AM, Avi Kivity wrote:
On 05/15/2010 01:54 AM, Luiz Capitulino wrote:
On Fri, 14 May 2010 19:03:36 +0200
Markus Armbrusterarm...@redhat.com wrote:
What about PCI domains?
Good point. Better to provide for them neatly now,
Jan Kiszka jan.kis...@web.de writes:
Luiz Capitulino wrote:
On Fri, 14 May 2010 19:08:07 +0200
Jan Kiszka jan.kis...@siemens.com wrote:
Avi Kivity wrote:
On 05/14/2010 08:01 PM, Avi Kivity wrote:
On 05/14/2010 07:52 PM, Jan Kiszka wrote:
In order not to compromise QMP adoption and make
Jan Kiszka jan.kis...@siemens.com writes:
This introduces device_show, a monitor command that saves the vmstate of
a qdev device and visualizes it. QMP is also supported. Buffers are cut
after 16 byte by default, but the full content can be requested via
'-f'. To pretty-print sub-arrays,
Jan Kiszka jan.kis...@siemens.com writes:
Avi Kivity wrote:
On 05/17/2010 10:57 AM, Jan Kiszka wrote:
Avi Kivity wrote:
On 05/17/2010 10:40 AM, Jan Kiszka wrote:
The alternative is to have a schema. Sun RPC/XDR doesn't carry any type
information (you can't even distinguish
Gerd Hoffmann kra...@redhat.com writes:
On 05/18/10 14:33, Markus Armbruster wrote:
Gerd Hoffmannkra...@redhat.com writes:
Try to pci hotplug a vga card, watch qemu die with hw_error().
This patch fixes it.
Looks good.
Are there any other hot-pluggable devices that acquire single-use
Daniel P. Berrange berra...@redhat.com writes:
On Tue, May 18, 2010 at 09:34:06AM -0500, Anthony Liguori wrote:
On 05/18/2010 09:09 AM, Daniel P. Berrange wrote:
On Tue, May 18, 2010 at 08:53:19AM -0500, Anthony Liguori wrote:
On 05/17/2010 10:23 PM, Chris Wright wrote:
Please
Markus Armbruster arm...@redhat.com writes:
[...]
- set_link
Patch posted weeks ago, still not merged.
Correction: it got merged weeks ago, as commit 5369e3c0. I got
confused.
[...]
I had a look at the first few, and they're all fine. Thanks!
David S. Ahern daah...@cisco.com writes:
On 05/19/2010 12:10 PM, Shahar Havivi wrote:
When closig Vm or removing usb on guest via usb_del monitor command,
qemu does not return the control to the host, the user have to
unplug and plug the device in order to use it on the host.
v2:
added
Luiz Capitulino lcapitul...@redhat.com writes:
Previous commit added the QMP/qmp-commands.txt file, which is a
copy of this information.
This is no longer true.
While it's good to keep it near code, maintaining two copies of
the same information is too hard and has little benefit as we
David S. Ahern daah...@cisco.com writes:
On 05/21/2010 1:33 AM, Markus Armbruster wrote:
Note: usbdevice_init() is not for general initialization, just for
dealing with the legacy -usbdevice command line.
Perhaps the comment before usbdevice_create is misleading or has some
conversion
Gerd Hoffmann kra...@redhat.com writes:
On 05/24/10 14:32, Paul Brook wrote:
+int is_ioport_assigned(pio_addr_t addr)
Shouldn't we move this into register_ioport_{read,write}, and have that fail
if the port has already been assigned?
It already checks and fails with hw_error(). Problem
Kevin Wolf kw...@redhat.com writes:
scanf calls must not use PRI constants, they have probably the wrong size and
corrupt memory. We could replace them by SCN ones, but strtol is simpler than
scanf here anyway. While at it, also fix the parsers to reject garbage after
the number (4096xyz was
Anthony Liguori anth...@codemonkey.ws writes:
On 05/26/2010 10:51 AM, Alexander Graf wrote:
Usually the guest can tell the host to flush data to disk. In some cases we
don't want to flush though, but try to keep everything in cache.
So let's add a new cache value to -drive that allows us to
Alex Williamson alex.william...@redhat.com writes:
Move to monitor.c:monitor_handle_fd_param() as a common helper.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
I'd like to use this for the proposed device assignment configfd
parameter since there's nothing net specific
Amit Shah amit.s...@redhat.com writes:
Add a 'description' along with each qdev property to document the input
each qdev property takes.
Signed-off-by: Amit Shah amit.s...@redhat.com
I always wanted this, and never got around to code it up. Thanks!
[...]
diff --git a/block_int.h
Amit Shah amit.s...@redhat.com writes:
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 17 ++---
hw/virtio-serial.h | 12
2 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index
Amit Shah amit.s...@redhat.com writes:
Signed-off-by: Amit Shah amit.s...@redhat.com
---
net.h | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/net.h b/net.h
index 0e9cc5d..8ad439a 100644
--- a/net.h
+++ b/net.h
@@ -20,10 +20,17 @@ typedef struct
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/qdev-properties.c |5 +
hw/qdev.h|1 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 9ffdba7..b6ee50f 100644
--- a/hw/qdev-properties.c
+++ b/hw
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/ide/cmd646.c |4 ++--
hw/ide/core.c | 30 ++
hw/ide/internal.h |5 +++--
hw/ide/isa.c|2 +-
hw/ide/macio.c |2 +-
hw/ide/microdrive.c |3 ++-
hw/ide/mmio.c
801 - 900 of 27531 matches
Mail list logo
