[Qemu-devel] [PATCH 048/108] qcow1: Validate image size (CVE-2014-0223)

2014-08-06 Thread Michael Roth
cesses (both reads and writes). Cc: qemu-sta...@nongnu.org Signed-off-by: Kevin Wolf (cherry picked from commit 46485de0cb357b57373e1ca895adedf1f3ed46ec) Signed-off-by: Michael Roth --- block/qcow.c | 16 ++-- tests/qemu-iotests/092 | 9 + tests/qemu-iotests/0

[Qemu-devel] [PATCH 079/108] virtio-scsi: define dummy handle_output for vhost-scsi vqs

2014-08-06 Thread Michael Roth
Signed-off-by: Ming Lei Signed-off-by: Paolo Bonzini (cherry picked from commit 91d670fbf9945ca4ecbd123affb36889e7fe8a5d) Signed-off-by: Michael Roth --- hw/scsi/vhost-scsi.c| 8 +++- hw/scsi/virtio-scsi.c | 14 +- include/hw/virtio/virtio-scsi.h | 7 ++- 3

[Qemu-devel] [PATCH 049/108] qcow1: Stricter backing file length check

2014-08-06 Thread Michael Roth
d-off-by: Kevin Wolf Reviewed-by: Benoit Canet (cherry picked from commit d66e5cee002c471b78139228a4e7012736b375f9) Signed-off-by: Michael Roth --- block/qcow.c | 7 +-- tests/qemu-iotests/092 | 11 +++ tests/qemu-iotests/092.out | 7 +++ 3 files change

[Qemu-devel] [PATCH 076/108] qdev: recursively unrealize devices when unrealizing bus

2014-08-06 Thread Michael Roth
el S. Tsirkin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Andreas Färber (cherry picked from commit 5942a19040fed313b316ab7b6e3d2d8e7b1625bb) Signed-off-by: Michael Roth --- hw/core/qdev.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 050/108] virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path

2014-08-06 Thread Michael Roth
From: Markus Armbruster Spotted by Coverity. Signed-off-by: Markus Armbruster Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini (cherry picked from commit 91e7fcca4743cf694eb0c8e7a8d938cf359b5bd8) Signed-off-by: Michael Roth --- hw/scsi/virtio-scsi.c | 3 ++- 1 file changed, 2

[Qemu-devel] [PATCH 082/108] q35: Use PC_Q35_COMPAT_1_4 on pc-q35-1.4 compat_props

2014-08-06 Thread Michael Roth
introduced in QEMU 2.0, by commit 7a10ef51c2397ac4323bc786af02c58b413b5cd2). Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Markus Armbruster (cherry picked from commit 48cb7f3c1526b4632bd63d945cac80d26616d6f5) Signed-off-by: Michael

[Qemu-devel] [PATCH 080/108] usb: Fix usb-bt-dongle initialization.

2014-08-06 Thread Michael Roth
c340a284f382a5f40774521f41b4bade76ddfa58) Signed-off-by: Michael Roth --- hw/usb/dev-bluetooth.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-bluetooth.c b/hw/usb/dev-bluetooth.c index a9661d2..a76e581 100644 --- a/hw/usb/dev-bluetooth.c +++ b/hw/usb/dev-bluetooth.c @@ -19,6

[Qemu-devel] [PATCH 055/108] block/sheepdog: Plug memory leak in sd_snapshot_create()

2014-08-06 Thread Michael Roth
From: Markus Armbruster Has always been leaky. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit 2df5fee2dbd56a9c34afd6d7df6744da2d951ccb) Signed-off-by: Michael Roth --- block/sheepdog.c | 4 ++-- 1 file

[Qemu-devel] [PATCH 053/108] input (curses): mask keycodes to remove modifier bits

2014-08-06 Thread Michael Roth
f5c0ab131265270c1e7852ec0d4e284a219d63d4) Signed-off-by: Michael Roth --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index b044790..de85f76 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -288,8 +288,8 @@ static void curses_refresh(DisplayChangeListener *dcl

[Qemu-devel] [PATCH 058/108] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR

2014-08-06 Thread Michael Roth
From: Markus Armbruster Introduced in commit a8d8ecb. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit f25391c2a6ef1674384204265429520ea50e82bc) Signed-off-by: Michael Roth --- block/qapi.c | 1 + 1 file

[Qemu-devel] [PATCH 091/108] nbd: Close socket on negotiation failure.

2014-08-06 Thread Michael Roth
From: Hani Benhabiles Otherwise, the nbd client may hang waiting for the server response. Signed-off-by: Hani Benhabiles Acked-by: Paolo Bonzini Signed-off-by: Michael Tokarev (cherry picked from commit 36af599417dde11747a27dc8550ff2281657a8ff) Signed-off-by: Michael Roth --- blockdev

[Qemu-devel] [PATCH 054/108] qemu-img: Plug memory leak in convert command

2014-08-06 Thread Michael Roth
From: Markus Armbruster Introduced in commit 661a0f7. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit bb9cd2ee99f6537c072d5f4bac441717d3cd2bed) Signed-off-by: Michael Roth --- qemu-img.c | 2 +- 1 file

[Qemu-devel] [PATCH 084/108] hw/xtensa/xtfpga: fix FLASH mapping to boot region for KC705

2014-08-06 Thread Michael Roth
From: Max Filippov On KC705 bootloader area is located at FLASH offset 0x0600, not 0 as on older xtfpga boards. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Filippov (cherry picked from commit 37ed7c4b24f265c2a8c7248666544c9755514ec2) Signed-off-by: Michael Roth --- hw/xtensa

[Qemu-devel] [PATCH 060/108] blockdev: Plug memory leak in blockdev_init()

2014-08-06 Thread Michael Roth
) Signed-off-by: Michael Roth --- blockdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index fbfdc27..b0ce4f0 100644 --- a/blockdev.c +++ b/blockdev.c @@ -332,7 +332,7 @@ static DriveInfo *blockdev_init(const char *file, QDict *bs_opts

[Qemu-devel] [PATCH 056/108] block/vvfat: Plug memory leak in read_directory()

2014-08-06 Thread Michael Roth
From: Markus Armbruster Has always been leaky. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit b122c3b6d020e529b203836efb8f611ece787293) Signed-off-by: Michael Roth --- block/vvfat.c | 4 +++- 1 file

[Qemu-devel] [PATCH 093/108] SMBIOS: Rename symbols to better reflect future use

2014-08-06 Thread Michael Roth
al changes. Signed-off-by: Gabriel Somlo Signed-off-by: Gerd Hoffmann (cherry picked from commit e6667f719caa7b5edcb491f61a7744f6a6affd27) Conflicts: hw/i386/pc_piix.c hw/i386/pc_q35.c *removed dependency on 3458b2b0 Signed-off-by: Michael Roth --- hw/i386/pc.c |

[Qemu-devel] [PATCH 098/108] virtio: validate config_len on load

2014-08-06 Thread Michael Roth
ed-off-by: Michael S. Tsirkin Signed-off-by: Juan Quintela -- v2: use %ix and %zx to print config_len values Signed-off-by: Juan Quintela (cherry picked from commit a890a2f9137ac3cf5b607649e66a6f3a5512d8dc) Signed-off-by: Michael Roth --- hw/virtio/virtio.c | 8 +++- 1 file changed, 7 inser

[Qemu-devel] [PATCH 059/108] blockdev: Plug memory leak in drive_init()

2014-08-06 Thread Michael Roth
otted by Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf (cherry picked from commit 3cb0e25c4b417b7336816bd92de458f0770d49ff) Signed-off-by: Michael Roth --- blockdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5dd01ea..fbfdc27 1

[Qemu-devel] [PATCH 081/108] KVM: Fix GSI number space limit

2014-08-06 Thread Michael Roth
Signed-off-by: Michael Roth --- kvm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kvm-all.c b/kvm-all.c index 82a9119..cd61496 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -948,7 +948,7 @@ void kvm_init_irq_routing(KVMState *s) { int gsi_count, i; -

[Qemu-devel] [PATCH 063/108] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths

2014-08-06 Thread Michael Roth
From: Markus Armbruster Introduced in commit 5a8a30d. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit a1904e48c4a9fb114d155419700bfb7d760273b9) Signed-off-by: Michael Roth --- block/qcow2.c | 3 +-- 1

[Qemu-devel] [PATCH 073/108] rdma: bug fixes

2014-08-06 Thread Michael Roth
frank.yang...@gmail.com Reported-by: dgilb...@redhat.com Signed-off-by: Michael R. Hines Signed-off-by: Juan Quintela (cherry picked from commit e325b49a320b493cc5d69e263751ff716dc458fe) Signed-off-by: Michael Roth --- migration-rdma.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[Qemu-devel] [PATCH 067/108] s390x/css: handle emw correctly for tsch

2014-08-06 Thread Michael Roth
Tested-by: Christian Borntraeger Signed-off-by: Cornelia Huck (cherry picked from commit f068d320def7fd83bf0fcdca37b305f1c2ac5413) Signed-off-by: Michael Roth --- hw/s390x/css.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x

[Qemu-devel] [PATCH 086/108] target-i386: Filter FEAT_7_0_EBX TCG features too

2014-08-06 Thread Michael Roth
Färber (cherry picked from commit d0a70f46fa9a3257089a56f2f620b0eff868557f) Signed-off-by: Michael Roth --- target-i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index d386592..37abcaa 100644 --- a/target-i386/cpu.c +++ b/target

[Qemu-devel] [PATCH 100/108] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space()

2014-08-06 Thread Michael Roth
roduce helper to retrieve a PCI device's DMA address space Cc: qemu-sta...@nongnu.org Signed-off-by: Le Tan Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit efc8188e9398e54567b238b756eec2cc746cd2a4) Signed-off-by: Michael Roth --- hw/pci/pci.

[Qemu-devel] [PATCH 068/108] aio: fix qemu_bh_schedule() bh->ctx race condition

2014-08-06 Thread Michael Roth
ion if the callback frees the BH before aio_notify(bh->ctx) has a chance to run. Reported-by: Stefan Priebe Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Tested-by: Stefan Priebe (cherry picked from commit 924fe1293c3e7a3c787bbdfb351e7f168caee3e9) Signed-off-by: Michael Roth ---

[Qemu-devel] [PATCH 085/108] target-i386: Make TCG feature filtering more readable

2014-08-06 Thread Michael Roth
a42d9938a162c3e3c9e441d1927dca5bd59167d9) Conflicts: target-i386/cpu.c *removed dependency on 77549a78 Signed-off-by: Michael Roth --- target-i386/cpu.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 553d0b8..d386592 100644 --- a

[Qemu-devel] [PATCH 108/108] hw/arm/boot: Set PC correctly when loading AArch64 ELF files

2014-08-06 Thread Michael Roth
: Christopher Covington Signed-off-by: Peter Maydell Tested-by: Christopher Covington Cc: qemu-sta...@nongnu.org (cherry picked from commit a9047ec3f6ab56295cba5b07e0d46cded9e2a7ff) Signed-off-by: Michael Roth --- hw/arm/boot.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 002/108] hw/net/stellaris_enet: Correct handling of packet padding

2014-08-06 Thread Michael Roth
ff-by: Peter Maydell Reviewed-by: Dr. David Alan Gilbert Cc: qemu-sta...@nongnu.org (cherry picked from commit 7fd5f064d1c1a827a95ffe678418b3d5b8d2f108) Signed-off-by: Michael Roth --- hw/net/stellaris_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/stellaris_enet.c

[Qemu-devel] [PATCH 071/108] arch_init: Be sure of only one exit entry with DPRINTF() for ram_load()

2014-08-06 Thread Michael Roth
y picked from commit 4798fe55c4d539ddf8c7f5befcddfa145b3c6102) Signed-off-by: Michael Roth --- arch_init.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 85c6d6e..9aeb2b5 100644 --- a/arch_init.c +++ b/arch_init.c @@ -998,7 +998,8 @@ static i

[Qemu-devel] [PATCH 106/108] vmstate_xhci_event: fix unterminated field list

2014-08-06 Thread Michael Roth
: Amit Shah Reviewed-by: Paolo Bonzini Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Maydell (cherry picked from commit 3afca1d6d413592c2b78cf28f52fa24a586d8f56) Signed-off-by: Michael Roth --- hw/usb/hcd-xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/

[Qemu-devel] [PATCH 103/108] s390x/kvm: synchronize guest floating point registers

2014-08-06 Thread Michael Roth
e patch to latest upstream] Cc: qemu-sta...@nongnu.org Reviewed-by: Alexander Graf Signed-off-by: Cornelia Huck (cherry picked from commit 85ad6230b3af048109b3e949ca95ade4dd9a0bfa) Signed-off-by: Michael Roth --- target-s390x/kvm.c | 23 +++ 1 file changed, 23 insertions(+) di

[Qemu-devel] [PATCH 092/108] nbd: Shutdown socket before closing.

2014-08-06 Thread Michael Roth
27e5eae4577316f7e86a56eb7363d4e78f79e3e5) Signed-off-by: Michael Roth --- blockdev-nbd.c | 1 + qemu-nbd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 18dc528..b3a2474 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -28,6 +28,7 @@ static void nbd_accept(void

[Qemu-devel] [PATCH 078/108] vhost: fix resource leak in error handling

2014-08-06 Thread Michael Roth
From: "Michael S. Tsirkin" vhost_verify_ring_mappings leaks mappings on error. Fix this up. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin (cherry picked from commit 8617343faae6ba7e916137c6c9e3ef22c00565d8) Signed-off-by: Michael Roth --- hw/virtio/vhost.c | 10 +++

[Qemu-devel] [PATCH 102/108] disas/libvixl: prepend the include path of libvixl header files

2014-08-06 Thread Michael Roth
y picked from commit 834fb1b269f4c9eb0ffc058fd6ab5a018c3bce1f) *added 2.0-specific fixup from Stefano in disas/Makefile.obj due to lack of 849d8284 Signed-off-by: Michael Roth --- disas/Makefile.objs | 2 +- disas/libvixl/Makefile.objs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 096/108] hw: Fix qemu_allocate_irqs() leaks

2014-08-06 Thread Michael Roth
to instance in sh4/sh7750.c ] Signed-off-by: Peter Crosthwaite Reviewed-by: Kirill Batuzov [AF: Fix IRQ index in sh4/sh7750.c] Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber (cherry picked from commit f3c7d0389fe8a2792fd4c1cf151b885de03c8f62) Signed-off-by: Michael Roth --- hw/arm

[Qemu-devel] [PATCH 077/108] scsi-disk: fix bug in scsi_block_new_request() introduced by commit 137745c

2014-08-06 Thread Michael Roth
SG_IO. Cc: qemu-sta...@nongnu.org Signed-off-by: Ulrich Obergfell Signed-off-by: Paolo Bonzini (cherry picked from commit 2fe5a9f73b3446690db2cae8a58473b0b4beaa32) Signed-off-by: Michael Roth --- hw/scsi/scsi-disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/scsi-d

[Qemu-devel] [PATCH 097/108] virtio: out-of-bounds buffer write on invalid state load

2014-08-06 Thread Michael Roth
of vqs has size VIRTIO_PCI_QUEUE_MAX, so on invalid input this will write beyond end of buffer. Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael Roth Signed-off-by: Juan Quintela (cherry picked from commit cc45995294b92d95319b4782750a3580cabdbc0c) Signed-off-by: Michael Roth --- hw/vir

[Qemu-devel] [PATCH 083/108] coroutine-win32.c: Add noinline attribute to work around gcc bug

2014-08-06 Thread Michael Roth
by: Peter Maydell Message-id: 1403535303-14939-1-git-send-email-peter.mayd...@linaro.org Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson (cherry picked from commit ff4873cb8c81db89668d8b56e19e57b852edb5f5) Signed-off-by: Michael Roth --- coroutine-win32.c | 13 +++-- 1 file

[Qemu-devel] [PATCH 099/108] Allow mismatched virtio config-len

2014-08-06 Thread Michael Roth
ilbert Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit 2f5732e9648fcddc8759a8fd25c0b41a38352be6) Signed-off-by: Michael Roth --- hw/virtio/virtio.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/virtio/virtio.c b/hw

[Qemu-devel] [PATCH 088/108] virtio-serial: don't migrate the config space

2014-08-06 Thread Michael Roth
B and commit message, Greg Kurz ] Reviewed-by: Michael S. Tsirkin Signed-off-by: Greg Kurz Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit e38e943a1fa20d04deb1899be19b12aadec7a585) Signed-off-by: Michael Roth --- hw/char/virtio-serial-bus.c

[Qemu-devel] [PATCH 087/108] virtio-net: byteswap virtio-net header

2014-08-06 Thread Michael Roth
hypervisor. Signed-off-by: Cédric Le Goater [ Ported from PowerKVM, Greg Kurz ] Signed-off-by: Greg Kurz Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611) Signed-off-by: Michael Roth --- hw/net/virtio-net.c | 17

[Qemu-devel] [PATCH 089/108] nbd: Don't export a block device with no medium.

2014-08-06 Thread Michael Roth
olo Bonzini (cherry picked from commit 60fe4fac22895576973e317d7148b084c31cc64c) Signed-off-by: Michael Roth --- blockdev-nbd.c | 4 1 file changed, 4 insertions(+) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 922cf56..a700d52 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@

[Qemu-devel] [PATCH 074/108] hw: Consistently name Error ** objects errp, and not err

2014-08-06 Thread Michael Roth
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Andreas Färber (cherry picked from commit a7737e4496aa3c1c8c3a4b4b9d5e44875fe21e12) Signed-off-by: Michael Roth --- hw/core/qdev.c | 20 ++-- hw/intc/i8259.c | 4 ++-- hw/timer/i8254.c | 4 ++-- 3

[Qemu-devel] [PATCH 090/108] nbd: Don't validate from and len in NBD_CMD_DISC.

2014-08-06 Thread Michael Roth
ommit 8c5d1abbb79193dca8e4823ef53d8d1e650362ae) Signed-off-by: Michael Roth --- nbd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/nbd.c b/nbd.c index e5084b6..e335d3a 100644 --- a/nbd.c +++ b/nbd.c @@ -1001,6 +1001,7 @@ static void nbd_trip(void *opaque) struct nbd_request re

[Qemu-devel] [PATCH 094/108] pc: make isapc and pc-0.10 to pc-0.13 have 1.7.0 memory layout

2014-08-06 Thread Michael Roth
icked from commit 5f8632d3c3d7bc5ef24166ba7cf90fcfb2adbf7d) Conflicts: hw/i386/pc_piix.c *removed dependency on c97294ec: smbios_legacy_mode always true pre-2.1.0 *removed dependency on de268e13: has_reserved_memory always false pre-2.1.0 Signed-off-by: Michael Roth --- hw/i386/pc_piix.c | 6

[Qemu-devel] [PATCH 104/108] cadence_uart: check for serial backend before using it.

2014-08-06 Thread Michael Roth
From: KONRAD Frederic This checks that s->chr is not NULL before using it. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Crosthwaite Signed-off-by: Peter Maydell (cherry picked from commit af52fe862fba686713044efdf9158195f84535ab) Signed-off-by: Michael Roth --- hw/char/cadence_uar

[Qemu-devel] [PATCH 095/108] sdhci: Fix misuse of qemu_free_irqs()

2014-08-06 Thread Michael Roth
ed-off-by: Michael Roth --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 843e697..32f2d0f 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1184,8 +1184,8 @@ static void sdhci_uninitfn(Object *obj) timer_free(s->

[Qemu-devel] [PATCH 105/108] kvm-all: Use 'tmpcpu' instead of 'cpu' in sub-looping to avoid 'cpu' be NULL

2014-08-06 Thread Michael Roth
7; must never be NULL, so need define additional temporary variable for 'cpu' to avoid the case. Cc: qemu-sta...@nongnu.org Signed-off-by: Chen Gang Signed-off-by: Paolo Bonzini (cherry picked from commit dc54e2525389e903cee2b847cf761b5d857f75cb) Signed-off-by: Michael Roth ---

[Qemu-devel] [PATCH 107/108] hw/misc/imx_ccm.c: Add missing VMState list terminator

2014-08-06 Thread Michael Roth
x27;) Signed-off-by: Peter Maydell Cc: qemu-sta...@nongnu.org (cherry picked from commit ef493d5c291e4689d64ff4973915a7442109a5c5) Signed-off-by: Michael Roth --- hw/misc/imx_ccm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index 63e33a4..449183d

[Qemu-devel] [PATCH 101/108] mc146818rtc: register the clock reset notifier on the right clock

2014-08-06 Thread Michael Roth
not sign off on his. Cc: qemu-sta...@nongnu.org Reported-by: Lb peace Signed-off-by: Paolo Bonzini (cherry picked from commit 13c0cbaec5698f3984606e52bfcfb63ddfc29f00) Signed-off-by: Michael Roth --- hw/timer/mc146818rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw

Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

2014-08-07 Thread Michael Roth
Quoting Eric Blake (2014-08-06 16:49:50) > On 08/06/2014 02:38 PM, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v2.0.1: > > > > https://github.com/mdroth/qemu/commits/stable-2.0-staging > > &g

Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

2014-08-07 Thread Michael Roth
Quoting Eric Blake (2014-08-07 10:50:41) > On 08/07/2014 03:19 AM, Michael Roth wrote: > >> > >> Libvirt could support active commit against qemu 2.0.1 if you backport > >> these patches: > >> > >> Jeff Cody > >> 7676e2c597 block: make &#

Re: [Qemu-devel] [RESEND PATCH v5 0/3] qga: Add guest-fsfreeze-freeze-list command

2014-08-07 Thread Michael Roth
Quoting Tomoki Sekiyama (2014-06-30 16:51:21) > Hi, > > As patch 3/3 was missing in the last post, I'm resending this patchset. > > === > This is v5 patch for qemu-ga to add functions to freeze specific file systems > mounted in a guest. > > Changes since v4: > - PATCH 2: fix coding styles (spa

[Qemu-devel] [PULL 0/3] qga: support fsfreeze'ing specific mounts

2014-08-07 Thread Michael Roth
Hello, Please pull the following changes, which add a new guest-fsfreeze-freeze-list command to qemu-ga that supports specifying specific mounts to freeze, and improves the introspection information from guest-info by explicitly blacklisting/reporting commands that aren't supported on a particular

[Qemu-devel] [PATCH 3/3] qga: Disable unsupported commands by default

2014-08-07 Thread Michael Roth
supported from 'enabled' property of the result from 'guest-info' command. Signed-off-by: Tomoki Sekiyama Signed-off-by: Michael Roth --- qga/commands-posix.c | 38 ++ qga/commands-win32.c | 32 +++- qga/gue

[Qemu-devel] [PATCH 1/3] qga: Add guest-fsfreeze-freeze-list command

2014-08-07 Thread Michael Roth
be useful when the host wants to create partial disk snapshots. Signed-off-by: Tomoki Sekiyama Reviewed-by: Eric Blake Signed-off-by: Michael Roth --- qga/commands-posix.c | 32 +++- qga/commands-win32.c | 9 + qga/qapi-schema.json | 17

[Qemu-devel] [PATCH 2/3] qga: Add guest-get-fsinfo command

2014-08-07 Thread Michael Roth
sk":[ {"bus-type":"virtio","bus":0,"unit":0,"target":0, "pci-controller":{"bus":0,"slot":6,"domain":0,"function":0}}], "type":"ext4"}]} In Linux gu

Re: [Qemu-devel] [RESEND PATCH v5 1/3] qga: Add guest-fsfreeze-freeze-list command

2014-08-07 Thread Michael Roth
Quoting Eric Blake (2014-08-07 17:03:57) > On 06/30/2014 03:51 PM, Tomoki Sekiyama wrote: > > If an array of mount point paths is specified as 'mountpoints' argument > > of guest-fsfreeze-freeze-list, qemu-ga will only freeze the file systems > > mounted on specified paths in Linux guests. Otherwis

Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

2014-08-07 Thread Michael Roth
Quoting Eric Blake (2014-08-07 16:23:14) > On 08/06/2014 02:38 PM, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v2.0.1: > > > > https://github.com/mdroth/qemu/commits/stable-2.0-staging > > &g

Re: [Qemu-devel] [PULL 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Michael Roth
Quoting Peter Maydell (2014-08-08 06:12:34) > On 7 August 2014 23:18, Eric Blake wrote: > > On 08/07/2014 04:10 PM, Michael Roth wrote: > >> Please pull the following changes, which add a new > >> guest-fsfreeze-freeze-list > >> command to qemu-ga that su

[Qemu-devel] [PULL v2 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Michael Roth
Hello, Please pull the following changes, which add a new guest-fsfreeze-freeze-list command to qemu-ga that supports specifying specific mounts to freeze, and improves the introspection information from guest-info by explicitly blacklisting/reporting commands that aren't supported on a particular

[Qemu-devel] [PATCH 3/3] qga: Disable unsupported commands by default

2014-08-08 Thread Michael Roth
supported from 'enabled' property of the result from 'guest-info' command. Signed-off-by: Tomoki Sekiyama Signed-off-by: Michael Roth --- qga/commands-posix.c | 38 ++ qga/commands-win32.c | 32 +++- qga/gue

[Qemu-devel] [PATCH 1/3] qga: Add guest-fsfreeze-freeze-list command

2014-08-08 Thread Michael Roth
be useful when the host wants to create partial disk snapshots. Signed-off-by: Tomoki Sekiyama Reviewed-by: Eric Blake *updated schema to report 2.2 as initial supported version Signed-off-by: Michael Roth --- qga/commands-posix.c | 32 +++- qga/commands-wi

[Qemu-devel] [PATCH 2/3] qga: Add guest-get-fsinfo command

2014-08-08 Thread Michael Roth
sk":[ {"bus-type":"virtio","bus":0,"unit":0,"target":0, "pci-controller":{"bus":0,"slot":6,"domain":0,"function":0}}], "type":"ext4"}]} In Linux gues

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-20 Thread Michael Roth
On 12/20/2011 08:30 AM, Paolo Bonzini wrote: On 12/20/2011 02:50 PM, Anthony Liguori wrote: For saving, you would adapt your visitor-based vmstate "put" routines so that they put things in a dictionary with no regard for integer types (a bit ugly for uint64, but perfectly fine for everything els

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2012-01-03 Thread Michael Roth
On 01/01/2012 03:52 AM, Dor Laor wrote: On 12/30/2011 12:39 AM, Anthony Liguori wrote: On 12/28/2011 07:25 PM, Isaku Yamahata wrote: Intro = This patch series implements postcopy live migration.[1] As discussed at KVM forum 2011, dedicated character device is used for distributed shared mem

Re: [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels

2012-01-04 Thread Michael Roth
On 01/04/2012 01:45 PM, Luiz Capitulino wrote: This fixes a bug when using -m isa-serial where qemu-ga will hang on a read()'s when communicating to the host via isa-serial. Original fix by Michael Roth. Signed-off-by: Luiz Capitulino --- qemu-ga.c |2 +- 1 files changed, 1 inser

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: Add the guest-suspend command

2012-01-04 Thread Michael Roth
wer/state" file. To reap terminated children, a new signal handler is installed to catch SIGCHLD signals and a non-blocking call to waitpid() is done to collect their exit statuses. Signed-off-by: Luiz Capitulino Looks good. Reviewed-by: Michael Roth --- qapi-schema-g

Re: [Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned function

2012-01-04 Thread Michael Roth
On 01/04/2012 06:00 AM, Stefan Hajnoczi wrote: On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: +static inline void *host_from_stream_offset_versioned(int version_id, +QEMUFile *f, ram_addr_t offset, int flags) +{ +void *host; +if (version_id == 3) { +

Re: [Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState

2012-01-04 Thread Michael Roth
On 01/03/2012 09:34 AM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman --- block-migration.c |4 +++- hw/hw.h |4 +++- migration.c | 15 +-- migration.h |3 +++ savevm.c | 11 +++ sysemu.h |4 +++- 6 file

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-04 Thread Michael Roth
On 01/04/2012 03:29 AM, Orit Wasserman wrote: On 01/03/2012 09:54 PM, Anthony Liguori wrote: On 01/03/2012 09:34 AM, Orit Wasserman wrote: Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman --- arch_init.c | 183 ++

Re: [Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information

2012-01-04 Thread Michael Roth
On 01/03/2012 09:34 AM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman --- arch_init.c | 67 +++ migration.c | 11 + migration.h |9 3 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch_init

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-05 Thread Michael Roth
On 01/05/2012 06:59 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 10:37:14AM -0200, Luiz Capitulino wrote: On Thu, 5 Jan 2012 10:16:30 + "Daniel P. Berrange" wrote: On Wed, Jan 04, 2012 at 05:45:11PM -0200, Luiz Capitulino wrote: This version drops modes 'sleep' and 'hybrid' beca

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-05 Thread Michael Roth
On 01/05/2012 08:42 AM, Luiz Capitulino wrote: On Thu, 5 Jan 2012 12:59:27 + "Daniel P. Berrange" wrote: On Thu, Jan 05, 2012 at 10:37:14AM -0200, Luiz Capitulino wrote: On Thu, 5 Jan 2012 10:16:30 + "Daniel P. Berrange" wrote: On Wed, Jan 04, 2012 at 05:45:11PM -0200, Luiz Capitul

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-05 Thread Michael Roth
On 01/05/2012 09:11 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 09:04:57AM -0600, Michael Roth wrote: On 01/05/2012 06:59 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 10:37:14AM -0200, Luiz Capitulino wrote: On Thu, 5 Jan 2012 10:16:30 + "Daniel P. Berrange&quo

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-05 Thread Michael Roth
On 01/05/2012 02:25 PM, Luiz Capitulino wrote: On Thu, 05 Jan 2012 09:10:50 -0600 Michael Roth wrote: On 01/05/2012 08:42 AM, Luiz Capitulino wrote: On Thu, 5 Jan 2012 12:59:27 + "Daniel P. Berrange" wrote: On Thu, Jan 05, 2012 at 10:37:14AM -0200, Luiz Capitulino wrote:

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-05 Thread Michael Roth
On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote: Hi, all. I am trying QEMU Guest Agent and encountered a small bug. It is that the PIDFILE remains when daemon start fails. And maybe forgotton to g_free(). MATSUDA, Daiki Thanks for the patch. There was some contention in the past about whether

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Michael Roth
On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wrote: On 01/05/2012 04:26 PM, MATSUDA, Daiki wrote: Hi, all. I am trying QEMU Guest Agent and encountered a small bug. It is that the PIDFILE remains when daemon start fails. And maybe

Re: [Qemu-devel] [PATCH] GuestAgent: PIDFILE remains when daemon start fails

2012-01-06 Thread Michael Roth
On 01/06/2012 01:06 PM, Luiz Capitulino wrote: On Fri, 6 Jan 2012 17:05:53 + "Daniel P. Berrange" wrote: On Fri, Jan 06, 2012 at 11:00:42AM -0600, Michael Roth wrote: On 01/06/2012 04:56 AM, Daniel P. Berrange wrote: On Thu, Jan 05, 2012 at 06:18:26PM -0600, Michael Roth wro

Re: [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command

2012-01-06 Thread Michael Roth
On 01/06/2012 01:04 PM, Luiz Capitulino wrote: On Thu, 05 Jan 2012 15:41:33 -0600 Michael Roth wrote: On 01/05/2012 02:25 PM, Luiz Capitulino wrote: On Thu, 05 Jan 2012 09:10:50 -0600 Michael Roth wrote: On 01/05/2012 08:42 AM, Luiz Capitulino wrote: On Thu, 5 Jan 2012 12:59:27 +

[Qemu-devel] [PATCH] qemu-ga: add guest-set-support-level command

2012-01-11 Thread Michael Roth
he client. The current default/minimum support level supports all versions of QEMU that have had qemu-ga in-tree (0.15.0, 1.0.0) and so should be backward-compatible with existing hosts/clients. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 31 +

[Qemu-devel] [PATCH v2] qemu-ga: add guest-set-support-level command

2012-01-11 Thread Michael Roth
he client. The current default/minimum support level supports all versions of QEMU that have had qemu-ga in-tree (0.15.0, 1.0.0) and so should be backward-compatible with existing hosts/clients. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 31 +

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-set-support-level command

2012-01-12 Thread Michael Roth
On 01/12/2012 12:57 PM, Luiz Capitulino wrote: On Wed, 11 Jan 2012 17:56:05 -0600 Michael Roth wrote: Recently commands where introduced on the mailing that involved adding commands to the guest agent that could potentially break older versions of QEMU. While it's okay to expect that qe

Re: [Qemu-devel] Is guest agent socket being closed upon reboot?

2012-01-16 Thread Michael Roth
On 01/16/2012 07:26 AM, Michal Privoznik wrote: Hi, I'd like you to ask if/why is guest agent socked being closed upon guest reboot. I am using virtserialport to talk to guest agent: -chardev socket,id=charchannel0,path=/var/lib/libvirt/qemu/f16x86_64.agent,server,nowait -device virtserialport,

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: Add the guest-suspend command

2012-01-16 Thread Michael Roth
On 01/16/2012 11:23 AM, Luiz Capitulino wrote: On Mon, 16 Jan 2012 15:18:37 -0200 Luiz Capitulino wrote: On Mon, 16 Jan 2012 17:13:39 + "Daniel P. Berrange" wrote: On Mon, Jan 16, 2012 at 03:08:53PM -0200, Luiz Capitulino wrote: On Fri, 13 Jan 2012 14:48:04 -0700 Eric Blake wrote: +

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: Add the guest-suspend command

2012-01-16 Thread Michael Roth
On 01/16/2012 02:35 PM, Daniel P. Berrange wrote: On Mon, Jan 16, 2012 at 02:02:08PM -0600, Michael Roth wrote: On 01/16/2012 11:23 AM, Luiz Capitulino wrote: On Mon, 16 Jan 2012 15:18:37 -0200 Luiz Capitulino wrote: On Mon, 16 Jan 2012 17:13:39 + "Daniel P. Berrange" wrote

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: Add the guest-suspend command

2012-01-16 Thread Michael Roth
On 01/16/2012 02:09 PM, Luiz Capitulino wrote: The guest-suspend command supports three modes: o hibernate (suspend to disk) o sleep (suspend to ram) o hybrid(save RAM contents to disk, but suspend instead of powering off) Before trying to suspend, the command queri

[Qemu-devel] [PATCH v3 1/2] qemu-ga: Add schema documentation for types

2012-01-16 Thread Michael Roth
Document guest agent schema types in similar fashion as qmp schema types. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 98 +++ 1 files changed, 81 insertions(+), 17 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema

[Qemu-devel] [PATCH v3 2/2] qemu-ga: add guest-set-support-level command

2012-01-16 Thread Michael Roth
he client. The current default/minimum support level supports all versions of QEMU that have had qemu-ga in-tree (0.15.0, 1.0.0) and so should be backward-compatible with existing hosts/clients. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 67 +++

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-01-16 Thread Michael Roth
On 01/15/2012 08:02 PM, Charles.Tsai-蔡清海-研究發展部 wrote: Vadim, Thank you for your prompt reply. Here are the information for our test case. 1) we use the following command line to launch the guest OS /usr/bin/kvm -S -M pc-0.14 -enable-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name win_x

[Qemu-devel] [PATCH v4 2/2] qemu-ga: add guest-set-support-level command

2012-01-17 Thread Michael Roth
he client. The current default/minimum support level supports all versions of QEMU that have had qemu-ga in-tree (0.15.0, 1.0.0) and so should be backward-compatible with existing hosts/clients. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 67 +++

[Qemu-devel] [PATCH v4 1/2] qemu-ga: Add schema documentation for types

2012-01-17 Thread Michael Roth
Document guest agent schema types in similar fashion as qmp schema types. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 118 +++- 1 files changed, 97 insertions(+), 21 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema

Re: [Qemu-devel] [RFC 0/5]: QMP: add balloon-get-memory-stats command

2012-01-19 Thread Michael Roth
On 01/19/2012 09:56 AM, Luiz Capitulino wrote: Long ago, commit 625a5be added the guest provided memory statistics to the query-balloon command. Unfortunately, it also introduced a severe bug: query-balloon would hang if the guest didn't respond. This, in turn, would also cause a hang in libvirt.

[Qemu-devel] [PATCH] main-loop: Fix SetEvent() on uninitialized handle on win32

2012-01-20 Thread Michael Roth
ols.o programs on Windows at runtime. This patch checks for an initialized event handle before attempting to set it, which is analoguous to how we deal with an unitialized io_thread_fd in the posix implementation. Signed-off-by: Michael Roth --- main-loop.c |5 - 1 files changed, 4 insertions(

[Qemu-devel] [PATCH] main-loop: For tools, initialize timers as part of qemu_init_main_loop()

2012-01-21 Thread Michael Roth
lities, so existing users shouldn't be affected. Signed-off-by: Michael Roth --- main-loop.c |2 +- main-loop.h | 12 qemu-tool.c |3 ++- vl.c|5 + 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/main-loop.c b/main-loop.c index 62d9

Re: [Qemu-devel] [PATCH] main-loop: For tools, initialize timers as part of qemu_init_main_loop()

2012-01-22 Thread Michael Roth
On 01/22/2012 06:32 AM, Paolo Bonzini wrote: On 01/21/2012 09:39 PM, Jamie Lokier wrote: Is this a timer that need to fire soon after setting, every time? I wonder if a different kind of Windows timer, lower-resolution, could be used if the timeout is longer. If it has insufficient resolution,

[Qemu-devel] qemu-ga: add support for Windows

2012-01-23 Thread Michael Roth
These patches apply/work on top of: [PATCH] qemu-ga: Add schema documentation for types [PATCH] qemu-ga: add guest-set-support-level command [PATCH] main-loop: Fix SetEvent() on uninitialized handle on win32 [PATCH] main-loop: For tools, initialize timers as part of qemu_init_main_loop() And can a

[Qemu-devel] [PATCH 2/7] qemu-ga: separate out common commands from posix-specific ones

2012-01-23 Thread Michael Roth
latter, and will rename guest-agent-commands.c to commands-posix.c in a future commit. Windows implementations will go in commands-win32.c, eventually. Signed-off-by: Michael Roth --- Makefile.objs |2 +- qga/commands.c | 86

[Qemu-devel] [PATCH 1/7] qemu-ga: move channel/transport functionality into wrapper class

2012-01-23 Thread Michael Roth
s like pid files, which weren't always cleaned up previously. Signed-off-by: Michael Roth --- Makefile.objs |1 + qemu-ga.c | 306 qga/channel-posix.c| 246 ++ qga/channel.h

[Qemu-devel] [PATCH 4/7] qemu-ga: fixes for win32 build of qemu-ga

2012-01-23 Thread Michael Roth
Various stubs and #ifdefs to compile for Windows using mingw cross-build. Still has 1 linker error due to a dependency on the forthcoming win32 versions of the GAChannel/transport class. Signed-off-by: Michael Roth --- Makefile |2 +- Makefile.objs|9 +++-- configure

<    2   3   4   5   6   7   8   9   10   11   >