Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-12 Thread Michael S. Tsirkin
for irqfd: add a parameter to > virtio_queue_set_host_notifier_fd_handler and in that case only set > the notifier, not the handler. > > Cc: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini Acked-by: Michael S. Tsirkin Anthony, could you pick this bugfix up please? > --- &g

Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:35:12AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This is required to get past the following assert with: > > commit 1523ed9e1d46b0b54540049d491475ccac7e6421 > Author: Jan Kiszka > Date: Thu May 17 10:32:39 2012 -0300 > > virtio/vhost:

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Michael S. Tsirkin
CONFIG_VHOST_SCSI for QEMU build configure (nab) > - Rename vhost_vring_target -> vhost_scsi_target (mst + nab) > - Add support for VHOST_SCSI_GET_ABI_VERSION ioctl (aliguori + nab) > > Cc: Stefan Hajnoczi > Cc: Zhi Yong Wu > Cc: Anthony Liguori > Cc: Paolo Bonzini > Cc: Mic

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Michael S. Tsirkin
CONFIG_VHOST_SCSI for QEMU build configure (nab) > - Rename vhost_vring_target -> vhost_scsi_target (mst + nab) > - Add support for VHOST_SCSI_GET_ABI_VERSION ioctl (aliguori + nab) > > Cc: Stefan Hajnoczi > Cc: Zhi Yong Wu > Cc: Anthony Liguori > Cc: Paolo Bonzin

Re: [Qemu-devel] [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI->cmd_vqs[0] definition

2012-08-13 Thread Michael S. Tsirkin
md_vqs[0]. > > Since virtio_scsi currently assumes a single vqs for data, this patch > simply changes ->cmd_vqs[1] to handle the single VirtQueue. > > Cc: Paolo Bonzini > Cc: Stefan Hajnoczi > Cc: Michael S. Tsirkin > Signed-off-by: Nicholas Bellinger This is a bugfix

Re: [Qemu-devel] [RFC-v2 0/6] vhost-scsi: Add support for host virtualized target

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:35:11AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi Paolo, Stefan, & QEMU folks, > > The following is the second RFC series for vhost-scsi patches against mainline > QEMU v1.1.0. The series is available from the following working branch: > >

Re: [Qemu-devel] [PATCH for-1.2 v5 14/14] pci: Tidy up PCI host bridges

2012-08-13 Thread Michael S. Tsirkin
be applied (below). Below it is split out but needs to be rebased on top of patches 1-13. --> From: Andreas Färber piix: minor code simplification There's no need to deal with qdev internals in piix - we get device state from qdev_create so just use that. Signed-off-by: Andreas Färber

Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 02:06:10PM +0200, Jan Kiszka wrote: > On 2012-08-13 10:35, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This is required to get past the following assert with: > > > > commit 1523ed9e1d46b0b54540049d491475ccac7e6421 > > Author: Jan Kiszka > > Date:

Re: [Qemu-devel] vhost-scsi port to v1.1.0 + MSI-X performance regression

2012-08-13 Thread Michael S. Tsirkin
On Tue, Jul 24, 2012 at 01:20:56PM -0700, Nicholas A. Bellinger wrote: > On Tue, 2012-07-24 at 09:57 +0200, Jan Kiszka wrote: > > On 2012-07-24 09:42, Nicholas A. Bellinger wrote: > > > Hi Anthony, Stefan & QEMU folks, > > > > > > > > > However, thus far I've not been able to get virtio-scsi <-

Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:06:17PM +0200, Jan Kiszka wrote: > On 2012-08-13 20:03, Michael S. Tsirkin wrote: > > On Mon, Aug 13, 2012 at 02:06:10PM +0200, Jan Kiszka wrote: > >> On 2012-08-13 10:35, Nicholas A. Bellinger wrote: > >>> From: Nicholas Bellinger >

Re: [Qemu-devel] [PATCH] qom: add style guide

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote: > +typedef struct MyType MyType; > + > +struct MyType > +{ This seems to violate our style:should be > +struct MyType { > +Object parent_obj; > + > +/*< private >*/ > +int foo; > +

Re: [Qemu-devel] [PATCH] qom: add style guide

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 03:57:41PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote: > >> +typedef struct MyType MyType; > >> + > >> +struct MyT

Re: [Qemu-devel] Q35 OS install status

2012-08-15 Thread Michael S. Tsirkin
On Wed, Aug 15, 2012 at 10:23:01AM -0400, Jason Baron wrote: > Hi, > > Linux > - > Fedora 17: installs and ran memory tests (requires ahci cdrom fixes I > posted to install) > Fedora 16: installs and ran memory tests > > Windows > --- > Windows 7: Wouldn't install due to this er

Re: [Qemu-devel] Slow inbound traffic on macvtap interfaces

2012-08-16 Thread Michael S. Tsirkin
On Thu, Aug 16, 2012 at 10:20:05AM +0100, Chris Webb wrote: > I'm experiencing a problem with qemu + macvtap which I can reproduce on a > variety of hardware, with kernels varying from 3.0.4 (the oldest I tried) to > 3.5.1 and with qemu[-kvm] versions 0.14.1, 1.0, and 1.1. > > Large data transfers

Re: [Qemu-devel] Slow inbound traffic on macvtap interfaces

2012-08-16 Thread Michael S. Tsirkin
On Thu, Aug 16, 2012 at 03:27:57PM +0100, Chris Webb wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Aug 16, 2012 at 10:20:05AM +0100, Chris Webb wrote: > > > > > For example, I can run > > > > > > ip addr add 192.168.1.2/24 dev et

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Michael S. Tsirkin
On Tue, Aug 14, 2012 at 02:12:29PM -0700, Nicholas A. Bellinger wrote: > On Mon, 2012-08-13 at 11:59 +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: > > > From: Stefan Hajnoczi > > > > > > This patch

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Michael S. Tsirkin
On Tue, Aug 14, 2012 at 01:31:14PM -0700, Nicholas A. Bellinger wrote: > On Mon, 2012-08-13 at 11:53 +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: > > > From: Stefan Hajnoczi > > > > > > This patch

Re: [Qemu-devel] [GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-08-18 Thread Michael S. Tsirkin
Hi Nicholas, I just noticed this problem in the interface: +#include + +/* + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. + * + * ABI Rev 0: July 2012 version starting point for v3.6-rc merge candidate + + *RFC-v2 vhost-scsi userspace. Add GET_ABI_VERSION ioctl usa

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-19 Thread Michael S. Tsirkin
On Sat, Aug 18, 2012 at 05:36:26PM -0700, Nicholas A. Bellinger wrote: > On Sat, 2012-08-18 at 22:12 +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 14, 2012 at 01:31:14PM -0700, Nicholas A. Bellinger wrote: > > > On Mon, 2012-08-13 at 11:53 +0300, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-20 Thread Michael S. Tsirkin
On Mon, Aug 20, 2012 at 12:31:01PM +0100, Stefan Hajnoczi wrote: > On Mon, Aug 20, 2012 at 10:04 AM, Paolo Bonzini wrote: > > Il 13/08/2012 10:35, Nicholas A. Bellinger ha scritto: > >> From: Stefan Hajnoczi > >> > >> This patch starts and stops vhost as the virtio device transitions > >> through

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 07:59:06AM +0200, Jan Kiszka wrote: > On 2012-08-24 01:13, Cam Macdonell wrote: > > Hi Jan, > > > > I've bisected a bug in which MSI interrupts are not being delivered to > > the following patch, where msix_reset was moved in tot he PCI core. > > > > commit cbd2d4342b3d42a

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This optimization was once used in qemu-kvm to keep KVM route usage low. > But now we solved that problem via lazy updates. It also tried to handle > the case of vectors shared between different sources of the same

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:15:33AM +0200, Jan Kiszka wrote: > On 2012-08-24 10:11, Michael S. Tsirkin wrote: > > On Fri, Aug 24, 2012 at 07:59:06AM +0200, Jan Kiszka wrote: > >> On 2012-08-24 01:13, Cam Macdonell wrote: > >>> Hi Jan, > >>> > >>&g

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:21:44AM +0200, Jan Kiszka wrote: > On 2012-08-24 10:20, Michael S. Tsirkin wrote: > > On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> This optimization was once used in qemu-kvm to keep

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:35:34AM +0200, Jan Kiszka wrote: > On 2012-08-24 10:21, Jan Kiszka wrote: > > On 2012-08-24 10:20, Michael S. Tsirkin wrote: > >> On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: > >>> From: Jan Kiszka > >>> > &g

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:39:15AM +0200, Jan Kiszka wrote: > On 2012-08-24 10:36, Michael S. Tsirkin wrote: > > On Fri, Aug 24, 2012 at 10:15:33AM +0200, Jan Kiszka wrote: > >> On 2012-08-24 10:11, Michael S. Tsirkin wrote: > >>> On Fri, Aug 24, 2012 at 07:5

[Qemu-devel] [PATCH for-1.2 0/2] migrate PV EOI MSR

2012-08-26 Thread Michael S. Tsirkin
er to apply it in qemu.git to keep diff to minimum. Needed for 1.2. Michael S. Tsirkin (2): linux-headers: update asm/kvm_para.h to 3.6 kvm: get/set PV EOI MSR linux-headers/asm-x86/kvm_para.h | 7 +++ target-i386/cpu.h| 1 + target-i386/kvm.c

[Qemu-devel] [PATCH for-1.2 1/2] linux-headers: update asm/kvm_para.h to 3.6

2012-08-26 Thread Michael S. Tsirkin
Update asm-x96/kvm_para.h to version present in Linux 3.6. This is needed for the new PV EOI feature. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-x86/kvm_para.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/linux-headers/asm-x86/kvm_para.h b/linux-headers/asm-x86

[Qemu-devel] [PATCH for-1.2 2/2] kvm: get/set PV EOI MSR

2012-08-26 Thread Michael S. Tsirkin
Support get/set of new PV EOI MSR, for migration. Add an optional section for MSR value - send it out in case MSR was changed from the default value (0). Signed-off-by: Michael S. Tsirkin --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21

[Qemu-devel] [PATCHv2 0/4] migrate PV EOI MSR

2012-08-27 Thread Michael S. Tsirkin
nc (Jan) Disable cpuid flag for qemu 1.2 and older (Orit) Michael S. Tsirkin (4): linux-headers: update to 3.6-rc3 pc: refactor compat code cpuid: disable pv eoi for 1.1 and older compat types kvm: get/set PV EOI MSR hw/Makefile.objs | 2 +- hw/

[Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Michael S. Tsirkin
Update linux-headers to version present in Linux 3.6-rc3. Header asm-x96_64/kvm_para.h update is needed for the new PV EOI feature. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-s390/kvm.h | 2 +- linux-headers/asm-s390/kvm_para.h | 2 +- linux-headers/asm-x86/kvm.h | 1

[Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-27 Thread Michael S. Tsirkin
In preparation to adding PV EOI migration for 1.2, trivially refactor some some compat code to make it easier to add version specific cpuid tweaks. Signed-off-by: Michael S. Tsirkin --- hw/pc_piix.c | 44 1 file changed, 36 insertions(+), 8 deletions

[Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Michael S. Tsirkin
-1.2 -cpu kvm64,-kvm_pv_eoi Signed-off-by: Michael S. Tsirkin --- hw/Makefile.objs | 2 +- hw/cpu_flags.c| 32 hw/cpu_flags.h| 9 + hw/pc_piix.c | 2 ++ target-i386/cpu.c | 8 5 files changed, 52 insertions(+), 1 deletion(-) create

[Qemu-devel] [PATCHv2 4/4] kvm: get/set PV EOI MSR

2012-08-27 Thread Michael S. Tsirkin
Support get/set of new PV EOI MSR, for migration. Add an optional section for MSR value - send it out in case MSR was changed from the default value (0). Signed-off-by: Michael S. Tsirkin --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 01:42:03PM +0100, Peter Maydell wrote: > On 27 August 2012 13:20, Michael S. Tsirkin wrote: > > Update linux-headers to version present in Linux 3.6-rc3. > > Header asm-x96_64/kvm_para.h update is needed for the new PV EOI > > feature. > > &

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 02:48:57PM +0200, Jan Kiszka wrote: > On 2012-08-27 14:42, Peter Maydell wrote: > > On 27 August 2012 13:20, Michael S. Tsirkin wrote: > >> Update linux-headers to version present in Linux 3.6-rc3. > >> Header asm-x96_64/kvm_para.h update i

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 04:59:40PM +0200, Jan Kiszka wrote: > On 2012-08-27 16:53, Michael S. Tsirkin wrote: > > On Mon, Aug 27, 2012 at 02:48:57PM +0200, Jan Kiszka wrote: > >> On 2012-08-27 14:42, Peter Maydell wrote: > >>> On 27 August 2012 13:20, Michael S. Tsirk

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 06:56:38PM +, Blue Swirl wrote: > > +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) > > +{ > > +AssignedDevRegion *d = opaque; > > +uint8_t *in = d->u.r_virtbase + addr; > > Don't perform arithmetic with void pointers. Why not? We require

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 06:58:29PM +, Blue Swirl wrote: > On Mon, Aug 27, 2012 at 12:20 PM, Michael S. Tsirkin wrote: > > In preparation for adding PV EOI support, disable PV EOI by default for > > 1.1 and older machine types, to avoid CPUID changing during migration. > >

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 07:12:27PM +, Blue Swirl wrote: > On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin wrote: > > On Mon, Aug 27, 2012 at 06:58:29PM +, Blue Swirl wrote: > >> On Mon, Aug 27, 2012 at 12:20 PM, Michael S. Tsirkin > >> wrote: > >>

[Qemu-devel] [PATCHv3 0/4] migrate PV EOI MSR

2012-08-28 Thread Michael S. Tsirkin
v1: Update all headers from 3.6-rc3 to keep them in sync (Jan) Disable cpuid flag for qemu 1.2 and older (Orit) Michael S. Tsirkin (4): linux-headers: update to 3.6-rc3 pc: refactor compat code cpuid: disable pv eoi for 1.1 and older compat types kvm: get/set PV EOI MSR hw/Makefil

[Qemu-devel] [PATCHv3 1/4] linux-headers: update to 3.6-rc3

2012-08-28 Thread Michael S. Tsirkin
Update linux-headers to version present in Linux 3.6-rc3. Header asm-x96_64/kvm_para.h update is needed for the new PV EOI feature. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-s390/kvm.h | 2 +- linux-headers/asm-s390/kvm_para.h | 2 +- linux-headers/asm-x86/kvm.h | 1

[Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
-1.2 -cpu kvm64,-kvm_pv_eoi Signed-off-by: Michael S. Tsirkin --- hw/Makefile.objs | 2 +- hw/cpu_flags.c| 32 hw/cpu_flags.h| 9 + hw/pc_piix.c | 2 ++ target-i386/cpu.c | 8 5 files changed, 52 insertions(+), 1 deletion(-) create

[Qemu-devel] [PATCHv3 4/4] kvm: get/set PV EOI MSR

2012-08-28 Thread Michael S. Tsirkin
Support get/set of new PV EOI MSR, for migration. Add an optional section for MSR value - send it out in case MSR was changed from the default value (0). Signed-off-by: Michael S. Tsirkin --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21

[Qemu-devel] [PATCHv3 2/4] pc: refactor compat code

2012-08-28 Thread Michael S. Tsirkin
In preparation to adding PV EOI migration for 1.2, trivially refactor some some compat code to make it easier to add version specific cpuid tweaks. Signed-off-by: Michael S. Tsirkin --- hw/pc_piix.c | 44 1 file changed, 36 insertions(+), 8 deletions

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 07:01:16PM +0300, Michael S. Tsirkin wrote: > We copied HACKING from libvirt but it has some bogus stuff: > neither underscore capital, double underscore, or underscore 't' suffixes > are reserved in Posix/C: this appears to be based on misreading of the

[Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
lso widely violated in our codebase, and it does not make sense to rework it all, apparently for no benefit. Signed-off-by: Michael S. Tsirkin --- HACKING | 4 1 file changed, 4 deletions(-) diff --git a/HACKING b/HACKING index 471cf1d..0a941fc 100644 --- a/HACKING +++ b/HACKING @@ -69,10 +

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > > On Mon, Aug 27, 2012 at 07:12:27PM +, Blue Swirl wrote: > >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin > >> wrote: > >>

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 01:23:18PM -0300, Marcelo Tosatti wrote: > On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > > In preparation to adding PV EOI migration for 1.2, > > trivially refactor some some compat code > > to make it easier to add version spec

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: > On 28 August 2012 17:01, Michael S. Tsirkin wrote: > > We copied HACKING from libvirt but it has some bogus stuff: > > neither underscore capital, double underscore, or underscore 't' suffixes > >

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:13:24PM +, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 4:01 PM, Michael S. Tsirkin wrote: > > We copied HACKING from libvirt but it has some bogus stuff: > > neither underscore capital, double underscore, or underscore 't' suffixes > >

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:05:25PM +, Blue Swirl wrote: > > +static bool _kvm_pv_eoi_disabled; > > NACK. I find your lack of compliance disturbing. Compliance with what? Could you please add some motivation for the NACK? -- MST

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > > On 27.08.2012 22:56, Blue Swirl wrote: > > [] > >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) > >>> +{ > >>> +AssignedDevRegion *d = opaque; >

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 06:23:38PM +0100, Peter Maydell wrote: > On 28 August 2012 18:18, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: > >> C99 7.1.3 > >> reserves underscore capital and double underscore prefixes. >

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 06:27:59PM +0100, Peter Maydell wrote: > On 28 August 2012 18:21, Michael S. Tsirkin wrote: > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > > And if it does happen then you run a simple script and fix > > this one i

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 09:33:16PM +0400, malc wrote: > On Tue, 28 Aug 2012, Peter Maydell wrote: > > > On 28 August 2012 18:21, Michael S. Tsirkin wrote: > > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > > > And if it does happen th

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:28:22PM +, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 05:05:25PM +, Blue Swirl wrote: > >> > +static bool _kvm_pv_eoi_disabled; > >> > >> NACK. I

[Qemu-devel] [PATCHv4 0/4] migrate PV EOI MSR

2012-08-28 Thread Michael S. Tsirkin
to strict C99 (Blue Swirl) Changes from v1: Update all headers from 3.6-rc3 to keep them in sync (Jan) Disable cpuid flag for qemu 1.2 and older (Orit) Michael S. Tsirkin (4): linux-headers: update to 3.6-rc3 pc: refactor compat code cpuid: disable pv eoi for 1.1 and older compat t

[Qemu-devel] [PATCHv4 1/4] linux-headers: update to 3.6-rc3

2012-08-28 Thread Michael S. Tsirkin
Update linux-headers to version present in Linux 3.6-rc3. Header asm-x96_64/kvm_para.h update is needed for the new PV EOI feature. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-s390/kvm.h | 2 +- linux-headers/asm-s390/kvm_para.h | 2 +- linux-headers/asm-x86/kvm.h | 1

[Qemu-devel] [PATCHv4 2/4] pc: refactor compat code

2012-08-28 Thread Michael S. Tsirkin
In preparation to adding PV EOI migration for 1.2, trivially refactor some some compat code to make it easier to add version specific cpuid tweaks. Signed-off-by: Michael S. Tsirkin --- hw/pc_piix.c | 44 1 file changed, 36 insertions(+), 8 deletions

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 06:46:53PM +0100, Peter Maydell wrote: > On 28 August 2012 18:32, Michael S. Tsirkin wrote: > > What about _t in POSIX? That seems fairly safe if name is long and qemu > > specific enough. > > Depends what you mean by "safe". The spec says &

[Qemu-devel] [PATCHv4 4/4] kvm: get/set PV EOI MSR

2012-08-28 Thread Michael S. Tsirkin
Support get/set of new PV EOI MSR, for migration. Add an optional section for MSR value - send it out in case MSR was changed from the default value (0). Signed-off-by: Michael S. Tsirkin --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21

[Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
-1.2 -cpu kvm64,-kvm_pv_eoi Signed-off-by: Michael S. Tsirkin --- hw/Makefile.objs | 2 +- hw/cpu_flags.c| 32 hw/cpu_flags.h| 9 + hw/pc_piix.c | 2 ++ target-i386/cpu.c | 8 5 files changed, 52 insertions(+), 1 deletion(-) create

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 01:37:18PM -0300, Marcelo Tosatti wrote: > On Tue, Aug 28, 2012 at 07:31:24PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 01:23:18PM -0300, Marcelo Tosatti wrote: > > > On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 04:13:38PM -0300, Eduardo Habkost wrote: > On Tue, Aug 28, 2012 at 08:43:52PM +0300, Michael S. Tsirkin wrote: > > In preparation for adding PV EOI support, disable PV EOI by default for > > 1.1 and older machine types, to avoid CPUID changing during migrati

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 02:13:18PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > In preparation for adding PV EOI support, disable PV EOI by default for > > 1.1 and older machine types, to avoid CPUID changing during migration. > > > >

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 04:40:38PM -0300, Eduardo Habkost wrote: > On Tue, Aug 28, 2012 at 02:13:18PM -0500, Anthony Liguori wrote: > > "Michael S. Tsirkin" writes: > > > > > In preparation for adding PV EOI support, disable PV EOI by default for > > >

Re: [Qemu-devel] [PATCH v2 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 01:02:26PM +0200, Jan Kiszka wrote: > This adds PCI device assignment for i386 targets using the classic KVM > interfaces. This version is 100% identical to what is being maintained > in qemu-kvm for several years and is supported by libvirt as well. It is > expected to rema

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 09:02:05PM +0400, malc wrote: > On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > > > On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > > > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin > > > wrote: > > > > On M

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 07:02:42PM -0300, Eduardo Habkost wrote: > On Wed, Aug 29, 2012 at 12:35:28AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 04:13:38PM -0300, Eduardo Habkost wrote: > > > On Tue, Aug 28, 2012 at 08:43:52PM +0300, Michael S. Tsirkin

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Wed, Aug 29, 2012 at 01:21:13AM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 07:02:42PM -0300, Eduardo Habkost wrote: > > On Wed, Aug 29, 2012 at 12:35:28AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 28, 2012 at 04:13:38PM -0300, Eduardo Habkost wrote: &

Re: [Qemu-devel] [PATCH 26/28] pci: convert to QEMU Object Model

2012-01-25 Thread Michael S. Tsirkin
On Tue, Jan 24, 2012 at 01:33:18PM -0600, Anthony Liguori wrote: > diff --git a/hw/ac97.c b/hw/ac97.c > index 03be99b..33b85f5 100644 > --- a/hw/ac97.c > +++ b/hw/ac97.c > @@ -1344,21 +1344,30 @@ int ac97_init (PCIBus *bus) > return 0; > } > > -static PCIDeviceInfo ac97_info = { > -.qde

Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally

2012-01-25 Thread Michael S. Tsirkin
On Tue, Jan 24, 2012 at 01:32:55PM -0600, Anthony Liguori wrote: > Because now all PCI devices are converted to qdev. > > Signed-off-by: Anthony Liguori Finally! > --- > hw/pci.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 54

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > Hi, > In this post > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > mentioned about the issues when 64Bit PCI BAR is present and 32bit > address range is selected for it. > The issue affects all recent qem

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > Hi, > In this post > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > mentioned about the issues when 64Bit PCI BAR is present and 32bit > address range is selected for it. > The issue affects all recent qem

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Michael S. Tsirkin
On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > Hi, > In this post > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg03171.html I've > mentioned about the issues when 64Bit PCI BAR is present and 32bit > address range is selected for it. > The issue affects all recent qem

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2012 at 03:51:06PM +0200, Avi Kivity wrote: > > Please look at HPET lines. HPET is mapped to 0xfed0. > > Size of ivshmem is 32MB. During pci enumeration ivshmem will corrupt the > > range from 0xfe00 - 0x. > > It overlaps HPET memory. When Linux does late_hpet init,

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: > On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: > > On Wed, Jan 25, 2012 at 06:46:03PM +1300, Alexey Korolev wrote: > > > Hi, > > > In this post > > > http://lists.gnu.org/archive/html/q

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Michael S. Tsirkin
On Tue, Jan 31, 2012 at 08:12:29AM -0600, Anthony Liguori wrote: > On 01/31/2012 07:15 AM, Andreas Färber wrote: > >Am 31.01.2012 00:53, schrieb Anthony Liguori: > >>On 01/30/2012 05:41 PM, Andreas Färber wrote: > >>>Am 30.01.2012 19:55, schrieb Juan Quintela: > Please send in any agenda items

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Michael S. Tsirkin
On Tue, Jan 31, 2012 at 05:04:48PM +0200, Michael S. Tsirkin wrote: > On Tue, Jan 31, 2012 at 08:12:29AM -0600, Anthony Liguori wrote: > > On 01/31/2012 07:15 AM, Andreas Färber wrote: > > >Am 31.01.2012 00:53, schrieb Anthony Liguori: > > >>On 01/30/2012 05:41 PM, A

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-31 Thread Michael S. Tsirkin
On Wed, Feb 01, 2012 at 06:44:42PM +1300, Alexey Korolev wrote: > On 31/01/12 22:43, Avi Kivity wrote: > > On 01/31/2012 11:40 AM, Avi Kivity wrote: > >> On 01/27/2012 06:42 AM, Alexey Korolev wrote: > >>> On 27/01/12 04:12, Avi Kivity wrote: > >>>> On

Re: [Qemu-devel] [PATCH] pci: Add generic PCI device option to disable 64bit MMIO BARs

2012-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2012 at 03:57:02PM -0700, Alex Williamson wrote: > As we start to enable 64bit I/O devices, there's a good chance > we'll find bugs and compatibility issues. This allows a user > to toggle off (default on) 64bit PCI MMIO BARs, downgrading > them to 32bit BARs. > > Signed-off-by: A

[Qemu-devel] [PATCH] docs: memory.txt document the endian field

2012-02-12 Thread Michael S. Tsirkin
This is an attempt to document the endian field in memory API. As this is a confusing topic, it's best to make the text as explicit as possible. Signed-off-by: Michael S. Tsirkin --- docs/memory.txt | 28 1 files changed, 28 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH] docs: memory.txt document the endian field

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 03:02:11PM +0200, Avi Kivity wrote: > On 02/12/2012 02:52 PM, Michael S. Tsirkin wrote: > > This is an attempt to document the endian > > field in memory API. As this is a confusing topic, > > it's best to make the text as explicit as possi

Re: [Qemu-devel] [PATCH] docs: memory.txt document the endian field

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 03:55:20PM +0200, Avi Kivity wrote: > On 02/12/2012 03:47 PM, Michael S. Tsirkin wrote: > > On Sun, Feb 12, 2012 at 03:02:11PM +0200, Avi Kivity wrote: > > > On 02/12/2012 02:52 PM, Michael S. Tsirkin wrote: > > > > This is an attempt to docume

[Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
I got this assert when working on qemu: pci hotplug callback failed so qdev_free was called. (gdb) where #0 0x75fa1905 in raise () from /lib64/libc.so.6 #1 0x75fa30e5 in abort () from /lib64/libc.so.6 #2 0x77413a7f in g_assertion_message () from /lib64/libglib-2.0.so.0 #

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 07:07:43PM +0200, Michael S. Tsirkin wrote: > I got this assert when working on qemu: pci hotplug > callback failed so qdev_free was called. > > (gdb) where > #0 0x75fa1905 in raise () from /lib64/libc.so.6 > #1 0x75fa30e5 in abort () f

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: > On 02/12/2012 11:31 AM, Michael S. Tsirkin wrote: > >On Sun, Feb 12, 2012 at 07:07:43PM +0200, Michael S. Tsirkin wrote: > >>I got this assert when working on qemu: pci hotplug > >>callback fai

Re: [Qemu-devel] [PATCH] docs: memory.txt document the endian field

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 07:20:07PM +0100, Andreas Färber wrote: > Am 12.02.2012 16:06, schrieb Michael S. Tsirkin: > > So I think the following is right? > > > > > > commit 02aa79aac9bec1c8c17d1b7b5405b59b649dfdb9 > > Author: Michael S. Tsirkin > >

[Qemu-devel] slirp-related crash

2012-02-12 Thread Michael S. Tsirkin
It seems somewhat easy to crash qemu with slirp if we queue multiple packets. I didn't investigate further yet so I don't know if this is a regression. Anyone knowledgeable about slirp wants to take a look? /home/mst/qemu-test/bin/qemu-system-x86_64 -enable-kvm -m 1G -drive file=/home/mst/rhel6.q

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: > On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: > >On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: > >>From: Anthony Liguori > >>Date: Sun, 12 Feb 2012 11:36:24 -0600 > >>Subj

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 02:19:19PM -0600, Anthony Liguori wrote: > On 02/12/2012 02:15 PM, Michael S. Tsirkin wrote: > >On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: > >>On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: > >>>On Sun, Feb 12, 201

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 02:17:35AM +0200, Michael S. Tsirkin wrote: > On Sun, Feb 12, 2012 at 02:19:19PM -0600, Anthony Liguori wrote: > > On 02/12/2012 02:15 PM, Michael S. Tsirkin wrote: > > >On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: > > >>On

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 03:18:13AM +0200, Michael S. Tsirkin wrote: > > I also see this: > > > > device_add virtio-net-pci,netdev=foo,mac=52:54:00:12:34:56,id=bla > > device_del bla > > *** glibc detected *** /home/mst/qemu-test/bin/qemu-system-x86_64: &g

[Qemu-devel] [PATCHv2-RFC 0/2] RFC: standard pci bridge device

2012-02-13 Thread Michael S. Tsirkin
dge,id=bog -device virtio-net-pci,netdev=foo,bus=bog,addr=8 Hot-unplug currently causes qemu to crash, this happens without this patch too, so I'm not worried :) New since v1: hotplug support -- MST Michael S. Tsirkin (2): shpc: standard hot plug controller pci: add standa

[Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-13 Thread Michael S. Tsirkin
. TODO: - chassis capability support - migration support - remove dependency on pci_internals.h Signed-off-by: Michael S. Tsirkin --- Makefile.objs |2 +- hw/pci_bridge_dev.c | 136 +++ 2 files changed, 137 insertions(+), 1 deletions

[Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller

2012-02-13 Thread Michael S. Tsirkin
- migration support - fix dependency on pci_internals.h Signed-off-by: Michael S. Tsirkin --- Makefile.objs |1 + hw/pci.h |6 + hw/shpc.c | 646 + hw/shpc.h | 40 qemu-common.h |1 + 5 files changed, 694 i

[Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Michael S. Tsirkin
To allow guests to load the native SHPC driver for a bridge, we must declare an OSHP method for the appropriate device which lets the OS take control of the SHPC. As we don't access SHPC at the moment, we don't need to do anything - just report success. Signed-off-by: Michael

Re: [Qemu-devel] [PATCHv2-RFC 0/2] RFC: standard pci bridge device

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 05:38:26PM +0800, Wen Congyang wrote: > At 02/13/2012 05:15 PM, Michael S. Tsirkin Wrote: > > Here's a new version of the patch. It works for me. > > Deep nesting of bridges is supported. > > You need a small BIOS patch to support the OSHP method

Re: [Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 07:03:52PM +0900, Isaku Yamahata wrote: > Oh nice work. > > On Mon, Feb 13, 2012 at 11:15:55AM +0200, Michael S. Tsirkin wrote: > > This adds support for SHPC interface, as defined by PCI Standard > > Hot-Plug Controller and Subsystem Specificat

  1   2   3   4   5   6   7   8   9   10   >