[Qemu-devel] [PATCH v8 05/26] fw_cfg: interface to trigger callback on read

2013-10-03 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions

[Qemu-devel] [PATCH v8 14/26] acpi: ssdt pcihp: updat generated file

2013-10-03 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v8 06/26] loader: support for unmapped ROM blobs

2013-10-03 Thread Michael S. Tsirkin
...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/lm32/lm32_hwsetup.h | 2 +- include/hw/loader.h| 7 --- hw/core/loader.c | 23 --- 3 files changed, 25 insertions(+), 7 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH v8 15/26] loader: use file path size from fw_cfg.h

2013-10-03 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 +++- hw

[Qemu-devel] [PATCH v8 07/26] pcie_host: expose UNMAPPED macro

2013-10-03 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3

[Qemu-devel] [PATCH v8 08/26] pcie_host: expose address format

2013-10-03 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c

[Qemu-devel] [PATCH v8 16/26] i386: add bios linker/loader

2013-10-03 Thread Michael S. Tsirkin
...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/bios-linker-loader.h | 27 hw/i386/bios-linker-loader.c | 158 +++ hw/i386/Makefile.objs| 1 + 3 files changed, 186 insertions(+) create mode 100644 hw/i386/bios

[Qemu-devel] [PATCH v8 09/26] q35: use macro for MCFG property name

2013-10-03 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v8 23/26] hpet: add API to find it

2013-10-03 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include

[Qemu-devel] [PATCH v8 18/26] i386: define pc guest info

2013-10-03 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m

[Qemu-devel] [PATCH v8 25/26] ssdt: fix PBLK length

2013-10-03 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-proc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v8 19/26] acpi/piix: add macros for acpi property names

2013-10-03 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386

[Qemu-devel] [PATCH v8 20/26] piix: APIs for pc guest info

2013-10-03 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S

[Qemu-devel] [PATCH v8 21/26] ich9: APIs for pc guest info

2013-10-03 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/ich9.h| 2 ++ include/hw/i386/ich9.h| 2 ++ include/hw/pci-host/q35.h | 2 ++ hw/acpi/ich9.c| 24 hw/isa/lpc_ich9.c | 40 hw/pci-host/q35.c

[Qemu-devel] [PATCH v8 22/26] pvpanic: add API to access io port

2013-10-03 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13

[Qemu-devel] [PATCH v8 26/26] ssdt-proc: update generated file

2013-10-03 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file

[Qemu-devel] [PATCH v8 17/26] loader: allow adding ROMs in done callbacks

2013-10-03 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9

[Qemu-devel] [PATCH v8 03/26] qom: add pointer to int property helpers

2013-10-03 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 21

[Qemu-devel] [PATCH v8 12/26] acpi: add rules to compile ASL source

2013-10-03 Thread Michael S. Tsirkin
time. Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- configure | 9 - hw/i386/Makefile.objs | 22 ++ scripts/update

Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-10-03 Thread Michael S. Tsirkin
On Thu, Oct 03, 2013 at 05:58:30PM +0200, Paolo Bonzini wrote: Il 03/10/2013 15:54, Michael S. Tsirkin ha scritto: On Thu, Oct 03, 2013 at 03:46:11PM +0200, Paolo Bonzini wrote: PCI is handling resetting of its devices before the bus is reset, but this is only necessary because qdev

Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-10-06 Thread Michael S. Tsirkin
On Thu, Oct 03, 2013 at 06:53:10PM +0200, Paolo Bonzini wrote: Il 03/10/2013 18:54, Michael S. Tsirkin ha scritto: For each PCI device I tried creating a VM with an instance of it (a few devices at a time), and did VM resets. Earlier versions were tested by the guy who reported the SCSI

Re: [Qemu-devel] [PATCH v8 18/26] i386: define pc guest info

2013-10-06 Thread Michael S. Tsirkin
On Fri, Oct 04, 2013 at 06:18:42PM +0200, Igor Mammedov wrote: On Thu, 3 Oct 2013 18:05:35 +0300 Michael S. Tsirkin m...@redhat.com wrote: This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo

Re: [Qemu-devel] [PATCH v8 18/26] i386: define pc guest info

2013-10-06 Thread Michael S. Tsirkin
On Fri, Oct 04, 2013 at 06:18:42PM +0200, Igor Mammedov wrote: On Thu, 3 Oct 2013 18:05:35 +0300 Michael S. Tsirkin m...@redhat.com wrote: This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo

Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote: pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated using pci_allocate_irq wrapper only if is needed by non pci devices.

Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 11:03:47AM +0300, Michael S. Tsirkin wrote: On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote: pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated

[Qemu-devel] [PATCH v3 1/4] pci: add pci_for_each_bus_depth_first

2013-10-07 Thread Michael S. Tsirkin
Add a method to scan pci buses in a predictable order. Useful for ACPI hotplug. Document that order is not guaranteed for pci_for_each_device, and re-implement using that. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pci.h | 14 ++ hw/pci/pci.c | 28

[Qemu-devel] [PATCH v3 0/4] acpi hotplug of devices behind a pci bridge

2013-10-07 Thread Michael S. Tsirkin
-endian systems. - Cross version migration: when running with -M 1.6 and older, new hotplug functionality is unavailable. All ACPI table generation is disabled. We present FW_CFG interface compatible with 1.6. Michael S. Tsirkin (4): pci: add

[Qemu-devel] [PATCH v3 3/4] piix4: add acpi pci hotplug support

2013-10-07 Thread Michael S. Tsirkin
Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.6 and older. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 5 hw/acpi/piix4.c | 75

[Qemu-devel] [PATCH v3 2/4] pcihp: generalization of piix4 acpi

2013-10-07 Thread Michael S. Tsirkin
, then slot into existing EJ. The interface is actually backwards-compatible with existing PIIX4 ACPI (though not migration compatible). This is split out from PIIX4 codebase so we can reuse it for Q35 as well. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/pcihp.h | 72

[Qemu-devel] [PATCH v3 4/4] acpi-build: enable hotplug for PCI bridges

2013-10-07 Thread Michael S. Tsirkin
hotplug events for each bridge with bsel property Note: ACPI doesn't support adding or removing bridges by hotplug. We detect and prevent removal of bridges by hotplug, unless they were added by hotplug previously (and so, are not described by ACPI). Signed-off-by: Michael S. Tsirkin m

[Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest

2013-10-07 Thread Michael S. Tsirkin
. Such binary compatibility makes it easier to be confident that this change won't break things. Igor Mammedov (1): cleanup object.h: include error.h directly Michael S. Tsirkin (26): qom: cleanup struct Error references qom: add pointer to int property helpers pci: fix up w64 size

[Qemu-devel] [PATCH v9 02/27] qom: cleanup struct Error references

2013-10-07 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PATCH v9 03/27] qom: add pointer to int property helpers

2013-10-07 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 21

[Qemu-devel] [PATCH v9 06/27] loader: support for unmapped ROM blobs

2013-10-07 Thread Michael S. Tsirkin
...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/lm32/lm32_hwsetup.h | 2 +- include/hw/loader.h| 7 --- hw/core/loader.c | 23 --- 3 files changed, 25 insertions(+), 7 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH v9 04/27] pci: fix up w64 size calculation helper

2013-10-07 Thread Michael S. Tsirkin
BAR base was calculated incorrectly. Use existing pci_bar_address to get it right. Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/pci.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/pci

[Qemu-devel] [PATCH v9 10/27] q35: expose mmcfg size as a property

2013-10-07 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed

[Qemu-devel] [PATCH v9 07/27] pcie_host: expose UNMAPPED macro

2013-10-07 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3

[Qemu-devel] [PATCH v9 05/27] fw_cfg: interface to trigger callback on read

2013-10-07 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions

[Qemu-devel] [PATCH v9 12/27] acpi: add rules to compile ASL source

2013-10-07 Thread Michael S. Tsirkin
time. Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- configure | 9 - hw/i386/Makefile.objs | 22 ++ scripts/update

[Qemu-devel] [PATCH v9 08/27] pcie_host: expose address format

2013-10-07 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c

[Qemu-devel] [PATCH v9 15/27] loader: use file path size from fw_cfg.h

2013-10-07 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 +++- hw

[Qemu-devel] [PATCH v9 09/27] q35: use macro for MCFG property name

2013-10-07 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v9 23/27] hpet: add API to find it

2013-10-07 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include

[Qemu-devel] [PATCH v9 25/27] ssdt: fix PBLK length

2013-10-07 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-proc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v9 14/27] acpi: ssdt pcihp: updat generated file

2013-10-07 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v9 16/27] i386: add bios linker/loader

2013-10-07 Thread Michael S. Tsirkin
...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/bios-linker-loader.h | 27 hw/i386/bios-linker-loader.c | 158 +++ hw/i386/Makefile.objs| 1 + 3 files changed, 186 insertions(+) create mode 100644 hw/i386/bios

[Qemu-devel] [PATCH v9 17/27] loader: allow adding ROMs in done callbacks

2013-10-07 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9

[Qemu-devel] [PATCH v9 18/27] i386: define pc guest info

2013-10-07 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m

[Qemu-devel] [PATCH v9 19/27] acpi/piix: add macros for acpi property names

2013-10-07 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386

[Qemu-devel] [PATCH v9 20/27] piix: APIs for pc guest info

2013-10-07 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S

[Qemu-devel] [PATCH v9 21/27] ich9: APIs for pc guest info

2013-10-07 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/ich9.h| 2 ++ include/hw/i386/ich9.h| 2 ++ include/hw/pci-host/q35.h | 2 ++ hw/acpi/ich9.c| 24 hw/isa/lpc_ich9.c | 40 hw/pci-host/q35.c

[Qemu-devel] [PATCH v9 22/27] pvpanic: add API to access io port

2013-10-07 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13

[Qemu-devel] [PATCH v9 26/27] ssdt-proc: update generated file

2013-10-07 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file

Re: [Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin

2013-10-07 Thread Michael S. Tsirkin
anymore. Special cases of replacements were done in separate patches, all others in one patch hw: set interrupts using pci irq wrappers OK so Acked-by: Michael S. Tsirkin m...@redhat.com Let's wait for some acks, then I'll merge this. Changes from v2: - Addressed Michael S. Tsirkin's

[Qemu-devel] [PATCH v9 01/27] cleanup object.h: include error.h directly

2013-10-07 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com qapi/error.h is simple enough to be included in qom/object.h direcly and prepares qom/object.h to use Error typedef. Signed-off-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 2 +- 1 file

Re: [Qemu-devel] [PATCH v9 27/27] don't post me: update bios

2013-10-07 Thread Michael S. Tsirkin
On Tue, Oct 08, 2013 at 01:10:56AM +0900, Peter Maydell wrote: On 7 October 2013 18:36, Michael S. Tsirkin m...@redhat.com wrote: update bios binaries to 55480e81704fa46429ac5bb4f8f452fadc9c0416 Subject: line doesn't match your actual behaviour :-) -- PMM Yes, I keep it around

Re: [Qemu-devel] [PATCH v5 0/3] pci: partially implement master abort protocol

2013-10-08 Thread Michael S. Tsirkin
in Status register Changes from v4: - Addressed Peter Maydell comments - Changed memory patches commit comment - Addressed Michael S. Tsirkin comments - Changed PCI master_abort_mem ops endian-nes to DEVICE_LITTLE_ENDIAN Changes from v3: - Addressed Peter Maydell comments

Re: [Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin

2013-10-08 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 10:36:33AM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Added pci_* wrappers to replace qemu_set_irq,

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-09 Thread Michael S. Tsirkin
On Wed, Oct 09, 2013 at 11:27:24AM +0800, liu ping fan wrote: On Mon, Sep 30, 2013 at 11:58 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote: Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: I was really only talking about q35

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-09 Thread Michael S. Tsirkin
On Wed, Oct 09, 2013 at 09:41:29AM +0200, Paolo Bonzini wrote: Il 09/10/2013 09:24, Michael S. Tsirkin ha scritto: Sorry, out of office for a long time, and did not keep up with this thread in time. When letting the caller set the intcap, we should consider the compatibility of q35

[Qemu-devel] [PATCH 1/3] acpi: add interface to access user-installed tables

2013-10-10 Thread Michael S. Tsirkin
Also add a new API to install builtin tables, so that we can distinguish between the two. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/acpi.h | 4 hw/acpi/core.c | 40 2 files changed, 44 insertions(+) diff --git

[Qemu-devel] [PATCH 0/3] acpi-build: add -acpitable support

2013-10-10 Thread Michael S. Tsirkin
This small patchset is on top of my acpi series v9 - as that is very big by now, sending as incremental patches to simplify review. Michael S. Tsirkin (3): acpi: add interface to access user-installed tables pc: use new api to add builtin tables acpi-build: load tables supplied by user

[Qemu-devel] [PATCH 2/3] pc: use new api to add builtin tables

2013-10-10 Thread Michael S. Tsirkin
At this point the only builtin table we have is the DSDT used for Q35. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index a7fcbf9..a51f916 100644 --- a/hw/i386/pc.c +++ b/hw/i386

[Qemu-devel] [PATCH 3/3] acpi-build: load tables supplied by user

2013-10-10 Thread Michael S. Tsirkin
If user supplies any SSDTs using -acpi, install them in addition to the built-in ones. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/acpi-build.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 262d1d6..6cfa044 100644

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2013 at 03:56:16PM +0800, Liu Ping Fan wrote: On q35, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet as guest chooses. So we introduce intcap property to do that. (currently, its value is IRQ2. Later, it should be set by

Re: [Qemu-devel] [PATCH v6 5/5] PC: differentiate hpet's interrupt capability on piix and q35

2013-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2013 at 03:56:19PM +0800, Liu Ping Fan wrote: For pc-piix-*, hpet's intcap is always hard coded as IRQ2. For q35, if it is pc-q35-1.7 and earlier, we use IRQ2 for compat reason, otherwise IRQ2, IRQ8, and IRQ16~23 are allowed. Signed-off-by: Liu Ping Fan

Re: [Qemu-devel] [PATCH v6 3/5] PC: use qdev_xx to create hpet instead of sysbus_create_xx

2013-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2013 at 03:56:17PM +0800, Liu Ping Fan wrote: sysbus_create_xx func does not allow us to set a device's extra properties. While hpet need to set its compat property before initialization, so we abandon the wrapper function, and spread its logic inline Signed-off-by: Liu

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2013 at 11:33:07AM +0200, Paolo Bonzini wrote: Il 10/10/2013 11:16, Michael S. Tsirkin ha scritto: On Thu, Oct 10, 2013 at 03:56:16PM +0800, Liu Ping Fan wrote: On q35, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet

Re: [Qemu-devel] [RFC] map 64-bit PCI devices after all possible RAM

2013-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2013 at 12:56:23PM +0200, Gerd Hoffmann wrote: Hi, So far from QEMU side it's partially (only memory region mapping and not ACPI window) configurable via {i440FX-pcihost|q35-pcihost}.pci-hole64-size property /me looks. Hmm, so the pci-hole64 memory region

Re: [Qemu-devel] [RFC] map 64-bit PCI devices after all possible RAM

2013-10-10 Thread Michael S. Tsirkin
On Wed, Oct 09, 2013 at 02:23:04PM +0200, Igor Mammedov wrote: I'm posting it to get an oppinion on one of possible approaches on where to map a hotplug memory. This patch assumes that a space for hotplug memory is located right after RamSizeOver4G region and QEMU will provide romfile to

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto: Are you sure? This is not done for any other compat property. Paolo It's done if we use the property from C. See PCI_HOST_PROP_PCI_HOLE64_SIZE. You want compiler

Re: [Qemu-devel] [RFC] map 64-bit PCI devices after all possible RAM

2013-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2013 at 02:14:16PM +0200, Gerd Hoffmann wrote: Hi, I think the simplest way to do all this is simply to tell seabios that we have more memory. seabios already programs 64 bit BARs higher than memory. Hmm? As I understand Igor just wants some address space for memory

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-13 Thread Michael S. Tsirkin
On Sun, Oct 13, 2013 at 02:13:44PM +0200, Igor Mammedov wrote: Currently 64-bit PCI BARs are unconditionally mapped by BIOS right over 4G + RamSizeOver4G location, which doesn't allow to reserve extra space before 64-bit PCI window. For memory hotplug an extra RAM space might be reserved after

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-13 Thread Michael S. Tsirkin
On Sun, Oct 13, 2013 at 05:11:54PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 15:31:23 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 02:13:44PM +0200, Igor Mammedov wrote: Currently 64-bit PCI BARs are unconditionally mapped by BIOS right over 4G

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-13 Thread Michael S. Tsirkin
On Sun, Oct 13, 2013 at 06:23:28PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 18:59:20 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 05:11:54PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 15:31:23 +0300 Michael S. Tsirkin m...@redhat.com wrote

Re: [Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest

2013-10-13 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 12:34:46PM +0300, Michael S. Tsirkin wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi No new issues has been raised in a week, I assume it's ok to merge now. Will apply around tomorrow.

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-13 Thread Michael S. Tsirkin
On Sun, Oct 13, 2013 at 07:33:19PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 19:46:09 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 06:23:28PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 18:59:20 +0300 Michael S. Tsirkin m...@redhat.com wrote

Re: [Qemu-devel] [PATCH v3 0/4] acpi hotplug of devices behind a pci bridge

2013-10-13 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 12:21:26PM +0300, Michael S. Tsirkin wrote: This is on top of patchset generating ACPI tables in qemu. Please review and consider for 1.7. No comments, I assume it's ok to merge this. Changes from v2: - split new code out to a separate file: acpi/pcihp.c

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 12:27:26PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 23:28:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 07:33:19PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 19:46:09 +0300 Michael S. Tsirkin m...@redhat.com wrote

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 02:16:23PM +0200, Gerd Hoffmann wrote: Hi, And there is slight difference between PCI holes and PCI address space mappings represented by MemoryRegion-s in QEMU. Basically we only need to inform BIOS where to PCI address spaces start and simple

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 03:04:45PM +0200, Gerd Hoffmann wrote: Hi, To me it makes more sense to just go the direct route and say please put the 64bit bars at this location rather than indirect we might want hotplug $thatmuch memory and then expect the bios to leave that much

[Qemu-devel] qemu master build errors

2013-10-14 Thread Michael S. Tsirkin
/scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc; ^ /scm/qemu/exec.c: In function ‘qemu_ram_alloc_from_ptr’: /scm/qemu/exec.c:1107:32:

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-14 Thread Michael S. Tsirkin
On Fri, Oct 11, 2013 at 05:18:30PM +0800, liu ping fan wrote: On Fri, Oct 11, 2013 at 4:38 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/10/2013 04:59, liu ping fan ha scritto: On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 10, 2013 at 11:46

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-14 Thread Michael S. Tsirkin
On Fri, Oct 11, 2013 at 10:59:40AM +0800, liu ping fan wrote: On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto: Are you sure? This is not done

Re: [Qemu-devel] qemu master build errors

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 05:08:58PM +0300, Michael S. Tsirkin wrote: /scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc; ^ /scm/qemu

Re: [Qemu-devel] [PATCH] exec: Fix prototype of phys_mem_set_alloc and related functions

2013-10-14 Thread Michael S. Tsirkin
: In function 'qemu_ram_remap': exec.c:1283:21: error: comparison of distinct pointer types lacks a cast [-Werror] Signed-off-by: Stefan Weil s...@weilnetz.de Fixes build on 32 build boxes. Reviewed-by: Michael S. Tsirkin m...@redhat.com Tested-by: Michael S. Tsirkin m...@redhat.com Anthony

Re: [Qemu-devel] qemu master build errors

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 04:38:22PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: /scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc

[Qemu-devel] [PULL 04/43] hw/core: Add interface to allocate and free a single IRQ

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com qemu_allocate_irq returns a single qemu_irq. The interface allows to specify an interrupt number. qemu_free_irq frees it. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/irq.h | 7

[Qemu-devel] [PULL 01/43] memory: Change MemoryRegion priorities from unsigned to signed

2013-10-14 Thread Michael S. Tsirkin
no other region exists: rather than having to explicitly specify a high priority for all the other regions, we can let them take the default (zero) priority and specify a negative priority for the background region. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Michael S. Tsirkin m

[Qemu-devel] [PULL 03/43] hw/pci: partially handle pci master abort

2013-10-14 Thread Michael S. Tsirkin
the RECEIVED MASTER ABORT bit in the STATUS register of the device that initiated the transaction will be implemented in another series Signed-off-by: Marcel Apfelbaum marce...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Michael S. Tsirkin
- pci IRQ API rework by Marcel - acpi generation and pci bridge hotplug support by myself Everything has gone through several revisions, latest versions have been on list for a while without any more comments, tested by several people. Please pull for 1.7. Signed-off-by: Michael S. Tsirkin m

[Qemu-devel] [PULL 02/43] docs/memory: Explictly state that MemoryRegion priority is signed

2013-10-14 Thread Michael S. Tsirkin
no other region exists: rather than having to explicitly specify a high priority for all the other regions, we can let them take the default (zero) priority and specify a negative priority for the background region. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Michael S. Tsirkin

[Qemu-devel] [PULL 08/43] hw/vfio: set interrupts using pci irq wrappers

2013-10-14 Thread Michael S. Tsirkin
-off-by: Michael S. Tsirkin m...@redhat.com --- hw/misc/vfio.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index a1c08fb..9d02e49 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -297,7 +297,7 @@ static void vfio_intx_interrupt

[Qemu-devel] [PULL 05/43] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pci.h | 23 +++ hw/pci/pci.c | 26 ++ 2 files changed, 45 insertions(+), 4 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 4b90e5d..990342c 100644

[Qemu-devel] [PULL 09/43] hw: set interrupts using pci irq wrappers

2013-10-14 Thread Michael S. Tsirkin
state if not used anymore. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/audio/ac97.c| 4 ++-- hw/audio/es1370.c | 4 ++-- hw/audio/intel-hda.c | 2 +- hw/block/nvme.c| 2 +- hw/char/serial-pci.c | 5 +++-- hw

[Qemu-devel] [PULL 07/43] hw/vmxnet3: set interrupts using pci irq wrappers

2013-10-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/net/vmxnet3.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 49c2466..19687aa 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -336,7 +336,7 @@ static bool

[Qemu-devel] [PULL 16/43] fw_cfg: interface to trigger callback on read

2013-10-14 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c

[Qemu-devel] [PULL 19/43] pcie_host: expose address format

2013-10-14 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m

[Qemu-devel] [PULL 10/43] hw/pcie: AER and hot-plug events must use device's interrupt

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com The fields hpev_intx and aer_intx were removed because both AER and hot-plug events must use device's interrupt. Assert/deassert interrupts using pci irq wrappers instead. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S

[Qemu-devel] [PULL 17/43] loader: support for unmapped ROM blobs

2013-10-14 Thread Michael S. Tsirkin
...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/lm32/lm32_hwsetup.h | 2 +- include/hw/loader.h| 7 --- hw/core/loader.c | 23

<    1   2   3   4   5   6   7   8   9   10   >