Re: [Qemu-devel] [PATCH v4 6/6] KVM: s390: Wire up ioeventfd.

2013-02-28 Thread Michael S. Tsirkin
On Thu, Feb 28, 2013 at 10:22:32AM +0100, Cornelia Huck wrote: > Enable ioeventfd support on s390 and hook up diagnose 500 virtio-ccw > notifications. > > Signed-off-by: Cornelia Huck > --- > arch/s390/kvm/Kconfig| 1 + > arch/s390/kvm/Makefile | 2 +- > arch/s390/kvm/diag.c | 26 +++

Re: [Qemu-devel] [PATCH v5 0/6] kvm: Make ioeventfd usable on s390.

2013-02-28 Thread Michael S. Tsirkin
c bits in s390 kvm are acceptable, but looks ok to me too. Acked-by: Michael S. Tsirkin > Cornelia Huck (5): > KVM: s390: Export virtio-ccw api. > KVM: Initialize irqfd from kvm_init(). > KVM: Introduce KVM_VIRTIO_CCW_NOTIFY_BUS. > KVM: ioeventfd for virtio-ccw devices. >

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-28 Thread Michael S. Tsirkin
On Thu, Feb 21, 2013 at 11:02:31AM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Feb 21, 2013 at 10:15:58AM -0600, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Thu, Feb 21, 2

Re: [Qemu-devel] [PATCH] pci: Teach PCI Bridges about VGA routing

2013-02-28 Thread Michael S. Tsirkin
On Thu, Feb 28, 2013 at 12:00:03PM -0700, Alex Williamson wrote: > Each PCI Bridge has a set of implied VGA regions that are enabled > when the VGA bit is set in the bridge control register. This allows > VGA devices behind bridges. > > Signed-off-by: Alex Williamson > --- > hw/pci/pci_bridge.c

Re: [Qemu-devel] [PATCH] pci: Teach PCI Bridges about VGA routing

2013-02-28 Thread Michael S. Tsirkin
On Thu, Feb 28, 2013 at 01:34:39PM -0700, Alex Williamson wrote: > On Thu, 2013-02-28 at 22:26 +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 28, 2013 at 12:00:03PM -0700, Alex Williamson wrote: > > > Each PCI Bridge has a set of implied VGA regions that are enabled > > &

Re: [Qemu-devel] [PATCH v2] pci: Teach PCI Bridges about VGA routing

2013-03-01 Thread Michael S. Tsirkin
On Thu, Feb 28, 2013 at 02:58:13PM -0700, Alex Williamson wrote: > Each PCI Bridge has a set of implied VGA regions that are enabled > when the VGA bit is set in the bridge control register. This allows > VGA devices behind bridges. > > Signed-off-by: Alex Williamson Off-topic: As I was review

[Qemu-devel] [PULL] virtio,vhost,pci,e1000

2013-03-03 Thread Michael S. Tsirkin
by Laszlo. Signed-off-by: Michael S. Tsirkin Alexey Korolev (1): Fix guest OS hang when 64bit PCI bar present Gal Hammer (1): Set virtio-serial device to have a default of 2 MSI vectors. Laszlo Ersek (1): ICH9 LPC: Res

Re: [Qemu-devel] [PATCH v4 2/2] pci: Teach PCI Bridges about VGA routing

2013-03-04 Thread Michael S. Tsirkin
On Sun, Mar 03, 2013 at 10:21:32AM -0700, Alex Williamson wrote: > Each PCI Bridge has a set of implied VGA regions that are enabled when > the VGA bit is set in the bridge control register. This allows VGA > devices behind bridges. Unfortunately with VGA Enable, which we > formerly allowed but d

Re: [Qemu-devel] [PATCH v4 0/2] PCI learns about VGA

2013-03-04 Thread Michael S. Tsirkin
On Sun, Mar 03, 2013 at 10:21:20AM -0700, Alex Williamson wrote: > Bridges aren't the only thing that needs to know about VGA, any class > VGA device can register for VGA. This adds infrastructure to PCI to > allow devices to register VGA regions and incorporates the previous > PCI bridge only pat

[Qemu-devel] [PATCH] pci_bridge: factor out common code

2013-03-04 Thread Michael S. Tsirkin
Reuse common code in pcie_port, override the hardwired-to-0 bits per PCI Express spec. No functional change but makes the code easier to follow. Signed-off-by: Michael S. Tsirkin --- Alex, I applied the following on top of your patch and did a dump of the config space to verify nothing changed

Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions

2013-03-04 Thread Michael S. Tsirkin
On Sun, Mar 03, 2013 at 09:01:11AM +, Blue Swirl wrote: > On Sun, Mar 3, 2013 at 6:13 AM, Peter Crosthwaite > wrote: > > This struct and functions provide some encapsulation of the uint32_t type to > > make it more friendly for use as guest accessible device state. Bits of > > device > > stat

Re: [Qemu-devel] Block I/O optimizations

2013-03-04 Thread Michael S. Tsirkin
On Sun, Mar 03, 2013 at 11:35:27AM +0200, Abel Gordon wrote: > > > Stefan Hajnoczi wrote on 01/03/2013 12:54:54 PM: > > > On Thu, Feb 28, 2013 at 08:20:08PM +0200, Abel Gordon wrote: > > > Stefan Hajnoczi wrote on 28/02/2013 04:43:04 PM: > > > > I think extending and tuning the existing mecha

Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug

2013-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2013 at 05:55:19PM +1100, Alexey Kardashevskiy wrote: > Hi! > > The patch f56a12475ff1b8aa61210d08522c3c8aaf0e2648 "vhost: backend > masking support" breaks virtio-net + vhost=on on PPC64 platform. > > The problem command line is: > 1) -netdev tap,id=tapnet,ifname=tap0,script=qemu

Re: [Qemu-devel] [PATCH v5 6/6] KVM: s390: Wire up ioeventfd.

2013-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2013 at 09:13:08AM +0100, Cornelia Huck wrote: > On Mon, 4 Mar 2013 21:07:41 -0300 > Marcelo Tosatti wrote: > > > On Thu, Feb 28, 2013 at 12:33:21PM +0100, Cornelia Huck wrote: > > > Enable ioeventfd support on s390 and hook up diagnose 500 virtio-ccw > > > notifications. > > > >

Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions

2013-03-05 Thread Michael S. Tsirkin
On Mon, Mar 04, 2013 at 08:52:33PM +, Blue Swirl wrote: > On Mon, Mar 4, 2013 at 9:44 AM, Michael S. Tsirkin wrote: > > On Sun, Mar 03, 2013 at 09:01:11AM +, Blue Swirl wrote: > >> On Sun, Mar 3, 2013 at 6:13 AM, Peter Crosthwaite > >> wrote: > >> >

Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug

2013-03-05 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 12:21:47AM +1100, Alexey Kardashevskiy wrote: > On 05/03/13 23:56, Michael S. Tsirkin wrote: > >>The patch f56a12475ff1b8aa61210d08522c3c8aaf0e2648 "vhost: backend > >>masking support" breaks virtio-net + vhost=on on PPC64 platform. >

Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions

2013-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2013 at 03:17:13PM +0100, Gerd Hoffmann wrote: > Hi, > > We also need uint8_t, uint16_t and uint64_t versions for some devices. > Perhaps it would be better to implement a uint64_t device which can be > used with shorter widths or even stronger connection with memo

Re: [Qemu-devel] [PATCH] virito-net: remove layout assumption for multiqueue ctrl

2013-03-05 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 01:50:27PM +0800, Jason Wang wrote: > Follow commit 921ac5d0f3a0df869db5ce4edf752f51d8b1596a (virtio-net: remove > layout assumptions for ctrl vq), this patch makes multiqueue ctrl handling not > reply on the layout of descriptors. > > Signed-off-by: Jason Wang Applied, t

Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug

2013-03-06 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 09:57:40AM +1100, Alexey Kardashevskiy wrote: > On 06/03/13 01:23, Michael S. Tsirkin wrote: > >On Wed, Mar 06, 2013 at 12:21:47AM +1100, Alexey Kardashevskiy wrote: > >>On 05/03/13 23:56, Michael S. Tsirkin wrote: > >>>>The patch f56a124

[Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when does the removal complete. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index b2698e4..ec5b810

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 02:57:22PM +0100, Andreas Färber wrote: > Am 06.03.2013 14:00, schrieb Michael S. Tsirkin: > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when does the > > removal complete. Add an event so

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 07:44:32AM -0700, Eric Blake wrote: > On 03/06/2013 06:00 AM, Michael S. Tsirkin wrote: > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when does the > > removal complete. Add an event so

[Qemu-devel] [PATCH] pci_bridge: drop formatting from source

2013-03-06 Thread Michael S. Tsirkin
We use the same formatting for all files, it doesn't make sense to have formatting directives only in pci bridge header. Signed-off-by: Michael S. Tsirkin --- hw/pci/pci_bridge.h | 8 1 file changed, 8 deletions(-) diff --git a/hw/pci/pci_bridge.h b/hw/pci/pci_bridge.h index 9d

[Qemu-devel] [PATCH] migration: move ram migration support

2013-03-06 Thread Michael S. Tsirkin
Move RAM migration code from arch_init to migration-ram. This is just code reorganization, no functional changes. Signed-off-by: Michael S. Tsirkin --- Makefile.target | 2 +- arch_init.c | 758 - migration-ram.c | 799

Re: [Qemu-devel] [PATCHv2] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 05:52:05PM +0100, Paolo Bonzini wrote: > Il 06/03/2013 17:49, Michael S. Tsirkin ha scritto: > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when the > > removal completes. Add an event so

[Qemu-devel] [PATCHv2] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- Changes from v1: - move to device_unparent - address comments by Andreas

[Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- Changes from v2: - move event toward the end of device_unparent, so

Re: [Qemu-devel] [PATCH V7 0/5] Send the gratuitous by guest

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:23:46PM +0800, Jason Wang wrote: > This series tries to let guest instead of qemu to send the gratuitous packets > after migration when guest is capable of doing this. This is needed since it's > impossible for qemu to keep track of all configurations (e.g 802.1Q) and mac

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 10:55:23AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Mar 06, 2013 at 02:57:22PM +0100, Andreas Färber wrote: > >> Am 06.03.2013 14:00, schrieb Michael S. Tsirkin: > >> > libvirt has a

Re: [Qemu-devel] [PATCH V7 0/5] Send the gratuitous by guest

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 06:13:41PM +0800, Jason Wang wrote: > On 03/07/2013 06:04 PM, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 04:23:46PM +0800, Jason Wang wrote: > >> This series tries to let guest instead of qemu to send the gratuitous > >> packets >

Re: [Qemu-devel] [PATCH V7 0/5] Send the gratuitous by guest

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 06:33:30PM +0800, Jason Wang wrote: > On 03/07/2013 06:25 PM, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 06:13:41PM +0800, Jason Wang wrote: > >> On 03/07/2013 06:04 PM, Michael S. Tsirkin wrote: > >>> On Thu, Mar 07, 2013 at 04:2

[Qemu-devel] [PATCHv2] migration: move ram migration support

2013-03-07 Thread Michael S. Tsirkin
Move RAM migration code from arch_init to savevm-ram. Signed-off-by: Michael S. Tsirkin --- Note: this is on top of Juan's pull request Changes from v1: - renamed source file, rebased on top of migration.next as suggested by Paolo Makefile.target | 2 +- arch_init.c

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: > Andreas Färber writes: > > > Am 07.03.2013 11:07, schrieb Michael S. Tsirkin: > >> On Thu, Mar 07, 2013 at 10:55:23AM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writ

Re: [Qemu-devel] [PATCHv2] migration: move ram migration support

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:20:48PM +0100, Paolo Bonzini wrote: > Il 07/03/2013 14:32, Michael S. Tsirkin ha scritto: > > +#ifdef DEBUG_ARCH_INIT > > +#define DPRINTF(fmt, ...) \ > > +do { fprintf(stdout, "arch_init: " fmt, ## __VA_ARGS__); } while (0) > >

[Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- Changes from v3: - Document that we only emit events for devices with

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 10:44:18AM -0600, Anthony Liguori wrote: > Andreas Färber writes: > > > Am 07.03.2013 17:27, schrieb Christian Borntraeger: > >>> It's a bug in both virtio-ccw that features=0 when get_features is > >>> called. You can also tell this with: > >>> > >>> [10:02 AM] anthony@t

[Qemu-devel] virtio-s390: document GPR4/GPR2 cookie values

2013-03-07 Thread Michael S. Tsirkin
virtio-s390 on kvm can use a cookie value passed to guest to optimize channel/VQ lookups. Document this. Signed-off-by: Michael S. Tsirkin --- diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 72d956c..91aed06 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -10627,7 +10626,252 @@ Guest

Re: [Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 11:39:21AM -0600, Anthony Liguori wrote: > Markus Armbruster writes: > > > "Michael S. Tsirkin" writes: > > > >> libvirt has a long-standing bug: when removing the device, > >> it can request removal but does not know when

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: > >> Andreas Färber writes: > >> > >> > Am 07.03.2013 11:07, schrieb Mi

[Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- At Anthony's request, reposting with a corrected subject. Sorry about the

Re: [Qemu-devel] [PATCH] pci: Fix INTx routing notifier recursion

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 11:29:19AM -0700, Alex Williamson wrote: > For some reason we recurse to fire the INTx routing notifier for each > child of a bus, for each possible device of a bus. That means that if > we add a root port, the notifier gets called for that bridge 256 > times. If we add an

Re: [Qemu-devel] [PATCH] xio3130: Add map_irq functions

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 11:29:46AM -0700, Alex Williamson wrote: > Just like root ports, I think these are supposed to be direct mapped. > > Signed-off-by: Alex Williamson Hmm, very strange. Why not using standard pci bridge logic? Any idea? > --- > hw/xio3130_downstream.c |7 +++ > hw

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 08:00:29PM +0100, Andreas Färber wrote: > Am 07.03.2013 19:12, schrieb Michael S. Tsirkin: > > On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >>> On Thu, Mar 07,

Re: [Qemu-devel] [PATCH] xio3130: Add map_irq functions

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 12:17:11PM -0700, Alex Williamson wrote: > On Thu, 2013-03-07 at 20:49 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 11:29:46AM -0700, Alex Williamson wrote: > > > Just like root ports, I think these are supposed to be direct mapped. >

Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when the > > removal completes. Add an event

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 09:18:48PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On

Re: [Qemu-devel] [PATCH] xio3130: Add map_irq functions

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 12:31:00PM -0700, Alex Williamson wrote: > On Thu, 2013-03-07 at 21:22 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 12:17:11PM -0700, Alex Williamson wrote: > > > On Thu, 2013-03-07 at 20:49 +0200, Michael S. Tsirkin wrote: > > > &

Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug

2013-03-10 Thread Michael S. Tsirkin
net using the old -net interface? Not at the moment. Why do you want to use it? > > On 06/03/13 21:31, Michael S. Tsirkin wrote: > >On Wed, Mar 06, 2013 at 09:57:40AM +1100, Alexey Kardashevskiy wrote: > >>On 06/03/13 01:23, Michael S. Tsirkin wrote: > &g

Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-10 Thread Michael S. Tsirkin
On Fri, Mar 08, 2013 at 08:58:43AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > libvirt ha

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate fu

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate fu

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Sun, Mar 10, 2013 at 12:13:27PM -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > > Rather than have everyone call pci_bridge_map_irq() themselves and > >

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Sun, Mar 10, 2013 at 12:15:11PM -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 12:13 -0600, Alex Williamson wrote: > > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > >

Re: [Qemu-devel] [PATCH 0/2] pci: handle zero size ROM files gracefully

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 10:20:19AM +0100, Stefan Hajnoczi wrote: > This is a fix for https://bugs.launchpad.net/qemu/+bug/1127053. > > If pxe-e1000.rom has 0 size we allocate the same RAMBlock offset twice and > fail > with an assertion in qemu_ram_set_idstr() later on. > > Two fixes: > > 1. Pr

Re: [Qemu-devel] [RFC PATCH RDMA support v3: 03/10] documentation of RDMA protocol in docs/rdma.txt

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 12:33:27AM -0400, michael.r.hines.mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > > Signed-off-by: Michael R. Hines > --- > docs/rdma.txt | 93 > + > 1 file changed, 93 insertions(+) > create

Re: [Qemu-devel] [RFC PATCH RDMA support v3: 03/10] documentation of RDMA protocol in docs/rdma.txt

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 01:17:19PM -0400, Michael R. Hines wrote: > On 03/11/2013 01:05 PM, Michael S. Tsirkin wrote: > >Well that's exactly the question. As far as I remember the RDMA > >memory model, you need to know a key and address to execute RDMA > >writes. Remo

Re: [Qemu-devel] [RFC PATCH RDMA support v3: 03/10] documentation of RDMA protocol in docs/rdma.txt

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 12:24:53PM -0400, Michael R. Hines wrote: > Excellent questions: answers inline. > > On 03/11/2013 07:51 AM, Michael S. Tsirkin wrote: > >+RDMA-based live migration protocol > >+== > >+ > >+

Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
On Fri, Mar 08, 2013 at 07:36:28AM -0600, Anthony Liguori wrote: > Markus Armbruster writes: > > > "Michael S. Tsirkin" writes: > > > >> On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" w

[Qemu-devel] [PATCHv5 0/3] DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
ff-by: Michael S. Tsirkin Changes from v4: - Add extra triggers and extra fields as requested by Markus Changes from v3: - Document that we only emit events for devices with and ID, as suggested by Markus Changes from v2: - move event toward the end of device_unparent, so that pa

[Qemu-devel] [PATCHv5 2/3] qom: pass original path to unparent method

2013-03-11 Thread Michael S. Tsirkin
We need to know the original path since unparenting loses this state. Signed-off-by: Michael S. Tsirkin --- hw/qdev.c| 4 ++-- include/qom/object.h | 3 ++- qom/object.c | 4 +++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index

[Qemu-devel] [PATCHv5 3/3] qmp: add path to device_deleted event

2013-03-11 Thread Michael S. Tsirkin
Add QOM path to device deleted event. It now becomes useful to report it for devices which don't have an ID assigned. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt | 9 + hw/qdev.c | 11 --- 2 files changed, 13 insertions(+), 7 deletions(-) diff --

[Qemu-devel] [PATCHv5 1/3] qdev: DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt| 17 + hw/qdev.c | 6

Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 02:26:58PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Mar 08, 2013 at 07:36:28AM -0600, Anthony Liguori wrote: > >> Markus Armbruster writes: > >> > >> > "Michael S. Tsirkin&qu

Re: [Qemu-devel] [RFC PATCH] pci: Differentiate PCI Express bus

2013-03-12 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 03:18:49PM -0600, Alex Williamson wrote: > When creating capabilities devices need to know what kind of bus > they're on. If we're on an express bus without a parent_dev, then > we're on the root complex and need to use integrated endpoints > rather than standard endpoints.

Re: [Qemu-devel] [RFC PATCH] pci: Differentiate PCI Express bus

2013-03-12 Thread Michael S. Tsirkin
On Tue, Mar 12, 2013 at 09:36:49AM -0600, Alex Williamson wrote: > On Tue, 2013-03-12 at 16:46 +0200, Michael S. Tsirkin wrote: > > On Mon, Mar 11, 2013 at 03:18:49PM -0600, Alex Williamson wrote: > > > When creating capabilities devices need to know what kind of bus > > &g

Re: [Qemu-devel] [RFC PATCH] pci: Differentiate PCI Express bus

2013-03-12 Thread Michael S. Tsirkin
On Tue, Mar 12, 2013 at 10:25:20AM -0600, Alex Williamson wrote: > On Tue, 2013-03-12 at 17:50 +0200, Michael S. Tsirkin wrote: > > On Tue, Mar 12, 2013 at 09:36:49AM -0600, Alex Williamson wrote: > > > On Tue, 2013-03-12 at 16:46 +0200, Michael S. Tsirkin wrote: > > > &

Re: [Qemu-devel] [PATCHv5 0/3] DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2013 at 08:45:51AM +0100, Markus Armbruster wrote: > Anthony asked for a space between "PATCH" and "v" in the subject. > Please try to remember next time. > > "Michael S. Tsirkin" writes: > > > libvirt has a long-standing bug: w

[Qemu-devel] [PATCH v6 0/3] DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
downstreams without QOM would want to only take the first patch). Event without fields is still useful as management can use it to poll device list to figure out which device was removed. Signed-off-by: Michael S. Tsirkin Changes from v5: - Emit an empty event on unnamed devices in patch 1/3, as

[Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt| 16 hw/qdev.c | 12

[Qemu-devel] [PATCH v6 2/3] qom: pass original path to unparent method

2013-03-13 Thread Michael S. Tsirkin
We need to know the original path since unparenting loses this state. Signed-off-by: Michael S. Tsirkin --- hw/qdev.c| 4 ++-- include/qom/object.h | 3 ++- qom/object.c | 4 +++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index

[Qemu-devel] [PATCH v6 3/3] qmp: add path to device_deleted event

2013-03-13 Thread Michael S. Tsirkin
Add QOM path to device deleted event. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt | 4 +++- hw/qdev.c | 9 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 24cf3e8..dcc826d 100644 --- a/QMP/qmp

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2013 at 06:31:57PM +0100, Paolo Bonzini wrote: > > We could do that purely > > with AioContexts as well, but that rules out a large class of > > backends that offloaded event loops can interact with, such as Chardevs, > > so I think modelling how to handle both will provide a thread

[Qemu-devel] [PATCH] virtio-pci: guest notifier mask without non-irqfd

2013-03-13 Thread Michael S. Tsirkin
. Reported-by: Alexey Kardashevskiy Signed-off-by: Michael S. Tsirkin --- Alexey, the following is a clean way to fix the problem that you reported "Re: QEMU -netdev vhost=on + -device virtio-net-pci bug" (previous patch was a quick hack but not I think a good fix). Lightly tested on x

Re: [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when the > > removal completes. Add an event

Re: [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when the > > removal completes. Add an event

Re: [Qemu-devel] [PATCH V2 WIP 0/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 05:25:42PM +0800, Asias He wrote: > On Thu, Mar 14, 2013 at 12:25:14PM +0800, Asias He wrote: > > On Tue, Mar 12, 2013 at 02:29:40PM +0800, Asias He wrote: > > > This is on top of Paolo and Nick's work. > > > > > > Current status: > > > Works now (guest boots fine, no hang

Re: [Qemu-devel] [PATCH V2 WIP 0/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 11:00:24AM +0100, Paolo Bonzini wrote: > > >> --- 8 ---> seabios patch: > >> diff --git a/src/virtio-scsi.c b/src/virtio-scsi.c > >> index 879ddfb..4de1255 100644 > >> --- a/src/virtio-scsi.c > >> +++ b/src/virtio-scsi.c > >> @@ -147,6 +147,9 @@ init

Re: [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 01:13:54PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > [...] > >> > diff --git a/

[Qemu-devel] [PATCH v7 2/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt| 16 hw/qdev.c | 10

[Qemu-devel] [PATCH v7 0/3] DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
downstreams without QOM would want to only take the first patch). Event without fields is still useful as management can use it to poll device list to figure out which device was removed. Signed-off-by: Michael S. Tsirkin Changes from v6: - make empty event use data: {}, Markus prefers this

[Qemu-devel] [PATCH v8 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt| 16 hw/qdev.c | 10

[Qemu-devel] [PATCH v8 3/3] qmp: add path to device_deleted event

2013-03-14 Thread Michael S. Tsirkin
Add QOM path to device deleted event. It now becomes useful to report it for devices which don't have an ID assigned. Signed-off-by: Michael S. Tsirkin --- QMP/qmp-events.txt | 4 +++- hw/qdev.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/QM

[Qemu-devel] [PATCH v8 0/3] DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
downstreams without QOM would want to only take the first patch). Event without fields is still useful as management can use it to poll device list to figure out which device was removed. Signed-off-by: Michael S. Tsirkin If there are no more comments I'll stick this on my pci branch. Changes

[Qemu-devel] [PATCH v8 2/3] qom: pass original path to unparent method

2013-03-14 Thread Michael S. Tsirkin
We need to know the original path since unparenting loses this state. Signed-off-by: Michael S. Tsirkin --- hw/qdev.c| 4 ++-- include/qom/object.h | 3 ++- qom/object.c | 4 +++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-14 Thread Michael S. Tsirkin
ox users have reported > again this bug with guest kernel 2.6.32. (proxmox host is rhel 6.3 kernel + > qemu 1.4) > > > > - Mail original - > > De: "Davide Guerri" > À: "Alexandre DERUMIER" > Cc: "Peter Lieven" , "M

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-17 Thread Michael S. Tsirkin
On Fri, Mar 15, 2013 at 08:23:44AM +0100, Peter Lieven wrote: > On 15.03.2013 00:04, Davide Guerri wrote: > >Yes this is definitely an option :) > > > >Just for curiosity, what is the effect of "in-kernel irqchip"? > > it emulates the irqchip in-kernel (in the KVM kernel module) which > avoids use

Re: [Qemu-devel] [PATCH 1/2] virtio-scsi: Set _DRIVER_OK flag before scsi target scanning

2013-03-17 Thread Michael S. Tsirkin
> Acked-by: Paolo Bonzini Acked-by: Michael S. Tsirkin > --- > src/virtio-scsi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/virtio-scsi.c b/src/virtio-scsi.c > index 879ddfb..4de1255 100644 > --- a/src/virtio-scsi.c &g

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi: Pack struct virtio_scsi_{req_cmd, resp_cmd}

2013-03-17 Thread Michael S. Tsirkin
On Fri, Mar 15, 2013 at 09:45:16AM +0800, Asias He wrote: > Device needs the exact size of these data structure. Prevent padding. > > This fixes guest hang when booting seabios + tcm_vhost. > > Signed-off-by: Asias He Acked-by: Michael S. Tsirkin > --- > src/virtio-scsi

Re: [Qemu-devel] [PATCH 0/7] pci: Create PCI Express bus type

2013-03-17 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 04:00:53PM -0600, Alex Williamson wrote: > When setting PCIe capabilities we need to know the type of bus we > have. On secondary buses we could poke around on the parent bridge > device to infer this data, but on root buses there's no parent device. > By creating a new PCI

Re: [Qemu-devel] [PATCH 7/7] pcie: Mangle types to match topology

2013-03-17 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 04:01:35PM -0600, Alex Williamson wrote: > Windows will fail to start drivers for devices with an Endpoint type > PCIe capability attached to a Root Complex (code 10 - Device cannot > start). The proper type for such a device is Root Complex Integrated > Endpoint. Devices

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2013-03-18 Thread Michael S. Tsirkin
est with 2.6.32 kernel. > > do you think that +x2apic in guest cpu could help ? > > (I think it's enable by default in RHEV/OVIRT ? but not in proxmox) > > > > ----- Mail original - > > De: "Michael S. Tsirkin" > À: "Peter Lieven&

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-18 Thread Michael S. Tsirkin
On Sun, Mar 17, 2013 at 11:18:56PM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This tries to cover all the questions I got the last time. > > Please do tell me what is not clear, and I'll revise again. > > Signed-off-by: Michael R. Hines > --- > docs/rdma.txt | 20

[Qemu-devel] [PULL] virtio,pci,qom

2013-03-18 Thread Michael S. Tsirkin
myself. Signed-off-by: Michael S. Tsirkin Alex Williamson (12): pci: Add PCI VGA helpers pci: Teach PCI Bridges about VGA routing pci: Fix INTx routing notifier recursion pci_bridge: Use a default map_irq

Re: [Qemu-devel] [PATCH v8 2/3] qom: pass original path to unparent method

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 09:24:16AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > We need to know the original path since unparenting loses this state. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/qdev.c

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 04:24:44PM -0400, Michael R. Hines wrote: > On 03/18/2013 06:40 AM, Michael S. Tsirkin wrote: > >I think there are two things here, API documentation and protocol > >documentation, protocol documentation still needs some more work. > >Also if what I

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 07:23:53PM -0400, Michael R. Hines wrote: > On 03/18/2013 05:26 PM, Michael S. Tsirkin wrote: > > > >Probably but I haven't mentioned ballooning at all. > > > >memory overcommit != ballooning > > Sure, then setting ballooning a

Re: [Qemu-devel] [PATCH v3 0/2] future proof rom loading for cross versiom migration

2013-08-18 Thread Michael S. Tsirkin
On Tue, Aug 13, 2013 at 01:43:29AM +0300, Michael S. Tsirkin wrote: > Changes from v2: address comments on v2 by Peter Maydell > - switch from global constant to function > - use memory_region_init_ram instead of _ram_ptr > - disable for 1.6 > > Changes from v1: a

[Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-18 Thread Michael S. Tsirkin
Make 1.4 compat code call the 1.6 one, reducing code duplication. Add comment explaining why we can't make 1.4 call 1.5 as usual. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 4 ++-- hw/i386/pc_q35.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH v2] spapr-pci: fix config space access to support bridges

2013-08-19 Thread Michael S. Tsirkin
possible for devices other that on a primary bus. > > This fixed find_dev() by using the PCI API pci_find_device() function. > This effectively enabled pci bridges on spapr. > > Signed-off-by: Alexey Kardashevskiy > --- Acked-by: Michael S. Tsirkin > > Does not it ma

Re: [Qemu-devel] [PATCH 1/2] kvm irqfd: support msimessage to irq translation in PHB

2013-08-19 Thread Michael S. Tsirkin
On Wed, Aug 07, 2013 at 06:51:32PM +1000, Alexey Kardashevskiy wrote: > On PPC64 systems MSI Messages are translated to system IRQ in a PCI > host bridge. This is already supported for emulated MSI/MSIX but > not for irqfd where the current QEMU allocates IRQ numbers from > irqchip and maps MSIMess

<    2   3   4   5   6   7   8   9   10   11   >