Re: [Qemu-devel] [PATCH 3/3] vga-pci: add qext region to mmio

2014-09-29 Thread Michael S. Tsirkin
On Tue, Sep 23, 2014 at 02:30:57PM +0200, Gerd Hoffmann wrote: > Add a qemu extented register range to the standard vga mmio bar. > Right nowe there are two registers: One readonly register returning the > size of the region (so we can easily add more registers there if needed) > and one endian co

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-29 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 07:28:57PM +0200, Greg Kurz wrote: > On Thu, 18 Sep 2014 21:54:58 +0300 > "Michael S. Tsirkin" wrote: > > > Current support for bus master (clearing OK bit) > > together with the need to support guests which do not > > enable PCI b

Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 08:23:05AM +, Gonglei (Arei) wrote: > > Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error > > message > > > > Il 30/09/2014 10:12, Markus Armbruster ha scritto: > > > error_report() is just fine here. qerror_report() is never necessary in > > > H

[Qemu-devel] [PULL 3/5] pci-hotplug-old: avoid losing error message

2014-09-30 Thread Michael S. Tsirkin
From: Gonglei When scsi_bus_legacy_add_drive() produces an error, we will lose the error message. Using error_report to report it. Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Markus Armbruster Reviewed-by: Eric Blake Acked-by: Michael S. Tsirkin Signed-off-by: Michael S

[Qemu-devel] [PULL 2/5] Revert "virtio-pci: fix migration for pci bus master"

2014-09-30 Thread Michael S. Tsirkin
This reverts commit 4d43d3f3c8147ade184df9a1e9e82826edd39e19. Reported to break PPC guests. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw

[Qemu-devel] [PULL 0/5] pci, pc, virtio, misc bugfixes

2014-09-30 Thread Michael S. Tsirkin
to 28d16f38d0d5881f95b074cc802dae8cacc1bf58: vl: Adjust the place of calling mlockall to speedup VM's startup (2014-09-29 19:44:04 +0300) pci, pc, virtio, misc bugfixes A bunch of bugfixes. Signed-off-by: Michael S. Ts

[Qemu-devel] [PULL 5/5] vl: Adjust the place of calling mlockall to speedup VM's startup

2014-09-30 Thread Michael S. Tsirkin
VM's startup. Acked-by: Michael S. Tsirkin Signed-off-by: zhanghailiang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- vl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index dbdca59..9d2aaaf 100644 --- a/vl.c +++ b

[Qemu-devel] [PULL 1/5] loader: g_realloc(p, 0) frees and returns NULL, simplify

2014-09-30 Thread Michael S. Tsirkin
Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/elf_ops.h | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index c6b5129..a517753 100644 --- a/include/hw/elf_ops.h +++ b/include/hw

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 04:36:00PM +0800, Zhangjie (HZ) wrote: > Hi, > There exits packets loss when we do packet forwarding in VM, > especially when we use dpdk to do the forwarding. By enlarging vring > can alleviate the problem. I think this has to do with the fact that dpdk disables checksum o

Re: [Qemu-devel] [PATCH v3 00/12] virtio: fix virtio child recount in transports

2014-09-30 Thread Michael S. Tsirkin
gt; parent. > > Changes since v2: > - fix some typos about commit message in PATCH 12 (Cornelia/Paolo) > - add 'Reviewed-by' tag For series: Reviewed-by: Michael S. Tsirkin Paolo, pls feel free to apply this in your tree. > Thanks for review! > > Changs since v

Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports

2014-09-30 Thread Michael S. Tsirkin
pper function for better code sharing > >in PATCH 12 (Cornelia/Michael/Paolo) > > I would like to take these patches through the SCSI tree, because of a > small conflict with virtio-scsi dataplane. Any objections? > > Paolo Fine with me. Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
to "out" in PATCH 1 (Andreas) > 2. improve descriptions in PATCH 3 (Paolo, adding Signed-off-by Paolo in > this patch) > 3. rework PATCH 5, set description at qdev_property_add_static(), > then copy the description of target_obj.property. (Paolo) > 4. free description fil

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 11:02:35AM +0800, arei.gong...@huawei.com wrote: > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceState *dev, Property > *prop, char *dest, > PropertyInfo qdev_prop_pci_devfn = { > .name = "int32", Is this name used anywhere? It seems wrong ... > .legacy

Re: [Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev properties

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 11:02:39AM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > The legacy_name is useless now, the better help > information provied by description field of property. provided. Pls run ispell on comments. > > Cc: Paolo Bonzini > Cc: Mic

Re: [Qemu-devel] [PATCH v4 2/5] qom: add description field in ObjectProperty struct

2014-09-30 Thread Michael S. Tsirkin
source object on the target Object, set the object property's > description to the source object property's. I think by the above you mean "Copy property descriptions when copying alias properties"? > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Cc: Markus Armbr

Re: [Qemu-devel] [PATCH] smbios: Fix assertion on socket count calculation

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 12:07:17PM +0200, Igor Mammedov wrote: > On Mon, 29 Sep 2014 22:21:45 -0300 > Eduardo Habkost wrote: > > > QEMU currently allows the number of VCPUs to not be a multiple of the > > number of threads per socket, but the smbios socket count calculation > > introduced by comm

Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of pcie devices

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > In QEMU, ARI Forwarding is enabled default at emulation of PCIe > ports. ARI Forwarding enable setting at firmware/OS Control handoff. > If the bit is Set when a non-ARI Device is present, the non-ARI > D

[Qemu-devel] [PULL 4/5] pc-dimm: Don't check dimm->node when there is non-NUMA config

2014-09-30 Thread Michael S. Tsirkin
option and NUMA option. But not support Windows guest OS to hotplug memory with no-NUMA config, actully, it's Windows limitation. Reviewed-By: Igor Mammedov Signed-off-by: zhanghailiang Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/mem/pc-dimm.c | 2 +- 1 file ch

Re: [Qemu-devel] [PATCH v4 3/3] pcie: remove confused comments

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 06:11:26PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > The below functions is not allocation functions, but > find helper function. The only allocation function is > pcie_add_capability(), but its argument names is not the > same with the comments. So remove

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 09:14:50PM +0800, Gonglei wrote: > > Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in > > PropertyInfo struct > > > > On Tue, Sep 30, 2014 at 11:02:35AM +0800, arei.gong...@huawei.com wrote: > > > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceS

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 03:36:22PM +0200, Paolo Bonzini wrote: > Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto: > > > > > > > The Propertyinfo.name is used to the qdev property's type, please see > > > PATCH 4: > > > > > > -

Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of pcie devices

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 09:38:51PM +0800, Gonglei wrote: > > Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability > > of > > pcie devices > > > > On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > In QEMU, ARI Forwardin

Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 03:53:53PM +0200, Paolo Bonzini wrote: > Il 30/09/2014 15:55, Michael S. Tsirkin ha scritto: > > > At the QOM level it is an int, even though it secondarily accepts a > > > string in "DD.F" format. > > > > That's the only

Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-30 Thread Michael S. Tsirkin
The descriptions can serve as documentation in the code, > and they can be used to provide better help. I'm fine with merging this as is, and adding improvements on top. Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] translate-all.c: memory walker initial address miscalculation

2014-09-30 Thread Michael S. Tsirkin
to apply this, but it has been too long since this was posted. This seems to make sense superficially. Acked-by: Michael S. Tsirkin Riku? > --- > include/exec/cpu-all.h | 4 ++-- > linux-user/elfload.c | 18 +- > translate-all.c| 27 +

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: > On 2014-09-02 17:11, Michael Roth wrote: > > Quoting Markus Armbruster (2014-07-30 06:19:36) > >> Paolo Bonzini writes: > >> > >>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: > >>

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 10:05:38AM +0200, Jan Kiszka wrote: > On 2014-10-02 10:03, Michael S. Tsirkin wrote: > > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: > >> On 2014-09-02 17:11, Michael Roth wrote: > >>> Quoting Markus Armbruster (2014-07-30

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 11:32:42AM +0300, Gal Hammer wrote: > On 01/10/2014 11:58, Markus Armbruster wrote: > >Did this get stuck? > > I think so. Did I miss a comment which was not handled in the last version > of the patch? > > Gal. I don't think you did but you have to Cc maintainers if y

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Sep 18, 2014 at 06:17:48PM +0200, Paolo Bonzini wrote: > In the emergency last-minute patches of QEMU 2.1 we did two things: > > - fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in > ACPI table sizes > > - ensured that future versions will not break migration compatibili

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote: > Hi, > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > Generation ID device. > > The first one add a new ACPI directive which allow to use a 16-bytes > buffer in an ACPI table. This buffer is for storing the

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:12:53PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 17, 2014 at 02:39:50PM +0300, Gal Hammer wrote: > > Hi, > > > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > > Generation ID device. > > > >

Re: [Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:51PM +0300, Gal Hammer wrote: > Add a 16-bytes buffer to allow storing a 128-bit UUID value in an > ACPI table. > > Signed-off-by: Gal Hammer > Reviewed-by: Paolo Bonzini This one looks good. Applied, thanks! > --- > scripts/acpi_extract.py | 23 ++--

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table. > > The GUID is set using a new "vmgenid" device. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 3/6] pc/vl: Add units-per-default-bus property

2014-10-02 Thread Michael S. Tsirkin
is adjusted based on the fact that the default IF > for the Q35 machine type is IF_IDE, and units-per-default-bus > overrides the IDE mapping from its default of 2 units per bus > to just 1 unit per bus. > > Signed-off-by: John Snow Reviewed-by: Michael S. Tsirkin > --- >

Re: [Qemu-devel] [PATCH v3 5/6] qtest/bios-tables: Correct Q35 command line

2014-10-02 Thread Michael S. Tsirkin
ts this test to always use > the full, non-sugared -device/-drive syntax > for both PC and Q35. > > Signed-off-by: John Snow Reviewed-by: Michael S. Tsirkin > --- > tests/bios-tables-test.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 6/6] q35/ahci: Pick up -cdrom and -hda options

2014-10-02 Thread Michael S. Tsirkin
On Wed, Oct 01, 2014 at 02:19:29PM -0400, John Snow wrote: > This patch implements the backend for the Q35 board > for us to be able to pick up and use drives defined > by the -cdrom, -hda, or -drive if=ide shorthand options. > > Signed-off-by: John Snow Reviewed-by: Mic

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 04:14:05PM +0300, Gal Hammer wrote: > On 02/10/2014 15:49, Michael S. Tsirkin wrote: > >On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: > >>Based on Microsoft's sepecifications (paper can be dowloaded from > >>http://go.microsoft

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 14:11, Michael S. Tsirkin ha scritto: > > Summarizing what you say, there are two issues around ACPI tables: > > - linuxboot uses FW CFG to for memory allocations, > > seabios ignores that, s

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 03:43:35PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 15:41, Michael S. Tsirkin ha scritto: > > On Thu, Oct 02, 2014 at 03:30:57PM +0200, Paolo Bonzini wrote: > >> These patches do fix John's scenario, but that is not the main issue. > >>

Re: [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-10-05 Thread Michael S. Tsirkin
On Sun, Oct 05, 2014 at 08:26:45AM -0400, Paolo Bonzini wrote: > > > > If you were just objecting to the fact that pc-1.0 was made to > > > > be an alias of either one or the other at compile time, simply > > > > drop the second patch of the v2 patchset. > > > > > > I was objecting to making pc-1.

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 03:42:01PM +0200, Paolo Bonzini wrote: > Il 02/10/2014 15:49, Michael S. Tsirkin ha scritto: > >>> The issue is that incoming migration might have a different > >>> fw_cfg size from what we have. > >> > >> Understood now. >

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 03:55:49PM +0200, Paolo Bonzini wrote: > Il 06/10/2014 15:52, Michael S. Tsirkin ha scritto: > > Maybe we should just modify ACPI and rom files in general to use > > something else, not RAM? > > It looked like a good fit initially so we went ahead w

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > On Wed, 17 Sep 2014 20:39:25 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > > > On Sun, 14 Sep 2014 21:30:36 +0300 > > > "Mi

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 06:46:17PM +0200, Greg Kurz wrote: > On Mon, 6 Oct 2014 19:26:21 +0300 > "Michael S. Tsirkin" wrote: > > On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > > > On Wed, 17 Sep 2014 20:39:25 +0300 > > > "Michael S. T

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-07 Thread Michael S. Tsirkin
On Tue, Sep 30, 2014 at 10:43:09AM +0800, Chen, Tiejun wrote: > On 2014/9/29 18:01, Michael S. Tsirkin wrote: > >On Sun, Sep 28, 2014 at 10:59:05AM +0800, Chen, Tiejun wrote: > >>On 2014/9/3 9:40, Kay, Allen M wrote: > >>> > >>> > >>>>-

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-07 Thread Michael S. Tsirkin
On Sun, Sep 28, 2014 at 01:38:43PM +0800, Chen, Tiejun wrote: > >**errp) > >{ > > uint32_t value = 0; > > XenHostPCIDevice hdev; > > int r = 0, num; > > > > r = xen_host_pci_device_get(&hdev, 0, 0, 0x02, 0); > > if (!r) { > > value = hdev.device_id; > > > > num =

Re: [Qemu-devel] [PATCH] pcie: change confused comment clearer

2014-10-07 Thread Michael S. Tsirkin
On Tue, Oct 07, 2014 at 02:53:48PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > This comment applies to all functions below it. > It is not appropriate that called capability allocation > functions, change it into capability list management functions. > > Signed-off-by: Gonglei Ap

Re: [Qemu-devel] [PATCH] linuxboot: compute initrd loading address

2014-10-07 Thread Michael S. Tsirkin
QEMU <= 2.1. > > Signed-off-by: Paolo Bonzini Acked-by: Michael S. Tsirkin OK, and we need something similar for multiboot.S? Also - can we drop FW_CFG_INITRD_ADDR and the patching in load_linux now (unless running a compat machine type)? > --- > pc-bios/linuxboot.bin

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 03:17:56PM +0800, Zhangjie (HZ) wrote: > Thanks for your patient answer! :-) > > On 2014/9/30 17:33, Michael S. Tsirkin wrote: > > On Tue, Sep 30, 2014 at 04:36:00PM +0800, Zhangjie (HZ) wrote: > >> Hi, > >> There exits packets loss w

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 04:07:47PM +0800, Zhangjie (HZ) wrote: > MST, Thanks very much, I get it. > > On 2014/10/8 15:37, Michael S. Tsirkin wrote: > > On Wed, Oct 08, 2014 at 03:17:56PM +0800, Zhangjie (HZ) wrote: > >> Thanks for your patient answer! :-) > >> &

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 10:43:07AM +0300, Avi Kivity wrote: > > On 09/30/2014 12:33 PM, Michael S. Tsirkin wrote: > >a single descriptor might use all of > >the virtqueue. In this case we wont to be able to pass the > >descriptor directly to linux as a single iov,

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 12:51:21PM +0300, Avi Kivity wrote: > > On 10/08/2014 12:15 PM, Michael S. Tsirkin wrote: > >On Wed, Oct 08, 2014 at 10:43:07AM +0300, Avi Kivity wrote: > >>On 09/30/2014 12:33 PM, Michael S. Tsirkin wrote: > >>>a single descriptor might

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 01:37:25PM +0300, Avi Kivity wrote: > > On 10/08/2014 01:14 PM, Michael S. Tsirkin wrote: > >On Wed, Oct 08, 2014 at 12:51:21PM +0300, Avi Kivity wrote: > >>On 10/08/2014 12:15 PM, Michael S. Tsirkin wrote: > >>>On Wed, Oct 08, 2014 at 1

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
On Fri, Apr 05, 2013 at 04:54:39PM -0400, Michael R. Hines wrote: > To be more specific, here's what I did: > > 1. apply kernel module patch - re-insert module > 1. QEMU does: ibv_reg_mr(IBV_ACCESS_GIFT | IBV_ACCESS_REMOTE_READ) > 2. Start the RDMA migration > 3. Migration completes withou

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
On Tue, Apr 09, 2013 at 01:56:00PM -0400, Michael R. Hines wrote: > On 04/09/2013 12:39 PM, Michael S. Tsirkin wrote: > >On Fri, Apr 05, 2013 at 04:54:39PM -0400, Michael R. Hines wrote: > >>To be more specific, here's what I did: > >> > >>1. apply ker

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
presumably is_dup_page reads the page, so should not break COW ... I'm not sure about the cgroups swap limit - you might have too many non COW pages so attempting to fault them all in makes you exceed the limit. You really should look at what is going on in the pagemap, to see if there's measureab

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
On Fri, Apr 05, 2013 at 02:03:33PM -0700, Roland Dreier wrote: > On Fri, Apr 5, 2013 at 1:51 PM, Michael R. Hines > wrote: > > Sorry, I was wrong. ignore the comments about cgroups. That's still broken. > > (i.e. trying to register RDMA memory while using a cgroup swap limit cause > > the process

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
On Fri, Apr 05, 2013 at 01:43:49PM -0700, Roland Dreier wrote: > On Fri, Apr 5, 2013 at 1:17 PM, Michael R. Hines > wrote: > > I also removed the IBV_*_WRITE flags on the sender-side and activated > > cgroups with the "memory.memsw.limit_in_bytes" activated and the migration > > with RDMA also suc

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
On Fri, Apr 05, 2013 at 04:17:36PM -0400, Michael R. Hines wrote: > The userland part of the patch was missing (IBV_ACCESS_GIFT). > > I added flag that to /usr/include in addition to this patch and did > a test RDMA migrate and it seems to work without any problems. > > I also removed the IBV_*_W

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
On Tue, Apr 09, 2013 at 11:34:09PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 05, 2013 at 04:17:36PM -0400, Michael R. Hines wrote: > > The userland part of the patch was missing (IBV_ACCESS_GIFT). > > > > I added flag that to /usr/include in addition to this patch an

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
ch mechanism do you refer to? You patches still seem to pin each page in guest memory at some point, which will break all COW. In particular any pagemap tricks to detect duplicates on source that I suggested won't work. > On 04/09/2013 03:03 PM, Michael S. Tsirkin wrote: > >p

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-09 Thread Michael S. Tsirkin
Below is a great high level overview. the protocol looks correct. A bit more detail would be helpful, as noted below. The main thing I'd like to see changed is that there are already two protocols here: chunk-based and non chunk based. We'll need to use versioning and capabilities going forward bu

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 2/7] documentation (docs/rdma.txt)

2013-04-09 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 12:29:35AM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Verbose documentation is included, for both the protocol and > interface to QEMU. > > Additionally, there is a Features/RDMALiveMigration wiki as > well as a patch on github.com (hinesmr/qe

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-09 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 12:32:31AM -0400, Michael R. Hines wrote: > On 04/09/2013 11:24 PM, Michael S. Tsirkin wrote: > >Which mechanism do you refer to? You patches still seem to pin > >each page in guest memory at some point, which will break all COW. > >In particular

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 08/12] new capabilities added and check for QMP string 'rdma'

2013-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 10:07:47AM +0200, Paolo Bonzini wrote: > Il 10/04/2013 03:11, Michael R. Hines ha scritto: > > Actually, this capability needs to be a part of the same patch. > > > > RDMA must have the ability to turn this off or performance will die. > > Yes, but you can put it in a sepa

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 09:04:44AM -0400, Michael R. Hines wrote: > On 04/10/2013 01:27 AM, Michael S. Tsirkin wrote: > >Below is a great high level overview. the protocol looks correct. > >A bit more detail would be helpful, as noted below. > > > >The main thing I&#x

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-10 Thread Michael S. Tsirkin
> > This guy provides the source code which dumps several gigabytes over RDMA > to the other side. > > There's no need to run QEMU to test your patch, > assuming you have access to infiniband hardware. > > - Michael Does this app have any COW pages? > On 04/10/2

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 11:29:24AM -0400, Michael R. Hines wrote: > On 04/10/2013 09:34 AM, Michael S. Tsirkin wrote: > >On Wed, Apr 10, 2013 at 09:04:44AM -0400, Michael R. Hines wrote: > >>On 04/10/2013 01:27 AM, Michael S. Tsirkin wrote: > >>>Below is a great hig

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 04:05:34PM -0400, Michael R. Hines wrote: > On 04/10/2013 01:41 PM, Michael S. Tsirkin wrote: > >>>> > >>>>Thanks. > >>>> > >>>>However, IMHO restricting the policy to only used chunk-based is really > >

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 06:28:18PM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This allows the user to disable zero page checking during migration > > Signed-off-by: Michael R. Hines IMO this knob is too low level to expose to management. Why not disable this automa

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 11:18:38AM +0200, Paolo Bonzini wrote: > Il 11/04/2013 09:38, Michael S. Tsirkin ha scritto: > > On Wed, Apr 10, 2013 at 06:28:18PM -0400, mrhi...@linux.vnet.ibm.com wrote: > >> From: "Michael R. Hines" > >> > >> This allows

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 09:12:17AM -0400, Michael R. Hines wrote: > On 04/11/2013 03:19 AM, Michael S. Tsirkin wrote: > >On Wed, Apr 10, 2013 at 04:05:34PM -0400, Michael R. Hines wrote: > >Maybe we should just say "RDMA is incompatible with memory > >overcommit" an

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 09:19:43AM -0400, Michael R. Hines wrote: > On 04/11/2013 07:13 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 11:18:38AM +0200, Paolo Bonzini wrote: > >>Il 11/04/2013 09:38, Michael S. Tsirkin ha scritto: > >>>On Wed, Apr 10,

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 09:58:50AM -0400, Michael R. Hines wrote: > On 04/11/2013 09:48 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 09:12:17AM -0400, Michael R. Hines wrote: > >>On 04/11/2013 03:19 AM, Michael S. Tsirkin wrote: > >>>On Wed, Apr 10, 2013

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 04:15:54PM +0200, Paolo Bonzini wrote: > Il 11/04/2013 15:24, Michael R. Hines ha scritto: > > That's very accurate. Zero page scanning *after* the bulk phase > > is not very helpful in general. > > > > Are we proposing to skip is_dup_page() after the bulk phase > > has fin

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 10:57:26AM -0400, Michael R. Hines wrote: > We have hardware already with front side bus speeds of 13 GB/s. > > We also already have 5 GB/s RDMA hardware, and we will likely > have even faster RDMA hardware in the future. > > This analysis is not factoring into account the

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 04:50:21PM +0200, Paolo Bonzini wrote: > Il 11/04/2013 16:37, Michael S. Tsirkin ha scritto: > > > > pg1 -> pin -> req -> res -> rdma -> done > > pg2 -> pin -> req -> res -> rdma -> done > >

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > We want to do macvtap programming by libvirt, this patch added > a monitor command to query rx mode information. I will also > work on another patch to add QMP event notification for rx-mode > changing. Libvirt will sync the rx-mode chang

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 05:33:41PM +0200, Paolo Bonzini wrote: > Il 11/04/2013 17:18, Michael R. Hines ha scritto: > > First of all, this whole argument should not even exist for the > > following reason: > > > > Page registrations are supposed to be *rare* - once a page is > > registered, it is

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 05:47:53PM +0200, Paolo Bonzini wrote: > Il 11/04/2013 17:46, Michael S. Tsirkin ha scritto: > > > Ok, let's keep it simple. The only two things we need are: > > > > > > 1) remove the patch to disable is_dup_page > > > > &

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
an that there can't be a fast one. But if you mean to say that the current chunk based code is useless, then I'd have to agree. > > On 04/11/2013 10:37 AM, Michael S. Tsirkin wrote: > >Answer above. > > > >Here's how things are supposed to work in a pipelin

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 12:09:44PM -0400, Michael R. Hines wrote: > On 04/11/2013 11:44 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 11:18:56AM -0400, Michael R. Hines wrote: > >>First of all, > >I know it's a hard habit to break but could you &g

Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 05:28:35PM +0100, Peter Maydell wrote: > On 11 April 2013 17:10, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > This doesn't look right. The MemoryRegion system isn't > hw-specific, it's a part of the basic QEMU emulation > system which provides functionality t

Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 08:18:52PM +0200, Paolo Bonzini wrote: > Il 11/04/2013 19:14, Peter Maydell ha scritto: > > On 11 April 2013 18:09, Paolo Bonzini wrote: > >> Il 11/04/2013 18:28, Peter Maydell ha scritto: > >>> On 11 April 2013 17:10, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonz

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: > On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 04:50:21PM +0200, Paolo Bonzini wrote: > >>Il 11/04/2013 16:37, Michael S. Tsirkin ha scritto: > >>>pg1 ->

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 04:33:03PM -0400, Michael R. Hines wrote: > On 04/11/2013 03:15 PM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: > >>On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: > >>>On Thu, Apr 11, 2

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 12:53:11PM +0200, Paolo Bonzini wrote: > Il 12/04/2013 12:48, Michael S. Tsirkin ha scritto: > > 1. You have two protocols already and this does not make sense in > > version 1 of the patch. > > It makes sense if we consider it experimental (add x- in

Re: [Qemu-devel] [PATCH 0/8] rdma: migration support

2013-04-12 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 01:51:06AM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Changes since v7: > > - Ran checkpatch.pl > - Finished additional cleanup requests > - Deleted zero scanning option > - Cleaned up docs/rdma.txt > > Wiki: http://wiki.qemu.org/Features/RDM

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 09:47:08AM -0400, Michael R. Hines wrote: > Second, as I've explained, I strongly, strongly disagree with unregistering > memory for all of the aforementioned reasons - workloads do not > operate in such a manner that they can tolerate memory to be > pulled out from undernea

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 04:43:54PM +0200, Paolo Bonzini wrote: > Il 12/04/2013 13:25, Michael S. Tsirkin ha scritto: > > On Fri, Apr 12, 2013 at 12:53:11PM +0200, Paolo Bonzini wrote: > >> Il 12/04/2013 12:48, Michael S. Tsirkin ha scritto: > >>> 1. You have two p

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 10:27:24AM -0400, Michael R. Hines wrote: > On 04/14/2013 07:59 AM, Michael S. Tsirkin wrote: > >On Fri, Apr 12, 2013 at 04:43:54PM +0200, Paolo Bonzini wrote: > >>Il 12/04/2013 13:25, Michael S. Tsirkin ha scritto: > >>>On Fri, Apr 12, 2

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 12:40:10PM -0400, Michael R. Hines wrote: > On 04/14/2013 12:03 PM, Michael S. Tsirkin wrote: > >On Sun, Apr 14, 2013 at 10:27:24AM -0400, Michael R. Hines wrote: > >>On 04/14/2013 07:59 AM, Michael S. Tsirkin wrote: > >>>On Fri, Apr 12, 2

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 10:31:20AM -0400, Michael R. Hines wrote: > On 04/14/2013 04:28 AM, Michael S. Tsirkin wrote: > >On Fri, Apr 12, 2013 at 09:47:08AM -0400, Michael R. Hines wrote: > >>Second, as I've explained, I strongly, strongly disagree with unregistering &g

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 03:06:11PM -0400, Michael R. Hines wrote: > On 04/14/2013 02:30 PM, Michael S. Tsirkin wrote: > >On Sun, Apr 14, 2013 at 12:40:10PM -0400, Michael R. Hines wrote: > >>On 04/14/2013 12:03 PM, Michael S. Tsirkin wrote: > >>>On Sun, Apr 14, 2013

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 03:43:28PM -0400, Michael R. Hines wrote: > On 04/14/2013 02:51 PM, Michael S. Tsirkin wrote: > >On Sun, Apr 14, 2013 at 10:31:20AM -0400, Michael R. Hines wrote: > >>On 04/14/2013 04:28 AM, Michael S. Tsirkin wrote: > >>>On Fri, Apr 12, 2013

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 09:06:36PM -0400, Michael R. Hines wrote: > On 04/14/2013 05:10 PM, Michael S. Tsirkin wrote: > >On Sun, Apr 14, 2013 at 03:06:11PM -0400, Michael R. Hines wrote: > >>On 04/14/2013 02:30 PM, Michael S. Tsirkin wrote: > >>>On Sun, Apr 14, 2013

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-14 Thread Michael S. Tsirkin
On Sun, Apr 14, 2013 at 09:10:36PM -0400, Michael R. Hines wrote: > On 04/14/2013 05:16 PM, Michael S. Tsirkin wrote: > >On Sun, Apr 14, 2013 at 03:43:28PM -0400, Michael R. Hines wrote: > >>On 04/14/2013 02:51 PM, Michael S. Tsirkin wrote: > >>>On Sun, Apr 14, 2013

[Qemu-devel] [PATCH] acpi: move declarations from pc.h to acpi.h

2013-04-14 Thread Michael S. Tsirkin
Functions defined in acpi/ should be declared in acpi.h Signed-off-by: Michael S. Tsirkin --- arch_init.c| 1 + hw/i386/pc.c | 1 + hw/i386/pc_piix.c | 1 + include/hw/acpi/acpi.h | 10 ++ include/hw/i386/pc.h | 11 --- 5 files changed, 13

[Qemu-devel] [PULL] pci: add pci test device

2013-04-14 Thread Michael S. Tsirkin
different configurations. FAST_MMIO will be added if/when kvm supports it. Also included are minor cleanups in kvm APIs that it needs. Signed-off-by: Michael S. Tsirkin Michael S. Tsirkin (4): kvm: remove unused APIs kvm

[Qemu-devel] [PATCH] acpi.h: make it self contained

2013-04-15 Thread Michael S. Tsirkin
Headers shouldn't assume another header is included, pull in everything necessary. Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/acpi.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index 35f7e09..88f7378 100644 --- a/in

<    5   6   7   8   9   10   11   12   13   14   >