Re: [PATCH] target/i386: fix direction of "32-bit MMU" test

2024-04-01 Thread Michael Tokarev
11.03.2024 10:58, Paolo Bonzini wrote: The low bit of MMU indices for x86 TCG indicates whether the processor is in 32-bit mode and therefore linear addresses have to be masked to 32 bits. However, the index was computed incorrectly, leading to possible conflicts in the TLB for any address above

[PATCH] gitlab-ci/cirrus: switch from 'master' to 'latest'

2024-03-31 Thread Michael Tokarev
Commit ab72522797 "gitlab: switch from 'stable' to 'latest' docker container tags" switched most tags to 'latest' but missed cirrus image. Fix this now. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2256 Signed-off-by: Michael Tokarev --- .gitlab-ci.d/cirrus.yml | 2

Re: [PULL 0/5] Net patches

2024-03-31 Thread Michael Tokarev
29.03.2024 10:10, Jason Wang: Akihiko Odaki (5): virtio-net: Fix vhost virtqueue notifiers for RSS ebpf: Fix indirections table setting hw/net/net_tx_pkt: Fix virtio header without checksum offloading tap-win32: Remove unnecessary stubs Revert "tap: setting

Re: [PATCH for-9.0] Fix some typos in documentation (found by codespell)

2024-03-31 Thread Michael Tokarev
31.03.2024 19:15, Stefan Weil via wrote: Signed-off-by: Stefan Weil Reviewed-by: Michael Tokarev Wonder if I should review qemu-trivial queue for 9.0, - I think there's nothing in there by now.. /mjt

[PATCH 0/4] small linux-user/syscall:do_setsockopt() cleanups and fixes

2024-03-31 Thread Michael Tokarev
A few cleanups and fixes for linux-user/syscall:do_setsockopt(). Michael Tokarev (4): linux-user/syscall: do_setsockopt: fix SOL_ALG.ALG_SET_KEY linux-user/syscall: do_setsockopt(): make ip_mreq local to the place it is used and inline target_to_host_ip_mreq() linux-user/syscall

[PATCH 3/4] linux-user/syscall: do_setsockopt(): make ip_mreq_source local to the place where it is used

2024-03-31 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- linux-user/syscall.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 733a2b91e9..988b6422fb 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2049,7 +2049,6 @@ static

[PATCH 4/4] linux-user/syscall: do_setsockopt(): eliminate goto in switch for SO_SNDTIMEO

2024-03-31 Thread Michael Tokarev
There's identical code for SO_SNDTIMEO and SO_RCVTIMEO, currently implemented using an ugly goto into another switch case. Eliminate that using arithmetic if, making code flow more natural. Signed-off-by: Michael Tokarev --- linux-user/syscall.c | 11 --- 1 file changed, 4 insertions

[PATCH 2/4] linux-user/syscall: do_setsockopt(): make ip_mreq local to the place it is used and inline target_to_host_ip_mreq()

2024-03-31 Thread Michael Tokarev
handles TARGET_EFAULT when the address is wrong. Note: optlen here refers to target struct size, while host struct size can potentially be different. Signed-off-by: Michael Tokarev --- linux-user/syscall.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions

[PATCH v2 1/4] linux-user/syscall: do_setsockopt: fix SOL_ALG.ALG_SET_KEY

2024-03-31 Thread Michael Tokarev
linux-user: Add support for setsockopt() option SOL_ALG" Signed-off-by: Michael Tokarev --- linux-user/syscall.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) v2: fix commit message wording diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e12d969c2e..5c7728c

[PATCH] linux-user/syscall.c: fix setsockopt(SOL_ALG, ALG_SET_KEY)

2024-03-31 Thread Michael Tokarev
"linux-user: Add support for setsockopt() option SOL_ALG" Signed-off-by: Michael Tokarev diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e12d969c2e..5c7728cfd4 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2277,18 +2277,13 @@ static abi_long do_sets

Re: Backdoor in xz, should we switch compression format for tarballs?

2024-03-31 Thread Michael Tokarev
' not rush into conclusions so far. Even with this long-term control, so far it does not look like .xz format itself is somehow bad (but it can be improved for sure), or it poses a treat. I CCed Michael Tokarev because he looked at compression formats for distributing QEMU recently and may have

Re: [PULL 00/15] riscv-to-apply queue

2024-03-27 Thread Michael Tokarev
26.03.2024 12:56, Alistair Francis пишет: On Tue, Mar 26, 2024 at 7:53 PM Michael Tokarev wrote: On 24.03.2024 21:12, Daniel Henrique Barboza wrote: On 3/24/24 12:07, Michael Tokarev wrote: Unfortunately this doesn't quite work, the following changes fail to apply to 8.2: 929e521a47

Re: [PATCH trivial for-9.0] smbios: add stub for smbios_get_table_legacy()

2024-03-26 Thread Michael Tokarev
only for 'pc' machine" Reported-by: Michael Tokarev Singned-off-by: Philippe Mathieu-Daudé Signed-off-by: Igor Mammedov Reviewed-by: Michael Tokarev Thanks, /mjt

Re: [PATCH-for-9.1] hw/i386: Add a config to only build the microvm machine

2024-03-26 Thread Michael Tokarev
26.03.2024 18:58, Philippe Mathieu-Daudé: This is not enough.  This step is good already, but it lacks default machine type selection.  In debian we carry a tiny patch to make microvm the default machine type or else it crashes at startup not finding "pc" machine or one of its required devices.

Re: [PATCH-for-9.1] hw/i386: Add a config to only build the microvm machine

2024-03-26 Thread Michael Tokarev
allow the selection of alternate config in the build"), it can be built using: $ ../configure --without-default-features \ --target-list=x86_64-softmmu \ --with-devices-x86_64=microvm Inspired-by: Michael Tokarev Signed-off-by: Philippe Mat

Re: [PULL 00/15] riscv-to-apply queue

2024-03-26 Thread Michael Tokarev
On 24.03.2024 21:12, Daniel Henrique Barboza wrote: On 3/24/24 12:07, Michael Tokarev wrote: Unfortunately this doesn't quite work, the following changes fail to apply to 8.2: 929e521a47 target/riscv: always clear vstart for ldst_whole insns b46631f122 target/riscv: remove 'over' brconds

Re: [PATCH trivial for-9.0] hw/i386/fw_cfg.c: fix non-legacy smbios build

2024-03-25 Thread Michael Tokarev
25.03.2024 18:20, Igor Mammedov wrote On Mon, 25 Mar 2024 16:09:20 +0300 Michael Tokarev wrote: When building qemu with smbios but not legacy mode (eg minimal microvm build), link fails with: hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' This is because fw_cfg

Re: [PATCH] meson: Fix MESONINTROSPECT parsing

2024-03-25 Thread Michael Tokarev
25.03.2024 20:23, Peter Maydell : On Sat, 12 Aug 2023 at 13:10, Akihiko Odaki wrote: ... The problem is that Meson uses a different logic for escaping arguments in MESONINTROSPECT on Windows. I'll wait till Meson maintainers figure out how MESONINTROSPECT should be used. For details, see:

Re: [PATCH trivial for-9.0] hw/i386/fw_cfg.c: fix non-legacy smbios build

2024-03-25 Thread Michael Tokarev
25.03.2024 16:40, Philippe Mathieu-Daudé пишет: Hi Michael, On 25/3/24 14:09, Michael Tokarev wrote: When building qemu with smbios but not legacy mode (eg minimal microvm build), link fails with:    hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' This is because fw_cfg

[PATCH trivial for-9.0] hw/i386/fw_cfg.c: fix non-legacy smbios build

2024-03-25 Thread Michael Tokarev
on CONFIG_SMBIOS_LEGACY. Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine" Signed-off-by: Michael Tokarev --- hw/i386/fw_cfg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c index d802d2787f..d5e78a9183 100644 --- a/hw/i386/fw_c

Re: [PULL 00/15] riscv-to-apply queue

2024-03-24 Thread Michael Tokarev
22.03.2024 22:46, Daniel Henrique Barboza : On 3/22/24 14:16, Michael Tokarev wrote: 22.03.2024 11:53, Alistair Francis : RISC-V PR for 9.0 * Do not enable all named features by default * A range of Vector fixes * Update APLIC IDC after claiming iforce register * Remove the dependency

Re: [PULL 00/15] riscv-to-apply queue

2024-03-22 Thread Michael Tokarev
22.03.2024 11:53, Alistair Francis : RISC-V PR for 9.0 * Do not enable all named features by default * A range of Vector fixes * Update APLIC IDC after claiming iforce register * Remove the dependency of Zvfbfmin to Zfbfmin * Fix mode in riscv_tlb_fill * Fix timebase-frequency when using KVM

Re: [PULL 1/1] target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int'

2024-03-22 Thread Michael Tokarev
22.03.2024 13:03, Song Gao : qemu-system-loongarch64 assert failed with the option '-d int', the helper_idle() raise an exception EXCP_HLT, but the exception name is undefined. Signed-off-by: Song Gao Reviewed-by: Philippe Mathieu-Daudé Message-Id:

Re: [PULL 0/9] target/hppa fixes for 9.0

2024-03-21 Thread Michael Tokarev
21.03.2024 21:32, Helge Deller wrote: On 3/21/24 19:25, Sven Schnelle wrote: Michael Tokarev writes: 20.03.2024 03:32, Richard Henderson : Richard Henderson (3):     target/hppa: Fix assemble_16 insns for wide mode     target/hppa: Fix assemble_11a insns for wide mode

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-21 Thread Michael Tokarev
20.03.2024 11:36, Tao Su : monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() may have a parameter with NULL monitor pointer. Revert monitor_puts() in do_inject_x86_mce() to fix, then the fact that we send the same message to monitor and log is again more obvious. Fixes:

Re: [PULL 3/3] target/loongarch: Fix qemu-loongarch64 hang when executing 'll.d $t0, $t0, 0'

2024-03-21 Thread Michael Tokarev
20.03.2024 05:40, Song Gao : On gen_ll, if a->imm is zero, make_address_x return src1, but the load to destination may clobber src1. We use a new destination to fix this problem. Fixes: c5af6628f4be (target/loongarch: Extract make_address_i() helper) Reviewed-by: Richard Henderson

Re: [PULL 2/3] target/loongarch: Fix tlb huge page loading issue

2024-03-21 Thread Michael Tokarev
20.03.2024 05:40, Song Gao : From: Xianglai Li +if (unlikely((level == 0) || (level > 4))) { +qemu_log_mask(LOG_GUEST_ERROR, + "Attepted LDDIR with level %"PRId64"\n", level); Attempted. FWIW, it's applied already. /mjt

Re: [PULL 0/9] target/hppa fixes for 9.0

2024-03-21 Thread Michael Tokarev
20.03.2024 03:32, Richard Henderson : Richard Henderson (3): target/hppa: Fix assemble_16 insns for wide mode target/hppa: Fix assemble_11a insns for wide mode target/hppa: Fix assemble_12a insns for wide mode Sven Schnelle (6): target/hppa: ldcw,s uses static shift

change QARMA3 default for aarch64?

2024-03-21 Thread Michael Tokarev
Since commit v8.1.0-511-g399e5e7125 "target/arm: Implement FEAT_PACQARMA3", pauth-qarma3 is the default pauth scheme. However this one is very slow. When people run aarch64 code in qemu tcg, an immediate reaction is like, "this seems to be a bug somewhere", since the code run insanely slower

Re: [PATCH for-9.0 1/2] nbd/server: Fix race in draining the export

2024-03-19 Thread Michael Tokarev
14.03.2024 19:58, Kevin Wolf wrote: When draining an NBD export, nbd_drained_begin() first sets client->quiescing so that nbd_client_receive_next_request() won't start any new request coroutines. Then nbd_drained_poll() tries to makes sure that we wait for any existing request coroutines by

Re: [PATCH] ui: compile dbus-display1.c with -fPIC as necessary

2024-03-19 Thread Michael Tokarev
. This makes commit 186acfbaf7 ("tests/qtest: Depend on dbus_display1_dep") no longer relevant, as dbus-display1.c will be recompiled. Fixes: c172136ea33 ("meson: ensure dbus-display generated code is built before other units") Reviewed-by: Michael Tokarev And yes, this fixe

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-18 Thread Michael Tokarev
18.03.2024 10:35, Marc-André Lureau wrote: .. dbus-display1 is also used with static linking for the unit test. It looks like the simplest is to let the actual target decide how it is built, even if it is compiled multiple time then: - dbus_display1_lib = static_library('dbus-display1',

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-17 Thread Michael Tokarev
17.03.2024 01:19, Olaf Hering: Sat, 16 Mar 2024 22:40:14 +0300 Michael Tokarev : meson: ensure dbus-display generated code is built before other units (cherry picked from commit 1222070e772833c6875e0ca63565db12c22df39e) "static_library" is used often. Some use the 'p

Re: Regression in v7.2.10 - ui-dbus.so requires -fPIC

2024-03-16 Thread Michael Tokarev
(cherry picked from commit 1222070e772833c6875e0ca63565db12c22df39e) Signed-off-by: Michael Tokarev This has bitten me multiple times, when dbus-display1.c isn't generated promptly. So I thought it's a good pick. Apparently not :) And indeed, on master the same issue exists now, - after

Re: [PATCH 12/12] vdpa: fix network breakage after cancelling migration

2024-03-13 Thread Michael Tokarev
13.03.2024 22:10, Si-Wei Liu wrote: On 3/13/2024 11:12 AM, Michael Tokarev wrote: .. Is this a -stable material? Probably yes, the pre-requisites of this patch are PATCH #10 and #11 from this series (where SVQ_TSTATE_DISABLING gets defined and set). If yes, is it also applicable

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-13 Thread Michael Tokarev
10.03.2024 21:13, Richard Henderson wrote: On 3/9/24 08:40, Michael Tokarev wrote: ... I tried to pick this one up for stable-7.2 (since the fix is for older commit), and faced a fun issue in this change to tests/tcg/aarch64/Makefile.target, since 7.2. doesn't have CROSS_AS_HAS_ARMV9_SME yet

Re: [PATCH 12/12] vdpa: fix network breakage after cancelling migration

2024-03-13 Thread Michael Tokarev
13.03.2024 21:12, Michael Tokarev пишет: 14.02.2024 14:28, Si-Wei Liu wrote: Fix an issue where cancellation of ongoing migration ends up with no network connectivity. When canceling migration, SVQ will be switched back to the passthrough mode, but the right call fd is not programed

Re: [PATCH v2 2/2] hmat acpi: Fix out of bounds access due to missing use of indirection

2024-03-13 Thread Michael Tokarev
07.03.2024 19:03, Jonathan Cameron via wrote: With a numa set up such as -numa nodeid=0,cpus=0 \ -numa nodeid=1,memdev=mem \ -numa nodeid=2,cpus=1 and appropriate hmat_lb entries the initiator list is correctly computed and writen to HMAT as 0,2 but then the LB data is accessed using the node

Re: [PATCH 12/12] vdpa: fix network breakage after cancelling migration

2024-03-13 Thread Michael Tokarev
14.02.2024 14:28, Si-Wei Liu wrote: Fix an issue where cancellation of ongoing migration ends up with no network connectivity. When canceling migration, SVQ will be switched back to the passthrough mode, but the right call fd is not programed to the device and the svq's own call fd is still

Re: [PULL 2/3] xen: Drop out of coroutine context xen_invalidate_map_cache_entry

2024-03-13 Thread Michael Tokarev
13.03.2024 20:21, Michael Tokarev: 12.03.2024 17:27, Anthony PERARD wrote: From: Peng Fan xen_invalidate_map_cache_entry is not expected to run in a coroutine. Without this, there is crash: Hi!  Is this a stable material? (It applies cleanly and builds on 8.2 and 7.2) Actually for 7.2

Re: [PULL 2/3] xen: Drop out of coroutine context xen_invalidate_map_cache_entry

2024-03-13 Thread Michael Tokarev
12.03.2024 17:27, Anthony PERARD wrote: From: Peng Fan xen_invalidate_map_cache_entry is not expected to run in a coroutine. Without this, there is crash: Hi! Is this a stable material? (It applies cleanly and builds on 8.2 and 7.2) Thanks, /mjt

Re: [PULL 0/8] Net patches

2024-03-12 Thread Michael Tokarev
12.03.2024 14:36, Jason Wang wrote: ... Andrew Melnychenko (5): ebpf: Added eBPF map update through mmap. ebpf: Added eBPF initialization by fds. virtio-net: Added property to load eBPF RSS with fds.

Re: [PATCH v2] migration/multifd: Don't fsync when closing QIOChannelFile

2024-03-12 Thread Michael Tokarev
05.03.2024 22:56, Fabiano Rosas : Commit bc38feddeb ("io: fsync before closing a file channel") added a Fixes: bc38feddeb ("io: fsync before closing a file channel") FWIW, this is commit c05dfcb7f2 in master, not bc38feddeb. It's too late to change that now though. /mjt

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-10 Thread Michael Tokarev
10.03.2024 21:13, Richard Henderson : ... If it all applies without drama, all is well. This very fix applies and works just fine on top of 7.2, it is only the tests part (the Makefile.target fragment) which isn't, so it's kinda problematic to apply it without a test. And while figuring out

Re: [PATCH 1/2] tcg/aarch64: Fix tcg_out_cmp for test comparisons

2024-03-10 Thread Michael Tokarev
339adf2f38 isn't in any released version and hasn't been picked up for stable either, so neither of the two changes has to go to stable. Still, thank you for remembering to Cc qemu-stable@, - it is better to have extra there and reject what's not needed than to miss something important. Reviewed-b

Re: [PATCH v3] hw/scsi/lsi53c895a: add timer to scripts processing

2024-03-10 Thread Michael Tokarev
04.03.2024 19:37, Sven Schnelle : HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location under certain circumstances. As the SCSI controller and CPU are not running at the same time this loop will never finish. After some time, the check loop interrupts with a unexpected device

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-09 Thread Michael Tokarev
05.03.2024 19:39, Richard Henderson wrote: While the 8-bit input elements are sequential in the input vector, the 32-bit output elements are not sequential in the output matrix. Do not attempt to compute 2 32-bit outputs at the same time. Cc: qemu-sta...@nongnu.org Fixes: 23a5e3859f5

[PULL 00/11] Trivial patches for 2024-03-09

2024-03-09 Thread Michael Tokarev
): replay: Improve error messages about configuration conflicts char: Slightly better error reporting when chardev is in use blockdev: Fix block_resize error reporting for op blockers qerror: QERR_DEVICE_IN_USE is no longer used, drop Michael Tokarev (1): make-release: switch

[PULL 11/11] docs/acpi/bits: add some clarity and details while also improving formating

2024-03-09 Thread Michael Tokarev
From: Ani Sinha Update bios-bits docs to add more details on why a pre-OS environment for testing bioses is useful. Add author's FOSDEM talk link. Also improve the formating of the document while at it. Signed-off-by: Ani Sinha Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev

[PULL 09/11] hw/pci-bridge/cxl_upstream: Fix problem with g_steal_pointer()

2024-03-09 Thread Michael Tokarev
). Signed-off-by: Thomas Huth Reviewed-by: Jonathan Cameron Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/pci-bridge/cxl_upstream.c | 8 include/hw/cxl/cxl_cdat.h| 8 +--- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/pci-bridge/cxl_upstream.c

[PULL 03/11] hw/scsi/lsi53c895a: Fix typo in comment

2024-03-09 Thread Michael Tokarev
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/scsi/lsi53c895a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index d607a5f9fb..f8598a17f5 100644 --- a/hw

[PULL 07/11] qerror: QERR_DEVICE_IN_USE is no longer used, drop

2024-03-09 Thread Michael Tokarev
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h

[PULL 10/11] hw/mem/cxl_type3: Fix problem with g_steal_pointer()

2024-03-09 Thread Michael Tokarev
). Signed-off-by: Thomas Huth Reviewed-by: Jonathan Cameron Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/mem/cxl_type3.c| 24 include/hw/cxl/cxl_cdat.h | 9 ++--- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/hw/mem

[PULL 05/11] char: Slightly better error reporting when chardev is in use

2024-03-09 Thread Michael Tokarev
-André Lureau Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- chardev/char-fe.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/chardev/char-fe.c b/chardev/char-fe.c index 20222a4cad..66cee8475a 100644 --- a/chardev/char-fe.c +++ b/chardev/char-fe.c

[PULL 01/11] replay: Improve error messages about configuration conflicts

2024-03-09 Thread Michael Tokarev
is not supported with multiple CPUs Record/replay is not supported with -snapshot Signed-off-by: Markus Armbruster Reviewed-by: Pavel Dovgalyuk Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- replay/replay.c | 2 +- system/vl.c | 2 +- 2

[PULL 04/11] make-release: switch to .xz format by default

2024-03-09 Thread Michael Tokarev
formats is definitely extra burden too. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Hajnoczi --- scripts/make-release | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/make-release b/scripts/make-release index 9c570b87f4

[PULL 02/11] hw/vfio/pci.c: Make some structure static

2024-03-09 Thread Michael Tokarev
From: Frediano Ziglio Not used outside C module. Signed-off-by: Frediano Ziglio Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by Tokarev Signed-off-by: Michael Tokarev --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PULL 06/11] blockdev: Fix block_resize error reporting for op blockers

2024-03-09 Thread Michael Tokarev
uot;block_resize", "arguments": {"node-name": "blk1", "size":32768}} <- {"error": {"class": "GenericError", "desc": "Device '(null)' is in use"}} Broken when commit 3b1dbd11a60 made @device optional.

[PULL 08/11] hw/cxl/cxl-cdat: Fix type of buf in ct3_load_cdat()

2024-03-09 Thread Michael Tokarev
is assigned to uint8_t *buf in CDATObject, i.e. a pointer of a different type. Change the local variable to the same type as buf in CDATObject to avoid the error. Signed-off-by: Thomas Huth Reviewed-by: Jonathan Cameron Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/cxl/cxl

Re: [PATCH v2] docs/acpi/bits: add some clarity and details while also improving formating

2024-03-07 Thread Michael Tokarev
08.03.2024 07:22, Ani Sinha : Update bios-bits docs to add more details on why a pre-OS environment for testing bioses is useful. Add author's FOSDEM talk link. Also improve the formating of the document while at it. CC: qemu-triv...@nongnu.org Signed-off-by: Ani Sinha Reviewed-by: Michael

Re: [PATCH 0/3] cxl: Fix issues with g_steal_pointer()

2024-03-07 Thread Michael Tokarev
04.03.2024 13:44, Thomas Huth wrote: When setting GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_58 or higher (which we'll certainly do in the not too distant future), glib adds type safety checks to the g_steal_pointer() macro. This triggers errors in the cxl code since the pointer types do not

Re: [PATCH 0/4] hw/i386/pc: Trivial cleanups

2024-03-07 Thread Michael Tokarev
07.03.2024 21:57, Bernhard Beschow : Am 1. März 2024 18:59:32 UTC schrieb "Philippe Mathieu-Daudé" : Trivial cleanups, mostly around the 'isapc' machine. Philippe Mathieu-Daudé (4): hw/i386/pc: Remove pc_compat_1_4..1.7[] left over declarations hw/i386/pc: Use generated

Re: [PATCH] target/arm: Fix 32-bit SMOPA

2024-03-05 Thread Michael Tokarev
05.03.2024 05:31, Richard Henderson : The while the 8-bit input elements are sequential in the input vector, Nitpick: "The while the" /mjt

[PATCH] make-release: switch to .xz format by default

2024-03-04 Thread Michael Tokarev
formats is definitely extra burden too. Signed-off-by: Michael Tokarev --- scripts/make-release | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/make-release b/scripts/make-release index 9c570b87f4..6e0433de24 100755 --- a/scripts/make-release +++ b/scripts/make-release

[ANNOUNCE] QEMU 8.2.2 Stable released

2024-03-04 Thread Michael Tokarev
Changelog (stable-8.2-hash master-hash Author Name: Commmit-Subject): 11aa0b1ff1 Michael Tokarev: Update version for 8.2.2 release 21214699c2 462945cd22 Thomas Huth: chardev/char-socket: Fix TLS io channels sending too much data to the backend 2a97c05796 f0cb6828ae Thomas Huth: tests/unit/test-util

[ANNOUNCE] QEMU 7.2.10 Stable released

2024-03-04 Thread Michael Tokarev
Changelog (stable-7.2-hash master-hash Author Name: Commmit-Subject): eee83fae9d Michael Tokarev: Update version for 7.2.10 release 0ee0f9d822 2196157404 Paolo Bonzini: target/i386: the sgx_epc_get_section stub is reachable 90b1b8e0d6 b6903cbe3a Peter Maydell: tests/unit/test-blockjob: Disable

Re: [PATCH v2] docs/conf.py: Remove usage of distutils

2024-03-04 Thread Michael Tokarev
installed via pip in the venv instead, and that is using a newer version, too, according to our pythondeps.toml file. Thus we can simply drop the version check now to get rid of the distutils dependency here. Signed-off-by: Thomas Huth Reviewed-by: Michael Tokarev Thanks once again, /mjt

Re: [PATCH] docs/conf.py: Remove usage of distutils

2024-03-04 Thread Michael Tokarev
. Signed-off-by: Thomas Huth Reviewed-by: Michael Tokarev Thanks! /mjt --- docs/conf.py | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index e84a95e71c..1b2afa241c 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -29,7 +29,6

Re: [PULL 5/5] roms/hppa: Add build rules for hppa-firmware

2024-03-04 Thread Michael Tokarev
03.03.2024 08:46, del...@kernel.org : From: Helge Deller Signed-off-by: Helge Deller Suggested-by: Michael Tokarev Reviewed-by: Richard Henderson Reviewed-by: Michael Tokarev Thank you! /mjt roms/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/roms/Makefile b

Re: [PATCH] Make some structure static

2024-03-03 Thread Michael Tokarev
01.03.2024 21:56, Frediano Ziglio : Not used outside C module. Applied to trivial-patches (with subject fixup) /mjt

Re: [Stable-8.2.1 61/71] linux-user/riscv: Adjust vdso signal frame cfa offsets

2024-03-03 Thread Michael Tokarev
03.03.2024 13:33, Andreas Schwab : On Jan 28 2024, Michael Tokarev wrote: From: Richard Henderson A typo in sizeof_reg put the registers at the wrong offset. Simplify the expressions to use positive addresses from the start of uc_mcontext instead of negative addresses from the end

[Stable-8.2.2 79/82] hw/intc/Kconfig: Fix GIC settings when using "--without-default-devices"

2024-03-03 Thread Michael Tokarev
lways keep the GIC switches enabled in the --without-default-devices builds, too. Message-ID: <20240221110059.152665-1-th...@redhat.com> Tested-by: Fabiano Rosas Signed-off-by: Thomas Huth (cherry picked from commit 8bd3f84d1f6fba0edebc450be6fa2c7630584df9) Signed-off-by: Michael Tokarev diff

[Stable-8.2.2 81/82] tests/unit/test-util-sockets: Remove temporary file after test

2024-03-03 Thread Michael Tokarev
..@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth (cherry picked from commit f0cb6828ae34fb56fbb869bb3147a636d1c984ce) Signed-off-by: Michael Tokarev diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c index 63909c

[Stable-8.2.2 80/82] hw/usb/bus.c: PCAP adding 0xA in Windows version

2024-03-03 Thread Michael Tokarev
e80$@fysnet.net> [thuth: Break long line to avoid checkpatch.pl error] Signed-off-by: Thomas Huth (cherry picked from commit 5e02a4fdebc442e34c5bb05e4540f85cc6e802f0) Signed-off-by: Michael Tokarev diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 92d6ed5626..4d4c671913 100644 --- a/hw/usb/bus.c +++ b/

[Stable-8.2.2 v3 00/82] Patch Round-up for stable 8.2.2, freeze on 2024-03-02 (frozen)

2024-03-03 Thread Michael Tokarev
The following patches are queued for QEMU stable v8.2.2: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: https://wiki.qemu.org/Planning/8.2 The changes which are staging for inclusion, with the original

[Stable-8.2.2 82/82] chardev/char-socket: Fix TLS io channels sending too much data to the backend

2024-03-03 Thread Michael Tokarev
d-by: Marc-André Lureau Signed-off-by: Thomas Huth (cherry picked from commit 462945cd22d2bcd233401ed3aa167d83a8e35b05) Signed-off-by: Michael Tokarev diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 73947da188..034840593d 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket

[Stable-7.2.10 48/54] gitlab: force allow use of pip in Cirrus jobs

2024-03-02 Thread Michael Tokarev
-by: Peter Maydell (cherry picked from commit a8bf9de2f4f398315ac5340e4b88c478d5457731) Signed-off-by: Michael Tokarev diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml index 7ef6af8d33..d8cf08dc14 100644 --- a/.gitlab-ci.d/cirrus/build.yml +++ b/.gitlab-ci.d/cirrus/build.yml

[Stable-7.2.10 v3 00/54] Patch Round-up for stable 7.2.10, freeze on 2024-03-02 (frozen)

2024-03-02 Thread Michael Tokarev
The following patches are queued for QEMU stable v7.2.10: https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2 Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: https://wiki.qemu.org/Planning/7.2 The changes which are staging for inclusion, with the original

[Stable-7.2.10 51/54] test-vmstate: fix bad GTree usage, use-after-free

2024-03-02 Thread Michael Tokarev
-by: Richard W.M. Jones Reviewed-by: Richard W.M. Jones Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela (cherry picked from commit abe2c4bdb65e8dd9cb2f01c355baa394bf49a8af) Signed-off-by: Michael Tokarev diff --git a/tests/unit/test-vmstate.c b/tests/un

[Stable-7.2.10 49/54] hw/usb/bus.c: PCAP adding 0xA in Windows version

2024-03-02 Thread Michael Tokarev
e80$@fysnet.net> [thuth: Break long line to avoid checkpatch.pl error] Signed-off-by: Thomas Huth (cherry picked from commit 5e02a4fdebc442e34c5bb05e4540f85cc6e802f0) Signed-off-by: Michael Tokarev diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 92d6ed5626..4d4c671913 100644 --- a/hw/usb/bus.c +++ b/

[Stable-7.2.10 52/54] tests/qtest/display-vga-test: Add proper checks if a device is available

2024-03-02 Thread Michael Tokarev
Message-Id: <20230130104446.1286773-4-th...@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth (cherry picked from commit f2e57851b831922625f9d364d78c11a0258331a6) Signed-off-by: Michael Tokarev diff --git a/tests/qtest/display-vga-test.c b/tests/qtest/display-vga-test.c index ace3bb

[Stable-7.2.10 54/54] target/i386: the sgx_epc_get_section stub is reachable

2024-03-02 Thread Michael Tokarev
lo Bonzini Message-ID: <20220201190941.106001-1-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini (cherry picked from commit 219615740425d9683588207b40a365e6741691a6) Signed-off-by: Michael Tokarev diff --git a/hw/i386/sgx-stub.c b/hw/i386/sgx-stub.c index 26833eb233..16b1dfd90b 100644 -

[Stable-7.2.10 50/54] tests/unit/test-util-sockets: Remove temporary file after test

2024-03-02 Thread Michael Tokarev
..@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth (cherry picked from commit f0cb6828ae34fb56fbb869bb3147a636d1c984ce) Signed-off-by: Michael Tokarev diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c index 63909c

[Stable-7.2.10 53/54] tests/unit/test-blockjob: Disable complete_in_standby test

2024-03-02 Thread Michael Tokarev
8) Signed-off-by: Michael Tokarev diff --git a/tests/unit/test-blockjob.c b/tests/unit/test-blockjob.c index c0426bd10c..a130f6fefb 100644 --- a/tests/unit/test-blockjob.c +++ b/tests/unit/test-blockjob.c @@ -531,6 +531,13 @@ int main(int argc, char **argv) g_test_add_func("/blockjob/

Re: [PATCH] Make some structure static

2024-03-01 Thread Michael Tokarev
01.03.2024 21:56, Frediano Ziglio wrote: Not used outside C module. Please add a sensible subject prefix, like "hw/vfio/pci.c: ". With that, Revieved-by: Michael Tokarev This is a good candidate for trivial-patches@ too (Cc'd). /mjt Signed-off-by: Frediano Ziglio --- hw/

Re: [Stable-7.2.10 v1 00/47] Patch Round-up for stable 7.2.10, freeze on 2024-03-02

2024-03-01 Thread Michael Tokarev
01.03.2024 22:04, Cole Robinson wrote: Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: ... Response might be too late, But here's the patches we are still carrying in Fedora 38 7.2.X and the explanations Nah, we've whole day left before the freeze. * abe2c4bdb6

Re: [PATCH v2 1/6] libqos/virtio.c: init all elems in qvring_indirect_desc_setup()

2024-03-01 Thread Michael Tokarev
17.02.2024 22:26, Daniel Henrique Barboza: diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c index 410513225f..4f39124eba 100644 --- a/tests/qtest/libqos/virtio.c +++ b/tests/qtest/libqos/virtio.c @@ -280,14 +280,27 @@ QVRingIndirectDesc

[Stable-8.2.2 75/78] target/i386: leave the A20 bit set in the final NPT walk

2024-02-28 Thread Michael Tokarev
("target/i386: Use atomic operations for pte updates", 2022-10-18) Signed-off-by: Paolo Bonzini (cherry picked from commit b5a9de3259f4c791bde2faff086dd5737625e41e) Signed-off-by: Michael Tokarev diff --git a/target/i386/tcg/sysemu/excp_helper.c b/target/i386/tcg/sysemu/excp_help

[Stable-8.2.2 69/78] hw/nvme: fix invalid endian conversion

2024-02-28 Thread Michael Tokarev
-by: Klaus Jensen Reviewed-by: Minwoo Im Message-ID: <20240222-fix-sriov-numcntl-v1-1-d60bea5e7...@samsung.com> Signed-off-by: Philippe Mathieu-Daudé (cherry picked from commit d2b5bb860e6c17442ad95cc275feb07c1665be5c) Signed-off-by: Michael Tokarev diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c

[Stable-8.2.2 66/78] target/ppc: Fix crash on machine check caused by ifetch

2024-02-28 Thread Michael Tokarev
-by: Nicholas Piggin (cherry picked from commit c8fd9667e5975fe2e70a906e125a758737eab707) Signed-off-by: Michael Tokarev diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index a42743a3e0..9b8fd69b85 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -1312,6 +13

[Stable-8.2.2 v2 00/78] Patch Round-up for stable 8.2.2, freeze on 2024-03-02

2024-02-28 Thread Michael Tokarev
The following patches are queued for QEMU stable v8.2.2: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: https://wiki.qemu.org/Planning/8.2 Please respond here or CC qemu-sta...@nongnu.org on any additional

[Stable-8.2.2 74/78] target/i386: remove unnecessary/wrong application of the A20 mask

2024-02-28 Thread Michael Tokarev
rom commit a28fe7dc1939333c81b895cdced81c69eb7c5ad0) Signed-off-by: Michael Tokarev diff --git a/target/i386/tcg/sysemu/excp_helper.c b/target/i386/tcg/sysemu/excp_helper.c index 38c313abc9..89df61eec6 100644 --- a/target/i386/tcg/sysemu/excp_helper.c +++ b/target/i386/tcg/sysemu/excp_helper.c @@ -164,8 +164,7 @@ s

[Stable-8.2.2 77/78] tests/vm: avoid re-building the VM images all the time

2024-02-28 Thread Michael Tokarev
oject/qemu/-/issues/2118 Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20240227144335.1196131-4-alex.ben...@linaro.org> (cherry picked from commit 151b7dba391fab64cc008a1fdba6ddcf6f8c39c8) Signed-off-by: Michael Tokarev diff --git a/tests/vm/Makefile.include b/tests/vm/Makefi

[Stable-8.2.2 64/78] .gitlab-ci.d/windows.yml: Drop msys2-32bit job

2024-02-28 Thread Michael Tokarev
homas Huth Reviewed-by: Alex Bennée Message-id: 20240220165602.135695-1-peter.mayd...@linaro.org (cherry picked from commit 5cd3ae4903e33982e7a9bbd04674af517e796d6e) Signed-off-by: Michael Tokarev diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml index 5c1e385dc8..8fc08218d2 100644 ---

[Stable-8.2.2 65/78] target/ppc: Fix lxv/stxv MSR facility check

2024-02-28 Thread Michael Tokarev
ssues/1769 Reviewed-by: Harsh Prateek Bora Tested-by: Harsh Prateek Bora Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: Nicholas Piggin (cherry picked from commit 2cc0e449d17310877fb28a942d4627ad22bb68ea) Signed-off-by: Michael Tokarev diff --git a/target/ppc/tra

[Stable-8.2.2 62/78] docs/system: Update description for input grab key

2024-02-28 Thread Michael Tokarev
From: Tianlan Zhou Input grab key should be Ctrl-Alt-g, not just Ctrl-Alt. Fixes: f8d2c9369b ("sdl: use ctrl-alt-g as grab hotkey") Signed-off-by: Tianlan Zhou Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (cherry picked f

[Stable-8.2.2 76/78] tests/vm: update openbsd image to 7.4

2024-02-28 Thread Michael Tokarev
Bennée Message-Id: <20240227144335.1196131-5-alex.ben...@linaro.org> (cherry picked from commit 8467ac75b3b7207a49a1c6c7b87f0f7d2d0cea18) Signed-off-by: Michael Tokarev diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 85c5bb3536..85c9863633 100755 --- a/tests/vm/openbsd +++ b/te

[Stable-8.2.2 78/78] gitlab: force allow use of pip in Cirrus jobs

2024-02-28 Thread Michael Tokarev
-by: Peter Maydell (cherry picked from commit a8bf9de2f4f398315ac5340e4b88c478d5457731) Signed-off-by: Michael Tokarev diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml index 29d55c4aa3..43dd52dd19 100644 --- a/.gitlab-ci.d/cirrus/build.yml +++ b/.gitlab-ci.d/cirrus/build.yml

[Stable-8.2.2 68/78] update edk2 binaries to edk2-stable202402

2024-02-28 Thread Michael Tokarev
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann (cherry picked from commit 658178c3d4e95b3f4106e25ec5a209356e339032) Signed-off-by: Michael Tokarev diff --git a/pc-bios/edk2-aarch64-code.fd.bz2 b/pc-bios/edk2-aarch64-code.fd.bz2 index fdcf89022a..5d0a57173d 100644 Binary files a/pc-bios/edk2

[Stable-8.2.2 71/78] target/i386: mask high bits of CR3 in 32-bit mode

2024-02-28 Thread Michael Tokarev
Fixes: 4a1e9d4d11c ("target/i386: Use atomic operations for pte updates", 2022-10-18) Signed-off-by: Paolo Bonzini (cherry picked from commit 68fb78d7d5723066ec2cacee7d25d67a4143b42f) Signed-off-by: Michael Tokarev diff --git a/target/i386/tcg/sysemu/excp_helper.c b/target/i386/

<    1   2   3   4   5   6   7   8   9   10   >